)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cb7ad814cb7542d516a941e8681928b9933492ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7733d683_572f5a37","updated":"2021-12-22 13:36:02.000000000","message":"recheck","commit_id":"93c61d73dfc57235feee950bdc9f98c7988e03f0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"47c96b50438781d0c8becd3f61cd3904a473e823","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f2cb288f_b133c0a8","updated":"2021-12-22 13:46:06.000000000","message":"recheck","commit_id":"93c61d73dfc57235feee950bdc9f98c7988e03f0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4c79a3ab7e3d8f41d749794a278bc08b704fb1f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dc99b50b_9e7f30b5","updated":"2022-01-13 22:36:20.000000000","message":"Thank you for the review... Addressed the comments in the latest PS. Please check the modifications inline :)","commit_id":"9300dcdb8d06b58197f281bcf30ba694f3ea32ec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"065809450e89a99a3c4cddfcb8e4e0a14d80910e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b48a690f_b1fd4f26","updated":"2022-02-01 18:47:14.000000000","message":"Thanks for the patch Carlos! Several comments/enhancement requests inline.. Don\u0027t we need to fix up the share filters as well and remove these? Doing that would require adding a release note to call out the adjustments to share filters.","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e74c30de_99ee46e1","updated":"2022-02-22 15:26:22.000000000","message":"Thanks for reviewing, Goutham\nPlease check the changes inline","commit_id":"aa372738e7d215cd2bc3d4a7103e5614900bf706"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f58d97accdad663a056f01ba510a815674f8ec27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"feee294c_95ec58b5","updated":"2022-02-22 20:38:21.000000000","message":"Thank you for revisiting, Goutham\nPlease check answers and changes inline","commit_id":"9b1fad1a1c6aca90d89843c9bc10a13f6e5f2241"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b1b864c9db4c43f553ca550ed36dfeb4560d6b51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a053a4cb_d12d1cc7","updated":"2022-02-22 18:45:57.000000000","message":"question regarding back-off rate, the rest of the changes look good - thanks Carlos!","commit_id":"9b1fad1a1c6aca90d89843c9bc10a13f6e5f2241"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b60eb8a690faec29217b7cf139e79bacc0ee9ea1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e4afcd26_da86a49b","updated":"2022-02-23 18:22:21.000000000","message":"LGTM, thank you Carlos","commit_id":"a391d35c4508b0e88ada5c20d1df62f915cc5b57"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"be32c2af6cd87e66384062212b3b641e6f44add6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c004dbd7_e930a5f5","updated":"2022-02-24 21:00:29.000000000","message":"Looks good, thanks Carlos :)","commit_id":"a391d35c4508b0e88ada5c20d1df62f915cc5b57"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5b1879438bbdf30e2f8246b5cf7b2c46c23b4b8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"41c5728c_2f3380f7","updated":"2022-02-22 21:07:26.000000000","message":"Thanks for the changes - lets see what the CI thinks of this! :)","commit_id":"a391d35c4508b0e88ada5c20d1df62f915cc5b57"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6aa4aaadb8ee4220f5f018526051c81f00945d10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"aea5beb8_d69c8db8","updated":"2022-02-25 07:11:14.000000000","message":"recheck","commit_id":"a391d35c4508b0e88ada5c20d1df62f915cc5b57"}],"manila/privsep/common.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f653deab0e1243e14a4d5c7bd78502fb11a839cc","unresolved":true,"context_lines":[{"line_number":32,"context_line":"                raise"},{"line_number":33,"context_line":"            LOG.exception(\"Recovering from a failed execute. \""},{"line_number":34,"context_line":"                          \"Try number %s\", tries)"},{"line_number":35,"context_line":"            time.sleep(tries ** 2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"162ad450_bba7324d","line":35,"updated":"2021-10-05 21:41:03.000000000","message":"line EOF (:","commit_id":"93c61d73dfc57235feee950bdc9f98c7988e03f0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                raise"},{"line_number":33,"context_line":"            LOG.exception(\"Recovering from a failed execute. \""},{"line_number":34,"context_line":"                          \"Try number %s\", tries)"},{"line_number":35,"context_line":"            time.sleep(tries ** 2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0dc04804_63805461","line":35,"in_reply_to":"162ad450_bba7324d","updated":"2022-02-22 15:26:22.000000000","message":"Done","commit_id":"93c61d73dfc57235feee950bdc9f98c7988e03f0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"065809450e89a99a3c4cddfcb8e4e0a14d80910e","unresolved":true,"context_lines":[{"line_number":32,"context_line":"                raise"},{"line_number":33,"context_line":"            LOG.exception(\"Recovering from a failed execute. \""},{"line_number":34,"context_line":"                          \"Try number %s\", tries)"},{"line_number":35,"context_line":"            time.sleep(tries ** 2)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5599ec8b_09eb8061","line":35,"range":{"start_line":35,"start_character":12,"end_line":35,"end_character":34},"updated":"2022-02-01 18:47:14.000000000","message":"why not use the common retry decorator we have to do this? It\u0027s got a lot of features, including an exponential backoff you want to have here..","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f58d97accdad663a056f01ba510a815674f8ec27","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                raise"},{"line_number":33,"context_line":"            LOG.exception(\"Recovering from a failed execute. \""},{"line_number":34,"context_line":"                          \"Try number %s\", tries)"},{"line_number":35,"context_line":"            time.sleep(tries ** 2)"}],"source_content_type":"text/x-python","patch_set":8,"id":"343f2b88_81c344c6","line":35,"range":{"start_line":35,"start_character":12,"end_line":35,"end_character":34},"in_reply_to":"5599ec8b_09eb8061","updated":"2022-02-22 20:38:21.000000000","message":"Done","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b1b864c9db4c43f553ca550ed36dfeb4560d6b51","unresolved":true,"context_lines":[{"line_number":22,"context_line":"def execute_with_retries(action, action_args, max_retries):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @manila_utils.retry("},{"line_number":25,"context_line":"        retry_param\u003dexception.ProcessExecutionError, backoff_rate\u003d3,"},{"line_number":26,"context_line":"        retries\u003dmax_retries)"},{"line_number":27,"context_line":"    def execute():"},{"line_number":28,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"300afbef_b9e84cab","line":25,"range":{"start_line":25,"start_character":53,"end_line":25,"end_character":67},"updated":"2022-02-22 18:45:57.000000000","message":"any reason to change this to 3?\n\nWe\u0027ll be waiting on errors a lot longer with our default retries; with the backoff rate as 2:\n\nRun\tSeconds\n0\t0.000\n1\t1.000\n2\t3.000\n3\t7.000\n4\t15.000\n5\t31.000\n6\t63.000\n7\t127.000\n8\t255.000\n9\t511.000\n\n\nvs 3:\n\n\nRun\tSeconds\n0\t0.000\n1\t1.000\n2\t4.000\n3\t13.000\n4\t40.000\n5\t121.000\n6\t364.000\n7\t1093.000\n8\t3280.000\n9\t9841.000","commit_id":"9b1fad1a1c6aca90d89843c9bc10a13f6e5f2241"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f58d97accdad663a056f01ba510a815674f8ec27","unresolved":false,"context_lines":[{"line_number":22,"context_line":"def execute_with_retries(action, action_args, max_retries):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @manila_utils.retry("},{"line_number":25,"context_line":"        retry_param\u003dexception.ProcessExecutionError, backoff_rate\u003d3,"},{"line_number":26,"context_line":"        retries\u003dmax_retries)"},{"line_number":27,"context_line":"    def execute():"},{"line_number":28,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fd756086_41ad9993","line":25,"range":{"start_line":25,"start_character":53,"end_line":25,"end_character":67},"in_reply_to":"300afbef_b9e84cab","updated":"2022-02-22 20:38:21.000000000","message":"Not a specific reason behind... 2 works. thank you!","commit_id":"9b1fad1a1c6aca90d89843c9bc10a13f6e5f2241"}],"manila/privsep/filesystem.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"065809450e89a99a3c4cddfcb8e4e0a14d80910e","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":25,"context_line":"def e2fsck(device_path):"},{"line_number":26,"context_line":"    processutils.execute(\u0027e2fsck\u0027, \u0027-y\u0027, \u0027-f\u0027, device_path)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"}],"source_content_type":"text/x-python","patch_set":8,"id":"2959e61b_72e12fc6","line":26,"range":{"start_line":26,"start_character":3,"end_line":26,"end_character":4},"updated":"2022-02-01 18:47:14.000000000","message":"nit: in all these methods, you can return to calling method, allows consistent traceability..","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":25,"context_line":"def e2fsck(device_path):"},{"line_number":26,"context_line":"    processutils.execute(\u0027e2fsck\u0027, \u0027-y\u0027, \u0027-f\u0027, device_path)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a750e2a_e11b9fbd","line":26,"range":{"start_line":26,"start_character":3,"end_line":26,"end_character":4},"in_reply_to":"2959e61b_72e12fc6","updated":"2022-02-22 15:26:22.000000000","message":"Done","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"065809450e89a99a3c4cddfcb8e4e0a14d80910e","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":35,"context_line":"def make_filesystem(ext_version, device_name):"},{"line_number":36,"context_line":"    processutils.execute(\u0027mkfs.%s\u0027 % ext_version, device_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"e5b20a9b_6cffe051","line":36,"range":{"start_line":36,"start_character":25,"end_line":36,"end_character":48},"updated":"2022-02-01 18:47:14.000000000","message":"nit: like you have elsewhere, use f-string perhaps","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":35,"context_line":"def make_filesystem(ext_version, device_name):"},{"line_number":36,"context_line":"    processutils.execute(\u0027mkfs.%s\u0027 % ext_version, device_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"23c0955b_46c91042","line":36,"range":{"start_line":36,"start_character":25,"end_line":36,"end_character":48},"in_reply_to":"e5b20a9b_6cffe051","updated":"2022-02-22 15:26:22.000000000","message":"Done","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"}],"manila/privsep/lvm.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"065809450e89a99a3c4cddfcb8e4e0a14d80910e","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":30,"context_line":"def lvcreate(lv_size, lv_name, vg_name, mirrors\u003d0, region_size\u003d0):"},{"line_number":31,"context_line":"    size_str \u003d \u0027%sG\u0027 % lv_size"},{"line_number":32,"context_line":"    extra_params \u003d []"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    if mirrors:"}],"source_content_type":"text/x-python","patch_set":8,"id":"59ac25ee_39ba5814","line":31,"range":{"start_line":31,"start_character":15,"end_line":31,"end_character":30},"updated":"2022-02-01 18:47:14.000000000","message":"f string on line 40 can eliminate the need for this variable, seeing that you\u0027re using one on line 26 above","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":30,"context_line":"def lvcreate(lv_size, lv_name, vg_name, mirrors\u003d0, region_size\u003d0):"},{"line_number":31,"context_line":"    size_str \u003d \u0027%sG\u0027 % lv_size"},{"line_number":32,"context_line":"    extra_params \u003d []"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    if mirrors:"}],"source_content_type":"text/x-python","patch_set":8,"id":"70729ef2_9d4babb7","line":31,"range":{"start_line":31,"start_character":15,"end_line":31,"end_character":30},"in_reply_to":"59ac25ee_39ba5814","updated":"2022-02-22 15:26:22.000000000","message":"Done","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"}],"manila/privsep/os.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0ddee45f76d600bf4ea5f83aa6353066e479b365","unresolved":true,"context_lines":[{"line_number":52,"context_line":"def mount(device_name, mount_path):"},{"line_number":53,"context_line":"    processutils.execute(\u0027mount\u0027, device_name, mount_path)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def list_mounts():"},{"line_number":57,"context_line":"    out, err \u003d processutils.execute(\u0027mount\u0027, \u0027-l\u0027)"},{"line_number":58,"context_line":"    return out, err"}],"source_content_type":"text/x-python","patch_set":3,"id":"7dd9d02a_8647e708","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":0},"updated":"2022-01-07 18:45:08.000000000","message":"decorator needed here?","commit_id":"9300dcdb8d06b58197f281bcf30ba694f3ea32ec"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4c79a3ab7e3d8f41d749794a278bc08b704fb1f6","unresolved":false,"context_lines":[{"line_number":52,"context_line":"def mount(device_name, mount_path):"},{"line_number":53,"context_line":"    processutils.execute(\u0027mount\u0027, device_name, mount_path)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def list_mounts():"},{"line_number":57,"context_line":"    out, err \u003d processutils.execute(\u0027mount\u0027, \u0027-l\u0027)"},{"line_number":58,"context_line":"    return out, err"}],"source_content_type":"text/x-python","patch_set":3,"id":"f43076d4_b28379cc","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":0},"in_reply_to":"7dd9d02a_8647e708","updated":"2022-01-13 22:36:20.000000000","message":"nice catch! done :)","commit_id":"9300dcdb8d06b58197f281bcf30ba694f3ea32ec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"065809450e89a99a3c4cddfcb8e4e0a14d80910e","unresolved":true,"context_lines":[{"line_number":29,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":30,"context_line":"def data_definition_check_support(src_str, dest_str):"},{"line_number":31,"context_line":"    processutils.execute("},{"line_number":32,"context_line":"        \u0027dd\u0027, \u0027count\u003d0\u0027, \u0027if\u003d%s\u0027 % src_str, \u0027of\u003d%s\u0027 % dest_str, \u0027iflag\u003ddirect\u0027,"},{"line_number":33,"context_line":"        \u0027oflag\u003ddirect\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"58c8485f_8a156bba","line":32,"range":{"start_line":32,"start_character":25,"end_line":32,"end_character":42},"updated":"2022-02-01 18:47:14.000000000","message":"nit: cleaner as f\u0027if\u003d{src_str}\u0027","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":30,"context_line":"def data_definition_check_support(src_str, dest_str):"},{"line_number":31,"context_line":"    processutils.execute("},{"line_number":32,"context_line":"        \u0027dd\u0027, \u0027count\u003d0\u0027, \u0027if\u003d%s\u0027 % src_str, \u0027of\u003d%s\u0027 % dest_str, \u0027iflag\u003ddirect\u0027,"},{"line_number":33,"context_line":"        \u0027oflag\u003ddirect\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f8b4c8d_750c2c1a","line":32,"range":{"start_line":32,"start_character":25,"end_line":32,"end_character":42},"in_reply_to":"58c8485f_8a156bba","updated":"2022-02-22 15:26:22.000000000","message":"Done","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"065809450e89a99a3c4cddfcb8e4e0a14d80910e","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":30,"context_line":"def data_definition_check_support(src_str, dest_str):"},{"line_number":31,"context_line":"    processutils.execute("},{"line_number":32,"context_line":"        \u0027dd\u0027, \u0027count\u003d0\u0027, \u0027if\u003d%s\u0027 % src_str, \u0027of\u003d%s\u0027 % dest_str, \u0027iflag\u003ddirect\u0027,"},{"line_number":33,"context_line":"        \u0027oflag\u003ddirect\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"}],"source_content_type":"text/x-python","patch_set":8,"id":"4c3ca0db_a5076838","line":33,"range":{"start_line":30,"start_character":4,"end_line":33,"end_character":23},"updated":"2022-02-01 18:47:14.000000000","message":"make this method handle the errors and return a boolean... \n\ndef is_data_definition_direct_io_supported(**)","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":30,"context_line":"def data_definition_check_support(src_str, dest_str):"},{"line_number":31,"context_line":"    processutils.execute("},{"line_number":32,"context_line":"        \u0027dd\u0027, \u0027count\u003d0\u0027, \u0027if\u003d%s\u0027 % src_str, \u0027of\u003d%s\u0027 % dest_str, \u0027iflag\u003ddirect\u0027,"},{"line_number":33,"context_line":"        \u0027oflag\u003ddirect\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"}],"source_content_type":"text/x-python","patch_set":8,"id":"25ff6c1c_542c6c8a","line":33,"range":{"start_line":30,"start_character":4,"end_line":33,"end_character":23},"in_reply_to":"4c3ca0db_a5076838","updated":"2022-02-22 15:26:22.000000000","message":"Done","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":30,"context_line":"def data_definition_check_support(src_str, dest_str):"},{"line_number":31,"context_line":"    processutils.execute("},{"line_number":32,"context_line":"        \u0027dd\u0027, \u0027count\u003d0\u0027, \u0027if\u003d%s\u0027 % src_str, \u0027of\u003d%s\u0027 % dest_str, \u0027iflag\u003ddirect\u0027,"},{"line_number":33,"context_line":"        \u0027oflag\u003ddirect\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"}],"source_content_type":"text/x-python","patch_set":8,"id":"68dc4917_ee478190","line":33,"range":{"start_line":30,"start_character":4,"end_line":33,"end_character":23},"in_reply_to":"4c3ca0db_a5076838","updated":"2022-02-22 15:26:22.000000000","message":"Done","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"065809450e89a99a3c4cddfcb8e4e0a14d80910e","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":37,"context_line":"def data_definition(src_str, dest_str, size_in_g, use_direct_io\u003dFalse):"},{"line_number":38,"context_line":"    extra_flags \u003d []"},{"line_number":39,"context_line":"    if use_direct_io:"},{"line_number":40,"context_line":"        extra_flags +\u003d [\u0027iflag\u003ddirect\u0027, \u0027oflag\u003ddirect\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"607930f5_6298945b","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":19},"updated":"2022-02-01 18:47:14.000000000","message":":D","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":37,"context_line":"def data_definition(src_str, dest_str, size_in_g, use_direct_io\u003dFalse):"},{"line_number":38,"context_line":"    extra_flags \u003d []"},{"line_number":39,"context_line":"    if use_direct_io:"},{"line_number":40,"context_line":"        extra_flags +\u003d [\u0027iflag\u003ddirect\u0027, \u0027oflag\u003ddirect\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"cdd2ef31_54dd8d1e","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":19},"in_reply_to":"607930f5_6298945b","updated":"2022-02-22 15:26:22.000000000","message":":D","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b1b864c9db4c43f553ca550ed36dfeb4560d6b51","unresolved":true,"context_lines":[{"line_number":32,"context_line":"def is_data_definition_direct_io_supported(src_str, dest_str):"},{"line_number":33,"context_line":"    try:"},{"line_number":34,"context_line":"        processutils.execute("},{"line_number":35,"context_line":"            \u0027dd\u0027, \u0027count\u003d0\u0027, f\u0027if\u003d{src_str}\u0027, \u0027of\u003d%s\u0027 % dest_str,"},{"line_number":36,"context_line":"            \u0027iflag\u003ddirect\u0027, \u0027oflag\u003ddirect\u0027)"},{"line_number":37,"context_line":"        is_direct_io_supported \u003d True"},{"line_number":38,"context_line":"    except exception.ProcessExecutionError:"}],"source_content_type":"text/x-python","patch_set":11,"id":"a629319e_8591ba49","line":35,"range":{"start_line":35,"start_character":46,"end_line":35,"end_character":64},"updated":"2022-02-22 18:45:57.000000000","message":"f\u0027of\u003d{dest_str}\u0027","commit_id":"9b1fad1a1c6aca90d89843c9bc10a13f6e5f2241"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f58d97accdad663a056f01ba510a815674f8ec27","unresolved":false,"context_lines":[{"line_number":32,"context_line":"def is_data_definition_direct_io_supported(src_str, dest_str):"},{"line_number":33,"context_line":"    try:"},{"line_number":34,"context_line":"        processutils.execute("},{"line_number":35,"context_line":"            \u0027dd\u0027, \u0027count\u003d0\u0027, f\u0027if\u003d{src_str}\u0027, \u0027of\u003d%s\u0027 % dest_str,"},{"line_number":36,"context_line":"            \u0027iflag\u003ddirect\u0027, \u0027oflag\u003ddirect\u0027)"},{"line_number":37,"context_line":"        is_direct_io_supported \u003d True"},{"line_number":38,"context_line":"    except exception.ProcessExecutionError:"}],"source_content_type":"text/x-python","patch_set":11,"id":"78ebddf6_ee9963cb","line":35,"range":{"start_line":35,"start_character":46,"end_line":35,"end_character":64},"in_reply_to":"a629319e_8591ba49","updated":"2022-02-22 20:38:21.000000000","message":"Done","commit_id":"9b1fad1a1c6aca90d89843c9bc10a13f6e5f2241"}],"manila/share/drivers/lvm.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0ddee45f76d600bf4ea5f83aa6353066e479b365","unresolved":true,"context_lines":[{"line_number":33,"context_line":"from manila import exception"},{"line_number":34,"context_line":"from manila.i18n import _"},{"line_number":35,"context_line":"from manila.privsep import common as privsep_common"},{"line_number":36,"context_line":"from manila.privsep import filesystem"},{"line_number":37,"context_line":"from manila.privsep import lvm"},{"line_number":38,"context_line":"from manila.privsep import os as os_routines"},{"line_number":39,"context_line":"from manila.share import driver"}],"source_content_type":"text/x-python","patch_set":3,"id":"9bf713ce_a876fe17","line":36,"range":{"start_line":36,"start_character":27,"end_line":36,"end_character":37},"updated":"2022-01-07 18:45:08.000000000","message":"maybe call these privsep_filesystem, privsep_lvm, and privsep_os -- provides a bit more context","commit_id":"9300dcdb8d06b58197f281bcf30ba694f3ea32ec"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4c79a3ab7e3d8f41d749794a278bc08b704fb1f6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from manila import exception"},{"line_number":34,"context_line":"from manila.i18n import _"},{"line_number":35,"context_line":"from manila.privsep import common as privsep_common"},{"line_number":36,"context_line":"from manila.privsep import filesystem"},{"line_number":37,"context_line":"from manila.privsep import lvm"},{"line_number":38,"context_line":"from manila.privsep import os as os_routines"},{"line_number":39,"context_line":"from manila.share import driver"}],"source_content_type":"text/x-python","patch_set":3,"id":"eddba467_88e7a3aa","line":36,"range":{"start_line":36,"start_character":27,"end_line":36,"end_character":37},"in_reply_to":"9bf713ce_a876fe17","updated":"2022-01-13 22:36:20.000000000","message":"nice suggestion! thanks","commit_id":"9300dcdb8d06b58197f281bcf30ba694f3ea32ec"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"065809450e89a99a3c4cddfcb8e4e0a14d80910e","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            out, err \u003d privsep_lvm.list_vgs_get_name()"},{"line_number":78,"context_line":"        except processutils.ProcessExecutionError:"},{"line_number":79,"context_line":"            raise"},{"line_number":80,"context_line":"        volume_groups \u003d out.split()"},{"line_number":81,"context_line":"        if self.configuration.lvm_share_volume_group not in volume_groups:"},{"line_number":82,"context_line":"            msg \u003d (_(\"Share volume group %s doesn\u0027t exist.\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"16ac5dba_849d7255","line":79,"range":{"start_line":79,"start_character":12,"end_line":79,"end_character":17},"updated":"2022-02-01 18:47:14.000000000","message":"raise appropriate ShareBackendException?","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            out, err \u003d privsep_lvm.list_vgs_get_name()"},{"line_number":78,"context_line":"        except processutils.ProcessExecutionError:"},{"line_number":79,"context_line":"            raise"},{"line_number":80,"context_line":"        volume_groups \u003d out.split()"},{"line_number":81,"context_line":"        if self.configuration.lvm_share_volume_group not in volume_groups:"},{"line_number":82,"context_line":"            msg \u003d (_(\"Share volume group %s doesn\u0027t exist.\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"0b961e4a_54d573db","line":79,"range":{"start_line":79,"start_character":12,"end_line":79,"end_character":17},"in_reply_to":"16ac5dba_849d7255","updated":"2022-02-22 15:26:22.000000000","message":"Done","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"065809450e89a99a3c4cddfcb8e4e0a14d80910e","unresolved":true,"context_lines":[{"line_number":98,"context_line":"                rsize \u003d int(2 ** math.ceil(math.log(terras) / math.log(2)))"},{"line_number":99,"context_line":"                # NOTE(vish): Next power of two for region size. See:"},{"line_number":100,"context_line":"                #             http://red.ht/U2BPOD"},{"line_number":101,"context_line":"                region_size \u003d six.text_type(rsize)"},{"line_number":102,"context_line":"        action_args \u003d ["},{"line_number":103,"context_line":"            share[\u0027size\u0027], share[\u0027name\u0027],"},{"line_number":104,"context_line":"            self.configuration.lvm_share_volume_group, mirrors, region_size]"}],"source_content_type":"text/x-python","patch_set":8,"id":"55102b85_9db46ec7","line":101,"range":{"start_line":101,"start_character":30,"end_line":101,"end_character":50},"updated":"2022-02-01 18:47:14.000000000","message":"str(rsize) while you\u0027re at it","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                rsize \u003d int(2 ** math.ceil(math.log(terras) / math.log(2)))"},{"line_number":99,"context_line":"                # NOTE(vish): Next power of two for region size. See:"},{"line_number":100,"context_line":"                #             http://red.ht/U2BPOD"},{"line_number":101,"context_line":"                region_size \u003d six.text_type(rsize)"},{"line_number":102,"context_line":"        action_args \u003d ["},{"line_number":103,"context_line":"            share[\u0027size\u0027], share[\u0027name\u0027],"},{"line_number":104,"context_line":"            self.configuration.lvm_share_volume_group, mirrors, region_size]"}],"source_content_type":"text/x-python","patch_set":8,"id":"42f3d34d_9e9be511","line":101,"range":{"start_line":101,"start_character":30,"end_line":101,"end_character":50},"in_reply_to":"55102b85_9db46ec7","updated":"2022-02-22 15:26:22.000000000","message":"Done","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"065809450e89a99a3c4cddfcb8e4e0a14d80910e","unresolved":true,"context_lines":[{"line_number":99,"context_line":"                # NOTE(vish): Next power of two for region size. See:"},{"line_number":100,"context_line":"                #             http://red.ht/U2BPOD"},{"line_number":101,"context_line":"                region_size \u003d six.text_type(rsize)"},{"line_number":102,"context_line":"        action_args \u003d ["},{"line_number":103,"context_line":"            share[\u0027size\u0027], share[\u0027name\u0027],"},{"line_number":104,"context_line":"            self.configuration.lvm_share_volume_group, mirrors, region_size]"},{"line_number":105,"context_line":"        privsep_common.execute_with_retries("},{"line_number":106,"context_line":"            privsep_lvm.lvcreate, action_args,"},{"line_number":107,"context_line":"            self.configuration.num_shell_tries)"}],"source_content_type":"text/x-python","patch_set":8,"id":"b34cfd16_8b7643fb","line":104,"range":{"start_line":102,"start_character":8,"end_line":104,"end_character":76},"updated":"2022-02-01 18:47:14.000000000","message":"list formatting: https://docs.openstack.org/hacking/latest/user/hacking.html#dictionaries-lists","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                # NOTE(vish): Next power of two for region size. See:"},{"line_number":100,"context_line":"                #             http://red.ht/U2BPOD"},{"line_number":101,"context_line":"                region_size \u003d six.text_type(rsize)"},{"line_number":102,"context_line":"        action_args \u003d ["},{"line_number":103,"context_line":"            share[\u0027size\u0027], share[\u0027name\u0027],"},{"line_number":104,"context_line":"            self.configuration.lvm_share_volume_group, mirrors, region_size]"},{"line_number":105,"context_line":"        privsep_common.execute_with_retries("},{"line_number":106,"context_line":"            privsep_lvm.lvcreate, action_args,"},{"line_number":107,"context_line":"            self.configuration.num_shell_tries)"}],"source_content_type":"text/x-python","patch_set":8,"id":"d3d00be8_b2665f81","line":104,"range":{"start_line":102,"start_character":8,"end_line":104,"end_character":76},"in_reply_to":"b34cfd16_8b7643fb","updated":"2022-02-22 15:26:22.000000000","message":"Done","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"065809450e89a99a3c4cddfcb8e4e0a14d80910e","unresolved":true,"context_lines":[{"line_number":158,"context_line":"            privsep_filesystem.e2fsck(device_path)"},{"line_number":159,"context_line":"            privsep_filesystem.tune2fs(device_path)"},{"line_number":160,"context_line":"        except processutils.ProcessExecutionError:"},{"line_number":161,"context_line":"            raise"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":164,"context_line":"        self._create_snapshot(context, snapshot)"}],"source_content_type":"text/x-python","patch_set":8,"id":"60d5d77a_5e712a72","line":161,"range":{"start_line":161,"start_character":12,"end_line":161,"end_character":17},"updated":"2022-02-01 18:47:14.000000000","message":"raise ShareBackendException?","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            privsep_filesystem.e2fsck(device_path)"},{"line_number":159,"context_line":"            privsep_filesystem.tune2fs(device_path)"},{"line_number":160,"context_line":"        except processutils.ProcessExecutionError:"},{"line_number":161,"context_line":"            raise"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":164,"context_line":"        self._create_snapshot(context, snapshot)"}],"source_content_type":"text/x-python","patch_set":8,"id":"b9d2f31c_f199d8ea","line":161,"range":{"start_line":161,"start_character":12,"end_line":161,"end_character":17},"in_reply_to":"60d5d77a_5e712a72","updated":"2022-02-22 15:26:22.000000000","message":"Done","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"065809450e89a99a3c4cddfcb8e4e0a14d80910e","unresolved":true,"context_lines":[{"line_number":248,"context_line":"            out, err \u003d privsep_lvm.get_vgs("},{"line_number":249,"context_line":"                self.configuration.lvm_share_volume_group)"},{"line_number":250,"context_line":"        except processutils.ProcessExecutionError:"},{"line_number":251,"context_line":"            raise"},{"line_number":252,"context_line":"        total_size \u003d re.findall(r\"VSize\\s[0-9.]+g\", out)[0][6:-1]"},{"line_number":253,"context_line":"        free_size \u003d re.findall(r\"VFree\\s[0-9.]+g\", out)[0][6:-1]"},{"line_number":254,"context_line":"        return [{"}],"source_content_type":"text/x-python","patch_set":8,"id":"436dadd4_41609cbd","line":251,"range":{"start_line":251,"start_character":12,"end_line":251,"end_character":17},"updated":"2022-02-01 18:47:14.000000000","message":"raise ShareBackendException","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            out, err \u003d privsep_lvm.get_vgs("},{"line_number":249,"context_line":"                self.configuration.lvm_share_volume_group)"},{"line_number":250,"context_line":"        except processutils.ProcessExecutionError:"},{"line_number":251,"context_line":"            raise"},{"line_number":252,"context_line":"        total_size \u003d re.findall(r\"VSize\\s[0-9.]+g\", out)[0][6:-1]"},{"line_number":253,"context_line":"        free_size \u003d re.findall(r\"VFree\\s[0-9.]+g\", out)[0][6:-1]"},{"line_number":254,"context_line":"        return [{"}],"source_content_type":"text/x-python","patch_set":8,"id":"8097bbd1_1a5eea14","line":251,"range":{"start_line":251,"start_character":12,"end_line":251,"end_character":17},"in_reply_to":"436dadd4_41609cbd","updated":"2022-02-22 15:26:22.000000000","message":"Done","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"065809450e89a99a3c4cddfcb8e4e0a14d80910e","unresolved":true,"context_lines":[{"line_number":318,"context_line":"            try:"},{"line_number":319,"context_line":"                privsep_os.rmdir(mount_path)"},{"line_number":320,"context_line":"            except exception.ProcessExecutionError:"},{"line_number":321,"context_line":"                raise"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def ensure_shares(self, context, shares):"},{"line_number":324,"context_line":"        updates \u003d {}"}],"source_content_type":"text/x-python","patch_set":8,"id":"c5028efd_7e8b90bc","line":321,"range":{"start_line":321,"start_character":16,"end_line":321,"end_character":21},"updated":"2022-02-01 18:47:14.000000000","message":"raise ShareBackendException","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            try:"},{"line_number":319,"context_line":"                privsep_os.rmdir(mount_path)"},{"line_number":320,"context_line":"            except exception.ProcessExecutionError:"},{"line_number":321,"context_line":"                raise"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def ensure_shares(self, context, shares):"},{"line_number":324,"context_line":"        updates \u003d {}"}],"source_content_type":"text/x-python","patch_set":8,"id":"a265ffb5_dbde9135","line":321,"range":{"start_line":321,"start_character":16,"end_line":321,"end_character":21},"in_reply_to":"c5028efd_7e8b90bc","updated":"2022-02-22 15:26:22.000000000","message":"Done","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"065809450e89a99a3c4cddfcb8e4e0a14d80910e","unresolved":true,"context_lines":[{"line_number":386,"context_line":"        mount_path \u003d self._get_mount_path(share_or_snapshot)"},{"line_number":387,"context_line":"        self._execute(\u0027mkdir\u0027, \u0027-p\u0027, mount_path)"},{"line_number":388,"context_line":"        try:"},{"line_number":389,"context_line":"            # TODO(carloss): fix check_exit_code"},{"line_number":390,"context_line":"            privsep_os.mount(device_name, mount_path)"},{"line_number":391,"context_line":"            privsep_os.chmod(\u0027777\u0027, mount_path)"},{"line_number":392,"context_line":"        except exception.ProcessExecutionError:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3479442b_f3ed0572","line":389,"range":{"start_line":389,"start_character":12,"end_line":389,"end_character":48},"updated":"2022-02-01 18:47:14.000000000","message":"this seems like a bool/int parameter to processutils\u0027s execute method that defaults to [0] (implying bool: True or, always check the exit code unless told not to with check_exit_code\u003dFalse).. so in a sense, use of check_exit_code in these calls was redundant, so you can drop this TODO.. \nhttps://github.com/openstack/oslo.concurrency/blob/5397838f4117300a509bff474dfcdd60b5993677/oslo_concurrency/processutils.py#L335-L339","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        mount_path \u003d self._get_mount_path(share_or_snapshot)"},{"line_number":387,"context_line":"        self._execute(\u0027mkdir\u0027, \u0027-p\u0027, mount_path)"},{"line_number":388,"context_line":"        try:"},{"line_number":389,"context_line":"            # TODO(carloss): fix check_exit_code"},{"line_number":390,"context_line":"            privsep_os.mount(device_name, mount_path)"},{"line_number":391,"context_line":"            privsep_os.chmod(\u0027777\u0027, mount_path)"},{"line_number":392,"context_line":"        except exception.ProcessExecutionError:"}],"source_content_type":"text/x-python","patch_set":8,"id":"69b32bf4_95080eca","line":389,"range":{"start_line":389,"start_character":12,"end_line":389,"end_character":48},"in_reply_to":"3479442b_f3ed0572","updated":"2022-02-22 15:26:22.000000000","message":"Ack. Thanks!","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"065809450e89a99a3c4cddfcb8e4e0a14d80910e","unresolved":true,"context_lines":[{"line_number":418,"context_line":"                srcstr, deststr, (size_in_g * 1024),"},{"line_number":419,"context_line":"                use_direct_io\u003duse_direct_io)"},{"line_number":420,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":421,"context_line":"            raise"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":424,"context_line":"        device_name \u003d self._get_local_path(share)"}],"source_content_type":"text/x-python","patch_set":8,"id":"d5994ac4_1da48362","line":421,"range":{"start_line":421,"start_character":12,"end_line":421,"end_character":17},"updated":"2022-02-01 18:47:14.000000000","message":"raise ShareBackendException","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18ec23f064c14e2a280c2d2f1681faf63e0d9cc1","unresolved":false,"context_lines":[{"line_number":418,"context_line":"                srcstr, deststr, (size_in_g * 1024),"},{"line_number":419,"context_line":"                use_direct_io\u003duse_direct_io)"},{"line_number":420,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":421,"context_line":"            raise"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":424,"context_line":"        device_name \u003d self._get_local_path(share)"}],"source_content_type":"text/x-python","patch_set":8,"id":"170c2d58_42ab4c32","line":421,"range":{"start_line":421,"start_character":12,"end_line":421,"end_character":17},"in_reply_to":"d5994ac4_1da48362","updated":"2022-02-22 15:26:22.000000000","message":"Done","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"}],"manila/tests/share/drivers/test_lvm.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3ac49292f7b35086465538663b2a78c848796636","unresolved":true,"context_lines":[{"line_number":389,"context_line":"        ]"},{"line_number":390,"context_line":"        self.assertEqual(expected_exec, fake_utils.fake_execute_get_log())"},{"line_number":391,"context_line":"        privsep_common.execute_with_retries("},{"line_number":392,"context_line":"            mock_lv_create, lv_create_args, )"},{"line_number":393,"context_line":"        filesystem.e2fsck.assert_called_once_with(device_path)"},{"line_number":394,"context_line":"        filesystem.tune2fs.assert_called_once_with(device_path)"},{"line_number":395,"context_line":"        os_routines.mount.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":8,"id":"38eb521f_11332ca7","line":392,"range":{"start_line":392,"start_character":43,"end_line":392,"end_character":44},"updated":"2022-02-01 18:51:07.000000000","message":"max retries missing here","commit_id":"e7e368728bc4c215c82fc1d2d67274f75b54e48e"}]}