)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7921a331b1b5f529db558de7bae409748fb1006e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1c3b4faa_1541b157","updated":"2021-10-15 20:29:32.000000000","message":"LGTM. Do you intend to backport it? If yes, could you please add a release note? ","commit_id":"b8ee70cc6e95bbf6004f38d52ba43b011919c90e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9d36b18d771cd184203df7d84698bf745ece5582","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a26bdcd2_78d09939","updated":"2021-10-15 18:52:31.000000000","message":"Thanks for reviewing, Goutham :)\nPlease check the changes inline","commit_id":"b8ee70cc6e95bbf6004f38d52ba43b011919c90e"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"daef2b7d37e411e758223052114589671f85193d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3ddc7e44_bd35ecb8","updated":"2021-10-15 22:53:12.000000000","message":"recheck","commit_id":"b8ee70cc6e95bbf6004f38d52ba43b011919c90e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"feec8a43706ec647a668277a71fea271e4d57776","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"37ab162b_b14c43b0","in_reply_to":"1c3b4faa_1541b157","updated":"2021-10-18 13:25:08.000000000","message":"Yes, it\u0027d be a good fix to have in older branches","commit_id":"b8ee70cc6e95bbf6004f38d52ba43b011919c90e"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"15cbdc6468b6bb057ce4ba39113f9c336865fd0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1be86014_72f0a353","updated":"2021-10-18 16:04:58.000000000","message":"LGTM -- thanks, Carlos!\n\nThe CephFS-NFS job failure is not related to this change in export location setup.  There is a problem doing ssh over IPv6 to the guest VM in scenario tests.","commit_id":"43ebc12fb53546a286ac6180db52ee8bbb775b1a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"533399c0b6f5157be42e055f87650ea31e376abc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b376b3eb_869f5986","updated":"2021-10-25 23:46:36.000000000","message":"Thanks Carlos!","commit_id":"43ebc12fb53546a286ac6180db52ee8bbb775b1a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"feec8a43706ec647a668277a71fea271e4d57776","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4ded30a7_00bd629d","updated":"2021-10-18 13:25:08.000000000","message":"Thanks for revisiting.\nAdded the release note","commit_id":"43ebc12fb53546a286ac6180db52ee8bbb775b1a"}],"manila/share/drivers/cephfs/driver.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"2210506cd2485112a4b973e5d94cb5c06ab3026a","unresolved":true,"context_lines":[{"line_number":990,"context_line":"        for export_ip in self.export_ips:"},{"line_number":991,"context_line":"            server_address \u003d ("},{"line_number":992,"context_line":"                hostname if export_ip \u003d\u003d hostname"},{"line_number":993,"context_line":"                else driver_helpers.escaped_address(export_ip))"},{"line_number":994,"context_line":"            export_path \u003d \"{server_address}:{mount_path}\".format("},{"line_number":995,"context_line":"                server_address\u003dserver_address, mount_path\u003dsubvolume_path)"},{"line_number":996,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"54175078_443b9e4d","line":993,"updated":"2021-10-14 11:38:38.000000000","message":"I wonder if, instead of checking whether the export_ip exactly matches the hostname, you could just catch an exception from escaped_address (raised by ipaddress.ip_address()) and build the server_address from the original value of export_ip.","commit_id":"c79e797e9d6e56f07115e0b427bc0e6d2766a979"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8ae0887a48c652b3f6e0234f740e902437c6bcff","unresolved":true,"context_lines":[{"line_number":990,"context_line":"        for export_ip in self.export_ips:"},{"line_number":991,"context_line":"            server_address \u003d ("},{"line_number":992,"context_line":"                hostname if export_ip \u003d\u003d hostname"},{"line_number":993,"context_line":"                else driver_helpers.escaped_address(export_ip))"},{"line_number":994,"context_line":"            export_path \u003d \"{server_address}:{mount_path}\".format("},{"line_number":995,"context_line":"                server_address\u003dserver_address, mount_path\u003dsubvolume_path)"},{"line_number":996,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6f289be3_7624c8fc","line":993,"in_reply_to":"54175078_443b9e4d","updated":"2021-10-14 11:59:21.000000000","message":"yes, that\u0027s a nice idea! Thanks, Tom! :)","commit_id":"c79e797e9d6e56f07115e0b427bc0e6d2766a979"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7d36d6378fe82a928e69b3f3260ae95f9bad88f","unresolved":true,"context_lines":[{"line_number":986,"context_line":""},{"line_number":987,"context_line":"    def get_export_locations(self, share, subvolume_path):"},{"line_number":988,"context_line":"        export_locations \u003d []"},{"line_number":989,"context_line":"        hostname \u003d socket.gethostname()"},{"line_number":990,"context_line":"        for export_ip in self.export_ips:"},{"line_number":991,"context_line":"            # Try to escape the export ip. If it fails, means that the"},{"line_number":992,"context_line":"            # `cephfs_ganesha_server_ip` wasn\u0027t possibly set and the used"}],"source_content_type":"text/x-python","patch_set":2,"id":"6e072812_c10ed4af","line":989,"range":{"start_line":989,"start_character":0,"end_line":989,"end_character":39},"updated":"2021-10-15 18:36:33.000000000","message":"this isn\u0027t necessary; self.export_ips will be a single element list (set to the hostname of the manila-share node) if the deployment hasn\u0027t overridden \"cephfs_ganesha_export_ips\".","commit_id":"1acfe5c6dbce4b093fb603e4dcc4b0e98ba3cf31"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9d36b18d771cd184203df7d84698bf745ece5582","unresolved":false,"context_lines":[{"line_number":986,"context_line":""},{"line_number":987,"context_line":"    def get_export_locations(self, share, subvolume_path):"},{"line_number":988,"context_line":"        export_locations \u003d []"},{"line_number":989,"context_line":"        hostname \u003d socket.gethostname()"},{"line_number":990,"context_line":"        for export_ip in self.export_ips:"},{"line_number":991,"context_line":"            # Try to escape the export ip. If it fails, means that the"},{"line_number":992,"context_line":"            # `cephfs_ganesha_server_ip` wasn\u0027t possibly set and the used"}],"source_content_type":"text/x-python","patch_set":2,"id":"1bd4b189_5856ff84","line":989,"range":{"start_line":989,"start_character":0,"end_line":989,"end_character":39},"in_reply_to":"6e072812_c10ed4af","updated":"2021-10-15 18:52:31.000000000","message":"Ack","commit_id":"1acfe5c6dbce4b093fb603e4dcc4b0e98ba3cf31"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7d36d6378fe82a928e69b3f3260ae95f9bad88f","unresolved":true,"context_lines":[{"line_number":994,"context_line":"            try:"},{"line_number":995,"context_line":"                server_address \u003d driver_helpers.escaped_address(export_ip)"},{"line_number":996,"context_line":"            except ValueError:"},{"line_number":997,"context_line":"                server_address \u003d hostname"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":"            export_path \u003d \"{server_address}:{mount_path}\".format("},{"line_number":1000,"context_line":"                server_address\u003dserver_address, mount_path\u003dsubvolume_path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"50200044_e5fd89ea","line":997,"range":{"start_line":997,"start_character":33,"end_line":997,"end_character":41},"updated":"2021-10-15 18:36:33.000000000","message":"export_ip","commit_id":"1acfe5c6dbce4b093fb603e4dcc4b0e98ba3cf31"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9d36b18d771cd184203df7d84698bf745ece5582","unresolved":false,"context_lines":[{"line_number":994,"context_line":"            try:"},{"line_number":995,"context_line":"                server_address \u003d driver_helpers.escaped_address(export_ip)"},{"line_number":996,"context_line":"            except ValueError:"},{"line_number":997,"context_line":"                server_address \u003d hostname"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":"            export_path \u003d \"{server_address}:{mount_path}\".format("},{"line_number":1000,"context_line":"                server_address\u003dserver_address, mount_path\u003dsubvolume_path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d5ab2078_497eeab9","line":997,"range":{"start_line":997,"start_character":33,"end_line":997,"end_character":41},"in_reply_to":"50200044_e5fd89ea","updated":"2021-10-15 18:52:31.000000000","message":"Done","commit_id":"1acfe5c6dbce4b093fb603e4dcc4b0e98ba3cf31"}]}