)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"fd1b8d1d1054df0d4cae26bae08e5c675be38e95","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Besjana Gjika \u003cbesa8383@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-10-22 16:42:21 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deletes the six library and all its usages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The manila/utils.py is still using six library and some of its methods, which are useless as Python 2 is no more used."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c5af2d02_c1806625","line":7,"updated":"2021-10-28 14:37:44.000000000","message":"nit: Perhaps add the file name to the title here? Otherwise this sounds like you are deleting the six library form everywhere in this repo. If this is indeed the last occurrence of the library here then you can instead state that as well. :)","commit_id":"8b360fb9d096518eb04a0a4b9d5c28dd694261bf"},{"author":{"_account_id":34133,"name":"Besjana Gjika","display_name":"B Gj","email":"besa8383@gmail.com","username":"mbeas"},"change_message_id":"76e8c3cecd07a362202cbdb328ab625122c003ed","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Besjana Gjika \u003cbesa8383@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-10-22 16:42:21 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deletes the six library and all its usages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The manila/utils.py is still using six library and some of its methods, which are useless as Python 2 is no more used."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"44396274_b65692d2","line":7,"in_reply_to":"c5af2d02_c1806625","updated":"2021-10-29 12:03:20.000000000","message":"Done","commit_id":"8b360fb9d096518eb04a0a4b9d5c28dd694261bf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34133,"name":"Besjana Gjika","display_name":"B Gj","email":"besa8383@gmail.com","username":"mbeas"},"change_message_id":"58165b2d9df7266bc5af1698eee6f9e7117efc1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ed03868f_771aaf05","updated":"2021-10-27 08:38:31.000000000","message":"\u003e Patch Set 1:\n\u003e \n\u003e Build failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\u003e \n\u003e - DellEMC_Unity_Manila_dhss_true https://elab-os-logsrv.delllabs.net/36/815136/1/check/DellEMC_Unity_Manila_dhss_true/06c00bb/DellEMC_Unity_Manila_dhss_true/52 : FAILURE in 13m 51s\n\u003e - DellEMC_Unity_Manila_dhss_false https://elab-os-logsrv.delllabs.net/36/815136/1/check/DellEMC_Unity_Manila_dhss_false/a77aac0/DellEMC_Unity_Manila_dhss_false/55 : FAILURE in 12m 24s\n\u003e \n\u003e Leave a comment with \u0027run-DellEMC Unity CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_Unity_CI\n\nrun-DellEMC Unity CI","commit_id":"8b360fb9d096518eb04a0a4b9d5c28dd694261bf"},{"author":{"_account_id":34133,"name":"Besjana Gjika","display_name":"B Gj","email":"besa8383@gmail.com","username":"mbeas"},"change_message_id":"8c8d817b75698be5a0d1d97ba4ad8baa33a4922d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d10580d5_8adc467d","updated":"2021-10-27 06:02:19.000000000","message":"\u003e Patch Set 1:\n\u003e \n\u003e Build failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\u003e \n\u003e - DellEMC_Unity_Manila_dhss_true https://elab-os-logsrv.delllabs.net/36/815136/1/check/DellEMC_Unity_Manila_dhss_true/44a0f27/DellEMC_Unity_Manila_dhss_true/48 : FAILURE in 14m 04s\n\u003e - DellEMC_Unity_Manila_dhss_false https://elab-os-logsrv.delllabs.net/36/815136/1/check/DellEMC_Unity_Manila_dhss_false/b8ce393/DellEMC_Unity_Manila_dhss_false/51 : FAILURE in 11m 44s\n\u003e \n\u003e Leave a comment with \u0027run-DellEMC Unity CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_Unity_CI\n\nrun-DellEMC Unity CI","commit_id":"8b360fb9d096518eb04a0a4b9d5c28dd694261bf"},{"author":{"_account_id":34133,"name":"Besjana Gjika","display_name":"B Gj","email":"besa8383@gmail.com","username":"mbeas"},"change_message_id":"b9f47e99743a978180a95167405f3396ac3e75f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e3da6ea9_5dd89081","updated":"2021-10-27 06:01:25.000000000","message":"\u003e Patch Set 1:\n\u003e \n\u003e Build failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\u003e \n\u003e - DellEMC_VNX_Manila https://elab-os-logsrv.delllabs.net/36/815136/1/check/DellEMC_VNX_Manila/ac45d2f/DellEMC_VNX_Manila/22 : FAILURE in 12m 31s\n\u003e \n\u003e Leave a comment with \u0027run-DellEMC VNX CI\u0027 to trigger a recheck. For more information about this CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VNX_CI\n\nrun-DellEMC VNX CI","commit_id":"8b360fb9d096518eb04a0a4b9d5c28dd694261bf"},{"author":{"_account_id":34133,"name":"Besjana Gjika","display_name":"B Gj","email":"besa8383@gmail.com","username":"mbeas"},"change_message_id":"43d062f8bd1a3ba5ad3ae507e70648dc8ad0fb74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e8643e50_258a908a","updated":"2021-10-27 08:15:29.000000000","message":"\u003e Patch Set 1:\n\u003e \n\u003e Build failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\u003e \n\u003e - DellEMC_VNX_Manila https://elab-os-logsrv.delllabs.net/36/815136/1/check/DellEMC_VNX_Manila/b08786c/DellEMC_VNX_Manila/24 : FAILURE in 12m 01s\n\u003e \n\u003e Leave a comment with \u0027run-DellEMC VNX CI\u0027 to trigger a recheck. For more information about this CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VNX_CI\n\nrun-DellEMC VNX CI","commit_id":"8b360fb9d096518eb04a0a4b9d5c28dd694261bf"},{"author":{"_account_id":34133,"name":"Besjana Gjika","display_name":"B Gj","email":"besa8383@gmail.com","username":"mbeas"},"change_message_id":"696d40991ac7a6e636af22a1df76516a5bf60c51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"10c4df8b_12be9e11","updated":"2021-10-27 09:21:07.000000000","message":"\u003e Patch Set 1:\n\u003e \n\u003e Build succeeded. For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\u003e * NexentaStor5_Manila_NFS http://openstack.deiter.ru/aaf864307c6ff20c3b5cc1ef422b55c2/refs-changes-36-815136-1/ns5_manila : SUCCESS in 1h 39m 35s\n\u003e \n\u003e Leave a comment with run-nexentaci to trigger a recheck. For more information about Nexenta CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/Nexenta_CI\n\nrun-nexentaci","commit_id":"8b360fb9d096518eb04a0a4b9d5c28dd694261bf"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"39ab65db8936de77f74e87528319544dcbe2fcb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1cb9da85_9a160d65","updated":"2021-10-26 16:24:11.000000000","message":"Kudos on your first contribution. Code looks good, seems there was a timeout in the LVM gate. Let\u0027s recheck.","commit_id":"8b360fb9d096518eb04a0a4b9d5c28dd694261bf"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"fd260760604eb0589450ba8649da6993afd5b776","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9d7b01a4_09414255","updated":"2021-10-27 14:21:53.000000000","message":"No need to run the third party CI. Thanks B Gj, it looks good.","commit_id":"8b360fb9d096518eb04a0a4b9d5c28dd694261bf"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"fd1b8d1d1054df0d4cae26bae08e5c675be38e95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c60715b2_15206d97","updated":"2021-10-28 14:37:44.000000000","message":"Thank you for working on this Besjana! I left a note inline about the commit message but that\u0027s just nit-picking, overall this looks good to me, well done! :)","commit_id":"8b360fb9d096518eb04a0a4b9d5c28dd694261bf"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"115a62c4c3621f6157e12fd6b5921db50871e553","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8071f11e_9a067052","updated":"2021-10-26 16:23:20.000000000","message":"recheck","commit_id":"8b360fb9d096518eb04a0a4b9d5c28dd694261bf"},{"author":{"_account_id":34133,"name":"Besjana Gjika","display_name":"B Gj","email":"besa8383@gmail.com","username":"mbeas"},"change_message_id":"76e8c3cecd07a362202cbdb328ab625122c003ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9671e783_7170761a","in_reply_to":"9d7b01a4_09414255","updated":"2021-10-29 12:03:20.000000000","message":"Thank you Victoria.","commit_id":"8b360fb9d096518eb04a0a4b9d5c28dd694261bf"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"555fd91c04fd1239368b6f7923d306fd46bbb52b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"31f4465f_4f195a06","updated":"2021-12-01 05:37:45.000000000","message":"LGTM, let\u0027s merge this.","commit_id":"b62081e138e80d5a17ef9495a744ac5869c554e2"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"d66f9bcb8a92b70415d1fcf9d87c36199cdf59b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dec77fd5_41e65619","updated":"2021-11-02 10:01:36.000000000","message":"Looks good","commit_id":"b62081e138e80d5a17ef9495a744ac5869c554e2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"36efab5919a18c9e3dfb5e898529f4a0ec81415e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e7470e3c_0c3f4d5b","updated":"2021-11-30 11:30:44.000000000","message":"Looks good to me, thanks Besjana :)","commit_id":"b62081e138e80d5a17ef9495a744ac5869c554e2"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4900308d30d2655bea5f2ead7f1608cf0f443ec3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3198864b_86d63288","updated":"2021-10-29 19:20:57.000000000","message":"Thanks again Besjana, looks good to me! :) ","commit_id":"b62081e138e80d5a17ef9495a744ac5869c554e2"},{"author":{"_account_id":34133,"name":"Besjana Gjika","display_name":"B Gj","email":"besa8383@gmail.com","username":"mbeas"},"change_message_id":"76e8c3cecd07a362202cbdb328ab625122c003ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e5fe009_c70095fc","updated":"2021-10-29 12:03:20.000000000","message":"Yes Maari, you are right. This way it is more correct. I changed the title.","commit_id":"b62081e138e80d5a17ef9495a744ac5869c554e2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ada9e8d2cf8ff359a1be373be19a1477bf9dda51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f4219b28_02fc0334","updated":"2021-10-29 14:56:16.000000000","message":"recheck","commit_id":"b62081e138e80d5a17ef9495a744ac5869c554e2"}],"manila/utils.py":[{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"bb707d93d913168cc610b036563ebadf9226fa63","unresolved":true,"context_lines":[{"line_number":290,"context_line":"                if six.PY3:"},{"line_number":291,"context_line":"                    member_type \u003d inspect.isfunction"},{"line_number":292,"context_line":"                else:"},{"line_number":293,"context_line":"                    member_type \u003d inspect.ismethod"},{"line_number":294,"context_line":"                for method, func in inspect.getmembers(clz, member_type):"},{"line_number":295,"context_line":"                    setattr("},{"line_number":296,"context_line":"                        clz, method,"}],"source_content_type":"text/x-python","patch_set":1,"id":"64a91539_f934261a","side":"PARENT","line":293,"updated":"2021-10-26 14:21:32.000000000","message":"I think you need to declare `member_type \u003d inspect.ismethod` directly without the `else` block since you are not checking for six.PY3","commit_id":"34d209484366cd921e052d37c5f9daef5e97af20"},{"author":{"_account_id":34133,"name":"Besjana Gjika","display_name":"B Gj","email":"besa8383@gmail.com","username":"mbeas"},"change_message_id":"76e8c3cecd07a362202cbdb328ab625122c003ed","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                if six.PY3:"},{"line_number":291,"context_line":"                    member_type \u003d inspect.isfunction"},{"line_number":292,"context_line":"                else:"},{"line_number":293,"context_line":"                    member_type \u003d inspect.ismethod"},{"line_number":294,"context_line":"                for method, func in inspect.getmembers(clz, member_type):"},{"line_number":295,"context_line":"                    setattr("},{"line_number":296,"context_line":"                        clz, method,"}],"source_content_type":"text/x-python","patch_set":1,"id":"99268a67_9538d53c","side":"PARENT","line":293,"in_reply_to":"64a91539_f934261a","updated":"2021-10-29 12:03:20.000000000","message":"Ack","commit_id":"34d209484366cd921e052d37c5f9daef5e97af20"}]}