)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6d83cd6ad2ecfc804719ae26ecdd211f06e42fac","unresolved":true,"context_lines":[{"line_number":12,"context_line":"e.g. manila share-replica-create share_id \\"},{"line_number":13,"context_line":"\t--scheduler-hints \"only_host\u003dhost@backend#pool\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"OnlyHostFilter (https://review.opendev.org/c/openstack/manila/+/813293)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1950313"},{"line_number":18,"context_line":"Change-Id: I2e6d8709fc02df16622bdc910127fa489835db38"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a175e390_e211a61c","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":71},"updated":"2021-11-18 22:20:12.000000000","message":"Sorry I didn\u0027t pay attention to it before...\nI believe you could have a Depends-On relationship here [1].\nThat is one of the ways we currently have as a community standard to signalize that one change depends on another one (being it cross-project or not).\n\n[1] https://docs.openstack.org/contributors/code-and-documentation/patch-best-practices.html#depends-on-tag","commit_id":"e68d51ecc05bbae650598d53a931d2365335be0c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d6f6963a203e0f93e956e90c9364f13794c6d8e0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"e.g. manila share-replica-create share_id \\"},{"line_number":13,"context_line":"\t--scheduler-hints \"only_host\u003dhost@backend#pool\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"OnlyHostFilter (https://review.opendev.org/c/openstack/manila/+/813293)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1950313"},{"line_number":18,"context_line":"Change-Id: I2e6d8709fc02df16622bdc910127fa489835db38"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4613797b_2e6d8e23","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":71},"in_reply_to":"a175e390_e211a61c","updated":"2021-11-20 09:27:25.000000000","message":"Done","commit_id":"e68d51ecc05bbae650598d53a931d2365335be0c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"37c301863416bee3818f5437e3809d933f2f5336","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"65d4ca5c_ba888e4b","updated":"2021-11-10 10:06:00.000000000","message":"This PR is considered only after https://review.opendev.org/c/openstack/manila/+/813293 will be merged. Please review","commit_id":"a1fdb0b72f93e52d8d22afbd3e3fdde111d5c46f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"278b48e8796ab595ec56eafeec8c6885b4b8c4dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5bdfa075_cdf1c737","updated":"2021-11-11 15:30:45.000000000","message":"Hi, Kiran!\nThanks for working on this change.\nThis is a good enhancement for manila. Could you please add a release note for this change?","commit_id":"b62aa3387130a2f557e86f05a30b2b09ddb5a4e7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c821c8f95310cbc9b666d767a81f90d0c9c26c5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e513db1a_0f977ce6","updated":"2021-11-12 11:06:06.000000000","message":"python-manilaclient PR \u003d https://review.opendev.org/c/openstack/python-manilaclient/+/817739","commit_id":"b62aa3387130a2f557e86f05a30b2b09ddb5a4e7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8569c0a204fed6096bc91f642fcfcde787e58eb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ed72c12e_d66d8f2a","updated":"2021-11-15 01:27:32.000000000","message":"thanks for this change, Kiran Pawar!\nhere are some comments inline.\ni recommend  add new releasenote here.","commit_id":"b62aa3387130a2f557e86f05a30b2b09ddb5a4e7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"1d90e1261b9c9ac54c1660a6f1cb113d585f8fcf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"76dd1459_849f1040","in_reply_to":"5bdfa075_cdf1c737","updated":"2021-11-11 17:56:31.000000000","message":"Hi Carlos,\nI can update releasenotes added in https://review.opendev.org/c/openstack/manila/+/813293.\n\nCan you please approve/review/merge above PR ? I will then either update releasenotes added in that PR or add new file here.","commit_id":"b62aa3387130a2f557e86f05a30b2b09ddb5a4e7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9d4c5f553f409d9729c77a7e21405ed865ecd952","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"86a1b7b8_81d391ec","in_reply_to":"ed72c12e_d66d8f2a","updated":"2021-11-15 11:13:01.000000000","message":"Fixed","commit_id":"b62aa3387130a2f557e86f05a30b2b09ddb5a4e7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5c11071119fcafd6a5d5cea3ac9bf539b9672434","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"00625784_2e282fea","updated":"2021-11-16 01:11:08.000000000","message":"LGTM, thanks.","commit_id":"e68d51ecc05bbae650598d53a931d2365335be0c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6d83cd6ad2ecfc804719ae26ecdd211f06e42fac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8baeae40_d0fbc30e","updated":"2021-11-18 22:20:12.000000000","message":"Looking good overal...\nHave some minor comments on the change. Thank you for your patience with this change, Kiran!","commit_id":"e68d51ecc05bbae650598d53a931d2365335be0c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"a75f766b6e382c8cd84102f833eeacaaa7e8df14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f61d6883_943c8e01","updated":"2021-11-25 02:04:38.000000000","message":"LGTM, thanks Kiran Pawar.\nwe need to update doc about it.\nmanila/api-ref/source/share-replicas.inc#62\n\nmanila/api-ref/samples/share-replica-create-request.json\n\n\n","commit_id":"bbf57bb9a3ee4b514f9e39f63f41d5ed5c775710"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9103c44a7c7b594070d2c88a3c5e29c404c4e324","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d6bd8a9e_d25aeb31","updated":"2021-11-24 14:49:34.000000000","message":"recheck","commit_id":"bbf57bb9a3ee4b514f9e39f63f41d5ed5c775710"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"fc5b026787f2f985ef2592453d09949daa94c958","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"108b5e67_52067adb","updated":"2021-12-03 02:06:15.000000000","message":"LGTM, thanks.","commit_id":"6b5981ec338821134da06f2e2820594168b547d5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"fef77ade57db44beefceb52ae48bbe6e0860aa79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fa57ee63_ffb3c42f","updated":"2021-11-26 01:02:40.000000000","message":"recheck","commit_id":"6b5981ec338821134da06f2e2820594168b547d5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2e5f54ade9b02c02d2c4f7cfa420a4fe251def7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9c0561f5_40165397","updated":"2021-12-27 08:27:04.000000000","message":"LGTM","commit_id":"f1f9f0baf42ce9913601a58c54d548cdef38955d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5005baede957d6f27b084c1b61fbe18cddb9c5e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"086ee406_3bc1ea83","updated":"2022-01-26 19:32:32.000000000","message":"Hey kiran thanks for your patience with this patch. Please take a look at the comments inline; if you add the validation on the \"only_host\", you can add a corresponding unit tests as well, since this patch doesn\u0027t seem to carry any other new tests. \n\nIs it feasible at all to add a share replica tempest test as well, perhaps to just test the happy path? Perhaps here: https://opendev.org/openstack/manila-tempest-plugin/src/branch/master/manila_tempest_tests/tests/api/admin/test_replication.py based on the pattern here: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/816168/4/manila_tempest_tests/tests/api/admin/test_scheduler_hints.py \n\n","commit_id":"7f16fe38834076058a1c589d28b6dde2d04799c3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"bb5b3617d4450460ddf591a527804c463dc468d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"58ea63ea_2073a06b","in_reply_to":"086ee406_3bc1ea83","updated":"2022-01-29 11:09:53.000000000","message":"For scheduler hint the test already added and you have reviewed, please merge it\n\nhttps://review.opendev.org/c/openstack/manila-tempest-plugin/+/816168","commit_id":"7f16fe38834076058a1c589d28b6dde2d04799c3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ae433808ffbc3413e069688d8f6698da99928bd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2835dcfb_fc06fb2b","in_reply_to":"58ea63ea_2073a06b","updated":"2022-02-04 23:18:16.000000000","message":"Thanks, i checked it out now and have posted comments","commit_id":"7f16fe38834076058a1c589d28b6dde2d04799c3"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"bff61db6d20653581a1b96d1f927fff60b4f26ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ca176b53_878dd832","updated":"2022-02-04 17:42:56.000000000","message":"Thanks Kiran. Just small issues. Still waiting for passing with the NetApp CI using [1].\n\n[1] https://review.opendev.org/c/openstack/manila-tempest-plugin/+/816168","commit_id":"f32068689595f9db61d53e17239cf71796210182"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"36929414a0fd19ca644fe83fae8d1f8ba4e36fa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ac909dfc_7b92bbab","updated":"2022-02-11 05:49:40.000000000","message":"this patch is ok for me.","commit_id":"fb8d08028a1bbdb5087db6dc5a2707cb39562941"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2c00bd3977974b54ba4aa9957bd1316c55c1ae16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e0878783_95da150f","updated":"2022-02-12 04:50:50.000000000","message":"rebased.","commit_id":"fa2827ee0b8d4237936d16ea62b0c61d87a0576f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c3589fccedd70d0d718887b756073b4bd5a4cd3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5e9c7f4c_71a47806","updated":"2022-02-15 00:03:54.000000000","message":"Thanks, LGTM","commit_id":"2c2b63779ace6fed2631d3dce66ba9af5693ef33"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"245e14a546b9b6486140998646f384dae845ee9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"36e3ae71_6a9d29ee","updated":"2022-02-16 22:47:31.000000000","message":"Looking good. Thanks for working on this change, and for the patience to get it merged, Kiran","commit_id":"9da023eeb58fb7fc62a3898dd1296633fda467ae"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9ce5693ccb528657a56512539690e25a051d1de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"aff6d6d6_a539b380","updated":"2022-02-15 03:52:14.000000000","message":"Thanks for the fix!","commit_id":"9da023eeb58fb7fc62a3898dd1296633fda467ae"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"c002d650d8d6e04470fb00ceef2cca80293e4c28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"498cdc94_ff207777","updated":"2022-02-15 13:08:29.000000000","message":"Thks, Kiran! LGTM.","commit_id":"9da023eeb58fb7fc62a3898dd1296633fda467ae"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8d7c52fe35ac3a260dcc5af1c9aefa9f07c0364f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7e3f5545_9e99896e","updated":"2022-02-15 05:28:22.000000000","message":"recheck","commit_id":"9da023eeb58fb7fc62a3898dd1296633fda467ae"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c3589fccedd70d0d718887b756073b4bd5a4cd3e","unresolved":true,"context_lines":[{"line_number":2945,"context_line":"  description: |"},{"line_number":2946,"context_line":"    One or more scheduler_hints key and value pairs as a dictionary of"},{"line_number":2947,"context_line":"    strings. Accepted hints are:"},{"line_number":2948,"context_line":"    - ``only_host``: value must be a manage-share service host in ``host@backend#POOL`` format (admin only)"},{"line_number":2949,"context_line":"  in: body"},{"line_number":2950,"context_line":"  required: false"},{"line_number":2951,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5760a12c_2b1a0cef","line":2948,"range":{"start_line":2948,"start_character":37,"end_line":2948,"end_character":49},"updated":"2022-02-15 00:03:54.000000000","message":"share manager","commit_id":"2c2b63779ace6fed2631d3dce66ba9af5693ef33"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b6541c10f5b9f439cd60e7261ac07a1bed9e8b5b","unresolved":false,"context_lines":[{"line_number":2945,"context_line":"  description: |"},{"line_number":2946,"context_line":"    One or more scheduler_hints key and value pairs as a dictionary of"},{"line_number":2947,"context_line":"    strings. Accepted hints are:"},{"line_number":2948,"context_line":"    - ``only_host``: value must be a manage-share service host in ``host@backend#POOL`` format (admin only)"},{"line_number":2949,"context_line":"  in: body"},{"line_number":2950,"context_line":"  required: false"},{"line_number":2951,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"0b3451a5_2b6ae13f","line":2948,"range":{"start_line":2948,"start_character":37,"end_line":2948,"end_character":49},"in_reply_to":"5760a12c_2b1a0cef","updated":"2022-02-15 03:23:33.000000000","message":"Done","commit_id":"2c2b63779ace6fed2631d3dce66ba9af5693ef33"}],"api-ref/source/share-replicas.inc":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5005baede957d6f27b084c1b61fbe18cddb9c5e2","unresolved":true,"context_lines":[{"line_number":84,"context_line":"   - share_id: share_replica_share_id"},{"line_number":85,"context_line":"   - availability_zone: share_replica_az"},{"line_number":86,"context_line":"   - share_network_id: share_replica_share_network_id"},{"line_number":87,"context_line":"   - scheduler_hints: scheduler_hints"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Request example"},{"line_number":90,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"0f6bab67_5c1ea64e","line":87,"range":{"start_line":87,"start_character":22,"end_line":87,"end_character":37},"updated":"2022-01-26 19:32:32.000000000","message":"\"only_host\" is the only scheduler hint that makes sense for replicas; correct? So we can\u0027t reuse this parameter [1] since it talks about the same_host and different_host hints; can you introduce a new parameter with an apt description? \n\nhttps://opendev.org/openstack/manila/src/commit/d1509256dac8d2e66d873e4b9d38e4e06f344b59/api-ref/source/parameters.yaml#L2324-L2329","commit_id":"7f16fe38834076058a1c589d28b6dde2d04799c3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d7ca2c561bfaac617a24966a15611fc5a72876ac","unresolved":false,"context_lines":[{"line_number":84,"context_line":"   - share_id: share_replica_share_id"},{"line_number":85,"context_line":"   - availability_zone: share_replica_az"},{"line_number":86,"context_line":"   - share_network_id: share_replica_share_network_id"},{"line_number":87,"context_line":"   - scheduler_hints: scheduler_hints"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Request example"},{"line_number":90,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"c18a8723_06dd42fb","line":87,"range":{"start_line":87,"start_character":22,"end_line":87,"end_character":37},"in_reply_to":"0f6bab67_5c1ea64e","updated":"2022-01-29 08:19:33.000000000","message":"Done","commit_id":"7f16fe38834076058a1c589d28b6dde2d04799c3"}],"manila/api/v2/share_replicas.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8569c0a204fed6096bc91f642fcfcde787e58eb3","unresolved":true,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        return self._view_builder.detail(req, replica)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @wsgi.Controller.api_version("},{"line_number":131,"context_line":"        MIN_SUPPORTED_API_VERSION, PRE_GRADUATION_VERSION, experimental\u003dTrue)"},{"line_number":132,"context_line":"    @wsgi.response(202)"},{"line_number":133,"context_line":"    def create(self, req, body):"},{"line_number":134,"context_line":"        return self._create(req, body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b2b6af75_6e1ed614","line":131,"range":{"start_line":130,"start_character":4,"end_line":131,"end_character":77},"updated":"2021-11-15 01:27:32.000000000","message":"support scheduler_hits when create share after api 2.65, just as what you did in manila/api/v2/shares.py#181. so i think here also need it.\n\nand then some unit tests may need to update to fit here api microversion change.","commit_id":"b62aa3387130a2f557e86f05a30b2b09ddb5a4e7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"92dc4da84181238e57b60f3204df8e53f221d058","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        return self._view_builder.detail(req, replica)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @wsgi.Controller.api_version("},{"line_number":131,"context_line":"        MIN_SUPPORTED_API_VERSION, PRE_GRADUATION_VERSION, experimental\u003dTrue)"},{"line_number":132,"context_line":"    @wsgi.response(202)"},{"line_number":133,"context_line":"    def create(self, req, body):"},{"line_number":134,"context_line":"        return self._create(req, body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fe2c230d_6ceb8e46","line":131,"range":{"start_line":130,"start_character":4,"end_line":131,"end_character":77},"in_reply_to":"57dd5fba_75406fd1","updated":"2022-01-29 17:06:25.000000000","message":"Done","commit_id":"b62aa3387130a2f557e86f05a30b2b09ddb5a4e7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9d4c5f553f409d9729c77a7e21405ed865ecd952","unresolved":true,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        return self._view_builder.detail(req, replica)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @wsgi.Controller.api_version("},{"line_number":131,"context_line":"        MIN_SUPPORTED_API_VERSION, PRE_GRADUATION_VERSION, experimental\u003dTrue)"},{"line_number":132,"context_line":"    @wsgi.response(202)"},{"line_number":133,"context_line":"    def create(self, req, body):"},{"line_number":134,"context_line":"        return self._create(req, body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"57dd5fba_75406fd1","line":131,"range":{"start_line":130,"start_character":4,"end_line":131,"end_character":77},"in_reply_to":"b2b6af75_6e1ed614","updated":"2021-11-15 11:13:01.000000000","message":"Added version check. \n\nI do not think we need test for API _create function definition change. At least I do not see those in other cases e.g. shares.","commit_id":"b62aa3387130a2f557e86f05a30b2b09ddb5a4e7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6d83cd6ad2ecfc804719ae26ecdd211f06e42fac","unresolved":true,"context_lines":[{"line_number":141,"context_line":"    @wsgi.Controller.api_version(\"2.65\") # noqa"},{"line_number":142,"context_line":"    @wsgi.response(202)"},{"line_number":143,"context_line":"    def create(self, req, body): # pylint: disable\u003dfunction-redefined  # noqa F811"},{"line_number":144,"context_line":"        if not self.is_valid_body(body, \u0027share_replica\u0027):"},{"line_number":145,"context_line":"            msg \u003d _(\"Body does not contain \u0027share_replica\u0027 information.\")"},{"line_number":146,"context_line":"            raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        share_replica \u003d body[\u0027share_replica\u0027]"},{"line_number":149,"context_line":"        scheduler_hints \u003d share_replica.pop(\u0027scheduler_hints\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1d245730_d1381a4a","line":146,"range":{"start_line":144,"start_character":8,"end_line":146,"end_character":62},"updated":"2021-11-18 22:20:12.000000000","message":"This code fragment could be reused, as it is being rewritten between lines 157 and 159","commit_id":"e68d51ecc05bbae650598d53a931d2365335be0c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e4f60229156b33f3f6d0f1f1846652b10a9471fa","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    @wsgi.Controller.api_version(\"2.65\") # noqa"},{"line_number":142,"context_line":"    @wsgi.response(202)"},{"line_number":143,"context_line":"    def create(self, req, body): # pylint: disable\u003dfunction-redefined  # noqa F811"},{"line_number":144,"context_line":"        if not self.is_valid_body(body, \u0027share_replica\u0027):"},{"line_number":145,"context_line":"            msg \u003d _(\"Body does not contain \u0027share_replica\u0027 information.\")"},{"line_number":146,"context_line":"            raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        share_replica \u003d body[\u0027share_replica\u0027]"},{"line_number":149,"context_line":"        scheduler_hints \u003d share_replica.pop(\u0027scheduler_hints\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"8fd18962_130359db","line":146,"range":{"start_line":144,"start_character":8,"end_line":146,"end_character":62},"in_reply_to":"1271be4f_9547aa7f","updated":"2022-01-26 19:33:33.000000000","message":"Ack","commit_id":"e68d51ecc05bbae650598d53a931d2365335be0c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d6f6963a203e0f93e956e90c9364f13794c6d8e0","unresolved":true,"context_lines":[{"line_number":141,"context_line":"    @wsgi.Controller.api_version(\"2.65\") # noqa"},{"line_number":142,"context_line":"    @wsgi.response(202)"},{"line_number":143,"context_line":"    def create(self, req, body): # pylint: disable\u003dfunction-redefined  # noqa F811"},{"line_number":144,"context_line":"        if not self.is_valid_body(body, \u0027share_replica\u0027):"},{"line_number":145,"context_line":"            msg \u003d _(\"Body does not contain \u0027share_replica\u0027 information.\")"},{"line_number":146,"context_line":"            raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        share_replica \u003d body[\u0027share_replica\u0027]"},{"line_number":149,"context_line":"        scheduler_hints \u003d share_replica.pop(\u0027scheduler_hints\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1271be4f_9547aa7f","line":146,"range":{"start_line":144,"start_character":8,"end_line":146,"end_character":62},"in_reply_to":"1d245730_d1381a4a","updated":"2021-11-20 09:27:25.000000000","message":"done","commit_id":"e68d51ecc05bbae650598d53a931d2365335be0c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5005baede957d6f27b084c1b61fbe18cddb9c5e2","unresolved":true,"context_lines":[{"line_number":146,"context_line":"    @wsgi.Controller.api_version(\"2.67\") # noqa"},{"line_number":147,"context_line":"    @wsgi.response(202)"},{"line_number":148,"context_line":"    def create(self, req, body): # pylint: disable\u003dfunction-redefined  # noqa F811"},{"line_number":149,"context_line":"        self._validate_body(body)"},{"line_number":150,"context_line":"        share_replica \u003d body[\u0027share_replica\u0027]"},{"line_number":151,"context_line":"        scheduler_hints \u003d share_replica.pop(\u0027scheduler_hints\u0027, None)"},{"line_number":152,"context_line":"        return self._create(req, body, scheduler_hints\u003dscheduler_hints)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @wsgi.Controller.authorize(\u0027create\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"4cde9291_309084ad","line":151,"range":{"start_line":149,"start_character":8,"end_line":151,"end_character":68},"updated":"2022-01-26 19:32:32.000000000","message":"instead of repeating this check here and in the _create method, you could pass a parameter to parse scheduler hints or not, for example:\n\n @wsgi.Controller.api_version(\"2.67\") # noqa\n    @wsgi.response(202)\n    def create(self, req, body): # pylint: disable\u003dfunction-redefined  # noqa F811\n        return self._create(req, body, allow_scheduler_hints\u003dTrue)\n\n @wsgi.Controller.authorize(\u0027create\u0027)\n    def _create(self, req, body, scheduler_hints\u003dNone):\n        \"\"\"Add a replica to an existing share.\"\"\"\n        context \u003d req.environ[\u0027manila.context\u0027]\n        self._validate_body(body)\n        \n        if allow_scheduler_hints:\n            scheduler_hints \u003d body.get(\u0027share_replica\u0027).get(\u0027scheduler_hints\u0027)\n        ...","commit_id":"7f16fe38834076058a1c589d28b6dde2d04799c3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d7ca2c561bfaac617a24966a15611fc5a72876ac","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    @wsgi.Controller.api_version(\"2.67\") # noqa"},{"line_number":147,"context_line":"    @wsgi.response(202)"},{"line_number":148,"context_line":"    def create(self, req, body): # pylint: disable\u003dfunction-redefined  # noqa F811"},{"line_number":149,"context_line":"        self._validate_body(body)"},{"line_number":150,"context_line":"        share_replica \u003d body[\u0027share_replica\u0027]"},{"line_number":151,"context_line":"        scheduler_hints \u003d share_replica.pop(\u0027scheduler_hints\u0027, None)"},{"line_number":152,"context_line":"        return self._create(req, body, scheduler_hints\u003dscheduler_hints)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @wsgi.Controller.authorize(\u0027create\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"be948670_436915ee","line":151,"range":{"start_line":149,"start_character":8,"end_line":151,"end_character":68},"in_reply_to":"4cde9291_309084ad","updated":"2022-01-29 08:19:33.000000000","message":"Done","commit_id":"7f16fe38834076058a1c589d28b6dde2d04799c3"}],"manila/share/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5005baede957d6f27b084c1b61fbe18cddb9c5e2","unresolved":true,"context_lines":[{"line_number":595,"context_line":"        return request_spec, share_instance"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def create_share_replica(self, context, share, availability_zone\u003dNone,"},{"line_number":598,"context_line":"                             share_network_id\u003dNone, scheduler_hints\u003dNone):"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        if not share.get(\u0027replication_type\u0027):"},{"line_number":601,"context_line":"            msg \u003d _(\"Replication not supported for share %s.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"f736b10c_b9bade41","line":598,"range":{"start_line":598,"start_character":52,"end_line":598,"end_character":67},"updated":"2022-01-26 19:32:32.000000000","message":"don\u0027t we want to validate this to only have \"only_host\" and no other kind of hint?","commit_id":"7f16fe38834076058a1c589d28b6dde2d04799c3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d7ca2c561bfaac617a24966a15611fc5a72876ac","unresolved":false,"context_lines":[{"line_number":595,"context_line":"        return request_spec, share_instance"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def create_share_replica(self, context, share, availability_zone\u003dNone,"},{"line_number":598,"context_line":"                             share_network_id\u003dNone, scheduler_hints\u003dNone):"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        if not share.get(\u0027replication_type\u0027):"},{"line_number":601,"context_line":"            msg \u003d _(\"Replication not supported for share %s.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"b1432742_12e45ee1","line":598,"range":{"start_line":598,"start_character":52,"end_line":598,"end_character":67},"in_reply_to":"d6655127_eb784227","updated":"2022-01-29 08:19:33.000000000","message":"Done","commit_id":"7f16fe38834076058a1c589d28b6dde2d04799c3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e4f60229156b33f3f6d0f1f1846652b10a9471fa","unresolved":true,"context_lines":[{"line_number":595,"context_line":"        return request_spec, share_instance"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def create_share_replica(self, context, share, availability_zone\u003dNone,"},{"line_number":598,"context_line":"                             share_network_id\u003dNone, scheduler_hints\u003dNone):"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        if not share.get(\u0027replication_type\u0027):"},{"line_number":601,"context_line":"            msg \u003d _(\"Replication not supported for share %s.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"d6655127_eb784227","line":598,"range":{"start_line":598,"start_character":52,"end_line":598,"end_character":67},"in_reply_to":"f736b10c_b9bade41","updated":"2022-01-26 19:33:33.000000000","message":"+1","commit_id":"7f16fe38834076058a1c589d28b6dde2d04799c3"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"bff61db6d20653581a1b96d1f927fff60b4f26ff","unresolved":true,"context_lines":[{"line_number":608,"context_line":"        if scheduler_hints:"},{"line_number":609,"context_line":"            if (\u0027only_host\u0027 not in scheduler_hints.keys() or len("},{"line_number":610,"context_line":"                    scheduler_hints) \u003e 1):"},{"line_number":611,"context_line":"                msg \u003d _(\"Arg \u0027scheduler_hint\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":612,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        self._check_is_share_busy(share)"}],"source_content_type":"text/x-python","patch_set":8,"id":"f74d2888_2e064de3","line":611,"range":{"start_line":611,"start_character":30,"end_line":611,"end_character":44},"updated":"2022-02-04 17:42:56.000000000","message":"scheduler_hints","commit_id":"f32068689595f9db61d53e17239cf71796210182"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"bff61db6d20653581a1b96d1f927fff60b4f26ff","unresolved":true,"context_lines":[{"line_number":608,"context_line":"        if scheduler_hints:"},{"line_number":609,"context_line":"            if (\u0027only_host\u0027 not in scheduler_hints.keys() or len("},{"line_number":610,"context_line":"                    scheduler_hints) \u003e 1):"},{"line_number":611,"context_line":"                msg \u003d _(\"Arg \u0027scheduler_hint\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":612,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        self._check_is_share_busy(share)"}],"source_content_type":"text/x-python","patch_set":8,"id":"761052d9_38fa07b8","line":611,"range":{"start_line":611,"start_character":46,"end_line":611,"end_character":54},"updated":"2022-02-04 17:42:56.000000000","message":"supports","commit_id":"f32068689595f9db61d53e17239cf71796210182"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2c00bd3977974b54ba4aa9957bd1316c55c1ae16","unresolved":false,"context_lines":[{"line_number":608,"context_line":"        if scheduler_hints:"},{"line_number":609,"context_line":"            if (\u0027only_host\u0027 not in scheduler_hints.keys() or len("},{"line_number":610,"context_line":"                    scheduler_hints) \u003e 1):"},{"line_number":611,"context_line":"                msg \u003d _(\"Arg \u0027scheduler_hint\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":612,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        self._check_is_share_busy(share)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fdd605e8_81e5a0ff","line":611,"range":{"start_line":611,"start_character":46,"end_line":611,"end_character":54},"in_reply_to":"761052d9_38fa07b8","updated":"2022-02-12 04:50:50.000000000","message":"Done","commit_id":"f32068689595f9db61d53e17239cf71796210182"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2c00bd3977974b54ba4aa9957bd1316c55c1ae16","unresolved":false,"context_lines":[{"line_number":608,"context_line":"        if scheduler_hints:"},{"line_number":609,"context_line":"            if (\u0027only_host\u0027 not in scheduler_hints.keys() or len("},{"line_number":610,"context_line":"                    scheduler_hints) \u003e 1):"},{"line_number":611,"context_line":"                msg \u003d _(\"Arg \u0027scheduler_hint\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":612,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        self._check_is_share_busy(share)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dda0dc40_d58c8e8e","line":611,"range":{"start_line":611,"start_character":30,"end_line":611,"end_character":44},"in_reply_to":"f74d2888_2e064de3","updated":"2022-02-12 04:50:50.000000000","message":"Done","commit_id":"f32068689595f9db61d53e17239cf71796210182"}]}