)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"abc9b9e60dc6c8b920deb0b2f15d3267e24eae2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d98360c_15908f4a","updated":"2021-11-22 19:36:04.000000000","message":"recheck","commit_id":"d28aa10ee7d70a1eb3adc909266049cad7c2e089"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9109b62c7220987285fc94c6dc0b2a2b18a740ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"27e8cc50_1223770b","updated":"2021-11-22 06:41:36.000000000","message":"recheck","commit_id":"d28aa10ee7d70a1eb3adc909266049cad7c2e089"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f5d469dcd7fe2bdc13a96d46acdc5a0aa3f051f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"df724ce2_8bc5b1a1","updated":"2021-12-08 15:43:48.000000000","message":"recheck","commit_id":"d28aa10ee7d70a1eb3adc909266049cad7c2e089"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f75621ef8441f01044dfdda63cf3a7534b6d190b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c7e5b242_4cab0a94","updated":"2021-12-09 19:13:03.000000000","message":"Thanks Liron, a comment regarding the failure inline... We\u0027ll run into issues setting up the default share group types as well; Victoria is working on a patch to allow share group type creation via OSC: https://review.opendev.org/c/openstack/python-manilaclient/+/805064 \n\nWe would need that change. You can add a Depends-On if you wish and start using the commands in the plugin and implement this change.","commit_id":"4a93735069fe02067a973e86ca209f542e5ff801"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3bda8c1ed386a6303c416af75b20600d38969919","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1c2f5eb3_d71f8c6e","updated":"2021-12-22 16:33:55.000000000","message":"recheck","commit_id":"50e76775cd34a32f9625dcaa82a7bc190955fd0a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"793103f138cc5cab016fc50f4dc8f0fb678513c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"eee80d70_0cfa025f","updated":"2021-12-29 17:30:25.000000000","message":"LGTM, thanks Liron ","commit_id":"466794964f2a24a0c9ae28f741282f85e4ef7d57"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3088732be4356f08a8290d4ca223c8dc0b3a2365","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"78ff6c86_a573a87c","updated":"2021-12-30 13:56:35.000000000","message":"Looks good, thanks for these changes Liron!\nI\u0027m only a bit concerned because the commit message does not mention the changes done to the share type/group type creation... But I don\u0027t think it\u0027s a huge blocker :)","commit_id":"466794964f2a24a0c9ae28f741282f85e4ef7d57"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4c304a47620cb5b6922dd947f8f792aa21354c97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e634f012_e5bffc02","updated":"2022-01-17 12:09:50.000000000","message":"seems like this change might be related to our recent failures:\nhttps://zuul.opendev.org/t/openstack/build/56a20d5942e8496eb5c94938c28a7eb5\n\nthe jobs are failing on \u0027share group type create\u0027\n\nany ideas, pointers how to fix that? ","commit_id":"466794964f2a24a0c9ae28f741282f85e4ef7d57"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"3eeae4a853a9ad8ec4f8f0db5fe60c34c30b61a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fd0bd195_449efd64","in_reply_to":"4f1ef79c_2f9e4f55","updated":"2022-01-17 13:39:41.000000000","message":"Hi Liron,\n\nthanks for the reply .. no idea how (from where) the job installs the client, I see that the change you linked is not packaged yet, maybe that\u0027s it, I\u0027m investigating the job further - maybe we can force it to install the client from source\n\nhttps://pypi.org/project/python-manilaclient/#history","commit_id":"466794964f2a24a0c9ae28f741282f85e4ef7d57"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"6e261484c8c09f3d92e70c20ab3c9d7f402007c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4f1ef79c_2f9e4f55","in_reply_to":"e634f012_e5bffc02","updated":"2022-01-17 12:33:27.000000000","message":"Hi Martin,\n\nThis change is based on patch [1] that has already been merged.\nIs there a possibility that patch [1] isn\u0027t included it this job ?\n\n\n[1] https://review.opendev.org/c/openstack/python-manilaclient/+/805064","commit_id":"466794964f2a24a0c9ae28f741282f85e4ef7d57"}],"devstack/plugin.sh":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f75621ef8441f01044dfdda63cf3a7534b6d190b","unresolved":true,"context_lines":[{"line_number":550,"context_line":"    driver_handles_share_servers\u003d$(iniget $MANILA_CONF ${enabled_backends[0]} driver_handles_share_servers)"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"    local type_exists\u003d$( openstack --os-cloud devstack-admin share type list | grep \" $MANILA_DEFAULT_SHARE_TYPE \" )"},{"line_number":553,"context_line":"    if [[ -z $type_exists ]]; then"},{"line_number":554,"context_line":"        local command_args\u003d\"$MANILA_DEFAULT_SHARE_TYPE $driver_handles_share_servers\""},{"line_number":555,"context_line":"        if [[ $MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS ]]; then"},{"line_number":556,"context_line":"            command_args\u003d\"$command_args --extra-specs $MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS\""},{"line_number":557,"context_line":"        fi"},{"line_number":558,"context_line":"        openstack --os-cloud devstack-admin share type create $command_args"},{"line_number":559,"context_line":"    fi"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"}"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"# create_custom_share_types - create share types suitable for both possible"},{"line_number":564,"context_line":"# driver modes with names \"dhss_true\" and \"dhss_false\"."},{"line_number":565,"context_line":"function create_custom_share_types {"},{"line_number":566,"context_line":"    local command_args\u003d\"dhss_true True\""},{"line_number":567,"context_line":"    if [[ $MANILA_DHSS_TRUE_SHARE_TYPE_EXTRA_SPECS ]]; then"},{"line_number":568,"context_line":"        command_args\u003d\"$command_args --extra-specs $MANILA_DHSS_TRUE_SHARE_TYPE_EXTRA_SPECS\""},{"line_number":569,"context_line":"    fi"},{"line_number":570,"context_line":"    openstack --os-cloud devstack-admin share type create $command_args"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    command_args\u003d\"dhss_false False\""},{"line_number":573,"context_line":"    if [[ $MANILA_DHSS_FALSE_SHARE_TYPE_EXTRA_SPECS ]]; then"},{"line_number":574,"context_line":"        command_args\u003d\"$command_args --extra-specs $MANILA_DHSS_FALSE_SHARE_TYPE_EXTRA_SPECS\""},{"line_number":575,"context_line":"    fi"},{"line_number":576,"context_line":"    openstack --os-cloud devstack-admin share type create $command_args"},{"line_number":577,"context_line":"}"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"# configure_backing_file - Set up backing file for LVM"},{"line_number":580,"context_line":"function configure_backing_file {"}],"source_content_type":"text/x-sh","patch_set":2,"id":"45fa9500_fe6548e5","line":577,"range":{"start_line":553,"start_character":4,"end_line":577,"end_character":1},"updated":"2021-12-09 19:13:03.000000000","message":"When the new defaults are enabled, these share type creation commands need to use the \"devstack-system-admin\" profile: https://zuul.opendev.org/t/openstack/build/f6aad9d429c54ac0997a0a785f0defa8/log/job-output.txt#23084-23093","commit_id":"4a93735069fe02067a973e86ca209f542e5ff801"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"eb7ba6dbc3d3f6ec2386ef46859fe083ed279d73","unresolved":true,"context_lines":[{"line_number":550,"context_line":"    driver_handles_share_servers\u003d$(iniget $MANILA_CONF ${enabled_backends[0]} driver_handles_share_servers)"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"    local type_exists\u003d$( openstack --os-cloud devstack-admin share type list | grep \" $MANILA_DEFAULT_SHARE_TYPE \" )"},{"line_number":553,"context_line":"    if [[ -z $type_exists ]]; then"},{"line_number":554,"context_line":"        local command_args\u003d\"$MANILA_DEFAULT_SHARE_TYPE $driver_handles_share_servers\""},{"line_number":555,"context_line":"        if [[ $MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS ]]; then"},{"line_number":556,"context_line":"            command_args\u003d\"$command_args --extra-specs $MANILA_DEFAULT_SHARE_TYPE_EXTRA_SPECS\""},{"line_number":557,"context_line":"        fi"},{"line_number":558,"context_line":"        openstack --os-cloud devstack-admin share type create $command_args"},{"line_number":559,"context_line":"    fi"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"}"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"# create_custom_share_types - create share types suitable for both possible"},{"line_number":564,"context_line":"# driver modes with names \"dhss_true\" and \"dhss_false\"."},{"line_number":565,"context_line":"function create_custom_share_types {"},{"line_number":566,"context_line":"    local command_args\u003d\"dhss_true True\""},{"line_number":567,"context_line":"    if [[ $MANILA_DHSS_TRUE_SHARE_TYPE_EXTRA_SPECS ]]; then"},{"line_number":568,"context_line":"        command_args\u003d\"$command_args --extra-specs $MANILA_DHSS_TRUE_SHARE_TYPE_EXTRA_SPECS\""},{"line_number":569,"context_line":"    fi"},{"line_number":570,"context_line":"    openstack --os-cloud devstack-admin share type create $command_args"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    command_args\u003d\"dhss_false False\""},{"line_number":573,"context_line":"    if [[ $MANILA_DHSS_FALSE_SHARE_TYPE_EXTRA_SPECS ]]; then"},{"line_number":574,"context_line":"        command_args\u003d\"$command_args --extra-specs $MANILA_DHSS_FALSE_SHARE_TYPE_EXTRA_SPECS\""},{"line_number":575,"context_line":"    fi"},{"line_number":576,"context_line":"    openstack --os-cloud devstack-admin share type create $command_args"},{"line_number":577,"context_line":"}"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"# configure_backing_file - Set up backing file for LVM"},{"line_number":580,"context_line":"function configure_backing_file {"}],"source_content_type":"text/x-sh","patch_set":2,"id":"4b8af5c1_794df9c6","line":577,"range":{"start_line":553,"start_character":4,"end_line":577,"end_character":1},"in_reply_to":"45fa9500_fe6548e5","updated":"2021-12-12 11:15:49.000000000","message":"Thanks Goutham!\nDone!","commit_id":"4a93735069fe02067a973e86ca209f542e5ff801"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"32ae505692030496cf9434d6110277600ebf8caa","unresolved":true,"context_lines":[{"line_number":526,"context_line":"    # for OSC support"},{"line_number":527,"context_line":"    # TODO(gouthamr): Remove workaround when we replace the commands below"},{"line_number":528,"context_line":"    # with OSC equivalents"},{"line_number":529,"context_line":"    source $TOP_DIR/openrc admin admin"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"    local type_exists\u003d$( openstack --os-cloud $CLOUD share group type list | grep \" $MANILA_DEFAULT_SHARE_GROUP_TYPE \" )"},{"line_number":532,"context_line":"    if [[ -z $type_exists ]]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"4a815c7f_64161297","line":529,"range":{"start_line":529,"start_character":4,"end_line":529,"end_character":38},"updated":"2021-12-13 20:22:06.000000000","message":"You have to drop this","commit_id":"4acfc197c7f884ff016fb3c437ff12e2f4515342"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"32ae505692030496cf9434d6110277600ebf8caa","unresolved":true,"context_lines":[{"line_number":536,"context_line":"        openstack --os-cloud $CLOUD share group type set $MANILA_DEFAULT_SHARE_GROUP_TYPE --group-specs $MANILA_DEFAULT_SHARE_GROUP_TYPE_SPECS"},{"line_number":537,"context_line":"    fi"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    for key in $( set | awk -F\u003d \u0027/^OS_/ {print $1}\u0027 ); do"},{"line_number":540,"context_line":"        unset \"${key}\""},{"line_number":541,"context_line":"    done"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"}"},{"line_number":544,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"0474a419_5cfa2d56","line":541,"range":{"start_line":539,"start_character":4,"end_line":541,"end_character":8},"updated":"2021-12-13 20:22:06.000000000","message":"and this","commit_id":"4acfc197c7f884ff016fb3c437ff12e2f4515342"}]}