)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"44e44005b9124739d11d7590da03315d4647f25e","unresolved":true,"context_lines":[{"line_number":10,"context_line":"that both resources must have the same project_id. If not,"},{"line_number":11,"context_line":"a HTTP Bad Request is raised. Affiliated tests were altered or created."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: # 1918323"},{"line_number":14,"context_line":"Change-Id: Idb2a8838d492ac3c616fb21ab1272f7dc74ee589"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b174790d_0f94bdba","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":14},"updated":"2021-12-02 19:58:54.000000000","message":"Please remove this blank space, otherwise the link to launchpad will not work.","commit_id":"df02f8162d90689d3ba34955e5c8dec37c98c6bc"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"0011bce3508bc08d1b3bc31f77733a1b34710c8b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"that both resources must have the same project_id. If not,"},{"line_number":11,"context_line":"a HTTP Bad Request is raised. Affiliated tests were altered or created."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: # 1918323"},{"line_number":14,"context_line":"Change-Id: Idb2a8838d492ac3c616fb21ab1272f7dc74ee589"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4c9407d1_c343f223","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":14},"in_reply_to":"b174790d_0f94bdba","updated":"2022-03-03 17:06:00.000000000","message":"Done","commit_id":"df02f8162d90689d3ba34955e5c8dec37c98c6bc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"44e44005b9124739d11d7590da03315d4647f25e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"072e5c29_a9827f07","updated":"2021-12-02 19:58:54.000000000","message":"Hi Ashley, thanks for working on this bugfix. I added some comments below. Please check :) ","commit_id":"df02f8162d90689d3ba34955e5c8dec37c98c6bc"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"3187ec8c6c3fd92bc9859c1c2f9c5416fe4e78fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"38f0783f_555469c3","updated":"2021-12-02 20:38:39.000000000","message":"Sorry, I forgot one thing, in the launchpad bug, Goutham mentioned an issue in the function `add_security_service`[1] that would be addressed with this bugfix, but looking the code I was not able to understand if it was covered by your fix. Could you please confirm if that issue was addressed?\n\nThank you!\n\n[1] https://review.opendev.org/c/openstack/manila/+/774728/10/manila/api/v2/share_networks.py#411","commit_id":"df02f8162d90689d3ba34955e5c8dec37c98c6bc"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"477798b24f9fa00b1676490ba13314514d900795","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a408943_3996aa55","updated":"2021-12-15 21:40:35.000000000","message":"Thanks for the reviews, currently looking into an alternative fix that can help with the extra test faliures.","commit_id":"df02f8162d90689d3ba34955e5c8dec37c98c6bc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"62d36232a53f5c9c684d596e354faa91b7db8273","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"238ae045_c618b5b3","updated":"2021-12-03 14:56:03.000000000","message":"recheck","commit_id":"df02f8162d90689d3ba34955e5c8dec37c98c6bc"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"76ce480bdadc8c4a3d2aa1350e7f8884952a548b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"65e2d4e4_fd35c06b","updated":"2022-03-09 23:57:39.000000000","message":"Fix is looking good, thanks Ashley\nCould you please add a release note for it?","commit_id":"da329a1c8f42b01fb0f8ff5034b03eda94d71a51"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d977e28ae69329a0883c6e0d27ce2006cc252f98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e0614d3b_b455fb5f","updated":"2022-04-18 19:34:37.000000000","message":"LGTM thanks Ashley","commit_id":"a97d65d3eb9b3a5b4a88a1b3f22b59ca2f75c9bc"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4735d485a11d6e8a9c136286aecfd9776d4f110f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"48338a81_ea9df150","updated":"2022-04-19 18:33:52.000000000","message":"LGTM, thank you Ashley! 😊\nSorry for the delay on merging this change","commit_id":"a97d65d3eb9b3a5b4a88a1b3f22b59ca2f75c9bc"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"26b73215888f869129a403d56d3bb3f7ad02eb9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f5349b08_d86247d3","updated":"2022-03-11 14:52:37.000000000","message":"Looks good to me now. Thanks Ashley! ","commit_id":"a97d65d3eb9b3a5b4a88a1b3f22b59ca2f75c9bc"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"37b04e40ad995d180f31ebfb288c75e2ecc61a8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"039cff52_baf374b1","updated":"2022-03-11 11:38:13.000000000","message":"recheck","commit_id":"a97d65d3eb9b3a5b4a88a1b3f22b59ca2f75c9bc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e70edc55c0ca7c3c817cfb0fad953869e61611f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"348b6021_a22ce5c5","updated":"2022-04-21 13:54:52.000000000","message":"recheck\n\nKnown sporadic tempest failure in the LVM job (one of the revert to snapshot tests); but the unit test failure in lower-constraints looks interesting and new:\n\n  test_init_identify_local_host_2_None\n\n  ft1.16: \n \n manila.tests.share.drivers.cephfs.test_driver.NFSProtocolHelperTestCase.test_init_identify_local_host_2_Nonetesttools.testresult.real._StringException: Traceback (most recent call last):\n  File \"/home/zuul/src/opendev.org/openstack/manila/.tox/lower-constraints/lib/python3.8/site-packages/ddt.py\", line 182, in wrapper\n    return func(self, *args, **kwargs)\n  File \"/home/zuul/src/opendev.org/openstack/manila/manila/tests/share/drivers/cephfs/test_driver.py\", line 980, in test_init_identify_local_host\n    driver.LOG.info.assert_called_once()\n  File \"/usr/lib/python3.8/unittest/mock.py\", line 892, in assert_called_once\n    raise AssertionError(msg)\nAssertionError: Expected \u0027mock\u0027 to have been called once. Called 3 times.\nCalls: [call(\u0027[%(be)s] Ceph client disconnecting...\u0027, {\u0027be\u0027: \u0027CephFS\u0027}),\n call(\u0027[%(be)s] Ceph client disconnected\u0027, {\u0027be\u0027: \u0027CephFS\u0027}),\n call(\"NFS-Ganesha server\u0027s location defaulted to driver\u0027s hostname: %s\", \u003cMock name\u003d\u0027mock()\u0027 id\u003d\u0027140492518629872\u0027\u003e)].\n\n\n\nit can\u0027t be related to this patch though since it doesn\u0027t touch that code.","commit_id":"a97d65d3eb9b3a5b4a88a1b3f22b59ca2f75c9bc"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0ea25ecaf5b5401d276e8b9dc0f00242f0b27389","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3f9554a7_3b5f5898","updated":"2022-04-19 19:24:59.000000000","message":"recheck\nLVM job failed even to build devstack.\nRetrying","commit_id":"a97d65d3eb9b3a5b4a88a1b3f22b59ca2f75c9bc"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6613d8ab9f62a0f443752218a95c5b095b554efa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9b3c7da0_af4a4bf9","updated":"2022-04-21 10:57:04.000000000","message":"recheck\nNeutron-dynamic-plugin issue got fixed: https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/838780","commit_id":"a97d65d3eb9b3a5b4a88a1b3f22b59ca2f75c9bc"}],"manila/tests/api/v2/test_share_networks.py":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"44e44005b9124739d11d7590da03315d4647f25e","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"fake_share_network_with_ss \u003d {"},{"line_number":71,"context_line":"    \u0027id\u0027: \u0027sn-id\u0027,"},{"line_number":72,"context_line":"    \u0027project_id\u0027: \u0027fake-project-id\u0027,"},{"line_number":73,"context_line":"    \u0027created_at\u0027: timeutils.parse_strtime(\u00272001-01-01\u0027, fmt\u003d\"%Y-%m-%d\"),"},{"line_number":74,"context_line":"    \u0027updated_at\u0027: None,"},{"line_number":75,"context_line":"    \u0027name\u0027: \u0027test-sn\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"8529524a_7d41bef2","line":72,"range":{"start_line":72,"start_character":4,"end_line":72,"end_character":35},"updated":"2021-12-02 19:58:54.000000000","message":"I believe this change is not necessary, because it seems not being used by your UTs.","commit_id":"df02f8162d90689d3ba34955e5c8dec37c98c6bc"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"0011bce3508bc08d1b3bc31f77733a1b34710c8b","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"fake_share_network_with_ss \u003d {"},{"line_number":71,"context_line":"    \u0027id\u0027: \u0027sn-id\u0027,"},{"line_number":72,"context_line":"    \u0027project_id\u0027: \u0027fake-project-id\u0027,"},{"line_number":73,"context_line":"    \u0027created_at\u0027: timeutils.parse_strtime(\u00272001-01-01\u0027, fmt\u003d\"%Y-%m-%d\"),"},{"line_number":74,"context_line":"    \u0027updated_at\u0027: None,"},{"line_number":75,"context_line":"    \u0027name\u0027: \u0027test-sn\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b99e47c5_1ec5ae86","line":72,"range":{"start_line":72,"start_character":4,"end_line":72,"end_character":35},"in_reply_to":"8529524a_7d41bef2","updated":"2022-03-03 17:06:00.000000000","message":"Done","commit_id":"df02f8162d90689d3ba34955e5c8dec37c98c6bc"}],"manila/tests/db_utils.py":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"44e44005b9124739d11d7590da03315d4647f25e","unresolved":true,"context_lines":[{"line_number":250,"context_line":"    \"\"\"Create a share network object.\"\"\""},{"line_number":251,"context_line":"    net \u003d {"},{"line_number":252,"context_line":"        \u0027user_id\u0027: \u0027fake\u0027,"},{"line_number":253,"context_line":"        \u0027project_id\u0027: \u0027fake-project-id\u0027,"},{"line_number":254,"context_line":"        \u0027status\u0027: \u0027active\u0027,"},{"line_number":255,"context_line":"        \u0027name\u0027: \u0027whatever\u0027,"},{"line_number":256,"context_line":"        \u0027description\u0027: \u0027fake description\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7b5b16_004a803e","line":253,"range":{"start_line":253,"start_character":8,"end_line":253,"end_character":39},"updated":"2021-12-02 19:58:54.000000000","message":"This change also seems not to be necessary, because the unit test is comparing this project-id with `fake_share_network[\u0027project-id\u0027]` which already has a different value and therefore would satisfy your unit test. Does that make sense to you?","commit_id":"df02f8162d90689d3ba34955e5c8dec37c98c6bc"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"0011bce3508bc08d1b3bc31f77733a1b34710c8b","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    \"\"\"Create a share network object.\"\"\""},{"line_number":251,"context_line":"    net \u003d {"},{"line_number":252,"context_line":"        \u0027user_id\u0027: \u0027fake\u0027,"},{"line_number":253,"context_line":"        \u0027project_id\u0027: \u0027fake-project-id\u0027,"},{"line_number":254,"context_line":"        \u0027status\u0027: \u0027active\u0027,"},{"line_number":255,"context_line":"        \u0027name\u0027: \u0027whatever\u0027,"},{"line_number":256,"context_line":"        \u0027description\u0027: \u0027fake description\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6eaf582e_c0ab0fdb","line":253,"range":{"start_line":253,"start_character":8,"end_line":253,"end_character":39},"in_reply_to":"df7b5b16_004a803e","updated":"2022-03-03 17:06:00.000000000","message":"Done","commit_id":"df02f8162d90689d3ba34955e5c8dec37c98c6bc"}],"releasenotes/notes/bug-1918323-add-validation-to-share-network-94571f35cb39c815.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d977e28ae69329a0883c6e0d27ce2006cc252f98","unresolved":true,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adds a check when associating a security service to a share network, so"},{"line_number":4,"context_line":"    that both resources must have the same project_id. If not,"},{"line_number":5,"context_line":"    HTTP Bad Request is raised."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8f8391de_5d1d3af5","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":8},"updated":"2022-04-18 19:34:37.000000000","message":"Added\n\nRelease notes are written in past tense because release notes are rendered and read together after a release has occurred","commit_id":"a97d65d3eb9b3a5b4a88a1b3f22b59ca2f75c9bc"}]}