)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"f3df624b94c46c5456257d6f0792d0702b0fba8d","unresolved":true,"context_lines":[{"line_number":12,"context_line":"and it will cause the destination share to change its export"},{"line_number":13,"context_line":"locations."},{"line_number":14,"context_line":"This change fixes an issue that allowed manila/the share driver"},{"line_number":15,"context_line":"to chose where a share instance is going to land in case of a"},{"line_number":16,"context_line":"nondisruptive migration. Now, when such migration is required,"},{"line_number":17,"context_line":"manila will automatically place the destination share instance in"},{"line_number":18,"context_line":"the same share server that the source instance is located at."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"89b7ad23_b2ba88a8","line":15,"range":{"start_line":15,"start_character":3,"end_line":15,"end_character":8},"updated":"2022-01-13 16:44:58.000000000","message":"nit: choose","commit_id":"af3513d2b0f7bbcc968a4c445243de40d94714aa"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b52b3d1e3b775e7000b8244757cc628528b32acc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2abf3b49_3740ad90","updated":"2021-12-03 14:47:23.000000000","message":"recheck","commit_id":"bf82ed08748fc7e814d0b94299c492d24f22aab1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9ba66e302709367126042e091da8b21d92256ca8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c4b30f25_63db403e","updated":"2021-12-02 11:03:29.000000000","message":"recheck","commit_id":"bf82ed08748fc7e814d0b94299c492d24f22aab1"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"3d316a146d5d437f102334b70156c355e949802c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c0473459_bd52cd8c","updated":"2021-12-02 13:02:49.000000000","message":"run Pure Storage CI","commit_id":"bf82ed08748fc7e814d0b94299c492d24f22aab1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2ea3a82be3b607c9b8097516b3548791940053bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8900f66b_01e90e80","updated":"2021-12-04 18:09:49.000000000","message":"Thanks Carlos, mostly LGTM - couple of comments inline. Could you also add a bug fix reno?","commit_id":"8ce2373bc4e6f8fc21b4ccccb3810cf8d39ff76a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b65c57e209dc361a303160900a9ab4717b0165fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e0232409_dfcafaf0","updated":"2021-12-06 21:40:17.000000000","message":"LGTM; following up on the dict conversion conversation from the last patch.. thanks Carlos","commit_id":"281e9240c54ec34b52b9190fa340d81fa4b53616"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"cb7d18fd575a58daea8014b69b5546896b76e2f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"529e0622_1b1ad81d","updated":"2021-12-12 02:11:38.000000000","message":"Thank you carlos for addressing this bug! The NetApp CI is skipping migration test (I dont think the tempest covers this bug scenario, though). I reproduced the bug in my env, then I applied your patch, unfortunately, it didn\u0027t work. The error log is showing here [1]. From my quick investigation, it seems that it\u0027s sending down the source_share as the dest_share entity.\n\nThe NetApp driver requests to the storages if the source can be moved to dest [2]. The name of the share is retrieved from the ID of source share [3]. This last is coming with the ID of the destination.\n\n[1] https://paste.opendev.org/show/811624/\n[2]https://github.com/openstack/manila/blob/master/manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py#L3241\n[3]https://github.com/openstack/manila/blob/master/manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py#L3230","commit_id":"281e9240c54ec34b52b9190fa340d81fa4b53616"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"294cb295306915378d607d4b935d9ba737eab46f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ff709f4c_a61bd24c","updated":"2021-12-16 14:13:22.000000000","message":"Thanks for reviewing, Felipe.\nPlease check the modifications inline","commit_id":"281e9240c54ec34b52b9190fa340d81fa4b53616"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e80dcc1c5a95e793d46322ca5d81aab1003f4261","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c9e151c7_8267defa","updated":"2021-12-06 18:33:35.000000000","message":"Thanks for reviewing, Goutham! Please check answers and changes inline :)","commit_id":"281e9240c54ec34b52b9190fa340d81fa4b53616"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b64924076d3dc39453458e02362dc8d355f270be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"244ccc7e_87bf2fc1","updated":"2021-12-23 19:32:43.000000000","message":"I will hazard a vote that the latest patch fixes Felipe\u0027s concerns. Felipe, would you please run your tests again and qualify this? Thanks both of you!","commit_id":"af3513d2b0f7bbcc968a4c445243de40d94714aa"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"b94f67a286de90d52564cdfae839044517e97fe1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6f7cbc55_15a2b868","updated":"2022-01-09 20:40:19.000000000","message":"Thank you Carlos, I tested in my env and it\u0027s working fine! Great job!","commit_id":"af3513d2b0f7bbcc968a4c445243de40d94714aa"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"eee5046a08ffa36b34ec2c52a02f1639d45d3cb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"db075906_9829e4bf","updated":"2022-01-13 17:27:16.000000000","message":"Thanks Carlos! Lets merge this patch and, if needed, please provide updates based on Carthaca\u0027s comments. This patch set was already tested by NetApp devs. So lets proceed.","commit_id":"af3513d2b0f7bbcc968a4c445243de40d94714aa"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d9b949ea69fc96726acf40b9ee2a36f7bed42155","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"35ebba1a_6403e1e1","updated":"2022-01-13 22:23:34.000000000","message":"Thanks for reviewing, folks. Addressed the comments in a follow-up change :)","commit_id":"af3513d2b0f7bbcc968a4c445243de40d94714aa"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"f3df624b94c46c5456257d6f0792d0702b0fba8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bb060525_7a68a2eb","updated":"2022-01-13 16:44:58.000000000","message":"Thanks, lgtm. Inline I just have some non-functional grammar questions ;)","commit_id":"af3513d2b0f7bbcc968a4c445243de40d94714aa"}],"manila/share/manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2ea3a82be3b607c9b8097516b3548791940053bf","unresolved":true,"context_lines":[{"line_number":1098,"context_line":"                    dest_share_server \u003d helper.wait_for_share_server("},{"line_number":1099,"context_line":"                        dest_share_server_id)"},{"line_number":1100,"context_line":"                else:"},{"line_number":1101,"context_line":"                    dest_share_server \u003d self._get_share_server_dict("},{"line_number":1102,"context_line":"                        context, share_server)"},{"line_number":1103,"context_line":"                    src_share_instance \u003d self.db.share_instance_update("},{"line_number":1104,"context_line":"                        context,"},{"line_number":1105,"context_line":"                        dest_share_instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fb1f4dd3_57540b67","line":1102,"range":{"start_line":1101,"start_character":20,"end_line":1102,"end_character":46},"updated":"2021-12-04 18:09:49.000000000","message":"would this be better if we made this dict conversion for both cases (disruptive vs nondisruptive) prior to the driver call on line 1203?","commit_id":"8ce2373bc4e6f8fc21b4ccccb3810cf8d39ff76a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"deaf90d78ced3f9a4faf29f09c5501b53306db54","unresolved":true,"context_lines":[{"line_number":1098,"context_line":"                    dest_share_server \u003d helper.wait_for_share_server("},{"line_number":1099,"context_line":"                        dest_share_server_id)"},{"line_number":1100,"context_line":"                else:"},{"line_number":1101,"context_line":"                    dest_share_server \u003d self._get_share_server_dict("},{"line_number":1102,"context_line":"                        context, share_server)"},{"line_number":1103,"context_line":"                    src_share_instance \u003d self.db.share_instance_update("},{"line_number":1104,"context_line":"                        context,"},{"line_number":1105,"context_line":"                        dest_share_instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"4e20a231_3d222631","line":1102,"range":{"start_line":1101,"start_character":20,"end_line":1102,"end_character":46},"in_reply_to":"10c15dbd_84b4c870","updated":"2021-12-07 17:23:55.000000000","message":"It isn\u0027t strictly necessary to have it here, and in he update we could use share_server[\u0027id\u0027] instead. The only reason I reused this dict conversion was to copy the content of the source share server and then forward it on line 1113...\nA dest_share_server \u003d share_server would work just fine here :)","commit_id":"8ce2373bc4e6f8fc21b4ccccb3810cf8d39ff76a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b65c57e209dc361a303160900a9ab4717b0165fb","unresolved":true,"context_lines":[{"line_number":1098,"context_line":"                    dest_share_server \u003d helper.wait_for_share_server("},{"line_number":1099,"context_line":"                        dest_share_server_id)"},{"line_number":1100,"context_line":"                else:"},{"line_number":1101,"context_line":"                    dest_share_server \u003d self._get_share_server_dict("},{"line_number":1102,"context_line":"                        context, share_server)"},{"line_number":1103,"context_line":"                    src_share_instance \u003d self.db.share_instance_update("},{"line_number":1104,"context_line":"                        context,"},{"line_number":1105,"context_line":"                        dest_share_instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"10c15dbd_84b4c870","line":1102,"range":{"start_line":1101,"start_character":20,"end_line":1102,"end_character":46},"in_reply_to":"ebb5d766_123e9132","updated":"2021-12-06 21:40:17.000000000","message":"But why would you need it here though? I agree its been problematic sending db objects down to the driver; but the next line\u0027s just a regular database update... what am i missing? 😊\n\nthe next driver update that i see is line 1113.","commit_id":"8ce2373bc4e6f8fc21b4ccccb3810cf8d39ff76a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e80dcc1c5a95e793d46322ca5d81aab1003f4261","unresolved":true,"context_lines":[{"line_number":1098,"context_line":"                    dest_share_server \u003d helper.wait_for_share_server("},{"line_number":1099,"context_line":"                        dest_share_server_id)"},{"line_number":1100,"context_line":"                else:"},{"line_number":1101,"context_line":"                    dest_share_server \u003d self._get_share_server_dict("},{"line_number":1102,"context_line":"                        context, share_server)"},{"line_number":1103,"context_line":"                    src_share_instance \u003d self.db.share_instance_update("},{"line_number":1104,"context_line":"                        context,"},{"line_number":1105,"context_line":"                        dest_share_instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"ebb5d766_123e9132","line":1102,"range":{"start_line":1101,"start_character":20,"end_line":1102,"end_character":46},"in_reply_to":"fb1f4dd3_57540b67","updated":"2021-12-06 18:33:35.000000000","message":"That would work too, but the main thing here is not the conversion itself, it\u0027s only an alternative way to get the information we need from the source share server, and \"copy\" it to the destination share server. I know there is copy.copy but we had issues with lazy loading + copy iirc... so I thought it would be better to reuse this method that has proven a good choice to get the content from an object :)","commit_id":"8ce2373bc4e6f8fc21b4ccccb3810cf8d39ff76a"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"cb7d18fd575a58daea8014b69b5546896b76e2f4","unresolved":true,"context_lines":[{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"        try:"},{"line_number":1075,"context_line":"            if dest_share_instance[\u0027share_network_id\u0027]:"},{"line_number":1076,"context_line":"                # NOTE(carloss): Let manila/the share driver chose the share"},{"line_number":1077,"context_line":"                # server only case a disruptive migration was requested. If a"},{"line_number":1078,"context_line":"                # share migration is meant to be nondisruptive, we should not"},{"line_number":1079,"context_line":"                # allow manila nor the driver to chose on which share server"}],"source_content_type":"text/x-python","patch_set":3,"id":"f33cf0f9_8f58bf79","line":1076,"range":{"start_line":1076,"start_character":17,"end_line":1076,"end_character":30},"updated":"2021-12-12 02:11:38.000000000","message":"particularly, I thought this NOTE a bit long. Could it be summerized in more small words ? What do you think ?\nThe point here is straight forward: Nondisruptive migration -\u003e same share server to keep export location, done.\n\nNOTE(carloss): For nondisruptive migration request, it MUST NOT change the share server, otherwise the share\u0027s export location will change, disconnecting the user. Disruptive migration requests to the driver the share server.\nif nondisruptive:\n....\n\nelse:\n...","commit_id":"281e9240c54ec34b52b9190fa340d81fa4b53616"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"294cb295306915378d607d4b935d9ba737eab46f","unresolved":false,"context_lines":[{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"        try:"},{"line_number":1075,"context_line":"            if dest_share_instance[\u0027share_network_id\u0027]:"},{"line_number":1076,"context_line":"                # NOTE(carloss): Let manila/the share driver chose the share"},{"line_number":1077,"context_line":"                # server only case a disruptive migration was requested. If a"},{"line_number":1078,"context_line":"                # share migration is meant to be nondisruptive, we should not"},{"line_number":1079,"context_line":"                # allow manila nor the driver to chose on which share server"}],"source_content_type":"text/x-python","patch_set":3,"id":"49f0783b_69e76678","line":1076,"range":{"start_line":1076,"start_character":17,"end_line":1076,"end_character":30},"in_reply_to":"f33cf0f9_8f58bf79","updated":"2021-12-16 14:13:22.000000000","message":"Done","commit_id":"281e9240c54ec34b52b9190fa340d81fa4b53616"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"cb7d18fd575a58daea8014b69b5546896b76e2f4","unresolved":true,"context_lines":[{"line_number":1075,"context_line":"            if dest_share_instance[\u0027share_network_id\u0027]:"},{"line_number":1076,"context_line":"                # NOTE(carloss): Let manila/the share driver chose the share"},{"line_number":1077,"context_line":"                # server only case a disruptive migration was requested. If a"},{"line_number":1078,"context_line":"                # share migration is meant to be nondisruptive, we should not"},{"line_number":1079,"context_line":"                # allow manila nor the driver to chose on which share server"},{"line_number":1080,"context_line":"                # the migrated share will land, because the chosen share server"},{"line_number":1081,"context_line":"                # can differ from the source."}],"source_content_type":"text/x-python","patch_set":3,"id":"658f982d_72784e5d","line":1078,"range":{"start_line":1078,"start_character":67,"end_line":1078,"end_character":74},"updated":"2021-12-12 02:11:38.000000000","message":"must","commit_id":"281e9240c54ec34b52b9190fa340d81fa4b53616"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"294cb295306915378d607d4b935d9ba737eab46f","unresolved":false,"context_lines":[{"line_number":1075,"context_line":"            if dest_share_instance[\u0027share_network_id\u0027]:"},{"line_number":1076,"context_line":"                # NOTE(carloss): Let manila/the share driver chose the share"},{"line_number":1077,"context_line":"                # server only case a disruptive migration was requested. If a"},{"line_number":1078,"context_line":"                # share migration is meant to be nondisruptive, we should not"},{"line_number":1079,"context_line":"                # allow manila nor the driver to chose on which share server"},{"line_number":1080,"context_line":"                # the migrated share will land, because the chosen share server"},{"line_number":1081,"context_line":"                # can differ from the source."}],"source_content_type":"text/x-python","patch_set":3,"id":"2a789ab3_6e4ceeaf","line":1078,"range":{"start_line":1078,"start_character":67,"end_line":1078,"end_character":74},"in_reply_to":"658f982d_72784e5d","updated":"2021-12-16 14:13:22.000000000","message":"Done","commit_id":"281e9240c54ec34b52b9190fa340d81fa4b53616"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"cb7d18fd575a58daea8014b69b5546896b76e2f4","unresolved":true,"context_lines":[{"line_number":1083,"context_line":"                # same share server, considering that if the share server"},{"line_number":1084,"context_line":"                # changes, the ip allocation will also change and with it, the"},{"line_number":1085,"context_line":"                # share\u0027s export locations."},{"line_number":1086,"context_line":"                if not nondisruptive:"},{"line_number":1087,"context_line":"                    rpcapi \u003d share_rpcapi.ShareAPI()"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"                    # NOTE(ganso): Obtaining the share_server_id asynchronously"}],"source_content_type":"text/x-python","patch_set":3,"id":"4d6edd50_14b7956c","line":1086,"range":{"start_line":1086,"start_character":19,"end_line":1086,"end_character":36},"updated":"2021-12-12 02:11:38.000000000","message":"Dont need to change, just a view (nit): given that you want to cover the variable as true, it\u0027s simpler to read covering it first (at least from my view haha):\n\nif nondisruptive:\n\nelse:","commit_id":"281e9240c54ec34b52b9190fa340d81fa4b53616"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"294cb295306915378d607d4b935d9ba737eab46f","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"                # same share server, considering that if the share server"},{"line_number":1084,"context_line":"                # changes, the ip allocation will also change and with it, the"},{"line_number":1085,"context_line":"                # share\u0027s export locations."},{"line_number":1086,"context_line":"                if not nondisruptive:"},{"line_number":1087,"context_line":"                    rpcapi \u003d share_rpcapi.ShareAPI()"},{"line_number":1088,"context_line":""},{"line_number":1089,"context_line":"                    # NOTE(ganso): Obtaining the share_server_id asynchronously"}],"source_content_type":"text/x-python","patch_set":3,"id":"ec988158_6ad3d917","line":1086,"range":{"start_line":1086,"start_character":19,"end_line":1086,"end_character":36},"in_reply_to":"4d6edd50_14b7956c","updated":"2021-12-16 14:13:22.000000000","message":"Done","commit_id":"281e9240c54ec34b52b9190fa340d81fa4b53616"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"cb7d18fd575a58daea8014b69b5546896b76e2f4","unresolved":true,"context_lines":[{"line_number":1100,"context_line":"                else:"},{"line_number":1101,"context_line":"                    dest_share_server \u003d self._get_share_server_dict("},{"line_number":1102,"context_line":"                        context, share_server)"},{"line_number":1103,"context_line":"                    src_share_instance \u003d self.db.share_instance_update("},{"line_number":1104,"context_line":"                        context,"},{"line_number":1105,"context_line":"                        dest_share_instance[\u0027id\u0027],"},{"line_number":1106,"context_line":"                        {\u0027share_server_id\u0027: dest_share_server[\u0027id\u0027]},"}],"source_content_type":"text/x-python","patch_set":3,"id":"9c23e9af_7ae56ec2","line":1103,"range":{"start_line":1103,"start_character":20,"end_line":1103,"end_character":39},"updated":"2021-12-12 02:11:38.000000000","message":"is it correct ?  the source share instance sent to the driver will have the destintion\u0027s ID, which causes error. Please, review my comment on the vote.","commit_id":"281e9240c54ec34b52b9190fa340d81fa4b53616"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"294cb295306915378d607d4b935d9ba737eab46f","unresolved":false,"context_lines":[{"line_number":1100,"context_line":"                else:"},{"line_number":1101,"context_line":"                    dest_share_server \u003d self._get_share_server_dict("},{"line_number":1102,"context_line":"                        context, share_server)"},{"line_number":1103,"context_line":"                    src_share_instance \u003d self.db.share_instance_update("},{"line_number":1104,"context_line":"                        context,"},{"line_number":1105,"context_line":"                        dest_share_instance[\u0027id\u0027],"},{"line_number":1106,"context_line":"                        {\u0027share_server_id\u0027: dest_share_server[\u0027id\u0027]},"}],"source_content_type":"text/x-python","patch_set":3,"id":"0d6e7e5b_82770ec4","line":1103,"range":{"start_line":1103,"start_character":20,"end_line":1103,"end_character":39},"in_reply_to":"9c23e9af_7ae56ec2","updated":"2021-12-16 14:13:22.000000000","message":"nope, it\u0027s supposed to be the dest","commit_id":"281e9240c54ec34b52b9190fa340d81fa4b53616"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"f3df624b94c46c5456257d6f0792d0702b0fba8d","unresolved":true,"context_lines":[{"line_number":1075,"context_line":"            if dest_share_instance[\u0027share_network_id\u0027]:"},{"line_number":1076,"context_line":"                # NOTE(carloss): For a nondisruptive migration request, we must"},{"line_number":1077,"context_line":"                # not change the share server, otherwise the share\u0027s export"},{"line_number":1078,"context_line":"                # location will change, disconnecting the user. Disruptive"},{"line_number":1079,"context_line":"                # migration requests to the driver the share server."},{"line_number":1080,"context_line":"                if nondisruptive:"},{"line_number":1081,"context_line":"                    dest_share_server \u003d self._get_share_server_dict("},{"line_number":1082,"context_line":"                        context, share_server)"}],"source_content_type":"text/x-python","patch_set":5,"id":"567d89c3_1ac4ace3","line":1079,"range":{"start_line":1078,"start_character":64,"end_line":1079,"end_character":68},"updated":"2022-01-13 16:44:58.000000000","message":"Is \u0027requests\u0027 the verb here?\n\nMaybe: \"Disruptive migration requests the share server from the driver\"\nI\u0027m not a native speaker either..","commit_id":"af3513d2b0f7bbcc968a4c445243de40d94714aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9c1268d6a27d55b5dd40529f4c38f2ee975eaa9","unresolved":true,"context_lines":[{"line_number":1075,"context_line":"            if dest_share_instance[\u0027share_network_id\u0027]:"},{"line_number":1076,"context_line":"                # NOTE(carloss): For a nondisruptive migration request, we must"},{"line_number":1077,"context_line":"                # not change the share server, otherwise the share\u0027s export"},{"line_number":1078,"context_line":"                # location will change, disconnecting the user. Disruptive"},{"line_number":1079,"context_line":"                # migration requests to the driver the share server."},{"line_number":1080,"context_line":"                if nondisruptive:"},{"line_number":1081,"context_line":"                    dest_share_server \u003d self._get_share_server_dict("},{"line_number":1082,"context_line":"                        context, share_server)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7dc5fc5c_863e922e","line":1079,"range":{"start_line":1078,"start_character":64,"end_line":1079,"end_character":68},"in_reply_to":"567d89c3_1ac4ace3","updated":"2022-01-13 19:50:08.000000000","message":"yes; not a native speaker either but your version sounds correct; and would encourage this fix.","commit_id":"af3513d2b0f7bbcc968a4c445243de40d94714aa"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d9b949ea69fc96726acf40b9ee2a36f7bed42155","unresolved":false,"context_lines":[{"line_number":1075,"context_line":"            if dest_share_instance[\u0027share_network_id\u0027]:"},{"line_number":1076,"context_line":"                # NOTE(carloss): For a nondisruptive migration request, we must"},{"line_number":1077,"context_line":"                # not change the share server, otherwise the share\u0027s export"},{"line_number":1078,"context_line":"                # location will change, disconnecting the user. Disruptive"},{"line_number":1079,"context_line":"                # migration requests to the driver the share server."},{"line_number":1080,"context_line":"                if nondisruptive:"},{"line_number":1081,"context_line":"                    dest_share_server \u003d self._get_share_server_dict("},{"line_number":1082,"context_line":"                        context, share_server)"}],"source_content_type":"text/x-python","patch_set":5,"id":"afbfddbd_dec0c720","line":1079,"range":{"start_line":1078,"start_character":64,"end_line":1079,"end_character":68},"in_reply_to":"7dc5fc5c_863e922e","updated":"2022-01-13 22:23:34.000000000","message":"Thanks for the suggestion, addressed in a new change [1] :)\n[1] https://review.opendev.org/c/openstack/manila/+/824652","commit_id":"af3513d2b0f7bbcc968a4c445243de40d94714aa"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"eee5046a08ffa36b34ec2c52a02f1639d45d3cb0","unresolved":true,"context_lines":[{"line_number":1078,"context_line":"                # location will change, disconnecting the user. Disruptive"},{"line_number":1079,"context_line":"                # migration requests to the driver the share server."},{"line_number":1080,"context_line":"                if nondisruptive:"},{"line_number":1081,"context_line":"                    dest_share_server \u003d self._get_share_server_dict("},{"line_number":1082,"context_line":"                        context, share_server)"},{"line_number":1083,"context_line":"                    dest_share_instance \u003d self.db.share_instance_update("},{"line_number":1084,"context_line":"                        context,"},{"line_number":1085,"context_line":"                        dest_share_instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"2f8a5b30_27360722","line":1082,"range":{"start_line":1081,"start_character":0,"end_line":1082,"end_character":46},"updated":"2022-01-13 17:27:16.000000000","message":"I see that there was a discussion around returning in dict format here. No objections against it from my point of view, since you will send this object to drivers.\nI not 100% in favor of hardcoding things here, I always prefer to move the decision to the drivers. But atm, I can\u0027t see how a nondisruptive would behave differently. So I\u0027m ok with that fix.","commit_id":"af3513d2b0f7bbcc968a4c445243de40d94714aa"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d9b949ea69fc96726acf40b9ee2a36f7bed42155","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"                # location will change, disconnecting the user. Disruptive"},{"line_number":1079,"context_line":"                # migration requests to the driver the share server."},{"line_number":1080,"context_line":"                if nondisruptive:"},{"line_number":1081,"context_line":"                    dest_share_server \u003d self._get_share_server_dict("},{"line_number":1082,"context_line":"                        context, share_server)"},{"line_number":1083,"context_line":"                    dest_share_instance \u003d self.db.share_instance_update("},{"line_number":1084,"context_line":"                        context,"},{"line_number":1085,"context_line":"                        dest_share_instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"8f839344_3797b6b0","line":1082,"range":{"start_line":1081,"start_character":0,"end_line":1082,"end_character":46},"in_reply_to":"2f8a5b30_27360722","updated":"2022-01-13 22:23:34.000000000","message":"Ack","commit_id":"af3513d2b0f7bbcc968a4c445243de40d94714aa"}],"manila/tests/share/drivers/dummy.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2ea3a82be3b607c9b8097516b3548791940053bf","unresolved":true,"context_lines":[{"line_number":427,"context_line":"        \"\"\"Tears down share server.\"\"\""},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    @slow_me_down"},{"line_number":430,"context_line":"    def _get_pools_info(self):"},{"line_number":431,"context_line":"        pools \u003d []"},{"line_number":432,"context_line":"        for i in range(2):"},{"line_number":433,"context_line":"            pool_name \u003d \"fake_pool_\" + str(i) + \"_for_%s\" % self.backend_name"},{"line_number":434,"context_line":"            new_pool \u003d {"},{"line_number":435,"context_line":"                \"pool_name\": pool_name,"},{"line_number":436,"context_line":"                \"total_capacity_gb\": 1230.0,"},{"line_number":437,"context_line":"                \"free_capacity_gb\": 1210.0,"},{"line_number":438,"context_line":"                \"reserved_percentage\":"},{"line_number":439,"context_line":"                    self.configuration.reserved_share_percentage,"},{"line_number":440,"context_line":"                \"reserved_snapshot_percentage\":"},{"line_number":441,"context_line":"                    self.configuration.reserved_share_from_snapshot_percentage"},{"line_number":442,"context_line":"            }"},{"line_number":443,"context_line":"            if self.configuration.replication_domain:"},{"line_number":444,"context_line":"                new_pool[\"replication_type\"] \u003d \"readable\""},{"line_number":445,"context_line":"            pools.append(new_pool)"},{"line_number":446,"context_line":"        return pools"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @slow_me_down"},{"line_number":449,"context_line":"    def _update_share_stats(self, data\u003dNone):"},{"line_number":450,"context_line":"        \"\"\"Retrieve stats info from share group.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"78c953c1_882e3379","line":447,"range":{"start_line":430,"start_character":3,"end_line":447,"end_character":0},"updated":"2021-12-04 18:09:49.000000000","message":"good enhancement, but is unrelated to this change?","commit_id":"8ce2373bc4e6f8fc21b4ccccb3810cf8d39ff76a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e80dcc1c5a95e793d46322ca5d81aab1003f4261","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        \"\"\"Tears down share server.\"\"\""},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    @slow_me_down"},{"line_number":430,"context_line":"    def _get_pools_info(self):"},{"line_number":431,"context_line":"        pools \u003d []"},{"line_number":432,"context_line":"        for i in range(2):"},{"line_number":433,"context_line":"            pool_name \u003d \"fake_pool_\" + str(i) + \"_for_%s\" % self.backend_name"},{"line_number":434,"context_line":"            new_pool \u003d {"},{"line_number":435,"context_line":"                \"pool_name\": pool_name,"},{"line_number":436,"context_line":"                \"total_capacity_gb\": 1230.0,"},{"line_number":437,"context_line":"                \"free_capacity_gb\": 1210.0,"},{"line_number":438,"context_line":"                \"reserved_percentage\":"},{"line_number":439,"context_line":"                    self.configuration.reserved_share_percentage,"},{"line_number":440,"context_line":"                \"reserved_snapshot_percentage\":"},{"line_number":441,"context_line":"                    self.configuration.reserved_share_from_snapshot_percentage"},{"line_number":442,"context_line":"            }"},{"line_number":443,"context_line":"            if self.configuration.replication_domain:"},{"line_number":444,"context_line":"                new_pool[\"replication_type\"] \u003d \"readable\""},{"line_number":445,"context_line":"            pools.append(new_pool)"},{"line_number":446,"context_line":"        return pools"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @slow_me_down"},{"line_number":449,"context_line":"    def _update_share_stats(self, data\u003dNone):"},{"line_number":450,"context_line":"        \"\"\"Retrieve stats info from share group.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"2384018d_11e05c6f","line":447,"range":{"start_line":430,"start_character":3,"end_line":447,"end_character":0},"in_reply_to":"78c953c1_882e3379","updated":"2021-12-06 18:33:35.000000000","message":"Commited this unintentionally :p\nSorry about that... I can add this in a separate change if this is worth it :)","commit_id":"8ce2373bc4e6f8fc21b4ccccb3810cf8d39ff76a"}],"manila/tests/share/test_manager.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"cb7d18fd575a58daea8014b69b5546896b76e2f4","unresolved":true,"context_lines":[{"line_number":5503,"context_line":"                self.context, migrating_instance[\u0027id\u0027],"},{"line_number":5504,"context_line":"                {\u0027share_server_id\u0027: src_server[\u0027id\u0027]},"},{"line_number":5505,"context_line":"                with_share_data\u003dTrue"},{"line_number":5506,"context_line":"            )"},{"line_number":5507,"context_line":"        (api.API.create_share_instance_and_get_request_spec."},{"line_number":5508,"context_line":"         assert_called_once_with(self.context, share, \u0027fake_az_id\u0027, None,"},{"line_number":5509,"context_line":"                                 \u0027fake_host\u0027, \u0027fake_net_id\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f71cd781_7a46025a","line":5506,"updated":"2021-12-12 02:11:38.000000000","message":"Maybe, you could check that the driver is not beeing called (that\u0027s the fix):\n\n rpcapi.ShareAPI.provide_share_server.assert_not_called() \n rpcapi.ShareAPI.create_share_server.assert_not_called()","commit_id":"281e9240c54ec34b52b9190fa340d81fa4b53616"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"294cb295306915378d607d4b935d9ba737eab46f","unresolved":false,"context_lines":[{"line_number":5503,"context_line":"                self.context, migrating_instance[\u0027id\u0027],"},{"line_number":5504,"context_line":"                {\u0027share_server_id\u0027: src_server[\u0027id\u0027]},"},{"line_number":5505,"context_line":"                with_share_data\u003dTrue"},{"line_number":5506,"context_line":"            )"},{"line_number":5507,"context_line":"        (api.API.create_share_instance_and_get_request_spec."},{"line_number":5508,"context_line":"         assert_called_once_with(self.context, share, \u0027fake_az_id\u0027, None,"},{"line_number":5509,"context_line":"                                 \u0027fake_host\u0027, \u0027fake_net_id\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"21a20eb9_ab6d92c6","line":5506,"in_reply_to":"f71cd781_7a46025a","updated":"2021-12-16 14:13:22.000000000","message":"Done","commit_id":"281e9240c54ec34b52b9190fa340d81fa4b53616"}]}