)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eb1968e618f59ce435daf2285e5290b9b54a3935","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8e4ff71c_af408707","updated":"2021-12-02 23:09:48.000000000","message":"Thank you for the bugfix Megharth! I have a couple of minor comments regarding test assertions. Please take a look! the functional jobs running on the CI are currently affected by a change in devstack; we\u0027re attempting to get that fixed here: https://review.opendev.org/c/openstack/manila/+/820259\n\nMeanwhile, this change is also missing a release note. It\u0027s useful to have one so we can let deployers know what changed. Can you please add it: https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html\n\nThis is a hard-to-hit bug, and a harder one to describe in the release note; I would suggest something like this:\n\n fixes: | \n   Fixed an issue during snapshot creation where a database error was being mishandled with\n   dead code. See `Launchpad bug 1475351 \u003chttps://launchpad.net/bugs/1475351\u003e`_ for more details.\n  ","commit_id":"c1d32c988dddf58772b39163700c5db1edb54764"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"03ca8c3eca2e4569a026277bdeacbb1f83dcb8fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ab37ccdd_29f7ea7c","updated":"2021-12-03 14:58:45.000000000","message":"recheck\n\nthe bugfix to manila\u0027s devstack script has now merged","commit_id":"c1d32c988dddf58772b39163700c5db1edb54764"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e92a15da5b425987e4cca15e141013dafb12daed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1d59ce7e_09f0865b","updated":"2021-12-03 22:04:14.000000000","message":"Looks good to me! Thank you for this fix, Mergharth!","commit_id":"a6177bcc0d533089eff509cc62d5313d4aaa44ba"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ebbae05f59c9ea423d330de1e00447aeea398fe7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0f61ee33_1a0c91ad","updated":"2021-12-03 21:52:27.000000000","message":"Looks great! Thanks Megharth! ","commit_id":"a6177bcc0d533089eff509cc62d5313d4aaa44ba"}],"manila/tests/share/test_api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eb1968e618f59ce435daf2285e5290b9b54a3935","unresolved":true,"context_lines":[{"line_number":2247,"context_line":"                          self.context, share,"},{"line_number":2248,"context_line":"                          \u0027fake_name\u0027, \u0027fake_desc\u0027)"},{"line_number":2249,"context_line":""},{"line_number":2250,"context_line":"        self.assertTrue(mock_db_share_snapshot_create.called)"},{"line_number":2251,"context_line":""},{"line_number":2252,"context_line":"    def test_create_snapshot_quota_commit_fail(self):"},{"line_number":2253,"context_line":"        share \u003d fakes.fake_share("}],"source_content_type":"text/x-python","patch_set":1,"id":"be3d477a_ae82d6ce","line":2250,"range":{"start_line":2250,"start_character":0,"end_line":2250,"end_character":61},"updated":"2021-12-02 23:09:48.000000000","message":"i\u0027d also suggest mocking the \"rollback\" method from quotas:\n\n  self.mock_object(quota.QUOTAS, \u0027rollback\u0027)\n\n\nand asserting rollback was called:\n\n QUOTAS.rollback.assert_called_once_with(self.context, \n                        mock.ANY,\n                        share_type_id\u003dshare[\u0027instance\u0027][\u0027share_type_id\u0027])","commit_id":"c1d32c988dddf58772b39163700c5db1edb54764"},{"author":{"_account_id":34056,"name":"Megharth Lakhataria","email":"m.c.lakhataria@gmail.com","username":"megharth"},"change_message_id":"884bbadc71b908ead68d441bd73579df9313865e","unresolved":false,"context_lines":[{"line_number":2247,"context_line":"                          self.context, share,"},{"line_number":2248,"context_line":"                          \u0027fake_name\u0027, \u0027fake_desc\u0027)"},{"line_number":2249,"context_line":""},{"line_number":2250,"context_line":"        self.assertTrue(mock_db_share_snapshot_create.called)"},{"line_number":2251,"context_line":""},{"line_number":2252,"context_line":"    def test_create_snapshot_quota_commit_fail(self):"},{"line_number":2253,"context_line":"        share \u003d fakes.fake_share("}],"source_content_type":"text/x-python","patch_set":1,"id":"72c38b22_51206e6a","line":2250,"range":{"start_line":2250,"start_character":0,"end_line":2250,"end_character":61},"in_reply_to":"be3d477a_ae82d6ce","updated":"2021-12-03 18:02:47.000000000","message":"Ack","commit_id":"c1d32c988dddf58772b39163700c5db1edb54764"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eb1968e618f59ce435daf2285e5290b9b54a3935","unresolved":true,"context_lines":[{"line_number":2266,"context_line":"        self.assertRaises(exception.QuotaError,"},{"line_number":2267,"context_line":"                          self.api.create_snapshot,"},{"line_number":2268,"context_line":"                          self.context, share,"},{"line_number":2269,"context_line":"                          \u0027fake_name\u0027, \u0027fake_desc\u0027)"},{"line_number":2270,"context_line":""},{"line_number":2271,"context_line":"    @ddt.data({\u0027use_scheduler\u0027: False, \u0027valid_host\u0027: \u0027fake\u0027,"},{"line_number":2272,"context_line":"               \u0027az\u0027: None},"}],"source_content_type":"text/x-python","patch_set":1,"id":"f05fca33_b556625c","line":2269,"range":{"start_line":2269,"start_character":50,"end_line":2269,"end_character":51},"updated":"2021-12-02 23:09:48.000000000","message":"and assert here that the rollback was called:\n\n\n QUOTAS.rollback.assert_called_once_with(self.context, \n                        mock.ANY,\n                        share_type_id\u003dshare[\u0027instance\u0027][\u0027share_type_id\u0027])\n\n\n\n\n\n(mock.ANY in place of reservations specifies that we don\u0027t care about what was passed in specifically, we\u0027re not mocking the output of the \"QUOTAS.reserve\" method - which we could if we wanted to, but not a biggie)","commit_id":"c1d32c988dddf58772b39163700c5db1edb54764"},{"author":{"_account_id":34056,"name":"Megharth Lakhataria","email":"m.c.lakhataria@gmail.com","username":"megharth"},"change_message_id":"884bbadc71b908ead68d441bd73579df9313865e","unresolved":false,"context_lines":[{"line_number":2266,"context_line":"        self.assertRaises(exception.QuotaError,"},{"line_number":2267,"context_line":"                          self.api.create_snapshot,"},{"line_number":2268,"context_line":"                          self.context, share,"},{"line_number":2269,"context_line":"                          \u0027fake_name\u0027, \u0027fake_desc\u0027)"},{"line_number":2270,"context_line":""},{"line_number":2271,"context_line":"    @ddt.data({\u0027use_scheduler\u0027: False, \u0027valid_host\u0027: \u0027fake\u0027,"},{"line_number":2272,"context_line":"               \u0027az\u0027: None},"}],"source_content_type":"text/x-python","patch_set":1,"id":"d15b9fd8_a127fd7d","line":2269,"range":{"start_line":2269,"start_character":50,"end_line":2269,"end_character":51},"in_reply_to":"f05fca33_b556625c","updated":"2021-12-03 18:02:47.000000000","message":"Ack","commit_id":"c1d32c988dddf58772b39163700c5db1edb54764"}]}