)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2bb4ec5524cea71ad8e545289527f58f4ec9dc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"792c8942_412075de","updated":"2021-12-07 19:16:40.000000000","message":"Hi Fabio, thanks for submitting this bugfix, please take a look at the comments inline. ","commit_id":"7cd7a34d16041457012e2e840a36a75f733d1c25"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"29d376b7e7fd7327265da82c46a208c57a3986a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e08c76b9_fb727145","updated":"2021-12-10 11:44:09.000000000","message":"LGTM, thank you Fabio! ","commit_id":"9417ece45629d4103d2b37a593dfbcc7e774362c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"65f72197c80c462d7ba07b0ea43969172fb178dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6eca45da_ff6fb729","updated":"2021-12-09 20:02:13.000000000","message":"LGTM, thanks Fabio!","commit_id":"9417ece45629d4103d2b37a593dfbcc7e774362c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ab0a8e189b20e90be422b14f367640bbc8b83e53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"636e7a43_79fd1dc3","updated":"2021-12-14 12:27:40.000000000","message":"Thank you for proposing this fix, Fábio!\nLGTM","commit_id":"9417ece45629d4103d2b37a593dfbcc7e774362c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"c2b190ab4cd0ecbcd40dacbf83e79e16b1a6372f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"69706eb8_8d66c5b7","updated":"2021-12-08 19:21:02.000000000","message":"Thank you for reviewing! Here is the new patch set.","commit_id":"9417ece45629d4103d2b37a593dfbcc7e774362c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dfa88840bb18cf6f7bb5d315d610097bd96f9cb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c1ff69e8_2f13c588","updated":"2021-12-15 20:55:39.000000000","message":"recheck","commit_id":"9417ece45629d4103d2b37a593dfbcc7e774362c"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2bb4ec5524cea71ad8e545289527f58f4ec9dc8","unresolved":true,"context_lines":[{"line_number":4920,"context_line":""},{"line_number":4921,"context_line":"        ontap_version \u003d self.get_system_version()[\u0027version-tuple\u0027]"},{"line_number":4922,"context_line":"        ontapi_version \u003d self.get_ontapi_version(cached\u003dTrue)"},{"line_number":4923,"context_line":"        if ontap_version \u003e\u003d (9, 1, 0) and ontapi_version \u003e\u003d (1, 110):"},{"line_number":4924,"context_line":"            if self.features.FLEXVOL_ENCRYPTION and encrypt_destination:"},{"line_number":4925,"context_line":"                api_args[\u0027encrypt-destination\u0027] \u003d \u0027true\u0027"},{"line_number":4926,"context_line":"            elif encrypt_destination:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f242ac6d_9887fd26","line":4923,"range":{"start_line":4923,"start_character":0,"end_line":4923,"end_character":69},"updated":"2021-12-07 19:16:40.000000000","message":"The check for the ONTAPI version is performed in initializing the \"self.features\" object, so no need to get the ontapi version again: https://github.com/openstack/manila/blob/9f3c566a10fe649919bee38f1ea839062b97cc01/manila/share/drivers/netapp/dataontap/client/client_cmode.py#L92\n\nIs \"encrypt-destination\" a mandatory parameter?\n\nIf not, it feels like you could avoid the \"else\" part altogether:\n\n      if self.features.FLEXVOL_ENCRYPTION:\n            if encrypt_destination:\n                api_args[\u0027encrypt-destination\u0027] \u003d \u0027true\u0027\n            else:\n                api_args[\u0027encrypt-destination\u0027] \u003d \u0027false\u0027\n      elif encrypt_destination:\n            msg \u003d \u0027Flexvol encryption is not supported on this backend.\u0027\n            raise exception.NetAppException(msg)\n\n\n\nWouldn\u0027t that satisfy older and newer ONTAP environments and the logic this is trying to implement?","commit_id":"7cd7a34d16041457012e2e840a36a75f733d1c25"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"c2b190ab4cd0ecbcd40dacbf83e79e16b1a6372f","unresolved":false,"context_lines":[{"line_number":4920,"context_line":""},{"line_number":4921,"context_line":"        ontap_version \u003d self.get_system_version()[\u0027version-tuple\u0027]"},{"line_number":4922,"context_line":"        ontapi_version \u003d self.get_ontapi_version(cached\u003dTrue)"},{"line_number":4923,"context_line":"        if ontap_version \u003e\u003d (9, 1, 0) and ontapi_version \u003e\u003d (1, 110):"},{"line_number":4924,"context_line":"            if self.features.FLEXVOL_ENCRYPTION and encrypt_destination:"},{"line_number":4925,"context_line":"                api_args[\u0027encrypt-destination\u0027] \u003d \u0027true\u0027"},{"line_number":4926,"context_line":"            elif encrypt_destination:"}],"source_content_type":"text/x-python","patch_set":1,"id":"cdc5a912_c57ed0d7","line":4923,"range":{"start_line":4923,"start_character":0,"end_line":4923,"end_character":69},"in_reply_to":"f242ac6d_9887fd26","updated":"2021-12-08 19:21:02.000000000","message":"Totally missed that, thank you Goutham.\n\n\u003e Is \"encrypt-destination\" a mandatory parameter?\nNo, it isn\u0027t.\n\n\u003e Wouldn\u0027t that satisfy older and newer ONTAP environments and the logic this is trying to implement?\nAck.","commit_id":"7cd7a34d16041457012e2e840a36a75f733d1c25"}],"releasenotes/notes/bug-1915237-netapp-fix-encrypt-check-on-migrate-1e39bd7f19651972.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2bb4ec5524cea71ad8e545289527f58f4ec9dc8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1b016bb1_e44cc3b6","line":8,"updated":"2021-12-07 19:16:40.000000000","message":"Trim whitespace above","commit_id":"7cd7a34d16041457012e2e840a36a75f733d1c25"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"c3e43d6efd648ffd07db32fb69c2edd20802411a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"89828220_896261d2","line":8,"in_reply_to":"1b016bb1_e44cc3b6","updated":"2021-12-08 19:21:15.000000000","message":"Done","commit_id":"7cd7a34d16041457012e2e840a36a75f733d1c25"}]}