)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9d090abfbb4b44f4ea0a45f83245975e2d1e3699","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"98bb2171_c6e91cc9","updated":"2021-12-21 22:04:00.000000000","message":"LGTM, thanks for working on this fix, Victoria","commit_id":"3a1e23801fb3a0682101af3f1cc965b1ae7e0379"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"101f4eb91b3127597e8f05ed49a17b4123c89a7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7473f1e0_a3686006","updated":"2021-12-21 21:26:03.000000000","message":"Thanks Victoria, minor comments inline; would be nice to have tempest test coverage here so this stuff doesn\u0027t break again.. ","commit_id":"3a1e23801fb3a0682101af3f1cc965b1ae7e0379"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"710cda9a04995a1a951a5ac4b7565a724b52fec9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"45124b5d_eb57a25f","updated":"2021-12-21 22:21:08.000000000","message":"we can follow up in a different patch about the minor comments inline.. ","commit_id":"3a1e23801fb3a0682101af3f1cc965b1ae7e0379"}],"manila/api/common.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"101f4eb91b3127597e8f05ed49a17b4123c89a7b","unresolved":true,"context_lines":[{"line_number":270,"context_line":"    \"\"\"Parse is_public into something usable."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    :returns:"},{"line_number":273,"context_line":"        - True: API should list public share group types only"},{"line_number":274,"context_line":"        - False: API should list private share group types only"},{"line_number":275,"context_line":"        - None: API should list both public and private share group types"},{"line_number":276,"context_line":"    \"\"\""},{"line_number":277,"context_line":"    if is_public is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"21dfe2a1_8880284c","line":274,"range":{"start_line":273,"start_character":10,"end_line":274,"end_character":63},"updated":"2021-12-21 21:26:03.000000000","message":"since this is used by both share types and group types, we could make this generic:\n\n :rtype: bool\n :returns: True if is_public is None or truthy, None if \"all\", False otherwise","commit_id":"3a1e23801fb3a0682101af3f1cc965b1ae7e0379"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"2f03ee2c56c1d4e5fb0da6471777c58379c8c2da","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    \"\"\"Parse is_public into something usable."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    :returns:"},{"line_number":273,"context_line":"        - True: API should list public share group types only"},{"line_number":274,"context_line":"        - False: API should list private share group types only"},{"line_number":275,"context_line":"        - None: API should list both public and private share group types"},{"line_number":276,"context_line":"    \"\"\""},{"line_number":277,"context_line":"    if is_public is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"6497cc1a_c0004040","line":274,"range":{"start_line":273,"start_character":10,"end_line":274,"end_character":63},"in_reply_to":"21dfe2a1_8880284c","updated":"2022-01-03 11:25:33.000000000","message":"Ack","commit_id":"3a1e23801fb3a0682101af3f1cc965b1ae7e0379"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"101f4eb91b3127597e8f05ed49a17b4123c89a7b","unresolved":true,"context_lines":[{"line_number":272,"context_line":"    :returns:"},{"line_number":273,"context_line":"        - True: API should list public share group types only"},{"line_number":274,"context_line":"        - False: API should list private share group types only"},{"line_number":275,"context_line":"        - None: API should list both public and private share group types"},{"line_number":276,"context_line":"    \"\"\""},{"line_number":277,"context_line":"    if is_public is None:"},{"line_number":278,"context_line":"        # preserve default value of showing only public types"}],"source_content_type":"text/x-python","patch_set":4,"id":"2fabfe90_0d0beaec","line":275,"range":{"start_line":275,"start_character":16,"end_line":275,"end_character":73},"updated":"2021-12-21 21:26:03.000000000","message":"this isn\u0027t correct per lines 277-279\n\nNone is assumed as being True","commit_id":"3a1e23801fb3a0682101af3f1cc965b1ae7e0379"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"2f03ee2c56c1d4e5fb0da6471777c58379c8c2da","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    :returns:"},{"line_number":273,"context_line":"        - True: API should list public share group types only"},{"line_number":274,"context_line":"        - False: API should list private share group types only"},{"line_number":275,"context_line":"        - None: API should list both public and private share group types"},{"line_number":276,"context_line":"    \"\"\""},{"line_number":277,"context_line":"    if is_public is None:"},{"line_number":278,"context_line":"        # preserve default value of showing only public types"}],"source_content_type":"text/x-python","patch_set":4,"id":"6102c998_70e0160d","line":275,"range":{"start_line":275,"start_character":16,"end_line":275,"end_character":73},"in_reply_to":"2fabfe90_0d0beaec","updated":"2022-01-03 11:25:33.000000000","message":"Ack","commit_id":"3a1e23801fb3a0682101af3f1cc965b1ae7e0379"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9d090abfbb4b44f4ea0a45f83245975e2d1e3699","unresolved":true,"context_lines":[{"line_number":277,"context_line":"    if is_public is None:"},{"line_number":278,"context_line":"        # preserve default value of showing only public types"},{"line_number":279,"context_line":"        return True"},{"line_number":280,"context_line":"    elif six.text_type(is_public).lower() \u003d\u003d \"all\":"},{"line_number":281,"context_line":"        return None"},{"line_number":282,"context_line":"    else:"},{"line_number":283,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"6ee52382_e4d59201","line":280,"range":{"start_line":280,"start_character":9,"end_line":280,"end_character":33},"updated":"2021-12-21 22:04:00.000000000","message":"nit... maybe: str(is_public).lower()\nsince we are already getting rid of six :D","commit_id":"3a1e23801fb3a0682101af3f1cc965b1ae7e0379"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"2f03ee2c56c1d4e5fb0da6471777c58379c8c2da","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    if is_public is None:"},{"line_number":278,"context_line":"        # preserve default value of showing only public types"},{"line_number":279,"context_line":"        return True"},{"line_number":280,"context_line":"    elif six.text_type(is_public).lower() \u003d\u003d \"all\":"},{"line_number":281,"context_line":"        return None"},{"line_number":282,"context_line":"    else:"},{"line_number":283,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1726fc91_6e12152c","line":280,"range":{"start_line":280,"start_character":9,"end_line":280,"end_character":33},"in_reply_to":"3ee194e6_60a603a5","updated":"2022-01-03 11:25:33.000000000","message":"Ack","commit_id":"3a1e23801fb3a0682101af3f1cc965b1ae7e0379"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"710cda9a04995a1a951a5ac4b7565a724b52fec9","unresolved":true,"context_lines":[{"line_number":277,"context_line":"    if is_public is None:"},{"line_number":278,"context_line":"        # preserve default value of showing only public types"},{"line_number":279,"context_line":"        return True"},{"line_number":280,"context_line":"    elif six.text_type(is_public).lower() \u003d\u003d \"all\":"},{"line_number":281,"context_line":"        return None"},{"line_number":282,"context_line":"    else:"},{"line_number":283,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ee194e6_60a603a5","line":280,"range":{"start_line":280,"start_character":9,"end_line":280,"end_character":33},"in_reply_to":"6ee52382_e4d59201","updated":"2021-12-21 22:21:08.000000000","message":"+1","commit_id":"3a1e23801fb3a0682101af3f1cc965b1ae7e0379"}],"releasenotes/notes/bp-support-group-spec-search-share-group-type-api-df55d056b622ced7.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"101f4eb91b3127597e8f05ed49a17b4123c89a7b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Share group types can now be filtered with its group_specs."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"650622e3_6f377a65","line":3,"range":{"start_line":3,"start_character":47,"end_line":3,"end_character":50},"updated":"2021-12-21 21:26:03.000000000","message":"nit: their","commit_id":"3a1e23801fb3a0682101af3f1cc965b1ae7e0379"}]}