)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a052c71eb99170e43f6417b862b25b1c9b3c81cd","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     haixin \u003chaix09@chinatelecom.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-06 09:03:24 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove usage of six library in driver layer and the corresponding test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Replace six with Python 3 style code."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"196cf2e9_b3f8421a","line":7,"updated":"2022-01-13 18:11:50.000000000","message":"We should format the commit message as follows\n\n\"\"\"\nRemove usage of six lib for all drivers\n\nPython2 is no longer supported, so in this patch\nset we remove the usage of the six (py2 and py3\ncompatibility library) in favor of py3 syntax.\n\"\"\"\n\nAlso, is there a bug or bp we can add the reference to?","commit_id":"a626a963acfd6f2d43889a23644d22405f9c791d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"797a87772713044f2300738fb00b3dbcc3e4d3fd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     haixin \u003chaix09@chinatelecom.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-06 09:03:24 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove usage of six library in driver layer and the corresponding test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Replace six with Python 3 style code."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"b0f7745b_4aba5009","line":7,"in_reply_to":"196cf2e9_b3f8421a","updated":"2022-01-14 03:03:34.000000000","message":"Done， but there is no bug or bp for it.","commit_id":"a626a963acfd6f2d43889a23644d22405f9c791d"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"e2521c1d1f806a0420e1d1a375f2422d4ffb5221","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     haixin \u003chaix09@chinatelecom.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-06 09:03:24 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove usage of six library in driver layer and the corresponding test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Replace six with Python 3 style code."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"54840510_08c356e9","line":7,"in_reply_to":"b0f7745b_4aba5009","updated":"2022-01-17 12:05:36.000000000","message":"Great, thanks!","commit_id":"a626a963acfd6f2d43889a23644d22405f9c791d"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"116b103154ce7b268797f5cee4e28a6b0d1bb010","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     haixin \u003chaix09@chinatelecom.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-14 11:00:50 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove usage of six lib for all drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Python2 is no longer supported, so in this patch"},{"line_number":10,"context_line":"set we remove the usage of the six (py2 and py3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3789befe_62c9f348","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":39},"updated":"2022-01-27 13:25:57.000000000","message":"Not all drivers are covered, examples: \n1. generic.py:import six\n2. lvm.py:import six\n\nI do understand that they are handled on patch [1], here:\n\n\"all third party/vendors drivers\"","commit_id":"589b93b5708172fb68a45c63abcd5ef5d565cf3b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"51b5be4282ce0da3d77abd4043a7c2b449057c61","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     haixin \u003chaix09@chinatelecom.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-14 11:00:50 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove usage of six lib for all drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Python2 is no longer supported, so in this patch"},{"line_number":10,"context_line":"set we remove the usage of the six (py2 and py3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"c8852a1f_d3024c3a","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":39},"in_reply_to":"3789befe_62c9f348","updated":"2022-01-29 03:01:53.000000000","message":"These two drivers are generic drivers, not third-party drivers. so i put the change about this into another patch:\nhttps://review.opendev.org/c/openstack/manila/+/756991","commit_id":"589b93b5708172fb68a45c63abcd5ef5d565cf3b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"0f702949032147716b1661e0632ec6be397aa488","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"de4a5e57_bab2f8fa","updated":"2021-12-09 09:09:49.000000000","message":"patchset 2 -----\u003e patchset 3\nThese four files has been changed in\nhttps://review.opendev.org/c/openstack/manila/+/756991","commit_id":"d54c73cd6fbc2d36afe2295e4239901320b06dcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe18a35d413e7db2da055a80cb13e725eb2bd08b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c7c09787_74b0659e","updated":"2022-01-05 23:23:45.000000000","message":"recheck","commit_id":"599530d603b706664103c1b872cd9a40b0b3ecc6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a052c71eb99170e43f6417b862b25b1c9b3c81cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"567064b6_87ecabf9","updated":"2022-01-13 18:11:50.000000000","message":"It looks good, just a minor comments. Plus, wanted to ask, shall we stick to utf-8 for the encoding instead of latin-1? Thanks Haixin!","commit_id":"a626a963acfd6f2d43889a23644d22405f9c791d"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"1aebd5252e645f28d5b72d4989b9f1213e310a23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9353a2b2_669f35b6","updated":"2022-01-09 20:40:46.000000000","message":"run-NetApp C","commit_id":"a626a963acfd6f2d43889a23644d22405f9c791d"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"bc116ee96b2c5792705b9889d833490d6b49302e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e8c054ca_95b2629e","updated":"2022-01-09 20:40:52.000000000","message":"run-NetApp CI","commit_id":"a626a963acfd6f2d43889a23644d22405f9c791d"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"e2521c1d1f806a0420e1d1a375f2422d4ffb5221","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"98daaa15_840c1731","in_reply_to":"03483882_ba82b8c8","updated":"2022-01-17 12:05:36.000000000","message":"Ok thanks, makes sense. Maybe at some point we can look into updating the encoding","commit_id":"a626a963acfd6f2d43889a23644d22405f9c791d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"797a87772713044f2300738fb00b3dbcc3e4d3fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"03483882_ba82b8c8","in_reply_to":"567064b6_87ecabf9","updated":"2022-01-14 03:03:34.000000000","message":"I did not intentionally change the encoding method used by the original driver manufacturer, However, I prefer to use UTF8 because it represents more characters. For example, support for Chinese.","commit_id":"a626a963acfd6f2d43889a23644d22405f9c791d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6e4ef61e9dfa93b1361924d97ebbaf63816be38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0805ae6e_398a00e8","in_reply_to":"98daaa15_840c1731","updated":"2022-02-04 22:26:13.000000000","message":"+1 Worthwhile improvement","commit_id":"a626a963acfd6f2d43889a23644d22405f9c791d"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"9c0244cd817c0654a5f62691c67dec9f50167f81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ee0dd3f6_356268b2","updated":"2022-01-20 15:08:04.000000000","message":"Great job haixin!\nI\u0027ve searched for six on manila/share/drivers, there are still some references on generic, lvm driver files and other common use files (helpers, service_instance). Is that right?\nThank you for your effort on cleaning the references on all drivers :)","commit_id":"589b93b5708172fb68a45c63abcd5ef5d565cf3b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"116b103154ce7b268797f5cee4e28a6b0d1bb010","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0ed4b61f_7fab70a0","updated":"2022-01-27 13:25:57.000000000","message":"Great work Haixin! Overall looks good. NetApp CI is passing too! Just a point in the commit message that could lead to a misunderstanding of the patch goal.","commit_id":"589b93b5708172fb68a45c63abcd5ef5d565cf3b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3de12b9455f79c486dc4f7a8fec7beb44f950c08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d4f912e0_951f9fb1","updated":"2022-01-20 20:42:35.000000000","message":"Hi, haixin!\nThanks for working on this change. I ran a grep in the drivers module and turns out that it is still being used by some drivers (generic, drivers helper, lvm and service_instance). Please see [1]\nIs there a specific reason why those files are untouched? If not, could you please address those? :)\n\n[1] https://paste.opendev.org/show/812271/","commit_id":"589b93b5708172fb68a45c63abcd5ef5d565cf3b"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"e2521c1d1f806a0420e1d1a375f2422d4ffb5221","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"53a42b0f_44139ba6","updated":"2022-01-17 12:05:36.000000000","message":"Thanks for addressing my comments Haixin, looks good!","commit_id":"589b93b5708172fb68a45c63abcd5ef5d565cf3b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"01c21e5f6d53ded2c62c6a9719581b938d55f92f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e053f7bf_52052645","updated":"2022-01-26 18:43:07.000000000","message":"run-NetApp CI","commit_id":"589b93b5708172fb68a45c63abcd5ef5d565cf3b"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"797a87772713044f2300738fb00b3dbcc3e4d3fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"16a58d31_eb6d1f73","updated":"2022-01-14 03:03:34.000000000","message":"thanks for your review, Victoria Martinez de la Cruz.","commit_id":"589b93b5708172fb68a45c63abcd5ef5d565cf3b"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"945ea2d30ac29ee72b1df0c57e95e59c3dfc612d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6482b869_29399cbd","in_reply_to":"d4f912e0_951f9fb1","updated":"2022-01-24 13:29:17.000000000","message":"I believe is the same was pointed out by me and Goutham answered on Manila meeting [1], maybe the commit title is misguiding us :) \n\n[1] https://review.opendev.org/c/openstack/manila/+/756991","commit_id":"589b93b5708172fb68a45c63abcd5ef5d565cf3b"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"0ec4e0297fc3e7e0b06da17256c9575a38c4d146","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5a5c86c4_c9fd79df","in_reply_to":"ee0dd3f6_356268b2","updated":"2022-01-20 18:46:32.000000000","message":"my concerns were already addressed here https://review.opendev.org/c/openstack/manila/+/756991","commit_id":"589b93b5708172fb68a45c63abcd5ef5d565cf3b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"246114982fdad58f226332d1a65468c350db94f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"706f972f_ce982e33","updated":"2022-02-03 13:16:24.000000000","message":"Good work, Haixin. LGTM!","commit_id":"a73b29937420598a741dcc56bfc48a436ec83a3f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6e4ef61e9dfa93b1361924d97ebbaf63816be38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d6a0e36e_aebd2f8d","updated":"2022-02-04 22:26:13.000000000","message":"Thank you for your work on this haixin. It\u0027d\u0027ve been nice to have the third party CIs passing on this - however, they\u0027re each failing at different places, and have nothing to do with this change by my understanding. \n\nPure Storage CI has a failure writing into a shrunk share (), rest of the tests pass: http://openstack-logs.purestorage.com/62/821162/7/thirdparty-check/pure-devstack-manila-tempest-aio/6114968/testr_results.html.gz\n\nDell/EMC PowerMax CI seems to be having a problem communicating with storage:\nhttps://elab-os-logsrv.delllabs.net/62/821162/7/check/DellEMC_PowerMAX_Manila/1050a6e/DellEMC_PowerMAX_Manila/97/logs/screen-m-shr.txt.gz\n\nDell/EMC Unity DHSS\u003dFalse CI is hitting https://bugs.launchpad.net/manila/+bug/1958193 and isn\u0027t installing the latest available python-manilaclient (or pulling it from source): https://elab-os-logsrv.delllabs.net/62/821162/5/check/DellEMC_Unity_Manila_dhss_false/b471dd1/DellEMC_Unity_Manila_dhss_false/183/logs/devstacklog.txt.gz\nDell/EMC Unity DHSS\u003dTrue CI error\u0027ed out at devstack much earlier:  https://elab-os-logsrv.delllabs.net/62/821162/5/check/DellEMC_Unity_Manila_dhss_true/3a307cf/DellEMC_Unity_Manila_dhss_true/192/logs/devstacklog.txt.gz\n\nNetApp DHSS\u003dTrue CI errored out at devstack much earlier too: https://netappopenstacklogserver.s3-us-west-1.amazonaws.com/logs/62/821162/7/upstream-check/manila-cDOT-ss/0e2d97c/0e2d97c/logs/devstacklog.txt\nNetApp DHSS\u003dFalse CI ran a bunch of tests but timed out: https://netappopenstacklogserver.s3-us-west-1.amazonaws.com/logs/62/821162/7/upstream-check/manila-cDOT-no-ss/73a9f8e/73a9f8e/console.html.txt\n\nLets get this in, and if we run into bugs, lets address them; ","commit_id":"a73b29937420598a741dcc56bfc48a436ec83a3f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2c24b40715eccc6d2f546c9994f265cbfdc8549f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"19325e69_f764331f","updated":"2022-02-04 17:35:15.000000000","message":"Thanks for working on this, haixin!","commit_id":"a73b29937420598a741dcc56bfc48a436ec83a3f"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"337590762ca603801d15080d13a7269cf16b6824","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"42d2323e_b7a6f5fc","updated":"2022-02-03 13:16:36.000000000","message":"run-NetApp CI","commit_id":"a73b29937420598a741dcc56bfc48a436ec83a3f"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"89aac2f4afb83d74bfcf7ee149d67b46234ccc4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e54000f6_e2edce06","updated":"2022-02-04 16:20:09.000000000","message":"run-NetApp CI","commit_id":"a73b29937420598a741dcc56bfc48a436ec83a3f"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"51b5be4282ce0da3d77abd4043a7c2b449057c61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"99550caa_bb27d6d5","updated":"2022-01-29 03:01:53.000000000","message":"thanks for your review, carlos and felipe.\n","commit_id":"a73b29937420598a741dcc56bfc48a436ec83a3f"}],"manila/share/drivers/dell_emc/plugins/base.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3de12b9455f79c486dc4f7a8fec7beb44f950c08","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":23,"context_line":"class StorageConnection(object):"},{"line_number":24,"context_line":"    \"\"\"Subclasses should implement storage backend specific functionality.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"d8cc59b1_70fc297b","side":"PARENT","line":23,"range":{"start_line":23,"start_character":24,"end_line":23,"end_character":30},"updated":"2022-01-20 20:42:35.000000000","message":"why is this removal necessary?","commit_id":"5b6197821bee76d8971b441979a4073193541693"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2c24b40715eccc6d2f546c9994f265cbfdc8549f","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":23,"context_line":"class StorageConnection(object):"},{"line_number":24,"context_line":"    \"\"\"Subclasses should implement storage backend specific functionality.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"32eeeb59_7bea9a45","side":"PARENT","line":23,"range":{"start_line":23,"start_character":24,"end_line":23,"end_character":30},"in_reply_to":"4340752b_7353a744","updated":"2022-02-04 17:35:15.000000000","message":"Makes sense. Thanks","commit_id":"5b6197821bee76d8971b441979a4073193541693"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"116b103154ce7b268797f5cee4e28a6b0d1bb010","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":23,"context_line":"class StorageConnection(object):"},{"line_number":24,"context_line":"    \"\"\"Subclasses should implement storage backend specific functionality.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa582582_c7391b84","side":"PARENT","line":23,"range":{"start_line":23,"start_character":24,"end_line":23,"end_character":30},"in_reply_to":"d8cc59b1_70fc297b","updated":"2022-01-27 13:25:57.000000000","message":"Hi carlos, I think the idea is removing all six reference, not only the strings one. Since six is used for supporting py2 and py3 and manila won\u0027t support py2, the six module is no more required.","commit_id":"5b6197821bee76d8971b441979a4073193541693"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"51b5be4282ce0da3d77abd4043a7c2b449057c61","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":23,"context_line":"class StorageConnection(object):"},{"line_number":24,"context_line":"    \"\"\"Subclasses should implement storage backend specific functionality.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ff80e99_120796d9","side":"PARENT","line":23,"range":{"start_line":23,"start_character":24,"end_line":23,"end_character":30},"in_reply_to":"fa582582_c7391b84","updated":"2022-01-29 03:01:53.000000000","message":"Done","commit_id":"5b6197821bee76d8971b441979a4073193541693"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"51b5be4282ce0da3d77abd4043a7c2b449057c61","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":23,"context_line":"class StorageConnection(object):"},{"line_number":24,"context_line":"    \"\"\"Subclasses should implement storage backend specific functionality.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"4340752b_7353a744","side":"PARENT","line":23,"range":{"start_line":23,"start_character":24,"end_line":23,"end_character":30},"in_reply_to":"fa582582_c7391b84","updated":"2022-01-29 03:01:53.000000000","message":"yes, now manila only support py3, so i put six.add_metaclass(aabc.ABCMeta) into class as parent class.","commit_id":"5b6197821bee76d8971b441979a4073193541693"}],"manila/share/drivers/ganesha/__init__.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a052c71eb99170e43f6417b862b25b1c9b3c81cd","unresolved":true,"context_lines":[{"line_number":31,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class NASHelperBase(metaclass\u003dabc.ABCMeta):"},{"line_number":35,"context_line":"    \"\"\"Interface to work with share.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # drivers that use a helper derived from this class"}],"source_content_type":"text/x-python","patch_set":5,"id":"fd7538b7_219ca8b2","line":34,"updated":"2022-01-13 18:11:50.000000000","message":"This seems like an unintented change, although this shouldn\u0027t affect the behavior","commit_id":"a626a963acfd6f2d43889a23644d22405f9c791d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"797a87772713044f2300738fb00b3dbcc3e4d3fd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class NASHelperBase(metaclass\u003dabc.ABCMeta):"},{"line_number":35,"context_line":"    \"\"\"Interface to work with share.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # drivers that use a helper derived from this class"}],"source_content_type":"text/x-python","patch_set":5,"id":"33c8817c_f871e373","line":34,"in_reply_to":"fd7538b7_219ca8b2","updated":"2022-01-14 03:03:34.000000000","message":"I\u0027ve seen other projects do the same, and maybe the format looks better","commit_id":"a626a963acfd6f2d43889a23644d22405f9c791d"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"0ec4e0297fc3e7e0b06da17256c9575a38c4d146","unresolved":true,"context_lines":[{"line_number":31,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class NASHelperBase(metaclass\u003dabc.ABCMeta):"},{"line_number":35,"context_line":"    \"\"\"Interface to work with share.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # drivers that use a helper derived from this class"}],"source_content_type":"text/x-python","patch_set":6,"id":"c0345ba0_983e43bb","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":43},"updated":"2022-01-20 18:46:32.000000000","message":"why the object param is being removed?","commit_id":"589b93b5708172fb68a45c63abcd5ef5d565cf3b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6e4ef61e9dfa93b1361924d97ebbaf63816be38","unresolved":true,"context_lines":[{"line_number":31,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class NASHelperBase(metaclass\u003dabc.ABCMeta):"},{"line_number":35,"context_line":"    \"\"\"Interface to work with share.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    # drivers that use a helper derived from this class"}],"source_content_type":"text/x-python","patch_set":6,"id":"cb6148ea_8e4612ae","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":43},"in_reply_to":"c0345ba0_983e43bb","updated":"2022-02-04 22:26:13.000000000","message":"inheriting \"object\" is implicitly done in python3..","commit_id":"589b93b5708172fb68a45c63abcd5ef5d565cf3b"}],"manila/share/drivers/glusterfs/layout.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3de12b9455f79c486dc4f7a8fec7beb44f950c08","unresolved":true,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":206,"context_line":"class GlusterfsShareLayoutBase(object):"},{"line_number":207,"context_line":"    \"\"\"Base class for share layouts.\"\"\""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def __init__(self, driver, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"81d8f3c6_613cbb7b","side":"PARENT","line":206,"range":{"start_line":206,"start_character":31,"end_line":206,"end_character":37},"updated":"2022-01-20 20:42:35.000000000","message":"same","commit_id":"5b6197821bee76d8971b441979a4073193541693"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"51b5be4282ce0da3d77abd4043a7c2b449057c61","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":206,"context_line":"class GlusterfsShareLayoutBase(object):"},{"line_number":207,"context_line":"    \"\"\"Base class for share layouts.\"\"\""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def __init__(self, driver, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ef899ed2_1a4ff763","side":"PARENT","line":206,"range":{"start_line":206,"start_character":31,"end_line":206,"end_character":37},"in_reply_to":"81d8f3c6_613cbb7b","updated":"2022-01-29 03:01:53.000000000","message":"Done","commit_id":"5b6197821bee76d8971b441979a4073193541693"}],"manila/share/drivers/netapp/dataontap/client/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6e4ef61e9dfa93b1361924d97ebbaf63816be38","unresolved":true,"context_lines":[{"line_number":850,"context_line":"                    self.add_child_elem(child)"},{"line_number":851,"context_line":"                elif isinstance("},{"line_number":852,"context_line":"                        value,"},{"line_number":853,"context_line":"                        (str, ) + (int, ) + (float, )):"},{"line_number":854,"context_line":"                    self.add_new_child(key, str(value))"},{"line_number":855,"context_line":"                elif isinstance(value, (list, tuple, dict)):"},{"line_number":856,"context_line":"                    child \u003d NaElement(key)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9e21e8d8_85a0fc85","line":853,"range":{"start_line":853,"start_character":24,"end_line":853,"end_character":53},"updated":"2022-02-04 22:26:13.000000000","message":"(str, int, float)","commit_id":"a73b29937420598a741dcc56bfc48a436ec83a3f"}],"manila/tests/share/drivers/hpe/test_hpe_3par_mediator.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a052c71eb99170e43f6417b862b25b1c9b3c81cd","unresolved":true,"context_lines":[{"line_number":1508,"context_line":"        self.assertTrue(mock_log.debug.called)"},{"line_number":1509,"context_line":"        self.assertTrue(mock_log.exception.called)"},{"line_number":1510,"context_line":""},{"line_number":1511,"context_line":"    @ddt.data(str(\u0027volname.1\u0027), [\u0027volname.2\u0027, \u0027volname.3\u0027])"},{"line_number":1512,"context_line":"    def test_mediator_get_fpg_status(self, volume_name_or_list):"},{"line_number":1513,"context_line":"        \"\"\"Mediator converts client stats to capacity result.\"\"\""},{"line_number":1514,"context_line":"        expected_capacity \u003d constants.EXPECTED_SIZE_2"}],"source_content_type":"text/x-python","patch_set":5,"id":"f2c78030_00de2e6d","line":1511,"updated":"2022-01-13 18:11:50.000000000","message":"Not needed, we are passing a str already","commit_id":"a626a963acfd6f2d43889a23644d22405f9c791d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"797a87772713044f2300738fb00b3dbcc3e4d3fd","unresolved":false,"context_lines":[{"line_number":1508,"context_line":"        self.assertTrue(mock_log.debug.called)"},{"line_number":1509,"context_line":"        self.assertTrue(mock_log.exception.called)"},{"line_number":1510,"context_line":""},{"line_number":1511,"context_line":"    @ddt.data(str(\u0027volname.1\u0027), [\u0027volname.2\u0027, \u0027volname.3\u0027])"},{"line_number":1512,"context_line":"    def test_mediator_get_fpg_status(self, volume_name_or_list):"},{"line_number":1513,"context_line":"        \"\"\"Mediator converts client stats to capacity result.\"\"\""},{"line_number":1514,"context_line":"        expected_capacity \u003d constants.EXPECTED_SIZE_2"}],"source_content_type":"text/x-python","patch_set":5,"id":"cb92907c_66d3631f","line":1511,"in_reply_to":"f2c78030_00de2e6d","updated":"2022-01-14 03:03:34.000000000","message":"Done","commit_id":"a626a963acfd6f2d43889a23644d22405f9c791d"}],"manila/tests/share/drivers/test_generic.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe18a35d413e7db2da055a80cb13e725eb2bd08b","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Unit tests for the Generic driver module.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from builtins import range"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import time"},{"line_number":22,"context_line":"from unittest import mock"}],"source_content_type":"text/x-python","patch_set":4,"id":"12b05cbf_d7064e06","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":26},"updated":"2022-01-05 23:23:45.000000000","message":"builtins are loaded automatically, no need to import them","commit_id":"599530d603b706664103c1b872cd9a40b0b3ecc6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"797a87772713044f2300738fb00b3dbcc3e4d3fd","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Unit tests for the Generic driver module.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from builtins import range"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import time"},{"line_number":22,"context_line":"from unittest import mock"}],"source_content_type":"text/x-python","patch_set":4,"id":"64600ba0_988ae398","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":26},"in_reply_to":"12b05cbf_d7064e06","updated":"2022-01-14 03:03:34.000000000","message":"Done","commit_id":"599530d603b706664103c1b872cd9a40b0b3ecc6"}]}