)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"477cd4b186d09d485b7e151d43ab2a00358a125e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9349f58f_f925dc80","updated":"2024-04-26 14:40:31.000000000","message":"recheck\nLogs are gone, resuming the work","commit_id":"1a429fbb6c0fdda0fa365bc5404ee984357cec4b"}],"manila/privsep/docker.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d063dfb0969fc88a7d56378c54d3d3ed25b686fd","unresolved":true,"context_lines":[{"line_number":35,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":36,"context_line":"def run_container(volume_mapping, container_name, path, image_name):"},{"line_number":37,"context_line":"    return processutils.execute("},{"line_number":38,"context_line":"        \"docker\", \"run\", \"-d\", \"-i\", \"-t\", \"--privileged\", \"-v\","},{"line_number":39,"context_line":"        volume_mapping, \"--name\u003d%s\" % container_name, \"-v\", path, image_name)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3db290da_b4193e4f","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":56},"updated":"2026-05-05 13:41:40.000000000","message":"previously, the docker container was created, and then run.. this transition makes the container create/run in the same go.","commit_id":"cd38d39b702be0fdafaff90ae4e99d64c58ba9a3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"835d989380f96b0feb758fcb19222341fd49d5e0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":36,"context_line":"def run_container(volume_mapping, container_name, path, image_name):"},{"line_number":37,"context_line":"    return processutils.execute("},{"line_number":38,"context_line":"        \"docker\", \"run\", \"-d\", \"-i\", \"-t\", \"--privileged\", \"-v\","},{"line_number":39,"context_line":"        volume_mapping, \"--name\u003d%s\" % container_name, \"-v\", path, image_name)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"f40f79b8_92e8f2c7","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":56},"in_reply_to":"3db290da_b4193e4f","updated":"2026-05-08 09:05:02.000000000","message":"Done","commit_id":"cd38d39b702be0fdafaff90ae4e99d64c58ba9a3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d063dfb0969fc88a7d56378c54d3d3ed25b686fd","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":48,"context_line":"def exec(container_name, cmd, keep_attached\u003dFalse):"},{"line_number":49,"context_line":"    extra_params \u003d []"},{"line_number":50,"context_line":"    if keep_attached:"},{"line_number":51,"context_line":"        extra_params +\u003d [\"-i\"]"}],"source_content_type":"text/x-python","patch_set":10,"id":"008d5059_01251543","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":8},"updated":"2026-05-05 13:41:40.000000000","message":"exec is a reserved python keyword: https://docs.python.org/3/library/functions.html#exec","commit_id":"cd38d39b702be0fdafaff90ae4e99d64c58ba9a3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"835d989380f96b0feb758fcb19222341fd49d5e0","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"@manila.privsep.sys_admin_pctxt.entrypoint"},{"line_number":48,"context_line":"def exec(container_name, cmd, keep_attached\u003dFalse):"},{"line_number":49,"context_line":"    extra_params \u003d []"},{"line_number":50,"context_line":"    if keep_attached:"},{"line_number":51,"context_line":"        extra_params +\u003d [\"-i\"]"}],"source_content_type":"text/x-python","patch_set":10,"id":"d099ae6b_192ebc92","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":8},"in_reply_to":"008d5059_01251543","updated":"2026-05-08 09:05:02.000000000","message":"good catch, missed it","commit_id":"cd38d39b702be0fdafaff90ae4e99d64c58ba9a3"}],"manila/share/drivers/container/driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d063dfb0969fc88a7d56378c54d3d3ed25b686fd","unresolved":true,"context_lines":[{"line_number":328,"context_line":"        LOG.debug(msg, server_id)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        try:"},{"line_number":331,"context_line":"            self.container.create_container(server_id)"},{"line_number":332,"context_line":"            self.container.start_container(server_id)"},{"line_number":333,"context_line":"        except Exception as e:"},{"line_number":334,"context_line":"            raise exception.ManilaException(_(\"Cannot create container: %s\") %"},{"line_number":335,"context_line":"                                            e)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fde40be6_d174daa5","line":332,"range":{"start_line":331,"start_character":12,"end_line":332,"end_character":53},"updated":"2026-05-05 13:41:40.000000000","message":"This invocation; it looks like you\u0027re combining the calls into \"run_container\"","commit_id":"cd38d39b702be0fdafaff90ae4e99d64c58ba9a3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"835d989380f96b0feb758fcb19222341fd49d5e0","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        LOG.debug(msg, server_id)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        try:"},{"line_number":331,"context_line":"            self.container.create_container(server_id)"},{"line_number":332,"context_line":"            self.container.start_container(server_id)"},{"line_number":333,"context_line":"        except Exception as e:"},{"line_number":334,"context_line":"            raise exception.ManilaException(_(\"Cannot create container: %s\") %"},{"line_number":335,"context_line":"                                            e)"}],"source_content_type":"text/x-python","patch_set":10,"id":"434daf01_23344b79","line":332,"range":{"start_line":331,"start_character":12,"end_line":332,"end_character":53},"in_reply_to":"fde40be6_d174daa5","updated":"2026-05-08 09:05:02.000000000","message":"maintained this behavior for a smooth migration.","commit_id":"cd38d39b702be0fdafaff90ae4e99d64c58ba9a3"}]}