)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5a867db9974804d9bec17bb880d7ca7baaccc0f1","unresolved":true,"context_lines":[{"line_number":9,"context_line":"1. Change context as first argument to function."},{"line_number":10,"context_line":"2. Fix spelling mistake in version history"},{"line_number":11,"context_line":"3. Add new hostAdmin RBAC policy which is applied in onlyHostFilter"},{"line_number":12,"context_line":"since non-admin user as well needs to create share on specific host."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id2c09ebab874ec983da7f26370932d46a0447801"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"f85e13fc_a0912a97","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":68},"updated":"2022-05-09 11:26:41.000000000","message":"if only keep admin can use onlyHostFilter, we should remove this line.","commit_id":"a0147ded9b8ff5a3dc1b25f6d7247c98f6a2a3c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9b024aaf4924dcfa2078f67d571548af8b96a102","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1. Change context as first argument to function."},{"line_number":10,"context_line":"2. Fix spelling mistake in version history"},{"line_number":11,"context_line":"3. Add new hostAdmin RBAC policy which is applied in onlyHostFilter"},{"line_number":12,"context_line":"since non-admin user as well needs to create share on specific host."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id2c09ebab874ec983da7f26370932d46a0447801"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"21210c06_bc34f4d2","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":68},"in_reply_to":"af54357e_6cd1c4c2","updated":"2022-07-12 15:14:10.000000000","message":"Done","commit_id":"a0147ded9b8ff5a3dc1b25f6d7247c98f6a2a3c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"34ba7a6bde5e57809af5891de37aaae035e8047c","unresolved":true,"context_lines":[{"line_number":9,"context_line":"1. Change context as first argument to function."},{"line_number":10,"context_line":"2. Fix spelling mistake in version history"},{"line_number":11,"context_line":"3. Add new hostAdmin RBAC policy which is applied in onlyHostFilter"},{"line_number":12,"context_line":"since non-admin user as well needs to create share on specific host."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id2c09ebab874ec983da7f26370932d46a0447801"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"af54357e_6cd1c4c2","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":68},"in_reply_to":"f85e13fc_a0912a97","updated":"2022-05-09 12:15:40.000000000","message":"I think we should enable for both system admin and project admin","commit_id":"a0147ded9b8ff5a3dc1b25f6d7247c98f6a2a3c7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"54142fa721507e7795fb2dac888add8b861e52ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0b404adc_604cec22","updated":"2022-02-07 07:20:23.000000000","message":"LGTM","commit_id":"6d7c37f118f7251c64d40cdd301735b67999eed2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2fce517cc2a9a07d287700e45cd53757197cc5c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"83358587_cf17fb00","updated":"2022-02-24 12:15:02.000000000","message":"Goutham,\ncan you please check this follow-up suggestions PR ?","commit_id":"53a93a8237323eeeb83d2b68ea370e1124aed5b1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"539a8c7b50d7b73d63fede6b2c2392f4c15e3b70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e5996af2_fcaeba07","in_reply_to":"83358587_cf17fb00","updated":"2022-02-24 17:55:58.000000000","message":"Sorry, this fell off my radar - will take a deeper look post feature freeze (Feb 25th).","commit_id":"53a93a8237323eeeb83d2b68ea370e1124aed5b1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b9d853ae970f7abc2fb2b22cc186aa9328703690","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"813ed61d_48f3d1e6","updated":"2022-05-06 03:55:50.000000000","message":"hi, here are some question about this.","commit_id":"3d5100e1ce62e78afc9c4a1a42074c9f279f27a5"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a777eb3c6f38778e1c0ceac2f9e88f332f787d99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"09e2ba44_6aa50c33","updated":"2022-07-07 13:11:25.000000000","message":"Fix Conflicts, please.","commit_id":"b0c53367e26f2a5fa7c20dd310fc5385731ffabe"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"6d079dda064616f6589476fb2c09b63042b4d699","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7043ffd8_a94adb9c","updated":"2022-05-09 13:07:41.000000000","message":"looks good.","commit_id":"b0c53367e26f2a5fa7c20dd310fc5385731ffabe"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"02bc9e28d7b65054101e27cc4940a9d82c008c58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"262dcda1_eed5ccf8","updated":"2022-07-15 02:34:10.000000000","message":"hi, Kiran Pawar, the code almost looks good, but here is an qeustion. please see comment.","commit_id":"7ea6907f6f9f16a68ef85c620e7c6cc329ba0b47"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8cd2e79df2033e5ed239a43606e612a448fee0c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"07f65f79_2e4384c5","updated":"2022-07-19 08:12:56.000000000","message":"thanks, Kiran Pawar.","commit_id":"7ea6907f6f9f16a68ef85c620e7c6cc329ba0b47"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1bd5abf793ec239ec5fe54653b821eb40b3fec3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ebb14519_f412c542","updated":"2022-08-30 19:29:44.000000000","message":"Kiran, thanks for working on this change. Added one comment inline, please take a look at it. Other than that, it looks good :)","commit_id":"adccbc8b9f449dd9514c0c8502f8e477d22a6a00"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"192954e12cfb6f146c370eda171dc0a0f86089d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9cc7fb6c_473a7840","updated":"2022-08-31 09:01:40.000000000","message":"Hi, \n\nThanks for wrking through this; i want to discuss this change a bit more; i expected to cover all API interactions with the \"host\" attribute via the new policy that you\u0027re introducing. This will allow us to split the granularity of seeing the host attribute and requesting it for various workflows: creating share types, hints, migrating shares, servers, etc. \n\nPerhaps we can discuss this at the upcoming PTG?","commit_id":"980fc67fdc1e584b097730b0cf21bed594e50a37"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"38a15bfa0273840fbaa879372d18db876816df06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d70b113e_129207e2","updated":"2022-08-31 14:17:46.000000000","message":"LGTM, thank you!","commit_id":"980fc67fdc1e584b097730b0cf21bed594e50a37"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"bef97af458f85f0d0aea001cf0c537cd7778dc51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"56d6d2f5_07e63b79","updated":"2022-11-04 08:56:17.000000000","message":"I think the idea was also to change https://opendev.org/openstack/manila/src/commit/031fab2c8fab31c56462390706557d2c37ba0b89/manila/api/views/shares.py#L104 to use policy.check_is_host_admin","commit_id":"84ea60afdc350b8d3d669bbd790a8ab07968bc02"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"933a1000dc9e1dad80ea4be654a6e4750f2a8a68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"4af5c151_be8e940e","updated":"2023-02-20 20:59:24.000000000","message":"Hi, Kiran! Trying to bubble this change up again. Could you please take a look at Maurice\u0027s comments?","commit_id":"994976c74a38627fc2620c9c5fc3ec9e228f51de"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"6e8092f56b73022b7edcb19046ea1d6e2c91cb91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"9036bdc3_ad7bf4cd","updated":"2023-02-28 08:59:43.000000000","message":"lgtm","commit_id":"360adf6b6960e7fa073b856fda82f3eb024b934e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"1bfc2c5613af6eecc1def741d7d789bd0bf21f1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"603bb6d1_8709ca76","updated":"2023-02-27 11:41:34.000000000","message":"recheck","commit_id":"360adf6b6960e7fa073b856fda82f3eb024b934e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c7167218b0a3a5302fc7bb1fce758be679e218a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"72846f41_118b4a6c","updated":"2023-02-27 18:00:25.000000000","message":"recheck","commit_id":"360adf6b6960e7fa073b856fda82f3eb024b934e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"39c304399caa7c4d048497211bc14bd72f74e1cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d0838cbf_f3ec224b","updated":"2023-02-27 20:18:21.000000000","message":"recheck","commit_id":"360adf6b6960e7fa073b856fda82f3eb024b934e"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"be9240ac82211916b07f3aefc0438afdb1a181e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ef303641_769c4670","updated":"2023-05-30 08:29:51.000000000","message":"LGTM","commit_id":"8eb38ac41a776f0878368efa2a083830eded9589"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"180d866acc802c7c33a1ee97942ad0e16edcd452","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"a662743b_2abe39fc","updated":"2023-05-25 14:49:48.000000000","message":"LGTM, thanks Kiran!","commit_id":"8eb38ac41a776f0878368efa2a083830eded9589"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b9d853ae970f7abc2fb2b22cc186aa9328703690","unresolved":true,"context_lines":[{"line_number":2350,"context_line":"    One or more scheduler_hints key and value pairs as a dictionary of"},{"line_number":2351,"context_line":"    strings. Accepted hints are:"},{"line_number":2352,"context_line":"    - ``same_host`` or ``different_host``: values must be a comma separated list of Share IDs"},{"line_number":2353,"context_line":"    - ``only_host``: value must be a manage-share service host in ``host@backend#POOL`` format (admin only). Only available in and beyond API version 2.67"},{"line_number":2354,"context_line":"  in: body"},{"line_number":2355,"context_line":"  required: false"},{"line_number":2356,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c4f0df1e_023e9afd","line":2353,"range":{"start_line":2353,"start_character":68,"end_line":2353,"end_character":85},"updated":"2022-05-06 03:55:50.000000000","message":"for end user, they can not get host information of share.  so ,, how they use this value?\nfor example, manila list commands, only admin user can get host, non-admin user get None.","commit_id":"3d5100e1ce62e78afc9c4a1a42074c9f279f27a5"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b9d853ae970f7abc2fb2b22cc186aa9328703690","unresolved":true,"context_lines":[{"line_number":2350,"context_line":"    One or more scheduler_hints key and value pairs as a dictionary of"},{"line_number":2351,"context_line":"    strings. Accepted hints are:"},{"line_number":2352,"context_line":"    - ``same_host`` or ``different_host``: values must be a comma separated list of Share IDs"},{"line_number":2353,"context_line":"    - ``only_host``: value must be a manage-share service host in ``host@backend#POOL`` format (admin only). Only available in and beyond API version 2.67"},{"line_number":2354,"context_line":"  in: body"},{"line_number":2355,"context_line":"  required: false"},{"line_number":2356,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"160f4f93_cf9077da","line":2353,"range":{"start_line":2353,"start_character":96,"end_line":2353,"end_character":106},"updated":"2022-05-06 03:55:50.000000000","message":"if non-admin user can use onlyHostFilter, we should remove this.","commit_id":"3d5100e1ce62e78afc9c4a1a42074c9f279f27a5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d34f72104dd65883582b9c83a4de04fa9655a446","unresolved":true,"context_lines":[{"line_number":2350,"context_line":"    One or more scheduler_hints key and value pairs as a dictionary of"},{"line_number":2351,"context_line":"    strings. Accepted hints are:"},{"line_number":2352,"context_line":"    - ``same_host`` or ``different_host``: values must be a comma separated list of Share IDs"},{"line_number":2353,"context_line":"    - ``only_host``: value must be a manage-share service host in ``host@backend#POOL`` format (admin only). Only available in and beyond API version 2.67"},{"line_number":2354,"context_line":"  in: body"},{"line_number":2355,"context_line":"  required: false"},{"line_number":2356,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d1f42216_aa0e0b71","line":2353,"range":{"start_line":2353,"start_character":96,"end_line":2353,"end_character":106},"in_reply_to":"160f4f93_cf9077da","updated":"2022-05-07 10:50:46.000000000","message":"kept admin only","commit_id":"3d5100e1ce62e78afc9c4a1a42074c9f279f27a5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9b024aaf4924dcfa2078f67d571548af8b96a102","unresolved":false,"context_lines":[{"line_number":2350,"context_line":"    One or more scheduler_hints key and value pairs as a dictionary of"},{"line_number":2351,"context_line":"    strings. Accepted hints are:"},{"line_number":2352,"context_line":"    - ``same_host`` or ``different_host``: values must be a comma separated list of Share IDs"},{"line_number":2353,"context_line":"    - ``only_host``: value must be a manage-share service host in ``host@backend#POOL`` format (admin only). Only available in and beyond API version 2.67"},{"line_number":2354,"context_line":"  in: body"},{"line_number":2355,"context_line":"  required: false"},{"line_number":2356,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a59d0cd4_b3e5c7a7","line":2353,"range":{"start_line":2353,"start_character":68,"end_line":2353,"end_character":85},"in_reply_to":"3b160b1c_2a76b63d","updated":"2022-07-12 15:14:10.000000000","message":"Done","commit_id":"3d5100e1ce62e78afc9c4a1a42074c9f279f27a5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d34f72104dd65883582b9c83a4de04fa9655a446","unresolved":true,"context_lines":[{"line_number":2350,"context_line":"    One or more scheduler_hints key and value pairs as a dictionary of"},{"line_number":2351,"context_line":"    strings. Accepted hints are:"},{"line_number":2352,"context_line":"    - ``same_host`` or ``different_host``: values must be a comma separated list of Share IDs"},{"line_number":2353,"context_line":"    - ``only_host``: value must be a manage-share service host in ``host@backend#POOL`` format (admin only). Only available in and beyond API version 2.67"},{"line_number":2354,"context_line":"  in: body"},{"line_number":2355,"context_line":"  required: false"},{"line_number":2356,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3b160b1c_2a76b63d","line":2353,"range":{"start_line":2353,"start_character":68,"end_line":2353,"end_character":85},"in_reply_to":"c4f0df1e_023e9afd","updated":"2022-05-07 10:50:46.000000000","message":"removed non-admin user.","commit_id":"3d5100e1ce62e78afc9c4a1a42074c9f279f27a5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9b024aaf4924dcfa2078f67d571548af8b96a102","unresolved":false,"context_lines":[{"line_number":2350,"context_line":"    One or more scheduler_hints key and value pairs as a dictionary of"},{"line_number":2351,"context_line":"    strings. Accepted hints are:"},{"line_number":2352,"context_line":"    - ``same_host`` or ``different_host``: values must be a comma separated list of Share IDs"},{"line_number":2353,"context_line":"    - ``only_host``: value must be a manage-share service host in ``host@backend#POOL`` format (admin only). Only available in and beyond API version 2.67"},{"line_number":2354,"context_line":"  in: body"},{"line_number":2355,"context_line":"  required: false"},{"line_number":2356,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"01393def_fd688159","line":2353,"range":{"start_line":2353,"start_character":96,"end_line":2353,"end_character":106},"in_reply_to":"d1f42216_aa0e0b71","updated":"2022-07-12 15:14:10.000000000","message":"Done","commit_id":"3d5100e1ce62e78afc9c4a1a42074c9f279f27a5"}],"manila/api/views/shares.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5a867db9974804d9bec17bb880d7ca7baaccc0f1","unresolved":true,"context_lines":[{"line_number":103,"context_line":"            share_dict[\u0027share_server_id\u0027] \u003d share_instance.get("},{"line_number":104,"context_line":"                \u0027share_server_id\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        if context.is_admin or policy.check_is_hostAdmin(context):"},{"line_number":107,"context_line":"            share_dict[\u0027host\u0027] \u003d share_instance.get(\u0027host\u0027)"},{"line_number":108,"context_line":"        return {\u0027share\u0027: share_dict}"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dd0699dd_f8e30f36","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":66},"updated":"2022-05-09 11:26:41.000000000","message":"if context.is_admin is True, then policy.check_is_hostAdmin(context) must also be True.\nscope_types of context_is_admin is [\u0027system\u0027].\nscope_types of context_is_hostAdmin is [\u0027system\u0027, \u0027project\u0027]\n\nso i think \nif context.is_admin or policy.check_is_hostAdmin(context):\nis equal to \nif policy.check_is_hostAdmin(context):","commit_id":"a0147ded9b8ff5a3dc1b25f6d7247c98f6a2a3c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9b024aaf4924dcfa2078f67d571548af8b96a102","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            share_dict[\u0027share_server_id\u0027] \u003d share_instance.get("},{"line_number":104,"context_line":"                \u0027share_server_id\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        if context.is_admin or policy.check_is_hostAdmin(context):"},{"line_number":107,"context_line":"            share_dict[\u0027host\u0027] \u003d share_instance.get(\u0027host\u0027)"},{"line_number":108,"context_line":"        return {\u0027share\u0027: share_dict}"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7df03403_8a286993","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":66},"in_reply_to":"bed133db_b9f53036","updated":"2022-07-12 15:14:10.000000000","message":"Done","commit_id":"a0147ded9b8ff5a3dc1b25f6d7247c98f6a2a3c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"34ba7a6bde5e57809af5891de37aaae035e8047c","unresolved":true,"context_lines":[{"line_number":103,"context_line":"            share_dict[\u0027share_server_id\u0027] \u003d share_instance.get("},{"line_number":104,"context_line":"                \u0027share_server_id\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        if context.is_admin or policy.check_is_hostAdmin(context):"},{"line_number":107,"context_line":"            share_dict[\u0027host\u0027] \u003d share_instance.get(\u0027host\u0027)"},{"line_number":108,"context_line":"        return {\u0027share\u0027: share_dict}"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bed133db_b9f53036","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":66},"in_reply_to":"dd0699dd_f8e30f36","updated":"2022-05-09 12:15:40.000000000","message":"right, i did add it back since tempest tests were failing.","commit_id":"a0147ded9b8ff5a3dc1b25f6d7247c98f6a2a3c7"}],"manila/policies/base.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5a867db9974804d9bec17bb880d7ca7baaccc0f1","unresolved":true,"context_lines":[{"line_number":131,"context_line":"        name\u003d\u0027context_is_hostAdmin\u0027,"},{"line_number":132,"context_line":"        check_str\u003dSYSTEM_ADMIN,"},{"line_number":133,"context_line":"        description\u003d\u0027Privileged user who can select host during scheduling\u0027,"},{"line_number":134,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027]),"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    # ***Legacy/deprecated unscoped rules*** #"},{"line_number":137,"context_line":"    # can be removed after \"enforce_scope\" defaults to True in oslo.policy"}],"source_content_type":"text/x-python","patch_set":8,"id":"1666c544_e9d80195","line":134,"range":{"start_line":134,"start_character":22,"end_line":134,"end_character":39},"updated":"2022-05-09 11:26:41.000000000","message":"I don\u0027t understand what the difference is between context_is_admin and context_is_hostAdmin.\nCan you tell me? thank you.  here the \u0027project\u0027 means project-admin user?\nwe just want admin user can use onlyHostFilter.","commit_id":"a0147ded9b8ff5a3dc1b25f6d7247c98f6a2a3c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9b024aaf4924dcfa2078f67d571548af8b96a102","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        name\u003d\u0027context_is_hostAdmin\u0027,"},{"line_number":132,"context_line":"        check_str\u003dSYSTEM_ADMIN,"},{"line_number":133,"context_line":"        description\u003d\u0027Privileged user who can select host during scheduling\u0027,"},{"line_number":134,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027]),"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    # ***Legacy/deprecated unscoped rules*** #"},{"line_number":137,"context_line":"    # can be removed after \"enforce_scope\" defaults to True in oslo.policy"}],"source_content_type":"text/x-python","patch_set":8,"id":"b32f333b_f6728468","line":134,"range":{"start_line":134,"start_character":22,"end_line":134,"end_character":39},"in_reply_to":"03c88750_cc8584dd","updated":"2022-07-12 15:14:10.000000000","message":"Done","commit_id":"a0147ded9b8ff5a3dc1b25f6d7247c98f6a2a3c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"34ba7a6bde5e57809af5891de37aaae035e8047c","unresolved":true,"context_lines":[{"line_number":131,"context_line":"        name\u003d\u0027context_is_hostAdmin\u0027,"},{"line_number":132,"context_line":"        check_str\u003dSYSTEM_ADMIN,"},{"line_number":133,"context_line":"        description\u003d\u0027Privileged user who can select host during scheduling\u0027,"},{"line_number":134,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027]),"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    # ***Legacy/deprecated unscoped rules*** #"},{"line_number":137,"context_line":"    # can be removed after \"enforce_scope\" defaults to True in oslo.policy"}],"source_content_type":"text/x-python","patch_set":8,"id":"03c88750_cc8584dd","line":134,"range":{"start_line":134,"start_character":22,"end_line":134,"end_character":39},"in_reply_to":"1666c544_e9d80195","updated":"2022-05-09 12:15:40.000000000","message":"yes, project admin. I think, we need to enable for both system admin and project admin to see host field as well as to use this filter","commit_id":"a0147ded9b8ff5a3dc1b25f6d7247c98f6a2a3c7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"02bc9e28d7b65054101e27cc4940a9d82c008c58","unresolved":true,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    policy.RuleDefault("},{"line_number":131,"context_line":"        name\u003d\u0027context_is_hostAdmin\u0027,"},{"line_number":132,"context_line":"        check_str\u003dSYSTEM_ADMIN_OR_PROJECT_MEMBER,"},{"line_number":133,"context_line":"        description\u003d\u0027Privileged user who can select host during scheduling\u0027,"},{"line_number":134,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027]),"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"36ff418a_e53c3957","line":132,"range":{"start_line":132,"start_character":18,"end_line":132,"end_character":48},"updated":"2022-07-15 02:34:10.000000000","message":"if we only enable for both system admin and project admin, then here maybe \nSYSTEM_ADMIN_OR_PROJECT_ADMIN.","commit_id":"7ea6907f6f9f16a68ef85c620e7c6cc329ba0b47"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ba797a529aeace0c4daf0c1b599b4e5fc4d2d11c","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    policy.RuleDefault("},{"line_number":131,"context_line":"        name\u003d\u0027context_is_hostAdmin\u0027,"},{"line_number":132,"context_line":"        check_str\u003dSYSTEM_ADMIN_OR_PROJECT_MEMBER,"},{"line_number":133,"context_line":"        description\u003d\u0027Privileged user who can select host during scheduling\u0027,"},{"line_number":134,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027]),"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"6b17844e_657fe137","line":132,"range":{"start_line":132,"start_character":18,"end_line":132,"end_character":48},"in_reply_to":"1901cfb6_5333a5cb","updated":"2022-08-23 09:17:00.000000000","message":"Done","commit_id":"7ea6907f6f9f16a68ef85c620e7c6cc329ba0b47"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"91d8627a17538d7fbb9a92b814a1b9c1037a3e8d","unresolved":true,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    policy.RuleDefault("},{"line_number":131,"context_line":"        name\u003d\u0027context_is_hostAdmin\u0027,"},{"line_number":132,"context_line":"        check_str\u003dSYSTEM_ADMIN_OR_PROJECT_MEMBER,"},{"line_number":133,"context_line":"        description\u003d\u0027Privileged user who can select host during scheduling\u0027,"},{"line_number":134,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027]),"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1901cfb6_5333a5cb","line":132,"range":{"start_line":132,"start_character":18,"end_line":132,"end_character":48},"in_reply_to":"36ff418a_e53c3957","updated":"2022-07-19 08:05:46.000000000","message":"No, we want system admin but for also for project member. \nAnyways project member is restricted to its own project. \nAlso , there are quite high chances that system admin is also project admin.","commit_id":"7ea6907f6f9f16a68ef85c620e7c6cc329ba0b47"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"bef97af458f85f0d0aea001cf0c537cd7778dc51","unresolved":true,"context_lines":[{"line_number":89,"context_line":"    policy.RuleDefault("},{"line_number":90,"context_line":"        name\u003d\u0027context_is_host_admin\u0027,"},{"line_number":91,"context_line":"        check_str\u003d\u0027role:admin or \u0027"},{"line_number":92,"context_line":"                  \u0027project_id:%(project_id)s\u0027,"},{"line_number":93,"context_line":"        description\u003d\u0027Privileged user who can select host during scheduling\u0027,"},{"line_number":94,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027]),"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"db339524_d28e08c6","line":92,"range":{"start_line":92,"start_character":19,"end_line":92,"end_character":44},"updated":"2022-11-04 08:56:17.000000000","message":"The second part here resolves to owner - which makes it not very privileged.\n\nI\u0027d rather go with: \u0027rule:project-admin\u0027 as default setting.\nBut I\u0027m also okay to keep it like it is, any operator can overwrite based on their needs","commit_id":"84ea60afdc350b8d3d669bbd790a8ab07968bc02"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7d086f70045835f5b8b8bcfd3da64484fe5ff9c6","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    policy.RuleDefault("},{"line_number":90,"context_line":"        name\u003d\u0027context_is_host_admin\u0027,"},{"line_number":91,"context_line":"        check_str\u003d\u0027role:admin or \u0027"},{"line_number":92,"context_line":"                  \u0027project_id:%(project_id)s\u0027,"},{"line_number":93,"context_line":"        description\u003d\u0027Privileged user who can select host during scheduling\u0027,"},{"line_number":94,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027]),"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"c8619e1a_e72aae93","line":92,"range":{"start_line":92,"start_character":19,"end_line":92,"end_character":44},"in_reply_to":"db339524_d28e08c6","updated":"2023-02-27 10:34:52.000000000","message":"Done","commit_id":"84ea60afdc350b8d3d669bbd790a8ab07968bc02"}],"manila/policy.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1bd5abf793ec239ec5fe54653b821eb40b3fec3f","unresolved":true,"context_lines":[{"line_number":223,"context_line":"    return authorize(context, \u0027context_is_admin\u0027, target, do_raise\u003dFalse)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"def check_is_hostAdmin(context):"},{"line_number":227,"context_line":"    \"\"\"Whether or not user is hostAdmin according to policy setting."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"570a99e5_013e0020","line":226,"range":{"start_line":226,"start_character":4,"end_line":226,"end_character":22},"updated":"2022-08-30 19:29:44.000000000","message":"check_is_host_admin - methods should be named with _ while separating the words. Classes should use a \"camel case\" pattern.","commit_id":"adccbc8b9f449dd9514c0c8502f8e477d22a6a00"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9a1deed4469503befe51f79de4250070aa1f03be","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    return authorize(context, \u0027context_is_admin\u0027, target, do_raise\u003dFalse)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"def check_is_hostAdmin(context):"},{"line_number":227,"context_line":"    \"\"\"Whether or not user is hostAdmin according to policy setting."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"b7e2ca22_e6a562e9","line":226,"range":{"start_line":226,"start_character":4,"end_line":226,"end_character":22},"in_reply_to":"570a99e5_013e0020","updated":"2022-08-31 06:54:17.000000000","message":"Done","commit_id":"adccbc8b9f449dd9514c0c8502f8e477d22a6a00"}],"manila/tests/policy.yaml":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"bef97af458f85f0d0aea001cf0c537cd7778dc51","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# or extra rules in policy file, it is strongly"},{"line_number":3,"context_line":"# recommended to switch to new rules."},{"line_number":4,"context_line":"\"context_is_admin\": \"role:admin\""},{"line_number":5,"context_line":"\"context_is_host_admin\": \"role:admin or role:project_member\""},{"line_number":6,"context_line":"\"admin_api\": \"is_admin:True\""},{"line_number":7,"context_line":"\"admin_or_owner\": \"is_admin:True or project_id:%(project_id)s\""},{"line_number":8,"context_line":"\"default\": \"rule:admin_or_owner\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"0a597836_21247893","line":5,"range":{"start_line":5,"start_character":37,"end_line":5,"end_character":59},"updated":"2022-11-04 08:56:17.000000000","message":"Is this intentionally different from the default rule?","commit_id":"84ea60afdc350b8d3d669bbd790a8ab07968bc02"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7d086f70045835f5b8b8bcfd3da64484fe5ff9c6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# or extra rules in policy file, it is strongly"},{"line_number":3,"context_line":"# recommended to switch to new rules."},{"line_number":4,"context_line":"\"context_is_admin\": \"role:admin\""},{"line_number":5,"context_line":"\"context_is_host_admin\": \"role:admin or role:project_member\""},{"line_number":6,"context_line":"\"admin_api\": \"is_admin:True\""},{"line_number":7,"context_line":"\"admin_or_owner\": \"is_admin:True or project_id:%(project_id)s\""},{"line_number":8,"context_line":"\"default\": \"rule:admin_or_owner\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"97325096_ded82e8f","line":5,"range":{"start_line":5,"start_character":37,"end_line":5,"end_character":59},"in_reply_to":"0a597836_21247893","updated":"2023-02-27 10:34:52.000000000","message":"fixed","commit_id":"84ea60afdc350b8d3d669bbd790a8ab07968bc02"}]}