)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"c56404475487344d9af812bee4d8e1ba21be5194","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"488097f8_9a815d40","updated":"2022-01-30 00:22:44.000000000","message":"run NetApp-CI","commit_id":"a2c14d51e9f9fa0999516de620ebd52d7a325e6d"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"77800b03a4273c6a766be436396a51a712f21dc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c16eea41_2383d70c","updated":"2022-01-30 15:32:16.000000000","message":"run-DellEMC Unity CI","commit_id":"a2c14d51e9f9fa0999516de620ebd52d7a325e6d"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a2dfa5f5456d2760a44726a6c0cd52633ad816d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"860077fb_5c175517","updated":"2022-01-30 15:07:54.000000000","message":"run-NetApp CI","commit_id":"a2c14d51e9f9fa0999516de620ebd52d7a325e6d"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a159dd573625812260ab161de276a8321e8ead61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8e1d15b0_0369dea5","updated":"2022-01-28 20:20:56.000000000","message":"run-NetApp CI","commit_id":"a2c14d51e9f9fa0999516de620ebd52d7a325e6d"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"3816e02ba28f20eab93f57dc6a7517204c0be639","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"92b298f1_9836bf67","updated":"2022-01-30 00:23:19.000000000","message":"run-NetApp CI","commit_id":"a2c14d51e9f9fa0999516de620ebd52d7a325e6d"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ca37c4fe87bdcb7b21b475a945ea8a6d7c591ecf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"18823076_8fb2d7f0","updated":"2022-01-31 11:17:55.000000000","message":"run-NetApp CI","commit_id":"7887965abcd551f958a92f4d13876efc5bc4341d"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"98953858da2872e5f0c19da60a9a0e57dc035faf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"33d396ae_885a9131","updated":"2022-01-31 11:01:19.000000000","message":"run-NetApp CI","commit_id":"7887965abcd551f958a92f4d13876efc5bc4341d"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"b82dd928797d72b12e201a164a34736d7e1f9158","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"52d6eb2f_545a65d2","updated":"2022-02-01 18:47:54.000000000","message":"run-NetApp CI","commit_id":"7887965abcd551f958a92f4d13876efc5bc4341d"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"3d771f3670bd35a038890b0519b7299893250890","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5fd5400a_1181e532","updated":"2022-01-31 03:46:02.000000000","message":"run-NetApp CI","commit_id":"7887965abcd551f958a92f4d13876efc5bc4341d"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"b7b8b513e52f47955caebb2f70f701290b103aba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a28c5d36_5ae4156e","updated":"2022-02-03 13:23:18.000000000","message":"run-NetApp CI","commit_id":"7887965abcd551f958a92f4d13876efc5bc4341d"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"2127805144acdaef76bf223b2fc53c285a9f4184","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"354577be_783cc35d","updated":"2022-02-03 04:27:36.000000000","message":"run-NetApp CI","commit_id":"b311275ac567bf4c2519b65266ff9b5ee88ddd88"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6f6d4b7e6ef6268baa63034f68c5d59b98bf9c72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"0ac07f5c_2c2ff4e1","updated":"2022-02-08 01:01:37.000000000","message":"run-NetApp CI","commit_id":"bd66e4c0e82423ff4b828f08381f6c1aea5e5377"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6bd632a3cdae551bd00f1892f65670a871e525be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"0649181f_3969992d","updated":"2022-02-08 19:22:14.000000000","message":"run-NetApp CI","commit_id":"99d2ea133efbbcf0137ed35f291c345ada370546"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"f72c8739c3e320ffad9bb172494903c699b545cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"0ca73bad_d7f23b4a","updated":"2022-02-08 20:41:33.000000000","message":"run-NetApp CI","commit_id":"99d2ea133efbbcf0137ed35f291c345ada370546"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"251fd025c1073258bdbd2fb51b16003209f822bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"0d45a5c2_1f92e091","updated":"2022-02-08 19:25:46.000000000","message":"run-NetApp CI","commit_id":"99d2ea133efbbcf0137ed35f291c345ada370546"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"bd34eca000a9636446479f4e182cca49dd84223d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"0dce5c7a_bac69e04","updated":"2022-02-08 15:26:47.000000000","message":"run-NetApp CI","commit_id":"99d2ea133efbbcf0137ed35f291c345ada370546"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"1ca297d359723ee2608928fde8b346da1f7ffcbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"15ed5105_8f2a17a7","updated":"2022-02-08 19:20:26.000000000","message":"run-NetApp CI","commit_id":"99d2ea133efbbcf0137ed35f291c345ada370546"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"2c590da972ac9c5979c1b5e4ae1721661ff5cb8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"2112b13d_93fb4c08","updated":"2022-02-09 12:36:10.000000000","message":"run-NetApp CI","commit_id":"99d2ea133efbbcf0137ed35f291c345ada370546"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"f09b407a3979d28b2b1104fd39ccd900c9ebd244","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"4773ab06_92284cdb","updated":"2022-02-09 19:50:51.000000000","message":"run-NetApp CI","commit_id":"99d2ea133efbbcf0137ed35f291c345ada370546"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"37b01bf9492cfea2bfc8a4d2e5c4a4dd9c5cd5f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"5f6c0543_9b359038","updated":"2022-02-08 19:30:13.000000000","message":"run-NetApp CI","commit_id":"99d2ea133efbbcf0137ed35f291c345ada370546"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"05a1fd55032bd0de6d8a89e24eb51c14976b2297","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"8df6a964_dc712632","updated":"2022-02-08 20:13:37.000000000","message":"run-NetApp CI","commit_id":"99d2ea133efbbcf0137ed35f291c345ada370546"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"b0ea97ebf640d35400f7ec6eedcac98b2eaa3fec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"9e782b03_fa2f4bdc","updated":"2022-02-09 16:33:34.000000000","message":"run-NetApp CI","commit_id":"99d2ea133efbbcf0137ed35f291c345ada370546"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"4b21f0913b48c5fa0c71af10e69c66850d01c8ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"bb2a8a46_0d49272d","updated":"2022-02-09 23:48:32.000000000","message":"run-NetApp CI","commit_id":"99d2ea133efbbcf0137ed35f291c345ada370546"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"08cad7f9bd89c67a316df9a82f3722e17bcb175c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"c58d8693_881ba1cd","updated":"2022-02-08 21:51:27.000000000","message":"run-NetApp CI","commit_id":"99d2ea133efbbcf0137ed35f291c345ada370546"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"539725159dcefd29d6d8ae302fe6bfcc1f598513","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"c880fd81_c05af0dc","updated":"2022-02-09 11:55:10.000000000","message":"run-NetApp CI","commit_id":"99d2ea133efbbcf0137ed35f291c345ada370546"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"9b742c983fb28e2cc966a0229b68806a9d4b1783","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"e6f206d8_074c054e","updated":"2022-02-08 20:43:05.000000000","message":"run-NetApp CI","commit_id":"99d2ea133efbbcf0137ed35f291c345ada370546"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c930331689ac5ea6e79fd9c75a7a4bd266351a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"f3242288_a1d790f0","updated":"2022-02-14 17:48:20.000000000","message":"Thanks for proposing this change; some comments from the collaborative session we hosted. ","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3f445b2d113a1f342589c7cd46624765c85e9065","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"9a23520c_52ed637a","updated":"2022-02-11 04:41:50.000000000","message":"run-NetApp CI","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"b591c04cf216d07a2ff8403390854fa6015b1c9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"bd80caea_b3835884","updated":"2022-02-11 13:33:16.000000000","message":"run-NetApp CI","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"6cfb210e435714307a7f8e3b1024671f64003ead","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"c80a9100_ec8a27cc","updated":"2022-02-11 13:13:42.000000000","message":"run-NetApp CI","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"09fbb695b344fd97d63c621856ce9a78f8a5e48a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"d3391d8c_a5ea5405","updated":"2022-02-11 11:15:16.000000000","message":"run-NetApp CI","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ae76728fb2eb8915f0b492aabaa100c4165469c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"4c69664d_cefc3236","updated":"2022-02-23 18:17:15.000000000","message":"Thanks you all for proposing this patch. Can\u0027t see any major issue now, only few details and things that were discussed in previous review call.\n/me still need to check unit test files.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"3cb57cff_6e862a3f","updated":"2022-02-24 21:10:41.000000000","message":"Thank you Douglas, Carlos and Goutham! See the fixes/replies.","commit_id":"77be0a3d52565e0feeef31652ad91f39dc888453"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"85c9a69f8bd08da6adbbbdc5727523aa41710991","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"d6f8bf49_c3a2200c","updated":"2022-02-25 12:59:02.000000000","message":"Thank you Goutham! See the replies.","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"b428d87268f4967e2633b7779fe6ab3cf56ffd1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"0cb87f57_bc0d078f","updated":"2022-02-25 16:21:34.000000000","message":"recheck","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3599dd6b3966e60c08177a3724149f850d0dc221","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"bd9ee7b3_79a729f3","updated":"2022-03-02 20:15:14.000000000","message":"Change is looking good, there is a small detail in release-notes, please update together with other comments.\nStill looking into CI results.","commit_id":"13cfef43f93e04d53d236e0b63828b86267668e8"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"16f2faef_cae3b523","updated":"2022-03-02 13:29:25.000000000","message":"Hi all, Only marking as resolved some comments already answered and fixed by Felipe.","commit_id":"13cfef43f93e04d53d236e0b63828b86267668e8"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"341f09361780ecbd497b835e945caeb17b84509e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"9d326f6f_91056e47","updated":"2022-02-28 11:28:11.000000000","message":"run-NetApp CI","commit_id":"13cfef43f93e04d53d236e0b63828b86267668e8"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"b659312ef893af4a1039af5100051982ffd89547","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"f3e143ee_3a99a07b","updated":"2022-02-28 13:22:08.000000000","message":"run-NetApp CI","commit_id":"13cfef43f93e04d53d236e0b63828b86267668e8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"40fa4cb68831cbcdb7cb83743c031c3546730a19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"ae7e0ca5_88e93724","updated":"2022-03-03 20:19:14.000000000","message":"Don\u0027t have anything else major to point out.\nIf folks find something worth of an improvement, I think it would be fine to submit it as a follow-up\nThank you folks","commit_id":"2b57d15c641ff2a222c7d0af63853976b7e50f1f"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"1eac09af9f6ee34aa5ad2d3d4c7f5ea1e18f5349","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"cff6b14e_57a46cd2","updated":"2022-03-03 21:39:06.000000000","message":"Just one question inline. Please add in a follow up change with other small fixes if needed\nThank you all for working on this.\n\nStill watching tempest results in https://review.opendev.org/c/openstack/manila-tempest-plugin/+/826959 for these last patch sets.","commit_id":"2b57d15c641ff2a222c7d0af63853976b7e50f1f"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c78cf74da120a860d897a0903aa21fd5f5b5c0ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"d4e3534c_cd42ead4","updated":"2022-03-04 12:29:17.000000000","message":"Latest patch set shows good results with new tempest tests, for Container[1] and NetApp[2] driver.\n\n[1] https://b8e3005a9c234018e42e-40ade3a18cf00a73146bbcccb0567727.ssl.cf1.rackcdn.com/826959/17/check/manila-tempest-plugin-container/6ce399e/testr_results.html\n[2] https://netappopenstacklogserver.s3-us-west-1.amazonaws.com/logs/59/826959/17/upstream-check/manila-cDOT-manila-tempest-plugin-ss/0bb11fb/console.html.txt","commit_id":"2b57d15c641ff2a222c7d0af63853976b7e50f1f"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"b5c7b14dc1fe1752e2060cd929f463cbdd287591","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"20773380_0cdb7f5a","updated":"2022-03-03 03:38:53.000000000","message":"recheck","commit_id":"2b57d15c641ff2a222c7d0af63853976b7e50f1f"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"2e81383dfae695c8482782d34416483789459c0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"6ed62435_5d417be5","updated":"2022-03-03 11:11:08.000000000","message":"recheck","commit_id":"2b57d15c641ff2a222c7d0af63853976b7e50f1f"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"8a9307e2d2e61333886fc2441b2370ed96f460a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"30acef75_773916e7","updated":"2022-03-03 15:20:42.000000000","message":"run-NetApp CI","commit_id":"2b57d15c641ff2a222c7d0af63853976b7e50f1f"}],"manila/api/common.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7070bee6da7029377635079a3693565b9542155","unresolved":true,"context_lines":[{"line_number":564,"context_line":"    return api_params"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"def _validate_subnet(context, share_network_id, az, multiple_subnet_support):"},{"line_number":568,"context_line":"    \"\"\"Validate the az for the given subnet."},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    If az is None, the method will search for an existent default subnet."}],"source_content_type":"text/x-python","patch_set":26,"id":"0799ec1a_1877ee0c","line":567,"range":{"start_line":567,"start_character":4,"end_line":567,"end_character":20},"updated":"2022-02-25 08:02:44.000000000","message":"This method is doing too much - degrades readability..\nCan we just do subnet retrievals here and move the validation into the calling method?\n\n\n\nIf we do that, we can call this method \"_get_existing_subnets\"","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"85c9a69f8bd08da6adbbbdc5727523aa41710991","unresolved":true,"context_lines":[{"line_number":564,"context_line":"    return api_params"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"def _validate_subnet(context, share_network_id, az, multiple_subnet_support):"},{"line_number":568,"context_line":"    \"\"\"Validate the az for the given subnet."},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    If az is None, the method will search for an existent default subnet."}],"source_content_type":"text/x-python","patch_set":26,"id":"8f48267f_6fc7e491","line":567,"range":{"start_line":567,"start_character":4,"end_line":567,"end_character":20},"in_reply_to":"0799ec1a_1877ee0c","updated":"2022-02-25 12:59:02.000000000","message":"agree, done. see next patch.","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":564,"context_line":"    return api_params"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"def _validate_subnet(context, share_network_id, az, multiple_subnet_support):"},{"line_number":568,"context_line":"    \"\"\"Validate the az for the given subnet."},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    If az is None, the method will search for an existent default subnet."}],"source_content_type":"text/x-python","patch_set":26,"id":"97a273f2_0d34bf6f","line":567,"range":{"start_line":567,"start_character":4,"end_line":567,"end_character":20},"in_reply_to":"8f48267f_6fc7e491","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7070bee6da7029377635079a3693565b9542155","unresolved":true,"context_lines":[{"line_number":565,"context_line":""},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"def _validate_subnet(context, share_network_id, az, multiple_subnet_support):"},{"line_number":568,"context_line":"    \"\"\"Validate the az for the given subnet."},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    If az is None, the method will search for an existent default subnet."},{"line_number":571,"context_line":"    In case of a given AZ, validates if there\u0027s an existent subnet for it."}],"source_content_type":"text/x-python","patch_set":26,"id":"944e2ca3_e6e26ffb","line":568,"range":{"start_line":568,"start_character":8,"end_line":568,"end_character":44},"updated":"2022-02-25 08:02:44.000000000","message":"Return any existing subnets in the AZ requested","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":565,"context_line":""},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"def _validate_subnet(context, share_network_id, az, multiple_subnet_support):"},{"line_number":568,"context_line":"    \"\"\"Validate the az for the given subnet."},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    If az is None, the method will search for an existent default subnet."},{"line_number":571,"context_line":"    In case of a given AZ, validates if there\u0027s an existent subnet for it."}],"source_content_type":"text/x-python","patch_set":26,"id":"042b7fe7_7514baa8","line":568,"range":{"start_line":568,"start_character":8,"end_line":568,"end_character":44},"in_reply_to":"944e2ca3_e6e26ffb","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7070bee6da7029377635079a3693565b9542155","unresolved":true,"context_lines":[{"line_number":574,"context_line":"           \"specified availability zone. Only one share network \""},{"line_number":575,"context_line":"           \"subnet is allowed per availability zone for share \""},{"line_number":576,"context_line":"           \"network %s.\" % share_network_id)"},{"line_number":577,"context_line":"    subnets \u003d []"},{"line_number":578,"context_line":"    if az is None:"},{"line_number":579,"context_line":"        subnets \u003d db_api.share_network_subnet_get_default_subnets("},{"line_number":580,"context_line":"            context, share_network_id)"}],"source_content_type":"text/x-python","patch_set":26,"id":"f3b36203_fdb4553f","line":577,"range":{"start_line":577,"start_character":4,"end_line":577,"end_character":11},"updated":"2022-02-25 08:02:44.000000000","message":"can we call this: \"existing_subnets\"?","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":574,"context_line":"           \"specified availability zone. Only one share network \""},{"line_number":575,"context_line":"           \"subnet is allowed per availability zone for share \""},{"line_number":576,"context_line":"           \"network %s.\" % share_network_id)"},{"line_number":577,"context_line":"    subnets \u003d []"},{"line_number":578,"context_line":"    if az is None:"},{"line_number":579,"context_line":"        subnets \u003d db_api.share_network_subnet_get_default_subnets("},{"line_number":580,"context_line":"            context, share_network_id)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ec1f6032_948ba81b","line":577,"range":{"start_line":577,"start_character":4,"end_line":577,"end_character":11},"in_reply_to":"932d450a_fff33f2e","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"85c9a69f8bd08da6adbbbdc5727523aa41710991","unresolved":true,"context_lines":[{"line_number":574,"context_line":"           \"specified availability zone. Only one share network \""},{"line_number":575,"context_line":"           \"subnet is allowed per availability zone for share \""},{"line_number":576,"context_line":"           \"network %s.\" % share_network_id)"},{"line_number":577,"context_line":"    subnets \u003d []"},{"line_number":578,"context_line":"    if az is None:"},{"line_number":579,"context_line":"        subnets \u003d db_api.share_network_subnet_get_default_subnets("},{"line_number":580,"context_line":"            context, share_network_id)"}],"source_content_type":"text/x-python","patch_set":26,"id":"932d450a_fff33f2e","line":577,"range":{"start_line":577,"start_character":4,"end_line":577,"end_character":11},"in_reply_to":"f3b36203_fdb4553f","updated":"2022-02-25 12:59:02.000000000","message":"nice, done.","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7070bee6da7029377635079a3693565b9542155","unresolved":true,"context_lines":[{"line_number":613,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"    data[\u0027availability_zone_id\u0027] \u003d subnet_az.get(\u0027id\u0027)"},{"line_number":616,"context_line":"    subnets \u003d _validate_subnet("},{"line_number":617,"context_line":"        context, share_network_id, data[\u0027availability_zone_id\u0027],"},{"line_number":618,"context_line":"        multiple_subnet_support)"},{"line_number":619,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"a2a7d055_d1f4e527","line":616,"range":{"start_line":616,"start_character":4,"end_line":616,"end_character":11},"updated":"2022-02-25 08:02:44.000000000","message":"existing_subnets","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":613,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"    data[\u0027availability_zone_id\u0027] \u003d subnet_az.get(\u0027id\u0027)"},{"line_number":616,"context_line":"    subnets \u003d _validate_subnet("},{"line_number":617,"context_line":"        context, share_network_id, data[\u0027availability_zone_id\u0027],"},{"line_number":618,"context_line":"        multiple_subnet_support)"},{"line_number":619,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ec62c00b_134c0baa","line":616,"range":{"start_line":616,"start_character":4,"end_line":616,"end_character":11},"in_reply_to":"a1d3c1b6_131229c9","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"85c9a69f8bd08da6adbbbdc5727523aa41710991","unresolved":true,"context_lines":[{"line_number":613,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"    data[\u0027availability_zone_id\u0027] \u003d subnet_az.get(\u0027id\u0027)"},{"line_number":616,"context_line":"    subnets \u003d _validate_subnet("},{"line_number":617,"context_line":"        context, share_network_id, data[\u0027availability_zone_id\u0027],"},{"line_number":618,"context_line":"        multiple_subnet_support)"},{"line_number":619,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"a1d3c1b6_131229c9","line":616,"range":{"start_line":616,"start_character":4,"end_line":616,"end_character":11},"in_reply_to":"a2a7d055_d1f4e527","updated":"2022-02-25 12:59:02.000000000","message":"nice, done.","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7070bee6da7029377635079a3693565b9542155","unresolved":true,"context_lines":[{"line_number":616,"context_line":"    subnets \u003d _validate_subnet("},{"line_number":617,"context_line":"        context, share_network_id, data[\u0027availability_zone_id\u0027],"},{"line_number":618,"context_line":"        multiple_subnet_support)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    return share_network, subnets"}],"source_content_type":"text/x-python","patch_set":26,"id":"15c9df8b_5fdbf996","line":619,"updated":"2022-02-25 08:02:44.000000000","message":"Perform the validation from line 588 here instead..","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"85c9a69f8bd08da6adbbbdc5727523aa41710991","unresolved":true,"context_lines":[{"line_number":616,"context_line":"    subnets \u003d _validate_subnet("},{"line_number":617,"context_line":"        context, share_network_id, data[\u0027availability_zone_id\u0027],"},{"line_number":618,"context_line":"        multiple_subnet_support)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    return share_network, subnets"}],"source_content_type":"text/x-python","patch_set":26,"id":"dacd3556_ff7c2aab","line":619,"in_reply_to":"15c9df8b_5fdbf996","updated":"2022-02-25 12:59:02.000000000","message":"done.","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":616,"context_line":"    subnets \u003d _validate_subnet("},{"line_number":617,"context_line":"        context, share_network_id, data[\u0027availability_zone_id\u0027],"},{"line_number":618,"context_line":"        multiple_subnet_support)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    return share_network, subnets"}],"source_content_type":"text/x-python","patch_set":26,"id":"99bcd096_f4197b79","line":619,"in_reply_to":"dacd3556_ff7c2aab","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a0b80a1e8918ca77b7a913244fce078b43d2b7cb","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    * 2.67 - Added ability to set \u0027only_host\u0027 scheduler hint via the share"},{"line_number":177,"context_line":"             create API."},{"line_number":178,"context_line":"    * 2.68 - Added admin only capabilities to share metadata API"},{"line_number":179,"context_line":"    * 2.69 - Added support for multiple subnets in the same availability zone."},{"line_number":180,"context_line":"             Also, it can add subnets for an in-use share network."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":22,"id":"7af52140_74c39099","line":179,"range":{"start_line":179,"start_character":39,"end_line":179,"end_character":40},"updated":"2022-02-16 19:29:19.000000000","message":"share network","commit_id":"ca1cefcd5013bd6d506bda6bee5ecd271b501bd9"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    * 2.67 - Added ability to set \u0027only_host\u0027 scheduler hint via the share"},{"line_number":177,"context_line":"             create API."},{"line_number":178,"context_line":"    * 2.68 - Added admin only capabilities to share metadata API"},{"line_number":179,"context_line":"    * 2.69 - Added support for multiple subnets in the same availability zone."},{"line_number":180,"context_line":"             Also, it can add subnets for an in-use share network."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":22,"id":"37638eda_6b3ff44c","line":179,"range":{"start_line":179,"start_character":39,"end_line":179,"end_character":40},"in_reply_to":"5b74ac9f_59fad491","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"ca1cefcd5013bd6d506bda6bee5ecd271b501bd9"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    * 2.67 - Added ability to set \u0027only_host\u0027 scheduler hint via the share"},{"line_number":177,"context_line":"             create API."},{"line_number":178,"context_line":"    * 2.68 - Added admin only capabilities to share metadata API"},{"line_number":179,"context_line":"    * 2.69 - Added support for multiple subnets in the same availability zone."},{"line_number":180,"context_line":"             Also, it can add subnets for an in-use share network."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":22,"id":"5b74ac9f_59fad491","line":179,"range":{"start_line":179,"start_character":39,"end_line":179,"end_character":40},"in_reply_to":"7af52140_74c39099","updated":"2022-02-24 21:10:41.000000000","message":"done, see next patch.","commit_id":"ca1cefcd5013bd6d506bda6bee5ecd271b501bd9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a0b80a1e8918ca77b7a913244fce078b43d2b7cb","unresolved":true,"context_lines":[{"line_number":177,"context_line":"             create API."},{"line_number":178,"context_line":"    * 2.68 - Added admin only capabilities to share metadata API"},{"line_number":179,"context_line":"    * 2.69 - Added support for multiple subnets in the same availability zone."},{"line_number":180,"context_line":"             Also, it can add subnets for an in-use share network."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"\"\"\""},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"fd2f09a4_150ed59a","line":180,"range":{"start_line":180,"start_character":19,"end_line":180,"end_character":21},"updated":"2022-02-16 19:29:19.000000000","message":"users","commit_id":"ca1cefcd5013bd6d506bda6bee5ecd271b501bd9"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":177,"context_line":"             create API."},{"line_number":178,"context_line":"    * 2.68 - Added admin only capabilities to share metadata API"},{"line_number":179,"context_line":"    * 2.69 - Added support for multiple subnets in the same availability zone."},{"line_number":180,"context_line":"             Also, it can add subnets for an in-use share network."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"\"\"\""},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"62d8b4da_b7eb2b0d","line":180,"range":{"start_line":180,"start_character":19,"end_line":180,"end_character":21},"in_reply_to":"29481a3a_3ecaf2e0","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"ca1cefcd5013bd6d506bda6bee5ecd271b501bd9"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":177,"context_line":"             create API."},{"line_number":178,"context_line":"    * 2.68 - Added admin only capabilities to share metadata API"},{"line_number":179,"context_line":"    * 2.69 - Added support for multiple subnets in the same availability zone."},{"line_number":180,"context_line":"             Also, it can add subnets for an in-use share network."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"\"\"\""},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"29481a3a_3ecaf2e0","line":180,"range":{"start_line":180,"start_character":19,"end_line":180,"end_character":21},"in_reply_to":"fd2f09a4_150ed59a","updated":"2022-02-24 21:10:41.000000000","message":"done, see next patch.","commit_id":"ca1cefcd5013bd6d506bda6bee5ecd271b501bd9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"956c7eb168966ebb4592f18b1be2bed1bcd4ed23","unresolved":true,"context_lines":[{"line_number":185,"context_line":"# The default api version request is defined to be the"},{"line_number":186,"context_line":"# minimum version of the API supported."},{"line_number":187,"context_line":"_MIN_API_VERSION \u003d \"2.0\""},{"line_number":188,"context_line":"_MAX_API_VERSION \u003d \"2.69\""},{"line_number":189,"context_line":"DEFAULT_API_VERSION \u003d _MIN_API_VERSION"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"1f740dc5_87a59ece","line":188,"range":{"start_line":188,"start_character":22,"end_line":188,"end_character":24},"updated":"2022-02-22 23:49:10.000000000","message":"please bump it","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":185,"context_line":"# The default api version request is defined to be the"},{"line_number":186,"context_line":"# minimum version of the API supported."},{"line_number":187,"context_line":"_MIN_API_VERSION \u003d \"2.0\""},{"line_number":188,"context_line":"_MAX_API_VERSION \u003d \"2.69\""},{"line_number":189,"context_line":"DEFAULT_API_VERSION \u003d _MIN_API_VERSION"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"ab269dfa_8246bf8b","line":188,"range":{"start_line":188,"start_character":22,"end_line":188,"end_character":24},"in_reply_to":"1f4e0598_41bf84ce","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":185,"context_line":"# The default api version request is defined to be the"},{"line_number":186,"context_line":"# minimum version of the API supported."},{"line_number":187,"context_line":"_MIN_API_VERSION \u003d \"2.0\""},{"line_number":188,"context_line":"_MAX_API_VERSION \u003d \"2.69\""},{"line_number":189,"context_line":"DEFAULT_API_VERSION \u003d _MIN_API_VERSION"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"1f4e0598_41bf84ce","line":188,"range":{"start_line":188,"start_character":22,"end_line":188,"end_character":24},"in_reply_to":"1f740dc5_87a59ece","updated":"2022-02-24 21:10:41.000000000","message":"done, see next patch.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"}],"manila/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c930331689ac5ea6e79fd9c75a7a4bd266351a9","unresolved":true,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":"2.69"},{"line_number":382,"context_line":"----"},{"line_number":383,"context_line":"  Added support to configure multiple subnets in the same availability zone (or"},{"line_number":384,"context_line":"  the default one). It can also add new subnets for an in-use share network, to"},{"line_number":385,"context_line":"  distinguish this update support a new property called"},{"line_number":386,"context_line":"  \u0027network_allocation_update_support\u0027 was added in the share network and share"}],"source_content_type":"text/x-rst","patch_set":21,"id":"e87a5ee6_1a115b77","line":383,"range":{"start_line":383,"start_character":45,"end_line":383,"end_character":46},"updated":"2022-02-14 17:48:20.000000000","message":"for a given share network","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":"2.69"},{"line_number":382,"context_line":"----"},{"line_number":383,"context_line":"  Added support to configure multiple subnets in the same availability zone (or"},{"line_number":384,"context_line":"  the default one). It can also add new subnets for an in-use share network, to"},{"line_number":385,"context_line":"  distinguish this update support a new property called"},{"line_number":386,"context_line":"  \u0027network_allocation_update_support\u0027 was added in the share network and share"}],"source_content_type":"text/x-rst","patch_set":21,"id":"104652b6_5ee3451e","line":383,"range":{"start_line":383,"start_character":45,"end_line":383,"end_character":46},"in_reply_to":"c5e901ec_f811e970","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":"2.69"},{"line_number":382,"context_line":"----"},{"line_number":383,"context_line":"  Added support to configure multiple subnets in the same availability zone (or"},{"line_number":384,"context_line":"  the default one). It can also add new subnets for an in-use share network, to"},{"line_number":385,"context_line":"  distinguish this update support a new property called"},{"line_number":386,"context_line":"  \u0027network_allocation_update_support\u0027 was added in the share network and share"}],"source_content_type":"text/x-rst","patch_set":21,"id":"c5e901ec_f811e970","line":383,"range":{"start_line":383,"start_character":45,"end_line":383,"end_character":46},"in_reply_to":"e87a5ee6_1a115b77","updated":"2022-02-24 21:10:41.000000000","message":"done, see next patch.","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ae76728fb2eb8915f0b492aabaa100c4165469c","unresolved":true,"context_lines":[{"line_number":381,"context_line":"2.69"},{"line_number":382,"context_line":"----"},{"line_number":383,"context_line":"  Added support to configure multiple subnets in the same availability zone (or"},{"line_number":384,"context_line":"  the default one). It can also add new subnets for an in-use share network, to"},{"line_number":385,"context_line":"  distinguish this update support a new property called"},{"line_number":386,"context_line":"  \u0027network_allocation_update_support\u0027 was added in the share network and share"},{"line_number":387,"context_line":"  server."}],"source_content_type":"text/x-rst","patch_set":24,"id":"5044368c_8171d12c","line":384,"range":{"start_line":384,"start_character":75,"end_line":384,"end_character":78},"updated":"2022-02-23 18:17:15.000000000","message":". To dis...","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ae76728fb2eb8915f0b492aabaa100c4165469c","unresolved":true,"context_lines":[{"line_number":381,"context_line":"2.69"},{"line_number":382,"context_line":"----"},{"line_number":383,"context_line":"  Added support to configure multiple subnets in the same availability zone (or"},{"line_number":384,"context_line":"  the default one). It can also add new subnets for an in-use share network, to"},{"line_number":385,"context_line":"  distinguish this update support a new property called"},{"line_number":386,"context_line":"  \u0027network_allocation_update_support\u0027 was added in the share network and share"},{"line_number":387,"context_line":"  server."}],"source_content_type":"text/x-rst","patch_set":24,"id":"3f65ac30_9de3b4db","line":384,"range":{"start_line":384,"start_character":19,"end_line":384,"end_character":22},"updated":"2022-02-23 18:17:15.000000000","message":"Users","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":381,"context_line":"2.69"},{"line_number":382,"context_line":"----"},{"line_number":383,"context_line":"  Added support to configure multiple subnets in the same availability zone (or"},{"line_number":384,"context_line":"  the default one). It can also add new subnets for an in-use share network, to"},{"line_number":385,"context_line":"  distinguish this update support a new property called"},{"line_number":386,"context_line":"  \u0027network_allocation_update_support\u0027 was added in the share network and share"},{"line_number":387,"context_line":"  server."}],"source_content_type":"text/x-rst","patch_set":24,"id":"43190819_8fd2ab39","line":384,"range":{"start_line":384,"start_character":75,"end_line":384,"end_character":78},"in_reply_to":"148f032e_deda731e","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":381,"context_line":"2.69"},{"line_number":382,"context_line":"----"},{"line_number":383,"context_line":"  Added support to configure multiple subnets in the same availability zone (or"},{"line_number":384,"context_line":"  the default one). It can also add new subnets for an in-use share network, to"},{"line_number":385,"context_line":"  distinguish this update support a new property called"},{"line_number":386,"context_line":"  \u0027network_allocation_update_support\u0027 was added in the share network and share"},{"line_number":387,"context_line":"  server."}],"source_content_type":"text/x-rst","patch_set":24,"id":"dfd16c53_76535d0b","line":384,"range":{"start_line":384,"start_character":19,"end_line":384,"end_character":22},"in_reply_to":"29ce4fb9_1c2157cd","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":381,"context_line":"2.69"},{"line_number":382,"context_line":"----"},{"line_number":383,"context_line":"  Added support to configure multiple subnets in the same availability zone (or"},{"line_number":384,"context_line":"  the default one). It can also add new subnets for an in-use share network, to"},{"line_number":385,"context_line":"  distinguish this update support a new property called"},{"line_number":386,"context_line":"  \u0027network_allocation_update_support\u0027 was added in the share network and share"},{"line_number":387,"context_line":"  server."}],"source_content_type":"text/x-rst","patch_set":24,"id":"29ce4fb9_1c2157cd","line":384,"range":{"start_line":384,"start_character":19,"end_line":384,"end_character":22},"in_reply_to":"3f65ac30_9de3b4db","updated":"2022-02-24 21:10:41.000000000","message":"done, see next patch.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":381,"context_line":"2.69"},{"line_number":382,"context_line":"----"},{"line_number":383,"context_line":"  Added support to configure multiple subnets in the same availability zone (or"},{"line_number":384,"context_line":"  the default one). It can also add new subnets for an in-use share network, to"},{"line_number":385,"context_line":"  distinguish this update support a new property called"},{"line_number":386,"context_line":"  \u0027network_allocation_update_support\u0027 was added in the share network and share"},{"line_number":387,"context_line":"  server."}],"source_content_type":"text/x-rst","patch_set":24,"id":"148f032e_deda731e","line":384,"range":{"start_line":384,"start_character":75,"end_line":384,"end_character":78},"in_reply_to":"5044368c_8171d12c","updated":"2022-02-24 21:10:41.000000000","message":"done, see next patch.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"}],"manila/api/v1/share_servers.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c930331689ac5ea6e79fd9c75a7a4bd266351a9","unresolved":true,"context_lines":[{"line_number":56,"context_line":"                s.share_network_name \u003d \u0027\u0027"},{"line_number":57,"context_line":"                continue"},{"line_number":58,"context_line":"            try:"},{"line_number":59,"context_line":"                s.share_network_id \u003d ("},{"line_number":60,"context_line":"                    s.share_network_subnets[0][\u0027share_network_id\u0027])"},{"line_number":61,"context_line":"                share_network \u003d db_api.share_network_get("},{"line_number":62,"context_line":"                    context, s.share_network_id)"},{"line_number":63,"context_line":"                s.project_id \u003d share_network[\u0027project_id\u0027]"}],"source_content_type":"text/x-python","patch_set":21,"id":"c3b6341d_8f84a4af","line":60,"range":{"start_line":59,"start_character":16,"end_line":60,"end_character":65},"updated":"2022-02-14 17:48:20.000000000","message":"You can have this as a @property to the share server so you don\u0027t need to parse it here..","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                s.share_network_name \u003d \u0027\u0027"},{"line_number":57,"context_line":"                continue"},{"line_number":58,"context_line":"            try:"},{"line_number":59,"context_line":"                s.share_network_id \u003d ("},{"line_number":60,"context_line":"                    s.share_network_subnets[0][\u0027share_network_id\u0027])"},{"line_number":61,"context_line":"                share_network \u003d db_api.share_network_get("},{"line_number":62,"context_line":"                    context, s.share_network_id)"},{"line_number":63,"context_line":"                s.project_id \u003d share_network[\u0027project_id\u0027]"}],"source_content_type":"text/x-python","patch_set":21,"id":"a3073533_9ee3e7bb","line":60,"range":{"start_line":59,"start_character":16,"end_line":60,"end_character":65},"in_reply_to":"9f710b0f_c20f7e90","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":56,"context_line":"                s.share_network_name \u003d \u0027\u0027"},{"line_number":57,"context_line":"                continue"},{"line_number":58,"context_line":"            try:"},{"line_number":59,"context_line":"                s.share_network_id \u003d ("},{"line_number":60,"context_line":"                    s.share_network_subnets[0][\u0027share_network_id\u0027])"},{"line_number":61,"context_line":"                share_network \u003d db_api.share_network_get("},{"line_number":62,"context_line":"                    context, s.share_network_id)"},{"line_number":63,"context_line":"                s.project_id \u003d share_network[\u0027project_id\u0027]"}],"source_content_type":"text/x-python","patch_set":21,"id":"9f710b0f_c20f7e90","line":60,"range":{"start_line":59,"start_character":16,"end_line":60,"end_character":65},"in_reply_to":"c3b6341d_8f84a4af","updated":"2022-02-24 21:10:41.000000000","message":"done, see next patch.","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"956c7eb168966ebb4592f18b1be2bed1bcd4ed23","unresolved":true,"context_lines":[{"line_number":92,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":93,"context_line":"        try:"},{"line_number":94,"context_line":"            server \u003d db_api.share_server_get(context, id)"},{"line_number":95,"context_line":"            net_id \u003d (server.share_network_subnets[0][\u0027share_network_id\u0027]"},{"line_number":96,"context_line":"                      if server.share_network_subnets else None)"},{"line_number":97,"context_line":"            share_network \u003d db_api.share_network_get("},{"line_number":98,"context_line":"                context, net_id)"}],"source_content_type":"text/x-python","patch_set":24,"id":"ea575cd1_d832e27e","line":95,"range":{"start_line":95,"start_character":12,"end_line":95,"end_character":18},"updated":"2022-02-22 23:49:10.000000000","message":"nit: share_network_id\nI think having it as the real name could help to make the code more readable","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":93,"context_line":"        try:"},{"line_number":94,"context_line":"            server \u003d db_api.share_server_get(context, id)"},{"line_number":95,"context_line":"            net_id \u003d (server.share_network_subnets[0][\u0027share_network_id\u0027]"},{"line_number":96,"context_line":"                      if server.share_network_subnets else None)"},{"line_number":97,"context_line":"            share_network \u003d db_api.share_network_get("},{"line_number":98,"context_line":"                context, net_id)"}],"source_content_type":"text/x-python","patch_set":24,"id":"eb498f8b_d6c0c1b5","line":95,"range":{"start_line":95,"start_character":12,"end_line":95,"end_character":18},"in_reply_to":"708a6873_2b686260","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":92,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":93,"context_line":"        try:"},{"line_number":94,"context_line":"            server \u003d db_api.share_server_get(context, id)"},{"line_number":95,"context_line":"            net_id \u003d (server.share_network_subnets[0][\u0027share_network_id\u0027]"},{"line_number":96,"context_line":"                      if server.share_network_subnets else None)"},{"line_number":97,"context_line":"            share_network \u003d db_api.share_network_get("},{"line_number":98,"context_line":"                context, net_id)"}],"source_content_type":"text/x-python","patch_set":24,"id":"708a6873_2b686260","line":95,"range":{"start_line":95,"start_character":12,"end_line":95,"end_character":18},"in_reply_to":"ea575cd1_d832e27e","updated":"2022-02-24 21:10:41.000000000","message":"makes sense. Actually, we can now access directly the net id with the new property, so I removed this variable. See next patch.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cdbcd1f07ad0f2f14fac2ca9c2df998b40402f6d","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        search_opts.update(req.GET)"},{"line_number":51,"context_line":"        share_servers \u003d db_api.share_server_get_all(context)"},{"line_number":52,"context_line":"        for s in share_servers:"},{"line_number":53,"context_line":"            if not s.share_network_id:"},{"line_number":54,"context_line":"                s.project_id \u003d \u0027\u0027"},{"line_number":55,"context_line":"                s.share_network_name \u003d \u0027\u0027"},{"line_number":56,"context_line":"                continue"},{"line_number":57,"context_line":"            try:"},{"line_number":58,"context_line":"                share_network \u003d db_api.share_network_get("},{"line_number":59,"context_line":"                    context, s.share_network_id)"}],"source_content_type":"text/x-python","patch_set":27,"id":"60bf5b61_ec168cec","line":56,"range":{"start_line":53,"start_character":12,"end_line":56,"end_character":24},"updated":"2022-02-25 19:20:40.000000000","message":"I think this scenario wouldn\u0027t exist... Share server must have a share network id related to it","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"39e609776ce5356ee37d5b41554adfdd9d1ab222","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        search_opts.update(req.GET)"},{"line_number":51,"context_line":"        share_servers \u003d db_api.share_server_get_all(context)"},{"line_number":52,"context_line":"        for s in share_servers:"},{"line_number":53,"context_line":"            if not s.share_network_id:"},{"line_number":54,"context_line":"                s.project_id \u003d \u0027\u0027"},{"line_number":55,"context_line":"                s.share_network_name \u003d \u0027\u0027"},{"line_number":56,"context_line":"                continue"},{"line_number":57,"context_line":"            try:"},{"line_number":58,"context_line":"                share_network \u003d db_api.share_network_get("},{"line_number":59,"context_line":"                    context, s.share_network_id)"}],"source_content_type":"text/x-python","patch_set":27,"id":"cbb213ec_28d9b833","line":56,"range":{"start_line":53,"start_character":12,"end_line":56,"end_character":24},"in_reply_to":"60bf5b61_ec168cec","updated":"2022-02-25 20:12:21.000000000","message":"nice, removed.","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        search_opts.update(req.GET)"},{"line_number":51,"context_line":"        share_servers \u003d db_api.share_server_get_all(context)"},{"line_number":52,"context_line":"        for s in share_servers:"},{"line_number":53,"context_line":"            if not s.share_network_id:"},{"line_number":54,"context_line":"                s.project_id \u003d \u0027\u0027"},{"line_number":55,"context_line":"                s.share_network_name \u003d \u0027\u0027"},{"line_number":56,"context_line":"                continue"},{"line_number":57,"context_line":"            try:"},{"line_number":58,"context_line":"                share_network \u003d db_api.share_network_get("},{"line_number":59,"context_line":"                    context, s.share_network_id)"}],"source_content_type":"text/x-python","patch_set":27,"id":"349c5856_293f5bf6","line":56,"range":{"start_line":53,"start_character":12,"end_line":56,"end_character":24},"in_reply_to":"cbb213ec_28d9b833","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"}],"manila/api/v2/share_network_subnets.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c930331689ac5ea6e79fd9c75a7a4bd266351a9","unresolved":true,"context_lines":[{"line_number":119,"context_line":"               \"subnet is allowed per availability zone for share \""},{"line_number":120,"context_line":"               \"network %s.\" % share_network_id)"},{"line_number":121,"context_line":"        subnets \u003d []"},{"line_number":122,"context_line":"        if az is None:"},{"line_number":123,"context_line":"            subnets \u003d db_api.share_network_subnet_get_default_subnet("},{"line_number":124,"context_line":"                context, share_network_id)"},{"line_number":125,"context_line":"        else:"},{"line_number":126,"context_line":"            subnets \u003d ("},{"line_number":127,"context_line":"                db_api.share_network_subnet_get_by_availability_zone_id("},{"line_number":128,"context_line":"                    context, share_network_id, az[\u0027id\u0027],"},{"line_number":129,"context_line":"                    fallback_default\u003dFalse)"},{"line_number":130,"context_line":"            )"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if subnets and not multiple_subnet_support:"}],"source_content_type":"text/x-python","patch_set":21,"id":"263cfc81_001ef2fa","line":129,"range":{"start_line":122,"start_character":8,"end_line":129,"end_character":43},"updated":"2022-02-14 17:48:20.000000000","message":"can this be optimized with one db call?","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":119,"context_line":"               \"subnet is allowed per availability zone for share \""},{"line_number":120,"context_line":"               \"network %s.\" % share_network_id)"},{"line_number":121,"context_line":"        subnets \u003d []"},{"line_number":122,"context_line":"        if az is None:"},{"line_number":123,"context_line":"            subnets \u003d db_api.share_network_subnet_get_default_subnet("},{"line_number":124,"context_line":"                context, share_network_id)"},{"line_number":125,"context_line":"        else:"},{"line_number":126,"context_line":"            subnets \u003d ("},{"line_number":127,"context_line":"                db_api.share_network_subnet_get_by_availability_zone_id("},{"line_number":128,"context_line":"                    context, share_network_id, az[\u0027id\u0027],"},{"line_number":129,"context_line":"                    fallback_default\u003dFalse)"},{"line_number":130,"context_line":"            )"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if subnets and not multiple_subnet_support:"}],"source_content_type":"text/x-python","patch_set":21,"id":"d13d9842_de485ee4","line":129,"range":{"start_line":122,"start_character":8,"end_line":129,"end_character":43},"in_reply_to":"263cfc81_001ef2fa","updated":"2022-02-24 21:10:41.000000000","message":"what do you mean by optimized  ?! They are not being called together, so it only calls one single db request. Do you mean handle this \"if\" condition on db api layer ?! This code is following what had been done before (see diff).","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c930331689ac5ea6e79fd9c75a7a4bd266351a9","unresolved":true,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        # create subnet operation on subnets with share servers means that an"},{"line_number":178,"context_line":"        # allocation update is requested."},{"line_number":179,"context_line":"        if (subnets and subnets[0][\u0027share_servers\u0027] and"},{"line_number":180,"context_line":"                len(subnets[0][\u0027share_servers\u0027]) \u003e 0):"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"            # NOTE(felipe_rodrigues): all subnets have the same set of share"},{"line_number":183,"context_line":"            # servers, so we can just get the servers from one of them. Not"}],"source_content_type":"text/x-python","patch_set":21,"id":"0f5ca826_c83a1be8","line":180,"range":{"start_line":179,"start_character":24,"end_line":180,"end_character":52},"updated":"2022-02-14 17:48:20.000000000","message":"these two conditions are the same..","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        # create subnet operation on subnets with share servers means that an"},{"line_number":178,"context_line":"        # allocation update is requested."},{"line_number":179,"context_line":"        if (subnets and subnets[0][\u0027share_servers\u0027] and"},{"line_number":180,"context_line":"                len(subnets[0][\u0027share_servers\u0027]) \u003e 0):"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"            # NOTE(felipe_rodrigues): all subnets have the same set of share"},{"line_number":183,"context_line":"            # servers, so we can just get the servers from one of them. Not"}],"source_content_type":"text/x-python","patch_set":21,"id":"bac2dcb2_683a6ec8","line":180,"range":{"start_line":179,"start_character":24,"end_line":180,"end_character":52},"in_reply_to":"0f5ca826_c83a1be8","updated":"2022-02-24 21:10:41.000000000","message":"done, see next patch.","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        # create subnet operation on subnets with share servers means that an"},{"line_number":178,"context_line":"        # allocation update is requested."},{"line_number":179,"context_line":"        if (subnets and subnets[0][\u0027share_servers\u0027] and"},{"line_number":180,"context_line":"                len(subnets[0][\u0027share_servers\u0027]) \u003e 0):"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"            # NOTE(felipe_rodrigues): all subnets have the same set of share"},{"line_number":183,"context_line":"            # servers, so we can just get the servers from one of them. Not"}],"source_content_type":"text/x-python","patch_set":21,"id":"e1b28641_ba048bf2","line":180,"range":{"start_line":179,"start_character":24,"end_line":180,"end_character":52},"in_reply_to":"bac2dcb2_683a6ec8","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c930331689ac5ea6e79fd9c75a7a4bd266351a9","unresolved":true,"context_lines":[{"line_number":194,"context_line":"                raise exc.HTTPConflict(explanation\u003de.msg)"},{"line_number":195,"context_line":"            except exception.InvalidShareNetwork as e:"},{"line_number":196,"context_line":"                raise exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":197,"context_line":"            except db_exception.DBError as e:"},{"line_number":198,"context_line":"                msg \u003d _(\u0027Could not add the share network subnet.\u0027)"},{"line_number":199,"context_line":"                LOG.error(e)"},{"line_number":200,"context_line":"                raise exc.HTTPInternalServerError(explanation\u003dmsg)"},{"line_number":201,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":21,"id":"d92a8036_1c8b3934","line":198,"range":{"start_line":197,"start_character":12,"end_line":198,"end_character":66},"updated":"2022-02-14 17:48:20.000000000","message":"This is a better error message for line 194 as well.. log the \"service is down\" error for an administrator, but\n\nyou don\u0027t want to break the cloud abstraction to regular users who have access to this API.","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                raise exc.HTTPConflict(explanation\u003de.msg)"},{"line_number":195,"context_line":"            except exception.InvalidShareNetwork as e:"},{"line_number":196,"context_line":"                raise exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":197,"context_line":"            except db_exception.DBError as e:"},{"line_number":198,"context_line":"                msg \u003d _(\u0027Could not add the share network subnet.\u0027)"},{"line_number":199,"context_line":"                LOG.error(e)"},{"line_number":200,"context_line":"                raise exc.HTTPInternalServerError(explanation\u003dmsg)"},{"line_number":201,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":21,"id":"d23d13a0_aa762544","line":198,"range":{"start_line":197,"start_character":12,"end_line":198,"end_character":66},"in_reply_to":"73dd8719_7299a245","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":194,"context_line":"                raise exc.HTTPConflict(explanation\u003de.msg)"},{"line_number":195,"context_line":"            except exception.InvalidShareNetwork as e:"},{"line_number":196,"context_line":"                raise exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":197,"context_line":"            except db_exception.DBError as e:"},{"line_number":198,"context_line":"                msg \u003d _(\u0027Could not add the share network subnet.\u0027)"},{"line_number":199,"context_line":"                LOG.error(e)"},{"line_number":200,"context_line":"                raise exc.HTTPInternalServerError(explanation\u003dmsg)"},{"line_number":201,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":21,"id":"73dd8719_7299a245","line":198,"range":{"start_line":197,"start_character":12,"end_line":198,"end_character":66},"in_reply_to":"d92a8036_1c8b3934","updated":"2022-02-24 21:10:41.000000000","message":"done, see next patch.","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"956c7eb168966ebb4592f18b1be2bed1bcd4ed23","unresolved":true,"context_lines":[{"line_number":129,"context_line":"                    fallback_default\u003dFalse)"},{"line_number":130,"context_line":"            )"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if subnets and not multiple_subnet_support:"},{"line_number":133,"context_line":"            raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        return subnets"}],"source_content_type":"text/x-python","patch_set":24,"id":"07c2133b_a2d7c791","line":132,"range":{"start_line":132,"start_character":11,"end_line":132,"end_character":18},"updated":"2022-02-22 23:49:10.000000000","message":"shouldn\u0027t this be len(subnets) \u003e 1?","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":129,"context_line":"                    fallback_default\u003dFalse)"},{"line_number":130,"context_line":"            )"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if subnets and not multiple_subnet_support:"},{"line_number":133,"context_line":"            raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        return subnets"}],"source_content_type":"text/x-python","patch_set":24,"id":"828985b3_6c533d12","line":132,"range":{"start_line":132,"start_character":11,"end_line":132,"end_character":18},"in_reply_to":"07c2133b_a2d7c791","updated":"2022-02-24 21:10:41.000000000","message":"Don\u0027t think so. That\u0027s a bit tricky.\n\nThe user is requesting a create subnet, so we need to check if the pre-existent subnet list with the new one will be multiple. In another words, if the \"subnets\" list contains one single item, with the new requested one, the subnets will become multiple needing \"multiple_subnet_support\" true.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cdbcd1f07ad0f2f14fac2ca9c2df998b40402f6d","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                    fallback_default\u003dFalse)"},{"line_number":130,"context_line":"            )"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if subnets and not multiple_subnet_support:"},{"line_number":133,"context_line":"            raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        return subnets"}],"source_content_type":"text/x-python","patch_set":24,"id":"bec0451f_544345e4","line":132,"range":{"start_line":132,"start_character":11,"end_line":132,"end_character":18},"in_reply_to":"828985b3_6c533d12","updated":"2022-02-25 19:20:40.000000000","message":"Ack","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"956c7eb168966ebb4592f18b1be2bed1bcd4ed23","unresolved":true,"context_lines":[{"line_number":155,"context_line":"            raise exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        availability_zone \u003d data.pop(\u0027availability_zone\u0027, None)"},{"line_number":158,"context_line":"        subnet_az \u003d None"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        if availability_zone:"},{"line_number":161,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":24,"id":"0df10839_cf5887bc","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":24},"updated":"2022-02-22 23:49:10.000000000","message":"subnet_az \u003d {}","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":155,"context_line":"            raise exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        availability_zone \u003d data.pop(\u0027availability_zone\u0027, None)"},{"line_number":158,"context_line":"        subnet_az \u003d None"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        if availability_zone:"},{"line_number":161,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":24,"id":"927bb500_e2baaf3d","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":24},"in_reply_to":"0df10839_cf5887bc","updated":"2022-02-24 21:10:41.000000000","message":"done, see next patch.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            raise exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        availability_zone \u003d data.pop(\u0027availability_zone\u0027, None)"},{"line_number":158,"context_line":"        subnet_az \u003d None"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        if availability_zone:"},{"line_number":161,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":24,"id":"2050db90_797280f9","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":24},"in_reply_to":"927bb500_e2baaf3d","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"956c7eb168966ebb4592f18b1be2bed1bcd4ed23","unresolved":true,"context_lines":[{"line_number":167,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        data[\u0027availability_zone_id\u0027] \u003d ("},{"line_number":170,"context_line":"            subnet_az[\u0027id\u0027] if subnet_az is not None else None)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        multiple_subnet_support \u003d (req.api_version_request \u003e\u003d"},{"line_number":173,"context_line":"                                   api_version.APIVersionRequest(\"2.69\"))"}],"source_content_type":"text/x-python","patch_set":24,"id":"626c8ec6_8f29a6b0","line":170,"range":{"start_line":170,"start_character":12,"end_line":170,"end_character":62},"updated":"2022-02-22 23:49:10.000000000","message":"subnet_az.get(\u0027id\u0027, None)","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":167,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        data[\u0027availability_zone_id\u0027] \u003d ("},{"line_number":170,"context_line":"            subnet_az[\u0027id\u0027] if subnet_az is not None else None)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        multiple_subnet_support \u003d (req.api_version_request \u003e\u003d"},{"line_number":173,"context_line":"                                   api_version.APIVersionRequest(\"2.69\"))"}],"source_content_type":"text/x-python","patch_set":24,"id":"b8d2f0b5_7b971099","line":170,"range":{"start_line":170,"start_character":12,"end_line":170,"end_character":62},"in_reply_to":"626c8ec6_8f29a6b0","updated":"2022-02-24 21:10:41.000000000","message":"done, see next patch. This code is now in the common file.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        data[\u0027availability_zone_id\u0027] \u003d ("},{"line_number":170,"context_line":"            subnet_az[\u0027id\u0027] if subnet_az is not None else None)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        multiple_subnet_support \u003d (req.api_version_request \u003e\u003d"},{"line_number":173,"context_line":"                                   api_version.APIVersionRequest(\"2.69\"))"}],"source_content_type":"text/x-python","patch_set":24,"id":"23aa2e3d_8723fe83","line":170,"range":{"start_line":170,"start_character":12,"end_line":170,"end_character":62},"in_reply_to":"b8d2f0b5_7b971099","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7070bee6da7029377635079a3693565b9542155","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        data[\u0027share_network_id\u0027] \u003d share_network_id"},{"line_number":120,"context_line":"        multiple_subnet_support \u003d (req.api_version_request \u003e\u003d"},{"line_number":121,"context_line":"                                   api_version.APIVersionRequest(\"2.70\"))"},{"line_number":122,"context_line":"        share_network, subnets \u003d common.validate_subnet_create("},{"line_number":123,"context_line":"            context, share_network_id, data, multiple_subnet_support)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        # create subnet operation on subnets with share servers means that an"}],"source_content_type":"text/x-python","patch_set":26,"id":"6529ab28_43a4003b","line":122,"range":{"start_line":122,"start_character":23,"end_line":122,"end_character":30},"updated":"2022-02-25 08:02:44.000000000","message":"existing_subnets","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"85c9a69f8bd08da6adbbbdc5727523aa41710991","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        data[\u0027share_network_id\u0027] \u003d share_network_id"},{"line_number":120,"context_line":"        multiple_subnet_support \u003d (req.api_version_request \u003e\u003d"},{"line_number":121,"context_line":"                                   api_version.APIVersionRequest(\"2.70\"))"},{"line_number":122,"context_line":"        share_network, subnets \u003d common.validate_subnet_create("},{"line_number":123,"context_line":"            context, share_network_id, data, multiple_subnet_support)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        # create subnet operation on subnets with share servers means that an"}],"source_content_type":"text/x-python","patch_set":26,"id":"688cc9dc_1a28c5e0","line":122,"range":{"start_line":122,"start_character":23,"end_line":122,"end_character":30},"in_reply_to":"6529ab28_43a4003b","updated":"2022-02-25 12:59:02.000000000","message":"done.","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        data[\u0027share_network_id\u0027] \u003d share_network_id"},{"line_number":120,"context_line":"        multiple_subnet_support \u003d (req.api_version_request \u003e\u003d"},{"line_number":121,"context_line":"                                   api_version.APIVersionRequest(\"2.70\"))"},{"line_number":122,"context_line":"        share_network, subnets \u003d common.validate_subnet_create("},{"line_number":123,"context_line":"            context, share_network_id, data, multiple_subnet_support)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        # create subnet operation on subnets with share servers means that an"}],"source_content_type":"text/x-python","patch_set":26,"id":"58016c03_854ad4e2","line":122,"range":{"start_line":122,"start_character":23,"end_line":122,"end_character":30},"in_reply_to":"688cc9dc_1a28c5e0","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7070bee6da7029377635079a3693565b9542155","unresolved":true,"context_lines":[{"line_number":122,"context_line":"        share_network, subnets \u003d common.validate_subnet_create("},{"line_number":123,"context_line":"            context, share_network_id, data, multiple_subnet_support)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        # create subnet operation on subnets with share servers means that an"},{"line_number":126,"context_line":"        # allocation update is requested."},{"line_number":127,"context_line":"        if subnets and subnets[0][\u0027share_servers\u0027]:"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"cf4adb58_80a83db3","line":125,"range":{"start_line":125,"start_character":34,"end_line":125,"end_character":44},"updated":"2022-02-25 08:02:44.000000000","message":"alongside subnets","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        share_network, subnets \u003d common.validate_subnet_create("},{"line_number":123,"context_line":"            context, share_network_id, data, multiple_subnet_support)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        # create subnet operation on subnets with share servers means that an"},{"line_number":126,"context_line":"        # allocation update is requested."},{"line_number":127,"context_line":"        if subnets and subnets[0][\u0027share_servers\u0027]:"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"760fa4e5_d028c414","line":125,"range":{"start_line":125,"start_character":34,"end_line":125,"end_character":44},"in_reply_to":"190b0588_8467f72e","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"85c9a69f8bd08da6adbbbdc5727523aa41710991","unresolved":true,"context_lines":[{"line_number":122,"context_line":"        share_network, subnets \u003d common.validate_subnet_create("},{"line_number":123,"context_line":"            context, share_network_id, data, multiple_subnet_support)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        # create subnet operation on subnets with share servers means that an"},{"line_number":126,"context_line":"        # allocation update is requested."},{"line_number":127,"context_line":"        if subnets and subnets[0][\u0027share_servers\u0027]:"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"190b0588_8467f72e","line":125,"range":{"start_line":125,"start_character":34,"end_line":125,"end_character":44},"in_reply_to":"cf4adb58_80a83db3","updated":"2022-02-25 12:59:02.000000000","message":"done.","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7070bee6da7029377635079a3693565b9542155","unresolved":true,"context_lines":[{"line_number":140,"context_line":"            except exception.ServiceIsDown as e:"},{"line_number":141,"context_line":"                msg \u003d _(\u0027Could not add the share network subnet.\u0027)"},{"line_number":142,"context_line":"                LOG.error(e)"},{"line_number":143,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":144,"context_line":"            except exception.InvalidShareNetwork as e:"},{"line_number":145,"context_line":"                raise exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":146,"context_line":"            except db_exception.DBError as e:"}],"source_content_type":"text/x-python","patch_set":26,"id":"f1f41873_e4a5daf0","line":143,"range":{"start_line":143,"start_character":22,"end_line":143,"end_character":55},"updated":"2022-02-25 08:02:44.000000000","message":"Not really a conflict.. since the service is down, we could use exc.HTTPInternalServerError - a non-retriable error.","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            except exception.ServiceIsDown as e:"},{"line_number":141,"context_line":"                msg \u003d _(\u0027Could not add the share network subnet.\u0027)"},{"line_number":142,"context_line":"                LOG.error(e)"},{"line_number":143,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":144,"context_line":"            except exception.InvalidShareNetwork as e:"},{"line_number":145,"context_line":"                raise exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":146,"context_line":"            except db_exception.DBError as e:"}],"source_content_type":"text/x-python","patch_set":26,"id":"fab66df6_f7b98868","line":143,"range":{"start_line":143,"start_character":22,"end_line":143,"end_character":55},"in_reply_to":"28736c81_7cc78527","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"85c9a69f8bd08da6adbbbdc5727523aa41710991","unresolved":true,"context_lines":[{"line_number":140,"context_line":"            except exception.ServiceIsDown as e:"},{"line_number":141,"context_line":"                msg \u003d _(\u0027Could not add the share network subnet.\u0027)"},{"line_number":142,"context_line":"                LOG.error(e)"},{"line_number":143,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":144,"context_line":"            except exception.InvalidShareNetwork as e:"},{"line_number":145,"context_line":"                raise exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":146,"context_line":"            except db_exception.DBError as e:"}],"source_content_type":"text/x-python","patch_set":26,"id":"28736c81_7cc78527","line":143,"range":{"start_line":143,"start_character":22,"end_line":143,"end_character":55},"in_reply_to":"f1f41873_e4a5daf0","updated":"2022-02-25 12:59:02.000000000","message":"ack, done.","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"}],"manila/api/v2/share_networks.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7070bee6da7029377635079a3693565b9542155","unresolved":true,"context_lines":[{"line_number":635,"context_line":"                    \"the request body.\")"},{"line_number":636,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":637,"context_line":"        data \u003d body[\u0027share_network_subnet_create_check\u0027]"},{"line_number":638,"context_line":"        multiple_subnet_support \u003d (req.api_version_request \u003e\u003d"},{"line_number":639,"context_line":"                                   api_version.APIVersionRequest(\"2.70\"))"},{"line_number":640,"context_line":"        share_network, subnets \u003d common.validate_subnet_create("},{"line_number":641,"context_line":"            context, id, data, multiple_subnet_support)"},{"line_number":642,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"0930f198_af4f0309","line":639,"range":{"start_line":638,"start_character":8,"end_line":639,"end_character":73},"updated":"2022-02-25 08:02:44.000000000","message":"This is redundant - line 627 performs this check","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":635,"context_line":"                    \"the request body.\")"},{"line_number":636,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":637,"context_line":"        data \u003d body[\u0027share_network_subnet_create_check\u0027]"},{"line_number":638,"context_line":"        multiple_subnet_support \u003d (req.api_version_request \u003e\u003d"},{"line_number":639,"context_line":"                                   api_version.APIVersionRequest(\"2.70\"))"},{"line_number":640,"context_line":"        share_network, subnets \u003d common.validate_subnet_create("},{"line_number":641,"context_line":"            context, id, data, multiple_subnet_support)"},{"line_number":642,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1415e461_d521c59b","line":639,"range":{"start_line":638,"start_character":8,"end_line":639,"end_character":73},"in_reply_to":"06e3202b_da089fb3","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"85c9a69f8bd08da6adbbbdc5727523aa41710991","unresolved":true,"context_lines":[{"line_number":635,"context_line":"                    \"the request body.\")"},{"line_number":636,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":637,"context_line":"        data \u003d body[\u0027share_network_subnet_create_check\u0027]"},{"line_number":638,"context_line":"        multiple_subnet_support \u003d (req.api_version_request \u003e\u003d"},{"line_number":639,"context_line":"                                   api_version.APIVersionRequest(\"2.70\"))"},{"line_number":640,"context_line":"        share_network, subnets \u003d common.validate_subnet_create("},{"line_number":641,"context_line":"            context, id, data, multiple_subnet_support)"},{"line_number":642,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"06e3202b_da089fb3","line":639,"range":{"start_line":638,"start_character":8,"end_line":639,"end_character":73},"in_reply_to":"0930f198_af4f0309","updated":"2022-02-25 12:59:02.000000000","message":"true, fixed.","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7070bee6da7029377635079a3693565b9542155","unresolved":true,"context_lines":[{"line_number":659,"context_line":"                    check_update_share_server_network_allocations("},{"line_number":660,"context_line":"                        context, share_network, data, reset_check))"},{"line_number":661,"context_line":"            except exception.ServiceIsDown as e:"},{"line_number":662,"context_line":"                raise exc.HTTPConflict(explanation\u003de.msg)"},{"line_number":663,"context_line":"            except exception.InvalidShareNetwork as e:"},{"line_number":664,"context_line":"                raise exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":665,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":26,"id":"d413ba67_43cfca39","line":662,"range":{"start_line":662,"start_character":26,"end_line":662,"end_character":38},"updated":"2022-02-25 08:02:44.000000000","message":"HTTPConflict is a retryable client error code - the server is incapable of processing this request due to a fault... so this needs to be HTTP500/Internal Server Error.\n\nand we don\u0027t need to share information regarding internal microservices of manila to possibly non-privileged users.. \n\n\nPerhaps replace with a message like:\n\"A share network subnet update check cannot be performed at this time\"\n\nand log the \"ServiceIsDown\" exception","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":659,"context_line":"                    check_update_share_server_network_allocations("},{"line_number":660,"context_line":"                        context, share_network, data, reset_check))"},{"line_number":661,"context_line":"            except exception.ServiceIsDown as e:"},{"line_number":662,"context_line":"                raise exc.HTTPConflict(explanation\u003de.msg)"},{"line_number":663,"context_line":"            except exception.InvalidShareNetwork as e:"},{"line_number":664,"context_line":"                raise exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":665,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":26,"id":"6e54104e_8760b824","line":662,"range":{"start_line":662,"start_character":26,"end_line":662,"end_character":38},"in_reply_to":"aa7ef687_8d89a3bf","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"85c9a69f8bd08da6adbbbdc5727523aa41710991","unresolved":true,"context_lines":[{"line_number":659,"context_line":"                    check_update_share_server_network_allocations("},{"line_number":660,"context_line":"                        context, share_network, data, reset_check))"},{"line_number":661,"context_line":"            except exception.ServiceIsDown as e:"},{"line_number":662,"context_line":"                raise exc.HTTPConflict(explanation\u003de.msg)"},{"line_number":663,"context_line":"            except exception.InvalidShareNetwork as e:"},{"line_number":664,"context_line":"                raise exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":665,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":26,"id":"aa7ef687_8d89a3bf","line":662,"range":{"start_line":662,"start_character":26,"end_line":662,"end_character":38},"in_reply_to":"d413ba67_43cfca39","updated":"2022-02-25 12:59:02.000000000","message":"Thanks, fixed.","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"49b12e2cd343c614e18a0b2821e2555eec6c810c","unresolved":true,"context_lines":[{"line_number":627,"context_line":"    @wsgi.Controller.api_version(\u00272.70\u0027)"},{"line_number":628,"context_line":"    @wsgi.action(\u0027share_network_subnet_create_check\u0027)"},{"line_number":629,"context_line":"    @wsgi.response(202)"},{"line_number":630,"context_line":"    def share_network_subnet_create_check(self, req, id, body):"},{"line_number":631,"context_line":"        \"\"\"Check the feasibility of creating a share network subnet.\"\"\""},{"line_number":632,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":633,"context_line":"        if not self.is_valid_body(body, \u0027share_network_subnet_create_check\u0027):"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a493539_cbc62790","line":630,"range":{"start_line":630,"start_character":0,"end_line":630,"end_character":63},"updated":"2022-02-25 18:28:09.000000000","message":"Why did you decide to add subnet_create_check here and not on subnets api? create subnet lives in [1].\n\n[1] https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/share_network_subnets.py","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1a805e64926f6b71caa7769f60fb890ce34f1172","unresolved":true,"context_lines":[{"line_number":627,"context_line":"    @wsgi.Controller.api_version(\u00272.70\u0027)"},{"line_number":628,"context_line":"    @wsgi.action(\u0027share_network_subnet_create_check\u0027)"},{"line_number":629,"context_line":"    @wsgi.response(202)"},{"line_number":630,"context_line":"    def share_network_subnet_create_check(self, req, id, body):"},{"line_number":631,"context_line":"        \"\"\"Check the feasibility of creating a share network subnet.\"\"\""},{"line_number":632,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":633,"context_line":"        if not self.is_valid_body(body, \u0027share_network_subnet_create_check\u0027):"}],"source_content_type":"text/x-python","patch_set":27,"id":"44a90237_9cdc77bc","line":630,"range":{"start_line":630,"start_character":0,"end_line":630,"end_character":63},"in_reply_to":"074a5852_bd5a56ed","updated":"2022-02-25 20:18:23.000000000","message":"yeah I agree with the reasoning regarding /actions being on a specific resource.. an alternative here would be to not have this be an /action at all, and give it its own endpoint - but that\u0027s not any better in terms of the user experience..","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20f29ca61f56034034aaa2999a81f6730ca167c1","unresolved":true,"context_lines":[{"line_number":627,"context_line":"    @wsgi.Controller.api_version(\u00272.70\u0027)"},{"line_number":628,"context_line":"    @wsgi.action(\u0027share_network_subnet_create_check\u0027)"},{"line_number":629,"context_line":"    @wsgi.response(202)"},{"line_number":630,"context_line":"    def share_network_subnet_create_check(self, req, id, body):"},{"line_number":631,"context_line":"        \"\"\"Check the feasibility of creating a share network subnet.\"\"\""},{"line_number":632,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":633,"context_line":"        if not self.is_valid_body(body, \u0027share_network_subnet_create_check\u0027):"}],"source_content_type":"text/x-python","patch_set":27,"id":"7f19a0b3_353157d0","line":630,"range":{"start_line":630,"start_character":0,"end_line":630,"end_character":63},"in_reply_to":"0dd80d14_3211ae96","updated":"2022-02-25 20:32:39.000000000","message":"Particularly, that\u0027s the first time I see a operation to check if we can create a resource in Manila. So, let keep as it is.","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"f3f0ec49e934838dbe31fd1e64874c0e08a59a5a","unresolved":true,"context_lines":[{"line_number":627,"context_line":"    @wsgi.Controller.api_version(\u00272.70\u0027)"},{"line_number":628,"context_line":"    @wsgi.action(\u0027share_network_subnet_create_check\u0027)"},{"line_number":629,"context_line":"    @wsgi.response(202)"},{"line_number":630,"context_line":"    def share_network_subnet_create_check(self, req, id, body):"},{"line_number":631,"context_line":"        \"\"\"Check the feasibility of creating a share network subnet.\"\"\""},{"line_number":632,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":633,"context_line":"        if not self.is_valid_body(body, \u0027share_network_subnet_create_check\u0027):"}],"source_content_type":"text/x-python","patch_set":27,"id":"4a8b1cba_b871ce6e","line":630,"range":{"start_line":630,"start_character":0,"end_line":630,"end_character":63},"in_reply_to":"1a493539_cbc62790","updated":"2022-02-25 19:42:03.000000000","message":"Hi Douglas, we realize that operation is an action from share network and not from share network subnet, since we don\u0027t use a subnet id in the command for example. So, we choose to add the command as a new action of the share network since we are using only the share network id as required parameter and the subnet parameters as optional. What do you think? I understand that to have a have in the subnets API will be necessary a subnet id for example, but it isn\u0027t the case.","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"44258c7bd519058db1ee81f6b38ad84f93049510","unresolved":true,"context_lines":[{"line_number":627,"context_line":"    @wsgi.Controller.api_version(\u00272.70\u0027)"},{"line_number":628,"context_line":"    @wsgi.action(\u0027share_network_subnet_create_check\u0027)"},{"line_number":629,"context_line":"    @wsgi.response(202)"},{"line_number":630,"context_line":"    def share_network_subnet_create_check(self, req, id, body):"},{"line_number":631,"context_line":"        \"\"\"Check the feasibility of creating a share network subnet.\"\"\""},{"line_number":632,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":633,"context_line":"        if not self.is_valid_body(body, \u0027share_network_subnet_create_check\u0027):"}],"source_content_type":"text/x-python","patch_set":27,"id":"0dd80d14_3211ae96","line":630,"range":{"start_line":630,"start_character":0,"end_line":630,"end_character":63},"in_reply_to":"44a90237_9cdc77bc","updated":"2022-02-25 20:28:39.000000000","message":"Yeah, the alternative doesn\u0027t sound too pretty. All in all, I think it\u0027s okay to keep as is","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"39e609776ce5356ee37d5b41554adfdd9d1ab222","unresolved":true,"context_lines":[{"line_number":627,"context_line":"    @wsgi.Controller.api_version(\u00272.70\u0027)"},{"line_number":628,"context_line":"    @wsgi.action(\u0027share_network_subnet_create_check\u0027)"},{"line_number":629,"context_line":"    @wsgi.response(202)"},{"line_number":630,"context_line":"    def share_network_subnet_create_check(self, req, id, body):"},{"line_number":631,"context_line":"        \"\"\"Check the feasibility of creating a share network subnet.\"\"\""},{"line_number":632,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":633,"context_line":"        if not self.is_valid_body(body, \u0027share_network_subnet_create_check\u0027):"}],"source_content_type":"text/x-python","patch_set":27,"id":"074a5852_bd5a56ed","line":630,"range":{"start_line":630,"start_character":0,"end_line":630,"end_character":63},"in_reply_to":"4a8b1cba_b871ce6e","updated":"2022-02-25 20:12:21.000000000","message":"The endpoint for the subnet check is now:\n\nshare_networsk/{share_network_id}/action \u003c-- action over the share net \"share_network_id\": check_create_subnet. \n\n\nWe haven\u0027t seen the actions without its id:\n\nshare_network/id/subnets/action \u003c--- action over the subnets without any {subnet_id}","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":627,"context_line":"    @wsgi.Controller.api_version(\u00272.70\u0027)"},{"line_number":628,"context_line":"    @wsgi.action(\u0027share_network_subnet_create_check\u0027)"},{"line_number":629,"context_line":"    @wsgi.response(202)"},{"line_number":630,"context_line":"    def share_network_subnet_create_check(self, req, id, body):"},{"line_number":631,"context_line":"        \"\"\"Check the feasibility of creating a share network subnet.\"\"\""},{"line_number":632,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":633,"context_line":"        if not self.is_valid_body(body, \u0027share_network_subnet_create_check\u0027):"}],"source_content_type":"text/x-python","patch_set":27,"id":"7ae279dd_677719c9","line":630,"range":{"start_line":630,"start_character":0,"end_line":630,"end_character":63},"in_reply_to":"7f19a0b3_353157d0","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f14ede0d5f82a6858cb2dcff93b23df2759d93ab","unresolved":true,"context_lines":[{"line_number":644,"context_line":"        # that an allocation update is requested."},{"line_number":645,"context_line":"        if existing_subnets and existing_subnets[0][\u0027share_servers\u0027]:"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"            # NOTE(felipe_rodrigues): all subnets have the same set of share"},{"line_number":648,"context_line":"            # servers, so we can just get the servers from one of them. Not"},{"line_number":649,"context_line":"            # necessarily all share servers from the specified AZ will be"},{"line_number":650,"context_line":"            # updated, only the ones created with subnets in the AZ. Others"}],"source_content_type":"text/x-python","patch_set":29,"id":"299cfa5b_c1304cf0","line":647,"range":{"start_line":647,"start_character":49,"end_line":647,"end_character":51},"updated":"2022-03-02 20:16:33.000000000","message":"nit:\nall subnets within the same az","commit_id":"cf31d4b1fb60976acf0d26fdd628911f0b032196"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"cd4a893494bf8d8e2ad4a028cfbcdef89f0d9158","unresolved":false,"context_lines":[{"line_number":644,"context_line":"        # that an allocation update is requested."},{"line_number":645,"context_line":"        if existing_subnets and existing_subnets[0][\u0027share_servers\u0027]:"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"            # NOTE(felipe_rodrigues): all subnets have the same set of share"},{"line_number":648,"context_line":"            # servers, so we can just get the servers from one of them. Not"},{"line_number":649,"context_line":"            # necessarily all share servers from the specified AZ will be"},{"line_number":650,"context_line":"            # updated, only the ones created with subnets in the AZ. Others"}],"source_content_type":"text/x-python","patch_set":29,"id":"77bbfe2b_2dc62df1","line":647,"range":{"start_line":647,"start_character":49,"end_line":647,"end_character":51},"in_reply_to":"299cfa5b_c1304cf0","updated":"2022-03-03 03:31:27.000000000","message":"Done.","commit_id":"cf31d4b1fb60976acf0d26fdd628911f0b032196"}],"manila/api/v2/share_servers.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c930331689ac5ea6e79fd9c75a7a4bd266351a9","unresolved":true,"context_lines":[{"line_number":183,"context_line":"                    \"with API version \u003e\u003d 2.51.\") % share_network_id"},{"line_number":184,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        if len(network_subnets) \u003e 1:"},{"line_number":187,"context_line":"            msg \u003d _(\"Cannot manage the share server, since the share network \""},{"line_number":188,"context_line":"                    \"subnet %s has more subnets in its availability \""},{"line_number":189,"context_line":"                    \"zone and share network.\") % network_subnet_id"},{"line_number":190,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        network_subnet \u003d network_subnets[0]"},{"line_number":193,"context_line":"        common.check_share_network_is_active(network_subnet[\u0027share_network\u0027])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if share_utils.extract_host(host, \u0027pool\u0027):"}],"source_content_type":"text/x-python","patch_set":21,"id":"565bb668_22b87a32","line":192,"range":{"start_line":186,"start_character":8,"end_line":192,"end_character":43},"updated":"2022-02-14 17:48:20.000000000","message":"As we discussed, we should have a way to prevent users from unmanaging share servers with allocations from multiple subnets as well -- we can straight out prevent it, or add a \"force\" field that will ensure that they know the action is deliberate and they can\u0027t manage a server back with all of its network allocations..","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ae76728fb2eb8915f0b492aabaa100c4165469c","unresolved":true,"context_lines":[{"line_number":183,"context_line":"                    \"with API version \u003e\u003d 2.51.\") % share_network_id"},{"line_number":184,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        if len(network_subnets) \u003e 1:"},{"line_number":187,"context_line":"            msg \u003d _(\"Cannot manage the share server, since the share network \""},{"line_number":188,"context_line":"                    \"subnet %s has more subnets in its availability \""},{"line_number":189,"context_line":"                    \"zone and share network.\") % network_subnet_id"},{"line_number":190,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        network_subnet \u003d network_subnets[0]"},{"line_number":193,"context_line":"        common.check_share_network_is_active(network_subnet[\u0027share_network\u0027])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if share_utils.extract_host(host, \u0027pool\u0027):"}],"source_content_type":"text/x-python","patch_set":21,"id":"20e5ef0a_87e90b7c","line":192,"range":{"start_line":186,"start_character":8,"end_line":192,"end_character":43},"in_reply_to":"565bb668_22b87a32","updated":"2022-02-23 18:17:15.000000000","message":"+1","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":183,"context_line":"                    \"with API version \u003e\u003d 2.51.\") % share_network_id"},{"line_number":184,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        if len(network_subnets) \u003e 1:"},{"line_number":187,"context_line":"            msg \u003d _(\"Cannot manage the share server, since the share network \""},{"line_number":188,"context_line":"                    \"subnet %s has more subnets in its availability \""},{"line_number":189,"context_line":"                    \"zone and share network.\") % network_subnet_id"},{"line_number":190,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        network_subnet \u003d network_subnets[0]"},{"line_number":193,"context_line":"        common.check_share_network_is_active(network_subnet[\u0027share_network\u0027])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if share_utils.extract_host(host, \u0027pool\u0027):"}],"source_content_type":"text/x-python","patch_set":21,"id":"6e063b32_22fb44f3","line":192,"range":{"start_line":186,"start_character":8,"end_line":192,"end_character":43},"in_reply_to":"565bb668_22b87a32","updated":"2022-02-24 21:10:41.000000000","message":"Fixed to block unmanage share server operation with share server containing multiple subnets. The \"force\" idea is nice, we can work on it in a near future, though.\n\nSee next patch.","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                    \"with API version \u003e\u003d 2.51.\") % share_network_id"},{"line_number":184,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        if len(network_subnets) \u003e 1:"},{"line_number":187,"context_line":"            msg \u003d _(\"Cannot manage the share server, since the share network \""},{"line_number":188,"context_line":"                    \"subnet %s has more subnets in its availability \""},{"line_number":189,"context_line":"                    \"zone and share network.\") % network_subnet_id"},{"line_number":190,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        network_subnet \u003d network_subnets[0]"},{"line_number":193,"context_line":"        common.check_share_network_is_active(network_subnet[\u0027share_network\u0027])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if share_utils.extract_host(host, \u0027pool\u0027):"}],"source_content_type":"text/x-python","patch_set":21,"id":"55510454_b74e090a","line":192,"range":{"start_line":186,"start_character":8,"end_line":192,"end_character":43},"in_reply_to":"6e063b32_22fb44f3","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"}],"manila/api/views/share_servers.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c930331689ac5ea6e79fd9c75a7a4bd266351a9","unresolved":true,"context_lines":[{"line_number":98,"context_line":"    def add_share_network_subnet_ids_field("},{"line_number":99,"context_line":"            self, context, share_server_dict, share_server):"},{"line_number":100,"context_line":"        share_server_dict[\u0027share_network_subnet_ids\u0027] \u003d sorted("},{"line_number":101,"context_line":"            share_server[\u0027share_network_subnet_ids\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @common.ViewBuilder.versioned_method(\"2.69\")"},{"line_number":104,"context_line":"    def add_network_allocation_update_support_field("},{"line_number":105,"context_line":"            self, context, share_server_dict, share_server):"},{"line_number":106,"context_line":"        share_server_dict[\u0027network_allocation_update_support\u0027] \u003d ("},{"line_number":107,"context_line":"            share_server[\u0027network_allocation_update_support\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"a7ecad31_52c95cda","line":107,"range":{"start_line":101,"start_character":53,"end_line":107,"end_character":62},"updated":"2022-02-14 17:48:20.000000000","message":"Can be combined into same method as above","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    def add_share_network_subnet_ids_field("},{"line_number":99,"context_line":"            self, context, share_server_dict, share_server):"},{"line_number":100,"context_line":"        share_server_dict[\u0027share_network_subnet_ids\u0027] \u003d sorted("},{"line_number":101,"context_line":"            share_server[\u0027share_network_subnet_ids\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @common.ViewBuilder.versioned_method(\"2.69\")"},{"line_number":104,"context_line":"    def add_network_allocation_update_support_field("},{"line_number":105,"context_line":"            self, context, share_server_dict, share_server):"},{"line_number":106,"context_line":"        share_server_dict[\u0027network_allocation_update_support\u0027] \u003d ("},{"line_number":107,"context_line":"            share_server[\u0027network_allocation_update_support\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"59857b66_275189a2","line":107,"range":{"start_line":101,"start_character":53,"end_line":107,"end_character":62},"in_reply_to":"59985db7_7fc96715","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"956c7eb168966ebb4592f18b1be2bed1bcd4ed23","unresolved":true,"context_lines":[{"line_number":98,"context_line":"    def add_share_network_subnet_ids_field("},{"line_number":99,"context_line":"            self, context, share_server_dict, share_server):"},{"line_number":100,"context_line":"        share_server_dict[\u0027share_network_subnet_ids\u0027] \u003d sorted("},{"line_number":101,"context_line":"            share_server[\u0027share_network_subnet_ids\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @common.ViewBuilder.versioned_method(\"2.69\")"},{"line_number":104,"context_line":"    def add_network_allocation_update_support_field("},{"line_number":105,"context_line":"            self, context, share_server_dict, share_server):"},{"line_number":106,"context_line":"        share_server_dict[\u0027network_allocation_update_support\u0027] \u003d ("},{"line_number":107,"context_line":"            share_server[\u0027network_allocation_update_support\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"e412645a_4aa1d81c","line":107,"range":{"start_line":101,"start_character":53,"end_line":107,"end_character":62},"in_reply_to":"a7ecad31_52c95cda","updated":"2022-02-22 23:49:10.000000000","message":"++","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":98,"context_line":"    def add_share_network_subnet_ids_field("},{"line_number":99,"context_line":"            self, context, share_server_dict, share_server):"},{"line_number":100,"context_line":"        share_server_dict[\u0027share_network_subnet_ids\u0027] \u003d sorted("},{"line_number":101,"context_line":"            share_server[\u0027share_network_subnet_ids\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @common.ViewBuilder.versioned_method(\"2.69\")"},{"line_number":104,"context_line":"    def add_network_allocation_update_support_field("},{"line_number":105,"context_line":"            self, context, share_server_dict, share_server):"},{"line_number":106,"context_line":"        share_server_dict[\u0027network_allocation_update_support\u0027] \u003d ("},{"line_number":107,"context_line":"            share_server[\u0027network_allocation_update_support\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"59985db7_7fc96715","line":107,"range":{"start_line":101,"start_character":53,"end_line":107,"end_character":62},"in_reply_to":"e412645a_4aa1d81c","updated":"2022-02-24 21:10:41.000000000","message":"Done, see next patch.","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"}],"manila/db/api.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ae76728fb2eb8915f0b492aabaa100c4165469c","unresolved":true,"context_lines":[{"line_number":957,"context_line":"                                         session\u003dsession)"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"def share_network_az_subnets_get(context, network_subnet_id, session\u003dNone):"},{"line_number":961,"context_line":"    \"\"\"Get requested az share network subnets DB record.\"\"\""},{"line_number":962,"context_line":"    return IMPL.share_network_az_subnets_get(context, network_subnet_id,"},{"line_number":963,"context_line":"                                             session\u003dsession)"}],"source_content_type":"text/x-python","patch_set":24,"id":"80aab802_7543e750","line":960,"range":{"start_line":960,"start_character":4,"end_line":960,"end_character":32},"updated":"2022-02-23 18:17:15.000000000","message":"this name is confusing for me, can we rename it?\n\nEDIT: looking into the code, it should be something like:\nshare_network_subnet_get_all_with_same_az()","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":957,"context_line":"                                         session\u003dsession)"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"def share_network_az_subnets_get(context, network_subnet_id, session\u003dNone):"},{"line_number":961,"context_line":"    \"\"\"Get requested az share network subnets DB record.\"\"\""},{"line_number":962,"context_line":"    return IMPL.share_network_az_subnets_get(context, network_subnet_id,"},{"line_number":963,"context_line":"                                             session\u003dsession)"}],"source_content_type":"text/x-python","patch_set":24,"id":"b08b0464_fbc81d40","line":960,"range":{"start_line":960,"start_character":4,"end_line":960,"end_character":32},"in_reply_to":"4a1a7e46_5e23962e","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":957,"context_line":"                                         session\u003dsession)"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"def share_network_az_subnets_get(context, network_subnet_id, session\u003dNone):"},{"line_number":961,"context_line":"    \"\"\"Get requested az share network subnets DB record.\"\"\""},{"line_number":962,"context_line":"    return IMPL.share_network_az_subnets_get(context, network_subnet_id,"},{"line_number":963,"context_line":"                                             session\u003dsession)"}],"source_content_type":"text/x-python","patch_set":24,"id":"4a1a7e46_5e23962e","line":960,"range":{"start_line":960,"start_character":4,"end_line":960,"end_character":32},"in_reply_to":"80aab802_7543e750","updated":"2022-02-24 21:10:41.000000000","message":"makes sense. done. see next patch.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ae76728fb2eb8915f0b492aabaa100c4165469c","unresolved":true,"context_lines":[{"line_number":968,"context_line":"    return IMPL.share_network_subnet_get_all(context)"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"def share_network_subnet_get_by_availability_zone_id(context, share_network_id,"},{"line_number":972,"context_line":"                                                     availability_zone_id,"},{"line_number":973,"context_line":"                                                     fallback_default\u003dTrue):"},{"line_number":974,"context_line":"    \"\"\"Get a share network subnet DB record."}],"source_content_type":"text/x-python","patch_set":24,"id":"bf00ad15_babb51ea","line":971,"range":{"start_line":971,"start_character":17,"end_line":971,"end_character":33},"updated":"2022-02-23 18:17:15.000000000","message":"since now return a list of elems, should be:\n*subnet_get_all_by*\nor\n*subnets_get_by*\n\nwdyt?","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":968,"context_line":"    return IMPL.share_network_subnet_get_all(context)"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"def share_network_subnet_get_by_availability_zone_id(context, share_network_id,"},{"line_number":972,"context_line":"                                                     availability_zone_id,"},{"line_number":973,"context_line":"                                                     fallback_default\u003dTrue):"},{"line_number":974,"context_line":"    \"\"\"Get a share network subnet DB record."}],"source_content_type":"text/x-python","patch_set":24,"id":"a0e59785_4b4a3bab","line":971,"range":{"start_line":971,"start_character":17,"end_line":971,"end_character":33},"in_reply_to":"2450dcc0_6f9b01d2","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":968,"context_line":"    return IMPL.share_network_subnet_get_all(context)"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"def share_network_subnet_get_by_availability_zone_id(context, share_network_id,"},{"line_number":972,"context_line":"                                                     availability_zone_id,"},{"line_number":973,"context_line":"                                                     fallback_default\u003dTrue):"},{"line_number":974,"context_line":"    \"\"\"Get a share network subnet DB record."}],"source_content_type":"text/x-python","patch_set":24,"id":"2450dcc0_6f9b01d2","line":971,"range":{"start_line":971,"start_character":17,"end_line":971,"end_character":33},"in_reply_to":"bf00ad15_babb51ea","updated":"2022-02-24 21:10:41.000000000","message":"Makes sense. done. see next patch.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ae76728fb2eb8915f0b492aabaa100c4165469c","unresolved":true,"context_lines":[{"line_number":985,"context_line":"        fallback_default\u003dfallback_default)"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"def share_network_subnet_get_default_subnet(context, share_network_id):"},{"line_number":989,"context_line":"    \"\"\"Get the default share network subnet DB record.\"\"\""},{"line_number":990,"context_line":"    return IMPL.share_network_subnet_get_default_subnet(context,"},{"line_number":991,"context_line":"                                                        share_network_id)"}],"source_content_type":"text/x-python","patch_set":24,"id":"530e236c_09f55f65","line":988,"range":{"start_line":988,"start_character":3,"end_line":988,"end_character":44},"updated":"2022-02-23 18:17:15.000000000","message":"*get_all_default*\nor\n*get_default_subnets*","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":985,"context_line":"        fallback_default\u003dfallback_default)"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"def share_network_subnet_get_default_subnet(context, share_network_id):"},{"line_number":989,"context_line":"    \"\"\"Get the default share network subnet DB record.\"\"\""},{"line_number":990,"context_line":"    return IMPL.share_network_subnet_get_default_subnet(context,"},{"line_number":991,"context_line":"                                                        share_network_id)"}],"source_content_type":"text/x-python","patch_set":24,"id":"bc508e74_ac1eedfd","line":988,"range":{"start_line":988,"start_character":3,"end_line":988,"end_character":44},"in_reply_to":"530e236c_09f55f65","updated":"2022-02-24 21:10:41.000000000","message":"Makes sense. done. see next patch.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":985,"context_line":"        fallback_default\u003dfallback_default)"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"def share_network_subnet_get_default_subnet(context, share_network_id):"},{"line_number":989,"context_line":"    \"\"\"Get the default share network subnet DB record.\"\"\""},{"line_number":990,"context_line":"    return IMPL.share_network_subnet_get_default_subnet(context,"},{"line_number":991,"context_line":"                                                        share_network_id)"}],"source_content_type":"text/x-python","patch_set":24,"id":"4a9ff672_0f48be72","line":988,"range":{"start_line":988,"start_character":3,"end_line":988,"end_character":44},"in_reply_to":"bc508e74_ac1eedfd","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ae76728fb2eb8915f0b492aabaa100c4165469c","unresolved":true,"context_lines":[{"line_number":991,"context_line":"                                                        share_network_id)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"def share_network_subnet_get_by_share_server_id(context, share_server_id):"},{"line_number":995,"context_line":"    \"\"\"Get the subnets that are being used by the share server.\"\"\""},{"line_number":996,"context_line":"    return IMPL.share_network_subnet_get_by_share_server_id(context,"},{"line_number":997,"context_line":"                                                            share_server_id)"}],"source_content_type":"text/x-python","patch_set":24,"id":"a9c6f6d9_8a8b6c98","line":994,"range":{"start_line":994,"start_character":18,"end_line":994,"end_character":38},"updated":"2022-02-23 18:17:15.000000000","message":"*get_all_by* ?","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":991,"context_line":"                                                        share_network_id)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"def share_network_subnet_get_by_share_server_id(context, share_server_id):"},{"line_number":995,"context_line":"    \"\"\"Get the subnets that are being used by the share server.\"\"\""},{"line_number":996,"context_line":"    return IMPL.share_network_subnet_get_by_share_server_id(context,"},{"line_number":997,"context_line":"                                                            share_server_id)"}],"source_content_type":"text/x-python","patch_set":24,"id":"c1d2bcec_dd77a385","line":994,"range":{"start_line":994,"start_character":18,"end_line":994,"end_character":38},"in_reply_to":"4f00f0cf_2c683734","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":991,"context_line":"                                                        share_network_id)"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"def share_network_subnet_get_by_share_server_id(context, share_server_id):"},{"line_number":995,"context_line":"    \"\"\"Get the subnets that are being used by the share server.\"\"\""},{"line_number":996,"context_line":"    return IMPL.share_network_subnet_get_by_share_server_id(context,"},{"line_number":997,"context_line":"                                                            share_server_id)"}],"source_content_type":"text/x-python","patch_set":24,"id":"4f00f0cf_2c683734","line":994,"range":{"start_line":994,"start_character":18,"end_line":994,"end_character":38},"in_reply_to":"a9c6f6d9_8a8b6c98","updated":"2022-02-24 21:10:41.000000000","message":"Makes sense. done. see next patch.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"}],"manila/db/migrations/alembic/versions/a87e0fb17dee_multiple_share_server_subnets.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4ee753b4c3c6dbc684af719fb87679b47ac1a5ad","unresolved":true,"context_lines":[{"line_number":49,"context_line":"            sa.Column(\u0027deleted\u0027, sa.Integer, default\u003d0),"},{"line_number":50,"context_line":"            sa.Column("},{"line_number":51,"context_line":"                \u0027share_server_id\u0027, sa.String(length\u003d36),"},{"line_number":52,"context_line":"                sa.ForeignKey(\u0027share_servers.id\u0027, name\u003d\"ssm_id_ss_id_uc\"),"},{"line_number":53,"context_line":"                nullable\u003dFalse),"},{"line_number":54,"context_line":"            sa.Column("},{"line_number":55,"context_line":"                \u0027share_network_subnet_id\u0027, sa.String(length\u003d36),"}],"source_content_type":"text/x-python","patch_set":22,"id":"27de010d_16a9552f","line":52,"range":{"start_line":52,"start_character":56,"end_line":52,"end_character":71},"updated":"2022-02-18 04:56:00.000000000","message":"We do a shoddy job of being consistent with this currently - but alembic and sqlalchemy have a convention that we can use:\n\n\"fk_%(table_name)s_%(column_0_name)s_%(referred_table_name)s\",\n\n\nfk_share_server_share_network_subnet_mappings_share_server_id_share_servers\n\nhttps://docs.sqlalchemy.org/en/14/core/constraints.html#configuring-constraint-naming-conventions","commit_id":"ca1cefcd5013bd6d506bda6bee5ecd271b501bd9"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":49,"context_line":"            sa.Column(\u0027deleted\u0027, sa.Integer, default\u003d0),"},{"line_number":50,"context_line":"            sa.Column("},{"line_number":51,"context_line":"                \u0027share_server_id\u0027, sa.String(length\u003d36),"},{"line_number":52,"context_line":"                sa.ForeignKey(\u0027share_servers.id\u0027, name\u003d\"ssm_id_ss_id_uc\"),"},{"line_number":53,"context_line":"                nullable\u003dFalse),"},{"line_number":54,"context_line":"            sa.Column("},{"line_number":55,"context_line":"                \u0027share_network_subnet_id\u0027, sa.String(length\u003d36),"}],"source_content_type":"text/x-python","patch_set":22,"id":"9e9de339_6fbf617b","line":52,"range":{"start_line":52,"start_character":56,"end_line":52,"end_character":71},"in_reply_to":"27de010d_16a9552f","updated":"2022-02-24 21:10:41.000000000","message":"thanks, done. See next patch.","commit_id":"ca1cefcd5013bd6d506bda6bee5ecd271b501bd9"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"b5a65cb9c8c88eefef8f9751ebab26dced9a57bc","unresolved":true,"context_lines":[{"line_number":49,"context_line":"            sa.Column(\u0027deleted\u0027, sa.Integer, default\u003d0),"},{"line_number":50,"context_line":"            sa.Column("},{"line_number":51,"context_line":"                \u0027share_server_id\u0027, sa.String(length\u003d36),"},{"line_number":52,"context_line":"                sa.ForeignKey(\u0027share_servers.id\u0027, name\u003d\"ssm_id_ss_id_uc\"),"},{"line_number":53,"context_line":"                nullable\u003dFalse),"},{"line_number":54,"context_line":"            sa.Column("},{"line_number":55,"context_line":"                \u0027share_network_subnet_id\u0027, sa.String(length\u003d36),"}],"source_content_type":"text/x-python","patch_set":22,"id":"af9efc89_c60d8c0f","line":52,"range":{"start_line":52,"start_character":56,"end_line":52,"end_character":71},"in_reply_to":"9e9de339_6fbf617b","updated":"2022-02-24 22:04:01.000000000","message":"Actually, the suggested name does not work, since it exceeds the length of the fk name. So, I used \"share_server_share_network_subnet_mappings\" as \"ss_sns_m\".","commit_id":"ca1cefcd5013bd6d506bda6bee5ecd271b501bd9"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            sa.Column(\u0027deleted\u0027, sa.Integer, default\u003d0),"},{"line_number":50,"context_line":"            sa.Column("},{"line_number":51,"context_line":"                \u0027share_server_id\u0027, sa.String(length\u003d36),"},{"line_number":52,"context_line":"                sa.ForeignKey(\u0027share_servers.id\u0027, name\u003d\"ssm_id_ss_id_uc\"),"},{"line_number":53,"context_line":"                nullable\u003dFalse),"},{"line_number":54,"context_line":"            sa.Column("},{"line_number":55,"context_line":"                \u0027share_network_subnet_id\u0027, sa.String(length\u003d36),"}],"source_content_type":"text/x-python","patch_set":22,"id":"ad55812c_4d98df29","line":52,"range":{"start_line":52,"start_character":56,"end_line":52,"end_character":71},"in_reply_to":"af9efc89_c60d8c0f","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"ca1cefcd5013bd6d506bda6bee5ecd271b501bd9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4ee753b4c3c6dbc684af719fb87679b47ac1a5ad","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            sa.Column("},{"line_number":55,"context_line":"                \u0027share_network_subnet_id\u0027, sa.String(length\u003d36),"},{"line_number":56,"context_line":"                sa.ForeignKey(\u0027share_network_subnets.id\u0027,"},{"line_number":57,"context_line":"                              name\u003d\"ssm_id_sns_id_uc\"),"},{"line_number":58,"context_line":"                nullable\u003dFalse),"},{"line_number":59,"context_line":"            mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":60,"context_line":"            mysql_charset\u003d\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"fd842205_baca2f9f","line":57,"range":{"start_line":57,"start_character":36,"end_line":57,"end_character":52},"updated":"2022-02-18 04:56:00.000000000","message":"same comment as above","commit_id":"ca1cefcd5013bd6d506bda6bee5ecd271b501bd9"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            sa.Column("},{"line_number":55,"context_line":"                \u0027share_network_subnet_id\u0027, sa.String(length\u003d36),"},{"line_number":56,"context_line":"                sa.ForeignKey(\u0027share_network_subnets.id\u0027,"},{"line_number":57,"context_line":"                              name\u003d\"ssm_id_sns_id_uc\"),"},{"line_number":58,"context_line":"                nullable\u003dFalse),"},{"line_number":59,"context_line":"            mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":60,"context_line":"            mysql_charset\u003d\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"b2e4de1f_844a5f56","line":57,"range":{"start_line":57,"start_character":36,"end_line":57,"end_character":52},"in_reply_to":"9b5b7d70_185f94e7","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"ca1cefcd5013bd6d506bda6bee5ecd271b501bd9"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            sa.Column("},{"line_number":55,"context_line":"                \u0027share_network_subnet_id\u0027, sa.String(length\u003d36),"},{"line_number":56,"context_line":"                sa.ForeignKey(\u0027share_network_subnets.id\u0027,"},{"line_number":57,"context_line":"                              name\u003d\"ssm_id_sns_id_uc\"),"},{"line_number":58,"context_line":"                nullable\u003dFalse),"},{"line_number":59,"context_line":"            mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":60,"context_line":"            mysql_charset\u003d\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9b5b7d70_185f94e7","line":57,"range":{"start_line":57,"start_character":36,"end_line":57,"end_character":52},"in_reply_to":"fd842205_baca2f9f","updated":"2022-02-24 21:10:41.000000000","message":"thanks, done. See next patch (25).","commit_id":"ca1cefcd5013bd6d506bda6bee5ecd271b501bd9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ae76728fb2eb8915f0b492aabaa100c4165469c","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        server_subnet_mappings_table \u003d op.create_table("},{"line_number":44,"context_line":"            SHARE_SERVER_SUBNET_MAP_TABLE,"},{"line_number":45,"context_line":"            sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":46,"context_line":"            sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":47,"context_line":"            sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":48,"context_line":"            sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":49,"context_line":"            sa.Column(\u0027deleted\u0027, sa.Integer, default\u003d0),"}],"source_content_type":"text/x-python","patch_set":24,"id":"32dc6809_b5ccf7f3","line":46,"range":{"start_line":46,"start_character":36,"end_line":46,"end_character":47},"updated":"2022-02-23 18:17:15.000000000","message":"sa.dialects.mysql.DATETIME(fsp\u003d6) if mysql_dl else sa.DateTime\n\nsee https://github.com/openstack/manila/blob/7c04fcb9047ab9ec854d8b8be69573ad2b55db75/manila/db/migrations/alembic/versions/478c445d8d3e_add_security_service_update_control_fields.py#L37-L46","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        server_subnet_mappings_table \u003d op.create_table("},{"line_number":44,"context_line":"            SHARE_SERVER_SUBNET_MAP_TABLE,"},{"line_number":45,"context_line":"            sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":46,"context_line":"            sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":47,"context_line":"            sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":48,"context_line":"            sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":49,"context_line":"            sa.Column(\u0027deleted\u0027, sa.Integer, default\u003d0),"}],"source_content_type":"text/x-python","patch_set":24,"id":"cd4bad31_50c8a79d","line":46,"range":{"start_line":46,"start_character":36,"end_line":46,"end_character":47},"in_reply_to":"0a95e41b_2b75a2fe","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        server_subnet_mappings_table \u003d op.create_table("},{"line_number":44,"context_line":"            SHARE_SERVER_SUBNET_MAP_TABLE,"},{"line_number":45,"context_line":"            sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":46,"context_line":"            sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":47,"context_line":"            sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":48,"context_line":"            sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":49,"context_line":"            sa.Column(\u0027deleted\u0027, sa.Integer, default\u003d0),"}],"source_content_type":"text/x-python","patch_set":24,"id":"bb8178e0_8c7e6712","line":46,"range":{"start_line":46,"start_character":36,"end_line":46,"end_character":47},"in_reply_to":"32dc6809_b5ccf7f3","updated":"2022-02-24 21:10:41.000000000","message":"nice catch. Thanks. See next patch .","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"85c9a69f8bd08da6adbbbdc5727523aa41710991","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        server_subnet_mappings_table \u003d op.create_table("},{"line_number":44,"context_line":"            SHARE_SERVER_SUBNET_MAP_TABLE,"},{"line_number":45,"context_line":"            sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":46,"context_line":"            sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":47,"context_line":"            sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":48,"context_line":"            sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":49,"context_line":"            sa.Column(\u0027deleted\u0027, sa.Integer, default\u003d0),"}],"source_content_type":"text/x-python","patch_set":24,"id":"0a95e41b_2b75a2fe","line":46,"range":{"start_line":46,"start_character":36,"end_line":46,"end_character":47},"in_reply_to":"908c42ac_eade029f","updated":"2022-02-25 12:59:02.000000000","message":"done. see patch 26.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7070bee6da7029377635079a3693565b9542155","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        server_subnet_mappings_table \u003d op.create_table("},{"line_number":44,"context_line":"            SHARE_SERVER_SUBNET_MAP_TABLE,"},{"line_number":45,"context_line":"            sa.Column(\u0027id\u0027, sa.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":46,"context_line":"            sa.Column(\u0027created_at\u0027, sa.DateTime),"},{"line_number":47,"context_line":"            sa.Column(\u0027updated_at\u0027, sa.DateTime),"},{"line_number":48,"context_line":"            sa.Column(\u0027deleted_at\u0027, sa.DateTime),"},{"line_number":49,"context_line":"            sa.Column(\u0027deleted\u0027, sa.Integer, default\u003d0),"}],"source_content_type":"text/x-python","patch_set":24,"id":"908c42ac_eade029f","line":46,"range":{"start_line":46,"start_character":36,"end_line":46,"end_character":47},"in_reply_to":"bb8178e0_8c7e6712","updated":"2022-02-25 08:02:44.000000000","message":"++","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ae76728fb2eb8915f0b492aabaa100c4165469c","unresolved":true,"context_lines":[{"line_number":74,"context_line":"                    \u0027created_at\u0027: server.created_at,"},{"line_number":75,"context_line":"                    \u0027updated_at\u0027: server.updated_at,"},{"line_number":76,"context_line":"                    \u0027deleted_at\u0027: server.deleted_at,"},{"line_number":77,"context_line":"                    \u0027deleted\u0027: 0 if server.deleted \u003d\u003d \u0027False\u0027 else 1,"},{"line_number":78,"context_line":"                    \u0027share_server_id\u0027: server.id,"},{"line_number":79,"context_line":"                    \u0027share_network_subnet_id\u0027: server.share_network_subnet_id,"},{"line_number":80,"context_line":"                })"}],"source_content_type":"text/x-python","patch_set":24,"id":"0d048ce3_34bda588","line":77,"range":{"start_line":77,"start_character":21,"end_line":77,"end_character":69},"updated":"2022-02-23 18:17:15.000000000","message":"hum, why not \"\u0027deleted\u0027: server.deleted\"?\n\nEDIT: ah, i see, server.deleted will have the server-id which does not make sense to be here, since it expected to have server-subnet-mapping id when deleted.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":74,"context_line":"                    \u0027created_at\u0027: server.created_at,"},{"line_number":75,"context_line":"                    \u0027updated_at\u0027: server.updated_at,"},{"line_number":76,"context_line":"                    \u0027deleted_at\u0027: server.deleted_at,"},{"line_number":77,"context_line":"                    \u0027deleted\u0027: 0 if server.deleted \u003d\u003d \u0027False\u0027 else 1,"},{"line_number":78,"context_line":"                    \u0027share_server_id\u0027: server.id,"},{"line_number":79,"context_line":"                    \u0027share_network_subnet_id\u0027: server.share_network_subnet_id,"},{"line_number":80,"context_line":"                })"}],"source_content_type":"text/x-python","patch_set":24,"id":"a558a607_c5e882a9","line":77,"range":{"start_line":77,"start_character":21,"end_line":77,"end_character":69},"in_reply_to":"0d048ce3_34bda588","updated":"2022-02-24 21:10:41.000000000","message":"sorry, I did\u0027t get your point. Could you explain better ?","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3599dd6b3966e60c08177a3724149f850d0dc221","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                    \u0027created_at\u0027: server.created_at,"},{"line_number":75,"context_line":"                    \u0027updated_at\u0027: server.updated_at,"},{"line_number":76,"context_line":"                    \u0027deleted_at\u0027: server.deleted_at,"},{"line_number":77,"context_line":"                    \u0027deleted\u0027: 0 if server.deleted \u003d\u003d \u0027False\u0027 else 1,"},{"line_number":78,"context_line":"                    \u0027share_server_id\u0027: server.id,"},{"line_number":79,"context_line":"                    \u0027share_network_subnet_id\u0027: server.share_network_subnet_id,"},{"line_number":80,"context_line":"                })"}],"source_content_type":"text/x-python","patch_set":24,"id":"c6db3089_c817f6c7","line":77,"range":{"start_line":77,"start_character":21,"end_line":77,"end_character":69},"in_reply_to":"a558a607_c5e882a9","updated":"2022-03-02 20:15:14.000000000","message":"No changes needed here, thanks.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"956c7eb168966ebb4592f18b1be2bed1bcd4ed23","unresolved":true,"context_lines":[{"line_number":95,"context_line":"                                    name\u003dnetwork_allocation_fk_name))"},{"line_number":96,"context_line":"        )"},{"line_number":97,"context_line":"    except Exception:"},{"line_number":98,"context_line":"        LOG.error(\u0027Could not add ForeignKey column \\\u0027share_network_subnet_id\\\u0027\u0027"},{"line_number":99,"context_line":"                  \u0027to table %s.\u0027, NETWORK_ALLOCATIONS_TABLE)"},{"line_number":100,"context_line":"        raise"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"c537f619_9878c952","line":98,"range":{"start_line":98,"start_character":18,"end_line":98,"end_character":19},"updated":"2022-02-22 23:49:10.000000000","message":"nit: if you use \" to open and close the message, you won\u0027t need to escape \u0027share_network_subnet_id\u0027","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":95,"context_line":"                                    name\u003dnetwork_allocation_fk_name))"},{"line_number":96,"context_line":"        )"},{"line_number":97,"context_line":"    except Exception:"},{"line_number":98,"context_line":"        LOG.error(\u0027Could not add ForeignKey column \\\u0027share_network_subnet_id\\\u0027\u0027"},{"line_number":99,"context_line":"                  \u0027to table %s.\u0027, NETWORK_ALLOCATIONS_TABLE)"},{"line_number":100,"context_line":"        raise"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"ff73e849_6088e251","line":98,"range":{"start_line":98,"start_character":18,"end_line":98,"end_character":19},"in_reply_to":"c537f619_9878c952","updated":"2022-02-24 21:10:41.000000000","message":"done, see next patch.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                                    name\u003dnetwork_allocation_fk_name))"},{"line_number":96,"context_line":"        )"},{"line_number":97,"context_line":"    except Exception:"},{"line_number":98,"context_line":"        LOG.error(\u0027Could not add ForeignKey column \\\u0027share_network_subnet_id\\\u0027\u0027"},{"line_number":99,"context_line":"                  \u0027to table %s.\u0027, NETWORK_ALLOCATIONS_TABLE)"},{"line_number":100,"context_line":"        raise"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"17084de6_43cff4c5","line":98,"range":{"start_line":98,"start_character":18,"end_line":98,"end_character":19},"in_reply_to":"ff73e849_6088e251","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"956c7eb168966ebb4592f18b1be2bed1bcd4ed23","unresolved":true,"context_lines":[{"line_number":177,"context_line":"                LOG.warning(\u0027Share server %s is not deleted and it \u0027"},{"line_number":178,"context_line":"                            \u0027has more than one subnet (%s subnets), \u0027"},{"line_number":179,"context_line":"                            \u0027the downgrade may cause an inconsistent \u0027"},{"line_number":180,"context_line":"                            \u0027environment.\u0027, server[\u0027id\u0027], len(subnets))"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"            subnet_id \u003d subnets[0].share_network_subnet_id if subnets else None"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"1c6968ae_f07c2938","line":180,"updated":"2022-02-22 23:49:10.000000000","message":"so a share server that was deployed with two subnets will never stop having more than one subnet until it gets deleted, right?","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":177,"context_line":"                LOG.warning(\u0027Share server %s is not deleted and it \u0027"},{"line_number":178,"context_line":"                            \u0027has more than one subnet (%s subnets), \u0027"},{"line_number":179,"context_line":"                            \u0027the downgrade may cause an inconsistent \u0027"},{"line_number":180,"context_line":"                            \u0027environment.\u0027, server[\u0027id\u0027], len(subnets))"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"            subnet_id \u003d subnets[0].share_network_subnet_id if subnets else None"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"876c77d9_4191c122","line":180,"in_reply_to":"1c6968ae_f07c2938","updated":"2022-02-24 21:10:41.000000000","message":"Right.. we cannot know which single subnet should be kept. Downgrading an env with share server containing multiple subnets is not recommended, though.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cdbcd1f07ad0f2f14fac2ca9c2df998b40402f6d","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                LOG.warning(\u0027Share server %s is not deleted and it \u0027"},{"line_number":178,"context_line":"                            \u0027has more than one subnet (%s subnets), \u0027"},{"line_number":179,"context_line":"                            \u0027the downgrade may cause an inconsistent \u0027"},{"line_number":180,"context_line":"                            \u0027environment.\u0027, server[\u0027id\u0027], len(subnets))"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"            subnet_id \u003d subnets[0].share_network_subnet_id if subnets else None"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"a8a05a43_a3062091","line":180,"in_reply_to":"876c77d9_4191c122","updated":"2022-02-25 19:20:40.000000000","message":"Ack","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7070bee6da7029377635079a3693565b9542155","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        raise"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    try:"},{"line_number":205,"context_line":"        op.drop_table(SHARE_SERVER_SUBNET_MAP_TABLE)"},{"line_number":206,"context_line":"        op.drop_column(SHARE_SERVERS_TABLE,"},{"line_number":207,"context_line":"                       \u0027network_allocation_update_support\u0027)"},{"line_number":208,"context_line":"    except Exception:"},{"line_number":209,"context_line":"        LOG.error(\"Table %s and column \""},{"line_number":210,"context_line":"                  \"\u0027share_servers.network_allocation_update_support\u0027 \""}],"source_content_type":"text/x-python","patch_set":26,"id":"8faf9ea0_db2e09e3","line":207,"range":{"start_line":205,"start_character":7,"end_line":207,"end_character":59},"updated":"2022-02-25 08:02:44.000000000","message":"these are two separate operations on two separate tables - exceptions should be handled separately","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"85c9a69f8bd08da6adbbbdc5727523aa41710991","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        raise"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    try:"},{"line_number":205,"context_line":"        op.drop_table(SHARE_SERVER_SUBNET_MAP_TABLE)"},{"line_number":206,"context_line":"        op.drop_column(SHARE_SERVERS_TABLE,"},{"line_number":207,"context_line":"                       \u0027network_allocation_update_support\u0027)"},{"line_number":208,"context_line":"    except Exception:"},{"line_number":209,"context_line":"        LOG.error(\"Table %s and column \""},{"line_number":210,"context_line":"                  \"\u0027share_servers.network_allocation_update_support\u0027 \""}],"source_content_type":"text/x-python","patch_set":26,"id":"f9ae17e4_e719197b","line":207,"range":{"start_line":205,"start_character":7,"end_line":207,"end_character":59},"in_reply_to":"8faf9ea0_db2e09e3","updated":"2022-02-25 12:59:02.000000000","message":"fixed.","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        raise"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    try:"},{"line_number":205,"context_line":"        op.drop_table(SHARE_SERVER_SUBNET_MAP_TABLE)"},{"line_number":206,"context_line":"        op.drop_column(SHARE_SERVERS_TABLE,"},{"line_number":207,"context_line":"                       \u0027network_allocation_update_support\u0027)"},{"line_number":208,"context_line":"    except Exception:"},{"line_number":209,"context_line":"        LOG.error(\"Table %s and column \""},{"line_number":210,"context_line":"                  \"\u0027share_servers.network_allocation_update_support\u0027 \""}],"source_content_type":"text/x-python","patch_set":26,"id":"02f35d0a_3209cca9","line":207,"range":{"start_line":205,"start_character":7,"end_line":207,"end_character":59},"in_reply_to":"f9ae17e4_e719197b","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":1989,"context_line":""},{"line_number":1990,"context_line":"    share_filter_keys \u003d [\u0027share_group_id\u0027, \u0027snapshot_id\u0027]"},{"line_number":1991,"context_line":"    instance_filter_keys \u003d [\u0027share_server_id\u0027, \u0027status\u0027, \u0027share_type_id\u0027,"},{"line_number":1992,"context_line":"                            \u0027host\u0027, \u0027share_network_id\u0027, \u0027availability_zone_id\u0027]"},{"line_number":1993,"context_line":"    share_filters \u003d {}"},{"line_number":1994,"context_line":"    instance_filters \u003d {}"},{"line_number":1995,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"a930e8fa_cec3afec","line":1992,"range":{"start_line":1992,"start_character":57,"end_line":1992,"end_character":77},"updated":"2022-02-24 21:10:41.000000000","message":"remove it","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7070bee6da7029377635079a3693565b9542155","unresolved":true,"context_lines":[{"line_number":1989,"context_line":""},{"line_number":1990,"context_line":"    share_filter_keys \u003d [\u0027share_group_id\u0027, \u0027snapshot_id\u0027]"},{"line_number":1991,"context_line":"    instance_filter_keys \u003d [\u0027share_server_id\u0027, \u0027status\u0027, \u0027share_type_id\u0027,"},{"line_number":1992,"context_line":"                            \u0027host\u0027, \u0027share_network_id\u0027, \u0027availability_zone_id\u0027]"},{"line_number":1993,"context_line":"    share_filters \u003d {}"},{"line_number":1994,"context_line":"    instance_filters \u003d {}"},{"line_number":1995,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"edc3802e_4463ebcd","line":1992,"range":{"start_line":1992,"start_character":57,"end_line":1992,"end_character":77},"in_reply_to":"a930e8fa_cec3afec","updated":"2022-02-25 08:02:44.000000000","message":"?\n\nis this a different bugfix?","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":1989,"context_line":""},{"line_number":1990,"context_line":"    share_filter_keys \u003d [\u0027share_group_id\u0027, \u0027snapshot_id\u0027]"},{"line_number":1991,"context_line":"    instance_filter_keys \u003d [\u0027share_server_id\u0027, \u0027status\u0027, \u0027share_type_id\u0027,"},{"line_number":1992,"context_line":"                            \u0027host\u0027, \u0027share_network_id\u0027, \u0027availability_zone_id\u0027]"},{"line_number":1993,"context_line":"    share_filters \u003d {}"},{"line_number":1994,"context_line":"    instance_filters \u003d {}"},{"line_number":1995,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"183dd5c7_be2188f1","line":1992,"range":{"start_line":1992,"start_character":57,"end_line":1992,"end_character":77},"in_reply_to":"b4dbb934_d056ba72","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"85c9a69f8bd08da6adbbbdc5727523aa41710991","unresolved":true,"context_lines":[{"line_number":1989,"context_line":""},{"line_number":1990,"context_line":"    share_filter_keys \u003d [\u0027share_group_id\u0027, \u0027snapshot_id\u0027]"},{"line_number":1991,"context_line":"    instance_filter_keys \u003d [\u0027share_server_id\u0027, \u0027status\u0027, \u0027share_type_id\u0027,"},{"line_number":1992,"context_line":"                            \u0027host\u0027, \u0027share_network_id\u0027, \u0027availability_zone_id\u0027]"},{"line_number":1993,"context_line":"    share_filters \u003d {}"},{"line_number":1994,"context_line":"    instance_filters \u003d {}"},{"line_number":1995,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"b4dbb934_d056ba72","line":1992,"range":{"start_line":1992,"start_character":57,"end_line":1992,"end_character":77},"in_reply_to":"edc3802e_4463ebcd","updated":"2022-02-25 12:59:02.000000000","message":"Nope. Something left from the code process. Removed. thanks.","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c930331689ac5ea6e79fd9c75a7a4bd266351a9","unresolved":true,"context_lines":[{"line_number":4189,"context_line":"@require_context"},{"line_number":4190,"context_line":"def share_network_subnet_get_by_availability_zone_id("},{"line_number":4191,"context_line":"        context, share_network_id, availability_zone_id,"},{"line_number":4192,"context_line":"        fallback_default\u003dTrue):"},{"line_number":4193,"context_line":"    result \u003d (_network_subnet_get_query(context).filter_by("},{"line_number":4194,"context_line":"        share_network_id\u003dshare_network_id,"},{"line_number":4195,"context_line":"        availability_zone_id\u003davailability_zone_id).all())"}],"source_content_type":"text/x-python","patch_set":21,"id":"478a14bf_99c18aab","line":4192,"range":{"start_line":4192,"start_character":8,"end_line":4192,"end_character":24},"updated":"2022-02-14 17:48:20.000000000","message":"\"fallback_to_default\" better conveys what you want, could you also add a docstring for this method and explain what this does?","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":4189,"context_line":"@require_context"},{"line_number":4190,"context_line":"def share_network_subnet_get_by_availability_zone_id("},{"line_number":4191,"context_line":"        context, share_network_id, availability_zone_id,"},{"line_number":4192,"context_line":"        fallback_default\u003dTrue):"},{"line_number":4193,"context_line":"    result \u003d (_network_subnet_get_query(context).filter_by("},{"line_number":4194,"context_line":"        share_network_id\u003dshare_network_id,"},{"line_number":4195,"context_line":"        availability_zone_id\u003davailability_zone_id).all())"}],"source_content_type":"text/x-python","patch_set":21,"id":"721914a4_4b08a663","line":4192,"range":{"start_line":4192,"start_character":8,"end_line":4192,"end_character":24},"in_reply_to":"478a14bf_99c18aab","updated":"2022-02-24 21:10:41.000000000","message":"agree. Added the docstring too.\n\nSee next patch.","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":4189,"context_line":"@require_context"},{"line_number":4190,"context_line":"def share_network_subnet_get_by_availability_zone_id("},{"line_number":4191,"context_line":"        context, share_network_id, availability_zone_id,"},{"line_number":4192,"context_line":"        fallback_default\u003dTrue):"},{"line_number":4193,"context_line":"    result \u003d (_network_subnet_get_query(context).filter_by("},{"line_number":4194,"context_line":"        share_network_id\u003dshare_network_id,"},{"line_number":4195,"context_line":"        availability_zone_id\u003davailability_zone_id).all())"}],"source_content_type":"text/x-python","patch_set":21,"id":"b6aea354_e632719e","line":4192,"range":{"start_line":4192,"start_character":8,"end_line":4192,"end_character":24},"in_reply_to":"721914a4_4b08a663","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ae76728fb2eb8915f0b492aabaa100c4165469c","unresolved":true,"context_lines":[{"line_number":4160,"context_line":""},{"line_number":4161,"context_line":"@require_context"},{"line_number":4162,"context_line":"def share_network_az_subnets_get(context, network_subnet_id, session\u003dNone):"},{"line_number":4163,"context_line":"    temp \u003d (_network_subnet_get_query(context, session)"},{"line_number":4164,"context_line":"            .filter_by(id\u003dnetwork_subnet_id).subquery())"},{"line_number":4165,"context_line":"    result \u003d (_network_subnet_get_query(context, session)"},{"line_number":4166,"context_line":"              .join(temp, temp.c.share_network_id \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":24,"id":"e7077937_c8c68b37","line":4163,"range":{"start_line":4163,"start_character":4,"end_line":4163,"end_character":8},"updated":"2022-02-23 18:17:15.000000000","message":"nit: subnet or target_subnet","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":4160,"context_line":""},{"line_number":4161,"context_line":"@require_context"},{"line_number":4162,"context_line":"def share_network_az_subnets_get(context, network_subnet_id, session\u003dNone):"},{"line_number":4163,"context_line":"    temp \u003d (_network_subnet_get_query(context, session)"},{"line_number":4164,"context_line":"            .filter_by(id\u003dnetwork_subnet_id).subquery())"},{"line_number":4165,"context_line":"    result \u003d (_network_subnet_get_query(context, session)"},{"line_number":4166,"context_line":"              .join(temp, temp.c.share_network_id \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":24,"id":"95d608d0_31f2626c","line":4163,"range":{"start_line":4163,"start_character":4,"end_line":4163,"end_character":8},"in_reply_to":"b2b6f6fe_7422fb26","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":4160,"context_line":""},{"line_number":4161,"context_line":"@require_context"},{"line_number":4162,"context_line":"def share_network_az_subnets_get(context, network_subnet_id, session\u003dNone):"},{"line_number":4163,"context_line":"    temp \u003d (_network_subnet_get_query(context, session)"},{"line_number":4164,"context_line":"            .filter_by(id\u003dnetwork_subnet_id).subquery())"},{"line_number":4165,"context_line":"    result \u003d (_network_subnet_get_query(context, session)"},{"line_number":4166,"context_line":"              .join(temp, temp.c.share_network_id \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":24,"id":"b2b6f6fe_7422fb26","line":4163,"range":{"start_line":4163,"start_character":4,"end_line":4163,"end_character":8},"in_reply_to":"e7077937_c8c68b37","updated":"2022-02-24 21:10:41.000000000","message":"ack, done. see next patch.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ae76728fb2eb8915f0b492aabaa100c4165469c","unresolved":true,"context_lines":[{"line_number":4250,"context_line":"    session \u003d get_session()"},{"line_number":4251,"context_line":"    with session.begin():"},{"line_number":4252,"context_line":"        server_ref \u003d share_server_get(context, id, session\u003dsession)"},{"line_number":4253,"context_line":"        model_query("},{"line_number":4254,"context_line":"            context, models.ShareServerShareNetworkSubnetMapping,"},{"line_number":4255,"context_line":"            session\u003dsession"},{"line_number":4256,"context_line":"        ).filter_by("},{"line_number":4257,"context_line":"            share_server_id\u003did,"},{"line_number":4258,"context_line":"        ).soft_delete()"},{"line_number":4259,"context_line":"        share_server_backend_details_delete(context, id, session\u003dsession)"},{"line_number":4260,"context_line":"        server_ref.soft_delete(session\u003dsession, update_status\u003dTrue)"},{"line_number":4261,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"a08ae7a1_5e9ebc0a","line":4258,"range":{"start_line":4253,"start_character":0,"end_line":4258,"end_character":23},"updated":"2022-02-23 18:17:15.000000000","message":"is this going to be always a single match?","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6024752bf1249523ab445775c718126f24e372f2","unresolved":true,"context_lines":[{"line_number":4250,"context_line":"    session \u003d get_session()"},{"line_number":4251,"context_line":"    with session.begin():"},{"line_number":4252,"context_line":"        server_ref \u003d share_server_get(context, id, session\u003dsession)"},{"line_number":4253,"context_line":"        model_query("},{"line_number":4254,"context_line":"            context, models.ShareServerShareNetworkSubnetMapping,"},{"line_number":4255,"context_line":"            session\u003dsession"},{"line_number":4256,"context_line":"        ).filter_by("},{"line_number":4257,"context_line":"            share_server_id\u003did,"},{"line_number":4258,"context_line":"        ).soft_delete()"},{"line_number":4259,"context_line":"        share_server_backend_details_delete(context, id, session\u003dsession)"},{"line_number":4260,"context_line":"        server_ref.soft_delete(session\u003dsession, update_status\u003dTrue)"},{"line_number":4261,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"da710d05_ad8fa9a5","line":4258,"range":{"start_line":4253,"start_character":0,"end_line":4258,"end_character":23},"in_reply_to":"a08ae7a1_5e9ebc0a","updated":"2022-02-23 18:18:56.000000000","message":"Yes, it will","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":false,"context_lines":[{"line_number":4250,"context_line":"    session \u003d get_session()"},{"line_number":4251,"context_line":"    with session.begin():"},{"line_number":4252,"context_line":"        server_ref \u003d share_server_get(context, id, session\u003dsession)"},{"line_number":4253,"context_line":"        model_query("},{"line_number":4254,"context_line":"            context, models.ShareServerShareNetworkSubnetMapping,"},{"line_number":4255,"context_line":"            session\u003dsession"},{"line_number":4256,"context_line":"        ).filter_by("},{"line_number":4257,"context_line":"            share_server_id\u003did,"},{"line_number":4258,"context_line":"        ).soft_delete()"},{"line_number":4259,"context_line":"        share_server_backend_details_delete(context, id, session\u003dsession)"},{"line_number":4260,"context_line":"        server_ref.soft_delete(session\u003dsession, update_status\u003dTrue)"},{"line_number":4261,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"f73def28_c33eeea9","line":4258,"range":{"start_line":4253,"start_character":0,"end_line":4258,"end_character":23},"in_reply_to":"da710d05_ad8fa9a5","updated":"2022-02-24 21:10:41.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"}],"manila/db/sqlalchemy/models.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c930331689ac5ea6e79fd9c75a7a4bd266351a9","unresolved":true,"context_lines":[{"line_number":1086,"context_line":"                    \u0027ShareServer.id \u003d\u003d \u0027"},{"line_number":1087,"context_line":"                    \u0027ShareServerBackendDetails.share_server_id, \u0027"},{"line_number":1088,"context_line":"                    \u0027ShareServerBackendDetails.deleted \u003d\u003d \"False\")\u0027)"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"    _share_network_subnet_ids \u003d orm.relationship("},{"line_number":1091,"context_line":"        \"ShareServerShareNetworkSubnetMapping\","},{"line_number":1092,"context_line":"        lazy\u003d\u0027immediate\u0027,"},{"line_number":1093,"context_line":"        viewonly\u003dTrue,"},{"line_number":1094,"context_line":"        primaryjoin\u003d\u0027and_(\u0027"},{"line_number":1095,"context_line":"                    \u0027ShareServer.id \u003d\u003d \u0027"},{"line_number":1096,"context_line":"                    \u0027ShareServerShareNetworkSubnetMapping.share_server_id,\u0027"},{"line_number":1097,"context_line":"                    \u0027ShareServerShareNetworkSubnetMapping.deleted \u003d\u003d 0)\u0027)"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"    @property"},{"line_number":1100,"context_line":"    def backend_details(self):"}],"source_content_type":"text/x-python","patch_set":21,"id":"ef28fe5a_adf5905a","line":1097,"range":{"start_line":1089,"start_character":0,"end_line":1097,"end_character":73},"updated":"2022-02-14 17:48:20.000000000","message":"If you joined load with the allocations, you will have this information because of the backref on line 1004","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":1086,"context_line":"                    \u0027ShareServer.id \u003d\u003d \u0027"},{"line_number":1087,"context_line":"                    \u0027ShareServerBackendDetails.share_server_id, \u0027"},{"line_number":1088,"context_line":"                    \u0027ShareServerBackendDetails.deleted \u003d\u003d \"False\")\u0027)"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"    _share_network_subnet_ids \u003d orm.relationship("},{"line_number":1091,"context_line":"        \"ShareServerShareNetworkSubnetMapping\","},{"line_number":1092,"context_line":"        lazy\u003d\u0027immediate\u0027,"},{"line_number":1093,"context_line":"        viewonly\u003dTrue,"},{"line_number":1094,"context_line":"        primaryjoin\u003d\u0027and_(\u0027"},{"line_number":1095,"context_line":"                    \u0027ShareServer.id \u003d\u003d \u0027"},{"line_number":1096,"context_line":"                    \u0027ShareServerShareNetworkSubnetMapping.share_server_id,\u0027"},{"line_number":1097,"context_line":"                    \u0027ShareServerShareNetworkSubnetMapping.deleted \u003d\u003d 0)\u0027)"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"    @property"},{"line_number":1100,"context_line":"    def backend_details(self):"}],"source_content_type":"text/x-python","patch_set":21,"id":"6039800d_145d883b","line":1097,"range":{"start_line":1089,"start_character":0,"end_line":1097,"end_character":73},"in_reply_to":"ef28fe5a_adf5905a","updated":"2022-02-24 21:10:41.000000000","message":"good point, but there is some scenarios where the share servers are accessed through the share network subnet [1]. In this case, the share server does not have access to the backref \u0027share_network_subnets\u0027, the access to field will raise the error:\n\nCaught error: Parent instance \u003cShareServer at 0x7f9232b662b0\u003e is not bound to a Session; lazy load operation of attribute \u0027share_network_subnets\u0027 cannot proceed\n\nActually, the relationship \u0027_share_network_subnet_ids\u0027 lazily as \u0027lazy\u003dselect\u0027, instead of \u0027immediate\u0027 fails with same exception.\n\n\n\n[1]https://review.opendev.org/c/openstack/manila/+/825110/24/manila/api/v2/share_network_subnets.py#105","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6c930331689ac5ea6e79fd9c75a7a4bd266351a9","unresolved":true,"context_lines":[{"line_number":1123,"context_line":"class ShareServerShareNetworkSubnetMapping(BASE, ManilaBase):"},{"line_number":1124,"context_line":"    \"\"\"Represents the Share Server and Share Network Subnet mapping.\"\"\""},{"line_number":1125,"context_line":"    __tablename__ \u003d \u0027share_server_share_network_subnet_mappings\u0027"},{"line_number":1126,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":1127,"context_line":"    share_server_id \u003d Column("},{"line_number":1128,"context_line":"        String(36), ForeignKey(\u0027share_servers.id\u0027), nullable\u003dFalse)"},{"line_number":1129,"context_line":"    share_network_subnet_id \u003d Column("}],"source_content_type":"text/x-python","patch_set":21,"id":"46d7617c_39f66e95","line":1126,"range":{"start_line":1126,"start_character":0,"end_line":1126,"end_character":42},"updated":"2022-02-14 17:48:20.000000000","message":"This continues the inconsistency we have in our database tables --- we have a combination of integer IDs and UUID/string IDs :( \n\nTo figure out: how do soft-deletes work for tables with integer IDs?","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":1123,"context_line":"class ShareServerShareNetworkSubnetMapping(BASE, ManilaBase):"},{"line_number":1124,"context_line":"    \"\"\"Represents the Share Server and Share Network Subnet mapping.\"\"\""},{"line_number":1125,"context_line":"    __tablename__ \u003d \u0027share_server_share_network_subnet_mappings\u0027"},{"line_number":1126,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":1127,"context_line":"    share_server_id \u003d Column("},{"line_number":1128,"context_line":"        String(36), ForeignKey(\u0027share_servers.id\u0027), nullable\u003dFalse)"},{"line_number":1129,"context_line":"    share_network_subnet_id \u003d Column("}],"source_content_type":"text/x-python","patch_set":21,"id":"92ccb1cc_717bc41c","line":1126,"range":{"start_line":1126,"start_character":0,"end_line":1126,"end_character":42},"in_reply_to":"46d7617c_39f66e95","updated":"2022-02-24 21:10:41.000000000","message":"The soft delete works with Integer, see [1].\n\nAs we discussed during colab review, keeping the map model as integer id makes our life eaiser during the share server creation. only setting the field \"share_network_subnets\" with the share server\u0027s subnets will create the rows in the map table. See [2].\n\n[1]https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/models.py#L129\n[2]https://review.opendev.org/c/openstack/manila/+/825110/24/manila/share/manager.py#1005","commit_id":"64ba9a082229c53c6157de014b6e9bbf148d200e"}],"manila/policies/share_network.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3599dd6b3966e60c08177a3724149f850d0dc221","unresolved":true,"context_lines":[{"line_number":293,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027subnet_create_check\u0027,"},{"line_number":294,"context_line":"        check_str\u003dbase.SYSTEM_ADMIN_OR_PROJECT_MEMBER,"},{"line_number":295,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":296,"context_line":"        description\u003d\"Check the feasibility of create a subnet from \""},{"line_number":297,"context_line":"                    \"share network.\","},{"line_number":298,"context_line":"        operations\u003d["},{"line_number":299,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":30,"id":"e3ef9437_d1783c72","line":296,"range":{"start_line":296,"start_character":62,"end_line":296,"end_character":66},"updated":"2022-03-02 20:15:14.000000000","message":"for a","commit_id":"13cfef43f93e04d53d236e0b63828b86267668e8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3599dd6b3966e60c08177a3724149f850d0dc221","unresolved":true,"context_lines":[{"line_number":293,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027subnet_create_check\u0027,"},{"line_number":294,"context_line":"        check_str\u003dbase.SYSTEM_ADMIN_OR_PROJECT_MEMBER,"},{"line_number":295,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":296,"context_line":"        description\u003d\"Check the feasibility of create a subnet from \""},{"line_number":297,"context_line":"                    \"share network.\","},{"line_number":298,"context_line":"        operations\u003d["},{"line_number":299,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":30,"id":"ee332044_762f83a6","line":296,"range":{"start_line":296,"start_character":55,"end_line":296,"end_character":61},"updated":"2022-03-02 20:15:14.000000000","message":"nit: new share network subnet","commit_id":"13cfef43f93e04d53d236e0b63828b86267668e8"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"cd4a893494bf8d8e2ad4a028cfbcdef89f0d9158","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027subnet_create_check\u0027,"},{"line_number":294,"context_line":"        check_str\u003dbase.SYSTEM_ADMIN_OR_PROJECT_MEMBER,"},{"line_number":295,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":296,"context_line":"        description\u003d\"Check the feasibility of create a subnet from \""},{"line_number":297,"context_line":"                    \"share network.\","},{"line_number":298,"context_line":"        operations\u003d["},{"line_number":299,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":30,"id":"b69a23c8_8d24b312","line":296,"range":{"start_line":296,"start_character":62,"end_line":296,"end_character":66},"in_reply_to":"e3ef9437_d1783c72","updated":"2022-03-03 03:31:27.000000000","message":"Done.","commit_id":"13cfef43f93e04d53d236e0b63828b86267668e8"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"cd4a893494bf8d8e2ad4a028cfbcdef89f0d9158","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027subnet_create_check\u0027,"},{"line_number":294,"context_line":"        check_str\u003dbase.SYSTEM_ADMIN_OR_PROJECT_MEMBER,"},{"line_number":295,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027],"},{"line_number":296,"context_line":"        description\u003d\"Check the feasibility of create a subnet from \""},{"line_number":297,"context_line":"                    \"share network.\","},{"line_number":298,"context_line":"        operations\u003d["},{"line_number":299,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":30,"id":"cbae6df3_4319c5a8","line":296,"range":{"start_line":296,"start_character":55,"end_line":296,"end_character":61},"in_reply_to":"ee332044_762f83a6","updated":"2022-03-03 03:31:27.000000000","message":"Done.","commit_id":"13cfef43f93e04d53d236e0b63828b86267668e8"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"1eac09af9f6ee34aa5ad2d3d4c7f5ea1e18f5349","unresolved":true,"context_lines":[{"line_number":102,"context_line":"deprecated_share_network_subnet_create_check \u003d policy.DeprecatedRule("},{"line_number":103,"context_line":"    name\u003dBASE_POLICY_NAME % \u0027subnet_create_check\u0027,"},{"line_number":104,"context_line":"    check_str\u003dbase.RULE_DEFAULT"},{"line_number":105,"context_line":")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"share_network_policies \u003d ["}],"source_content_type":"text/x-python","patch_set":31,"id":"21b520ed_305093fa","line":105,"range":{"start_line":105,"start_character":0,"end_line":105,"end_character":1},"updated":"2022-03-03 21:39:06.000000000","message":"missing?\n    deprecated_reason\u003dDEPRECATED_REASON,\n    deprecated_since\u003dversionutils.deprecated.YOGA","commit_id":"2b57d15c641ff2a222c7d0af63853976b7e50f1f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bf43a7212b5b6e59c7e017ffed561f6318271d22","unresolved":true,"context_lines":[{"line_number":102,"context_line":"deprecated_share_network_subnet_create_check \u003d policy.DeprecatedRule("},{"line_number":103,"context_line":"    name\u003dBASE_POLICY_NAME % \u0027subnet_create_check\u0027,"},{"line_number":104,"context_line":"    check_str\u003dbase.RULE_DEFAULT"},{"line_number":105,"context_line":")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"share_network_policies \u003d ["}],"source_content_type":"text/x-python","patch_set":31,"id":"5d2edaf1_c739f4ad","line":105,"range":{"start_line":105,"start_character":0,"end_line":105,"end_character":1},"in_reply_to":"1513a2e1_8355c98a","updated":"2022-03-08 19:48:27.000000000","message":"Yeah, this non-scoped policy will need to be introduced as deprecated... weird, i know.. read on:\n\nI know its a bit strange, but, the intent of all these current deprecations is so that we can make a transition into using the \"scope\" attribute exposed by keystone... in short - keystone now has a way for a user holding a particular role to operate at system scope or within a project\u0027s scope. \n\nUnfortunately, the use of scope is going to be a pretty major change to deployers, so, we want to ease the transition... and we want to make a coordinated transition across all openstack projects. The current plan is to stop supported these deprecated policies likely in the \"A\" or \"B\" releases. So, until then, every policy we introduce will need to have two parts:\n\n1) Scoped policy like the one you\u0027ve added on line 292 of this file\nand\n2) an un-scoped policy (where there\u0027s no \"scope_types\" argument\") that is introduced as deprecated.","commit_id":"2b57d15c641ff2a222c7d0af63853976b7e50f1f"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"a1c41bafa634d378e08002af698cd4034819befb","unresolved":true,"context_lines":[{"line_number":102,"context_line":"deprecated_share_network_subnet_create_check \u003d policy.DeprecatedRule("},{"line_number":103,"context_line":"    name\u003dBASE_POLICY_NAME % \u0027subnet_create_check\u0027,"},{"line_number":104,"context_line":"    check_str\u003dbase.RULE_DEFAULT"},{"line_number":105,"context_line":")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"share_network_policies \u003d ["}],"source_content_type":"text/x-python","patch_set":31,"id":"1513a2e1_8355c98a","line":105,"range":{"start_line":105,"start_character":0,"end_line":105,"end_character":1},"in_reply_to":"21b520ed_305093fa","updated":"2022-03-03 21:56:41.000000000","message":"Hi Douglas, I talked with Carlos about it some time ago, and he said probably it\u0027s not necessary since it\u0027s a new API and doesn\u0027t exist when the deprecation happened at W release. If I understood wrong let me know, and we will fix in a follow-up patch.","commit_id":"2b57d15c641ff2a222c7d0af63853976b7e50f1f"}],"manila/scheduler/filters/availability_zone.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ae76728fb2eb8915f0b492aabaa100c4165469c","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        # host:"},{"line_number":47,"context_line":"        #   1. host is satisfying the AZ"},{"line_number":48,"context_line":"        #   2. There is a map to be checked"},{"line_number":49,"context_line":"        #   4. The host does not support a multiple subnet"},{"line_number":50,"context_line":"        if (host_satisfied and az_request_multiple_subnet_support_map and"},{"line_number":51,"context_line":"                host_single_subnet_only):"},{"line_number":52,"context_line":"            host_satisfied \u003d ("}],"source_content_type":"text/x-python","patch_set":24,"id":"3568e64a_b16724d7","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":13},"updated":"2022-02-23 18:17:15.000000000","message":"3","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        # host:"},{"line_number":47,"context_line":"        #   1. host is satisfying the AZ"},{"line_number":48,"context_line":"        #   2. There is a map to be checked"},{"line_number":49,"context_line":"        #   4. The host does not support a multiple subnet"},{"line_number":50,"context_line":"        if (host_satisfied and az_request_multiple_subnet_support_map and"},{"line_number":51,"context_line":"                host_single_subnet_only):"},{"line_number":52,"context_line":"            host_satisfied \u003d ("}],"source_content_type":"text/x-python","patch_set":24,"id":"c7303f36_ea6fb203","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":13},"in_reply_to":"11d9ceab_ccad7228","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        # host:"},{"line_number":47,"context_line":"        #   1. host is satisfying the AZ"},{"line_number":48,"context_line":"        #   2. There is a map to be checked"},{"line_number":49,"context_line":"        #   4. The host does not support a multiple subnet"},{"line_number":50,"context_line":"        if (host_satisfied and az_request_multiple_subnet_support_map and"},{"line_number":51,"context_line":"                host_single_subnet_only):"},{"line_number":52,"context_line":"            host_satisfied \u003d ("}],"source_content_type":"text/x-python","patch_set":24,"id":"11d9ceab_ccad7228","line":49,"range":{"start_line":49,"start_character":12,"end_line":49,"end_character":13},"in_reply_to":"3568e64a_b16724d7","updated":"2022-02-24 21:10:41.000000000","message":"done, see next patch.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"}],"manila/share/api.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ae76728fb2eb8915f0b492aabaa100c4165469c","unresolved":true,"context_lines":[{"line_number":3344,"context_line":"            \u0027neutron_subnet_id\u0027: added_subnet.get(\u0027neutron_subnet_id\u0027),"},{"line_number":3345,"context_line":"        }"},{"line_number":3346,"context_line":"        for backend_host in backend_hosts:"},{"line_number":3347,"context_line":"            is_compatible \u003d ("},{"line_number":3348,"context_line":"                self.share_rpcapi."},{"line_number":3349,"context_line":"                check_update_share_server_network_allocations("},{"line_number":3350,"context_line":"                    context, backend_host, share_network[\u0027id\u0027],"},{"line_number":3351,"context_line":"                    subnet_info))"},{"line_number":3352,"context_line":"            if not is_compatible:"},{"line_number":3353,"context_line":"                msg \u003d _("},{"line_number":3354,"context_line":"                    \"Cannot create share network subnet, one of the share \""}],"source_content_type":"text/x-python","patch_set":24,"id":"158e74f1_d3e8c4ef","line":3351,"range":{"start_line":3347,"start_character":0,"end_line":3351,"end_character":33},"updated":"2022-02-23 18:17:15.000000000","message":"i think that this syncronous call was already discussed in the collab call, please consider reuse sec service update methods to store that info in DB and split into 2 different calls","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":3344,"context_line":"            \u0027neutron_subnet_id\u0027: added_subnet.get(\u0027neutron_subnet_id\u0027),"},{"line_number":3345,"context_line":"        }"},{"line_number":3346,"context_line":"        for backend_host in backend_hosts:"},{"line_number":3347,"context_line":"            is_compatible \u003d ("},{"line_number":3348,"context_line":"                self.share_rpcapi."},{"line_number":3349,"context_line":"                check_update_share_server_network_allocations("},{"line_number":3350,"context_line":"                    context, backend_host, share_network[\u0027id\u0027],"},{"line_number":3351,"context_line":"                    subnet_info))"},{"line_number":3352,"context_line":"            if not is_compatible:"},{"line_number":3353,"context_line":"                msg \u003d _("},{"line_number":3354,"context_line":"                    \"Cannot create share network subnet, one of the share \""}],"source_content_type":"text/x-python","patch_set":24,"id":"343c3db9_08850bae","line":3351,"range":{"start_line":3347,"start_character":0,"end_line":3351,"end_character":33},"in_reply_to":"158e74f1_d3e8c4ef","updated":"2022-02-24 21:10:41.000000000","message":"yeap, see next patch with this new approach.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":3344,"context_line":"            \u0027neutron_subnet_id\u0027: added_subnet.get(\u0027neutron_subnet_id\u0027),"},{"line_number":3345,"context_line":"        }"},{"line_number":3346,"context_line":"        for backend_host in backend_hosts:"},{"line_number":3347,"context_line":"            is_compatible \u003d ("},{"line_number":3348,"context_line":"                self.share_rpcapi."},{"line_number":3349,"context_line":"                check_update_share_server_network_allocations("},{"line_number":3350,"context_line":"                    context, backend_host, share_network[\u0027id\u0027],"},{"line_number":3351,"context_line":"                    subnet_info))"},{"line_number":3352,"context_line":"            if not is_compatible:"},{"line_number":3353,"context_line":"                msg \u003d _("},{"line_number":3354,"context_line":"                    \"Cannot create share network subnet, one of the share \""}],"source_content_type":"text/x-python","patch_set":24,"id":"c9378456_25f18638","line":3351,"range":{"start_line":3347,"start_character":0,"end_line":3351,"end_character":33},"in_reply_to":"343c3db9_08850bae","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cdbcd1f07ad0f2f14fac2ca9c2df998b40402f6d","unresolved":true,"context_lines":[{"line_number":3499,"context_line":"                    availability_zone_id\u003dadded_subnet.get("},{"line_number":3500,"context_line":"                        \"availability_zone_id\")))"},{"line_number":3501,"context_line":"        except Exception as e:"},{"line_number":3502,"context_line":"            LOG.error(e)"},{"line_number":3503,"context_line":"            # Due to an internal error, we will delete the entry."},{"line_number":3504,"context_line":"            self.db.async_operation_data_delete("},{"line_number":3505,"context_line":"                context, share_network[\u0027id\u0027], update_key)"}],"source_content_type":"text/x-python","patch_set":27,"id":"45b90400_31b1df28","line":3502,"range":{"start_line":3502,"start_character":16,"end_line":3502,"end_character":21},"updated":"2022-02-25 19:20:40.000000000","message":"exception?","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"39e609776ce5356ee37d5b41554adfdd9d1ab222","unresolved":true,"context_lines":[{"line_number":3499,"context_line":"                    availability_zone_id\u003dadded_subnet.get("},{"line_number":3500,"context_line":"                        \"availability_zone_id\")))"},{"line_number":3501,"context_line":"        except Exception as e:"},{"line_number":3502,"context_line":"            LOG.error(e)"},{"line_number":3503,"context_line":"            # Due to an internal error, we will delete the entry."},{"line_number":3504,"context_line":"            self.db.async_operation_data_delete("},{"line_number":3505,"context_line":"                context, share_network[\u0027id\u0027], update_key)"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa899551_031061a3","line":3502,"range":{"start_line":3502,"start_character":16,"end_line":3502,"end_character":21},"in_reply_to":"45b90400_31b1df28","updated":"2022-02-25 20:12:21.000000000","message":"ok. done.","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":3499,"context_line":"                    availability_zone_id\u003dadded_subnet.get("},{"line_number":3500,"context_line":"                        \"availability_zone_id\")))"},{"line_number":3501,"context_line":"        except Exception as e:"},{"line_number":3502,"context_line":"            LOG.error(e)"},{"line_number":3503,"context_line":"            # Due to an internal error, we will delete the entry."},{"line_number":3504,"context_line":"            self.db.async_operation_data_delete("},{"line_number":3505,"context_line":"                context, share_network[\u0027id\u0027], update_key)"}],"source_content_type":"text/x-python","patch_set":27,"id":"ce5c2f0b_1105dcb4","line":3502,"range":{"start_line":3502,"start_character":16,"end_line":3502,"end_character":21},"in_reply_to":"fa899551_031061a3","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"}],"manila/share/manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7070bee6da7029377635079a3693565b9542155","unresolved":true,"context_lines":[{"line_number":3050,"context_line":"            msg \u003d (\"Since share %(share)s has been un-managed from share \""},{"line_number":3051,"context_line":"                   \"server %(server)s. This share server must be removed \""},{"line_number":3052,"context_line":"                   \"manually, either by un-managing or by deleting it. The \""},{"line_number":3053,"context_line":"                   \"share network subnet %(subnet)s and share network \""},{"line_number":3054,"context_line":"                   \"%(network)s cannot be deleted unless this share server \""},{"line_number":3055,"context_line":"                   \"has been removed.\")"},{"line_number":3056,"context_line":"            msg_args \u003d {"}],"source_content_type":"text/x-python","patch_set":26,"id":"13e33dc0_7df050a9","line":3053,"range":{"start_line":3053,"start_character":41,"end_line":3053,"end_character":51},"updated":"2022-02-25 08:02:44.000000000","message":"The key here is subnet, you\u0027re changing the args below.. \n\nthis fails a bunch of times during testing the container driver: https://zuul.opendev.org/t/openstack/build/22d234d01d6740b6abe3b6c8d3f1a9cd/log/controller/logs/screen-m-shr.txt#10804-10926","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"85c9a69f8bd08da6adbbbdc5727523aa41710991","unresolved":true,"context_lines":[{"line_number":3050,"context_line":"            msg \u003d (\"Since share %(share)s has been un-managed from share \""},{"line_number":3051,"context_line":"                   \"server %(server)s. This share server must be removed \""},{"line_number":3052,"context_line":"                   \"manually, either by un-managing or by deleting it. The \""},{"line_number":3053,"context_line":"                   \"share network subnet %(subnet)s and share network \""},{"line_number":3054,"context_line":"                   \"%(network)s cannot be deleted unless this share server \""},{"line_number":3055,"context_line":"                   \"has been removed.\")"},{"line_number":3056,"context_line":"            msg_args \u003d {"}],"source_content_type":"text/x-python","patch_set":26,"id":"d0feed1e_1186d051","line":3053,"range":{"start_line":3053,"start_character":41,"end_line":3053,"end_character":51},"in_reply_to":"13e33dc0_7df050a9","updated":"2022-02-25 12:59:02.000000000","message":"nice catch. Thanks. Fixed.","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":3050,"context_line":"            msg \u003d (\"Since share %(share)s has been un-managed from share \""},{"line_number":3051,"context_line":"                   \"server %(server)s. This share server must be removed \""},{"line_number":3052,"context_line":"                   \"manually, either by un-managing or by deleting it. The \""},{"line_number":3053,"context_line":"                   \"share network subnet %(subnet)s and share network \""},{"line_number":3054,"context_line":"                   \"%(network)s cannot be deleted unless this share server \""},{"line_number":3055,"context_line":"                   \"has been removed.\")"},{"line_number":3056,"context_line":"            msg_args \u003d {"}],"source_content_type":"text/x-python","patch_set":26,"id":"90e7fe53_e71d1e24","line":3053,"range":{"start_line":3053,"start_character":41,"end_line":3053,"end_character":51},"in_reply_to":"d0feed1e_1186d051","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"13c8c0fabfe6dbb17121ed4997c403be54e03ed7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cdbcd1f07ad0f2f14fac2ca9c2df998b40402f6d","unresolved":true,"context_lines":[{"line_number":4232,"context_line":"    @utils.require_driver_initialized"},{"line_number":4233,"context_line":"    def delete_share_server(self, context, share_server):"},{"line_number":4234,"context_line":""},{"line_number":4235,"context_line":"        subnet_id \u003d (share_server[\u0027share_network_subnet_ids\u0027][0]"},{"line_number":4236,"context_line":"                     if share_server[\u0027share_network_subnet_ids\u0027] else None)"},{"line_number":4237,"context_line":""},{"line_number":4238,"context_line":"        @utils.synchronized("}],"source_content_type":"text/x-python","patch_set":27,"id":"aa77ed5b_241cf145","line":4235,"range":{"start_line":4235,"start_character":8,"end_line":4235,"end_character":17},"updated":"2022-02-25 19:20:40.000000000","message":"is there any chance of this being none?","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f14ede0d5f82a6858cb2dcff93b23df2759d93ab","unresolved":false,"context_lines":[{"line_number":4232,"context_line":"    @utils.require_driver_initialized"},{"line_number":4233,"context_line":"    def delete_share_server(self, context, share_server):"},{"line_number":4234,"context_line":""},{"line_number":4235,"context_line":"        subnet_id \u003d (share_server[\u0027share_network_subnet_ids\u0027][0]"},{"line_number":4236,"context_line":"                     if share_server[\u0027share_network_subnet_ids\u0027] else None)"},{"line_number":4237,"context_line":""},{"line_number":4238,"context_line":"        @utils.synchronized("}],"source_content_type":"text/x-python","patch_set":27,"id":"07e86918_c98ead8c","line":4235,"range":{"start_line":4235,"start_character":8,"end_line":4235,"end_character":17},"in_reply_to":"58da4a07_a261570d","updated":"2022-03-02 20:16:33.000000000","message":"Sounds okay","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"39e609776ce5356ee37d5b41554adfdd9d1ab222","unresolved":true,"context_lines":[{"line_number":4232,"context_line":"    @utils.require_driver_initialized"},{"line_number":4233,"context_line":"    def delete_share_server(self, context, share_server):"},{"line_number":4234,"context_line":""},{"line_number":4235,"context_line":"        subnet_id \u003d (share_server[\u0027share_network_subnet_ids\u0027][0]"},{"line_number":4236,"context_line":"                     if share_server[\u0027share_network_subnet_ids\u0027] else None)"},{"line_number":4237,"context_line":""},{"line_number":4238,"context_line":"        @utils.synchronized("}],"source_content_type":"text/x-python","patch_set":27,"id":"58da4a07_a261570d","line":4235,"range":{"start_line":4235,"start_character":8,"end_line":4235,"end_character":17},"in_reply_to":"aa77ed5b_241cf145","updated":"2022-02-25 20:12:21.000000000","message":"During migration script, we only add to subnets to map table when the share server has \"share_network_subnet_id\" field set. The subnet id on ShareServers model was \"nullable\u003dTrue\", so there is a possibility to have a share server without subnet from previous environment (at least from the database design perspective). \n\nIt\u0027s more a kind of defensive code. The \"ShareServers\" table does not block ShareServer to have empty \"share_network_subnet_id\". So, we prefer checking it before accessing the list first element. \n\nIn new environments, I cannot see the possibility to be None. However, in upgrade pre-existent system, there is a possibility (very small, I think).\n\n\nFinally, we don\u0027t know the future. The share network subnet can be changed for some reason, causing an exception here. Or even the db can be manually changed for some reason. The approach is: better to be safe, check if the list contains elements, before accessing it.\n\n\nI don\u0027t have strong opnion here. I\u0027m totally okay to change it to get directly the first element without any check, though.\n\nWDYT ?","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cdbcd1f07ad0f2f14fac2ca9c2df998b40402f6d","unresolved":true,"context_lines":[{"line_number":6181,"context_line":"                    context, constants.STATUS_ERROR,"},{"line_number":6182,"context_line":"                    share_instance_ids\u003dshare_instance_ids,"},{"line_number":6183,"context_line":"                    snapshot_instance_ids\u003dsnapshot_instance_ids)"},{"line_number":6184,"context_line":""},{"line_number":6185,"context_line":"                continue"},{"line_number":6186,"context_line":""},{"line_number":6187,"context_line":"            msg \u003d _("}],"source_content_type":"text/x-python","patch_set":27,"id":"ac9ed8b4_013b3057","line":6184,"updated":"2022-02-25 19:20:40.000000000","message":"would setting the share network status to error be something interesting for us as well?\nI\u0027m thinking of that as a possible way to signalize that manila tried to add the subnet but failed","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"39e609776ce5356ee37d5b41554adfdd9d1ab222","unresolved":true,"context_lines":[{"line_number":6181,"context_line":"                    context, constants.STATUS_ERROR,"},{"line_number":6182,"context_line":"                    share_instance_ids\u003dshare_instance_ids,"},{"line_number":6183,"context_line":"                    snapshot_instance_ids\u003dsnapshot_instance_ids)"},{"line_number":6184,"context_line":""},{"line_number":6185,"context_line":"                continue"},{"line_number":6186,"context_line":""},{"line_number":6187,"context_line":"            msg \u003d _("}],"source_content_type":"text/x-python","patch_set":27,"id":"c3d45463_3acf82d1","line":6184,"in_reply_to":"ac9ed8b4_013b3057","updated":"2022-02-25 20:12:21.000000000","message":"Yeah.. that\u0027s a possibility.. We have designed the feature in the spec to leave the share network back to active state, no matter failed or not. It follows the same pattern of update security service (failed operation will have network to active only share servers to error). \n\nParticularly, I\u0027m okay with both. Just follow what we\u0027ve decided during spec.","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f14ede0d5f82a6858cb2dcff93b23df2759d93ab","unresolved":false,"context_lines":[{"line_number":6181,"context_line":"                    context, constants.STATUS_ERROR,"},{"line_number":6182,"context_line":"                    share_instance_ids\u003dshare_instance_ids,"},{"line_number":6183,"context_line":"                    snapshot_instance_ids\u003dsnapshot_instance_ids)"},{"line_number":6184,"context_line":""},{"line_number":6185,"context_line":"                continue"},{"line_number":6186,"context_line":""},{"line_number":6187,"context_line":"            msg \u003d _("}],"source_content_type":"text/x-python","patch_set":27,"id":"9588e195_c2a7d106","line":6184,"in_reply_to":"c3d45463_3acf82d1","updated":"2022-03-02 20:16:33.000000000","message":"Ack","commit_id":"ac2d454d5aa741fd4ecd3639bec3622d86fe5975"}],"manila/share/rpcapi.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ae76728fb2eb8915f0b492aabaa100c4165469c","unresolved":true,"context_lines":[{"line_number":466,"context_line":"            current_security_service_id\u003dcurrent_security_service_id)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    def check_update_share_server_network_allocations("},{"line_number":469,"context_line":"            self, context, dest_host, share_network_id, added_subnet):"},{"line_number":470,"context_line":"        host \u003d utils.extract_host(dest_host)"},{"line_number":471,"context_line":"        call_context \u003d self.client.prepare(server\u003dhost, version\u003d\u00271.23\u0027)"},{"line_number":472,"context_line":"        return call_context.call("}],"source_content_type":"text/x-python","patch_set":24,"id":"0d4caa7b_aa49560f","line":469,"range":{"start_line":469,"start_character":56,"end_line":469,"end_character":68},"updated":"2022-02-23 18:17:15.000000000","message":"nit: new_share_network_subnet_id","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":466,"context_line":"            current_security_service_id\u003dcurrent_security_service_id)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    def check_update_share_server_network_allocations("},{"line_number":469,"context_line":"            self, context, dest_host, share_network_id, added_subnet):"},{"line_number":470,"context_line":"        host \u003d utils.extract_host(dest_host)"},{"line_number":471,"context_line":"        call_context \u003d self.client.prepare(server\u003dhost, version\u003d\u00271.23\u0027)"},{"line_number":472,"context_line":"        return call_context.call("}],"source_content_type":"text/x-python","patch_set":24,"id":"7c4a0a46_02b808ff","line":469,"range":{"start_line":469,"start_character":56,"end_line":469,"end_character":68},"in_reply_to":"0d4caa7b_aa49560f","updated":"2022-02-24 21:10:41.000000000","message":"It is not a subnet_id, it is the added subnet info (dict).","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            current_security_service_id\u003dcurrent_security_service_id)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    def check_update_share_server_network_allocations("},{"line_number":469,"context_line":"            self, context, dest_host, share_network_id, added_subnet):"},{"line_number":470,"context_line":"        host \u003d utils.extract_host(dest_host)"},{"line_number":471,"context_line":"        call_context \u003d self.client.prepare(server\u003dhost, version\u003d\u00271.23\u0027)"},{"line_number":472,"context_line":"        return call_context.call("}],"source_content_type":"text/x-python","patch_set":24,"id":"3f211a18_d43928a6","line":469,"range":{"start_line":469,"start_character":56,"end_line":469,"end_character":68},"in_reply_to":"7c4a0a46_02b808ff","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5ae76728fb2eb8915f0b492aabaa100c4165469c","unresolved":true,"context_lines":[{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def update_share_server_network_allocations("},{"line_number":479,"context_line":"            self, context, dest_host, share_network_id,"},{"line_number":480,"context_line":"            added_share_network_subnet_id):"},{"line_number":481,"context_line":"        host \u003d utils.extract_host(dest_host)"},{"line_number":482,"context_line":"        call_context \u003d self.client.prepare(server\u003dhost, version\u003d\u00271.23\u0027)"},{"line_number":483,"context_line":"        call_context.cast("}],"source_content_type":"text/x-python","patch_set":24,"id":"c9b56f3d_7431d789","line":480,"range":{"start_line":480,"start_character":12,"end_line":480,"end_character":41},"updated":"2022-02-23 18:17:15.000000000","message":"nit: new_share_network_subnet_id","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"48f1cd18fd3bec9ca7653c7365b8cd748cfeee07","unresolved":true,"context_lines":[{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def update_share_server_network_allocations("},{"line_number":479,"context_line":"            self, context, dest_host, share_network_id,"},{"line_number":480,"context_line":"            added_share_network_subnet_id):"},{"line_number":481,"context_line":"        host \u003d utils.extract_host(dest_host)"},{"line_number":482,"context_line":"        call_context \u003d self.client.prepare(server\u003dhost, version\u003d\u00271.23\u0027)"},{"line_number":483,"context_line":"        call_context.cast("}],"source_content_type":"text/x-python","patch_set":24,"id":"e99a95ff_bba60b38","line":480,"range":{"start_line":480,"start_character":12,"end_line":480,"end_character":41},"in_reply_to":"c9b56f3d_7431d789","updated":"2022-02-24 21:10:41.000000000","message":"done, see next patch.","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"ac0c11ddacc58ca933bdf7a906028aadf1d1a62a","unresolved":false,"context_lines":[{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def update_share_server_network_allocations("},{"line_number":479,"context_line":"            self, context, dest_host, share_network_id,"},{"line_number":480,"context_line":"            added_share_network_subnet_id):"},{"line_number":481,"context_line":"        host \u003d utils.extract_host(dest_host)"},{"line_number":482,"context_line":"        call_context \u003d self.client.prepare(server\u003dhost, version\u003d\u00271.23\u0027)"},{"line_number":483,"context_line":"        call_context.cast("}],"source_content_type":"text/x-python","patch_set":24,"id":"71b364d5_b73f1c5c","line":480,"range":{"start_line":480,"start_character":12,"end_line":480,"end_character":41},"in_reply_to":"e99a95ff_bba60b38","updated":"2022-03-02 13:29:25.000000000","message":"Done","commit_id":"acfad4395ae5d6acecfe3f308fbd54ac330402ef"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3599dd6b3966e60c08177a3724149f850d0dc221","unresolved":true,"context_lines":[{"line_number":466,"context_line":"            current_security_service_id\u003dcurrent_security_service_id)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    def check_update_share_server_network_allocations("},{"line_number":469,"context_line":"            self, context, dest_host, share_network_id, added_subnet):"},{"line_number":470,"context_line":"        host \u003d utils.extract_host(dest_host)"},{"line_number":471,"context_line":"        call_context \u003d self.client.prepare(server\u003dhost, version\u003d\u00271.23\u0027)"},{"line_number":472,"context_line":"        call_context.cast("}],"source_content_type":"text/x-python","patch_set":30,"id":"ac1f77ac_d1b46a8e","line":469,"range":{"start_line":469,"start_character":56,"end_line":469,"end_character":68},"updated":"2022-03-02 20:15:14.000000000","message":"nit: new_subnet_info (in case you update this change)\n\"added\" means that you added a new subnet, which is not true (yet)","commit_id":"13cfef43f93e04d53d236e0b63828b86267668e8"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"cd4a893494bf8d8e2ad4a028cfbcdef89f0d9158","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            current_security_service_id\u003dcurrent_security_service_id)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    def check_update_share_server_network_allocations("},{"line_number":469,"context_line":"            self, context, dest_host, share_network_id, added_subnet):"},{"line_number":470,"context_line":"        host \u003d utils.extract_host(dest_host)"},{"line_number":471,"context_line":"        call_context \u003d self.client.prepare(server\u003dhost, version\u003d\u00271.23\u0027)"},{"line_number":472,"context_line":"        call_context.cast("}],"source_content_type":"text/x-python","patch_set":30,"id":"2cb518a3_fe01d300","line":469,"range":{"start_line":469,"start_character":56,"end_line":469,"end_character":68},"in_reply_to":"ac1f77ac_d1b46a8e","updated":"2022-03-03 03:31:27.000000000","message":"Done. To keep it consistent I\u0027ve replaced all added_subnet occurrences to new_share_network_subnet in core code. I\u0027ve also updated the drivers patches to use the new paramenter name.","commit_id":"13cfef43f93e04d53d236e0b63828b86267668e8"}],"releasenotes/notes/add_support_multiple_subnet_per_az-e7b0359f4e8eca48.yaml":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3599dd6b3966e60c08177a3724149f850d0dc221","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    that support this deployment will be selected."},{"line_number":21,"context_line":"deprecations:"},{"line_number":22,"context_line":"  - Removed \u0027share_network_subnet_id\u0027 attribute and add \u0027share_network_subnet_ids\u0027"},{"line_number":23,"context_line":"    attribute from share server view starting with microversion \u00272.69\u0027. The share"},{"line_number":24,"context_line":"    server has a list of subnets."}],"source_content_type":"text/x-yaml","patch_set":30,"id":"5985dc86_b5e542c3","line":23,"range":{"start_line":23,"start_character":67,"end_line":23,"end_character":69},"updated":"2022-03-02 20:15:14.000000000","message":"70","commit_id":"13cfef43f93e04d53d236e0b63828b86267668e8"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"cd4a893494bf8d8e2ad4a028cfbcdef89f0d9158","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    that support this deployment will be selected."},{"line_number":21,"context_line":"deprecations:"},{"line_number":22,"context_line":"  - Removed \u0027share_network_subnet_id\u0027 attribute and add \u0027share_network_subnet_ids\u0027"},{"line_number":23,"context_line":"    attribute from share server view starting with microversion \u00272.69\u0027. The share"},{"line_number":24,"context_line":"    server has a list of subnets."}],"source_content_type":"text/x-yaml","patch_set":30,"id":"404b2167_92777e27","line":23,"range":{"start_line":23,"start_character":67,"end_line":23,"end_character":69},"in_reply_to":"5985dc86_b5e542c3","updated":"2022-03-03 03:31:27.000000000","message":"Done.","commit_id":"13cfef43f93e04d53d236e0b63828b86267668e8"}]}