)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"a2195e1920adc6845af0807574b54f4b6cf22d5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ce8b7fdf_50f5bd08","updated":"2022-01-18 18:07:02.000000000","message":"work in progress...","commit_id":"108a44b2a674fe34e7d7e086e51a8746c53de50d"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"a3f190795dc08504b914ab10a3169e2df0703865","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"05202999_21423fd2","updated":"2022-01-26 21:06:42.000000000","message":"Release notes and ref to blueprint still missing.","commit_id":"062aae0ad3505d4d88527077fcda97f75650bf2f"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"05ceb06937413769fdefdcf4bd5001d9d52eb185","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cccb0312_eb578bd9","updated":"2022-01-27 03:56:47.000000000","message":"Fixed pep8, release notes and ref to bp still missing.","commit_id":"d9fb08103e35d292ca91f385adda5b574194e295"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"a12424bf2107efc07ce2bb5db088b0794bc30f72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0757b1f4_88025a8b","updated":"2022-02-01 18:54:56.000000000","message":"run-NetApp CI","commit_id":"205146bb6682d058eab80dcfda91dfaf0203c8b1"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"d461dbefb59460e8f5ab30d4857a6fcb517341d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"06a1eb2d_329deeec","updated":"2022-02-03 04:18:35.000000000","message":"run-NetApp CI","commit_id":"0c7b839db48bb9f122f878d12d07b2ba484c73b2"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"8ac782aa33b1984f2ab34e7539a8bb39b141ffda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0b8e7d37_77f603ad","updated":"2022-02-03 13:23:10.000000000","message":"run-NetApp CI","commit_id":"0c7b839db48bb9f122f878d12d07b2ba484c73b2"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"743f691f1a4b18d8f36aa895c9cffffdd5f81b86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0ad55e18_ef652c7c","updated":"2022-02-09 12:47:29.000000000","message":"run-NetApp CI","commit_id":"fbe7185dde325e71ca6e8d6c59e5623b9e0a02c0"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"373b064a91cce7a18041d648e8610674a26f6bcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0c4faecf_53b7e604","updated":"2022-02-09 16:33:46.000000000","message":"run-NetApp CI","commit_id":"fbe7185dde325e71ca6e8d6c59e5623b9e0a02c0"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"1e7ca6ca00ebd253f24622c7ea1f578f9884a111","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3d2f6e33_959e9e70","updated":"2022-02-09 23:48:20.000000000","message":"run-NetApp CI","commit_id":"fbe7185dde325e71ca6e8d6c59e5623b9e0a02c0"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"7fd2e1235fb72d41099907bbcec2d5577cdf77db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"aa2752a7_d7332cb3","updated":"2022-02-10 11:20:23.000000000","message":"run-NetApp CI","commit_id":"fbe7185dde325e71ca6e8d6c59e5623b9e0a02c0"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"512982ee148c11aa86ef1a7e6beb3dbaf09c7bd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d9fe3a34_bfc999eb","updated":"2022-02-09 19:53:53.000000000","message":"run-NetApp CI","commit_id":"fbe7185dde325e71ca6e8d6c59e5623b9e0a02c0"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"06a59855def28d0dd9417e057ae68fb7bcc85266","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"81abe456_0d51d17e","updated":"2022-02-10 13:25:58.000000000","message":"run-NetApp CI","commit_id":"e0c1ba0e360832bac9bb39b9d54a3c9cb4504698"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"2d33870413e99303bfb5dd3d5b97b13104ff162b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"32222c1d_048b9e88","updated":"2022-02-11 03:36:15.000000000","message":"run-NetApp CI","commit_id":"4d3d9500407e7b83d79090a114b83138041127c0"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"21117e85647c656a5af3edfeabbbbadccda423df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"333bb5bb_f72ef51f","updated":"2022-02-10 22:08:57.000000000","message":"run-NetApp CI","commit_id":"4d3d9500407e7b83d79090a114b83138041127c0"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"d8fd9b06bfe8877f0f72fbb7cc5bf9de9988addd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"96943816_935ce109","updated":"2022-02-10 19:00:29.000000000","message":"run-NetApp CI","commit_id":"4d3d9500407e7b83d79090a114b83138041127c0"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"9d3ab3931730c72e1d5c5e4ba8147ee214d4cefc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a39a8f36_24a89812","updated":"2022-02-11 00:11:11.000000000","message":"run-NetApp CI","commit_id":"4d3d9500407e7b83d79090a114b83138041127c0"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"6b0bdce445fbea1dfff0988bdc7f9cd0eb1ee69f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a544bc78_d139739c","updated":"2022-02-10 13:48:05.000000000","message":"run-NetApp CI","commit_id":"4d3d9500407e7b83d79090a114b83138041127c0"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"ec09ec23b86aeb72b3e4d8f712f37607df0faaeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c1db491e_53eb30a9","updated":"2022-02-11 04:08:57.000000000","message":"run-NetApp CI","commit_id":"4d3d9500407e7b83d79090a114b83138041127c0"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"1ee536b2bd0d2a3d30e6b6f12a71865a14ea1919","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ff4392f2_aff68fb5","updated":"2022-02-11 04:02:31.000000000","message":"run-NetApp CI","commit_id":"4d3d9500407e7b83d79090a114b83138041127c0"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"351a2aebd163d32109e9c6b86f8c25f6c245d5ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1c829824_7270b837","updated":"2022-02-11 04:41:45.000000000","message":"run-NetApp CI","commit_id":"a0c82b035126033ef33b34e52c167c92fb1c5ac6"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"cd90266f2e74eeefbefbc52882ee6836a5c50c6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d84ecb5e_222bfb03","updated":"2022-02-11 11:14:00.000000000","message":"run-NetApp CI","commit_id":"a0c82b035126033ef33b34e52c167c92fb1c5ac6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"eb63b6b46fea1c517b4c9d6bdb15f84fe2a1c2d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"f47cf7d5_32093cdc","updated":"2022-02-23 23:02:33.000000000","message":"Change looks well written, Fernando!\nThanks for working on it\nAdded few comments inline, please check them :)","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"03f179b668fbcee6dfc572ab1adcf0a96c5c92e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"31f4529b_d2da1d61","updated":"2022-02-23 20:01:46.000000000","message":"Looks good, some questions inline.","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"0cdc9e9e16f79832927a2c04e41162e0517970bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"dfff9631_9862fe89","updated":"2022-02-26 07:18:47.000000000","message":"recheck\n\nZuul went offline halfway through job execution.","commit_id":"e98d72a0b6b62053ec22dcc83832d075ab1b3bca"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"5a9fdf1ee1e9b683541fce45a9be85bab23ea8dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"c39aac9a_866a899d","updated":"2022-02-28 13:22:54.000000000","message":"run-NetApp CI","commit_id":"93822d46ed800691b173d8e782fba836be985455"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c2cbe1c218397008dcced0fdc97712d80560a116","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"0f193529_be63bdaf","updated":"2022-03-02 20:42:15.000000000","message":"Looking good, thanks for the enhancements","commit_id":"faa706cbf3f518d7a7647b0469addf5385d6ec11"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8bc346cfa0abf4d65cf3c2d351c4a2f0d7f5113a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"38c15ba4_703a7f1c","updated":"2022-03-03 21:36:26.000000000","message":"Can\u0027t spot any other issue in the code. \nThere are a couple of networking functions that were refactored in order to implement this features, which is dangerous since it can bring some regression. In other hand, NetApp CI has a good test coverage in its CI which is also testing this new feature here [1]\n\n[1] https://netappopenstacklogserver.s3-us-west-1.amazonaws.com/logs/59/826959/13/upstream-check/manila-cDOT-manila-tempest-plugin-ss/217620b/console.html.txt\n\nStill watching for new test run with latest patch sets. Thanks","commit_id":"e3c12b49f5837bca6a4270071741115b78fcc00d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cf692762718aa67ce812ac91b0bead0f31236472","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"0cd853a2_adc0ed7b","updated":"2022-03-04 12:45:55.000000000","message":"LGTM and NetApp CI is happy.\nThanks!","commit_id":"e3c12b49f5837bca6a4270071741115b78fcc00d"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"eb63b6b46fea1c517b4c9d6bdb15f84fe2a1c2d0","unresolved":true,"context_lines":[{"line_number":974,"context_line":"        \"\"\"Checks if LIF exists.\"\"\""},{"line_number":975,"context_line":"        if not home_port:"},{"line_number":976,"context_line":"            home_port \u003d (port if not vlan else"},{"line_number":977,"context_line":"                         \u0027%(port)s-%(tag)s\u0027 % {\u0027port\u0027: port, \u0027tag\u0027: vlan})"},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"        api_args \u003d {"},{"line_number":980,"context_line":"            \u0027query\u0027: {"}],"source_content_type":"text/x-python","patch_set":16,"id":"81230e50_6aaee3f3","line":977,"range":{"start_line":977,"start_character":25,"end_line":977,"end_character":43},"updated":"2022-02-23 23:02:33.000000000","message":"you could use f strings here:\nf\u0027{port}-{tag}\u0027","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"94e88786a050f85655ac2f6d8fca51f74057e675","unresolved":false,"context_lines":[{"line_number":974,"context_line":"        \"\"\"Checks if LIF exists.\"\"\""},{"line_number":975,"context_line":"        if not home_port:"},{"line_number":976,"context_line":"            home_port \u003d (port if not vlan else"},{"line_number":977,"context_line":"                         \u0027%(port)s-%(tag)s\u0027 % {\u0027port\u0027: port, \u0027tag\u0027: vlan})"},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"        api_args \u003d {"},{"line_number":980,"context_line":"            \u0027query\u0027: {"}],"source_content_type":"text/x-python","patch_set":16,"id":"5c17b659_fc029d1c","line":977,"range":{"start_line":977,"start_character":25,"end_line":977,"end_character":43},"in_reply_to":"81230e50_6aaee3f3","updated":"2022-02-28 20:37:17.000000000","message":"Done","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"03f179b668fbcee6dfc572ab1adcf0a96c5c92e6","unresolved":true,"context_lines":[{"line_number":326,"context_line":"                                   enable_nfs\u003dTrue, security_services\u003dNone,"},{"line_number":327,"context_line":"                                   nfs_config\u003dNone):"},{"line_number":328,"context_line":"        \"\"\"Setup Vserver network configuration\"\"\""},{"line_number":329,"context_line":"        # segmentation_id and mtu are the same for all allocations at"},{"line_number":330,"context_line":"        # this point so it can be extracted from the first index"},{"line_number":331,"context_line":"        ref_allocation \u003d network_info[0][\u0027network_allocations\u0027][0]"},{"line_number":332,"context_line":"        vlan \u003d ref_allocation[\u0027segmentation_id\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"2a3fe985_45fc79bf","line":329,"range":{"start_line":329,"start_character":30,"end_line":329,"end_character":33},"updated":"2022-02-23 20:01:46.000000000","message":"is there a mtu validation? or it is guaranteed by the driver\u0027s code?","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"9f843ff8d87bada7ac75a0394455d8dcb99efb06","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                                   enable_nfs\u003dTrue, security_services\u003dNone,"},{"line_number":327,"context_line":"                                   nfs_config\u003dNone):"},{"line_number":328,"context_line":"        \"\"\"Setup Vserver network configuration\"\"\""},{"line_number":329,"context_line":"        # segmentation_id and mtu are the same for all allocations at"},{"line_number":330,"context_line":"        # this point so it can be extracted from the first index"},{"line_number":331,"context_line":"        ref_allocation \u003d network_info[0][\u0027network_allocations\u0027][0]"},{"line_number":332,"context_line":"        vlan \u003d ref_allocation[\u0027segmentation_id\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"ae49c3ce_04edda31","line":329,"range":{"start_line":329,"start_character":30,"end_line":329,"end_character":33},"in_reply_to":"2a3fe985_45fc79bf","updated":"2022-03-02 06:03:18.000000000","message":"Acctually it is guaranteed by the fact that driver\u0027s code ensure all subnets are in the same network segmentation and consequently belongs to a same Neutron network as Neutron blocks creation of Neutron networks with duplicate provider segment values. I\u0027ve changed the comment to include this information.","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8bc346cfa0abf4d65cf3c2d351c4a2f0d7f5113a","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                                   enable_nfs\u003dTrue, security_services\u003dNone,"},{"line_number":327,"context_line":"                                   nfs_config\u003dNone):"},{"line_number":328,"context_line":"        \"\"\"Setup Vserver network configuration\"\"\""},{"line_number":329,"context_line":"        # segmentation_id and mtu are the same for all allocations at"},{"line_number":330,"context_line":"        # this point so it can be extracted from the first index"},{"line_number":331,"context_line":"        ref_allocation \u003d network_info[0][\u0027network_allocations\u0027][0]"},{"line_number":332,"context_line":"        vlan \u003d ref_allocation[\u0027segmentation_id\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"8f1bc903_50fc0fe6","line":329,"range":{"start_line":329,"start_character":30,"end_line":329,"end_character":33},"in_reply_to":"ae49c3ce_04edda31","updated":"2022-03-03 21:36:26.000000000","message":"You are right, mtu is a layer-2 property and you guarantee that they are in the same segment, so it is ok. Thanks","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"eb63b6b46fea1c517b4c9d6bdb15f84fe2a1c2d0","unresolved":true,"context_lines":[{"line_number":491,"context_line":"                vserver_name, node_name, port, ip_address, netmask, vlan,"},{"line_number":492,"context_line":"                home_port\u003dlif_home_port):"},{"line_number":493,"context_line":"            msg \u003d (\u0027LIF %(ip)s netmask %(mask)s already exists for \u0027"},{"line_number":494,"context_line":"                   \u0027node %(node)s port %(port)s vserver %(vserver)s.\u0027 % {"},{"line_number":495,"context_line":"                       \u0027ip\u0027: ip_address,"},{"line_number":496,"context_line":"                       \u0027mask\u0027: netmask,"},{"line_number":497,"context_line":"                       \u0027node\u0027: node_name,"}],"source_content_type":"text/x-python","patch_set":16,"id":"5cd64e68_0b944c85","line":494,"range":{"start_line":494,"start_character":47,"end_line":494,"end_character":55},"updated":"2022-02-23 23:02:33.000000000","message":"nit: in the vserver","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"94e88786a050f85655ac2f6d8fca51f74057e675","unresolved":false,"context_lines":[{"line_number":491,"context_line":"                vserver_name, node_name, port, ip_address, netmask, vlan,"},{"line_number":492,"context_line":"                home_port\u003dlif_home_port):"},{"line_number":493,"context_line":"            msg \u003d (\u0027LIF %(ip)s netmask %(mask)s already exists for \u0027"},{"line_number":494,"context_line":"                   \u0027node %(node)s port %(port)s vserver %(vserver)s.\u0027 % {"},{"line_number":495,"context_line":"                       \u0027ip\u0027: ip_address,"},{"line_number":496,"context_line":"                       \u0027mask\u0027: netmask,"},{"line_number":497,"context_line":"                       \u0027node\u0027: node_name,"}],"source_content_type":"text/x-python","patch_set":16,"id":"8a5a58ec_dcabca88","line":494,"range":{"start_line":494,"start_character":47,"end_line":494,"end_character":55},"in_reply_to":"5cd64e68_0b944c85","updated":"2022-02-28 20:37:17.000000000","message":"Done","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"eb63b6b46fea1c517b4c9d6bdb15f84fe2a1c2d0","unresolved":true,"context_lines":[{"line_number":2166,"context_line":"                    return False"},{"line_number":2167,"context_line":"        return True"},{"line_number":2168,"context_line":""},{"line_number":2169,"context_line":"    def check_update_share_server_network_allocations("},{"line_number":2170,"context_line":"            self, context, share_server, current_network_allocations,"},{"line_number":2171,"context_line":"            added_subnet, security_services, share_instances,"},{"line_number":2172,"context_line":"            share_instances_rules):"}],"source_content_type":"text/x-python","patch_set":16,"id":"5625e7b0_0340059d","line":2169,"range":{"start_line":2169,"start_character":4,"end_line":2169,"end_character":54},"updated":"2022-02-23 23:02:33.000000000","message":"This and the below methods are not being covered by unit tests. Could you please add some?","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"9f843ff8d87bada7ac75a0394455d8dcb99efb06","unresolved":false,"context_lines":[{"line_number":2166,"context_line":"                    return False"},{"line_number":2167,"context_line":"        return True"},{"line_number":2168,"context_line":""},{"line_number":2169,"context_line":"    def check_update_share_server_network_allocations("},{"line_number":2170,"context_line":"            self, context, share_server, current_network_allocations,"},{"line_number":2171,"context_line":"            added_subnet, security_services, share_instances,"},{"line_number":2172,"context_line":"            share_instances_rules):"}],"source_content_type":"text/x-python","patch_set":16,"id":"6a2cabf9_aa904cf4","line":2169,"range":{"start_line":2169,"start_character":4,"end_line":2169,"end_character":54},"in_reply_to":"4e7ce199_6d53db9b","updated":"2022-03-02 06:03:18.000000000","message":"Done.","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"94e88786a050f85655ac2f6d8fca51f74057e675","unresolved":true,"context_lines":[{"line_number":2166,"context_line":"                    return False"},{"line_number":2167,"context_line":"        return True"},{"line_number":2168,"context_line":""},{"line_number":2169,"context_line":"    def check_update_share_server_network_allocations("},{"line_number":2170,"context_line":"            self, context, share_server, current_network_allocations,"},{"line_number":2171,"context_line":"            added_subnet, security_services, share_instances,"},{"line_number":2172,"context_line":"            share_instances_rules):"}],"source_content_type":"text/x-python","patch_set":16,"id":"4e7ce199_6d53db9b","line":2169,"range":{"start_line":2169,"start_character":4,"end_line":2169,"end_character":54},"in_reply_to":"5625e7b0_0340059d","updated":"2022-02-28 20:37:17.000000000","message":"working on it 😊","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"03f179b668fbcee6dfc572ab1adcf0a96c5c92e6","unresolved":true,"context_lines":[{"line_number":2176,"context_line":"        # extract segmentation_id from allocations as subnet validation"},{"line_number":2177,"context_line":"        # consists in checking if all subnets have the same segmentation_id"},{"line_number":2178,"context_line":"        network_segments \u003d []"},{"line_number":2179,"context_line":"        for subnet in current_network_allocations[\u0027subnets\u0027]:"},{"line_number":2180,"context_line":"            # Get the segmentation_id from the first allocation per subnet"},{"line_number":2181,"context_line":"            # since they all correspond to a same subnet configuration"},{"line_number":2182,"context_line":"            seg_id \u003d subnet[\u0027network_allocations\u0027][0][\u0027segmentation_id\u0027]"},{"line_number":2183,"context_line":"            network_segments.append({\u0027segmentation_id\u0027: seg_id})"},{"line_number":2184,"context_line":"        network_segments.append("},{"line_number":2185,"context_line":"            {\u0027segmentation_id\u0027: added_subnet[\u0027segmentation_id\u0027]})"},{"line_number":2186,"context_line":""},{"line_number":2187,"context_line":"        is_valid_configuration \u003d True"},{"line_number":2188,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":16,"id":"eb10b588_13d9a6e3","line":2185,"range":{"start_line":2179,"start_character":0,"end_line":2185,"end_character":65},"updated":"2022-02-23 20:01:46.000000000","message":"nit: `subnet[\u0027network_allocations\u0027][0][\u0027segmentation_id\u0027] !\u003d added_subnet[\u0027segmentation_id\u0027]` should be enough right? but it is also ok to check all","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"9f843ff8d87bada7ac75a0394455d8dcb99efb06","unresolved":false,"context_lines":[{"line_number":2176,"context_line":"        # extract segmentation_id from allocations as subnet validation"},{"line_number":2177,"context_line":"        # consists in checking if all subnets have the same segmentation_id"},{"line_number":2178,"context_line":"        network_segments \u003d []"},{"line_number":2179,"context_line":"        for subnet in current_network_allocations[\u0027subnets\u0027]:"},{"line_number":2180,"context_line":"            # Get the segmentation_id from the first allocation per subnet"},{"line_number":2181,"context_line":"            # since they all correspond to a same subnet configuration"},{"line_number":2182,"context_line":"            seg_id \u003d subnet[\u0027network_allocations\u0027][0][\u0027segmentation_id\u0027]"},{"line_number":2183,"context_line":"            network_segments.append({\u0027segmentation_id\u0027: seg_id})"},{"line_number":2184,"context_line":"        network_segments.append("},{"line_number":2185,"context_line":"            {\u0027segmentation_id\u0027: added_subnet[\u0027segmentation_id\u0027]})"},{"line_number":2186,"context_line":""},{"line_number":2187,"context_line":"        is_valid_configuration \u003d True"},{"line_number":2188,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":16,"id":"efc9bbdc_3c05e04a","line":2185,"range":{"start_line":2179,"start_character":0,"end_line":2185,"end_character":65},"in_reply_to":"eb10b588_13d9a6e3","updated":"2022-03-02 06:03:18.000000000","message":"I\u0027ve changed the code a bit to validate only a single segmentation id from current allocations instead of the entire list as all current subnets have the same segmentation_id. Function _validate_share_network_subnets will now only compare the segmentation id from current allocation at the index 0 and  from the added subnet.","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"03f179b668fbcee6dfc572ab1adcf0a96c5c92e6","unresolved":true,"context_lines":[{"line_number":2225,"context_line":"                admin_addresses\u003d[])"},{"line_number":2226,"context_line":""},{"line_number":2227,"context_line":"            export_locations \u003d [{"},{"line_number":2228,"context_line":"                \u0027path\u0027: \u0027%s:%s\u0027 % (export_address, export_path),"},{"line_number":2229,"context_line":"                \u0027is_admin_only\u0027: metadata.pop(\u0027is_admin_only\u0027, False),"},{"line_number":2230,"context_line":"                \u0027metadata\u0027: metadata,"},{"line_number":2231,"context_line":"            } for export_address, metadata in copy.deepcopy("}],"source_content_type":"text/x-python","patch_set":16,"id":"3e4e7c1b_b6e0d974","line":2228,"range":{"start_line":2228,"start_character":24,"end_line":2228,"end_character":64},"updated":"2022-02-23 20:01:46.000000000","message":"This is only valid for NFS. Will this feature work with both NFS and CIFS?\nYou will need to use protocol helper to generate that info for you.","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"eb63b6b46fea1c517b4c9d6bdb15f84fe2a1c2d0","unresolved":true,"context_lines":[{"line_number":2225,"context_line":"                admin_addresses\u003d[])"},{"line_number":2226,"context_line":""},{"line_number":2227,"context_line":"            export_locations \u003d [{"},{"line_number":2228,"context_line":"                \u0027path\u0027: \u0027%s:%s\u0027 % (export_address, export_path),"},{"line_number":2229,"context_line":"                \u0027is_admin_only\u0027: metadata.pop(\u0027is_admin_only\u0027, False),"},{"line_number":2230,"context_line":"                \u0027metadata\u0027: metadata,"},{"line_number":2231,"context_line":"            } for export_address, metadata in copy.deepcopy("}],"source_content_type":"text/x-python","patch_set":16,"id":"602099f5_57b07472","line":2228,"range":{"start_line":2228,"start_character":24,"end_line":2228,"end_character":64},"in_reply_to":"3e4e7c1b_b6e0d974","updated":"2022-02-23 23:02:33.000000000","message":"++","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"94e88786a050f85655ac2f6d8fca51f74057e675","unresolved":false,"context_lines":[{"line_number":2225,"context_line":"                admin_addresses\u003d[])"},{"line_number":2226,"context_line":""},{"line_number":2227,"context_line":"            export_locations \u003d [{"},{"line_number":2228,"context_line":"                \u0027path\u0027: \u0027%s:%s\u0027 % (export_address, export_path),"},{"line_number":2229,"context_line":"                \u0027is_admin_only\u0027: metadata.pop(\u0027is_admin_only\u0027, False),"},{"line_number":2230,"context_line":"                \u0027metadata\u0027: metadata,"},{"line_number":2231,"context_line":"            } for export_address, metadata in copy.deepcopy("}],"source_content_type":"text/x-python","patch_set":16,"id":"796e7521_fde61393","line":2228,"range":{"start_line":2228,"start_character":24,"end_line":2228,"end_character":64},"in_reply_to":"4e0ac3c1_12200c2a","updated":"2022-02-28 20:37:17.000000000","message":"Fixed by using an already existent _create_export function as it already use the proper helpers to build the correct path for the export location.","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"5a9fdf1ee1e9b683541fce45a9be85bab23ea8dd","unresolved":false,"context_lines":[{"line_number":2225,"context_line":"                admin_addresses\u003d[])"},{"line_number":2226,"context_line":""},{"line_number":2227,"context_line":"            export_locations \u003d [{"},{"line_number":2228,"context_line":"                \u0027path\u0027: \u0027%s:%s\u0027 % (export_address, export_path),"},{"line_number":2229,"context_line":"                \u0027is_admin_only\u0027: metadata.pop(\u0027is_admin_only\u0027, False),"},{"line_number":2230,"context_line":"                \u0027metadata\u0027: metadata,"},{"line_number":2231,"context_line":"            } for export_address, metadata in copy.deepcopy("}],"source_content_type":"text/x-python","patch_set":16,"id":"4e0ac3c1_12200c2a","line":2228,"range":{"start_line":2228,"start_character":24,"end_line":2228,"end_character":64},"in_reply_to":"602099f5_57b07472","updated":"2022-02-28 13:22:54.000000000","message":"Good catch! 😮","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"}],"releasenotes/notes/netapp-multiple-subnets-support-274a37c5ddb43ca1.yaml":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"03f179b668fbcee6dfc572ab1adcf0a96c5c92e6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP: Add support to multiple subnets per AZ in the same network"},{"line_number":5,"context_line":"    segment."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"c215419d_84a11a17","line":5,"range":{"start_line":4,"start_character":18,"end_line":5,"end_character":12},"updated":"2022-02-23 20:01:46.000000000","message":"Maybe give more details that driver now supports adding new share network subnets to in-use share networks.","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"9f843ff8d87bada7ac75a0394455d8dcb99efb06","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP: Add support to multiple subnets per AZ in the same network"},{"line_number":5,"context_line":"    segment."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"c1285aea_54edded4","line":5,"range":{"start_line":4,"start_character":18,"end_line":5,"end_character":12},"in_reply_to":"38ff34ac_7fffc710","updated":"2022-03-02 06:03:18.000000000","message":"I\u0027ve include the possibility of updating in-use share servers. Please let me know if you guys think it\u0027s still missing important information.","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"eb63b6b46fea1c517b4c9d6bdb15f84fe2a1c2d0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP: Add support to multiple subnets per AZ in the same network"},{"line_number":5,"context_line":"    segment."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"38ff34ac_7fffc710","line":5,"range":{"start_line":4,"start_character":18,"end_line":5,"end_character":12},"in_reply_to":"c215419d_84a11a17","updated":"2022-02-23 23:02:33.000000000","message":"++","commit_id":"12810c5de9958dabbdcce7cad0c57d7855d81003"}]}