)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a305e505c6c9492db5b0012c69e4c6eb03f06a4","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     silvacarloss \u003cces.eduardo98@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-11 09:45:33 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Change manila generated key type to ecsda"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib2f1043e8cd3a41ff02501763d3b5c47980a84f0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ae605945_a591bc37","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":47},"updated":"2022-02-17 18:14:30.000000000","message":"ecdsa","commit_id":"f58af57ff28fc110f21c5d7b976ca91fcaa81358"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fcb3b05977b78178d2bf77ef4370b07c8341db8b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     silvacarloss \u003cces.eduardo98@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-11 09:45:33 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Change manila generated key type to ecsda"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib2f1043e8cd3a41ff02501763d3b5c47980a84f0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"185a8f21_682a9c0e","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":47},"in_reply_to":"ae605945_a591bc37","updated":"2022-04-28 12:28:07.000000000","message":"Done","commit_id":"f58af57ff28fc110f21c5d7b976ca91fcaa81358"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9bf0750d36c88b38e0381dd6f91d3fc0154d51a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d958f954_5555ff17","updated":"2022-04-28 14:48:28.000000000","message":"Issues in the Ceph NFS job are possibly caused by this change - Will investigate further","commit_id":"f4926143cee75ea2e95c69e0483d635a887a975a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fcb3b05977b78178d2bf77ef4370b07c8341db8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"720d9788_5943ee3b","updated":"2022-04-28 12:28:07.000000000","message":"Thank you for the review, Goutham!\nPlease check the changes and the other question inline","commit_id":"f4926143cee75ea2e95c69e0483d635a887a975a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"49913273512dc0c037947162be4c470246820d1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"708b8289_6811708d","updated":"2022-04-29 12:17:07.000000000","message":"recheck\nGetting some more confirmation logs for this","commit_id":"f4926143cee75ea2e95c69e0483d635a887a975a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a8381aa78a009e4d403c5f83adf2a7199ff24cc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8f1b810f_e4ed4d6d","updated":"2022-05-03 12:27:52.000000000","message":"recheck\nGeneric failing while trying to connect to the DB - Issue that usually occurs when the machine gets out of memory\nCEPH NFS failing due to a timeout in create extend and write test","commit_id":"564cf3539da325a85ddba8aa832c0208030db44d"}],"manila/share/drivers/service_instance.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a305e505c6c9492db5b0012c69e4c6eb03f06a4","unresolved":true,"context_lines":[{"line_number":59,"context_line":"             \"instances. Only used if driver_handles_share_servers\u003dTrue.\"),"},{"line_number":60,"context_line":"    cfg.StrOpt("},{"line_number":61,"context_line":"        \"path_to_public_key\","},{"line_number":62,"context_line":"        default\u003d\"~/.ssh/id_ecdsa.pub\","},{"line_number":63,"context_line":"        help\u003d\"Path to hosts public key. \""},{"line_number":64,"context_line":"             \"Only used if driver_handles_share_servers\u003dTrue.\"),"},{"line_number":65,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"6de74aa4_4b0f79d5","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":38},"updated":"2022-02-17 18:14:30.000000000","message":"this needs to be called out in the release notes - it has a pretty huge upgrade impact in case there\u0027s no \"id_ecdsa.pub\" in an existing deployment","commit_id":"f58af57ff28fc110f21c5d7b976ca91fcaa81358"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fcb3b05977b78178d2bf77ef4370b07c8341db8b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"             \"instances. Only used if driver_handles_share_servers\u003dTrue.\"),"},{"line_number":60,"context_line":"    cfg.StrOpt("},{"line_number":61,"context_line":"        \"path_to_public_key\","},{"line_number":62,"context_line":"        default\u003d\"~/.ssh/id_ecdsa.pub\","},{"line_number":63,"context_line":"        help\u003d\"Path to hosts public key. \""},{"line_number":64,"context_line":"             \"Only used if driver_handles_share_servers\u003dTrue.\"),"},{"line_number":65,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"f6ffd80a_3f1764df","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":38},"in_reply_to":"6de74aa4_4b0f79d5","updated":"2022-04-28 12:28:07.000000000","message":"Done","commit_id":"f58af57ff28fc110f21c5d7b976ca91fcaa81358"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fcb3b05977b78178d2bf77ef4370b07c8341db8b","unresolved":true,"context_lines":[{"line_number":236,"context_line":"            \u0027backend_availability_zone\u0027) or CONF.storage_availability_zone"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        if self.get_config_option(\"driver_handles_share_servers\"):"},{"line_number":239,"context_line":"            ecdsa_key_exists \u003d os.path.exists("},{"line_number":240,"context_line":"                os.path.expanduser(default_path_to_ecdsa_key))"},{"line_number":241,"context_line":"            self.path_to_public_key \u003d ("},{"line_number":242,"context_line":"                default_path_to_ecdsa_key"},{"line_number":243,"context_line":"                if ecdsa_key_exists"}],"source_content_type":"text/x-python","patch_set":4,"id":"251fa433_ca51d966","line":240,"range":{"start_line":239,"start_character":12,"end_line":240,"end_character":62},"updated":"2022-04-28 12:28:07.000000000","message":"@Goutham, I need a second opinion on this :)\nThe thing is... I\u0027m defaulting to look for an ECDSA key here, but something could happen:\nThe user has a rsa key alongside the ecdsa in the same directory and prefer that the RSA key is used.\nThis would end up using the wrong key. Should we have a way to let users chose what key type they want to use?","commit_id":"f4926143cee75ea2e95c69e0483d635a887a975a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"34128674b692ff8e95cf31af75b037c2dae39d6d","unresolved":true,"context_lines":[{"line_number":236,"context_line":"            \u0027backend_availability_zone\u0027) or CONF.storage_availability_zone"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        if self.get_config_option(\"driver_handles_share_servers\"):"},{"line_number":239,"context_line":"            ecdsa_key_exists \u003d os.path.exists("},{"line_number":240,"context_line":"                os.path.expanduser(default_path_to_ecdsa_key))"},{"line_number":241,"context_line":"            self.path_to_public_key \u003d ("},{"line_number":242,"context_line":"                default_path_to_ecdsa_key"},{"line_number":243,"context_line":"                if ecdsa_key_exists"}],"source_content_type":"text/x-python","patch_set":4,"id":"c7917d05_e0dc4861","line":240,"range":{"start_line":239,"start_character":12,"end_line":240,"end_character":62},"in_reply_to":"251fa433_ca51d966","updated":"2022-04-28 18:33:52.000000000","message":"yes, this should be the other way around... if the option isn\u0027t overridden, we should try to find the edcsa key and if that\u0027s not found, the id_rsa key.. \n\nbut, my concern is also that - for existing share servers, we will need to use the same key we set the servers up with... is it possible for you to check at driver startup if there are any existing shares to preserve the old default in case there is no override?","commit_id":"f4926143cee75ea2e95c69e0483d635a887a975a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8a2a1102a9f5e31af94241bf127d212ac416ef60","unresolved":true,"context_lines":[{"line_number":236,"context_line":"            \u0027backend_availability_zone\u0027) or CONF.storage_availability_zone"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        if self.get_config_option(\"driver_handles_share_servers\"):"},{"line_number":239,"context_line":"            ecdsa_key_exists \u003d os.path.exists("},{"line_number":240,"context_line":"                os.path.expanduser(default_path_to_ecdsa_key))"},{"line_number":241,"context_line":"            self.path_to_public_key \u003d ("},{"line_number":242,"context_line":"                default_path_to_ecdsa_key"},{"line_number":243,"context_line":"                if ecdsa_key_exists"}],"source_content_type":"text/x-python","patch_set":4,"id":"97771234_eb3c13fb","line":240,"range":{"start_line":239,"start_character":12,"end_line":240,"end_character":62},"in_reply_to":"c7917d05_e0dc4861","updated":"2022-04-28 20:26:11.000000000","message":"I think it would be possible... I\u0027ve considered the following scenarios:\n1) Retrieving instances through the database\nFor this to happen we\u0027d need to perform calls to the database from the driver layer (which is not ideal considering all the driver implementations we have).\nWe\u0027d also need the current host to filter the share servers in Manila (which is something we currently don\u0027t have access to in this layer).\n\n2) Listing nova instances\nThis would be fine too - I would need to query for nova instances and check if there is any instance with the `service_image_name` set to the value that is currently configured\n\n3) Looking for ports in neutron\nAs we create ports in Neutron and add a manila tag to them, we could filter ports, but we\u0027d need network information as well.\n\nSo at the end we will:\ncheck if there are share servers built.\nIf there are, use the default key value without even checking other things\nIf there isn\u0027t, search for an ecdsa key\nIf no ecdsa key is there, we can fall back to the rsa\n\nI have a sense that option 2 would be our best scenario here - the only problem is if in some way the admin created instances manually using the Manila image - which I think wouldn\u0027t be the case.\nWdyt?","commit_id":"f4926143cee75ea2e95c69e0483d635a887a975a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a2a0ee52f88a69ab416d9cdbf50a1fde7dc9c78c","unresolved":true,"context_lines":[{"line_number":240,"context_line":"            # be almost the same as the private except for the .pub at the end"},{"line_number":241,"context_line":"            # of the file name"},{"line_number":242,"context_line":"            if self.path_to_private_key:"},{"line_number":243,"context_line":"                path_to_public_key \u003d self.path_to_private_key + \u0027.pub\u0027"},{"line_number":244,"context_line":"                self.path_to_public_key \u003d path_to_public_key"},{"line_number":245,"context_line":"            else:"},{"line_number":246,"context_line":"                self.path_to_public_key \u003d self.get_config_option("}],"source_content_type":"text/x-python","patch_set":7,"id":"be2c74cb_7295e879","line":243,"updated":"2022-05-24 20:30:35.000000000","message":"this change seems unnecessary...","commit_id":"0cf723f94f92fe8e0bf7e0a8831b233f61a42c1a"}],"releasenotes/notes/change-default-key-to-ecdsa-a868124c05bdcc77.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a2a0ee52f88a69ab416d9cdbf50a1fde7dc9c78c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Path to hosts public key now must be set if"},{"line_number":5,"context_line":"    driver_handles_share_servers\u003dTrue. Otherwise it will use the public keys"},{"line_number":6,"context_line":"    of the automatically generated private key."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"593a4a86_2f7a3d2b","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":47},"updated":"2022-05-24 20:30:35.000000000","message":"1) This is only applicable to any driver using the \"service_instance\" module.. \n2) From what i can see, we don\u0027t create SSH keys in manila, we always expect it to be configured... \n\nam i mistaken?","commit_id":"0cf723f94f92fe8e0bf7e0a8831b233f61a42c1a"}]}