)]}'
{"manila/share/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"069391bc1e4dfd9bb0e96441c72bcab4d1b66f92","unresolved":true,"context_lines":[{"line_number":373,"context_line":"            QUOTAS.commit(context, reservations, share_type_id\u003dshare_type_id)"},{"line_number":374,"context_line":"        except Exception:"},{"line_number":375,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":376,"context_line":"                if share:"},{"line_number":377,"context_line":"                    try:"},{"line_number":378,"context_line":"                        self.db.share_delete(context, share[\u0027id\u0027])"},{"line_number":379,"context_line":"                    finally:"},{"line_number":380,"context_line":"                        _rollback_share_quotas()"},{"line_number":381,"context_line":"                else:"},{"line_number":382,"context_line":"                    _rollback_share_quotas()"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        self.save_scheduler_hints(context, share, scheduler_hints)"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b822763c_611f6ce1","line":382,"range":{"start_line":376,"start_character":16,"end_line":382,"end_character":44},"updated":"2022-03-08 19:31:27.000000000","message":"Would this work?\n\n  try:\n      self.db.share_delete(context, share[\u0027id\u0027])\n  except TypeError, KeyError:\n    # share db object wasn\u0027t created properly\n    pass\n\n  _rollback_share_quotas()","commit_id":"2e997fe60039e68f1739968afc901bf467bcf2ed"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f3b35f3192e79bde393476904315251ce8ed1f5f","unresolved":true,"context_lines":[{"line_number":373,"context_line":"            QUOTAS.commit(context, reservations, share_type_id\u003dshare_type_id)"},{"line_number":374,"context_line":"        except Exception:"},{"line_number":375,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":376,"context_line":"                if share:"},{"line_number":377,"context_line":"                    try:"},{"line_number":378,"context_line":"                        self.db.share_delete(context, share[\u0027id\u0027])"},{"line_number":379,"context_line":"                    finally:"},{"line_number":380,"context_line":"                        _rollback_share_quotas()"},{"line_number":381,"context_line":"                else:"},{"line_number":382,"context_line":"                    _rollback_share_quotas()"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        self.save_scheduler_hints(context, share, scheduler_hints)"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4e0631a9_2cf996de","line":382,"range":{"start_line":376,"start_character":16,"end_line":382,"end_character":44},"in_reply_to":"a5047463_a401e762","updated":"2022-03-09 23:59:14.000000000","message":"\u003e if DB insert failed, share will be None(defined in line 364). will not exec db.share_delete(). and then\n++... that\u0027s exactly why I\u0027m checking if there\u0027s a share","commit_id":"2e997fe60039e68f1739968afc901bf467bcf2ed"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"4f0a82bd092d34dc2e0ec09ff737b08e3036f6c4","unresolved":true,"context_lines":[{"line_number":373,"context_line":"            QUOTAS.commit(context, reservations, share_type_id\u003dshare_type_id)"},{"line_number":374,"context_line":"        except Exception:"},{"line_number":375,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":376,"context_line":"                if share:"},{"line_number":377,"context_line":"                    try:"},{"line_number":378,"context_line":"                        self.db.share_delete(context, share[\u0027id\u0027])"},{"line_number":379,"context_line":"                    finally:"},{"line_number":380,"context_line":"                        _rollback_share_quotas()"},{"line_number":381,"context_line":"                else:"},{"line_number":382,"context_line":"                    _rollback_share_quotas()"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        self.save_scheduler_hints(context, share, scheduler_hints)"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a5047463_a401e762","line":382,"range":{"start_line":376,"start_character":16,"end_line":382,"end_character":44},"in_reply_to":"b822763c_611f6ce1","updated":"2022-03-09 07:48:53.000000000","message":"if share is not None here, that means DB insert successed. if DB insert failed, share will be None(defined in line 364). will not exec db.share_delete(). and then\nwill not get TypeError or KeyError. i think this will work.","commit_id":"2e997fe60039e68f1739968afc901bf467bcf2ed"}]}