)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"0ecaf812d3bd941e63f2e8f8854ba50e9c499594","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b47dd9d8_cf5a3e0c","updated":"2022-02-23 19:07:46.000000000","message":"Code looks good. I\u0027m afraid I don\u0027t have a glusterfs env to test this and, for what I checked, it is not being run in the CI.","commit_id":"9d868a2432bcee212c9f6f4b54b04255520ed172"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"829a4f64718f213b513f6db7d5b3a4f9fe4f1c46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cc895be5_d911c57a","updated":"2022-02-25 23:39:10.000000000","message":"Thank you for working on this refactor","commit_id":"9d868a2432bcee212c9f6f4b54b04255520ed172"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"11dbf058e413ab2cebad348b6b1b0270880b8c95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9538972b_e685adf6","updated":"2022-02-15 18:45:48.000000000","message":"recheck","commit_id":"9d868a2432bcee212c9f6f4b54b04255520ed172"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"915513e972cd025803bea23f556579e5ad6dc928","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c5e067bb_3a2de8dd","in_reply_to":"b47dd9d8_cf5a3e0c","updated":"2022-02-24 17:57:14.000000000","message":"Victoria, we don\u0027t need gluster to test this. This change only affects unit tests, and we\u0027re seeing good results..  Here\u0027s the time it took for this test to run with this change:\n\nhttps://zuul.opendev.org/t/openstack/build/360cbfa272424ea487c07f71faf67c35/log/job-output.txt#6787\nhttps://zuul.opendev.org/t/openstack/build/360cbfa272424ea487c07f71faf67c35/log/job-output.txt#9871\n\n2022-02-15 18:54:31.849515 | ubuntu-bionic | {5} manila.tests.share.drivers.glusterfs.test_common.GlusterManagerTestCase.test_set_vol_option_error_1 [0.042090s] ... ok\n2022-02-15 18:54:49.456926 | ubuntu-bionic | {6} manila.tests.share.drivers.glusterfs.test_common.GlusterManagerTestCase.test_set_vol_option_error_2 [0.036505s] ... ok\n\n\nand without this change:\n\nhttps://zuul.opendev.org/t/openstack/build/a84e0411e85640a1bd5b04d1692f4aa3/log/job-output.txt#19143\nhttps://zuul.opendev.org/t/openstack/build/a84e0411e85640a1bd5b04d1692f4aa3/log/job-output.txt#19237\n\n2022-02-24 12:33:04.812870 | ubuntu-bionic | {2} manila.tests.share.drivers.glusterfs.test_common.GlusterManagerTestCase.test_set_vol_option_error_1 [511.054935s] ... ok\n2022-02-24 12:33:06.424776 | ubuntu-bionic | {6} manila.tests.share.drivers.glusterfs.test_common.GlusterManagerTestCase.test_set_vol_option_error_2 [511.048092s] ... ok","commit_id":"9d868a2432bcee212c9f6f4b54b04255520ed172"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"19c4925e2cbfbb36b1f2ab56926331e7fd58931f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a9443947_bb49c59d","in_reply_to":"c5e067bb_3a2de8dd","updated":"2022-02-24 18:11:15.000000000","message":"Cool, thanks for sharing the output of the test run. I thought that a specific environment was needed for this tests.","commit_id":"9d868a2432bcee212c9f6f4b54b04255520ed172"}]}