)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"6677cd2f89074df391346b18552eb85cf59adbc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"be159b52_8961b37b","updated":"2022-03-23 12:58:03.000000000","message":"Hi, thanks for working on this. My personal taste would be to sort the options alphabetically:  \nreserved_percentage, reserved_share_extend_percentage, reserved_snapshot_percentage but putting the newest one last is also fine with me","commit_id":"72cdc1c86dd23134b8ff7b094f3466bd61508958"},{"author":{"_account_id":34181,"name":"Manish Honap","email":"mmhonap@gmail.com","username":"mhonap"},"change_message_id":"86fb3260f54dd31341b206123c451eb8bd89a530","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fd9ba9fd_1338c5db","updated":"2022-03-23 20:03:16.000000000","message":"Incorporated the suggestions made in patchset 3.\nThank you.","commit_id":"72cdc1c86dd23134b8ff7b094f3466bd61508958"},{"author":{"_account_id":34181,"name":"Manish Honap","email":"mmhonap@gmail.com","username":"mhonap"},"change_message_id":"00842e56db40c8206264322814c5e5cc1f950737","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6a28f939_46864965","updated":"2022-03-11 17:49:16.000000000","message":"recheck","commit_id":"72cdc1c86dd23134b8ff7b094f3466bd61508958"},{"author":{"_account_id":34181,"name":"Manish Honap","email":"mmhonap@gmail.com","username":"mhonap"},"change_message_id":"86fb3260f54dd31341b206123c451eb8bd89a530","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e1834fd6_320e10ed","in_reply_to":"be159b52_8961b37b","updated":"2022-03-23 20:03:16.000000000","message":"ACK.\nI will keep the newest one last.","commit_id":"72cdc1c86dd23134b8ff7b094f3466bd61508958"},{"author":{"_account_id":34181,"name":"Manish Honap","email":"mmhonap@gmail.com","username":"mhonap"},"change_message_id":"668d87db1cd1f4021f0578c2f06508895ccf6017","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ac7475b0_31437666","updated":"2022-04-06 15:01:13.000000000","message":"Gentle reminder for review...","commit_id":"4ad390d8f7dadef458eda9a66d5f920f9a3dc859"},{"author":{"_account_id":34181,"name":"Manish Honap","email":"mmhonap@gmail.com","username":"mhonap"},"change_message_id":"9d0bb55c1d135f6f4b6c3523efd172ac06af0cb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"915b6e39_9b2b1648","updated":"2022-04-20 14:48:54.000000000","message":"Gentle ping for review.","commit_id":"8c67223753d4dee3682a59172782d95856df9260"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b295558721362a1e6a0d533d04f71ddd6ea907bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0ad1f10a_33a0a16f","updated":"2022-04-23 12:56:58.000000000","message":"Goutham/Carlos,\nCan you please review the change ?","commit_id":"8c67223753d4dee3682a59172782d95856df9260"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b5112f7923c9dd0db8fbfe7900b310d715c0cee1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b9aad9b3_89dc80f8","updated":"2022-05-13 07:08:23.000000000","message":"code looks good. \n","commit_id":"8c67223753d4dee3682a59172782d95856df9260"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2bdeba9c49c5f3e891e8a0ebdd39f0679f236a0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0155d02c_959953c1","updated":"2022-04-20 17:15:50.000000000","message":"recheck","commit_id":"8c67223753d4dee3682a59172782d95856df9260"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91ca9a3017bdd55a7bf265b957a3311ba4a1e402","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c941df34_7790d732","updated":"2022-06-09 15:18:30.000000000","message":"recheck","commit_id":"8c67223753d4dee3682a59172782d95856df9260"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c79955038cfe50e1685fa491f2d827bec1043655","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"db1181d7_41c12c3f","updated":"2022-05-12 19:25:47.000000000","message":"recheck\n\na few jobs failed because of sporadic package installation issues. Let\u0027s redo testing for sanity. \n\nThanks for working on this change. Please see some minor comments inline; i don\u0027t mind you fixing up the missing space in the doc in a subsequent commit - up to you. ","commit_id":"8c67223753d4dee3682a59172782d95856df9260"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"506e08d2223dcfb9f0125f2fb256690d51e2eb34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6e9b37f3_441f41df","updated":"2022-04-21 10:55:45.000000000","message":"recheck\nNeutron-dynamic-plugin issue got fixed: https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/838780","commit_id":"8c67223753d4dee3682a59172782d95856df9260"},{"author":{"_account_id":34181,"name":"Manish Honap","email":"mmhonap@gmail.com","username":"mhonap"},"change_message_id":"35b4698aa5fec17e1012105758ecc8947b952f31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a87b552b_e782b08b","updated":"2022-06-14 17:41:09.000000000","message":"Resolved white-space and release notes message formatting comments in ps5.","commit_id":"6431b86f19d09e1076e191d0ea5e794cc95bfac6"}],"manila/share/driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c79955038cfe50e1685fa491f2d827bec1043655","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        default\u003d0,"},{"line_number":57,"context_line":"        help\u003d\"The percentage of backend capacity reserved for share extend \""},{"line_number":58,"context_line":"             \"operation. When existing limit of \u0027reserved_share_percentage\u0027 \""},{"line_number":59,"context_line":"             \"is hit, we do not want user to create a new share but existing\""},{"line_number":60,"context_line":"             \"shares can be extended based on value of this parameter.\"),"},{"line_number":61,"context_line":"    cfg.StrOpt("},{"line_number":62,"context_line":"        \u0027share_backend_name\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"16556534_82a35e68","line":59,"range":{"start_line":59,"start_character":76,"end_line":59,"end_character":77},"updated":"2022-05-12 19:25:47.000000000","message":"missing space after word","commit_id":"8c67223753d4dee3682a59172782d95856df9260"},{"author":{"_account_id":34181,"name":"Manish Honap","email":"mmhonap@gmail.com","username":"mhonap"},"change_message_id":"35b4698aa5fec17e1012105758ecc8947b952f31","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        default\u003d0,"},{"line_number":57,"context_line":"        help\u003d\"The percentage of backend capacity reserved for share extend \""},{"line_number":58,"context_line":"             \"operation. When existing limit of \u0027reserved_share_percentage\u0027 \""},{"line_number":59,"context_line":"             \"is hit, we do not want user to create a new share but existing\""},{"line_number":60,"context_line":"             \"shares can be extended based on value of this parameter.\"),"},{"line_number":61,"context_line":"    cfg.StrOpt("},{"line_number":62,"context_line":"        \u0027share_backend_name\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"20b03cf3_4a773495","line":59,"range":{"start_line":59,"start_character":76,"end_line":59,"end_character":77},"in_reply_to":"16556534_82a35e68","updated":"2022-06-14 17:41:09.000000000","message":"Done","commit_id":"8c67223753d4dee3682a59172782d95856df9260"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b5112f7923c9dd0db8fbfe7900b310d715c0cee1","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        default\u003d0,"},{"line_number":57,"context_line":"        help\u003d\"The percentage of backend capacity reserved for share extend \""},{"line_number":58,"context_line":"             \"operation. When existing limit of \u0027reserved_share_percentage\u0027 \""},{"line_number":59,"context_line":"             \"is hit, we do not want user to create a new share but existing\""},{"line_number":60,"context_line":"             \"shares can be extended based on value of this parameter.\"),"},{"line_number":61,"context_line":"    cfg.StrOpt("},{"line_number":62,"context_line":"        \u0027share_backend_name\u0027,"},{"line_number":63,"context_line":"        help\u003d\u0027The backend name for a given driver implementation.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"6911c3c5_fdb989cc","line":60,"range":{"start_line":59,"start_character":22,"end_line":60,"end_character":69},"updated":"2022-05-13 07:08:23.000000000","message":"this means reserved_share_extend_percentage should be less than reserved_share_percentage. if reserved_share_extend_percentage  greater or equal  than reserved_share_percentage. If user cannot create a share, it must cannot extend any share.\n\nso here we should tell admin this value should less than reserved_share_percentage(if it is configed)","commit_id":"8c67223753d4dee3682a59172782d95856df9260"}],"manila/share/drivers/huawei/v3/connection.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c79955038cfe50e1685fa491f2d827bec1043655","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                            \u0027max_over_subscription_ratio\u0027)),"},{"line_number":324,"context_line":"                    allocated_capacity_gb\u003dcapacity[\u0027CONSUMEDCAPACITY\u0027],"},{"line_number":325,"context_line":"                    qos\u003dself._get_qos_capability(),"},{"line_number":326,"context_line":"                    reserved_percentage\u003d0,"},{"line_number":327,"context_line":"                    reserved_snapshot_percentage\u003d0,"},{"line_number":328,"context_line":"                    reserved_share_extend_percentage\u003d0,"},{"line_number":329,"context_line":"                    thin_provisioning\u003d[True, False],"},{"line_number":330,"context_line":"                    dedupe\u003d[True, False],"},{"line_number":331,"context_line":"                    compression\u003d[True, False],"}],"source_content_type":"text/x-python","patch_set":4,"id":"e2ad0c16_1f615827","line":328,"range":{"start_line":326,"start_character":20,"end_line":328,"end_character":55},"updated":"2022-05-12 19:25:47.000000000","message":"These should be coming from config; and that\u0027s a bug..no need to do anything with this patch","commit_id":"8c67223753d4dee3682a59172782d95856df9260"}],"manila/share/drivers/veritas/veritas_isa.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c79955038cfe50e1685fa491f2d827bec1043655","unresolved":true,"context_lines":[{"line_number":620,"context_line":"            \u0027storage_protocol\u0027: \u0027NFS\u0027,"},{"line_number":621,"context_line":"            \u0027total_capacity_gb\u0027: total_capacity,"},{"line_number":622,"context_line":"            \u0027free_capacity_gb\u0027: free_capacity,"},{"line_number":623,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":624,"context_line":"            \u0027reserved_snapshot_percentage\u0027: 0,"},{"line_number":625,"context_line":"            \u0027reserved_share_extend_percentage\u0027: 0,"},{"line_number":626,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":627,"context_line":"            \u0027snapshot_support\u0027: True,"},{"line_number":628,"context_line":"            \u0027create_share_from_snapshot_support\u0027: True"}],"source_content_type":"text/x-python","patch_set":4,"id":"a109dbcf_0c9699ae","line":625,"range":{"start_line":623,"start_character":0,"end_line":625,"end_character":50},"updated":"2022-05-12 19:25:47.000000000","message":"These should be coming from config; and that\u0027s a bug..no need to do anything with this patch","commit_id":"8c67223753d4dee3682a59172782d95856df9260"}],"manila/tests/scheduler/fakes.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"6677cd2f89074df391346b18552eb85cf59adbc2","unresolved":true,"context_lines":[{"line_number":262,"context_line":"                      \u0027thin_provisioning\u0027: False,"},{"line_number":263,"context_line":"                      \u0027reserved_percentage\u0027: 10,"},{"line_number":264,"context_line":"                      \u0027reserved_snapshot_percentage\u0027: 5,"},{"line_number":265,"context_line":"                      \u0027reserved_share_extend_percentage\u0027: 5,"},{"line_number":266,"context_line":"                      \u0027timestamp\u0027: None,"},{"line_number":267,"context_line":"                      \u0027snapshot_support\u0027: True,"},{"line_number":268,"context_line":"                      \u0027create_share_from_snapshot_support\u0027: True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"88ef331c_3a2df5db","line":265,"updated":"2022-03-23 12:58:03.000000000","message":"I suggest to use a different value for reserved_snapshot_percentage and reserved_share_extend_percentage here and similarly below to be able to distinguish both settings from each other.","commit_id":"72cdc1c86dd23134b8ff7b094f3466bd61508958"},{"author":{"_account_id":34181,"name":"Manish Honap","email":"mmhonap@gmail.com","username":"mhonap"},"change_message_id":"86fb3260f54dd31341b206123c451eb8bd89a530","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                      \u0027thin_provisioning\u0027: False,"},{"line_number":263,"context_line":"                      \u0027reserved_percentage\u0027: 10,"},{"line_number":264,"context_line":"                      \u0027reserved_snapshot_percentage\u0027: 5,"},{"line_number":265,"context_line":"                      \u0027reserved_share_extend_percentage\u0027: 5,"},{"line_number":266,"context_line":"                      \u0027timestamp\u0027: None,"},{"line_number":267,"context_line":"                      \u0027snapshot_support\u0027: True,"},{"line_number":268,"context_line":"                      \u0027create_share_from_snapshot_support\u0027: True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"208b0807_2f6bef13","line":265,"in_reply_to":"88ef331c_3a2df5db","updated":"2022-03-23 20:03:16.000000000","message":"okay, I have updated in patchset 3","commit_id":"72cdc1c86dd23134b8ff7b094f3466bd61508958"}],"manila/tests/scheduler/filters/test_capacity.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"6677cd2f89074df391346b18552eb85cf59adbc2","unresolved":true,"context_lines":[{"line_number":123,"context_line":"            reserved,"},{"line_number":124,"context_line":"            reserved_share_extend_percentage):"},{"line_number":125,"context_line":"        self._stub_service_is_up(True)"},{"line_number":126,"context_line":"        filter_properties \u003d {\u0027size\u0027: 100, \u0027is_share_extend\u0027: True}"},{"line_number":127,"context_line":"        service \u003d {\u0027disabled\u0027: False}"},{"line_number":128,"context_line":"        host \u003d fakes.FakeHostState(\u0027host1\u0027,"},{"line_number":129,"context_line":"                                   {\u0027total_capacity_gb\u0027: total_capacity,"}],"source_content_type":"text/x-python","patch_set":2,"id":"f57db853_da0bccef","line":126,"updated":"2022-03-23 12:58:03.000000000","message":"For my understanding: \u0027size\u0027 here means \u0027increase by this size\u0027?","commit_id":"72cdc1c86dd23134b8ff7b094f3466bd61508958"},{"author":{"_account_id":34181,"name":"Manish Honap","email":"mmhonap@gmail.com","username":"mhonap"},"change_message_id":"86fb3260f54dd31341b206123c451eb8bd89a530","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            reserved,"},{"line_number":124,"context_line":"            reserved_share_extend_percentage):"},{"line_number":125,"context_line":"        self._stub_service_is_up(True)"},{"line_number":126,"context_line":"        filter_properties \u003d {\u0027size\u0027: 100, \u0027is_share_extend\u0027: True}"},{"line_number":127,"context_line":"        service \u003d {\u0027disabled\u0027: False}"},{"line_number":128,"context_line":"        host \u003d fakes.FakeHostState(\u0027host1\u0027,"},{"line_number":129,"context_line":"                                   {\u0027total_capacity_gb\u0027: total_capacity,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3c7a12e2_ec277445","line":126,"in_reply_to":"f57db853_da0bccef","updated":"2022-03-23 20:03:16.000000000","message":"size here means the actual size of share.","commit_id":"72cdc1c86dd23134b8ff7b094f3466bd61508958"}],"releasenotes/notes/bug-1961087-add-reserved-share-extend-percentage-c6da2ac8a0113d2c.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c79955038cfe50e1685fa491f2d827bec1043655","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    \u0027reserved_share_extend_percentage\u0027 backend config option allows"},{"line_number":5,"context_line":"    Manila to consider different reservation percentage for share extend"},{"line_number":6,"context_line":"    operation."},{"line_number":7,"context_line":"    With this option, under existing limit of \u0027reserved_share_percentage\u0027,"},{"line_number":8,"context_line":"    we do not want user to create new share if limit is hit, but allow user to"},{"line_number":9,"context_line":"    extend existing share."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f29721d3_ad82e2e1","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":26},"updated":"2022-05-12 19:25:47.000000000","message":"This distinct option is useful if operators want to prevent provisioning of new shares but allow extensions of existing shares on storage pools beyond their reserved space.","commit_id":"8c67223753d4dee3682a59172782d95856df9260"},{"author":{"_account_id":34181,"name":"Manish Honap","email":"mmhonap@gmail.com","username":"mhonap"},"change_message_id":"35b4698aa5fec17e1012105758ecc8947b952f31","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    \u0027reserved_share_extend_percentage\u0027 backend config option allows"},{"line_number":5,"context_line":"    Manila to consider different reservation percentage for share extend"},{"line_number":6,"context_line":"    operation."},{"line_number":7,"context_line":"    With this option, under existing limit of \u0027reserved_share_percentage\u0027,"},{"line_number":8,"context_line":"    we do not want user to create new share if limit is hit, but allow user to"},{"line_number":9,"context_line":"    extend existing share."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"95afa480_a2cc4f58","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":26},"in_reply_to":"f29721d3_ad82e2e1","updated":"2022-06-14 17:41:09.000000000","message":"Done","commit_id":"8c67223753d4dee3682a59172782d95856df9260"}]}