)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"a2621e5c3a9e2f18bea80ec57f501dfab9009223","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[NetApp] Fix DHSS mode fails to create share on a new pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes #1928241 checking if the aggregates of"},{"line_number":10,"context_line":"a vserver matches with the backend pools, if there are"},{"line_number":11,"context_line":"different the share server cannot be reused and a new"},{"line_number":12,"context_line":"one with the right aggregates is created."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e48356b7_f301e555","line":10,"range":{"start_line":10,"start_character":45,"end_line":10,"end_character":51},"updated":"2022-04-07 13:25:11.000000000","message":"nit: \"they\" ?","commit_id":"79b7cf253040595bfa0ec78f46fc94c3b21a6d0c"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"febac1cc9ba57cadf81b959dc9c3e08df7347d9b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[NetApp] Fix DHSS mode fails to create share on a new pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes #1928241 checking if the aggregates of"},{"line_number":10,"context_line":"a vserver matches with the backend pools, if there are"},{"line_number":11,"context_line":"different the share server cannot be reused and a new"},{"line_number":12,"context_line":"one with the right aggregates is created."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5e31e201_0f38b52e","line":10,"range":{"start_line":10,"start_character":45,"end_line":10,"end_character":51},"in_reply_to":"e48356b7_f301e555","updated":"2022-04-18 18:50:22.000000000","message":"Done","commit_id":"79b7cf253040595bfa0ec78f46fc94c3b21a6d0c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a0dcacb9d61feb059ff97648b2aa818d98a9049d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"10b39488_b393b571","updated":"2022-03-21 15:22:28.000000000","message":"Hi Andre, please add a release note for this fix. Thanks","commit_id":"0bacbf26eb09c908fa03b8f6a601fa8765b02515"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"1e9b4e6f412d78370966adf1fb86a2618dcff0e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2afb8acf_40f406a7","in_reply_to":"10b39488_b393b571","updated":"2022-03-21 19:45:14.000000000","message":"Sure, thank you Douglas.","commit_id":"0bacbf26eb09c908fa03b8f6a601fa8765b02515"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"a2621e5c3a9e2f18bea80ec57f501dfab9009223","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a5c1f425_a0d67cdd","updated":"2022-04-07 13:25:11.000000000","message":"Hi Andre, I added some comments, please let me know your opinion about them. Thank you!","commit_id":"79b7cf253040595bfa0ec78f46fc94c3b21a6d0c"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"6599802d23abcf31040397393396b0ba750c7634","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"50caef6b_1ec4fe3c","updated":"2022-03-22 12:00:44.000000000","message":"run-NetApp CI","commit_id":"79b7cf253040595bfa0ec78f46fc94c3b21a6d0c"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"e914ec5181e9cae2d643ec183fe42e2be39cbb50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b15062e4_80a3d4d2","updated":"2022-03-22 14:18:54.000000000","message":"run-NetApp CI","commit_id":"79b7cf253040595bfa0ec78f46fc94c3b21a6d0c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"020961969b2f4d65ad040dc4b27864056a00ca99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9bbe7a4a_9d1e9a0c","updated":"2022-04-19 11:50:01.000000000","message":"Andre, thanks for updating the patch with the fixes. LGTM!","commit_id":"4549d4c6b81e5d7125378939da9ac0e121d9d832"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"febac1cc9ba57cadf81b959dc9c3e08df7347d9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1a4eff66_63e562f1","updated":"2022-04-18 18:50:22.000000000","message":"Thank you Nahim... ","commit_id":"4549d4c6b81e5d7125378939da9ac0e121d9d832"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e98737dba2de8edb7af32413a586801c640d0903","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"18c699ee_042b37df","updated":"2022-09-15 11:21:20.000000000","message":"Thanks Andre. I found a possible issue with the code.","commit_id":"4549d4c6b81e5d7125378939da9ac0e121d9d832"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"69ff4a2d14010341de0abe4e400bbf0aded72343","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f86df971_c148c4eb","updated":"2022-09-15 11:00:21.000000000","message":"run-NetApp CI","commit_id":"4549d4c6b81e5d7125378939da9ac0e121d9d832"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c7ada43823d9497b61fff6e93fccda11fcf2a194","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"60f05ea6_ba000fad","updated":"2022-09-15 18:26:21.000000000","message":"Agree with Carlos\u0027s review on the reno; the code looks good to me as well. Thanks!","commit_id":"b03535d4367faf9a59814b5829e2e72603640946"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"58335b9caa3c15ce24f85b7caba9415038f0a542","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3f550038_c8515f28","updated":"2022-09-15 14:35:30.000000000","message":"Code looks good, only suggesting some changes to the commit message.\nThank you for the fix","commit_id":"b03535d4367faf9a59814b5829e2e72603640946"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"75a64275413ed4de0d691423f07e48ebf75d5f46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"511db4fb_49c56009","updated":"2023-03-01 15:47:37.000000000","message":"Thanks for the patch. Besides comments about release notes, the rest LGTM.","commit_id":"b03535d4367faf9a59814b5829e2e72603640946"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"1e1255c086afc9c691c7c1ea5b06b61d2f6e8634","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0daf91de_1cdcc085","updated":"2022-09-15 12:08:47.000000000","message":"run-NetApp CI","commit_id":"b03535d4367faf9a59814b5829e2e72603640946"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3628d29fa307e9f8fd9c9d57ca6870a3cc37784f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5d76e500_b5a5552d","updated":"2023-03-03 20:18:08.000000000","message":"Felipe: SHould this fix be backported to stable/zed and earlier branches?","commit_id":"7e08ed4ce5c7e578148e71f709c15eeeb50be92c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c089aa4a26e9b2c2bf5d26eac6e08e3893d6391c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2b768590_86bf01d8","updated":"2023-03-02 11:07:09.000000000","message":"LGTM, thanks Felipe!","commit_id":"7e08ed4ce5c7e578148e71f709c15eeeb50be92c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ca398515339d4d3efaa67992a4f2780649c855fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"103ecd27_6310d30c","updated":"2023-03-01 22:34:16.000000000","message":"Thanks for the update Felipe. \n\nThe NetApp DHSS\u003dFalse CI job failed a share group test - looks like its unrelated to this fix","commit_id":"7e08ed4ce5c7e578148e71f709c15eeeb50be92c"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6522cc8e6fac62ae4b7789fb072f285bc5f679c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c2ca7ea5_61c3ef4e","updated":"2023-03-01 18:11:35.000000000","message":"run-NetApp CI","commit_id":"7e08ed4ce5c7e578148e71f709c15eeeb50be92c"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a0dcacb9d61feb059ff97648b2aa818d98a9049d","unresolved":true,"context_lines":[{"line_number":907,"context_line":"        # NOTE(andrebeltrami): Check for fixing #1928241, if backend pools"},{"line_number":908,"context_line":"        # are different than the aggregates of the vserver, the vserver cannot"},{"line_number":909,"context_line":"        # be reused."},{"line_number":910,"context_line":"        share_server_pools \u003d self.get_share_server_pools("},{"line_number":911,"context_line":"            share_server)"},{"line_number":912,"context_line":"        server_pool_list \u003d [pool[\u0027pool_name\u0027] for pool in share_server_pools]"},{"line_number":913,"context_line":"        aggr_list \u003d client.list_vserver_aggregates()"},{"line_number":914,"context_line":"        if set(server_pool_list) !\u003d set(aggr_list):"}],"source_content_type":"text/x-python","patch_set":1,"id":"b4d66d9f_c41755f2","line":911,"range":{"start_line":910,"start_character":0,"end_line":911,"end_character":25},"updated":"2022-03-21 15:22:28.000000000","message":"is there another easy way to retrieve this info? today you have cached info about pools, but this performance improvement[1] is not available in older branches, if you plan to backport this fix.\n\n[1] https://opendev.org/openstack/manila/commit/b2e1797889f292aef43ffb581c5f67ed53f66070","commit_id":"0bacbf26eb09c908fa03b8f6a601fa8765b02515"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"1e9b4e6f412d78370966adf1fb86a2618dcff0e0","unresolved":true,"context_lines":[{"line_number":907,"context_line":"        # NOTE(andrebeltrami): Check for fixing #1928241, if backend pools"},{"line_number":908,"context_line":"        # are different than the aggregates of the vserver, the vserver cannot"},{"line_number":909,"context_line":"        # be reused."},{"line_number":910,"context_line":"        share_server_pools \u003d self.get_share_server_pools("},{"line_number":911,"context_line":"            share_server)"},{"line_number":912,"context_line":"        server_pool_list \u003d [pool[\u0027pool_name\u0027] for pool in share_server_pools]"},{"line_number":913,"context_line":"        aggr_list \u003d client.list_vserver_aggregates()"},{"line_number":914,"context_line":"        if set(server_pool_list) !\u003d set(aggr_list):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da5092c2_ec58b046","line":911,"range":{"start_line":910,"start_character":0,"end_line":911,"end_character":25},"in_reply_to":"b4d66d9f_c41755f2","updated":"2022-03-21 19:45:14.000000000","message":"Good point, maybe an alternative can be using the _get_pools() directly. WDYT? Thank you, Douglas.","commit_id":"0bacbf26eb09c908fa03b8f6a601fa8765b02515"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"febac1cc9ba57cadf81b959dc9c3e08df7347d9b","unresolved":false,"context_lines":[{"line_number":907,"context_line":"        # NOTE(andrebeltrami): Check for fixing #1928241, if backend pools"},{"line_number":908,"context_line":"        # are different than the aggregates of the vserver, the vserver cannot"},{"line_number":909,"context_line":"        # be reused."},{"line_number":910,"context_line":"        share_server_pools \u003d self.get_share_server_pools("},{"line_number":911,"context_line":"            share_server)"},{"line_number":912,"context_line":"        server_pool_list \u003d [pool[\u0027pool_name\u0027] for pool in share_server_pools]"},{"line_number":913,"context_line":"        aggr_list \u003d client.list_vserver_aggregates()"},{"line_number":914,"context_line":"        if set(server_pool_list) !\u003d set(aggr_list):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9cbfe09a_7b25a62e","line":911,"range":{"start_line":910,"start_character":0,"end_line":911,"end_character":25},"in_reply_to":"da5092c2_ec58b046","updated":"2022-04-18 18:50:22.000000000","message":"Done","commit_id":"0bacbf26eb09c908fa03b8f6a601fa8765b02515"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"a2621e5c3a9e2f18bea80ec57f501dfab9009223","unresolved":true,"context_lines":[{"line_number":910,"context_line":"        backend_pools \u003d self._get_pools()"},{"line_number":911,"context_line":"        backend_pool_list \u003d [pool[\u0027pool_name\u0027] for pool in backend_pools]"},{"line_number":912,"context_line":"        aggr_list \u003d client.list_vserver_aggregates()"},{"line_number":913,"context_line":"        if set(backend_pool_list) !\u003d set(aggr_list):"},{"line_number":914,"context_line":"            return False"},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"        if self.is_nfs_config_supported:"}],"source_content_type":"text/x-python","patch_set":2,"id":"db70e187_073940f2","line":913,"range":{"start_line":913,"start_character":11,"end_line":913,"end_character":51},"updated":"2022-04-07 13:25:11.000000000","message":"I\u0027m wondering if this solution would work for flexgroups - Wouldn\u0027t this comparison always return False? For example, I believe the values could be something like:\n\nbackend_pool_list \u003d [\u0027aggr1\u0027, \u0027aggr2\u0027, \u0027flexgroup_auto\u0027]\naggr_list \u003d [\u0027aggr1\u0027, \u0027aggr2\u0027]\n\nAnd the share server would never be reused.","commit_id":"79b7cf253040595bfa0ec78f46fc94c3b21a6d0c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"020961969b2f4d65ad040dc4b27864056a00ca99","unresolved":false,"context_lines":[{"line_number":910,"context_line":"        backend_pools \u003d self._get_pools()"},{"line_number":911,"context_line":"        backend_pool_list \u003d [pool[\u0027pool_name\u0027] for pool in backend_pools]"},{"line_number":912,"context_line":"        aggr_list \u003d client.list_vserver_aggregates()"},{"line_number":913,"context_line":"        if set(backend_pool_list) !\u003d set(aggr_list):"},{"line_number":914,"context_line":"            return False"},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"        if self.is_nfs_config_supported:"}],"source_content_type":"text/x-python","patch_set":2,"id":"25b1be7d_69e6ba42","line":913,"range":{"start_line":913,"start_character":11,"end_line":913,"end_character":51},"in_reply_to":"7b673be2_14fcb7b0","updated":"2022-04-19 11:50:01.000000000","message":"Ack","commit_id":"79b7cf253040595bfa0ec78f46fc94c3b21a6d0c"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"febac1cc9ba57cadf81b959dc9c3e08df7347d9b","unresolved":true,"context_lines":[{"line_number":910,"context_line":"        backend_pools \u003d self._get_pools()"},{"line_number":911,"context_line":"        backend_pool_list \u003d [pool[\u0027pool_name\u0027] for pool in backend_pools]"},{"line_number":912,"context_line":"        aggr_list \u003d client.list_vserver_aggregates()"},{"line_number":913,"context_line":"        if set(backend_pool_list) !\u003d set(aggr_list):"},{"line_number":914,"context_line":"            return False"},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"        if self.is_nfs_config_supported:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7b673be2_14fcb7b0","line":913,"range":{"start_line":913,"start_character":11,"end_line":913,"end_character":51},"in_reply_to":"db70e187_073940f2","updated":"2022-04-18 18:50:22.000000000","message":"Good point Nahim, thank you for this valuable comment. I tested the solution and it was not working for flexgroups. Please take a look at the PS3 that now it\u0027s considering both flexgroups and flexvols.","commit_id":"79b7cf253040595bfa0ec78f46fc94c3b21a6d0c"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e98737dba2de8edb7af32413a586801c640d0903","unresolved":true,"context_lines":[{"line_number":910,"context_line":"            aggr_list \u003d client.list_vserver_aggregates()"},{"line_number":911,"context_line":"            if self._is_flexgroup_pool(share_pool):"},{"line_number":912,"context_line":"                share_pool \u003d self._get_flexgroup_aggregate_list(share_pool)"},{"line_number":913,"context_line":"            if not set([share_pool]).issubset(set(aggr_list)):"},{"line_number":914,"context_line":"                return False"},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"        if self.is_nfs_config_supported:"}],"source_content_type":"text/x-python","patch_set":3,"id":"05d736a0_353479d3","line":913,"range":{"start_line":913,"start_character":19,"end_line":913,"end_character":36},"updated":"2022-09-15 11:21:20.000000000","message":"I think it won\u0027t work with FlexGroup, the \"share_pool\" will be  a list, so the code will break, since you cannot create a set of list of list.","commit_id":"4549d4c6b81e5d7125378939da9ac0e121d9d832"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0eaca8dd88e0d0728a76a76e97ce964c65ee52a8","unresolved":false,"context_lines":[{"line_number":910,"context_line":"            aggr_list \u003d client.list_vserver_aggregates()"},{"line_number":911,"context_line":"            if self._is_flexgroup_pool(share_pool):"},{"line_number":912,"context_line":"                share_pool \u003d self._get_flexgroup_aggregate_list(share_pool)"},{"line_number":913,"context_line":"            if not set([share_pool]).issubset(set(aggr_list)):"},{"line_number":914,"context_line":"                return False"},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"        if self.is_nfs_config_supported:"}],"source_content_type":"text/x-python","patch_set":3,"id":"0f7ae59e_fb96acdc","line":913,"range":{"start_line":913,"start_character":19,"end_line":913,"end_character":36},"in_reply_to":"05d736a0_353479d3","updated":"2022-09-15 12:02:46.000000000","message":"Done","commit_id":"4549d4c6b81e5d7125378939da9ac0e121d9d832"}],"manila/tests/share/drivers/netapp/dataontap/cluster_mode/test_lib_multi_svm.py":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"a2621e5c3a9e2f18bea80ec57f501dfab9009223","unresolved":true,"context_lines":[{"line_number":1766,"context_line":"        self.mock_object(mock_client, \u0027get_vserver_info\u0027,"},{"line_number":1767,"context_line":"                         mock.Mock(return_value\u003dfake.VSERVER_INFO))"},{"line_number":1768,"context_line":"        self.mock_object(self.library, \u0027_get_pools\u0027,"},{"line_number":1769,"context_line":"                         mock.Mock(return_value\u003dfake.POOLS))"},{"line_number":1770,"context_line":"        self.mock_object(mock_client, \u0027list_vserver_aggregates\u0027,"},{"line_number":1771,"context_line":"                         mock.Mock(return_value\u003dfake.AGGREGATES))"},{"line_number":1772,"context_line":"        self.library._cache_pool_status \u003d na_utils.DataCache(60)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0401d915_f8e2ef4e","line":1769,"range":{"start_line":1769,"start_character":48,"end_line":1769,"end_character":58},"updated":"2022-04-07 13:25:11.000000000","message":"If my comment above is correct, about flexgroups, it would be good to consider that case here in the UTs :)","commit_id":"79b7cf253040595bfa0ec78f46fc94c3b21a6d0c"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"febac1cc9ba57cadf81b959dc9c3e08df7347d9b","unresolved":true,"context_lines":[{"line_number":1766,"context_line":"        self.mock_object(mock_client, \u0027get_vserver_info\u0027,"},{"line_number":1767,"context_line":"                         mock.Mock(return_value\u003dfake.VSERVER_INFO))"},{"line_number":1768,"context_line":"        self.mock_object(self.library, \u0027_get_pools\u0027,"},{"line_number":1769,"context_line":"                         mock.Mock(return_value\u003dfake.POOLS))"},{"line_number":1770,"context_line":"        self.mock_object(mock_client, \u0027list_vserver_aggregates\u0027,"},{"line_number":1771,"context_line":"                         mock.Mock(return_value\u003dfake.AGGREGATES))"},{"line_number":1772,"context_line":"        self.library._cache_pool_status \u003d na_utils.DataCache(60)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f143ca1d_5db74b83","line":1769,"range":{"start_line":1769,"start_character":48,"end_line":1769,"end_character":58},"in_reply_to":"0401d915_f8e2ef4e","updated":"2022-04-18 18:50:22.000000000","message":"I added a specific UT for flexgroup. In my tests the coverage is happy, so I believe it\u0027s covered.","commit_id":"79b7cf253040595bfa0ec78f46fc94c3b21a6d0c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"020961969b2f4d65ad040dc4b27864056a00ca99","unresolved":false,"context_lines":[{"line_number":1766,"context_line":"        self.mock_object(mock_client, \u0027get_vserver_info\u0027,"},{"line_number":1767,"context_line":"                         mock.Mock(return_value\u003dfake.VSERVER_INFO))"},{"line_number":1768,"context_line":"        self.mock_object(self.library, \u0027_get_pools\u0027,"},{"line_number":1769,"context_line":"                         mock.Mock(return_value\u003dfake.POOLS))"},{"line_number":1770,"context_line":"        self.mock_object(mock_client, \u0027list_vserver_aggregates\u0027,"},{"line_number":1771,"context_line":"                         mock.Mock(return_value\u003dfake.AGGREGATES))"},{"line_number":1772,"context_line":"        self.library._cache_pool_status \u003d na_utils.DataCache(60)"}],"source_content_type":"text/x-python","patch_set":2,"id":"61400511_14bedfd8","line":1769,"range":{"start_line":1769,"start_character":48,"end_line":1769,"end_character":58},"in_reply_to":"f143ca1d_5db74b83","updated":"2022-04-19 11:50:01.000000000","message":"Ack","commit_id":"79b7cf253040595bfa0ec78f46fc94c3b21a6d0c"}],"releasenotes/notes/bug-1928241-d1b48e79aceb3cc4.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"58335b9caa3c15ce24f85b7caba9415038f0a542","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1928241 \u003chttps://bugs.launchpad.net/manila/+bug/1928241\u003e`_]"},{"line_number":5,"context_line":"    This fix avoid reuse of share servers that is not compatible"},{"line_number":6,"context_line":"    with the pools available on the backends. In other words, the reuse share"},{"line_number":7,"context_line":"    server for a share is not checking if the share\u0027s pool is part of share"},{"line_number":8,"context_line":"    server aggregates. So, new added pools cannot have shares created whether"},{"line_number":9,"context_line":"    any share server exists."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f1490598_8ba5ac95","line":9,"range":{"start_line":4,"start_character":4,"end_line":9,"end_character":28},"updated":"2022-09-15 14:35:30.000000000","message":"Fixes `bug 1928241 \u003chttps://bugs.launchpad.net/manila/+bug/1928241\u003e`_.\nThe NetApp ONTAP driver will now avoid reusing a share server during the share creation in case the share server does not span the selected pool.","commit_id":"b03535d4367faf9a59814b5829e2e72603640946"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"1db3e651f6f470fb6b75499dc3fe5c9026fb9321","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1928241 \u003chttps://bugs.launchpad.net/manila/+bug/1928241\u003e`_]"},{"line_number":5,"context_line":"    This fix avoid reuse of share servers that is not compatible"},{"line_number":6,"context_line":"    with the pools available on the backends. In other words, the reuse share"},{"line_number":7,"context_line":"    server for a share is not checking if the share\u0027s pool is part of share"},{"line_number":8,"context_line":"    server aggregates. So, new added pools cannot have shares created whether"},{"line_number":9,"context_line":"    any share server exists."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f237dfd3_fd119523","line":9,"range":{"start_line":4,"start_character":4,"end_line":9,"end_character":28},"in_reply_to":"3c2436eb_a2fe7d02","updated":"2023-03-01 18:10:56.000000000","message":"Thanks Carlos and Goutham. Fixed with newest patchset.","commit_id":"b03535d4367faf9a59814b5829e2e72603640946"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c7ada43823d9497b61fff6e93fccda11fcf2a194","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1928241 \u003chttps://bugs.launchpad.net/manila/+bug/1928241\u003e`_]"},{"line_number":5,"context_line":"    This fix avoid reuse of share servers that is not compatible"},{"line_number":6,"context_line":"    with the pools available on the backends. In other words, the reuse share"},{"line_number":7,"context_line":"    server for a share is not checking if the share\u0027s pool is part of share"},{"line_number":8,"context_line":"    server aggregates. So, new added pools cannot have shares created whether"},{"line_number":9,"context_line":"    any share server exists."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3c2436eb_a2fe7d02","line":9,"range":{"start_line":4,"start_character":4,"end_line":9,"end_character":28},"in_reply_to":"f1490598_8ba5ac95","updated":"2022-09-15 18:26:21.000000000","message":"+1 please provide context that this bug affects the NetApp driver. Avoid the use of \"this fix\" or \"this patch\" -- release notes are rendered as a summary at the end of the release, and there is no patch referenced to point back to","commit_id":"b03535d4367faf9a59814b5829e2e72603640946"}]}
