)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a73611656a72fc0abe93c2ce86f39013168fd789","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Kiran Pawar \u003ckinpaa@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-23 09:44:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp: Use cluster client to check vserver exists before using vserver client."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When share server is in error state in Manila and backend vserver has"},{"line_number":10,"context_line":"not been created, there exist entries of share server and shares in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"f5938589_6395b72f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":79},"updated":"2023-01-28 21:49:46.000000000","message":"Please keep the commit message title under 50 characters: https://wiki.openstack.org/wiki/GitCommitMessages#Git_Commit_Good_Practice","commit_id":"3830c357ffe818fc9429a5961856929b37edb140"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2fd9a0420793180a9bab89a514648888faa385b3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kiran Pawar \u003ckinpaa@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-23 09:44:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp: Use cluster client to check vserver exists before using vserver client."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When share server is in error state in Manila and backend vserver has"},{"line_number":10,"context_line":"not been created, there exist entries of share server and shares in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bdcc24ba_5dbb9720","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":79},"in_reply_to":"f5938589_6395b72f","updated":"2023-02-01 08:40:20.000000000","message":"Done","commit_id":"3830c357ffe818fc9429a5961856929b37edb140"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"076ecf9ccf5f18dde1efd7edbc57a775d405f627","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"76be2635_3d7095fb","updated":"2022-04-26 09:04:52.000000000","message":"fixed","commit_id":"9d58da19dc12deb5f28f886eac65bfc779dad184"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3d8921a8cd418f34597613c88600a6fcce2705c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f654fda2_a5ef5131","updated":"2022-08-23 21:14:39.000000000","message":"LGTM; but NetApp CI is failing. Felipe/Nahim could you please take a look and retrigger it?","commit_id":"325b3d5a92522f580f9355cfba1289eeaae055d0"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"f698c7265d4ca80cba43adfb0f938a2fd5d11dc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"70e0331a_c67adac6","updated":"2022-08-29 13:25:14.000000000","message":"run-NetApp CI","commit_id":"325b3d5a92522f580f9355cfba1289eeaae055d0"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"325a2e68f6f30d71c3fc1b4cd9cfc89b99db7af9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c7361b45_f88cee4d","updated":"2022-08-26 17:53:07.000000000","message":"run-NetApp CI","commit_id":"325b3d5a92522f580f9355cfba1289eeaae055d0"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ea1d46c242062f88eab916ca8219a399a84985eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2f0571e4_3597b958","updated":"2022-08-31 00:11:37.000000000","message":"Thanks Kiran for providing this Fix. Please, see my comments.","commit_id":"0de6b3ece95938bac732fa92c2a4e017a92c3a4b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"32734bcbd32c69aa2c43c28f957e3ac044b2e1f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a176d8fd_bc5be0de","updated":"2022-11-23 02:05:37.000000000","message":"Please, run the NetApp CI.","commit_id":"aa1ac4c4b8af585c4b102d9cf403ff254e3250d3"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"648af9fcf02a5f233526a5635e47d1ea77a49606","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7ebcae12_123f1fe5","updated":"2022-11-02 17:02:57.000000000","message":"Thanks Felipe, it is failing even earlier (see the trace in the bugreport), but the hint is super helpful.","commit_id":"aa1ac4c4b8af585c4b102d9cf403ff254e3250d3"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6c2a2e01a9357dd78d3c33e4543d7b2a610ce3c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"da4cfef4_ef345421","updated":"2022-11-23 02:05:25.000000000","message":"Thanks. An improvement to the release note.","commit_id":"aa1ac4c4b8af585c4b102d9cf403ff254e3250d3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"26dfc20caf4d3c7b52471be4ed2581c455b1cad2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a87fec81_a7a2369c","updated":"2022-11-23 15:24:32.000000000","message":"After discussion with Maurice, updated patchset to address suggestions from Felipe.","commit_id":"aad273522d31ca802222dc66f4f34c8113579c17"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"69362517c9df8ecc279fe715314652970ef65656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c0447ef9_2fe8e90c","updated":"2022-11-24 01:04:11.000000000","message":"run-NetApp CI","commit_id":"aad273522d31ca802222dc66f4f34c8113579c17"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"cece8bd6468853bb074841f3598f623e95e41c1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6ada18ea_7610c266","updated":"2022-12-27 16:45:43.000000000","message":"run-NetApp CI","commit_id":"581b784e962b2b8f0b4e39f79aab0c62ff39764d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"be94a63ae92dcf2b0360ea084f81f8d17617263f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0b847e59_c5dda704","updated":"2023-01-25 13:28:29.000000000","message":"LGTM, thanks Kiran","commit_id":"3830c357ffe818fc9429a5961856929b37edb140"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c372077949e83217aa0128325ee65bd3f37b245d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3cef694d_cd55359f","updated":"2023-01-23 13:04:48.000000000","message":"recheck","commit_id":"3830c357ffe818fc9429a5961856929b37edb140"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a73611656a72fc0abe93c2ce86f39013168fd789","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"85881b2d_097ae814","updated":"2023-01-28 21:49:46.000000000","message":"run-NetApp-CI","commit_id":"3830c357ffe818fc9429a5961856929b37edb140"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"da1cfb7dc587da1b448e335976a4158c7d5fd076","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c2852022_7234fdc9","updated":"2023-02-07 13:53:42.000000000","message":"Hi, Kiran. Patch looks good to me. Just need to recheck and run the NetApp CI.","commit_id":"224d3aa4dda388def5dc45b4ae1fb7ac68d86106"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"5ed2193c89b2df9406f8b29fe8c37cdeab8b80a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"59ccb828_7405a4f1","updated":"2023-02-10 12:10:44.000000000","message":"LGTM and CI is passing.","commit_id":"224d3aa4dda388def5dc45b4ae1fb7ac68d86106"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"48f96c8a0fe2626fb4d6db77a81dc423a58f5fb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"4bed42eb_290a4b70","updated":"2023-02-09 20:08:09.000000000","message":"Thanks for the updates - let\u0027s check NetApp CI output","commit_id":"224d3aa4dda388def5dc45b4ae1fb7ac68d86106"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ce376003f8a72c0c81231ab50cd554762543ad60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"653b19c4_ab93b14f","updated":"2023-02-08 09:20:08.000000000","message":"recheck","commit_id":"224d3aa4dda388def5dc45b4ae1fb7ac68d86106"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"685ec21dae41d769ce6df80002441d9f13286678","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f6b846cb_bbb0e862","updated":"2023-02-01 11:56:23.000000000","message":"recheck","commit_id":"224d3aa4dda388def5dc45b4ae1fb7ac68d86106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c879d13045c26d30c4c5e604f7015e0dd7233100","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5cf43216_85edb2db","updated":"2023-02-08 18:48:52.000000000","message":"run-NetApp CI","commit_id":"224d3aa4dda388def5dc45b4ae1fb7ac68d86106"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1df0c4154d8fa6e6b613639f467e24d9819b8437","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c2b09159_6b0fc7cc","updated":"2023-02-09 20:07:54.000000000","message":"run-NetApp CI","commit_id":"224d3aa4dda388def5dc45b4ae1fb7ac68d86106"}],"manila/share/drivers/netapp/dataontap/client/client_base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a73611656a72fc0abe93c2ce86f39013168fd789","unresolved":true,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        result \u003d self.send_request(\u0027system-get-version\u0027,"},{"line_number":60,"context_line":"                                   enable_tunneling\u003dFalse)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        version_tuple \u003d result.get_child_by_name("},{"line_number":63,"context_line":"            \u0027version-tuple\u0027) or netapp_api.NaElement(\u0027none\u0027)"},{"line_number":64,"context_line":"        system_version_tuple \u003d version_tuple.get_child_by_name("}],"source_content_type":"text/x-python","patch_set":11,"id":"93938437_c6c2f61c","line":61,"updated":"2023-01-28 21:49:46.000000000","message":"This fix doesn\u0027t appear relevant to the bug that you\u0027re trying to resolve - is it?","commit_id":"3830c357ffe818fc9429a5961856929b37edb140"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2fd9a0420793180a9bab89a514648888faa385b3","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        result \u003d self.send_request(\u0027system-get-version\u0027,"},{"line_number":60,"context_line":"                                   enable_tunneling\u003dFalse)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        version_tuple \u003d result.get_child_by_name("},{"line_number":63,"context_line":"            \u0027version-tuple\u0027) or netapp_api.NaElement(\u0027none\u0027)"},{"line_number":64,"context_line":"        system_version_tuple \u003d version_tuple.get_child_by_name("}],"source_content_type":"text/x-python","patch_set":11,"id":"540956a7_dd6d8948","line":61,"in_reply_to":"93938437_c6c2f61c","updated":"2023-02-01 08:40:20.000000000","message":"yes it is, I changed commit message","commit_id":"3830c357ffe818fc9429a5961856929b37edb140"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a73611656a72fc0abe93c2ce86f39013168fd789","unresolved":true,"context_lines":[{"line_number":292,"context_line":"        }"},{"line_number":293,"context_line":"        try:"},{"line_number":294,"context_line":"            result \u003d self.send_iter_request(\u0027vserver-get-iter\u0027, api_args,"},{"line_number":295,"context_line":"                                            enable_tunneling\u003dFalse)"},{"line_number":296,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":297,"context_line":"            if e.code \u003d\u003d netapp_api.EVSERVERNOTFOUND:"},{"line_number":298,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":11,"id":"0c0f2e38_4876f3d6","line":295,"range":{"start_line":295,"start_character":44,"end_line":295,"end_character":67},"updated":"2023-01-28 21:49:46.000000000","message":"I see the single SVM driver (DHSS\u003dFalse) also invokes this method: https://github.com/openstack/manila/blob/9f3c566a10fe649919bee38f1ea839062b97cc01/manila/share/drivers/netapp/dataontap/cluster_mode/lib_single_svm.py#L55-L56 \n\nis this change okay for that driver mode?","commit_id":"3830c357ffe818fc9429a5961856929b37edb140"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2fd9a0420793180a9bab89a514648888faa385b3","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        }"},{"line_number":293,"context_line":"        try:"},{"line_number":294,"context_line":"            result \u003d self.send_iter_request(\u0027vserver-get-iter\u0027, api_args,"},{"line_number":295,"context_line":"                                            enable_tunneling\u003dFalse)"},{"line_number":296,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":297,"context_line":"            if e.code \u003d\u003d netapp_api.EVSERVERNOTFOUND:"},{"line_number":298,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":11,"id":"cbba491a_a1e6c43d","line":295,"range":{"start_line":295,"start_character":44,"end_line":295,"end_character":67},"in_reply_to":"0c0f2e38_4876f3d6","updated":"2023-02-01 08:40:20.000000000","message":"AFAIK, yes.","commit_id":"3830c357ffe818fc9429a5961856929b37edb140"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"1d030b142ed46b2e50f16167054367723ee2a96f","unresolved":true,"context_lines":[{"line_number":98,"context_line":"            msg \u003d _(\u0027Share server or vserver name not provided\u0027)"},{"line_number":99,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if not self._client.vserver_exists(vserver):"},{"line_number":102,"context_line":"            raise exception.VserverNotFound(vserver\u003dvserver)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        if backend_name:"},{"line_number":105,"context_line":"            vserver_client \u003d data_motion.get_client_for_backend("},{"line_number":106,"context_line":"                backend_name, vserver"}],"source_content_type":"text/x-python","patch_set":3,"id":"e877da9d_6889d6ae","line":103,"range":{"start_line":101,"start_character":8,"end_line":103,"end_character":0},"updated":"2022-04-25 15:16:47.000000000","message":"We just noticed in our fork:\nthis will break the case if `backend_name` has been provided and the existence of a vserver in a different backend should be checked","commit_id":"58582b5ed692661eb2f61fde40c7b5e8138ea7ea"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"076ecf9ccf5f18dde1efd7edbc57a775d405f627","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            msg \u003d _(\u0027Share server or vserver name not provided\u0027)"},{"line_number":99,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if not self._client.vserver_exists(vserver):"},{"line_number":102,"context_line":"            raise exception.VserverNotFound(vserver\u003dvserver)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        if backend_name:"},{"line_number":105,"context_line":"            vserver_client \u003d data_motion.get_client_for_backend("},{"line_number":106,"context_line":"                backend_name, vserver"}],"source_content_type":"text/x-python","patch_set":3,"id":"b0d9bb35_144eedcc","line":103,"range":{"start_line":101,"start_character":8,"end_line":103,"end_character":0},"in_reply_to":"0ae7c11d_548597dc","updated":"2022-04-26 09:04:52.000000000","message":"Done","commit_id":"58582b5ed692661eb2f61fde40c7b5e8138ea7ea"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"a205e9138d0e104149a6a252698f1b3ec6a804e7","unresolved":true,"context_lines":[{"line_number":98,"context_line":"            msg \u003d _(\u0027Share server or vserver name not provided\u0027)"},{"line_number":99,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if not self._client.vserver_exists(vserver):"},{"line_number":102,"context_line":"            raise exception.VserverNotFound(vserver\u003dvserver)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        if backend_name:"},{"line_number":105,"context_line":"            vserver_client \u003d data_motion.get_client_for_backend("},{"line_number":106,"context_line":"                backend_name, vserver"}],"source_content_type":"text/x-python","patch_set":3,"id":"0ae7c11d_548597dc","line":103,"range":{"start_line":101,"start_character":8,"end_line":103,"end_character":0},"in_reply_to":"e877da9d_6889d6ae","updated":"2022-04-25 15:55:01.000000000","message":"I suggest to use\n```\n            backend_client \u003d data_motion.get_client_for_backend(backend_name)\n            if not backend_client.vserver_exists(vserver):\n                raise exception.VserverNotFound(vserver\u003dvserver)\n```\n\nin this case","commit_id":"58582b5ed692661eb2f61fde40c7b5e8138ea7ea"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ea1d46c242062f88eab916ca8219a399a84985eb","unresolved":true,"context_lines":[{"line_number":99,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if backend_name:"},{"line_number":102,"context_line":"            backend_client \u003d data_motion.get_client_for_backend(backend_name)"},{"line_number":103,"context_line":"            if not backend_client.vserver_exists(vserver):"},{"line_number":104,"context_line":"                raise exception.VserverNotFound(vserver\u003dvserver)"},{"line_number":105,"context_line":"            vserver_client \u003d data_motion.get_client_for_backend("},{"line_number":106,"context_line":"                backend_name, vserver"},{"line_number":107,"context_line":"            )"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            if not self._client.vserver_exists(vserver):"},{"line_number":110,"context_line":"                raise exception.VserverNotFound(vserver\u003dvserver)"},{"line_number":111,"context_line":"            vserver_client \u003d self._get_api_client(vserver)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        return vserver, vserver_client"}],"source_content_type":"text/x-python","patch_set":6,"id":"6c1609a9_9fd05cae","line":110,"range":{"start_line":102,"start_character":11,"end_line":110,"end_character":64},"updated":"2022-08-31 00:11:37.000000000","message":"The \"vserver_exists\" is called by both \"if\" conditions, so you could leave as it was before: a single \"vserver_exists\" check. Also, the new code is creating two clients, instead of one (as before), each client initialization requires some storage calls consuming bandwidth and taking time. It should be avoided, if possible.\n\nThe root cause of the reported bug is because the client method \"vserver_exist: is not setting the \"tunneling\" and the default is True. So, it is trying to check if the vserver exists tunneling to the vserver that does not exist yet. It will fail.\n\nHowever, we could call the \"vserver_exists\" on send_request with tunneling\u003dFalse[1]. This would solve the problem directly on client layer, without creating client twice.\n\nExcept in this reported case, all callers of \"vserver_exists\" are not using tunneling, because even the method is requesting the tunneling, the API layer only forces the tunneling when the requester client has a vserver. All \"vserver_exists\" are called using the \"self._client\" that does not have a vserver.\n\n\n[1]https://github.com/openstack/manila/blob/master/manila/share/drivers/netapp/dataontap/client/client_cmode.py#L294","commit_id":"0de6b3ece95938bac732fa92c2a4e017a92c3a4b"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"648af9fcf02a5f233526a5635e47d1ea77a49606","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if backend_name:"},{"line_number":102,"context_line":"            backend_client \u003d data_motion.get_client_for_backend(backend_name)"},{"line_number":103,"context_line":"            if not backend_client.vserver_exists(vserver):"},{"line_number":104,"context_line":"                raise exception.VserverNotFound(vserver\u003dvserver)"},{"line_number":105,"context_line":"            vserver_client \u003d data_motion.get_client_for_backend("},{"line_number":106,"context_line":"                backend_name, vserver"},{"line_number":107,"context_line":"            )"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            if not self._client.vserver_exists(vserver):"},{"line_number":110,"context_line":"                raise exception.VserverNotFound(vserver\u003dvserver)"},{"line_number":111,"context_line":"            vserver_client \u003d self._get_api_client(vserver)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        return vserver, vserver_client"}],"source_content_type":"text/x-python","patch_set":6,"id":"3b733aa4_3aed5703","line":110,"range":{"start_line":102,"start_character":11,"end_line":110,"end_character":64},"in_reply_to":"6c1609a9_9fd05cae","updated":"2022-11-02 17:02:57.000000000","message":"Ack","commit_id":"0de6b3ece95938bac732fa92c2a4e017a92c3a4b"}],"releasenotes/notes/fix-vserver-client-in-case-vserver-not-present-92b8a710a08f90e6.yaml":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6c2a2e01a9357dd78d3c33e4543d7b2a610ce3c9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp driver: When manila share server is in error state and backend"},{"line_number":5,"context_line":"    vserver is not created, but DB objects for share server and share are"},{"line_number":6,"context_line":"    present. In order to correctly perform share deletion, we should"},{"line_number":7,"context_line":"    check vserver existence with the cluster client instead of tunneling to"},{"line_number":8,"context_line":"    the vserver client. For more details, please refer to"},{"line_number":9,"context_line":"    `launchpad bug #1964592 \u003chttps://bugs.launchpad.net/manila/+bug/1964592\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"0abe722c_8d1e5ac8","line":8,"range":{"start_line":4,"start_character":20,"end_line":8,"end_character":22},"updated":"2022-11-23 02:05:25.000000000","message":"too much coder/verbose. The release note is for admin/users, code explanation is not much desired. We don\u0027t need to explain how it was solved, since the admin/users are not interested in it. They want to know which feature is working now. Please, summarize the fix. Maybe:\n\nNetApp driver can now delete share server in error state that had not been created on storage side. For more details, please refer to ...","commit_id":"aa1ac4c4b8af585c4b102d9cf403ff254e3250d3"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"8a0046cb5ca7d72fc3cc3e726d757b1659772558","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp driver: When manila share server is in error state and backend"},{"line_number":5,"context_line":"    vserver is not created, but DB objects for share server and share are"},{"line_number":6,"context_line":"    present. In order to correctly perform share deletion, we should"},{"line_number":7,"context_line":"    check vserver existence with the cluster client instead of tunneling to"},{"line_number":8,"context_line":"    the vserver client. For more details, please refer to"},{"line_number":9,"context_line":"    `launchpad bug #1964592 \u003chttps://bugs.launchpad.net/manila/+bug/1964592\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"d67298ad_68261ab9","line":8,"range":{"start_line":4,"start_character":20,"end_line":8,"end_character":22},"in_reply_to":"0abe722c_8d1e5ac8","updated":"2022-11-23 08:52:37.000000000","message":"Done","commit_id":"aa1ac4c4b8af585c4b102d9cf403ff254e3250d3"}]}
