)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b1c16543c0396b6a00d799b95f826fc3d68c0440","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7388e796_62733f42","updated":"2022-05-05 14:17:42.000000000","message":"I think a few unit tests should be fixed in this issue. Could you please take a look on that?","commit_id":"b14a4cbee74c14eb86f7a9b7c35454640ca915ea"},{"author":{"_account_id":33986,"name":"Lucas Morais de oliveira","email":"lucasmoliveira059@gmail.com","username":"lucasmoliveira059"},"change_message_id":"6fce3809a0e9832b9fa81db8f31e16d34aae9113","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"35033acf_b220fec9","in_reply_to":"7388e796_62733f42","updated":"2022-05-30 12:14:20.000000000","message":"Thanks Carlos. The unit tests has been fixed \u003d).","commit_id":"b14a4cbee74c14eb86f7a9b7c35454640ca915ea"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"7eb63dafd4612b84fee43471f21a14df31a46fea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"808f6b6a_6955009f","updated":"2025-03-11 10:09:39.000000000","message":"recheck","commit_id":"5c123ede6c10cc807cb4d86b62f2f11ca631c487"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"891b786a01e93a84c33cc9df4f96afc67c09c8dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a25f8d44_9e05297f","updated":"2025-03-05 15:19:17.000000000","message":"recheck","commit_id":"5c123ede6c10cc807cb4d86b62f2f11ca631c487"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"00351f9179d2076ee3c78d2d8e9c6fd18de12f8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cff548da_c080a280","updated":"2025-03-26 19:07:08.000000000","message":"Looking good, thanks for working on this change, Sai! Thinking if it needs a release note but I\u0027m unsure, as apparently this will not result on something that impacts the end user usability. @gouthampravi@gmail.com thoughs? :)","commit_id":"d01e55b937b45ff0eb29c98b3d17d21459927513"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cdd00a741b0dc45d42355a1655a7668358159af6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"86eae8ea_df0ca12a","in_reply_to":"cff548da_c080a280","updated":"2025-10-20 19:17:33.000000000","message":"driver maintainers of out-of-tree drivers _might_ care about this.. but we\u0027d have to be explicit in the note that this is something driver maintainers need to pay attention to.","commit_id":"d01e55b937b45ff0eb29c98b3d17d21459927513"}],"manila/share/utils.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cdd00a741b0dc45d42355a1655a7668358159af6","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        \u0027host\u0027: share_instance_ref[\u0027host\u0027],"},{"line_number":145,"context_line":"        \u0027status\u0027: share_instance_ref[\u0027status\u0027],"},{"line_number":146,"context_line":"        \u0027share_type_id\u0027: share_instance_ref[\u0027share_type_id\u0027],"},{"line_number":147,"context_line":"        \u0027share_type\u0027: share_instance_ref[\u0027share_type\u0027],"},{"line_number":148,"context_line":"    }"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    usage_info.update(extra_usage_info)"}],"source_content_type":"text/x-python","patch_set":7,"id":"c206ff74_71243c86","line":147,"range":{"start_line":147,"start_character":0,"end_line":147,"end_character":55},"updated":"2025-10-20 19:17:33.000000000","message":"why was this change necessary?","commit_id":"d01e55b937b45ff0eb29c98b3d17d21459927513"}],"manila/tests/share/test_manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cdd00a741b0dc45d42355a1655a7668358159af6","unresolved":true,"context_lines":[{"line_number":237,"context_line":"            self.share_manager.access_helper, \u0027update_access_rules\u0027)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        dict_instances \u003d [self._get_share_instance_dict("},{"line_number":240,"context_line":"            instance, share_server\u003d\u0027share_server\u0027) for instance in instances]"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        self.share_manager.ensure_driver_resources(self.context)"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"cd5ad016_0f182020","side":"PARENT","line":240,"updated":"2025-10-20 19:17:33.000000000","message":"What breaks here? \n\nYou should be able to mock \"get_share_attributes_from_share_type\" and still keep these lines..","commit_id":"eb131b92d80c2f4de114c2323d8f2d9120a07ee8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cdd00a741b0dc45d42355a1655a7668358159af6","unresolved":true,"context_lines":[{"line_number":9121,"context_line":"        ]"},{"line_number":9122,"context_line":"        self.mock_object("},{"line_number":9123,"context_line":"            self.share_manager, \u0027_get_extra_specs_from_share_type\u0027,"},{"line_number":9124,"context_line":"            mock.Mock(return_value\u003d{}))"},{"line_number":9125,"context_line":"        self.mock_object(self.share_manager, \u0027driver\u0027)"},{"line_number":9126,"context_line":"        self.mock_object(self.share_manager.db,"},{"line_number":9127,"context_line":"                         \u0027share_instance_get_all_by_host\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"f0008899_fe2d6c1e","line":9124,"range":{"start_line":9124,"start_character":35,"end_line":9124,"end_character":37},"updated":"2025-10-20 19:17:33.000000000","message":"these would never be {} - there\u0027s always some data: https://opendev.org/openstack/manila/src/commit/d17634044a10b2753813125cfb0d171d353ee007/manila/share/api.py#L702-L708","commit_id":"d01e55b937b45ff0eb29c98b3d17d21459927513"}]}