)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dcb3e619339e4a8ffce6e35629f4e8e98785bc1f","unresolved":true,"context_lines":[{"line_number":11,"context_line":"additional api call to the NetApp storage back end."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibc21b6c72d76a3a804f67e66e7604b3d0be4373f"},{"line_number":14,"context_line":"Closes-Bug: #1971710"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5ec52dc0_7c2c35bd","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":20},"updated":"2022-09-15 18:23:26.000000000","message":"Felipe and I were chatting about this; and we feel that this doesn\u0027t really address the root cause here. The bug mentions that a significant number of snapshots went \"missing\" on a busy storage cluster. It\u0027s possible that they were deleted externally; in any case, the check being added here isn\u0027t problematic - i like that it\u0027ll error out in case the snapshot wasn\u0027t created, allowing the user to try again (maybe add a user message too suggesting that the user retry the request, as a follow up - it\u0027ll be nice to have)\n\nIf teh storage system was lying about a snapshot not existing, the record of the snapshot still exists in manila, in \"error\" state, and the user that owns the snapshot may choose to delete it which will clean up the snapshot from the backend as well if it existed. \n\nSo the approach to add a check makes sense; what doesn\u0027t is us thinking this is the fix to the bug :) Perhaps you should report to NetApp since the snapshot-create ZAPI is misbehaving on busy storage clusters? \n\nIn any case, this patch can reference the bug as \"Related-Bug\" rather than \"Closes-Bug\"","commit_id":"0e7eeeffeb2a7d43cea9e86aa772fb56cdb6a261"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"3aabb595808a4cdc209227948c9f0d6d151ebbb4","unresolved":true,"context_lines":[{"line_number":11,"context_line":"additional api call to the NetApp storage back end."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibc21b6c72d76a3a804f67e66e7604b3d0be4373f"},{"line_number":14,"context_line":"Closes-Bug: #1971710"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d729010e_aa9247a2","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":20},"in_reply_to":"5ec52dc0_7c2c35bd","updated":"2022-09-15 18:25:48.000000000","message":"+1","commit_id":"0e7eeeffeb2a7d43cea9e86aa772fb56cdb6a261"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0e50ea25ddde492c9c44d8eb0b88c94e6e6a1dc0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"additional api call to the NetApp storage back end."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibc21b6c72d76a3a804f67e66e7604b3d0be4373f"},{"line_number":14,"context_line":"Closes-Bug: #1971710"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a0f5fe0c_32b9306b","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":20},"in_reply_to":"d729010e_aa9247a2","updated":"2022-10-15 14:48:15.000000000","message":"Done","commit_id":"0e7eeeffeb2a7d43cea9e86aa772fb56cdb6a261"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f0e45c41e2faa17291ef29f2e7bc84afe4d9cca4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4deae7ee_c4d5d7ff","updated":"2022-09-15 15:34:23.000000000","message":"Could you please add a release note to this change? :)","commit_id":"78af9b8809487787d5b68916f5b4dd82f0feba0c"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"7187d302d5e967ad20a0a623ae808753649095a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a5de44d8_cb892aaa","in_reply_to":"4deae7ee_c4d5d7ff","updated":"2022-09-15 16:07:58.000000000","message":"fixed","commit_id":"78af9b8809487787d5b68916f5b4dd82f0feba0c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"40db5fdbca205df111350a58ee88f9fbac1d170b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"81337460_3c4faba9","updated":"2022-10-13 19:40:09.000000000","message":"\u003e Patch Set 3:\n\u003e \n\u003e Build failed.\n\u003e \n\u003e - manila-tempest-plugin-ontap-dhss https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/73/840673/3/upstream-check/manila-tempest-plugin-ontap-dhss/2b56146/ : FAILURE in 1h 32m 47s\n\u003e - manila-tempest-plugin-ontap-no-dhss https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/73/840673/3/upstream-check/manila-tempest-plugin-ontap-no-dhss/77fcc5a/ : SUCCESS in 1h 16m 51s\n\u003e \n\u003e Comment \"run-NetApp CI\" to rerun these tests. https://wiki.openstack.org/wiki/ThirdPartySystems/NetApp_CI\n\n\nIt has run, but failed, so the re checkin should help","commit_id":"321fb13af99a3512a15a97b28313a1814dc6b30e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"d9a0d6df564cf70a45841213d02ddf81102794ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3a33c8ed_ed585370","updated":"2022-10-13 19:53:51.000000000","message":"LGTM","commit_id":"321fb13af99a3512a15a97b28313a1814dc6b30e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"541e584b06c5f180c5c9e32f8eddc413534c4932","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"23af98cb_cc58437c","updated":"2022-10-13 19:39:33.000000000","message":"run-NetApp-CI\n\nThanks, LGTM. NetApp CI hasn\u0027t run on the latest change.. ","commit_id":"321fb13af99a3512a15a97b28313a1814dc6b30e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"587bc33b8a8d6899458295f192c39c8d237b3ab0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b928cc57_5e42e8c2","updated":"2022-11-23 02:07:04.000000000","message":"LGTM","commit_id":"c0015bce086570794b2bbda25b0b5438a851382b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"03c0eae72a84a9bfd5527bb7af2a28e9229484ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fde0cd35_9964419d","updated":"2022-12-16 14:07:57.000000000","message":"LGTM. thanks for the fix, Maurice","commit_id":"c0015bce086570794b2bbda25b0b5438a851382b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"4b028e6efbf7ba100c2420f3c804b4c7d06058a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"193fe2f5_8875df09","updated":"2022-11-23 02:07:34.000000000","message":"run-NetApp CI","commit_id":"c0015bce086570794b2bbda25b0b5438a851382b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"030b351162c77275b3a0676af35a674781bed010","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d2055424_d49148b1","updated":"2023-01-03 17:26:33.000000000","message":"\"manila-tempest-plugin-ontap-dhss\" passed on previous versions of the patch and the current failures look like a misconfiguration and not caused by this change... Thanks!","commit_id":"f95cb40ee3a39872e71adaeeda1643f8b46694dc"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"cc5e41c6ff1054a6f709e7b5eeda2196b1567230","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"03fd6f01_aa6313be","updated":"2022-12-27 12:06:50.000000000","message":"LGTM","commit_id":"f95cb40ee3a39872e71adaeeda1643f8b46694dc"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"373c0d52489cac0dbf8ff99ec8458e69ead4f08e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"20f4dfef_4a7cf118","updated":"2023-01-04 07:42:36.000000000","message":"The failures of Pep and py38 are caused by tox \u003e 4.0.","commit_id":"f95cb40ee3a39872e71adaeeda1643f8b46694dc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d096224e40706981bd63b3a7d5dc4905e80341e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c3159d97_a43529e0","updated":"2023-01-04 18:10:45.000000000","message":"recheck\n\ntox4 fixes have merged on this branch","commit_id":"f95cb40ee3a39872e71adaeeda1643f8b46694dc"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"f803140dcb7ce03d5ca997d4fa3f57596d8b87cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"389d9363_f24b78ff","updated":"2022-12-26 23:56:20.000000000","message":"run-NetApp CI","commit_id":"f95cb40ee3a39872e71adaeeda1643f8b46694dc"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a6a4881c896bdc9db40d8fcc535eb1bb319a0767","unresolved":true,"context_lines":[{"line_number":1746,"context_line":"        snapshot_name \u003d self._get_backend_snapshot_name(snapshot[\u0027id\u0027])"},{"line_number":1747,"context_line":"        LOG.debug(\u0027Creating snapshot %s\u0027, snapshot_name)"},{"line_number":1748,"context_line":"        vserver_client.create_snapshot(share_name, snapshot_name)"},{"line_number":1749,"context_line":"        if not vserver_client.snapshot_exists(snapshot_name, share_name):"},{"line_number":1750,"context_line":"            raise exception.SnapshotResourceNotFound("},{"line_number":1751,"context_line":"                name\u003dsnapshot_name)"},{"line_number":1752,"context_line":""},{"line_number":1753,"context_line":"        return {\u0027provider_location\u0027: snapshot_name}"},{"line_number":1754,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6796f678_418b08aa","line":1751,"range":{"start_line":1749,"start_character":7,"end_line":1751,"end_character":35},"updated":"2022-07-05 20:06:10.000000000","message":"does it make sense to retry the creation instead of failing?","commit_id":"78af9b8809487787d5b68916f5b4dd82f0feba0c"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6ba3e0558142bcf97a117ffb59c49860adef243d","unresolved":false,"context_lines":[{"line_number":1746,"context_line":"        snapshot_name \u003d self._get_backend_snapshot_name(snapshot[\u0027id\u0027])"},{"line_number":1747,"context_line":"        LOG.debug(\u0027Creating snapshot %s\u0027, snapshot_name)"},{"line_number":1748,"context_line":"        vserver_client.create_snapshot(share_name, snapshot_name)"},{"line_number":1749,"context_line":"        if not vserver_client.snapshot_exists(snapshot_name, share_name):"},{"line_number":1750,"context_line":"            raise exception.SnapshotResourceNotFound("},{"line_number":1751,"context_line":"                name\u003dsnapshot_name)"},{"line_number":1752,"context_line":""},{"line_number":1753,"context_line":"        return {\u0027provider_location\u0027: snapshot_name}"},{"line_number":1754,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"406880a3_42918aec","line":1751,"range":{"start_line":1749,"start_character":7,"end_line":1751,"end_character":35},"in_reply_to":"2ebbd7d1_97af30fb","updated":"2022-11-23 02:07:15.000000000","message":"Done","commit_id":"78af9b8809487787d5b68916f5b4dd82f0feba0c"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"7d1ad80c95fb8c078aa897e3ece7e75fec1119f8","unresolved":true,"context_lines":[{"line_number":1746,"context_line":"        snapshot_name \u003d self._get_backend_snapshot_name(snapshot[\u0027id\u0027])"},{"line_number":1747,"context_line":"        LOG.debug(\u0027Creating snapshot %s\u0027, snapshot_name)"},{"line_number":1748,"context_line":"        vserver_client.create_snapshot(share_name, snapshot_name)"},{"line_number":1749,"context_line":"        if not vserver_client.snapshot_exists(snapshot_name, share_name):"},{"line_number":1750,"context_line":"            raise exception.SnapshotResourceNotFound("},{"line_number":1751,"context_line":"                name\u003dsnapshot_name)"},{"line_number":1752,"context_line":""},{"line_number":1753,"context_line":"        return {\u0027provider_location\u0027: snapshot_name}"},{"line_number":1754,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2ebbd7d1_97af30fb","line":1751,"range":{"start_line":1749,"start_character":7,"end_line":1751,"end_character":35},"in_reply_to":"6796f678_418b08aa","updated":"2022-07-06 11:57:51.000000000","message":"Can we reproduce a scenario where the snapshot is created successfully from the API call, but the snapshot is not there ?!","commit_id":"78af9b8809487787d5b68916f5b4dd82f0feba0c"}],"releasenotes/notes/netapp-check-snapshot-after-creation-1b59038a3a117c65.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"541e584b06c5f180c5c9e32f8eddc413534c4932","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    NetApp driver now checks after sending snapshot-create request that the"},{"line_number":5,"context_line":"    snapshot has been properly created. If snapshot is not checked, manila"},{"line_number":6,"context_line":"    assumes that working snapshot is available. But when user tries to access"},{"line_number":7,"context_line":"    the snapshot, request fails."},{"line_number":8,"context_line":"    `Launchpad bug 1971710 \u003chttps://bugs.launchpad.net/manila/+bug/1971710\u003e`_"},{"line_number":9,"context_line":"    for more details."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1aee4670_2ac8fb9b","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":31},"updated":"2022-10-13 19:39:33.000000000","message":"could fail","commit_id":"321fb13af99a3512a15a97b28313a1814dc6b30e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0e50ea25ddde492c9c44d8eb0b88c94e6e6a1dc0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    NetApp driver now checks after sending snapshot-create request that the"},{"line_number":5,"context_line":"    snapshot has been properly created. If snapshot is not checked, manila"},{"line_number":6,"context_line":"    assumes that working snapshot is available. But when user tries to access"},{"line_number":7,"context_line":"    the snapshot, request fails."},{"line_number":8,"context_line":"    `Launchpad bug 1971710 \u003chttps://bugs.launchpad.net/manila/+bug/1971710\u003e`_"},{"line_number":9,"context_line":"    for more details."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"37fe53ed_358167a1","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":31},"in_reply_to":"1aee4670_2ac8fb9b","updated":"2022-10-15 14:48:15.000000000","message":"Done","commit_id":"321fb13af99a3512a15a97b28313a1814dc6b30e"}]}