)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"213921a23aa90a4e3855fe1d3ebc363ca2e05396","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"49b4c173_4dc10373","updated":"2022-05-26 19:23:00.000000000","message":"Thanks Kiran, LGTM.. could you please add a bugfix release note and perhaps a unit test assertion?","commit_id":"c0fe9b37ea85cc41acb4439da1ad201c3207ea9e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0bff9d112a7009afbda250e97068cb6322489de7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0dc706df_193b940d","in_reply_to":"49b4c173_4dc10373","updated":"2022-05-29 09:09:01.000000000","message":"Fixed","commit_id":"c0fe9b37ea85cc41acb4439da1ad201c3207ea9e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0e202f3d283945813845e0609bb480d289d933ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b1890710_087a92e4","updated":"2022-06-07 17:32:58.000000000","message":"LGTM, thanks Kiran","commit_id":"8c854a1c6847e74b876ce84780afba72e1b87eae"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"78797baa5e5dd93b92e7b0ca20a5beff001a9e9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"09cae4e4_401b4b9e","updated":"2022-06-08 13:24:49.000000000","message":"Looks good! Thank you Kiran","commit_id":"8c854a1c6847e74b876ce84780afba72e1b87eae"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a3ec33416b4842fe1fc78bf70c208383f5d71538","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b12d46d3_a7bff81c","updated":"2022-06-09 07:44:36.000000000","message":"recheck","commit_id":"8c854a1c6847e74b876ce84780afba72e1b87eae"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"ed48303aef3931694a90d945ad8efa836d573e98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9c428a5a_193b69be","updated":"2022-05-30 01:38:24.000000000","message":"thanks for your change, Kiran.\n","commit_id":"8c854a1c6847e74b876ce84780afba72e1b87eae"}],"manila/api/v2/share_networks.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"ed48303aef3931694a90d945ad8efa836d573e98","unresolved":true,"context_lines":[{"line_number":411,"context_line":"                msg \u003d _(\u0027Could not create share network subnet.\u0027)"},{"line_number":412,"context_line":"                raise exc.HTTPInternalServerError(explanation\u003dmsg)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"            QUOTAS.commit(context, reservations)"},{"line_number":415,"context_line":"            share_network \u003d db_api.share_network_get(context,"},{"line_number":416,"context_line":"                                                     share_network[\u0027id\u0027])"},{"line_number":417,"context_line":"            return self._view_builder.build_share_network(req, share_network)"}],"source_content_type":"text/x-python","patch_set":2,"id":"93afc343_d7b1db5f","line":414,"range":{"start_line":414,"start_character":12,"end_line":414,"end_character":48},"updated":"2022-05-30 01:38:24.000000000","message":"we could better move this to line:408, if failed to commit reservations, also need to rollback.\n\n            try:\n                db_api.share_network_subnet_create(\n                    context, share_network_subnet_values)\n                QUOTAS.commit(context, reservations)\n            except db_exception.DBError:\n                db_api.share_network_delete(context, share_network[\u0027id\u0027])\n                QUOTAS.rollback(context, reservations)\n                msg \u003d _(\u0027Could not create share network subnet.\u0027)\n                raise exc.HTTPInternalServerError(explanation\u003dmsg)","commit_id":"8c854a1c6847e74b876ce84780afba72e1b87eae"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"40104cf8a1fc5f5a37afe8f76a5f8f8208db4c32","unresolved":true,"context_lines":[{"line_number":411,"context_line":"                msg \u003d _(\u0027Could not create share network subnet.\u0027)"},{"line_number":412,"context_line":"                raise exc.HTTPInternalServerError(explanation\u003dmsg)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"            QUOTAS.commit(context, reservations)"},{"line_number":415,"context_line":"            share_network \u003d db_api.share_network_get(context,"},{"line_number":416,"context_line":"                                                     share_network[\u0027id\u0027])"},{"line_number":417,"context_line":"            return self._view_builder.build_share_network(req, share_network)"}],"source_content_type":"text/x-python","patch_set":2,"id":"83cf1261_5d9e105b","line":414,"range":{"start_line":414,"start_character":12,"end_line":414,"end_character":48},"in_reply_to":"93afc343_d7b1db5f","updated":"2022-05-30 09:11:22.000000000","message":"I check few other places where commit is used and I dont see its under try-except where rollback is called on failure. So I will prefer keep as it is.","commit_id":"8c854a1c6847e74b876ce84780afba72e1b87eae"}]}