)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8ccb61adee9d765261dba74d855a08e5bbc2de3","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"WIP Working on testing coverage"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"bp use-cephadm-nfs-ganesha"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I1826f2970528928a31b32a664013380e38bbd7c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8ef787a7_be1fab2e","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":26},"updated":"2022-08-24 22:05:37.000000000","message":"Implements: bp/use-cephadm-nfs-ganesha","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"0690a70db113e3f23ba34daf9ad21d36ef08dc27","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"WIP Working on testing coverage"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"bp use-cephadm-nfs-ganesha"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I1826f2970528928a31b32a664013380e38bbd7c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ce80e8b2_34dd28f0","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":26},"in_reply_to":"8ef787a7_be1fab2e","updated":"2022-08-31 22:20:34.000000000","message":"Done","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8ccb61adee9d765261dba74d855a08e5bbc2de3","unresolved":true,"context_lines":[{"line_number":16,"context_line":"WIP Working on testing coverage"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"bp use-cephadm-nfs-ganesha"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I1826f2970528928a31b32a664013380e38bbd7c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"86e4cdc2_ea9fbb2f","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":0},"updated":"2022-08-24 22:05:37.000000000","message":"please add a DocImpact to add some documentation to the ceph admin and config docs","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"0690a70db113e3f23ba34daf9ad21d36ef08dc27","unresolved":false,"context_lines":[{"line_number":16,"context_line":"WIP Working on testing coverage"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"bp use-cephadm-nfs-ganesha"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I1826f2970528928a31b32a664013380e38bbd7c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfbdc918_2ae5568e","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":0},"in_reply_to":"86e4cdc2_ea9fbb2f","updated":"2022-08-31 22:20:34.000000000","message":"Done","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9adb0a1d66ba86228dfbc4ebbe9c041a2bdd0a35","unresolved":true,"context_lines":[{"line_number":13,"context_line":"the nfs plugin. Read more about this plugin in"},{"line_number":14,"context_line":"https://docs.ceph.com/en/latest/cephfs/nfs/"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"WIP Working on testing coverage"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: bp/use-cephadm-nfs-ganesha"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"acc2b7d4_cd9bb615","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":31},"updated":"2022-09-06 22:21:03.000000000","message":"I think this WIP is mostly done at this point?\n\nI think it\u0027d be worth adding a test or two to cover the update_access method: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_03d/848987/4/check/openstack-tox-cover/03d0b43/cover/d_3a429f71f404b988_driver_py.html#t1231\n\nTempest has covered it well though","commit_id":"442c78e651b32682a87f96efedce7987386ec4c8"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8f9c9e9b2f6db99b8be85750650f9dc64c8dc72d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"the nfs plugin. Read more about this plugin in"},{"line_number":14,"context_line":"https://docs.ceph.com/en/latest/cephfs/nfs/"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"WIP Working on testing coverage"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: bp/use-cephadm-nfs-ganesha"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"78eff368_facfe086","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":31},"in_reply_to":"acc2b7d4_cd9bb615","updated":"2022-09-07 15:43:18.000000000","message":"Yeah, that\u0027s one of the tests I have missing... just added some testing for the get export ips command, I\u0027ll add update_access next","commit_id":"442c78e651b32682a87f96efedce7987386ec4c8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e3f8f4c2f9fc0e5b59f22f768a28109279be3d4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"61108653_e2b7800f","updated":"2022-08-31 11:28:25.000000000","message":"Not much to add other than Goutham\u0027s comments! Thank you for working on this change\nDo you think we will be able to merge this change by EOW, so we won\u0027t need a feature freeze exception? :)","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8ccb61adee9d765261dba74d855a08e5bbc2de3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"087173f2_80e7b4c7","updated":"2022-08-24 22:05:37.000000000","message":"Thanks for working on this Victoria, please see comments inline","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"24dc489a4e3f7f4c1d8d2b6e6ece92ff146b8e34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"57f27b26_11e2a9ee","in_reply_to":"61108653_e2b7800f","updated":"2022-08-31 16:15:52.000000000","message":"Of course, I\u0027ll address comments by EOD today and we can review it again, thanks!","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9adb0a1d66ba86228dfbc4ebbe9c041a2bdd0a35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a6ba8c38_8cd174cb","updated":"2022-09-06 22:21:03.000000000","message":"Hi, Thank you for all the changes Victoria - sorry for the -1, but this is failing tests and could use some quick/minor fixes... ","commit_id":"442c78e651b32682a87f96efedce7987386ec4c8"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"48090fd9c358c4cb3b4015a3c5a3d641e7f5dd1e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"52ad4a55_5088745a","updated":"2022-09-05 21:02:37.000000000","message":"I checked how the mgr/nfs module interfaces are used in cephfs/driver.py. The driver code looks good to me. \n\nThere is no mention anywhere about the type of NFS cluster whose exports can be managed. The driver can only manage exports of NFS cluster deployed by cephadm (and in the future rook).  I think this should be mentioned in the release notes and the driver docs.\n\nI don\u0027t follow the upgrades section in the release notes. It mentions the \"nfs_cluster_id\" option. It doesn\u0027t say whether it\u0027s currently possible or not possible to upgrade from the existing NFS driver to the clustered NFS driver. ","commit_id":"442c78e651b32682a87f96efedce7987386ec4c8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7977a90046d7115d875f627dda63234ba0553522","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b1c9233a_ad746155","updated":"2022-09-01 14:50:24.000000000","message":"Thank you for working on the comments. Change LGTM.\nThere\u0027s a mention for WIP tests, which I am fine with. We can follow up with the change without major problems.","commit_id":"442c78e651b32682a87f96efedce7987386ec4c8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5605c735ece9f344f89b2bfba4b72078b69cd445","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8355c3f6_af4f1d31","in_reply_to":"52ad4a55_5088745a","updated":"2022-09-06 22:24:30.000000000","message":"\u003e There is no mention anywhere about the type of NFS cluster whose exports can be managed. The driver can only manage exports of NFS cluster deployed by cephadm (and in the future rook).  I think this should be mentioned in the release notes and the driver docs.\n\nI kinda asked for that mention to be removed from code so it would be generic for a time when rook-based nfs-ganesha clusters can also be supported with the driver as is. However, I agree we can address this in the release notes and documentation a bit. \n\n\n\u003e I don\u0027t follow the upgrades section in the release notes. It mentions the \"nfs_cluster_id\" option. It doesn\u0027t say whether it\u0027s currently possible or not possible to upgrade from the existing NFS driver to the clustered NFS driver.\n\nYes. I added a suggestion to improve this; we currently don\u0027t have an upgrade step, but it will come in the next release after we\u0027ve tested the HA bits with one of the two approaches we\u0027re pursuing on the ceph and nfs/ganesha repos (single/multiple IP keepalived, single-IP ceph-ingress with HAProxy)","commit_id":"442c78e651b32682a87f96efedce7987386ec4c8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"374f888e4901cb48658c6685332555b326637337","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c5d476e2_6dbf27c3","updated":"2022-09-08 12:52:56.000000000","message":"Thank you for the updates, LGTM","commit_id":"f32be69fc4ab836dce0cdf3ad5308f771b33f3f2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dd1e5630cee9612655ee7d42de4c9733b71b6683","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3c33432b_e3529ebf","updated":"2022-09-08 23:40:12.000000000","message":"we have some issues in the cephadm job that’s testing this change. But I’m hoping that’s the infrastructure or related to the ceph packages. The code here looks good. Thank you, Victoria!","commit_id":"f32be69fc4ab836dce0cdf3ad5308f771b33f3f2"}],"manila/share/drivers/cephfs/driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8ccb61adee9d765261dba74d855a08e5bbc2de3","unresolved":true,"context_lines":[{"line_number":138,"context_line":"    cfg.StrOpt(\u0027cephfs_filesystem_name\u0027,"},{"line_number":139,"context_line":"               help\u003d\"The name of the filesystem to use, if there are \""},{"line_number":140,"context_line":"                    \"multiple filesystems in the cluster.\"),"},{"line_number":141,"context_line":"    cfg.BoolOpt(\u0027cephadm_deploy\u0027,"},{"line_number":142,"context_line":"                default\u003dFalse,"},{"line_number":143,"context_line":"                help\u003d\"Wheter cephadm has been used for deployment or not.\"),"},{"line_number":144,"context_line":"]"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"cephfsnfs_opts \u003d ["},{"line_number":147,"context_line":"    cfg.StrOpt(\u0027nfs_cluster_id\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"67858c6c_2fb00ee9","line":144,"range":{"start_line":141,"start_character":3,"end_line":144,"end_character":1},"updated":"2022-08-24 22:05:37.000000000","message":"I think this option isn\u0027t needed when you have the one below; if a nfs_cluster_id is provided, we can use the ceph mgr commands. \n\nIts possible to create ceph nfs clusters without cephadm (manually, rook, etc) - but, we\u0027ll probably only ever support NFS clusters that we can use ceph mgr commands with.","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"6ec62648a60eb6d9e44fc2e00b81a0bc1989cdfb","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    cfg.StrOpt(\u0027cephfs_filesystem_name\u0027,"},{"line_number":139,"context_line":"               help\u003d\"The name of the filesystem to use, if there are \""},{"line_number":140,"context_line":"                    \"multiple filesystems in the cluster.\"),"},{"line_number":141,"context_line":"    cfg.BoolOpt(\u0027cephadm_deploy\u0027,"},{"line_number":142,"context_line":"                default\u003dFalse,"},{"line_number":143,"context_line":"                help\u003d\"Wheter cephadm has been used for deployment or not.\"),"},{"line_number":144,"context_line":"]"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"cephfsnfs_opts \u003d ["},{"line_number":147,"context_line":"    cfg.StrOpt(\u0027nfs_cluster_id\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1881aa61_1525619f","line":144,"range":{"start_line":141,"start_character":3,"end_line":144,"end_character":1},"in_reply_to":"67858c6c_2fb00ee9","updated":"2022-08-31 22:19:57.000000000","message":"Good idea","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8ccb61adee9d765261dba74d855a08e5bbc2de3","unresolved":true,"context_lines":[{"line_number":144,"context_line":"]"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"cephfsnfs_opts \u003d ["},{"line_number":147,"context_line":"    cfg.StrOpt(\u0027nfs_cluster_id\u0027,"},{"line_number":148,"context_line":"               help\u003d\"The ID of the NFS cluster to use, if there are \""},{"line_number":149,"context_line":"                    \"multiple NFS clusters in the deploy.\"),"},{"line_number":150,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"53e0764c_149c2183","line":147,"range":{"start_line":147,"start_character":16,"end_line":147,"end_character":30},"updated":"2022-08-24 22:05:37.000000000","message":"cephfs_nfs_cluster_id","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"6ec62648a60eb6d9e44fc2e00b81a0bc1989cdfb","unresolved":false,"context_lines":[{"line_number":144,"context_line":"]"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"cephfsnfs_opts \u003d ["},{"line_number":147,"context_line":"    cfg.StrOpt(\u0027nfs_cluster_id\u0027,"},{"line_number":148,"context_line":"               help\u003d\"The ID of the NFS cluster to use, if there are \""},{"line_number":149,"context_line":"                    \"multiple NFS clusters in the deploy.\"),"},{"line_number":150,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aad32a2_0e2cd37e","line":147,"range":{"start_line":147,"start_character":16,"end_line":147,"end_character":30},"in_reply_to":"53e0764c_149c2183","updated":"2022-08-31 22:19:57.000000000","message":"Done","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8ccb61adee9d765261dba74d855a08e5bbc2de3","unresolved":true,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"cephfsnfs_opts \u003d ["},{"line_number":147,"context_line":"    cfg.StrOpt(\u0027nfs_cluster_id\u0027,"},{"line_number":148,"context_line":"               help\u003d\"The ID of the NFS cluster to use, if there are \""},{"line_number":149,"context_line":"                    \"multiple NFS clusters in the deploy.\"),"},{"line_number":150,"context_line":"]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"236c46bd_70f760c4","line":149,"range":{"start_line":148,"start_character":55,"end_line":149,"end_character":57},"updated":"2022-08-24 22:05:37.000000000","message":"We\u0027ll always have to assign a cluster id when its being created: https://docs.ceph.com/en/octopus/cephfs/fs-nfs-exports/#create-nfs-ganesha-cluster","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"6ec62648a60eb6d9e44fc2e00b81a0bc1989cdfb","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"cephfsnfs_opts \u003d ["},{"line_number":147,"context_line":"    cfg.StrOpt(\u0027nfs_cluster_id\u0027,"},{"line_number":148,"context_line":"               help\u003d\"The ID of the NFS cluster to use, if there are \""},{"line_number":149,"context_line":"                    \"multiple NFS clusters in the deploy.\"),"},{"line_number":150,"context_line":"]"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f63bcd8_7c647056","line":149,"range":{"start_line":148,"start_character":55,"end_line":149,"end_character":57},"in_reply_to":"236c46bd_70f760c4","updated":"2022-08-31 22:19:57.000000000","message":"Done","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8ccb61adee9d765261dba74d855a08e5bbc2de3","unresolved":true,"context_lines":[{"line_number":975,"context_line":"            export_path \u003d \"{server_address}:{mount_path}\".format("},{"line_number":976,"context_line":"                server_address\u003dserver_address, mount_path\u003dsubvolume_path)"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"            LOG.info(\"Calculated export path for share %(id)s: %(epath)s\","},{"line_number":979,"context_line":"                     {\"id\": share[\u0027id\u0027], \"epath\": export_path})"},{"line_number":980,"context_line":"            export_location \u003d {"},{"line_number":981,"context_line":"                \u0027path\u0027: export_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"624f05bc_6457a700","line":978,"range":{"start_line":978,"start_character":16,"end_line":978,"end_character":20},"updated":"2022-08-24 22:05:37.000000000","message":"i feel like this should be done at \"debug\" rather than info...","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9adb0a1d66ba86228dfbc4ebbe9c041a2bdd0a35","unresolved":false,"context_lines":[{"line_number":975,"context_line":"            export_path \u003d \"{server_address}:{mount_path}\".format("},{"line_number":976,"context_line":"                server_address\u003dserver_address, mount_path\u003dsubvolume_path)"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"            LOG.info(\"Calculated export path for share %(id)s: %(epath)s\","},{"line_number":979,"context_line":"                     {\"id\": share[\u0027id\u0027], \"epath\": export_path})"},{"line_number":980,"context_line":"            export_location \u003d {"},{"line_number":981,"context_line":"                \u0027path\u0027: export_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"2864d07c_12a90779","line":978,"range":{"start_line":978,"start_character":16,"end_line":978,"end_character":20},"in_reply_to":"1da028f7_8362263d","updated":"2022-09-06 22:21:03.000000000","message":"ack; lets do that in a different change!","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"6ec62648a60eb6d9e44fc2e00b81a0bc1989cdfb","unresolved":false,"context_lines":[{"line_number":975,"context_line":"            export_path \u003d \"{server_address}:{mount_path}\".format("},{"line_number":976,"context_line":"                server_address\u003dserver_address, mount_path\u003dsubvolume_path)"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"            LOG.info(\"Calculated export path for share %(id)s: %(epath)s\","},{"line_number":979,"context_line":"                     {\"id\": share[\u0027id\u0027], \"epath\": export_path})"},{"line_number":980,"context_line":"            export_location \u003d {"},{"line_number":981,"context_line":"                \u0027path\u0027: export_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1da028f7_8362263d","line":978,"range":{"start_line":978,"start_character":16,"end_line":978,"end_character":20},"in_reply_to":"624f05bc_6457a700","updated":"2022-08-31 22:19:57.000000000","message":"This is part of the current CephFS NFS helper. Modifying the log level for this data as part of this change might generate confusion on existing users. Shall we do this change in a follow up change? It might be easier to trace in the future","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8ccb61adee9d765261dba74d855a08e5bbc2de3","unresolved":true,"context_lines":[{"line_number":1115,"context_line":"        rados_command(self.rados_client, \"fs subvolume deauthorize\", argdict)"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":"class CephAdmNFSProtocolHelper(NFSProtocolHelperMixin, ganesha.NASHelperBase):"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    supported_access_types \u003d (\u0027ip\u0027, )"},{"line_number":1121,"context_line":"    supported_access_levels \u003d (constants.ACCESS_LEVEL_RW,"}],"source_content_type":"text/x-python","patch_set":3,"id":"039910d1_2ea1e2ae","line":1118,"range":{"start_line":1118,"start_character":6,"end_line":1118,"end_character":30},"updated":"2022-08-24 22:05:37.000000000","message":"We could end up supporting rook deployed NFS clusters with this approach as well, should we call it something like NFSClusterProtocolHelper?","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"6ec62648a60eb6d9e44fc2e00b81a0bc1989cdfb","unresolved":false,"context_lines":[{"line_number":1115,"context_line":"        rados_command(self.rados_client, \"fs subvolume deauthorize\", argdict)"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":"class CephAdmNFSProtocolHelper(NFSProtocolHelperMixin, ganesha.NASHelperBase):"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    supported_access_types \u003d (\u0027ip\u0027, )"},{"line_number":1121,"context_line":"    supported_access_levels \u003d (constants.ACCESS_LEVEL_RW,"}],"source_content_type":"text/x-python","patch_set":3,"id":"87c3e207_8f4ef441","line":1118,"range":{"start_line":1118,"start_character":6,"end_line":1118,"end_character":30},"in_reply_to":"039910d1_2ea1e2ae","updated":"2022-08-31 22:19:57.000000000","message":"Done","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8ccb61adee9d765261dba74d855a08e5bbc2de3","unresolved":true,"context_lines":[{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"        self._nfs_clusterid \u003d self.configuration.safe_get(\u0027nfs_cluster_id\u0027)"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"        # FIXME(vkmc) Remove when using config option"},{"line_number":1144,"context_line":"        # this is the devstack default atm"},{"line_number":1145,"context_line":"        if not self._nfs_clusterid:"},{"line_number":1146,"context_line":"            self._nfs_clusterid \u003d \"cephfs\""},{"line_number":1147,"context_line":""},{"line_number":1148,"context_line":"        return self._nfs_clusterid"},{"line_number":1149,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d28a7761_87f39571","line":1146,"range":{"start_line":1143,"start_character":0,"end_line":1146,"end_character":42},"updated":"2022-08-24 22:05:37.000000000","message":"Could we add \"nfs_cluster_id\" config to the test job definitionn? (and then follow up with a devstack config opt if necessary) I suggest not having a default for this in code since you\u0027re always supposed to specify an ID when creating a ceph nfs cluster with cephadm; and not having a default will allow us to introduce one config option to switch to this mode of operation...","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"6ec62648a60eb6d9e44fc2e00b81a0bc1989cdfb","unresolved":false,"context_lines":[{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"        self._nfs_clusterid \u003d self.configuration.safe_get(\u0027nfs_cluster_id\u0027)"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"        # FIXME(vkmc) Remove when using config option"},{"line_number":1144,"context_line":"        # this is the devstack default atm"},{"line_number":1145,"context_line":"        if not self._nfs_clusterid:"},{"line_number":1146,"context_line":"            self._nfs_clusterid \u003d \"cephfs\""},{"line_number":1147,"context_line":""},{"line_number":1148,"context_line":"        return self._nfs_clusterid"},{"line_number":1149,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9e4b0f7f_c53d931c","line":1146,"range":{"start_line":1143,"start_character":0,"end_line":1146,"end_character":42},"in_reply_to":"d28a7761_87f39571","updated":"2022-08-31 22:19:57.000000000","message":"Ack. I\u0027ll raise a BackendException if the config is not set","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8ccb61adee9d765261dba74d855a08e5bbc2de3","unresolved":true,"context_lines":[{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"        return export_ips"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"    def _check_export_exists(self, share):"},{"line_number":1178,"context_line":"        \"\"\"Check a share has exports\"\"\""},{"line_number":1179,"context_line":"        nfs_clusterid \u003d self.nfs_clusterid"},{"line_number":1180,"context_line":"        export_exists \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"ed17d4ff_ae49576e","line":1177,"range":{"start_line":1177,"start_character":0,"end_line":1177,"end_character":42},"updated":"2022-08-24 22:05:37.000000000","message":"This method seems unused?","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"6ec62648a60eb6d9e44fc2e00b81a0bc1989cdfb","unresolved":false,"context_lines":[{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"        return export_ips"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"    def _check_export_exists(self, share):"},{"line_number":1178,"context_line":"        \"\"\"Check a share has exports\"\"\""},{"line_number":1179,"context_line":"        nfs_clusterid \u003d self.nfs_clusterid"},{"line_number":1180,"context_line":"        export_exists \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"aad5a30c_38ffb510","line":1177,"range":{"start_line":1177,"start_character":0,"end_line":1177,"end_character":42},"in_reply_to":"ed17d4ff_ae49576e","updated":"2022-08-31 22:19:57.000000000","message":"Done","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8ccb61adee9d765261dba74d855a08e5bbc2de3","unresolved":true,"context_lines":[{"line_number":1203,"context_line":"            \"path\": self._get_export_path(share),"},{"line_number":1204,"context_line":"            \"cluster_id\": self.nfs_clusterid,"},{"line_number":1205,"context_line":"            \"pseudo\": self._get_export_pseudo_path(share),"},{"line_number":1206,"context_line":"            # FIXME(vkmc) drop?"},{"line_number":1207,"context_line":"            \"access_type\": \"none\","},{"line_number":1208,"context_line":"            # configurable?"},{"line_number":1209,"context_line":"            \"squash\": \"none\","},{"line_number":1210,"context_line":"            \"security_label\": True,"}],"source_content_type":"text/x-python","patch_set":3,"id":"49e5dcf4_e2793d88","line":1207,"range":{"start_line":1206,"start_character":0,"end_line":1207,"end_character":34},"updated":"2022-08-24 22:05:37.000000000","message":"Yes, the current nfs protocol helper doesn\u0027t set it","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"6ec62648a60eb6d9e44fc2e00b81a0bc1989cdfb","unresolved":false,"context_lines":[{"line_number":1203,"context_line":"            \"path\": self._get_export_path(share),"},{"line_number":1204,"context_line":"            \"cluster_id\": self.nfs_clusterid,"},{"line_number":1205,"context_line":"            \"pseudo\": self._get_export_pseudo_path(share),"},{"line_number":1206,"context_line":"            # FIXME(vkmc) drop?"},{"line_number":1207,"context_line":"            \"access_type\": \"none\","},{"line_number":1208,"context_line":"            # configurable?"},{"line_number":1209,"context_line":"            \"squash\": \"none\","},{"line_number":1210,"context_line":"            \"security_label\": True,"}],"source_content_type":"text/x-python","patch_set":3,"id":"70f2af35_edcdd9d4","line":1207,"range":{"start_line":1206,"start_character":0,"end_line":1207,"end_character":34},"in_reply_to":"49e5dcf4_e2793d88","updated":"2022-08-31 22:19:57.000000000","message":"Ok, I\u0027ll drop it","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8ccb61adee9d765261dba74d855a08e5bbc2de3","unresolved":true,"context_lines":[{"line_number":1208,"context_line":"            # configurable?"},{"line_number":1209,"context_line":"            \"squash\": \"none\","},{"line_number":1210,"context_line":"            \"security_label\": True,"},{"line_number":1211,"context_line":"            \"protocols\": self.get_configured_ip_versions(),"},{"line_number":1212,"context_line":"            \"fsal\": {"},{"line_number":1213,"context_line":"                \"name\": \"CEPH\","},{"line_number":1214,"context_line":"                \"fs_name\": self.volname,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c72aa742_05eb861f","line":1211,"range":{"start_line":1211,"start_character":12,"end_line":1211,"end_character":59},"updated":"2022-08-24 22:05:37.000000000","message":"This configuration refers to NFS protocols; we haven\u0027t restricted the protocols supported with the driver to version 4.x here, (but we do in RHOSP). I think with this new driver helper, we could set the protocols to [4] and if anyone needs, we could later introduce a configuration to extend that to [3, 4]. WDYT?\n\n\nhttps://github.com/ceph/ceph/blob/6fee777d603aebce492c57b41f3b5760d50ddb07/src/pybind/mgr/nfs/ganesha_conf.py#L465-L467","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"0690a70db113e3f23ba34daf9ad21d36ef08dc27","unresolved":false,"context_lines":[{"line_number":1208,"context_line":"            # configurable?"},{"line_number":1209,"context_line":"            \"squash\": \"none\","},{"line_number":1210,"context_line":"            \"security_label\": True,"},{"line_number":1211,"context_line":"            \"protocols\": self.get_configured_ip_versions(),"},{"line_number":1212,"context_line":"            \"fsal\": {"},{"line_number":1213,"context_line":"                \"name\": \"CEPH\","},{"line_number":1214,"context_line":"                \"fs_name\": self.volname,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ed024a92_08c75944","line":1211,"range":{"start_line":1211,"start_character":12,"end_line":1211,"end_character":59},"in_reply_to":"0c73e673_44ab756f","updated":"2022-08-31 22:20:34.000000000","message":"Done","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"6ec62648a60eb6d9e44fc2e00b81a0bc1989cdfb","unresolved":true,"context_lines":[{"line_number":1208,"context_line":"            # configurable?"},{"line_number":1209,"context_line":"            \"squash\": \"none\","},{"line_number":1210,"context_line":"            \"security_label\": True,"},{"line_number":1211,"context_line":"            \"protocols\": self.get_configured_ip_versions(),"},{"line_number":1212,"context_line":"            \"fsal\": {"},{"line_number":1213,"context_line":"                \"name\": \"CEPH\","},{"line_number":1214,"context_line":"                \"fs_name\": self.volname,"}],"source_content_type":"text/x-python","patch_set":3,"id":"0c73e673_44ab756f","line":1211,"range":{"start_line":1211,"start_character":12,"end_line":1211,"end_character":59},"in_reply_to":"c72aa742_05eb861f","updated":"2022-08-31 22:19:57.000000000","message":"Good catch. Yes, that would make sense as a first iteration","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9adb0a1d66ba86228dfbc4ebbe9c041a2bdd0a35","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        self._volname \u003d None"},{"line_number":234,"context_line":"        self._ceph_mon_version \u003d None"},{"line_number":235,"context_line":"        self.configuration.append_config_values(cephfs_opts)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        try:"},{"line_number":238,"context_line":"            int(self.configuration.cephfs_volume_mode, 8)"},{"line_number":239,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"b9723539_290c3c7a","line":236,"updated":"2022-09-06 22:21:03.000000000","message":"to use the \"cephfs_nfs_cluster_id\" configuration option in the do_setup method below, \"cephfsnfs_opts\" must also be added to the self.configuration list.\n\nWithout that, we fail the driver setup: https://zuul.opendev.org/t/openstack/build/8f5b3f9bfa184687a14496277fd615fe/log/controller/logs/screen-m-shr.txt#109-127","commit_id":"442c78e651b32682a87f96efedce7987386ec4c8"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8f9c9e9b2f6db99b8be85750650f9dc64c8dc72d","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        self._volname \u003d None"},{"line_number":234,"context_line":"        self._ceph_mon_version \u003d None"},{"line_number":235,"context_line":"        self.configuration.append_config_values(cephfs_opts)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        try:"},{"line_number":238,"context_line":"            int(self.configuration.cephfs_volume_mode, 8)"},{"line_number":239,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"cc74d4bd_61ca32f6","line":236,"in_reply_to":"b9723539_290c3c7a","updated":"2022-09-07 15:43:18.000000000","message":"Good catch, completely missed this, fixing it in the next ps","commit_id":"442c78e651b32682a87f96efedce7987386ec4c8"}],"manila/tests/share/drivers/cephfs/test_driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9adb0a1d66ba86228dfbc4ebbe9c041a2bdd0a35","unresolved":true,"context_lines":[{"line_number":1310,"context_line":"            \"path\": \"ganesha:/foo/bar\","},{"line_number":1311,"context_line":"            \"cluster_id\": nfs_clusterid,"},{"line_number":1312,"context_line":"            \"pseudo\": \"ganesha:/foo/bar\","},{"line_number":1313,"context_line":"            # FIXME)(vkmc) configurable?"},{"line_number":1314,"context_line":"            \"squash\": \"none\","},{"line_number":1315,"context_line":"            \"security_label\": True,"},{"line_number":1316,"context_line":"            \"protocols\": protocols,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da78bdb6_9c0097ff","line":1313,"range":{"start_line":1313,"start_character":14,"end_line":1313,"end_character":19},"updated":"2022-09-06 22:21:03.000000000","message":"(","commit_id":"442c78e651b32682a87f96efedce7987386ec4c8"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8f9c9e9b2f6db99b8be85750650f9dc64c8dc72d","unresolved":false,"context_lines":[{"line_number":1310,"context_line":"            \"path\": \"ganesha:/foo/bar\","},{"line_number":1311,"context_line":"            \"cluster_id\": nfs_clusterid,"},{"line_number":1312,"context_line":"            \"pseudo\": \"ganesha:/foo/bar\","},{"line_number":1313,"context_line":"            # FIXME)(vkmc) configurable?"},{"line_number":1314,"context_line":"            \"squash\": \"none\","},{"line_number":1315,"context_line":"            \"security_label\": True,"},{"line_number":1316,"context_line":"            \"protocols\": protocols,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1326a4a9_ce873173","line":1313,"range":{"start_line":1313,"start_character":14,"end_line":1313,"end_character":19},"in_reply_to":"da78bdb6_9c0097ff","updated":"2022-09-07 15:43:18.000000000","message":"Done","commit_id":"442c78e651b32682a87f96efedce7987386ec4c8"}],"releasenotes/notes/use-cephadm-nfs-ganesha-b9e071924de738fd.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8ccb61adee9d765261dba74d855a08e5bbc2de3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    CephAdmNFSProtocol helper has been added to allow users to consume NFS clusters"},{"line_number":5,"context_line":"    deployed using cephadm. This presents many advantages, since the operator no longer"},{"line_number":6,"context_line":"    needs to maintain their own instances of NFS Ganesha apart of the Ceph cluster."},{"line_number":7,"context_line":"    For this, we now communicate with ceph mgr using the nfs plugin. Read more"},{"line_number":8,"context_line":"    about this plugin in https://docs.ceph.com/en/latest/cephfs/nfs/"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5d122805_70b8ac30","line":5,"range":{"start_line":4,"start_character":71,"end_line":5,"end_character":26},"updated":"2022-08-24 22:05:37.000000000","message":"suggest: to export CephFS shares over a clustered NFS gateway.","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"6ec62648a60eb6d9e44fc2e00b81a0bc1989cdfb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    CephAdmNFSProtocol helper has been added to allow users to consume NFS clusters"},{"line_number":5,"context_line":"    deployed using cephadm. This presents many advantages, since the operator no longer"},{"line_number":6,"context_line":"    needs to maintain their own instances of NFS Ganesha apart of the Ceph cluster."},{"line_number":7,"context_line":"    For this, we now communicate with ceph mgr using the nfs plugin. Read more"},{"line_number":8,"context_line":"    about this plugin in https://docs.ceph.com/en/latest/cephfs/nfs/"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c533f84b_b82d2fe5","line":5,"range":{"start_line":4,"start_character":71,"end_line":5,"end_character":26},"in_reply_to":"5d122805_70b8ac30","updated":"2022-08-31 22:19:57.000000000","message":"Done","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8ccb61adee9d765261dba74d855a08e5bbc2de3","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    about this plugin in https://docs.ceph.com/en/latest/cephfs/nfs/"},{"line_number":9,"context_line":"other:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Two new configuration options has been added and will be deprecated in the upcoming"},{"line_number":12,"context_line":"    releases. The new configuration options are:"},{"line_number":13,"context_line":"    * cephadm_deploy (boolean option): whether the underlying Ceph cluster has been deployed"},{"line_number":14,"context_line":"    with cephadm or not. This can be turned on by the operator to choose which helper to use."},{"line_number":15,"context_line":"    Defaults to False (uses the current helper)."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2246274d_7fc0d5c9","line":12,"range":{"start_line":11,"start_character":49,"end_line":12,"end_character":12},"updated":"2022-08-24 22:05:37.000000000","message":"you mean we\u0027d deprecate the existing helper (and associated configuration options) for use with the CephFS driver? That makes sense in the \"other\" section; specify the two new options being introduced in the \"upgrade\" section","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"6ec62648a60eb6d9e44fc2e00b81a0bc1989cdfb","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    about this plugin in https://docs.ceph.com/en/latest/cephfs/nfs/"},{"line_number":9,"context_line":"other:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    Two new configuration options has been added and will be deprecated in the upcoming"},{"line_number":12,"context_line":"    releases. The new configuration options are:"},{"line_number":13,"context_line":"    * cephadm_deploy (boolean option): whether the underlying Ceph cluster has been deployed"},{"line_number":14,"context_line":"    with cephadm or not. This can be turned on by the operator to choose which helper to use."},{"line_number":15,"context_line":"    Defaults to False (uses the current helper)."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a0765870_ca643b94","line":12,"range":{"start_line":11,"start_character":49,"end_line":12,"end_character":12},"in_reply_to":"2246274d_7fc0d5c9","updated":"2022-08-31 22:19:57.000000000","message":"Ack","commit_id":"c80e0e23d71efc2c5513b5a9334b90926171a52a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9adb0a1d66ba86228dfbc4ebbe9c041a2bdd0a35","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    about this plugin in https://docs.ceph.com/en/latest/cephfs/nfs/"},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    One new configuration option has been added. The new configuration option is:"},{"line_number":12,"context_line":"    * cephfs_nfs_cluster_id (string option): name of the nfs cluster to use."},{"line_number":13,"context_line":"    This option can be used to specify which NFS cluster to use."},{"line_number":14,"context_line":"other:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6ba699e2_414ec0fa","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":80},"updated":"2022-09-06 22:21:03.000000000","message":"The CephFS driver now supports a new configuration option:","commit_id":"442c78e651b32682a87f96efedce7987386ec4c8"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8f9c9e9b2f6db99b8be85750650f9dc64c8dc72d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    about this plugin in https://docs.ceph.com/en/latest/cephfs/nfs/"},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    One new configuration option has been added. The new configuration option is:"},{"line_number":12,"context_line":"    * cephfs_nfs_cluster_id (string option): name of the nfs cluster to use."},{"line_number":13,"context_line":"    This option can be used to specify which NFS cluster to use."},{"line_number":14,"context_line":"other:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"30dfa111_d871223e","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":80},"in_reply_to":"6ba699e2_414ec0fa","updated":"2022-09-07 15:43:18.000000000","message":"Done","commit_id":"442c78e651b32682a87f96efedce7987386ec4c8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9adb0a1d66ba86228dfbc4ebbe9c041a2bdd0a35","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    This option can be used to specify which NFS cluster to use."},{"line_number":14,"context_line":"other:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    The existing helper (and associated configuration options) for use with the CephFS driver"},{"line_number":17,"context_line":"    will be deprecated in a future release."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"136bc8c2_a9162fc3","line":17,"range":{"start_line":16,"start_character":4,"end_line":17,"end_character":43},"updated":"2022-09-06 22:21:03.000000000","message":"This note still seems a little bit vague to me because it feels like administrators can do something about this, but we\u0027re not telling them what needs to be done.. I suggest rewording this a bit to make it clearer. \n\n Since the CephFS driver is now capable of using ceph manager commands to manage\n NFS exports, we would like to deprecate and remove support for managing exports\n with the help of DBUS in a future release. Please use cephadm deployed NFS ganesha\n clusters in greenfield deployments with OpenStack Manila and refrain from using\n a standalone non-clustered nfs-ganesha service with this driver. As this solution\n is hardened for HA within Ceph, we expect to provide code to help migrate existing\n nfs-ganesha exports to the nfs-ganesha clusters in a future release.","commit_id":"442c78e651b32682a87f96efedce7987386ec4c8"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8f9c9e9b2f6db99b8be85750650f9dc64c8dc72d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    This option can be used to specify which NFS cluster to use."},{"line_number":14,"context_line":"other:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    The existing helper (and associated configuration options) for use with the CephFS driver"},{"line_number":17,"context_line":"    will be deprecated in a future release."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3e221873_85e88f5d","line":17,"range":{"start_line":16,"start_character":4,"end_line":17,"end_character":43},"in_reply_to":"136bc8c2_a9162fc3","updated":"2022-09-07 15:43:18.000000000","message":"Done","commit_id":"442c78e651b32682a87f96efedce7987386ec4c8"}]}