)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"94f56d96ecb725d93e349b6b204d0998e20c9054","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Fields \u0027segmentation_id\u0027 and \u0027network_type\u0027 removed from users"},{"line_number":10,"context_line":"that are not admins"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"partial-fix: #1824442"},{"line_number":13,"context_line":"Co-authored-by: Lucas de Oliveira \u003clucasmoliveira059@gmail.com\u003e"},{"line_number":14,"context_line":"Change-Id: Id49a8e8f0e014e2f6ea0bfe41750ebe9a6f96509"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"214aec58_aeea6d85","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":12},"updated":"2022-07-27 16:23:20.000000000","message":"Partial-Fix:\n\nIf we don\u0027t have capital letters at the beginning we the launchpad bot will not recognize the flag and the fix won´t be tracked alongside the bug","commit_id":"a803c9696b3ba5291a0443fa0939e6c58e7fb037"},{"author":{"_account_id":35002},"change_message_id":"e6915162a9701faadf2cc5a62b9671b7aa1d513b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Fields \u0027segmentation_id\u0027 and \u0027network_type\u0027 removed from users"},{"line_number":10,"context_line":"that are not admins"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"partial-fix: #1824442"},{"line_number":13,"context_line":"Co-authored-by: Lucas de Oliveira \u003clucasmoliveira059@gmail.com\u003e"},{"line_number":14,"context_line":"Change-Id: Id49a8e8f0e014e2f6ea0bfe41750ebe9a6f96509"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4dad85b6_50e757bd","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":12},"in_reply_to":"214aec58_aeea6d85","updated":"2022-08-10 15:04:53.000000000","message":"Thanks, I\u0027ll pay attention next time!","commit_id":"a803c9696b3ba5291a0443fa0939e6c58e7fb037"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ae9fb46287b6b80cc08817ccb88ef1253225d301","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1097687a_932cf468","updated":"2023-01-25 13:15:13.000000000","message":"Hi, Luiz! Could you please rebase this change?","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ad4cc810a5b06f7ea5f73f255f15648d5519652d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5b9658fc_9d09bf08","updated":"2022-10-13 18:58:26.000000000","message":"Thank you for working on this Luiz. There are a few concerns:\n\n1) I like that we\u0027re bumping up the microversion - we should do that, but, we cannot allow a security loophole by enforcing policy only on newer microversions. Remember that the microversion is specified in a user\u0027s request -- so they can easily use an older microversion to get access to these fields. \n\n2) I think we can bump up the API microversion, but, write a release note indicating that the API version bump is just informational -- i.e., regardless of the actual version of the API request, these fields will be available only if policy allows it - otherwise, they can still see the fields, but their values will be set to None\n\n3) As noted inline, i think we should not override the context.is_admin check. We should introduce a brand new policy and make that policy default to \"rule:admin\". \n\nI\u0027ll be happy to clarify these points.\n\nCan you also add a \"DocImpact\" to your Commit message - i think we need to update the API reference to capture these changes.","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"a653a0622f67741cb5d8e671ad9cd002a1136fcf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c0b06ec9_a11f9d23","updated":"2025-06-20 19:49:10.000000000","message":"These are being addressed and changed.","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6a8a7af65e8187cd34d6ed3633eb8033885794fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"21ea8620_a9ec3378","updated":"2025-06-26 21:04:25.000000000","message":"Added some more comments inline. Please take a look at them. Also, I think you\u0027ll need to do the same for share network subnets view [1] as well as the share networks subnets API [2].\n[1] https://github.com/openstack/manila/blob/master/manila/api/views/share_network_subnets.py#L27\n[2] https://github.com/openstack/manila/blob/master/manila/api/v2/share_network_subnets.py","commit_id":"bed12d1a147c7d4b4c2dee190a1780cdeb691471"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"f85b355bb86f0b4845014af5575bd8cb1128d42a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8118feb4_5f8006bd","updated":"2025-06-27 03:29:50.000000000","message":"Addressed the style issues after updating my flake8 version","commit_id":"bed12d1a147c7d4b4c2dee190a1780cdeb691471"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"3868d8b36f7dc5c8f08a4d792577fa4bb61186dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a7d3eee7_5d22f3c0","updated":"2025-06-30 00:25:18.000000000","message":"Applied and fixed according to the comments","commit_id":"99848015d580904ca814fca9990492e4d6741c00"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0240c8d6c75d4c41bd22ea1e32d7c59303bee395","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b8133385_8c442c53","updated":"2025-06-27 18:21:39.000000000","message":"Thanks for updating this change, please check the comments inline.","commit_id":"99848015d580904ca814fca9990492e4d6741c00"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"cf61ee565586d9cd99660e84cee44cc596baff3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b26ebc8a_8e370580","updated":"2025-06-30 00:34:09.000000000","message":"I\u0027m sorry, I forgot to update the policy and the show and index in the manila/api/v2/share_networks.py file. I\u0027ll work on adding that and push the code again","commit_id":"7570b51b377d9c8c5f82c95be1390f9005af7e87"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"e217a182cb89d3bf30d65c36c886bac644b885e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a37b2077_ac13b784","updated":"2025-09-19 19:08:50.000000000","message":"recheck\n\nlogs are gone","commit_id":"7570b51b377d9c8c5f82c95be1390f9005af7e87"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"a19f5a1f932a61e98ec25a3437f9a973d8a0fead","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8341d095_b30ef93f","updated":"2025-10-10 01:03:03.000000000","message":"Thank you for the update. Changed, debugged, and added DDT test.","commit_id":"8f27cd80bae3f526fe67276709f167f10f51dcdf"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"5737cf63dc1d0b0165731b2cb0157ebfce0dc98b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"96a2b754_c9c37feb","updated":"2025-11-14 18:51:29.000000000","message":"Resolved comments","commit_id":"64b6a0f910109914582685dfb087294e78ee28e7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"669c80174a3abc95dcc647f3a3553d5821abffb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8267ab8f_be72d090","updated":"2026-03-02 15:11:15.000000000","message":"recheck\nLet\u0027s get some fresh logs","commit_id":"64b6a0f910109914582685dfb087294e78ee28e7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"873ef56113438faf03ec0d68ffab603d879624bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"e71629b6_99c81c52","updated":"2026-03-06 05:36:58.000000000","message":"I think we\u0027ll need to curate all APIs, not just the GET /share-networks/\u003cnetwork\u003e API. This means that this obscuration logic should move to the view builder, and should include the share network subnet APIs as well. We should also prevent users from filtering these resources with `segmentation_id` and `network_type`. \n\nWe could re-use the same policy as it was added. I can take a shot at rewriting this fix.","commit_id":"87913004b4d6ce2ce57f623cb936f6302c7574be"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b23c06bb1fe42e7d1b547020a1746d8c3e2e9a3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3901efb3_8d68d729","updated":"2026-03-11 21:06:50.000000000","message":"LGTM, thanks Goutham","commit_id":"bf3c835c94c997048a46389fba1bfd9c4f55da27"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"10ba0edb0c211407e952a581d71de79da32bdd65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"65847447_9a382dcd","updated":"2026-03-12 15:21:18.000000000","message":"a important fix to land, code looks good, thanks!","commit_id":"bf3c835c94c997048a46389fba1bfd9c4f55da27"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fa12353556ccf7d8a6a8da4c54cddcdac6109d37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"4c25071d_726dfbc7","updated":"2026-03-10 21:12:48.000000000","message":"recheck\n\ndependency updated","commit_id":"bf3c835c94c997048a46389fba1bfd9c4f55da27"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6d3f18489cc7e070f0f9f6433e9a6500d61cf13a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"d12b243c_36f83e83","updated":"2026-03-10 21:12:21.000000000","message":"recheck\n\ndependency updated","commit_id":"bf3c835c94c997048a46389fba1bfd9c4f55da27"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1f3c23dc1b8b58695e25f433df82d2ea1da9976b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"297f6785_be1a3d57","updated":"2026-03-06 19:40:40.000000000","message":"recheck\n\nunrelated CI failure that\u0027s addressed elsewhere","commit_id":"bf3c835c94c997048a46389fba1bfd9c4f55da27"}],"manila/api/v2/share_networks.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6a8a7af65e8187cd34d6ed3633eb8033885794fb","unresolved":true,"context_lines":[{"line_number":133,"context_line":"            raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        for subnet in share_network[\u0027share_network_subnets\u0027]:"},{"line_number":136,"context_line":"            if not self._all_share_servers_are_auto_deletable(subnet):"},{"line_number":137,"context_line":"                msg \u003d _("},{"line_number":138,"context_line":"                    \"The service cannot determine if there are any \""},{"line_number":139,"context_line":"                    \"non-managed shares on the share network subnet %(id)s, \""},{"line_number":140,"context_line":"                    \"so it cannot be deleted. Please contact the cloud \""},{"line_number":141,"context_line":"                    \"administrator to rectify.\""},{"line_number":142,"context_line":"                ) % {\u0027id\u0027: subnet[\u0027id\u0027]}"},{"line_number":143,"context_line":"                LOG.error(msg)"},{"line_number":144,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        for subnet in share_network[\u0027share_network_subnets\u0027]:"}],"source_content_type":"text/x-python","patch_set":9,"id":"6752bdf6_f99963f6","line":143,"range":{"start_line":136,"start_character":11,"end_line":143,"end_character":30},"updated":"2025-06-26 21:04:25.000000000","message":"please return the formatting to what it used to be, so that it doesn\u0027t show up as an edited part on future git history checks","commit_id":"bed12d1a147c7d4b4c2dee190a1780cdeb691471"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"f85b355bb86f0b4845014af5575bd8cb1128d42a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        for subnet in share_network[\u0027share_network_subnets\u0027]:"},{"line_number":136,"context_line":"            if not self._all_share_servers_are_auto_deletable(subnet):"},{"line_number":137,"context_line":"                msg \u003d _("},{"line_number":138,"context_line":"                    \"The service cannot determine if there are any \""},{"line_number":139,"context_line":"                    \"non-managed shares on the share network subnet %(id)s, \""},{"line_number":140,"context_line":"                    \"so it cannot be deleted. Please contact the cloud \""},{"line_number":141,"context_line":"                    \"administrator to rectify.\""},{"line_number":142,"context_line":"                ) % {\u0027id\u0027: subnet[\u0027id\u0027]}"},{"line_number":143,"context_line":"                LOG.error(msg)"},{"line_number":144,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        for subnet in share_network[\u0027share_network_subnets\u0027]:"}],"source_content_type":"text/x-python","patch_set":9,"id":"22da6fff_9407c6d8","line":143,"range":{"start_line":136,"start_character":11,"end_line":143,"end_character":30},"in_reply_to":"6752bdf6_f99963f6","updated":"2025-06-27 03:29:50.000000000","message":"Done","commit_id":"bed12d1a147c7d4b4c2dee190a1780cdeb691471"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6a8a7af65e8187cd34d6ed3633eb8033885794fb","unresolved":true,"context_lines":[{"line_number":242,"context_line":"                        api_version.APIVersionRequest(\"2.36\")):"},{"line_number":243,"context_line":"                    networks \u003d ["},{"line_number":244,"context_line":"                        network for network in networks"},{"line_number":245,"context_line":"                        if (network.get(key) \u003d\u003d value or"},{"line_number":246,"context_line":"                            self._subnet_has_search_opt(key, value, network) or"},{"line_number":247,"context_line":"                            (value in network.get("},{"line_number":248,"context_line":"                                key.rstrip(\u0027~\u0027) if key.endswith(\u0027~\u0027)"},{"line_number":249,"context_line":"                                and network.get(key.rstrip(\u0027~\u0027))"},{"line_number":250,"context_line":"                                else ())))]"},{"line_number":251,"context_line":"                else:"},{"line_number":252,"context_line":"                    networks \u003d ["},{"line_number":253,"context_line":"                        network for network in networks"},{"line_number":254,"context_line":"                        if (network.get(key) \u003d\u003d value or"},{"line_number":255,"context_line":"                            self._subnet_has_search_opt("},{"line_number":256,"context_line":"                                key, value, network, exact_value\u003dTrue))]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        limited_list \u003d common.limited(networks, req)"},{"line_number":259,"context_line":"        return self._view_builder.build_share_networks("}],"source_content_type":"text/x-python","patch_set":9,"id":"15e7c016_7597dfdb","line":256,"range":{"start_line":245,"start_character":24,"end_line":256,"end_character":72},"updated":"2025-06-26 21:04:25.000000000","message":"same as above","commit_id":"bed12d1a147c7d4b4c2dee190a1780cdeb691471"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"f85b355bb86f0b4845014af5575bd8cb1128d42a","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                        api_version.APIVersionRequest(\"2.36\")):"},{"line_number":243,"context_line":"                    networks \u003d ["},{"line_number":244,"context_line":"                        network for network in networks"},{"line_number":245,"context_line":"                        if (network.get(key) \u003d\u003d value or"},{"line_number":246,"context_line":"                            self._subnet_has_search_opt(key, value, network) or"},{"line_number":247,"context_line":"                            (value in network.get("},{"line_number":248,"context_line":"                                key.rstrip(\u0027~\u0027) if key.endswith(\u0027~\u0027)"},{"line_number":249,"context_line":"                                and network.get(key.rstrip(\u0027~\u0027))"},{"line_number":250,"context_line":"                                else ())))]"},{"line_number":251,"context_line":"                else:"},{"line_number":252,"context_line":"                    networks \u003d ["},{"line_number":253,"context_line":"                        network for network in networks"},{"line_number":254,"context_line":"                        if (network.get(key) \u003d\u003d value or"},{"line_number":255,"context_line":"                            self._subnet_has_search_opt("},{"line_number":256,"context_line":"                                key, value, network, exact_value\u003dTrue))]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        limited_list \u003d common.limited(networks, req)"},{"line_number":259,"context_line":"        return self._view_builder.build_share_networks("}],"source_content_type":"text/x-python","patch_set":9,"id":"517daf57_e1a5b43c","line":256,"range":{"start_line":245,"start_character":24,"end_line":256,"end_character":72},"in_reply_to":"15e7c016_7597dfdb","updated":"2025-06-27 03:29:50.000000000","message":"Done","commit_id":"bed12d1a147c7d4b4c2dee190a1780cdeb691471"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6a8a7af65e8187cd34d6ed3633eb8033885794fb","unresolved":true,"context_lines":[{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        support_adding_to_in_use_networks \u003d ("},{"line_number":467,"context_line":"            req.api_version_request \u003e\u003d"},{"line_number":468,"context_line":"            api_version.APIVersionRequest(\"2.63\"))"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        if contain_share_servers:"},{"line_number":471,"context_line":"            if not support_adding_to_in_use_networks:"}],"source_content_type":"text/x-python","patch_set":9,"id":"66985fc7_738fa26d","line":468,"range":{"start_line":468,"start_character":0,"end_line":468,"end_character":50},"updated":"2025-06-26 21:04:25.000000000","message":"same as above","commit_id":"bed12d1a147c7d4b4c2dee190a1780cdeb691471"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"f85b355bb86f0b4845014af5575bd8cb1128d42a","unresolved":false,"context_lines":[{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        support_adding_to_in_use_networks \u003d ("},{"line_number":467,"context_line":"            req.api_version_request \u003e\u003d"},{"line_number":468,"context_line":"            api_version.APIVersionRequest(\"2.63\"))"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        if contain_share_servers:"},{"line_number":471,"context_line":"            if not support_adding_to_in_use_networks:"}],"source_content_type":"text/x-python","patch_set":9,"id":"080018d3_d02b1487","line":468,"range":{"start_line":468,"start_character":0,"end_line":468,"end_character":50},"in_reply_to":"66985fc7_738fa26d","updated":"2025-06-27 03:29:50.000000000","message":"Done","commit_id":"bed12d1a147c7d4b4c2dee190a1780cdeb691471"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0240c8d6c75d4c41bd22ea1e32d7c59303bee395","unresolved":true,"context_lines":[{"line_number":81,"context_line":"            # \u0027segmentation_id\u0027 of a share network. These fields contain"},{"line_number":82,"context_line":"            # potentially sensitive network information, so we remove them"},{"line_number":83,"context_line":"            # for non-admin users before passing the data to the view builder."},{"line_number":84,"context_line":"            share_network[\u0027network_type\u0027] \u003d None"},{"line_number":85,"context_line":"            share_network[\u0027segmentation_id\u0027] \u003d None"},{"line_number":86,"context_line":"        return self._view_builder.build_share_network(req, share_network)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _all_share_servers_are_auto_deletable(self, share_network):"}],"source_content_type":"text/x-python","patch_set":10,"id":"12a0b6c3_3b109fde","line":85,"range":{"start_line":84,"start_character":12,"end_line":85,"end_character":51},"updated":"2025-06-27 18:21:39.000000000","message":"```suggestion\n            if not share_network.get(\u0027share_network_subnets\u0027, None):\n                share_network[\u0027network_type\u0027] \u003d None\n                share_network[\u0027segmentation_id\u0027] \u003d None\n            else:\n                for subnet in share_network[\u0027share_network_subnets\u0027]:\n                    subnet[\u0027network_type\u0027] \u003d None\n                    subnet[\u0027segmentation_id\u0027] \u003d None\n```","commit_id":"99848015d580904ca814fca9990492e4d6741c00"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"3868d8b36f7dc5c8f08a4d792577fa4bb61186dd","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            # \u0027segmentation_id\u0027 of a share network. These fields contain"},{"line_number":82,"context_line":"            # potentially sensitive network information, so we remove them"},{"line_number":83,"context_line":"            # for non-admin users before passing the data to the view builder."},{"line_number":84,"context_line":"            share_network[\u0027network_type\u0027] \u003d None"},{"line_number":85,"context_line":"            share_network[\u0027segmentation_id\u0027] \u003d None"},{"line_number":86,"context_line":"        return self._view_builder.build_share_network(req, share_network)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _all_share_servers_are_auto_deletable(self, share_network):"}],"source_content_type":"text/x-python","patch_set":10,"id":"2ebbde6c_0a145b54","line":85,"range":{"start_line":84,"start_character":12,"end_line":85,"end_character":51},"in_reply_to":"12a0b6c3_3b109fde","updated":"2025-06-30 00:25:18.000000000","message":"Done","commit_id":"99848015d580904ca814fca9990492e4d6741c00"}],"manila/api/views/share_network_subnets.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ad4cc810a5b06f7ea5f73f255f15648d5519652d","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    \"\"\"Model a server API response as a python dictionary.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    _collection_name \u003d \u0027share_network_subnets\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def build_share_network_subnet(self, request, share_network_subnet):"},{"line_number":25,"context_line":"        return {"},{"line_number":26,"context_line":"            \u0027share_network_subnet\u0027: self._build_share_network_subnet_view("}],"source_content_type":"text/x-python","patch_set":8,"id":"44eb8bd2_edd739d7","line":23,"updated":"2022-10-13 18:58:26.000000000","message":"You need a \"_detail_version_modifiers\" variable here, and set it to a list containing your method name: remove_non_privileged_fields\n\nExample: https://opendev.org/openstack/manila/src/commit/b8fdf9b9e758fa0945504d1da651445dab8350d7/manila/api/views/export_locations.py#L26","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"a653a0622f67741cb5d8e671ad9cd002a1136fcf","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \"\"\"Model a server API response as a python dictionary.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    _collection_name \u003d \u0027share_network_subnets\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def build_share_network_subnet(self, request, share_network_subnet):"},{"line_number":25,"context_line":"        return {"},{"line_number":26,"context_line":"            \u0027share_network_subnet\u0027: self._build_share_network_subnet_view("}],"source_content_type":"text/x-python","patch_set":8,"id":"862480c2_c6e0b9b9","line":23,"in_reply_to":"44eb8bd2_edd739d7","updated":"2025-06-20 19:49:10.000000000","message":"Done","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ad4cc810a5b06f7ea5f73f255f15648d5519652d","unresolved":true,"context_lines":[{"line_number":53,"context_line":"        return sns"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @common.ViewBuilder.versioned_method(\"2.74\")"},{"line_number":56,"context_line":"    def remove_non_privileged_fields(self, request, share_network_subnet):"},{"line_number":57,"context_line":"        context \u003d request.environ[\u0027manila.context\u0027]"},{"line_number":58,"context_line":"        sns \u003d {"},{"line_number":59,"context_line":"            \u0027id\u0027: share_network_subnet.get(\u0027id\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"d4eda609_5ac239a9","line":56,"range":{"start_line":56,"start_character":37,"end_line":56,"end_character":72},"updated":"2022-10-13 18:58:26.000000000","message":"This needs four attributes:\n\n self, context, share_network_subnet_view, share_network_subnet","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"a653a0622f67741cb5d8e671ad9cd002a1136fcf","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        return sns"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @common.ViewBuilder.versioned_method(\"2.74\")"},{"line_number":56,"context_line":"    def remove_non_privileged_fields(self, request, share_network_subnet):"},{"line_number":57,"context_line":"        context \u003d request.environ[\u0027manila.context\u0027]"},{"line_number":58,"context_line":"        sns \u003d {"},{"line_number":59,"context_line":"            \u0027id\u0027: share_network_subnet.get(\u0027id\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"429cfa92_b6b04343","line":56,"range":{"start_line":56,"start_character":37,"end_line":56,"end_character":72},"in_reply_to":"d4eda609_5ac239a9","updated":"2025-06-20 19:49:10.000000000","message":"Done","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ad4cc810a5b06f7ea5f73f255f15648d5519652d","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @common.ViewBuilder.versioned_method(\"2.74\")"},{"line_number":56,"context_line":"    def remove_non_privileged_fields(self, request, share_network_subnet):"},{"line_number":57,"context_line":"        context \u003d request.environ[\u0027manila.context\u0027]"},{"line_number":58,"context_line":"        sns \u003d {"},{"line_number":59,"context_line":"            \u0027id\u0027: share_network_subnet.get(\u0027id\u0027),"},{"line_number":60,"context_line":"            \u0027availability_zone\u0027: share_network_subnet.get(\u0027availability_zone\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"ce13a9bf_d7ce04fc","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":51},"updated":"2022-10-13 18:58:26.000000000","message":"request isn\u0027t passed here, the context is: https://opendev.org/openstack/manila/src/commit/b8fdf9b9e758fa0945504d1da651445dab8350d7/manila/api/common.py#L377-L378","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"a653a0622f67741cb5d8e671ad9cd002a1136fcf","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @common.ViewBuilder.versioned_method(\"2.74\")"},{"line_number":56,"context_line":"    def remove_non_privileged_fields(self, request, share_network_subnet):"},{"line_number":57,"context_line":"        context \u003d request.environ[\u0027manila.context\u0027]"},{"line_number":58,"context_line":"        sns \u003d {"},{"line_number":59,"context_line":"            \u0027id\u0027: share_network_subnet.get(\u0027id\u0027),"},{"line_number":60,"context_line":"            \u0027availability_zone\u0027: share_network_subnet.get(\u0027availability_zone\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"d00008c6_6b08b581","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":51},"in_reply_to":"ce13a9bf_d7ce04fc","updated":"2025-06-20 19:49:10.000000000","message":"Done","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ad4cc810a5b06f7ea5f73f255f15648d5519652d","unresolved":true,"context_lines":[{"line_number":69,"context_line":"            \u0027mtu\u0027: share_network_subnet.get(\u0027mtu\u0027),"},{"line_number":70,"context_line":"            \u0027gateway\u0027: share_network_subnet.get(\u0027gateway\u0027)"},{"line_number":71,"context_line":"        }"},{"line_number":72,"context_line":"        if context.is_admin:"},{"line_number":73,"context_line":"            sns.update({"},{"line_number":74,"context_line":"                \u0027segmentation_id\u0027: share_network_subnet.get(\u0027segmentation_id\u0027),"},{"line_number":75,"context_line":"                \u0027network_type\u0027: share_network_subnet.get(\u0027network_type\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"0713f203_09d3894f","line":72,"range":{"start_line":72,"start_character":10,"end_line":72,"end_character":28},"updated":"2022-10-13 18:58:26.000000000","message":"I would prefer we don\u0027t overload this \"context.is_admin\" check; we can just introduce a new policy instead, specifically for this. If you need help with that, please let me know","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"a653a0622f67741cb5d8e671ad9cd002a1136fcf","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            \u0027mtu\u0027: share_network_subnet.get(\u0027mtu\u0027),"},{"line_number":70,"context_line":"            \u0027gateway\u0027: share_network_subnet.get(\u0027gateway\u0027)"},{"line_number":71,"context_line":"        }"},{"line_number":72,"context_line":"        if context.is_admin:"},{"line_number":73,"context_line":"            sns.update({"},{"line_number":74,"context_line":"                \u0027segmentation_id\u0027: share_network_subnet.get(\u0027segmentation_id\u0027),"},{"line_number":75,"context_line":"                \u0027network_type\u0027: share_network_subnet.get(\u0027network_type\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"d1ed3e34_bc4aaf8a","line":72,"range":{"start_line":72,"start_character":10,"end_line":72,"end_character":28},"in_reply_to":"0713f203_09d3894f","updated":"2025-06-20 19:49:10.000000000","message":"Done","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ad4cc810a5b06f7ea5f73f255f15648d5519652d","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    @common.ViewBuilder.versioned_method(\"2.74\")"},{"line_number":56,"context_line":"    def remove_non_privileged_fields(self, request, share_network_subnet):"},{"line_number":57,"context_line":"        context \u003d request.environ[\u0027manila.context\u0027]"},{"line_number":58,"context_line":"        sns \u003d {"},{"line_number":59,"context_line":"            \u0027id\u0027: share_network_subnet.get(\u0027id\u0027),"},{"line_number":60,"context_line":"            \u0027availability_zone\u0027: share_network_subnet.get(\u0027availability_zone\u0027),"},{"line_number":61,"context_line":"            \u0027share_network_id\u0027: share_network_subnet.get(\u0027share_network_id\u0027),"},{"line_number":62,"context_line":"            \u0027share_network_name\u0027: share_network_subnet[\u0027share_network_name\u0027],"},{"line_number":63,"context_line":"            \u0027created_at\u0027: share_network_subnet.get(\u0027created_at\u0027),"},{"line_number":64,"context_line":"            \u0027neutron_subnet_id\u0027: share_network_subnet.get(\u0027neutron_subnet_id\u0027),"},{"line_number":65,"context_line":"            \u0027updated_at\u0027: share_network_subnet.get(\u0027updated_at\u0027),"},{"line_number":66,"context_line":"            \u0027neutron_net_id\u0027: share_network_subnet.get(\u0027neutron_net_id\u0027),"},{"line_number":67,"context_line":"            \u0027ip_version\u0027: share_network_subnet.get(\u0027ip_version\u0027),"},{"line_number":68,"context_line":"            \u0027cidr\u0027: share_network_subnet.get(\u0027cidr\u0027),"},{"line_number":69,"context_line":"            \u0027mtu\u0027: share_network_subnet.get(\u0027mtu\u0027),"},{"line_number":70,"context_line":"            \u0027gateway\u0027: share_network_subnet.get(\u0027gateway\u0027)"},{"line_number":71,"context_line":"        }"},{"line_number":72,"context_line":"        if context.is_admin:"},{"line_number":73,"context_line":"            sns.update({"},{"line_number":74,"context_line":"                \u0027segmentation_id\u0027: share_network_subnet.get(\u0027segmentation_id\u0027),"},{"line_number":75,"context_line":"                \u0027network_type\u0027: share_network_subnet.get(\u0027network_type\u0027),"},{"line_number":76,"context_line":"            })"},{"line_number":77,"context_line":"        self.update_versioned_resource_dict(request, sns, share_network_subnet)"},{"line_number":78,"context_line":"        return sns"}],"source_content_type":"text/x-python","patch_set":8,"id":"58d50c66_248a24f4","line":76,"range":{"start_line":58,"start_character":8,"end_line":76,"end_character":14},"updated":"2022-10-13 18:58:26.000000000","message":"No need for redefining all this, you need to just pop the values of \"segmentation_id\" and \"network_type\" if the user isn\u0027t an administrator","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"a653a0622f67741cb5d8e671ad9cd002a1136fcf","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    @common.ViewBuilder.versioned_method(\"2.74\")"},{"line_number":56,"context_line":"    def remove_non_privileged_fields(self, request, share_network_subnet):"},{"line_number":57,"context_line":"        context \u003d request.environ[\u0027manila.context\u0027]"},{"line_number":58,"context_line":"        sns \u003d {"},{"line_number":59,"context_line":"            \u0027id\u0027: share_network_subnet.get(\u0027id\u0027),"},{"line_number":60,"context_line":"            \u0027availability_zone\u0027: share_network_subnet.get(\u0027availability_zone\u0027),"},{"line_number":61,"context_line":"            \u0027share_network_id\u0027: share_network_subnet.get(\u0027share_network_id\u0027),"},{"line_number":62,"context_line":"            \u0027share_network_name\u0027: share_network_subnet[\u0027share_network_name\u0027],"},{"line_number":63,"context_line":"            \u0027created_at\u0027: share_network_subnet.get(\u0027created_at\u0027),"},{"line_number":64,"context_line":"            \u0027neutron_subnet_id\u0027: share_network_subnet.get(\u0027neutron_subnet_id\u0027),"},{"line_number":65,"context_line":"            \u0027updated_at\u0027: share_network_subnet.get(\u0027updated_at\u0027),"},{"line_number":66,"context_line":"            \u0027neutron_net_id\u0027: share_network_subnet.get(\u0027neutron_net_id\u0027),"},{"line_number":67,"context_line":"            \u0027ip_version\u0027: share_network_subnet.get(\u0027ip_version\u0027),"},{"line_number":68,"context_line":"            \u0027cidr\u0027: share_network_subnet.get(\u0027cidr\u0027),"},{"line_number":69,"context_line":"            \u0027mtu\u0027: share_network_subnet.get(\u0027mtu\u0027),"},{"line_number":70,"context_line":"            \u0027gateway\u0027: share_network_subnet.get(\u0027gateway\u0027)"},{"line_number":71,"context_line":"        }"},{"line_number":72,"context_line":"        if context.is_admin:"},{"line_number":73,"context_line":"            sns.update({"},{"line_number":74,"context_line":"                \u0027segmentation_id\u0027: share_network_subnet.get(\u0027segmentation_id\u0027),"},{"line_number":75,"context_line":"                \u0027network_type\u0027: share_network_subnet.get(\u0027network_type\u0027),"},{"line_number":76,"context_line":"            })"},{"line_number":77,"context_line":"        self.update_versioned_resource_dict(request, sns, share_network_subnet)"},{"line_number":78,"context_line":"        return sns"}],"source_content_type":"text/x-python","patch_set":8,"id":"079a8d26_f04051bb","line":76,"range":{"start_line":58,"start_character":8,"end_line":76,"end_character":14},"in_reply_to":"58d50c66_248a24f4","updated":"2025-06-20 19:49:10.000000000","message":"Done","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ad4cc810a5b06f7ea5f73f255f15648d5519652d","unresolved":true,"context_lines":[{"line_number":74,"context_line":"                \u0027segmentation_id\u0027: share_network_subnet.get(\u0027segmentation_id\u0027),"},{"line_number":75,"context_line":"                \u0027network_type\u0027: share_network_subnet.get(\u0027network_type\u0027),"},{"line_number":76,"context_line":"            })"},{"line_number":77,"context_line":"        self.update_versioned_resource_dict(request, sns, share_network_subnet)"},{"line_number":78,"context_line":"        return sns"}],"source_content_type":"text/x-python","patch_set":8,"id":"523b0d16_6b20411f","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":79},"updated":"2022-10-13 18:58:26.000000000","message":"Nope - don\u0027t need to update it again.. this needs to only be done once, like on line #52","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"a653a0622f67741cb5d8e671ad9cd002a1136fcf","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                \u0027segmentation_id\u0027: share_network_subnet.get(\u0027segmentation_id\u0027),"},{"line_number":75,"context_line":"                \u0027network_type\u0027: share_network_subnet.get(\u0027network_type\u0027),"},{"line_number":76,"context_line":"            })"},{"line_number":77,"context_line":"        self.update_versioned_resource_dict(request, sns, share_network_subnet)"},{"line_number":78,"context_line":"        return sns"}],"source_content_type":"text/x-python","patch_set":8,"id":"04569a93_33ba6a57","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":79},"in_reply_to":"523b0d16_6b20411f","updated":"2025-06-20 19:49:10.000000000","message":"Done","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"}],"manila/api/views/share_networks.py":[{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"b82a4a1de4361dac86d8ef5d04992e1574a4bf45","unresolved":true,"context_lines":[{"line_number":119,"context_line":"    def add_subnets(self, context, network_dict, network):"},{"line_number":120,"context_line":"        network_dict[\u0027share_network_subnets\u0027] \u003d []"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        for sns in network_dict.get(\u0027share_network_subnets\u0027):"},{"line_number":123,"context_line":"            s \u003d {"},{"line_number":124,"context_line":"                \u0027id\u0027: sns.get(\u0027id\u0027),"},{"line_number":125,"context_line":"                \u0027availability_zone\u0027: sns.get(\u0027availability_zone\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"27b0bb44_bfddb7f4","line":122,"range":{"start_line":122,"start_character":19,"end_line":122,"end_character":31},"updated":"2022-07-13 13:59:10.000000000","message":"should be \"network\"","commit_id":"a803c9696b3ba5291a0443fa0939e6c58e7fb037"},{"author":{"_account_id":35002},"change_message_id":"e6915162a9701faadf2cc5a62b9671b7aa1d513b","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    def add_subnets(self, context, network_dict, network):"},{"line_number":120,"context_line":"        network_dict[\u0027share_network_subnets\u0027] \u003d []"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        for sns in network_dict.get(\u0027share_network_subnets\u0027):"},{"line_number":123,"context_line":"            s \u003d {"},{"line_number":124,"context_line":"                \u0027id\u0027: sns.get(\u0027id\u0027),"},{"line_number":125,"context_line":"                \u0027availability_zone\u0027: sns.get(\u0027availability_zone\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"337efadd_3b571f76","line":122,"range":{"start_line":122,"start_character":19,"end_line":122,"end_character":31},"in_reply_to":"27b0bb44_bfddb7f4","updated":"2022-08-10 15:04:53.000000000","message":"Thanks, it\u0027s done","commit_id":"a803c9696b3ba5291a0443fa0939e6c58e7fb037"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ad4cc810a5b06f7ea5f73f255f15648d5519652d","unresolved":true,"context_lines":[{"line_number":157,"context_line":"    @common.ViewBuilder.versioned_method(\"2.74\")"},{"line_number":158,"context_line":"    def remove_non_privileged_fields("},{"line_number":159,"context_line":"            self, context, network_dict, network):"},{"line_number":160,"context_line":"        if not context.is_admin:"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            for i in range(len(network_dict[\u0027share_network_subnets\u0027])):"},{"line_number":163,"context_line":"                network_dict[\u0027share_network_subnets\u0027][i].pop(\u0027network_type\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"8c17b249_e292ff51","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":32},"updated":"2022-10-13 18:58:26.000000000","message":"Same comment here, we can introduce a new policy for this","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"a653a0622f67741cb5d8e671ad9cd002a1136fcf","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    @common.ViewBuilder.versioned_method(\"2.74\")"},{"line_number":158,"context_line":"    def remove_non_privileged_fields("},{"line_number":159,"context_line":"            self, context, network_dict, network):"},{"line_number":160,"context_line":"        if not context.is_admin:"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            for i in range(len(network_dict[\u0027share_network_subnets\u0027])):"},{"line_number":163,"context_line":"                network_dict[\u0027share_network_subnets\u0027][i].pop(\u0027network_type\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"051b8df5_a326406b","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":32},"in_reply_to":"8c17b249_e292ff51","updated":"2025-06-20 19:49:10.000000000","message":"Done","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ad4cc810a5b06f7ea5f73f255f15648d5519652d","unresolved":true,"context_lines":[{"line_number":159,"context_line":"            self, context, network_dict, network):"},{"line_number":160,"context_line":"        if not context.is_admin:"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            for i in range(len(network_dict[\u0027share_network_subnets\u0027])):"},{"line_number":163,"context_line":"                network_dict[\u0027share_network_subnets\u0027][i].pop(\u0027network_type\u0027)"},{"line_number":164,"context_line":"                network_dict[\u0027share_network_subnets\u0027][i].pop(\u0027segmentation_id\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"c18abda5_f4d09819","line":162,"range":{"start_line":162,"start_character":12,"end_line":162,"end_character":71},"updated":"2022-10-13 18:58:26.000000000","message":"for share_network_subnet in network_dict[\u0027share_network_subnets\u0027]","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"a653a0622f67741cb5d8e671ad9cd002a1136fcf","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            self, context, network_dict, network):"},{"line_number":160,"context_line":"        if not context.is_admin:"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            for i in range(len(network_dict[\u0027share_network_subnets\u0027])):"},{"line_number":163,"context_line":"                network_dict[\u0027share_network_subnets\u0027][i].pop(\u0027network_type\u0027)"},{"line_number":164,"context_line":"                network_dict[\u0027share_network_subnets\u0027][i].pop(\u0027segmentation_id\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"4fe78c0a_4ec4d459","line":162,"range":{"start_line":162,"start_character":12,"end_line":162,"end_character":71},"in_reply_to":"c18abda5_f4d09819","updated":"2025-06-20 19:49:10.000000000","message":"Done","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ad4cc810a5b06f7ea5f73f255f15648d5519652d","unresolved":true,"context_lines":[{"line_number":160,"context_line":"        if not context.is_admin:"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            for i in range(len(network_dict[\u0027share_network_subnets\u0027])):"},{"line_number":163,"context_line":"                network_dict[\u0027share_network_subnets\u0027][i].pop(\u0027network_type\u0027)"},{"line_number":164,"context_line":"                network_dict[\u0027share_network_subnets\u0027][i].pop(\u0027segmentation_id\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"52f2fa12_eff2d1d9","line":164,"range":{"start_line":163,"start_character":16,"end_line":164,"end_character":79},"updated":"2022-10-13 18:58:26.000000000","message":"Don\u0027t pop, just set these values to None","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"a653a0622f67741cb5d8e671ad9cd002a1136fcf","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        if not context.is_admin:"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"            for i in range(len(network_dict[\u0027share_network_subnets\u0027])):"},{"line_number":163,"context_line":"                network_dict[\u0027share_network_subnets\u0027][i].pop(\u0027network_type\u0027)"},{"line_number":164,"context_line":"                network_dict[\u0027share_network_subnets\u0027][i].pop(\u0027segmentation_id\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"8eae03ea_c4e6aebc","line":164,"range":{"start_line":163,"start_character":16,"end_line":164,"end_character":79},"in_reply_to":"52f2fa12_eff2d1d9","updated":"2025-06-20 19:49:10.000000000","message":"Done","commit_id":"b29117ccdd5d00d6bd250faf744e8e58eb4c1b83"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6a8a7af65e8187cd34d6ed3633eb8033885794fb","unresolved":true,"context_lines":[{"line_number":74,"context_line":"                update_dict \u003d {"},{"line_number":75,"context_line":"                    \u0027neutron_net_id\u0027: sns.get(\u0027neutron_net_id\u0027),"},{"line_number":76,"context_line":"                    \u0027neutron_subnet_id\u0027: sns.get(\u0027neutron_subnet_id\u0027),"},{"line_number":77,"context_line":"                    \u0027network_type\u0027: sns.get(\u0027network_type\u0027),"},{"line_number":78,"context_line":"                    \u0027segmentation_id\u0027: sns.get(\u0027segmentation_id\u0027),"},{"line_number":79,"context_line":"                    \u0027cidr\u0027: sns.get(\u0027cidr\u0027),"},{"line_number":80,"context_line":"                    \u0027ip_version\u0027: sns.get(\u0027ip_version\u0027),"},{"line_number":81,"context_line":"                    \u0027gateway\u0027: sns.get(\u0027gateway\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"e9436b61_9fc7922f","line":78,"range":{"start_line":77,"start_character":12,"end_line":78,"end_character":66},"updated":"2025-06-26 21:04:25.000000000","message":"please drop these two from the list, as they should only be added when the if statement below qualifies","commit_id":"bed12d1a147c7d4b4c2dee190a1780cdeb691471"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"f85b355bb86f0b4845014af5575bd8cb1128d42a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                update_dict \u003d {"},{"line_number":75,"context_line":"                    \u0027neutron_net_id\u0027: sns.get(\u0027neutron_net_id\u0027),"},{"line_number":76,"context_line":"                    \u0027neutron_subnet_id\u0027: sns.get(\u0027neutron_subnet_id\u0027),"},{"line_number":77,"context_line":"                    \u0027network_type\u0027: sns.get(\u0027network_type\u0027),"},{"line_number":78,"context_line":"                    \u0027segmentation_id\u0027: sns.get(\u0027segmentation_id\u0027),"},{"line_number":79,"context_line":"                    \u0027cidr\u0027: sns.get(\u0027cidr\u0027),"},{"line_number":80,"context_line":"                    \u0027ip_version\u0027: sns.get(\u0027ip_version\u0027),"},{"line_number":81,"context_line":"                    \u0027gateway\u0027: sns.get(\u0027gateway\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"15f5bbd8_97a2b766","line":78,"range":{"start_line":77,"start_character":12,"end_line":78,"end_character":66},"in_reply_to":"e9436b61_9fc7922f","updated":"2025-06-27 03:29:50.000000000","message":"Done","commit_id":"bed12d1a147c7d4b4c2dee190a1780cdeb691471"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0240c8d6c75d4c41bd22ea1e32d7c59303bee395","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        }"},{"line_number":95,"context_line":"        if is_detail:"},{"line_number":96,"context_line":"            self._update_share_network_info(request, share_network)"},{"line_number":97,"context_line":"            # Context is not used but kept for future use"},{"line_number":98,"context_line":"            _ \u003d request.environ[\u0027manila.context\u0027]  # noqa: F841"},{"line_number":99,"context_line":"            network_data \u003d {"},{"line_number":100,"context_line":"                \u0027project_id\u0027: share_network.get(\u0027project_id\u0027),"},{"line_number":101,"context_line":"                \u0027created_at\u0027: share_network.get(\u0027created_at\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"d024c712_38746305","line":98,"range":{"start_line":97,"start_character":0,"end_line":98,"end_character":63},"updated":"2025-06-27 18:21:39.000000000","message":"please drop this statement","commit_id":"99848015d580904ca814fca9990492e4d6741c00"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"3868d8b36f7dc5c8f08a4d792577fa4bb61186dd","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        }"},{"line_number":95,"context_line":"        if is_detail:"},{"line_number":96,"context_line":"            self._update_share_network_info(request, share_network)"},{"line_number":97,"context_line":"            # Context is not used but kept for future use"},{"line_number":98,"context_line":"            _ \u003d request.environ[\u0027manila.context\u0027]  # noqa: F841"},{"line_number":99,"context_line":"            network_data \u003d {"},{"line_number":100,"context_line":"                \u0027project_id\u0027: share_network.get(\u0027project_id\u0027),"},{"line_number":101,"context_line":"                \u0027created_at\u0027: share_network.get(\u0027created_at\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"73a0ee19_54fa317e","line":98,"range":{"start_line":97,"start_character":0,"end_line":98,"end_character":63},"in_reply_to":"d024c712_38746305","updated":"2025-06-30 00:25:18.000000000","message":"Done","commit_id":"99848015d580904ca814fca9990492e4d6741c00"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3216b66f963bb69147819d732b0c078fbbf05c13","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            # Only include network_type and segmentation_id if they exist"},{"line_number":108,"context_line":"            if share_network.get(\u0027network_type\u0027, None):"},{"line_number":109,"context_line":"                network_data[\u0027network_type\u0027] \u003d share_network[\u0027network_type\u0027]"},{"line_number":110,"context_line":"                network_data[\u0027segmentation_id\u0027] \u003d ("},{"line_number":111,"context_line":"                    share_network[\u0027segmentation_id\u0027])"},{"line_number":112,"context_line":"            sn.update(network_data)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            self.update_versioned_resource_dict(request, sn, share_network)"}],"source_content_type":"text/x-python","patch_set":11,"id":"c07590be_ea461726","line":111,"range":{"start_line":110,"start_character":16,"end_line":111,"end_character":53},"updated":"2025-09-19 19:05:11.000000000","message":"please make a different If statement for this","commit_id":"7570b51b377d9c8c5f82c95be1390f9005af7e87"},{"author":{"_account_id":38038,"name":"Riane TOrres","display_name":"Riane Torres","email":"riane.torres@gmail.com","username":"realrtorres"},"change_message_id":"a19f5a1f932a61e98ec25a3437f9a973d8a0fead","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            # Only include network_type and segmentation_id if they exist"},{"line_number":108,"context_line":"            if share_network.get(\u0027network_type\u0027, None):"},{"line_number":109,"context_line":"                network_data[\u0027network_type\u0027] \u003d share_network[\u0027network_type\u0027]"},{"line_number":110,"context_line":"                network_data[\u0027segmentation_id\u0027] \u003d ("},{"line_number":111,"context_line":"                    share_network[\u0027segmentation_id\u0027])"},{"line_number":112,"context_line":"            sn.update(network_data)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            self.update_versioned_resource_dict(request, sn, share_network)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1466396a_28f7196d","line":111,"range":{"start_line":110,"start_character":16,"end_line":111,"end_character":53},"in_reply_to":"c07590be_ea461726","updated":"2025-10-10 01:03:03.000000000","message":"Done","commit_id":"7570b51b377d9c8c5f82c95be1390f9005af7e87"}],"manila/policies/share_network.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b23c06bb1fe42e7d1b547020a1746d8c3e2e9a3b","unresolved":true,"context_lines":[{"line_number":301,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027show_network_details\u0027,"},{"line_number":302,"context_line":"        check_str\u003dbase.ADMIN,"},{"line_number":303,"context_line":"        scope_types\u003d[\u0027project\u0027],"},{"line_number":304,"context_line":"        description\u003d(\"Allow viewing network_type and segmentation_id of \""},{"line_number":305,"context_line":"                     \"share networks and share network subnets. Also \""},{"line_number":306,"context_line":"                     \"allows filtering share networks by these fields.\"),"},{"line_number":307,"context_line":"        operations\u003d["},{"line_number":308,"context_line":"            {"},{"line_number":309,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"49198964_c0d0f368","line":306,"range":{"start_line":304,"start_character":22,"end_line":306,"end_character":69},"updated":"2026-03-11 21:06:50.000000000","message":"thanks for the detailed description","commit_id":"bf3c835c94c997048a46389fba1bfd9c4f55da27"}]}