)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"2c398b17a8ede2c0256cfe711bfca7ca8e48fe10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a2fd3cc_c338bf71","updated":"2022-07-15 11:31:05.000000000","message":"Good catch Carlos, can you add some unit tests to see we are raising the correct exceptions now?","commit_id":"ecf71cfda636f9bc836f81cc19d542d85cd52607"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"59afa208c527908cb2d3d82d042fd2435b64e9ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7e9fcda6_29c2e3c7","in_reply_to":"8f6b16cb_d5283470","updated":"2022-07-21 22:19:10.000000000","message":"PLease take a look at the latest PS","commit_id":"ecf71cfda636f9bc836f81cc19d542d85cd52607"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f64cd262459024eafbafeb02c9308610f2032470","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8f6b16cb_d5283470","in_reply_to":"9a2fd3cc_c338bf71","updated":"2022-07-21 22:18:49.000000000","message":"Sure! Thank you for the review\nThe lines were already covered by unit test as a side effect, since we were testing the exception for ShareGroupSnapshotNotFound, and that code statement was the same for both exceptions... But it is good to add new unit tests :)","commit_id":"ecf71cfda636f9bc836f81cc19d542d85cd52607"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7b87fcdc68f94a7603662d7bb95eac79df366567","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2f2ee082_5d7d7518","updated":"2022-07-26 08:45:12.000000000","message":"thanks, Carlos Eduardo.\nplease see comment inline.","commit_id":"60706ad85f23a909e7fc8ca6ac6feb48f20b5cdf"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"43850cf45ab78a7117a15e062f18d200c94d8a5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"40471ecd_1dadf620","updated":"2022-07-27 01:05:04.000000000","message":"LGTM","commit_id":"51bc15830594b0b7d07ccdc443ba8d32c19d7ca9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"60d5344bf5b544432c63464eda72b321baf301b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cf77c2f0_87aa76c8","updated":"2022-07-26 20:37:17.000000000","message":"Thank you for the reviews, please check the changes inline.","commit_id":"51bc15830594b0b7d07ccdc443ba8d32c19d7ca9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dc50dd0db7a769e5c1e5da3ac730d102d91c55ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"af5ef434_3eab9e0a","updated":"2022-07-28 19:17:50.000000000","message":"Thanks Carlos!","commit_id":"51bc15830594b0b7d07ccdc443ba8d32c19d7ca9"}],"manila/api/v2/share_groups.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7b87fcdc68f94a7603662d7bb95eac79df366567","unresolved":true,"context_lines":[{"line_number":280,"context_line":"            raise exc.HTTPConflict(explanation\u003de.message)"},{"line_number":281,"context_line":"        except (exception.ShareGroupSnapshotNotFound,"},{"line_number":282,"context_line":"                exception.InvalidInput) as e:"},{"line_number":283,"context_line":"            msg \u003d e.msg if isinstance(e, exception.InvalidInput) else e.message"},{"line_number":284,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        return self._view_builder.detail("}],"source_content_type":"text/x-python","patch_set":2,"id":"08f11560_96e57105","line":283,"range":{"start_line":283,"start_character":12,"end_line":283,"end_character":79},"updated":"2022-07-26 08:45:12.000000000","message":"Similar problems exist elsewhere in the API layer, we can fix it together.\n[1] https://opendev.org/openstack/manila/src/commit/25a10ba4c0d147164bf2ee0f979fb582af531ca0/manila/api/v1/shares.py#L557\n[2]https://opendev.org/openstack/manila/src/commit/25a10ba4c0d147164bf2ee0f979fb582af531ca0/manila/api/v1/shares.py#L577","commit_id":"60706ad85f23a909e7fc8ca6ac6feb48f20b5cdf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"60d5344bf5b544432c63464eda72b321baf301b5","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            raise exc.HTTPConflict(explanation\u003de.message)"},{"line_number":281,"context_line":"        except (exception.ShareGroupSnapshotNotFound,"},{"line_number":282,"context_line":"                exception.InvalidInput) as e:"},{"line_number":283,"context_line":"            msg \u003d e.msg if isinstance(e, exception.InvalidInput) else e.message"},{"line_number":284,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        return self._view_builder.detail("}],"source_content_type":"text/x-python","patch_set":2,"id":"61974ec4_8e9db2fd","line":283,"range":{"start_line":283,"start_character":12,"end_line":283,"end_character":79},"in_reply_to":"08f11560_96e57105","updated":"2022-07-26 20:37:17.000000000","message":"Done","commit_id":"60706ad85f23a909e7fc8ca6ac6feb48f20b5cdf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"60d5344bf5b544432c63464eda72b321baf301b5","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            raise exc.HTTPConflict(explanation\u003de.message)"},{"line_number":281,"context_line":"        except (exception.ShareGroupSnapshotNotFound,"},{"line_number":282,"context_line":"                exception.InvalidInput) as e:"},{"line_number":283,"context_line":"            msg \u003d e.msg if isinstance(e, exception.InvalidInput) else e.message"},{"line_number":284,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        return self._view_builder.detail("}],"source_content_type":"text/x-python","patch_set":2,"id":"6a11d4a4_1719247b","line":283,"range":{"start_line":283,"start_character":12,"end_line":283,"end_character":79},"in_reply_to":"08f11560_96e57105","updated":"2022-07-26 20:37:17.000000000","message":"Done","commit_id":"60706ad85f23a909e7fc8ca6ac6feb48f20b5cdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eb5ca4cee396e7854f7c47c3ce1a1d9e7935b185","unresolved":true,"context_lines":[{"line_number":280,"context_line":"            raise exc.HTTPConflict(explanation\u003de.message)"},{"line_number":281,"context_line":"        except (exception.ShareGroupSnapshotNotFound,"},{"line_number":282,"context_line":"                exception.InvalidInput) as e:"},{"line_number":283,"context_line":"            msg \u003d e.msg if isinstance(e, exception.InvalidInput) else e.message"},{"line_number":284,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        return self._view_builder.detail("},{"line_number":287,"context_line":"            req, {k: v for k, v in new_share_group.items()})"}],"source_content_type":"text/x-python","patch_set":2,"id":"fc4ffaaf_a6867acb","line":284,"range":{"start_line":283,"start_character":12,"end_line":284,"end_character":53},"updated":"2022-07-26 18:23:22.000000000","message":"raise exc.HTTPBadRequest(explanation\u003dstr(e))\n\n\nSince these have an __str__ implementation","commit_id":"60706ad85f23a909e7fc8ca6ac6feb48f20b5cdf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"60d5344bf5b544432c63464eda72b321baf301b5","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            raise exc.HTTPConflict(explanation\u003de.message)"},{"line_number":281,"context_line":"        except (exception.ShareGroupSnapshotNotFound,"},{"line_number":282,"context_line":"                exception.InvalidInput) as e:"},{"line_number":283,"context_line":"            msg \u003d e.msg if isinstance(e, exception.InvalidInput) else e.message"},{"line_number":284,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        return self._view_builder.detail("},{"line_number":287,"context_line":"            req, {k: v for k, v in new_share_group.items()})"}],"source_content_type":"text/x-python","patch_set":2,"id":"21815856_ce3c3d12","line":284,"range":{"start_line":283,"start_character":12,"end_line":284,"end_character":53},"in_reply_to":"fc4ffaaf_a6867acb","updated":"2022-07-26 20:37:17.000000000","message":"Done","commit_id":"60706ad85f23a909e7fc8ca6ac6feb48f20b5cdf"}]}