)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c338b92d6cd71f94e0792eb42ce8771f32ebaac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"08e3e058_8655fb3f","updated":"2022-08-25 19:39:15.000000000","message":"Fix LGTM, minor comments inline; would like to see the NetApp CI vote on this. ","commit_id":"ecf421af681a29889323696de8a8b669d3c5d007"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"472c36e284be1e6755b3c2bd4a12e1087df47d49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5a69b886_96b2a93e","updated":"2022-08-29 20:26:32.000000000","message":"LGTM, thanks for the fix Kiran","commit_id":"8f2303046fd662bfaeb15abc3223acf6d76f0207"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9c8bb4970952a185a6b3ec3c91d23bd96c11ac33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d90f70cf_eb618bf9","updated":"2022-08-29 20:03:58.000000000","message":"Thanks, LGTM. NetApp\u0027s DHSS\u003dFalse CI job is failing; but this code path doesn\u0027t get invoked in the DHSS\u003dFalse mode so we should be okay. ","commit_id":"8f2303046fd662bfaeb15abc3223acf6d76f0207"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c338b92d6cd71f94e0792eb42ce8771f32ebaac","unresolved":true,"context_lines":[{"line_number":2009,"context_line":"                \u0027cifs-domain-server-discovery-mode-modify\u0027,"},{"line_number":2010,"context_line":"                api_args)"},{"line_number":2011,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":2012,"context_line":"            msg \u003d _(\"Failed to set cifs domain server discovery mode. %s\")"},{"line_number":2013,"context_line":"            # no raise to be non-blocking"},{"line_number":2014,"context_line":"            LOG.warning(msg, e.message)"},{"line_number":2015,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"518177b3_fc7e2ec0","line":2012,"range":{"start_line":2012,"start_character":68,"end_line":2012,"end_character":69},"updated":"2022-08-25 19:39:15.000000000","message":"\"to None\". Would be useful to log the security service ID","commit_id":"ecf421af681a29889323696de8a8b669d3c5d007"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d1b2ab7e5bf927eebbd92c71f23797458f7c1416","unresolved":false,"context_lines":[{"line_number":2009,"context_line":"                \u0027cifs-domain-server-discovery-mode-modify\u0027,"},{"line_number":2010,"context_line":"                api_args)"},{"line_number":2011,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":2012,"context_line":"            msg \u003d _(\"Failed to set cifs domain server discovery mode. %s\")"},{"line_number":2013,"context_line":"            # no raise to be non-blocking"},{"line_number":2014,"context_line":"            LOG.warning(msg, e.message)"},{"line_number":2015,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e148de47_913da9bc","line":2012,"range":{"start_line":2012,"start_character":68,"end_line":2012,"end_character":69},"in_reply_to":"518177b3_fc7e2ec0","updated":"2022-08-26 07:16:28.000000000","message":"Done","commit_id":"ecf421af681a29889323696de8a8b669d3c5d007"}],"releasenotes/notes/netapp-set-discovery-mode-to-none-d66b2125a8d12740.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c338b92d6cd71f94e0792eb42ce8771f32ebaac","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    If user is configuring \u0027Servers\u0027 in AD Server in the security service then"},{"line_number":5,"context_line":"    the discovery mode should be changed to \u0027none\u0027. Value of \u0027none\u0027 indicates"},{"line_number":6,"context_line":"    that domain controller discovery will not be done, and it will depend"},{"line_number":7,"context_line":"    only on preferred DC\u0027s configured."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0735c5dd_bd4b1f3d","line":5,"range":{"start_line":4,"start_character":74,"end_line":5,"end_character":50},"updated":"2022-08-25 19:39:15.000000000","message":"Mention this is a netapp specific fix:\n \n then,\n for NetApp ONTAP, the dns discovery mode should be set to \u0027none\u0027","commit_id":"ecf421af681a29889323696de8a8b669d3c5d007"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d1b2ab7e5bf927eebbd92c71f23797458f7c1416","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    If user is configuring \u0027Servers\u0027 in AD Server in the security service then"},{"line_number":5,"context_line":"    the discovery mode should be changed to \u0027none\u0027. Value of \u0027none\u0027 indicates"},{"line_number":6,"context_line":"    that domain controller discovery will not be done, and it will depend"},{"line_number":7,"context_line":"    only on preferred DC\u0027s configured."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"21da4ca9_e0a333ef","line":5,"range":{"start_line":4,"start_character":74,"end_line":5,"end_character":50},"in_reply_to":"0735c5dd_bd4b1f3d","updated":"2022-08-26 07:16:28.000000000","message":"Done","commit_id":"ecf421af681a29889323696de8a8b669d3c5d007"}]}
