)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"32b34ff2ffe1675c3826f74d42f59178f3d092d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bf8755c5_92db831b","updated":"2022-08-30 18:45:10.000000000","message":"recheck","commit_id":"722f390c1f582668906f891adfb61ef2add2979f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"204950a4721691a2e9f2139bae7919e9d51e34b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b7337321_c19038f5","updated":"2022-09-21 19:24:31.000000000","message":"Hi Kiran, \n\nSince the defaultadsite doesn\u0027t apply to Kerberos or LDAP, have you considered a different approach? Perhaps security service metadata? It kinda keeps the API simpler and allows configuratuon that we can pass on transparently.. \n\nOne downside is that metadata updates are not taken back to the share driver - it might be something we can clarify in the documentation perhaps? Or have a reserved key that can only be set and not unset/modified? \n\nSharing these thoughts in line with our current intention to allow metadata across all user facing resources: https://specs.openstack.org/openstack/manila-specs/specs/yoga/metadata-for-share-resources.html. We\u0027ve made some slow progress in this regard by adding metadata to snapshots recently.. ","commit_id":"c567778fd23416cba175ed63485363590a54a4e8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"54cd8f3cf277e1f39a2acc765c92e5119c386768","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"91164781_ce4a3629","in_reply_to":"524e3c7d_94323240","updated":"2022-09-22 16:35:55.000000000","message":"Oh - so when you say its orthogonal to \"server\" -- would it mean it can be used by the driver in place of the server?","commit_id":"c567778fd23416cba175ed63485363590a54a4e8"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"335d3b87656c5b7abe1a63850e2a88dcd9fc11ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cfa82f9b_9c7c7cf1","in_reply_to":"91164781_ce4a3629","updated":"2022-09-22 16:44:37.000000000","message":"as far as security service are concerned, active directory can have either of one but not both. https://review.opendev.org/c/openstack/manila/+/855220/4/manila/api/v1/security_service.py#224","commit_id":"c567778fd23416cba175ed63485363590a54a4e8"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"67ad84da053bbde50325a32a21da1b2347dac10b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"524e3c7d_94323240","in_reply_to":"b7337321_c19038f5","updated":"2022-09-22 13:29:50.000000000","message":"I had given a thought of having it as metadata before implementing this in our setup. This field is orthogonal to \u0027server\u0027 and carries same importance as that of \u0027server\u0027 field even-though its not applicable to other services like LDAP. E.g.\nWe have other field e.g. OU as part of service structure even-though its optional. \nAlso, I believe there is less probability of adding new options under \u0027security service\u0027 in future as most are already in place. So if something comes up we can consider it under metadata in future.","commit_id":"c567778fd23416cba175ed63485363590a54a4e8"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"187a504c2f2e10372e60eb931f6f510b993e8a17","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b82fc482_e5740b70","updated":"2022-11-23 00:59:28.000000000","message":"I didn\u0027t understand It sounds more like a feature than a bug fix. If so, is there any spec ? How has it be accepted ? Is there any community discussion about this feature ? ","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"54bbbdf8c3ca11a59695074d7c4345b5be5e2f8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"257db88b_cfac2225","updated":"2022-11-24 02:15:52.000000000","message":"Thanks Kiran. This feature is adding a new way of configuring the AD. How did you test it ? Have you coded some tempest test ? If not, is there any plan for working on it ? I think it would be nice.","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4a4531c2df2c80dafd19f56d043db8b9b342278a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b8ecbba9_0969f8da","in_reply_to":"257db88b_cfac2225","updated":"2022-11-28 15:40:27.000000000","message":"defaultadsite was tested on our cluster. Sure, I will add tempest test.","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"1710bd8df47a4328568e65b35b53281f62f7ff64","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e467f896_535deff3","in_reply_to":"b82fc482_e5740b70","updated":"2022-11-23 08:04:31.000000000","message":"Yes, this can be considered as feature, though not big enough to have spec. I see few other fields of security-service are merged as bug e.g OU.\n\n\u003eIs there any community discussion about this feature ?\nNothing as such. At this stage, this is specific to NetApp. https://kb.netapp.com/Advice_and_Troubleshooting/Data_Storage_Software/ONTAP_OS/What_is_Domain_Controller_Discovery","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"54bbbdf8c3ca11a59695074d7c4345b5be5e2f8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"01008e55_e50cec29","in_reply_to":"e467f896_535deff3","updated":"2022-11-24 02:15:52.000000000","message":"Ack","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d5f967d55dee9df94f677b9563a0947c6df15c95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"63b2fcd8_456dc106","updated":"2023-02-14 22:59:20.000000000","message":"Thanks for working on this change and sorry for the time we took to review - Please take a look at the comments inline :)","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96fbe136878e405a1e4f14486acee65a151e8315","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"cf869d7f_3533323d","updated":"2023-02-16 01:11:46.000000000","message":"Thank you for the enhancements. I was giving this some more thought and I really think we should follow the pattern that we have for core + driver changes, sorry :/\n\nSo what I\u0027m asking is:\n- Keep this change as a core change only (remove the NetApp drive modifications from this change)\n- Propose a new change with the NetApp driver changes having a depends-on to this change.\n\nIf we keep the change like it is, we tend to seem that we are introducing features for a specific driver. It is also better for readability and future commits investigation if we keep things separate. We have other examples of people doing this in the past as well.\n\nOther than this, I have nothing else to point out. Again, thank you for working on this change and for being responsive with the reviews.","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a55ce01085c7d775003d17668a58ba2d6b025d90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"dea7867a_8138d570","updated":"2023-02-16 07:15:42.000000000","message":"Thanks for the changes, some comments inline","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1f2c673ab1b95f0a1332bc7ff41cc54b829f0f3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b1e55f47_a6cb526c","updated":"2023-02-16 11:48:42.000000000","message":"LGTM - Thanks Kiran!","commit_id":"858939c19042bca563f9241325b92074ddf61e08"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6dd12db44c43ab84cadbe0a835af4f7c0b2ce4c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ef1105b8_c8bfaea0","updated":"2023-02-16 15:32:37.000000000","message":"Thanks Kiran!","commit_id":"858939c19042bca563f9241325b92074ddf61e08"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0c3810623adf56af40849536b3478a81d48b7d50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"44144385_b9932bc6","updated":"2023-02-17 00:08:10.000000000","message":"recheck\n\nknown db migration test failure","commit_id":"858939c19042bca563f9241325b92074ddf61e08"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a15dc48133385c1d031353cfc1b546f41ae300db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1fbcbee5_2e05b506","updated":"2023-02-16 16:51:30.000000000","message":"recheck\n\nsporadic failure with AZs which is unrelated to this patch","commit_id":"858939c19042bca563f9241325b92074ddf61e08"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d5f967d55dee9df94f677b9563a0947c6df15c95","unresolved":true,"context_lines":[{"line_number":2425,"context_line":"  required: true"},{"line_number":2426,"context_line":"  type: string"},{"line_number":2427,"context_line":"  min_version: 2.75"},{"line_number":2428,"context_line":"security_service_default_ad_site_request:"},{"line_number":2429,"context_line":"  description: |"},{"line_number":2430,"context_line":"    The security service default AD site."},{"line_number":2431,"context_line":"  in: body"},{"line_number":2432,"context_line":"  required: false"},{"line_number":2433,"context_line":"  type: string"},{"line_number":2434,"context_line":"  min_version: 2.75"},{"line_number":2435,"context_line":"security_service_dns_ip:"},{"line_number":2436,"context_line":"  description: |"},{"line_number":2437,"context_line":"    The DNS IP address that is used inside the project network."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"eab8f7e0_1f3741b8","line":2434,"range":{"start_line":2428,"start_character":0,"end_line":2434,"end_character":19},"updated":"2023-02-14 22:59:20.000000000","message":"nit: request, body/response and query parameters are separated across this file. Please move this to the request side.","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96fbe136878e405a1e4f14486acee65a151e8315","unresolved":false,"context_lines":[{"line_number":2425,"context_line":"  required: true"},{"line_number":2426,"context_line":"  type: string"},{"line_number":2427,"context_line":"  min_version: 2.75"},{"line_number":2428,"context_line":"security_service_default_ad_site_request:"},{"line_number":2429,"context_line":"  description: |"},{"line_number":2430,"context_line":"    The security service default AD site."},{"line_number":2431,"context_line":"  in: body"},{"line_number":2432,"context_line":"  required: false"},{"line_number":2433,"context_line":"  type: string"},{"line_number":2434,"context_line":"  min_version: 2.75"},{"line_number":2435,"context_line":"security_service_dns_ip:"},{"line_number":2436,"context_line":"  description: |"},{"line_number":2437,"context_line":"    The DNS IP address that is used inside the project network."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"796ebd59_3d619209","line":2434,"range":{"start_line":2428,"start_character":0,"end_line":2434,"end_character":19},"in_reply_to":"5542d9c1_272b737e","updated":"2023-02-16 01:11:46.000000000","message":"Let\u0027s keep it as is then, thanks for checking!","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b86b90dbdb028776c7a1a488d88f0524fbe1b5ad","unresolved":true,"context_lines":[{"line_number":2425,"context_line":"  required: true"},{"line_number":2426,"context_line":"  type: string"},{"line_number":2427,"context_line":"  min_version: 2.75"},{"line_number":2428,"context_line":"security_service_default_ad_site_request:"},{"line_number":2429,"context_line":"  description: |"},{"line_number":2430,"context_line":"    The security service default AD site."},{"line_number":2431,"context_line":"  in: body"},{"line_number":2432,"context_line":"  required: false"},{"line_number":2433,"context_line":"  type: string"},{"line_number":2434,"context_line":"  min_version: 2.75"},{"line_number":2435,"context_line":"security_service_dns_ip:"},{"line_number":2436,"context_line":"  description: |"},{"line_number":2437,"context_line":"    The DNS IP address that is used inside the project network."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5542d9c1_272b737e","line":2434,"range":{"start_line":2428,"start_character":0,"end_line":2434,"end_character":19},"in_reply_to":"eab8f7e0_1f3741b8","updated":"2023-02-15 16:10:27.000000000","message":"If you check little bit down in same file, all other security service options are mentioned in same way. Do you want me to keep as it is or still change ?","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a55ce01085c7d775003d17668a58ba2d6b025d90","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a6a53c47_59f0d1d4","updated":"2023-02-16 07:15:42.000000000","message":"You\u0027re missing an addition to rest_api_version_history: https://github.com/openstack/manila/blob/master/manila/api/openstack/rest_api_version_history.rst","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"156acaba580068d5d8577e27114758787dd8af23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7bcf7641_18cda765","in_reply_to":"a6a53c47_59f0d1d4","updated":"2023-02-16 09:31:57.000000000","message":"Done","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a55ce01085c7d775003d17668a58ba2d6b025d90","unresolved":true,"context_lines":[{"line_number":192,"context_line":"             \u0027error\u0027 state."},{"line_number":193,"context_line":"    * 2.75 - Added option to specify quiesce wait time in share replica"},{"line_number":194,"context_line":"             promote API."},{"line_number":195,"context_line":"    * 2.76 - Added \u0027default_ad_site\u0027 option in security service."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"\"\"\""},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"a8c42ade_cb07485e","line":195,"range":{"start_line":195,"start_character":13,"end_line":195,"end_character":64},"updated":"2023-02-16 07:15:42.000000000","message":"s/option/field\n\ns/security service./security service object","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"156acaba580068d5d8577e27114758787dd8af23","unresolved":false,"context_lines":[{"line_number":192,"context_line":"             \u0027error\u0027 state."},{"line_number":193,"context_line":"    * 2.75 - Added option to specify quiesce wait time in share replica"},{"line_number":194,"context_line":"             promote API."},{"line_number":195,"context_line":"    * 2.76 - Added \u0027default_ad_site\u0027 option in security service."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"\"\"\""},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"a9da9085_fa46d1c4","line":195,"range":{"start_line":195,"start_character":13,"end_line":195,"end_character":64},"in_reply_to":"a8c42ade_cb07485e","updated":"2023-02-16 09:31:57.000000000","message":"Done","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"}],"manila/api/v1/security_service.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"54bbbdf8c3ca11a59695074d7c4345b5be5e2f8c","unresolved":true,"context_lines":[{"line_number":221,"context_line":"                reason\u003d(_(\"Can not create security service because both \""},{"line_number":222,"context_line":"                          \"server and default AD site is provided, Specify \""},{"line_number":223,"context_line":"                          \"either server or default AD site.\")))"},{"line_number":224,"context_line":"        if security_srv_type \u003d\u003d \u0027active_directory\u0027:"},{"line_number":225,"context_line":"            if not server and not defaultadsite:"},{"line_number":226,"context_line":"                raise exception.InvalidInput("},{"line_number":227,"context_line":"                    reason\u003d(_(\"Can not create security service because either \""},{"line_number":228,"context_line":"                              \"server or default AD site is needed for Active \""}],"source_content_type":"text/x-python","patch_set":7,"id":"2462a68b_0408e356","line":225,"range":{"start_line":224,"start_character":7,"end_line":225,"end_character":48},"updated":"2022-11-24 02:15:52.000000000","message":"Don\u0027t need if chains:\n\nif security_srv_type \u003d\u003d \u0027active_directory\u0027 and not server and not defaultadsite:","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4a4531c2df2c80dafd19f56d043db8b9b342278a","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                reason\u003d(_(\"Can not create security service because both \""},{"line_number":222,"context_line":"                          \"server and default AD site is provided, Specify \""},{"line_number":223,"context_line":"                          \"either server or default AD site.\")))"},{"line_number":224,"context_line":"        if security_srv_type \u003d\u003d \u0027active_directory\u0027:"},{"line_number":225,"context_line":"            if not server and not defaultadsite:"},{"line_number":226,"context_line":"                raise exception.InvalidInput("},{"line_number":227,"context_line":"                    reason\u003d(_(\"Can not create security service because either \""},{"line_number":228,"context_line":"                              \"server or default AD site is needed for Active \""}],"source_content_type":"text/x-python","patch_set":7,"id":"73e74678_e38a8db2","line":225,"range":{"start_line":224,"start_character":7,"end_line":225,"end_character":48},"in_reply_to":"2462a68b_0408e356","updated":"2022-11-28 15:40:27.000000000","message":"fixed.","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"54bbbdf8c3ca11a59695074d7c4345b5be5e2f8c","unresolved":true,"context_lines":[{"line_number":223,"context_line":"                          \"either server or default AD site.\")))"},{"line_number":224,"context_line":"        if security_srv_type \u003d\u003d \u0027active_directory\u0027:"},{"line_number":225,"context_line":"            if not server and not defaultadsite:"},{"line_number":226,"context_line":"                raise exception.InvalidInput("},{"line_number":227,"context_line":"                    reason\u003d(_(\"Can not create security service because either \""},{"line_number":228,"context_line":"                              \"server or default AD site is needed for Active \""},{"line_number":229,"context_line":"                              \"directory service type.\")))"},{"line_number":230,"context_line":"        security_service_args[\u0027project_id\u0027] \u003d context.project_id"},{"line_number":231,"context_line":"        security_service \u003d db.security_service_create("},{"line_number":232,"context_line":"            context, security_service_args)"}],"source_content_type":"text/x-python","patch_set":7,"id":"6d679967_2f6f345d","line":229,"range":{"start_line":226,"start_character":16,"end_line":229,"end_character":58},"updated":"2022-11-24 02:15:52.000000000","message":"Previously, the API was accepting the AD without server. Now, you are forcing either server or the default AD. Would it invalidate a use case ?\n\nAre you fixing a pre-existent bug (ss AD without server) ? If so, it should be reported and fixed by another patch, so we can backport it. Just make sure that this is a bug, not a desired behavior.","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4a4531c2df2c80dafd19f56d043db8b9b342278a","unresolved":true,"context_lines":[{"line_number":223,"context_line":"                          \"either server or default AD site.\")))"},{"line_number":224,"context_line":"        if security_srv_type \u003d\u003d \u0027active_directory\u0027:"},{"line_number":225,"context_line":"            if not server and not defaultadsite:"},{"line_number":226,"context_line":"                raise exception.InvalidInput("},{"line_number":227,"context_line":"                    reason\u003d(_(\"Can not create security service because either \""},{"line_number":228,"context_line":"                              \"server or default AD site is needed for Active \""},{"line_number":229,"context_line":"                              \"directory service type.\")))"},{"line_number":230,"context_line":"        security_service_args[\u0027project_id\u0027] \u003d context.project_id"},{"line_number":231,"context_line":"        security_service \u003d db.security_service_create("},{"line_number":232,"context_line":"            context, security_service_args)"}],"source_content_type":"text/x-python","patch_set":7,"id":"efdf81c8_1aafb4f4","line":229,"range":{"start_line":226,"start_character":16,"end_line":229,"end_character":58},"in_reply_to":"6d679967_2f6f345d","updated":"2022-11-28 15:40:27.000000000","message":"No, I do not want to change default behaviour. \u0027server\u0027 is not mandatory, but user can not specify both \u0027server\u0027 and \u0027defaultadsite\u0027 in request.","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e93c88ef5bfa14c2f7757d8079ff07cab0406cb1","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                          \"either server or default AD site.\")))"},{"line_number":224,"context_line":"        if security_srv_type \u003d\u003d \u0027active_directory\u0027:"},{"line_number":225,"context_line":"            if not server and not defaultadsite:"},{"line_number":226,"context_line":"                raise exception.InvalidInput("},{"line_number":227,"context_line":"                    reason\u003d(_(\"Can not create security service because either \""},{"line_number":228,"context_line":"                              \"server or default AD site is needed for Active \""},{"line_number":229,"context_line":"                              \"directory service type.\")))"},{"line_number":230,"context_line":"        security_service_args[\u0027project_id\u0027] \u003d context.project_id"},{"line_number":231,"context_line":"        security_service \u003d db.security_service_create("},{"line_number":232,"context_line":"            context, security_service_args)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7503249a_72404552","line":229,"range":{"start_line":226,"start_character":16,"end_line":229,"end_character":58},"in_reply_to":"efdf81c8_1aafb4f4","updated":"2023-02-09 13:00:21.000000000","message":"Done","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d5f967d55dee9df94f677b9563a0947c6df15c95","unresolved":true,"context_lines":[{"line_number":222,"context_line":"                msg \u003d _(\u0027Default AD site supported from API version 2.75.\u0027)"},{"line_number":223,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"            if (security_srv_type \u003d\u003d \u0027active_directory\u0027 and server and"},{"line_number":226,"context_line":"                    default_ad_site):"},{"line_number":227,"context_line":"                raise exception.InvalidInput("},{"line_number":228,"context_line":"                    reason\u003d(_(\"Can not create security service because both \""},{"line_number":229,"context_line":"                              \"server and default AD site is provided, \""}],"source_content_type":"text/x-python","patch_set":13,"id":"35cae964_b49b9742","line":226,"range":{"start_line":225,"start_character":12,"end_line":226,"end_character":37},"updated":"2023-02-14 22:59:20.000000000","message":"we should be validating this on the update as well, shouldn\u0027t we? otherwise we would be allowing people that already have a server configured to also set a default ad site as soon as we introduce this parameter. So I would be say it is better to be safe and add an extra validation than not adding it :)","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b86b90dbdb028776c7a1a488d88f0524fbe1b5ad","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                msg \u003d _(\u0027Default AD site supported from API version 2.75.\u0027)"},{"line_number":223,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"            if (security_srv_type \u003d\u003d \u0027active_directory\u0027 and server and"},{"line_number":226,"context_line":"                    default_ad_site):"},{"line_number":227,"context_line":"                raise exception.InvalidInput("},{"line_number":228,"context_line":"                    reason\u003d(_(\"Can not create security service because both \""},{"line_number":229,"context_line":"                              \"server and default AD site is provided, \""}],"source_content_type":"text/x-python","patch_set":13,"id":"743157a8_45792086","line":226,"range":{"start_line":225,"start_character":12,"end_line":226,"end_character":37},"in_reply_to":"35cae964_b49b9742","updated":"2023-02-15 16:10:27.000000000","message":"Done","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d5f967d55dee9df94f677b9563a0947c6df15c95","unresolved":true,"context_lines":[{"line_number":226,"context_line":"                    default_ad_site):"},{"line_number":227,"context_line":"                raise exception.InvalidInput("},{"line_number":228,"context_line":"                    reason\u003d(_(\"Can not create security service because both \""},{"line_number":229,"context_line":"                              \"server and default AD site is provided, \""},{"line_number":230,"context_line":"                              \"Specify either server or default AD site.\")))"},{"line_number":231,"context_line":"        security_service_args[\u0027project_id\u0027] \u003d context.project_id"},{"line_number":232,"context_line":"        security_service \u003d db.security_service_create("}],"source_content_type":"text/x-python","patch_set":13,"id":"e763cbf0_7348aed9","line":229,"range":{"start_line":229,"start_character":58,"end_line":229,"end_character":60},"updated":"2023-02-14 22:59:20.000000000","message":"nit: were","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b86b90dbdb028776c7a1a488d88f0524fbe1b5ad","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                    default_ad_site):"},{"line_number":227,"context_line":"                raise exception.InvalidInput("},{"line_number":228,"context_line":"                    reason\u003d(_(\"Can not create security service because both \""},{"line_number":229,"context_line":"                              \"server and default AD site is provided, \""},{"line_number":230,"context_line":"                              \"Specify either server or default AD site.\")))"},{"line_number":231,"context_line":"        security_service_args[\u0027project_id\u0027] \u003d context.project_id"},{"line_number":232,"context_line":"        security_service \u003d db.security_service_create("}],"source_content_type":"text/x-python","patch_set":13,"id":"ccb90bc8_144d02c9","line":229,"range":{"start_line":229,"start_character":58,"end_line":229,"end_character":60},"in_reply_to":"e763cbf0_7348aed9","updated":"2023-02-15 16:10:27.000000000","message":"Done","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d5f967d55dee9df94f677b9563a0947c6df15c95","unresolved":true,"context_lines":[{"line_number":226,"context_line":"                    default_ad_site):"},{"line_number":227,"context_line":"                raise exception.InvalidInput("},{"line_number":228,"context_line":"                    reason\u003d(_(\"Can not create security service because both \""},{"line_number":229,"context_line":"                              \"server and default AD site is provided, \""},{"line_number":230,"context_line":"                              \"Specify either server or default AD site.\")))"},{"line_number":231,"context_line":"        security_service_args[\u0027project_id\u0027] \u003d context.project_id"},{"line_number":232,"context_line":"        security_service \u003d db.security_service_create("},{"line_number":233,"context_line":"            context, security_service_args)"}],"source_content_type":"text/x-python","patch_set":13,"id":"2377b44b_9ba09cfe","line":230,"range":{"start_line":229,"start_character":69,"end_line":230,"end_character":71},"updated":"2023-02-14 22:59:20.000000000","message":". Specify...","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b86b90dbdb028776c7a1a488d88f0524fbe1b5ad","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                    default_ad_site):"},{"line_number":227,"context_line":"                raise exception.InvalidInput("},{"line_number":228,"context_line":"                    reason\u003d(_(\"Can not create security service because both \""},{"line_number":229,"context_line":"                              \"server and default AD site is provided, \""},{"line_number":230,"context_line":"                              \"Specify either server or default AD site.\")))"},{"line_number":231,"context_line":"        security_service_args[\u0027project_id\u0027] \u003d context.project_id"},{"line_number":232,"context_line":"        security_service \u003d db.security_service_create("},{"line_number":233,"context_line":"            context, security_service_args)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5696e29e_b5ad8343","line":230,"range":{"start_line":229,"start_character":69,"end_line":230,"end_character":71},"in_reply_to":"2377b44b_9ba09cfe","updated":"2023-02-15 16:10:27.000000000","message":"Done","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a55ce01085c7d775003d17668a58ba2d6b025d90","unresolved":true,"context_lines":[{"line_number":197,"context_line":"        default_ad_site \u003d security_service_data.get(\u0027default_ad_site\u0027)"},{"line_number":198,"context_line":"        if default_ad_site:"},{"line_number":199,"context_line":"            if req.api_version_request \u003c api_version.APIVersionRequest(\"2.76\"):"},{"line_number":200,"context_line":"                msg \u003d _(\u0027Default AD site supported from API version 2.76.\u0027)"},{"line_number":201,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"            if (security_service[\u0027type\u0027] \u003d\u003d \u0027active_directory\u0027 and server and"}],"source_content_type":"text/x-python","patch_set":14,"id":"08c6e7b2_0510b057","line":200,"range":{"start_line":200,"start_character":41,"end_line":200,"end_character":50},"updated":"2023-02-16 07:15:42.000000000","message":"\u0027\"default_ad_site\" is only supported from API version 2.76.\u0027","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"156acaba580068d5d8577e27114758787dd8af23","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        default_ad_site \u003d security_service_data.get(\u0027default_ad_site\u0027)"},{"line_number":198,"context_line":"        if default_ad_site:"},{"line_number":199,"context_line":"            if req.api_version_request \u003c api_version.APIVersionRequest(\"2.76\"):"},{"line_number":200,"context_line":"                msg \u003d _(\u0027Default AD site supported from API version 2.76.\u0027)"},{"line_number":201,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"            if (security_service[\u0027type\u0027] \u003d\u003d \u0027active_directory\u0027 and server and"}],"source_content_type":"text/x-python","patch_set":14,"id":"a5471e26_0b0c0757","line":200,"range":{"start_line":200,"start_character":41,"end_line":200,"end_character":50},"in_reply_to":"08c6e7b2_0510b057","updated":"2023-02-16 09:31:57.000000000","message":"Done","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a55ce01085c7d775003d17668a58ba2d6b025d90","unresolved":true,"context_lines":[{"line_number":203,"context_line":"            if (security_service[\u0027type\u0027] \u003d\u003d \u0027active_directory\u0027 and server and"},{"line_number":204,"context_line":"                    default_ad_site):"},{"line_number":205,"context_line":"                raise exception.InvalidInput("},{"line_number":206,"context_line":"                    reason\u003d(_(\"Can not create security service because both \""},{"line_number":207,"context_line":"                              \"server and default AD site were provided. \""},{"line_number":208,"context_line":"                              \"Specify either server or default AD site.\")))"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"bf53cbe1_5c1951df","line":206,"range":{"start_line":206,"start_character":31,"end_line":206,"end_character":38},"updated":"2023-02-16 07:15:42.000000000","message":"Cannot","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"156acaba580068d5d8577e27114758787dd8af23","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            if (security_service[\u0027type\u0027] \u003d\u003d \u0027active_directory\u0027 and server and"},{"line_number":204,"context_line":"                    default_ad_site):"},{"line_number":205,"context_line":"                raise exception.InvalidInput("},{"line_number":206,"context_line":"                    reason\u003d(_(\"Can not create security service because both \""},{"line_number":207,"context_line":"                              \"server and default AD site were provided. \""},{"line_number":208,"context_line":"                              \"Specify either server or default AD site.\")))"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"14321155_4d214ab5","line":206,"range":{"start_line":206,"start_character":31,"end_line":206,"end_character":38},"in_reply_to":"bf53cbe1_5c1951df","updated":"2023-02-16 09:31:57.000000000","message":"Done","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a55ce01085c7d775003d17668a58ba2d6b025d90","unresolved":true,"context_lines":[{"line_number":204,"context_line":"                    default_ad_site):"},{"line_number":205,"context_line":"                raise exception.InvalidInput("},{"line_number":206,"context_line":"                    reason\u003d(_(\"Can not create security service because both \""},{"line_number":207,"context_line":"                              \"server and default AD site were provided. \""},{"line_number":208,"context_line":"                              \"Specify either server or default AD site.\")))"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        policy.check_policy(context, RESOURCE_NAME, \u0027update\u0027, security_service)"}],"source_content_type":"text/x-python","patch_set":14,"id":"21e53bf4_1e914b03","line":207,"range":{"start_line":207,"start_character":42,"end_line":207,"end_character":57},"updated":"2023-02-16 07:15:42.000000000","message":"\u0027default_ad_site\u0027\n\nuse the parameter name here and below please","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"156acaba580068d5d8577e27114758787dd8af23","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                    default_ad_site):"},{"line_number":205,"context_line":"                raise exception.InvalidInput("},{"line_number":206,"context_line":"                    reason\u003d(_(\"Can not create security service because both \""},{"line_number":207,"context_line":"                              \"server and default AD site were provided. \""},{"line_number":208,"context_line":"                              \"Specify either server or default AD site.\")))"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        policy.check_policy(context, RESOURCE_NAME, \u0027update\u0027, security_service)"}],"source_content_type":"text/x-python","patch_set":14,"id":"705952a9_5ed54797","line":207,"range":{"start_line":207,"start_character":42,"end_line":207,"end_character":57},"in_reply_to":"21e53bf4_1e914b03","updated":"2023-02-16 09:31:57.000000000","message":"Done","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a55ce01085c7d775003d17668a58ba2d6b025d90","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        default_ad_site \u003d security_service_args.get(\u0027default_ad_site\u0027)"},{"line_number":234,"context_line":"        if default_ad_site:"},{"line_number":235,"context_line":"            if req.api_version_request \u003c api_version.APIVersionRequest(\"2.76\"):"},{"line_number":236,"context_line":"                msg \u003d _(\u0027Default AD site supported from API version 2.76.\u0027)"},{"line_number":237,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"            if (security_srv_type \u003d\u003d \u0027active_directory\u0027 and server and"}],"source_content_type":"text/x-python","patch_set":14,"id":"c25abafa_6751c0f2","line":236,"range":{"start_line":236,"start_character":41,"end_line":236,"end_character":50},"updated":"2023-02-16 07:15:42.000000000","message":"\u0027\"default_ad_site\" is only supported from API version 2.76.\u0027","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"156acaba580068d5d8577e27114758787dd8af23","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        default_ad_site \u003d security_service_args.get(\u0027default_ad_site\u0027)"},{"line_number":234,"context_line":"        if default_ad_site:"},{"line_number":235,"context_line":"            if req.api_version_request \u003c api_version.APIVersionRequest(\"2.76\"):"},{"line_number":236,"context_line":"                msg \u003d _(\u0027Default AD site supported from API version 2.76.\u0027)"},{"line_number":237,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"            if (security_srv_type \u003d\u003d \u0027active_directory\u0027 and server and"}],"source_content_type":"text/x-python","patch_set":14,"id":"1e9b574b_e203f871","line":236,"range":{"start_line":236,"start_character":41,"end_line":236,"end_character":50},"in_reply_to":"c25abafa_6751c0f2","updated":"2023-02-16 09:31:57.000000000","message":"Done","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a55ce01085c7d775003d17668a58ba2d6b025d90","unresolved":true,"context_lines":[{"line_number":240,"context_line":"                    default_ad_site):"},{"line_number":241,"context_line":"                raise exception.InvalidInput("},{"line_number":242,"context_line":"                    reason\u003d(_(\"Can not create security service because both \""},{"line_number":243,"context_line":"                              \"server and default AD site is provided, \""},{"line_number":244,"context_line":"                              \"Specify either server or default AD site.\")))"},{"line_number":245,"context_line":"        security_service_args[\u0027project_id\u0027] \u003d context.project_id"},{"line_number":246,"context_line":"        security_service \u003d db.security_service_create("}],"source_content_type":"text/x-python","patch_set":14,"id":"08a3a402_d500ebee","line":243,"range":{"start_line":243,"start_character":42,"end_line":243,"end_character":57},"updated":"2023-02-16 07:15:42.000000000","message":"\u0027default_ad_site\u0027\n\nuse the parameter name here and below please","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a55ce01085c7d775003d17668a58ba2d6b025d90","unresolved":true,"context_lines":[{"line_number":240,"context_line":"                    default_ad_site):"},{"line_number":241,"context_line":"                raise exception.InvalidInput("},{"line_number":242,"context_line":"                    reason\u003d(_(\"Can not create security service because both \""},{"line_number":243,"context_line":"                              \"server and default AD site is provided, \""},{"line_number":244,"context_line":"                              \"Specify either server or default AD site.\")))"},{"line_number":245,"context_line":"        security_service_args[\u0027project_id\u0027] \u003d context.project_id"},{"line_number":246,"context_line":"        security_service \u003d db.security_service_create("}],"source_content_type":"text/x-python","patch_set":14,"id":"945a393f_2a948080","line":243,"range":{"start_line":243,"start_character":58,"end_line":243,"end_character":60},"updated":"2023-02-16 07:15:42.000000000","message":"were","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"156acaba580068d5d8577e27114758787dd8af23","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                    default_ad_site):"},{"line_number":241,"context_line":"                raise exception.InvalidInput("},{"line_number":242,"context_line":"                    reason\u003d(_(\"Can not create security service because both \""},{"line_number":243,"context_line":"                              \"server and default AD site is provided, \""},{"line_number":244,"context_line":"                              \"Specify either server or default AD site.\")))"},{"line_number":245,"context_line":"        security_service_args[\u0027project_id\u0027] \u003d context.project_id"},{"line_number":246,"context_line":"        security_service \u003d db.security_service_create("}],"source_content_type":"text/x-python","patch_set":14,"id":"04f526ba_fa55c1d5","line":243,"range":{"start_line":243,"start_character":42,"end_line":243,"end_character":57},"in_reply_to":"08a3a402_d500ebee","updated":"2023-02-16 09:31:57.000000000","message":"Done","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"156acaba580068d5d8577e27114758787dd8af23","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                    default_ad_site):"},{"line_number":241,"context_line":"                raise exception.InvalidInput("},{"line_number":242,"context_line":"                    reason\u003d(_(\"Can not create security service because both \""},{"line_number":243,"context_line":"                              \"server and default AD site is provided, \""},{"line_number":244,"context_line":"                              \"Specify either server or default AD site.\")))"},{"line_number":245,"context_line":"        security_service_args[\u0027project_id\u0027] \u003d context.project_id"},{"line_number":246,"context_line":"        security_service \u003d db.security_service_create("}],"source_content_type":"text/x-python","patch_set":14,"id":"141e0330_a9b3e116","line":243,"range":{"start_line":243,"start_character":58,"end_line":243,"end_character":60},"in_reply_to":"945a393f_2a948080","updated":"2023-02-16 09:31:57.000000000","message":"Done","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"}],"manila/db/migrations/alembic/versions/c476aeb186ec_add_default_ad_site_to_security_service.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d5f967d55dee9df94f677b9563a0947c6df15c95","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def downgrade():"},{"line_number":36,"context_line":"    op.drop_column(\u0027security_services\u0027, \u0027default_ad_site\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1eff63f3_83f5ad12","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":58},"updated":"2023-02-14 22:59:20.000000000","message":"please surround in a try/catch","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b86b90dbdb028776c7a1a488d88f0524fbe1b5ad","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def downgrade():"},{"line_number":36,"context_line":"    op.drop_column(\u0027security_services\u0027, \u0027default_ad_site\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"434b43ac_5705fd66","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":58},"in_reply_to":"1eff63f3_83f5ad12","updated":"2023-02-15 16:10:27.000000000","message":"Done","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"}],"manila/db/sqlalchemy/models.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"54bbbdf8c3ca11a59695074d7c4345b5be5e2f8c","unresolved":true,"context_lines":[{"line_number":931,"context_line":"    name \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":932,"context_line":"    description \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":933,"context_line":"    ou \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":934,"context_line":"    defaultadsite \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"class ShareNetwork(BASE, ManilaBase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"03954bd9_565f8904","line":934,"range":{"start_line":934,"start_character":4,"end_line":934,"end_character":18},"updated":"2022-11-24 02:15:52.000000000","message":"why is it being called as joined strings, instead of \"default_ad_site\" ? I think the pattern has been with \"_\", see \"dns_id\", \"project_id\" and every other examples.\n\nIf changed here, all references in this patch should be changed from \"defaultadsite\" to \"default_ad_site\"","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4a4531c2df2c80dafd19f56d043db8b9b342278a","unresolved":false,"context_lines":[{"line_number":931,"context_line":"    name \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":932,"context_line":"    description \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":933,"context_line":"    ou \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":934,"context_line":"    defaultadsite \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"class ShareNetwork(BASE, ManilaBase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5558a3b0_fd90a92c","line":934,"range":{"start_line":934,"start_character":4,"end_line":934,"end_character":18},"in_reply_to":"03954bd9_565f8904","updated":"2022-11-28 15:40:27.000000000","message":"Done","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"54bbbdf8c3ca11a59695074d7c4345b5be5e2f8c","unresolved":true,"context_lines":[{"line_number":1709,"context_line":""},{"line_number":1710,"context_line":"        if security_service[\u0027ou\u0027] is not None:"},{"line_number":1711,"context_line":"            api_args[\u0027organizational-unit\u0027] \u003d security_service[\u0027ou\u0027]"},{"line_number":1712,"context_line":"        if security_service.get(\u0027defaultadsite\u0027, None):"},{"line_number":1713,"context_line":"            api_args[\u0027default-site\u0027] \u003d security_service[\u0027defaultadsite\u0027]"},{"line_number":1714,"context_line":""},{"line_number":1715,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"73ab2865_24217398","line":1712,"range":{"start_line":1712,"start_character":49,"end_line":1712,"end_character":53},"updated":"2022-11-24 02:15:52.000000000","message":"Not required, since None is the default.","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4a4531c2df2c80dafd19f56d043db8b9b342278a","unresolved":false,"context_lines":[{"line_number":1709,"context_line":""},{"line_number":1710,"context_line":"        if security_service[\u0027ou\u0027] is not None:"},{"line_number":1711,"context_line":"            api_args[\u0027organizational-unit\u0027] \u003d security_service[\u0027ou\u0027]"},{"line_number":1712,"context_line":"        if security_service.get(\u0027defaultadsite\u0027, None):"},{"line_number":1713,"context_line":"            api_args[\u0027default-site\u0027] \u003d security_service[\u0027defaultadsite\u0027]"},{"line_number":1714,"context_line":""},{"line_number":1715,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"c17bedce_56d4d6f1","line":1712,"range":{"start_line":1712,"start_character":49,"end_line":1712,"end_character":53},"in_reply_to":"73ab2865_24217398","updated":"2022-11-28 15:40:27.000000000","message":"Done","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"54bbbdf8c3ca11a59695074d7c4345b5be5e2f8c","unresolved":true,"context_lines":[{"line_number":2002,"context_line":""},{"line_number":2003,"context_line":"    @na_utils.trace"},{"line_number":2004,"context_line":"    def configure_cifs_options(self, security_service):"},{"line_number":2005,"context_line":"        if security_service.get(\u0027server\u0027, None):"},{"line_number":2006,"context_line":"            api_args \u003d {\u0027mode\u0027: \u0027none\u0027}"},{"line_number":2007,"context_line":"        elif security_service.get(\u0027defaultadsite\u0027, None):"},{"line_number":2008,"context_line":"            api_args \u003d {\u0027mode\u0027: \u0027site\u0027}"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf8d4e8c_d3170f7e","line":2005,"range":{"start_line":2005,"start_character":42,"end_line":2005,"end_character":46},"updated":"2022-11-24 02:15:52.000000000","message":"Not required, since None is the default.","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4a4531c2df2c80dafd19f56d043db8b9b342278a","unresolved":false,"context_lines":[{"line_number":2002,"context_line":""},{"line_number":2003,"context_line":"    @na_utils.trace"},{"line_number":2004,"context_line":"    def configure_cifs_options(self, security_service):"},{"line_number":2005,"context_line":"        if security_service.get(\u0027server\u0027, None):"},{"line_number":2006,"context_line":"            api_args \u003d {\u0027mode\u0027: \u0027none\u0027}"},{"line_number":2007,"context_line":"        elif security_service.get(\u0027defaultadsite\u0027, None):"},{"line_number":2008,"context_line":"            api_args \u003d {\u0027mode\u0027: \u0027site\u0027}"}],"source_content_type":"text/x-python","patch_set":7,"id":"382f720c_ae76b9ee","line":2005,"range":{"start_line":2005,"start_character":42,"end_line":2005,"end_character":46},"in_reply_to":"bf8d4e8c_d3170f7e","updated":"2022-11-28 15:40:27.000000000","message":"Done","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"54bbbdf8c3ca11a59695074d7c4345b5be5e2f8c","unresolved":true,"context_lines":[{"line_number":2004,"context_line":"    def configure_cifs_options(self, security_service):"},{"line_number":2005,"context_line":"        if security_service.get(\u0027server\u0027, None):"},{"line_number":2006,"context_line":"            api_args \u003d {\u0027mode\u0027: \u0027none\u0027}"},{"line_number":2007,"context_line":"        elif security_service.get(\u0027defaultadsite\u0027, None):"},{"line_number":2008,"context_line":"            api_args \u003d {\u0027mode\u0027: \u0027site\u0027}"},{"line_number":2009,"context_line":"        else:"},{"line_number":2010,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":7,"id":"547abfcd_277afe95","line":2007,"range":{"start_line":2007,"start_character":51,"end_line":2007,"end_character":55},"updated":"2022-11-24 02:15:52.000000000","message":"Not required, since None is the default.","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4a4531c2df2c80dafd19f56d043db8b9b342278a","unresolved":false,"context_lines":[{"line_number":2004,"context_line":"    def configure_cifs_options(self, security_service):"},{"line_number":2005,"context_line":"        if security_service.get(\u0027server\u0027, None):"},{"line_number":2006,"context_line":"            api_args \u003d {\u0027mode\u0027: \u0027none\u0027}"},{"line_number":2007,"context_line":"        elif security_service.get(\u0027defaultadsite\u0027, None):"},{"line_number":2008,"context_line":"            api_args \u003d {\u0027mode\u0027: \u0027site\u0027}"},{"line_number":2009,"context_line":"        else:"},{"line_number":2010,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fc7cb7d_ddc0bddf","line":2007,"range":{"start_line":2007,"start_character":51,"end_line":2007,"end_character":55},"in_reply_to":"547abfcd_277afe95","updated":"2022-11-28 15:40:27.000000000","message":"Done","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d5f967d55dee9df94f677b9563a0947c6df15c95","unresolved":true,"context_lines":[{"line_number":1761,"context_line":"        if \u0027default_ad_site\u0027 in differring_keys:"},{"line_number":1762,"context_line":"            if new_security_service[\u0027default_ad_site\u0027] is not None:"},{"line_number":1763,"context_line":"                cifs_server \u003d self._get_cifs_server_name(vserver_name)"},{"line_number":1764,"context_line":"                api_args \u003d {"},{"line_number":1765,"context_line":"                    \u0027admin-username\u0027: new_security_service[\u0027user\u0027],"},{"line_number":1766,"context_line":"                    \u0027admin-password\u0027: new_security_service[\u0027password\u0027],"},{"line_number":1767,"context_line":"                    \u0027force-account-overwrite\u0027: \u0027true\u0027,"},{"line_number":1768,"context_line":"                    \u0027cifs-server\u0027: cifs_server,"},{"line_number":1769,"context_line":"                    \u0027default-site\u0027: new_security_service[\u0027default_ad_site\u0027]"},{"line_number":1770,"context_line":"                }"},{"line_number":1771,"context_line":"                try:"},{"line_number":1772,"context_line":"                    LOG.debug(\"Trying to modify CIFS server with data: %s\","}],"source_content_type":"text/x-python","patch_set":13,"id":"ba37caef_bd51e13a","line":1769,"range":{"start_line":1764,"start_character":20,"end_line":1769,"end_character":75},"updated":"2023-02-14 22:59:20.000000000","message":"do we actually need to send all of this info?\ni was checking some examples in the netapp documentation and saw something:\nhttps://docs.netapp.com/us-en/ontap-cli-95/vserver-cifs-modify.html#examples\nThe first example shows the default site being modified and only it - no other parameters being set other than this.\nIt\u0027s okay if there\u0027s a specific reason if you have found some specific behavior :)","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b86b90dbdb028776c7a1a488d88f0524fbe1b5ad","unresolved":false,"context_lines":[{"line_number":1761,"context_line":"        if \u0027default_ad_site\u0027 in differring_keys:"},{"line_number":1762,"context_line":"            if new_security_service[\u0027default_ad_site\u0027] is not None:"},{"line_number":1763,"context_line":"                cifs_server \u003d self._get_cifs_server_name(vserver_name)"},{"line_number":1764,"context_line":"                api_args \u003d {"},{"line_number":1765,"context_line":"                    \u0027admin-username\u0027: new_security_service[\u0027user\u0027],"},{"line_number":1766,"context_line":"                    \u0027admin-password\u0027: new_security_service[\u0027password\u0027],"},{"line_number":1767,"context_line":"                    \u0027force-account-overwrite\u0027: \u0027true\u0027,"},{"line_number":1768,"context_line":"                    \u0027cifs-server\u0027: cifs_server,"},{"line_number":1769,"context_line":"                    \u0027default-site\u0027: new_security_service[\u0027default_ad_site\u0027]"},{"line_number":1770,"context_line":"                }"},{"line_number":1771,"context_line":"                try:"},{"line_number":1772,"context_line":"                    LOG.debug(\"Trying to modify CIFS server with data: %s\","}],"source_content_type":"text/x-python","patch_set":13,"id":"5f4b7c1f_209dd679","line":1769,"range":{"start_line":1764,"start_character":20,"end_line":1769,"end_character":75},"in_reply_to":"ba37caef_bd51e13a","updated":"2023-02-15 16:10:27.000000000","message":"yes, we need all parameters in info","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a55ce01085c7d775003d17668a58ba2d6b025d90","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"6ee09889_fa37cb8c","updated":"2023-02-16 07:15:42.000000000","message":"I agree with Carlos; please factor out the NetApp driver change into a separate change. It makes sense to include driver changes into a core change only when there are changes pertaining to all drivers;","commit_id":"26227bd88beff3e8f94d58992169e13aec59f4ef"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d5f967d55dee9df94f677b9563a0947c6df15c95","unresolved":true,"context_lines":[{"line_number":2044,"context_line":"        if ss_type \u003d\u003d \u0027active_directory\u0027:"},{"line_number":2045,"context_line":"            server \u003d security_service.get(\u0027server\u0027)"},{"line_number":2046,"context_line":"            default_ad_site \u003d security_service.get(\u0027default_ad_site\u0027)"},{"line_number":2047,"context_line":"            if server and default_ad_site:"},{"line_number":2048,"context_line":"                msg \u003d _(\"Active directory security service must not have \""},{"line_number":2049,"context_line":"                        \"both \u0027server\u0027 and \u0027default_ad_site\u0027 parameters.\")"},{"line_number":2050,"context_line":"                LOG.error(msg)"},{"line_number":2051,"context_line":"                return False"},{"line_number":2052,"context_line":""},{"line_number":2053,"context_line":"        if not all([security_service[key] is not None"}],"source_content_type":"text/x-python","patch_set":13,"id":"de20be4a_d509b8a2","line":2050,"range":{"start_line":2047,"start_character":12,"end_line":2050,"end_character":30},"updated":"2023-02-14 22:59:20.000000000","message":"this could be validated earlier in the API, right?\nOr is this a NetApp driver specific detail? For create we already prevent this to happen. If it is netapp specific, the api should not be validating it. If we expect every AD security service to don\u0027t have both server and default ad site set, we should validate not only the create, but the update in the API.","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"96fbe136878e405a1e4f14486acee65a151e8315","unresolved":false,"context_lines":[{"line_number":2044,"context_line":"        if ss_type \u003d\u003d \u0027active_directory\u0027:"},{"line_number":2045,"context_line":"            server \u003d security_service.get(\u0027server\u0027)"},{"line_number":2046,"context_line":"            default_ad_site \u003d security_service.get(\u0027default_ad_site\u0027)"},{"line_number":2047,"context_line":"            if server and default_ad_site:"},{"line_number":2048,"context_line":"                msg \u003d _(\"Active directory security service must not have \""},{"line_number":2049,"context_line":"                        \"both \u0027server\u0027 and \u0027default_ad_site\u0027 parameters.\")"},{"line_number":2050,"context_line":"                LOG.error(msg)"},{"line_number":2051,"context_line":"                return False"},{"line_number":2052,"context_line":""},{"line_number":2053,"context_line":"        if not all([security_service[key] is not None"}],"source_content_type":"text/x-python","patch_set":13,"id":"59b9ed73_7f469086","line":2050,"range":{"start_line":2047,"start_character":12,"end_line":2050,"end_character":30},"in_reply_to":"494d3199_473988b5","updated":"2023-02-16 01:11:46.000000000","message":"Ack","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b86b90dbdb028776c7a1a488d88f0524fbe1b5ad","unresolved":true,"context_lines":[{"line_number":2044,"context_line":"        if ss_type \u003d\u003d \u0027active_directory\u0027:"},{"line_number":2045,"context_line":"            server \u003d security_service.get(\u0027server\u0027)"},{"line_number":2046,"context_line":"            default_ad_site \u003d security_service.get(\u0027default_ad_site\u0027)"},{"line_number":2047,"context_line":"            if server and default_ad_site:"},{"line_number":2048,"context_line":"                msg \u003d _(\"Active directory security service must not have \""},{"line_number":2049,"context_line":"                        \"both \u0027server\u0027 and \u0027default_ad_site\u0027 parameters.\")"},{"line_number":2050,"context_line":"                LOG.error(msg)"},{"line_number":2051,"context_line":"                return False"},{"line_number":2052,"context_line":""},{"line_number":2053,"context_line":"        if not all([security_service[key] is not None"}],"source_content_type":"text/x-python","patch_set":13,"id":"494d3199_473988b5","line":2050,"range":{"start_line":2047,"start_character":12,"end_line":2050,"end_character":30},"in_reply_to":"de20be4a_d509b8a2","updated":"2023-02-15 16:10:27.000000000","message":"This is from update of SS attached to share network, ideally all SS are validated at API, but this is additional check during update within share network attached SS. The restriction is limited to AD only.","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"}],"manila/share/manager.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"54bbbdf8c3ca11a59695074d7c4345b5be5e2f8c","unresolved":true,"context_lines":[{"line_number":4195,"context_line":"            # share network separately without dependency on each other."},{"line_number":4196,"context_line":"            for security_service in network_info_list[0][\u0027security_services\u0027]:"},{"line_number":4197,"context_line":"                ss_type \u003d security_service[\u0027type\u0027]"},{"line_number":4198,"context_line":"                data \u003d {"},{"line_number":4199,"context_line":"                    \u0027name\u0027: security_service[\u0027name\u0027],"},{"line_number":4200,"context_line":"                    \u0027ou\u0027: security_service[\u0027ou\u0027],"},{"line_number":4201,"context_line":"                    \u0027domain\u0027: security_service[\u0027domain\u0027],"},{"line_number":4202,"context_line":"                    \u0027server\u0027: security_service[\u0027server\u0027],"},{"line_number":4203,"context_line":"                    \u0027dns_ip\u0027: security_service[\u0027dns_ip\u0027],"},{"line_number":4204,"context_line":"                    \u0027user\u0027: security_service[\u0027user\u0027],"},{"line_number":4205,"context_line":"                    \u0027type\u0027: ss_type,"},{"line_number":4206,"context_line":"                    \u0027password\u0027: security_service[\u0027password\u0027],"},{"line_number":4207,"context_line":"                }"},{"line_number":4208,"context_line":"                self.db.share_server_backend_details_set("},{"line_number":4209,"context_line":"                    context, share_server[\u0027id\u0027],"},{"line_number":4210,"context_line":"                    {\u0027security_service_\u0027 + ss_type: jsonutils.dumps(data)})"}],"source_content_type":"text/x-python","patch_set":7,"id":"e71b54a7_fb8ddfcf","line":4207,"range":{"start_line":4198,"start_character":16,"end_line":4207,"end_character":17},"updated":"2022-11-24 02:15:52.000000000","message":"why are you not adding the new field here ?","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4a4531c2df2c80dafd19f56d043db8b9b342278a","unresolved":false,"context_lines":[{"line_number":4195,"context_line":"            # share network separately without dependency on each other."},{"line_number":4196,"context_line":"            for security_service in network_info_list[0][\u0027security_services\u0027]:"},{"line_number":4197,"context_line":"                ss_type \u003d security_service[\u0027type\u0027]"},{"line_number":4198,"context_line":"                data \u003d {"},{"line_number":4199,"context_line":"                    \u0027name\u0027: security_service[\u0027name\u0027],"},{"line_number":4200,"context_line":"                    \u0027ou\u0027: security_service[\u0027ou\u0027],"},{"line_number":4201,"context_line":"                    \u0027domain\u0027: security_service[\u0027domain\u0027],"},{"line_number":4202,"context_line":"                    \u0027server\u0027: security_service[\u0027server\u0027],"},{"line_number":4203,"context_line":"                    \u0027dns_ip\u0027: security_service[\u0027dns_ip\u0027],"},{"line_number":4204,"context_line":"                    \u0027user\u0027: security_service[\u0027user\u0027],"},{"line_number":4205,"context_line":"                    \u0027type\u0027: ss_type,"},{"line_number":4206,"context_line":"                    \u0027password\u0027: security_service[\u0027password\u0027],"},{"line_number":4207,"context_line":"                }"},{"line_number":4208,"context_line":"                self.db.share_server_backend_details_set("},{"line_number":4209,"context_line":"                    context, share_server[\u0027id\u0027],"},{"line_number":4210,"context_line":"                    {\u0027security_service_\u0027 + ss_type: jsonutils.dumps(data)})"}],"source_content_type":"text/x-python","patch_set":7,"id":"334ad116_ec38a82e","line":4207,"range":{"start_line":4198,"start_character":16,"end_line":4207,"end_character":17},"in_reply_to":"e71b54a7_fb8ddfcf","updated":"2022-11-28 15:40:27.000000000","message":"Done","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"54bbbdf8c3ca11a59695074d7c4345b5be5e2f8c","unresolved":true,"context_lines":[{"line_number":5826,"context_line":"                context, share_network_id,"},{"line_number":5827,"context_line":"                {\u0027status\u0027: constants.STATUS_NETWORK_ACTIVE})"},{"line_number":5828,"context_line":""},{"line_number":5829,"context_line":"    def _update_share_network_security_service("},{"line_number":5830,"context_line":"            self, context, share_network_id, new_security_service_id,"},{"line_number":5831,"context_line":"            current_security_service_id\u003dNone, check_only\u003dFalse):"},{"line_number":5832,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"d5839614_8cda111d","line":5829,"range":{"start_line":5829,"start_character":8,"end_line":5829,"end_character":46},"updated":"2022-11-24 02:15:52.000000000","message":"Have you tested the update security service with NetApp defaultadsite ?\n\n1. Adding a new SS with defaultadsite\n2. Changing from server to defaultadsite mode\n3. Changing from defaultadsite to server mode\n\n\nI think NetApp driver layer requires some modifications regarding the fields. See [1]. Please, can you confirm that this feature keeps working with the new field update ?\n\n[1] https://github.com/openstack/manila/blob/master/manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py#L2017","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4a4531c2df2c80dafd19f56d043db8b9b342278a","unresolved":false,"context_lines":[{"line_number":5826,"context_line":"                context, share_network_id,"},{"line_number":5827,"context_line":"                {\u0027status\u0027: constants.STATUS_NETWORK_ACTIVE})"},{"line_number":5828,"context_line":""},{"line_number":5829,"context_line":"    def _update_share_network_security_service("},{"line_number":5830,"context_line":"            self, context, share_network_id, new_security_service_id,"},{"line_number":5831,"context_line":"            current_security_service_id\u003dNone, check_only\u003dFalse):"},{"line_number":5832,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"6cd6eda6_1cf47071","line":5829,"range":{"start_line":5829,"start_character":8,"end_line":5829,"end_character":46},"in_reply_to":"d5839614_8cda111d","updated":"2022-11-28 15:40:27.000000000","message":"Done","commit_id":"a65b330f8706e5a700e80a501bce08de2f9df0fd"}],"releasenotes/notes/add-defaultadsite-to-security-service-e90854c1a69be581.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d5f967d55dee9df94f677b9563a0947c6df15c95","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    From API version 2.75, added \u0027default_ad_site\u0027 field to \u0027security_service\u0027"},{"line_number":5,"context_line":"    object. This field can not be used along-with \u0027server\u0027 field of the"},{"line_number":6,"context_line":"    \u0027security_service\u0027. For Netapp ONTAP driver, the \u0027default_ad_site\u0027 will"},{"line_number":7,"context_line":"    restrict the Domain controller\u0027s discovery mode to \u0027site\u0027 i.e. only Domain"},{"line_number":8,"context_line":"    Controller\u0027s in local site will be discovered."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"8f9c6208_13ebc40b","line":8,"range":{"start_line":6,"start_character":24,"end_line":8,"end_character":50},"updated":"2023-02-14 22:59:20.000000000","message":"Please break it down into another item or peferrably a different release note file. Ideally core changes should not be accompanied by third party driver feature implementations. Core changes should be proposed in one patch, and another patch with the driver changes with a depends-on to the core should be proposed. Otherwise it looks a bit like a driver-specific thing :)\n\nthis is a small feature, I\u0027m okay if you prefer to keep the netapp changes here, but please split the release notes :)","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b86b90dbdb028776c7a1a488d88f0524fbe1b5ad","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    From API version 2.75, added \u0027default_ad_site\u0027 field to \u0027security_service\u0027"},{"line_number":5,"context_line":"    object. This field can not be used along-with \u0027server\u0027 field of the"},{"line_number":6,"context_line":"    \u0027security_service\u0027. For Netapp ONTAP driver, the \u0027default_ad_site\u0027 will"},{"line_number":7,"context_line":"    restrict the Domain controller\u0027s discovery mode to \u0027site\u0027 i.e. only Domain"},{"line_number":8,"context_line":"    Controller\u0027s in local site will be discovered."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"511cd5ab_ef2bcadc","line":8,"range":{"start_line":6,"start_character":24,"end_line":8,"end_character":50},"in_reply_to":"8f9c6208_13ebc40b","updated":"2023-02-15 16:10:27.000000000","message":"Done","commit_id":"b24b96c608f5fcb6608efa9a2da9a3f3536e584f"}]}