)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9cedd81c00375a27cae8095e3ba8f2698bad5816","unresolved":true,"context_lines":[{"line_number":10,"context_line":"context-based enginefacade. This one is a little tricky as it highlights"},{"line_number":11,"context_line":"two issues."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* The models in \u0027manila.db.sqlalchemy.models\u0027 do not match those created"},{"line_number":14,"context_line":"  by the migrations. This causes us issues since we apply the former"},{"line_number":15,"context_line":"  rather than running migrations when creating our database via the"},{"line_number":16,"context_line":"  DatabaseFixture, which means we\u0027re not actually testing against what"},{"line_number":17,"context_line":"  our customers see. One gap is closed here in order to get newly added"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"023449e8_cf881db3","line":14,"range":{"start_line":13,"start_character":2,"end_line":14,"end_character":21},"updated":"2023-01-06 00:22:14.000000000","message":"Are there multiple occurrences that you\u0027re aware of?\n\nI see a missing constraint that you\u0027re fixing up in this patch: https://opendev.org/openstack/manila/src/commit/27808af1181851620cd54e310958cfbc54e20073/manila/db/migrations/alembic/versions/1f0bd302c1a6_add_availability_zones_table.py#L66","commit_id":"83a7fdf010ff11de3791bfaefe581e81bc2cce03"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ba226ef8b500ca5baf8ff5a219be3d9e9374b3fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0051e0a1_70df207a","updated":"2022-12-20 17:47:51.000000000","message":"recheck gimme logs","commit_id":"727b84839617013589661d53243e4ab4eb003a72"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"604742b6ba51f990499b060b4e414ba9a224a1bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9068b1e6_2ea34f4b","updated":"2023-01-13 20:30:55.000000000","message":"LGTM, thanks for making the issues and the fixes to address very comprehensive on the commit message, Stephen!","commit_id":"83a7fdf010ff11de3791bfaefe581e81bc2cce03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9cedd81c00375a27cae8095e3ba8f2698bad5816","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"22dd8c1a_68397edc","updated":"2023-01-06 00:22:14.000000000","message":"LGTM; thanks - i like enginefacade for the simplicity it will bring in.. ","commit_id":"83a7fdf010ff11de3791bfaefe581e81bc2cce03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"17f263f4d2b434ce403ca609dfc0f390e6159e6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ef409b2d_7131f808","updated":"2023-01-17 01:20:12.000000000","message":"recheck\n\nThe failure doesn\u0027t seem related to the changes here, but, is strange.. we\u0027ll investigate","commit_id":"83a7fdf010ff11de3791bfaefe581e81bc2cce03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"612753cd27f1d836141f8a7ff7129bbf166207cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9c0c6257_3b999a9d","updated":"2023-01-18 22:38:42.000000000","message":"recheck\n\na bout of bad luck on the CI here; we haven\u0027t seen the db timeout in a while now.. ","commit_id":"83a7fdf010ff11de3791bfaefe581e81bc2cce03"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3dddd3326bbfc42471c07485e725e7851ec88c82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d8b68165_4c9014fc","updated":"2022-12-21 15:11:32.000000000","message":"🎉 Looks like everything is working now. The failures in the non-voting jobs seem unrelated.","commit_id":"83a7fdf010ff11de3791bfaefe581e81bc2cce03"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a63d0b479a2601df65c799878bba82fb68c849a0","unresolved":true,"context_lines":[{"line_number":5234,"context_line":"            with session.begin():"},{"line_number":5235,"context_line":"                az.save(session)"},{"line_number":5236,"context_line":"        else:"},{"line_number":5237,"context_line":"            az.save(context.session)"},{"line_number":5238,"context_line":"    # NOTE(u_glide): Do not catch specific exception here, because it depends"},{"line_number":5239,"context_line":"    # on concrete backend used by SqlAlchemy"},{"line_number":5240,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"33f51d07_c06569ce","line":5237,"updated":"2022-09-08 14:11:26.000000000","message":"This failing during service creation because the AZ already exists and we\u0027re not rolling back properly. Guess we\u0027re missing unit test coverage to say I didn\u0027t spot this locally 😞\n\nhttps://zuul.opendev.org/t/openstack/build/dcaa00b0d5a546ffa02126088a5d6866/log/controller/logs/screen-m-dat.txt#445","commit_id":"727b84839617013589661d53243e4ab4eb003a72"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a9035c90568a8a3c3f732cc74acea8da88a4a16e","unresolved":false,"context_lines":[{"line_number":5234,"context_line":"            with session.begin():"},{"line_number":5235,"context_line":"                az.save(session)"},{"line_number":5236,"context_line":"        else:"},{"line_number":5237,"context_line":"            az.save(context.session)"},{"line_number":5238,"context_line":"    # NOTE(u_glide): Do not catch specific exception here, because it depends"},{"line_number":5239,"context_line":"    # on concrete backend used by SqlAlchemy"},{"line_number":5240,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfa7e4f8_203cd394","line":5237,"in_reply_to":"33f51d07_c06569ce","updated":"2022-12-21 15:08:54.000000000","message":"This turned out to be easier to resolve than expected, though I got caught out by issues with the tests. See the revised commit message for more context.","commit_id":"727b84839617013589661d53243e4ab4eb003a72"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e3df185decdb00e900d67124c87182b1dd0eed99","unresolved":false,"context_lines":[{"line_number":525,"context_line":"@require_admin_context"},{"line_number":526,"context_line":"@context_manager.reader"},{"line_number":527,"context_line":"def service_get(context, service_id):"},{"line_number":528,"context_line":"    return _service_get(context, service_id)"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"@require_admin_context"}],"source_content_type":"text/x-python","patch_set":4,"id":"45dfbe9d_c0fe678c","line":528,"updated":"2023-01-13 21:56:21.000000000","message":"btw, the reason for this is because you can\u0027t have a function decorated with context manager call another decorated function. The decorator isn\u0027t clever enough (whether that\u0027s intentional or not I don\u0027t know) to realise we already have an existing session that should be re-used. You\u0027ll see this pattern throughout. The other pattern you\u0027ll see is private functions that optionally use a session argument. This allows us to call these from both migrated and (currently) non-migrated functions. Where this happens, I attempt to call them out with TODOs. Hope this helps! 🤓","commit_id":"83a7fdf010ff11de3791bfaefe581e81bc2cce03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"17f263f4d2b434ce403ca609dfc0f390e6159e6d","unresolved":false,"context_lines":[{"line_number":525,"context_line":"@require_admin_context"},{"line_number":526,"context_line":"@context_manager.reader"},{"line_number":527,"context_line":"def service_get(context, service_id):"},{"line_number":528,"context_line":"    return _service_get(context, service_id)"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"@require_admin_context"}],"source_content_type":"text/x-python","patch_set":4,"id":"035db99b_3260ba50","line":528,"in_reply_to":"45dfbe9d_c0fe678c","updated":"2023-01-17 01:20:12.000000000","message":"+1 got that pattern..","commit_id":"83a7fdf010ff11de3791bfaefe581e81bc2cce03"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9cedd81c00375a27cae8095e3ba8f2698bad5816","unresolved":true,"context_lines":[{"line_number":5328,"context_line":""},{"line_number":5329,"context_line":""},{"line_number":5330,"context_line":"def _ensure_availability_zone_exists("},{"line_number":5331,"context_line":"    context, values, session\u003dNone, *, strict\u003dTrue,"},{"line_number":5332,"context_line":"):"},{"line_number":5333,"context_line":"    az_name \u003d values.pop(\u0027availability_zone\u0027, None)"},{"line_number":5334,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"650a378e_c885084a","line":5331,"range":{"start_line":5331,"start_character":34,"end_line":5331,"end_character":37},"updated":"2023-01-06 00:22:14.000000000","message":"thanks for the safeguard; i\u0027m hoping the \"session\" kwarg and this can be dropped once we finish up the AZ methods..","commit_id":"83a7fdf010ff11de3791bfaefe581e81bc2cce03"}]}