)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9eecb7385ebbaaac4d23b29db91a9a10e94acc6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bdc4a825_4e988271","updated":"2023-01-09 18:10:03.000000000","message":"LGTM, thanks Stephen - a usage question inline... ","commit_id":"f4d9df5662f6adcfca62e5472ae8cae29c4fab65"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fcdde420572fb5b1261caa289adc957bb2b6d43c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a0b2775_d16ce202","updated":"2023-01-23 19:10:58.000000000","message":"LGTM, thanks Stephen! :)","commit_id":"f4d9df5662f6adcfca62e5472ae8cae29c4fab65"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9ebff162f68f8df812753bde3818390ea424c765","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"12002804_cbc02d5c","updated":"2023-01-24 09:42:18.000000000","message":"recheck base patch failure","commit_id":"f4d9df5662f6adcfca62e5472ae8cae29c4fab65"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2bf8e4e76355d08e2baa48e633aa3afd44fb8e0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d8a74f6e_27a87333","updated":"2023-01-30 22:37:26.000000000","message":"recheck\n\nsporadic failure; doesn\u0027t hurt to try ","commit_id":"bc2078b697c78db0ec2cc0952a2dd6310d11a039"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9eecb7385ebbaaac4d23b29db91a9a10e94acc6c","unresolved":true,"context_lines":[{"line_number":6353,"context_line":"        values[\u0027id\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":6354,"context_line":"    message_ref.update(values)"},{"line_number":6355,"context_line":""},{"line_number":6356,"context_line":"    context.session.add(message_ref)"},{"line_number":6357,"context_line":""},{"line_number":6358,"context_line":"    return _message_get(context, message_ref[\u0027id\u0027])"},{"line_number":6359,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8021097d_e48e26dd","line":6356,"range":{"start_line":6356,"start_character":4,"end_line":6356,"end_character":36},"updated":"2023-01-09 18:10:03.000000000","message":"is there any difference between doing this, vs:\n\n   message_ref.save(context.session) \n   \n   \nSince we\u0027re creating a single record, could we just use .save here for consistency?","commit_id":"f4d9df5662f6adcfca62e5472ae8cae29c4fab65"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"32090d5d73ad6daea50e6a7f1c8a127586328d05","unresolved":false,"context_lines":[{"line_number":6353,"context_line":"        values[\u0027id\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":6354,"context_line":"    message_ref.update(values)"},{"line_number":6355,"context_line":""},{"line_number":6356,"context_line":"    context.session.add(message_ref)"},{"line_number":6357,"context_line":""},{"line_number":6358,"context_line":"    return _message_get(context, message_ref[\u0027id\u0027])"},{"line_number":6359,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dcd77f0e_eb3ad735","line":6356,"range":{"start_line":6356,"start_character":4,"end_line":6356,"end_character":36},"in_reply_to":"144145b5_6152ce90","updated":"2023-01-11 21:07:01.000000000","message":"Thanks Stephen, agree with your take to not modify the behavior here - afaiu, we don\u0027t need to flush here since there\u0027s no need for sqlalchemy to give us any autogenerated data for the messages model. I\u0027m okay leaving the .save implementation elsewhere - i see the usage in nova/cinder etc as well;","commit_id":"f4d9df5662f6adcfca62e5472ae8cae29c4fab65"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1207bf51914e8f439e1a5af2f3ae4b7f054bfa88","unresolved":false,"context_lines":[{"line_number":6353,"context_line":"        values[\u0027id\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":6354,"context_line":"    message_ref.update(values)"},{"line_number":6355,"context_line":""},{"line_number":6356,"context_line":"    context.session.add(message_ref)"},{"line_number":6357,"context_line":""},{"line_number":6358,"context_line":"    return _message_get(context, message_ref[\u0027id\u0027])"},{"line_number":6359,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"144145b5_6152ce90","line":6356,"range":{"start_line":6356,"start_character":4,"end_line":6356,"end_character":36},"in_reply_to":"8021097d_e48e26dd","updated":"2023-01-10 12:28:45.000000000","message":"\u0027Model.save\u0027 isn\u0027t actually defined in SQLAlchemy - it\u0027s an oslo.db addition [1]. We could use it here but it\u0027s not an identical operation (it also results in a flush). I\u0027d rather not do any more functional changes that needed while migrating things over, but it\u0027d be a good follow-up perhaps if you\u0027d like?\n\nAlternatively, I can replace all calls to \u0027Model.save\u0027 with \u0027session.add\u0027 and \u0027session.flush\u0027 calls, so things look more like \"upstream\" SQLAlchemy. Whatever works for you guys...\n\n[1] https://github.com/openstack/oslo.db/blob/32b042e7069f90c61548d73e3460ab8e0f6990c7/oslo_db/sqlalchemy/models.py#L35-L38","commit_id":"f4d9df5662f6adcfca62e5472ae8cae29c4fab65"}]}