)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"09ff628a20a5f0fcd61deb8e898be9973ea644ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"abb3fbd6_44e64b2e","updated":"2022-12-21 15:15:35.000000000","message":"Failures are real. From [1]:\n\n\tDec 21 12:51:02.593260 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi [None req-46946860-a2f9-4d86-a472-903c9fb18988 tempest-ShareGroupsTest-1174037036 tempest-ShareGroupsTest-1174037036-project-admin] Exception handling resource: count_share_groups() got an unexpected keyword argument \u0027session\u0027: TypeError: count_share_groups() got an unexpected keyword argument \u0027session\u0027\n\tDec 21 12:51:02.593260 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi Traceback (most recent call last):\n\tDec 21 12:51:02.593260 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/opt/stack/manila/manila/api/openstack/wsgi.py\", line 829, in _process_stack\n\tDec 21 12:51:02.593260 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     action_result \u003d self.dispatch(meth, request, action_args)\n\tDec 21 12:51:02.593260 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/opt/stack/manila/manila/api/openstack/wsgi.py\", line 924, in dispatch\n\tDec 21 12:51:02.593260 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     return method(req\u003drequest, **action_args)\n\tDec 21 12:51:02.593260 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/opt/stack/manila/manila/api/openstack/wsgi.py\", line 1066, in version_select\n\tDec 21 12:51:02.593260 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     return func.func(self, *args, **kwargs)\n\tDec 21 12:51:02.593260 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/opt/stack/manila/manila/api/v2/share_groups.py\", line 291, in create\n\tDec 21 12:51:02.593260 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     return self._create(req, body)\n\tDec 21 12:51:02.593260 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/opt/stack/manila/manila/api/openstack/wsgi.py\", line 1160, in wrapper\n\tDec 21 12:51:02.593260 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     return f(self, req, *args, **kwargs)\n\tDec 21 12:51:02.593260 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/opt/stack/manila/manila/api/v2/share_groups.py\", line 278, in _create\n\tDec 21 12:51:02.593260 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     new_share_group \u003d self.share_group_api.create(context, **kwargs)\n\tDec 21 12:51:02.593260 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/opt/stack/manila/manila/share_group/api.py\", line 182, in create\n\tDec 21 12:51:02.593260 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     reservations \u003d QUOTAS.reserve(context, share_groups\u003d1)\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/opt/stack/manila/manila/quota.py\", line 1015, in reserve\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     reservations \u003d self._driver.reserve(\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/opt/stack/manila/manila/quota.py\", line 536, in reserve\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     return db.quota_reserve(\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/opt/stack/manila/manila/db/api.py\", line 256, in quota_reserve\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     return IMPL.quota_reserve(\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/opt/stack/manila/manila/db/sqlalchemy/api.py\", line 172, in wrapper\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     return f(*args, **kwargs)\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/opt/stack/manila/manila/db/sqlalchemy/api.py\", line 1112, in quota_reserve\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     user_reservations \u003d _quota_reserve(\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/usr/local/lib/python3.10/dist-packages/oslo_db/api.py\", line 144, in wrapper\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     with excutils.save_and_reraise_exception() as ectxt:\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/usr/local/lib/python3.10/dist-packages/oslo_utils/excutils.py\", line 227, in __exit__\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     self.force_reraise()\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/usr/local/lib/python3.10/dist-packages/oslo_utils/excutils.py\", line 200, in force_reraise\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     raise self.value\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/usr/local/lib/python3.10/dist-packages/oslo_db/api.py\", line 142, in wrapper\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     return f(*args, **kwargs)\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/opt/stack/manila/manila/db/sqlalchemy/api.py\", line 1204, in _quota_reserve\n\tDec 21 12:51:02.594561 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     updates \u003d sync(\n\tDec 21 12:51:02.596285 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/opt/stack/manila/manila/db/sqlalchemy/api.py\", line 431, in _sync_share_groups\n\tDec 21 12:51:02.596285 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     share_groups_count \u003d count_share_groups(\n\tDec 21 12:51:02.596285 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/opt/stack/manila/manila/db/sqlalchemy/api.py\", line 172, in wrapper\n\tDec 21 12:51:02.596285 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     return f(*args, **kwargs)\n\tDec 21 12:51:02.596285 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi   File \"/usr/local/lib/python3.10/dist-packages/oslo_db/sqlalchemy/enginefacade.py\", line 1018, in wrapper\n\tDec 21 12:51:02.596285 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi     return fn(*args, **kwargs)\n\tDec 21 12:51:02.596285 ubuntu-jammy-rax-dfw-0032551128 devstack@m-api.service[34322]: ERROR manila.api.openstack.wsgi TypeError: count_share_groups() got an unexpected keyword argument \u0027session\u0027\n\n[1] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_657/856467/2/check/manila-tempest-plugin-dummy-dhss/6571b59/controller/logs/screen-m-api.txt","commit_id":"2f930618111e32dbc06ead49245a153621ef5254"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0531ac2acdbb23f3d9ed633301164f8d2eb802cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db2f4cea_e082e67b","updated":"2023-01-23 19:49:50.000000000","message":"Hello, Stephen! Thank you for working on this change - Please take a look at the comment inline","commit_id":"c36ecdbfb29d53574931bcf4f2087e73325a08e9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c5d4bd6d74010248ee0fc3b48c5df4a7b85caa46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"19d15737_a8873f86","updated":"2023-04-15 00:38:32.000000000","message":"This is a long patch chain, lets get some things in and keep testing. Thanks Stephen!","commit_id":"15b4b39eb5ad6dbc77c430fb8c6500ef22f89bd1"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0531ac2acdbb23f3d9ed633301164f8d2eb802cf","unresolved":true,"context_lines":[{"line_number":442,"context_line":"    return {\u0027share_group_snapshots\u0027: share_group_snapshots_count}"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"def _sync_share_replicas(context, project_id, user_id, session,"},{"line_number":446,"context_line":"                         share_type_id\u003dNone):"},{"line_number":447,"context_line":"    share_replicas_count, _junk \u003d share_replica_data_get_for_project("},{"line_number":448,"context_line":"        context, project_id, user_id, share_type_id\u003dshare_type_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"79458f60_fe306154","line":445,"updated":"2023-01-23 19:49:50.000000000","message":"I think this and the function below would be fine if touched in the quotas change, but as we are having each change featuring specific resources, and this one is related to the entirety of the share groups resources, shouldn\u0027t we leave the share replica related functions to the share replicas change? I have also seen changes later in the file (i.e.) L5715","commit_id":"c36ecdbfb29d53574931bcf4f2087e73325a08e9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"039ab34e6b8cdb55d46b98143803122a2941e965","unresolved":false,"context_lines":[{"line_number":442,"context_line":"    return {\u0027share_group_snapshots\u0027: share_group_snapshots_count}"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"def _sync_share_replicas(context, project_id, user_id, session,"},{"line_number":446,"context_line":"                         share_type_id\u003dNone):"},{"line_number":447,"context_line":"    share_replicas_count, _junk \u003d share_replica_data_get_for_project("},{"line_number":448,"context_line":"        context, project_id, user_id, share_type_id\u003dshare_type_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7e87b661_38a1e1bb","line":445,"in_reply_to":"79458f60_fe306154","updated":"2023-04-14 15:47:45.000000000","message":"Sorry, I missed this comment. You\u0027re right: these shouldn\u0027t have been done here but rather in a later share replicas change (like the one I currently have in WIP [1]). All of these should be done in a separate quota-related change. I guess I missed this because the count functions were grouped together with the share group resources. I\u0027ll update the series now.\n\n[1] https://review.opendev.org/c/openstack/manila/+/880202/","commit_id":"c36ecdbfb29d53574931bcf4f2087e73325a08e9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b78aaa99b79da312d6e141ab5bddeed30d09b4bd","unresolved":false,"context_lines":[{"line_number":442,"context_line":"    return {\u0027share_group_snapshots\u0027: share_group_snapshots_count}"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"def _sync_share_replicas(context, project_id, user_id, session,"},{"line_number":446,"context_line":"                         share_type_id\u003dNone):"},{"line_number":447,"context_line":"    share_replicas_count, _junk \u003d share_replica_data_get_for_project("},{"line_number":448,"context_line":"        context, project_id, user_id, share_type_id\u003dshare_type_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f92c071c_37f1a215","line":445,"in_reply_to":"7e87b661_38a1e1bb","updated":"2023-04-14 16:04:09.000000000","message":"Done","commit_id":"c36ecdbfb29d53574931bcf4f2087e73325a08e9"}]}