)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"060a3e1ae811feba9bba7289e096817aba58a2fb","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch is removing the code that renames the snapshot during"},{"line_number":14,"context_line":"management, so the snapshot name is kept as informed, saving it"},{"line_number":15,"context_line":"to the provider location field."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-bug: #1936648"},{"line_number":18,"context_line":"Change-Id: Ib1a928d453de80d6841524cdb86c4708a5b0dbdf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"124ffff6_3523761e","line":15,"updated":"2022-09-15 18:38:30.000000000","message":"How does the new fixed version work when an admin takes an external snapshot, renames it, manages it, and then reverts to the snapshot? don\u0027t we unexpectedly lose reference to the snapshot there too? i wonder if you can add some logic to the \"revert-to-snapshot\" method to reconcile the snapshot?","commit_id":"1dc445945670ac510c845f248f7b58ff96c25021"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8746c49135f7443f8d75323c67b8b7b03ebf1410","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch is removing the code that renames the snapshot during"},{"line_number":14,"context_line":"management, so the snapshot name is kept as informed, saving it"},{"line_number":15,"context_line":"to the provider location field."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-bug: #1936648"},{"line_number":18,"context_line":"Change-Id: Ib1a928d453de80d6841524cdb86c4708a5b0dbdf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6fd383a9_478e8c6a","line":15,"in_reply_to":"124ffff6_3523761e","updated":"2022-09-15 19:41:38.000000000","message":"You are right. The issue will still happen if the renames occurred externally to Manila. Actually, the bug can be even worse. All snapshots are returned back to the name when reverting, not only the one that reverted. Example:\n\n\n1. Take snap1\n2. Take snap2\n3. Rename snap1 -\u003e my_snap1\n4. Rename snap2 -\u003e my_snap2\n5. Manage my_snap1\n6. Manage my_snap2\n7. Revert to my_snap2\n\nAs result, the provider location of both snaps will be as \"my_snap1\" and \"my_snap2\", but the actual name is \"snap1\" and \"snap2\".\n\nThe revert process can change the name of several snapshots, not only the one that is was used to revert.\n\nanother point, how can manila know the original name  to rename back ? In the example, how could the manila know the original snap name (\"snap1\" and \"snap2\") ?","commit_id":"1dc445945670ac510c845f248f7b58ff96c25021"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04e1a36d8543062e807205d10fc3e39437ccc029","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch is removing the code that renames the snapshot during"},{"line_number":14,"context_line":"management, so the snapshot name is kept as informed, saving it"},{"line_number":15,"context_line":"to the provider location field."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-bug: #1936648"},{"line_number":18,"context_line":"Change-Id: Ib1a928d453de80d6841524cdb86c4708a5b0dbdf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"54117bb0_d2674541","line":15,"in_reply_to":"6fd383a9_478e8c6a","updated":"2023-02-15 00:33:06.000000000","message":"Hmmm, maybe its not worth optimizing this; but rather call this out as a known issue; we don\u0027t provide a way to rename the provider_location field on a snapshot if this happens though - so the general advice would be to be mindful of unnecessary reference name changes on the backend and consider that the manila driver uses the original name to locate snapshots..","commit_id":"1dc445945670ac510c845f248f7b58ff96c25021"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8746c49135f7443f8d75323c67b8b7b03ebf1410","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"232dbb85_e29f1112","updated":"2022-09-15 19:41:38.000000000","message":"Good catch Goutham, thank you! ","commit_id":"1dc445945670ac510c845f248f7b58ff96c25021"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7710e14ca8091086ac117b08db2b04fed069e255","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"befe458d_2ab53785","updated":"2023-02-15 13:48:56.000000000","message":"LGTM, thanks Felipe!","commit_id":"1dc445945670ac510c845f248f7b58ff96c25021"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04e1a36d8543062e807205d10fc3e39437ccc029","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dd84bc87_c13ee5bd","updated":"2023-02-15 00:33:06.000000000","message":"Thanks! LGTM","commit_id":"1dc445945670ac510c845f248f7b58ff96c25021"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"66f4c2bc8fc6a1f62e551fcf36e721686d92160d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ec53dbd6_3558e968","updated":"2023-02-15 16:08:00.000000000","message":"recheck\nKnown issue with availability zones in the dummy-no-dhss job","commit_id":"1dc445945670ac510c845f248f7b58ff96c25021"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a56362f47fd55a3eec6892d6fea2a99ba6f4bee0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b893afde_2424c848","updated":"2023-01-25 13:23:25.000000000","message":"recheck\nLogs are gone - also, trying to get some attention to it again :)","commit_id":"1dc445945670ac510c845f248f7b58ff96c25021"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"be16976d959e2f24362a086b401209f537a309b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cd82dfb6_f6291f29","updated":"2023-01-30 15:55:31.000000000","message":"recheck - Errors in DBConnection and unexpected timeouts","commit_id":"1dc445945670ac510c845f248f7b58ff96c25021"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"f47d08f414ef3b78a5452314f418b5d64c740053","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"36582567_4e14e456","updated":"2023-02-10 12:22:48.000000000","message":"recheck - Unexpected connection error in manila-tempest-plugin-lvm tests.","commit_id":"1dc445945670ac510c845f248f7b58ff96c25021"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"595ff2251e81900e774edc99d8520c0c9b224606","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0445dc1e_d1615e22","updated":"2022-09-15 18:38:45.000000000","message":"run-NetApp CI","commit_id":"1dc445945670ac510c845f248f7b58ff96c25021"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"f83421344f0b4bb05fef2764ef445519ea900233","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3eb4c277_2d5ecd03","updated":"2023-02-13 12:08:25.000000000","message":"run-NetApp CI","commit_id":"1dc445945670ac510c845f248f7b58ff96c25021"}],"releasenotes/notes/fix-netapp-manage-snapshot-f6ed571bd4f9a2ac.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9e31b965da338a825a0927d57b71b32e75745a15","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp driver: fix some issues caused with managed snapshot, it is no more"},{"line_number":5,"context_line":"    renaming the managed snapshot. For more details, please refer to"},{"line_number":6,"context_line":"    `launchpad bug #1936648 \u003chttps://bugs.launchpad.net/manila/+bug/1936648\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d98436ff_ee9b762c","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":34},"updated":"2022-09-15 21:57:40.000000000","message":"maybe call this out in the driver documentation? could be netapp.io or if we reference the name change in the upstream docs, add a note there too","commit_id":"1dc445945670ac510c845f248f7b58ff96c25021"}]}