)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b72a3a40dbb3b3743d696032a498d52e47c97186","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c1233660_937d1d3b","updated":"2023-01-25 13:38:37.000000000","message":"recheck\nLogs are gone","commit_id":"f63ea0f2e2b5d91dc4f3f0fcbc6b635370cf2514"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0ed77fb8aa1f52cbfff51e57182511d6afd59e89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"56cd8142_aef6607d","updated":"2023-01-28 03:17:45.000000000","message":"update gets an ID in many resources; we\u0027ll need to retrieve this from the DB before checking policy via the resource","commit_id":"f63ea0f2e2b5d91dc4f3f0fcbc6b635370cf2514"},{"author":{"_account_id":35586,"name":"Renan Vitor","email":"renanv@netapp.com","username":"renan_vitor"},"change_message_id":"a7fbb3363a8482978e7eb9aa2d0350b76ed88d81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d9443d68_ef9a2150","updated":"2023-03-01 13:48:47.000000000","message":"Thanks for the patch, looks good to me","commit_id":"7463e6a7489000975c6d12cfe70539c4fecaa12a"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"b335d9aa632a07a6cb3846b434e54a408cef375f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1b6299a6_0f59d397","updated":"2023-09-21 11:50:48.000000000","message":"LGTM","commit_id":"aa121bc1e1b1f48b28425da42cca12dcce0434c9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e6aae367fb1b44662839f8b193549baef4fd3f12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d36d37e4_c974cf74","updated":"2023-08-17 13:33:51.000000000","message":"LGTM, thanks for the fix, Goutham","commit_id":"aa121bc1e1b1f48b28425da42cca12dcce0434c9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"119fbaf06c30016535fddf79b672e74d22f9ea22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0b5b9652_9f47d1bc","updated":"2023-09-21 13:03:32.000000000","message":"LGTM, thanks goutham","commit_id":"aa121bc1e1b1f48b28425da42cca12dcce0434c9"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"43426ac9e858769ab9fb45ad6a213c3dfff28905","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"06ac3273_658340ba","updated":"2023-09-20 06:40:40.000000000","message":"LGTM. thanks.","commit_id":"aa121bc1e1b1f48b28425da42cca12dcce0434c9"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"17af32f77d9850ef6259b22f01d282b243c6eeac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1c8ff745_25229e6b","updated":"2023-09-20 13:33:27.000000000","message":"Thanks for this patch, Goutham. Just a question inline so I understand better, the rest LGTM.","commit_id":"aa121bc1e1b1f48b28425da42cca12dcce0434c9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"88d98f80bf228a8f64c13c07108e38f60fd70d9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8335423b_1a19e788","updated":"2023-08-17 13:34:03.000000000","message":"recheck\nlogs are gone","commit_id":"aa121bc1e1b1f48b28425da42cca12dcce0434c9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1c91172e17fe441cc360575388869fe1bea9bdfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b0fe4384_0516471f","updated":"2023-09-19 15:03:59.000000000","message":"recheck\nlogs are gone","commit_id":"aa121bc1e1b1f48b28425da42cca12dcce0434c9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c6203db6a693cfd2ab33926b5e30a9149865d9a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c720cb5c_3c1414d5","updated":"2023-09-28 12:51:25.000000000","message":"LGTM - thanks for the update, Goutham","commit_id":"55edb00cc12ade9df333e9c0a3472e68d797b8f6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"176e476b92ccd04b8622a0d071c2e5f365b95c29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4653f33f_d34571b5","updated":"2023-09-28 20:16:24.000000000","message":"Minor update since last iteration - let\u0027s get this merged","commit_id":"55edb00cc12ade9df333e9c0a3472e68d797b8f6"}],"manila/api/openstack/wsgi.py":[{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"17af32f77d9850ef6259b22f01d282b243c6eeac","unresolved":false,"context_lines":[{"line_number":1267,"context_line":"                                target_obj\u003dresource)"},{"line_number":1268,"context_line":"        except exception.NotAuthorized as e:"},{"line_number":1269,"context_line":"            raise webob.exc.HTTPForbidden(e.message)"},{"line_number":1270,"context_line":"        self._update(context, id, update)"},{"line_number":1271,"context_line":"        return webob.Response(status_int\u003dhttp_client.ACCEPTED)"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"    @Controller.authorize(\u0027force_delete\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"4a3facdc_7d388011","line":1270,"range":{"start_line":1270,"start_character":8,"end_line":1270,"end_character":20},"updated":"2023-09-20 13:33:27.000000000","message":"nit: Is there a reason to remove this call from try block? It\u0027s not necessary anymore?","commit_id":"aa121bc1e1b1f48b28425da42cca12dcce0434c9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8515d18a3cb4871749a372c54231e16cccb5e7f","unresolved":false,"context_lines":[{"line_number":1267,"context_line":"                                target_obj\u003dresource)"},{"line_number":1268,"context_line":"        except exception.NotAuthorized as e:"},{"line_number":1269,"context_line":"            raise webob.exc.HTTPForbidden(e.message)"},{"line_number":1270,"context_line":"        self._update(context, id, update)"},{"line_number":1271,"context_line":"        return webob.Response(status_int\u003dhttp_client.ACCEPTED)"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"    @Controller.authorize(\u0027force_delete\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f40749ef_07e45bcf","line":1270,"range":{"start_line":1270,"start_character":8,"end_line":1270,"end_character":20},"in_reply_to":"4a3facdc_7d388011","updated":"2023-09-20 18:46:58.000000000","message":"yes; we\u0027re handling the NotFound exception above; and shouldn\u0027t occur when we get here.","commit_id":"aa121bc1e1b1f48b28425da42cca12dcce0434c9"}],"manila/api/v1/shares.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"20a32828905cd97bf3b4a3706d58a260e08576e0","unresolved":true,"context_lines":[{"line_number":43,"context_line":"class ShareMixin(object):"},{"line_number":44,"context_line":"    \"\"\"Mixin class for Share API Controllers.\"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _update(self, *args, **kwargs):"},{"line_number":47,"context_line":"        ctx, share \u003d (args[0], args[1])"},{"line_number":48,"context_line":"        authorized \u003d policy.check_policy("},{"line_number":49,"context_line":"            ctx, \u0027share\u0027, \u0027get\u0027, share, do_raise\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dba35407_cbf2af86","line":46,"range":{"start_line":46,"start_character":4,"end_line":46,"end_character":39},"updated":"2023-01-29 01:50:44.000000000","message":"how about:\n        ctx, share_id\u003d (args[0], args[1])\n        try:\n            self.share_api.get(context, share_id)\n        except exception.NotFound:\n            raise exc.HTTPNotFound()\n\n        authorized \u003d policy.check_policy(\n            ctx, \u0027share\u0027, \u0027get\u0027, share, do_raise\u003dFalse)\n        if not authorized:\n            raise exc.HTTPNotFound()","commit_id":"f63ea0f2e2b5d91dc4f3f0fcbc6b635370cf2514"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a58ceb201ede07adb9a770e13e19695374ef72cc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"class ShareMixin(object):"},{"line_number":44,"context_line":"    \"\"\"Mixin class for Share API Controllers.\"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _update(self, *args, **kwargs):"},{"line_number":47,"context_line":"        ctx, share \u003d (args[0], args[1])"},{"line_number":48,"context_line":"        authorized \u003d policy.check_policy("},{"line_number":49,"context_line":"            ctx, \u0027share\u0027, \u0027get\u0027, share, do_raise\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0aa9a60f_9f3373fa","line":46,"range":{"start_line":46,"start_character":4,"end_line":46,"end_character":39},"in_reply_to":"966c9595_b51f6f72","updated":"2023-09-21 00:40:35.000000000","message":"Done","commit_id":"f63ea0f2e2b5d91dc4f3f0fcbc6b635370cf2514"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ec0f568a49909d2ea2b2ffc0b1b0c92c9e5f6f37","unresolved":true,"context_lines":[{"line_number":43,"context_line":"class ShareMixin(object):"},{"line_number":44,"context_line":"    \"\"\"Mixin class for Share API Controllers.\"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _update(self, *args, **kwargs):"},{"line_number":47,"context_line":"        ctx, share \u003d (args[0], args[1])"},{"line_number":48,"context_line":"        authorized \u003d policy.check_policy("},{"line_number":49,"context_line":"            ctx, \u0027share\u0027, \u0027get\u0027, share, do_raise\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"966c9595_b51f6f72","line":46,"range":{"start_line":46,"start_character":4,"end_line":46,"end_character":39},"in_reply_to":"dba35407_cbf2af86","updated":"2023-02-02 01:01:43.000000000","message":"Thank you, attempted something very similar - needed some unit test and Manila exception to HTTP error conversions alongside it","commit_id":"f63ea0f2e2b5d91dc4f3f0fcbc6b635370cf2514"}],"manila/tests/api/v2/test_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d56658ff3ca96f54a9ce71b71c2db296e1f4929f","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"        # resource and we\u0027ll bleed into other tests, so we\u0027ll mock the"},{"line_number":1167,"context_line":"        # policy check to return False instead"},{"line_number":1168,"context_line":"        rbac_checks \u003d [None, None, exception.NotAuthorized]"},{"line_number":1169,"context_line":"        with mock.patch.object(policy, \u0027authorize\u0027, side_effect\u003drbac_checks):"},{"line_number":1170,"context_line":"            self.mock_object(share_api.API, \u0027get\u0027,"},{"line_number":1171,"context_line":"                             mock.Mock(return_value\u003dshare))"},{"line_number":1172,"context_line":"            self.assertRaises(webob.exc.HTTPForbidden,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a85eca4_3b415735","line":1169,"range":{"start_line":1169,"start_character":31,"end_line":1169,"end_character":52},"updated":"2023-09-26 00:00:32.000000000","message":"we started mocking \"check_policy\" in the init method; and this mock had to be adjusted to do the same..","commit_id":"aa121bc1e1b1f48b28425da42cca12dcce0434c9"}]}