)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"eb4639b0178ab0ccbf490317169f5835da90dd06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e0eab984_eaa09bce","updated":"2022-09-20 16:53:07.000000000","message":"run-NetApp CI","commit_id":"ab1033b45a6cda6851180d9d0d064348d19165d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d6f02926b88c019e0940b7c9c9b8a9f1c48ca1d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5820b556_1e8d98b0","updated":"2023-01-27 00:25:19.000000000","message":"\u003e Patch Set 4:\n\u003e \n\u003e Build succeeded.\n\u003e \n\u003e - manila-tempest-plugin-ontap-dhss https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/40/858140/4/upstream-check/manila-tempest-plugin-ontap-dhss/8db83a8/ : SUCCESS in 1h 33m 28s\n\u003e - manila-tempest-plugin-ontap-no-dhss https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/40/858140/4/upstream-check/manila-tempest-plugin-ontap-no-dhss/3341576/ : SUCCESS in 1h 41m 25s\n\u003e \n\u003e Comment \"run-NetApp CI\" to rerun these tests. https://wiki.openstack.org/wiki/ThirdPartySystems/NetApp_CI\n\nI see the DHSS\u003dTrue job isn\u0027t covering CIFS; and the DHSS\u003dFalse job has CIFS enabled, but i\u0027m not sure it\u0027s covering regression properly","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1cfafdf6a1eb159444f2e6211887b47213c9e650","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"592b3c5a_17cba368","updated":"2023-01-25 13:21:21.000000000","message":"Caique, I think the fix is in the right direction, so I\u0027m trying to get more attention to it.\nAre there logs from the NetApp CI for this change?","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"32d81bca2115d13d20b2d7f8853520aff418be06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"758d3ce4_d1e1d64f","updated":"2023-02-09 18:33:53.000000000","message":"Thank you Carlos and Goutham for the reviews.","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a821fa51b3de9964b4160a87db675c8a48f18b98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c5f749e6_c805fb12","updated":"2023-01-27 00:22:58.000000000","message":"Thanks Caique, I\u0027ve some questions regarding the code inline; ","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":33986,"name":"Lucas Morais de oliveira","email":"lucasmoliveira059@gmail.com","username":"lucasmoliveira059"},"change_message_id":"686cd3d29805e693c825d95e9a3d16bbb9170e25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5ff0042c_fcf105c9","updated":"2022-09-22 18:43:23.000000000","message":"recheck","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"6f9a5c584bbe864046c224ab5e98382449256f4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6afbb2a5_90d0638c","updated":"2022-09-27 12:01:07.000000000","message":"run-NetApp CI","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":34853,"name":"NetApp-CI","email":"ng-openstack-ci@netapp.com","username":"netapp-ontap-ci"},"change_message_id":"be2492ddfe25218a8c79da8ce24d78ead75ba9a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ebbb32cc_2657e4b2","updated":"2022-09-26 21:02:48.000000000","message":"run-NetApp CI","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"32d81bca2115d13d20b2d7f8853520aff418be06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"efde1610_ba784480","in_reply_to":"592b3c5a_17cba368","updated":"2023-02-09 18:33:53.000000000","message":"Hi Carlos, I don\u0027t know if I understood correctly, but the NetApp CI logs are commented above.","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"2aca7d7e8fe04e653ca038b86c21a92bf61930e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ddc023d9_7d41b209","updated":"2023-03-07 20:15:43.000000000","message":"run-NetApp CI","commit_id":"0e2699170d4c1fe683c01cfff1b7a99d561914b2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7cc41c6591bb2e1fc87a5f1f02703b4e34ed4d1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c53a8a5c_3b56d07d","updated":"2023-03-09 18:05:40.000000000","message":"run-NetApp CI\n\n\nThanks for the changes and the follow up comments. NetApp CI isn\u0027t running migration tests, have you tested this locally? ","commit_id":"0e2699170d4c1fe683c01cfff1b7a99d561914b2"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"e4f24f1dd6e8d3f74d44e02867aeecf01c5a835d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e9efcfb2_4e9eb6b3","in_reply_to":"c53a8a5c_3b56d07d","updated":"2023-03-13 13:30:17.000000000","message":"I\u0027ve tested it manually and Felipe is also going to review it and generate the logs.","commit_id":"0e2699170d4c1fe683c01cfff1b7a99d561914b2"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"e4f24f1dd6e8d3f74d44e02867aeecf01c5a835d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"384c163b_15f99a09","updated":"2023-03-13 13:30:17.000000000","message":"Thank you Goutham!","commit_id":"28fd46946e83e69b6d9ff589e20b794f2edd6ed8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8665ce9cddcaf103718a8f4c2c7829cc7d8e12d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"19eccf8e_2d70e68a","updated":"2023-04-10 17:41:25.000000000","message":"Caique: Is this appropriate for a backport to older releases? If yes, could you please propose this backport?","commit_id":"9ddddeeea3123c4af638e54c54a05deb3d59672a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"785e50114b1e0aeaee69fd7641513c811821d698","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9dbff723_c0dd2a3c","updated":"2023-04-10 15:57:39.000000000","message":"LGTM, thanks Caique","commit_id":"9ddddeeea3123c4af638e54c54a05deb3d59672a"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"dee21736482e2dd3ab1919d1c29d0e0dd4b11c83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"19e1a239_15528b88","updated":"2023-03-22 12:40:59.000000000","message":"LGTM. Thank you, Caique.","commit_id":"9ddddeeea3123c4af638e54c54a05deb3d59672a"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"4557498a397fa8b8f31725047bd868d613c300d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0ae0263c_6d94c427","updated":"2023-03-21 13:24:08.000000000","message":"Thank you for the reviews goutham, nahim and felipe.\n\nI\u0027ve done some manual tests, here is the logs:\nhttps://paste.opendev.org/show/bW3x4qqsehrdfw5SwAKU/\n","commit_id":"9ddddeeea3123c4af638e54c54a05deb3d59672a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8ad046ffdaa3f1fdfb50071b2a31a8b5c31f7cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"91055fcf_cfa17ea7","updated":"2023-03-22 23:08:18.000000000","message":"run-NetApp CI\n\nthanks Caique","commit_id":"9ddddeeea3123c4af638e54c54a05deb3d59672a"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"ba40c668b14fba3067ebe2212fa022ce63f50f2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e985d434_08c25e29","in_reply_to":"19eccf8e_2d70e68a","updated":"2023-04-11 13:13:33.000000000","message":"Hello Goutham!\nYes, we intend to backport until Xena release. I will work on it ASAP.","commit_id":"9ddddeeea3123c4af638e54c54a05deb3d59672a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3562e5e30576e5d337f12acbf96a425201683d1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c129d063_7499eeaf","in_reply_to":"e985d434_08c25e29","updated":"2023-04-11 20:16:07.000000000","message":"Great; Thank you Caique. I\u0027d be interested in a Wallaby backport as well (for RHEL OSP consumers) in case it\u0027s relevant..","commit_id":"9ddddeeea3123c4af638e54c54a05deb3d59672a"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a821fa51b3de9964b4160a87db675c8a48f18b98","unresolved":true,"context_lines":[{"line_number":1648,"context_line":""},{"line_number":1649,"context_line":"        # Create the share and get a callback for generating export locations"},{"line_number":1650,"context_line":"        pool \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":1651,"context_line":"        callback \u003d helper.create_share("},{"line_number":1652,"context_line":"            share, share_name,"},{"line_number":1653,"context_line":"            clear_current_export_policy\u003dclear_current_export_policy,"},{"line_number":1654,"context_line":"            ensure_share_already_exists\u003densure_share_already_exists,"},{"line_number":1655,"context_line":"            replica\u003dreplica,"},{"line_number":1656,"context_line":"            is_flexgroup\u003dself._is_flexgroup_pool(pool))"},{"line_number":1657,"context_line":""},{"line_number":1658,"context_line":"        # Generate export locations using addresses, metadata and callback"},{"line_number":1659,"context_line":"        export_locations \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"f15c3c64_39a54d06","line":1656,"range":{"start_line":1651,"start_character":0,"end_line":1656,"end_character":55},"updated":"2023-01-27 00:22:58.000000000","message":"maybe skip this callback if path is already known?","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"4557498a397fa8b8f31725047bd868d613c300d0","unresolved":false,"context_lines":[{"line_number":1648,"context_line":""},{"line_number":1649,"context_line":"        # Create the share and get a callback for generating export locations"},{"line_number":1650,"context_line":"        pool \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":1651,"context_line":"        callback \u003d helper.create_share("},{"line_number":1652,"context_line":"            share, share_name,"},{"line_number":1653,"context_line":"            clear_current_export_policy\u003dclear_current_export_policy,"},{"line_number":1654,"context_line":"            ensure_share_already_exists\u003densure_share_already_exists,"},{"line_number":1655,"context_line":"            replica\u003dreplica,"},{"line_number":1656,"context_line":"            is_flexgroup\u003dself._is_flexgroup_pool(pool))"},{"line_number":1657,"context_line":""},{"line_number":1658,"context_line":"        # Generate export locations using addresses, metadata and callback"},{"line_number":1659,"context_line":"        export_locations \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"ed0fb077_84f7fb40","line":1656,"range":{"start_line":1651,"start_character":0,"end_line":1656,"end_character":55},"in_reply_to":"164537c2_95b962af","updated":"2023-03-21 13:24:08.000000000","message":"Ack","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"f88e4ba0986b9b7f18fc61470f9a9a5cbaf9493c","unresolved":true,"context_lines":[{"line_number":1648,"context_line":""},{"line_number":1649,"context_line":"        # Create the share and get a callback for generating export locations"},{"line_number":1650,"context_line":"        pool \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":1651,"context_line":"        callback \u003d helper.create_share("},{"line_number":1652,"context_line":"            share, share_name,"},{"line_number":1653,"context_line":"            clear_current_export_policy\u003dclear_current_export_policy,"},{"line_number":1654,"context_line":"            ensure_share_already_exists\u003densure_share_already_exists,"},{"line_number":1655,"context_line":"            replica\u003dreplica,"},{"line_number":1656,"context_line":"            is_flexgroup\u003dself._is_flexgroup_pool(pool))"},{"line_number":1657,"context_line":""},{"line_number":1658,"context_line":"        # Generate export locations using addresses, metadata and callback"},{"line_number":1659,"context_line":"        export_locations \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"164537c2_95b962af","line":1656,"range":{"start_line":1651,"start_character":0,"end_line":1656,"end_character":55},"in_reply_to":"358a70c9_8b9362db","updated":"2023-03-07 20:15:27.000000000","message":"+1 Caique. Better to fix the problem in the bug scoped (migration function), instead of the utils function, avoiding adding a bug to another operation while fixing it.","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"a5d077e2c5e00459567bd808ee59d095fcb2fb93","unresolved":true,"context_lines":[{"line_number":1648,"context_line":""},{"line_number":1649,"context_line":"        # Create the share and get a callback for generating export locations"},{"line_number":1650,"context_line":"        pool \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":1651,"context_line":"        callback \u003d helper.create_share("},{"line_number":1652,"context_line":"            share, share_name,"},{"line_number":1653,"context_line":"            clear_current_export_policy\u003dclear_current_export_policy,"},{"line_number":1654,"context_line":"            ensure_share_already_exists\u003densure_share_already_exists,"},{"line_number":1655,"context_line":"            replica\u003dreplica,"},{"line_number":1656,"context_line":"            is_flexgroup\u003dself._is_flexgroup_pool(pool))"},{"line_number":1657,"context_line":""},{"line_number":1658,"context_line":"        # Generate export locations using addresses, metadata and callback"},{"line_number":1659,"context_line":"        export_locations \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"358a70c9_8b9362db","line":1656,"range":{"start_line":1651,"start_character":0,"end_line":1656,"end_character":55},"in_reply_to":"f15c3c64_39a54d06","updated":"2023-03-07 12:12:08.000000000","message":"I thought it best not to modify _create_export since it is used in many core functions for CIFS and NFS as well.\n\nWe add a condition to skip it only in migration complete for CIFS.","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a821fa51b3de9964b4160a87db675c8a48f18b98","unresolved":true,"context_lines":[{"line_number":3593,"context_line":"                destination_share, share_server, vserver, vserver_client,"},{"line_number":3594,"context_line":"                clear_current_export_policy\u003dFalse)"},{"line_number":3595,"context_line":"        else:"},{"line_number":3596,"context_line":"            export_locations \u003d source_share[\u0027export_locations\u0027][0][\u0027path\u0027]"},{"line_number":3597,"context_line":""},{"line_number":3598,"context_line":"        src_snaps_dict \u003d {s[\u0027id\u0027]: s for s in source_snapshots}"},{"line_number":3599,"context_line":"        snapshot_updates \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"ccc4cc6d_06b4fcb1","line":3596,"range":{"start_line":3596,"start_character":12,"end_line":3596,"end_character":74},"updated":"2023-01-27 00:22:58.000000000","message":"This doesn\u0027t make sense? You need to return all the export location information... export locations are formatted as a list of export location info dictionaries because you could possibly have multiple LIFs - one or more data LIFs and possibly an admin network LIF as well; \n\nThe way i read this currently is that a CIFS share would only retain one  export location, and lose the \"preferred\" export location tagging as well. \n\nIf you\u0027re resolving the problem with the CIFS callback such that you\u0027re setting the path correctly, why not just allow the _create_export method to be called for CIFS as well? See comment in the method above","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"32d81bca2115d13d20b2d7f8853520aff418be06","unresolved":true,"context_lines":[{"line_number":3593,"context_line":"                destination_share, share_server, vserver, vserver_client,"},{"line_number":3594,"context_line":"                clear_current_export_policy\u003dFalse)"},{"line_number":3595,"context_line":"        else:"},{"line_number":3596,"context_line":"            export_locations \u003d source_share[\u0027export_locations\u0027][0][\u0027path\u0027]"},{"line_number":3597,"context_line":""},{"line_number":3598,"context_line":"        src_snaps_dict \u003d {s[\u0027id\u0027]: s for s in source_snapshots}"},{"line_number":3599,"context_line":"        snapshot_updates \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"f87ea870_be562ece","line":3596,"range":{"start_line":3596,"start_character":12,"end_line":3596,"end_character":74},"in_reply_to":"ccc4cc6d_06b4fcb1","updated":"2023-02-09 18:33:53.000000000","message":"Good point Goutham. I should be passing all exports, instead of the first one at position 0. However, it would not be the case to call \"create_export\" for CIFS because we don\u0027t want to rename the CIFS share, because, unlike NFS, if we rename the CIFS share the user is disconnected killing the feature of being non-disruptive. That is, for CIFS the export locations stay the same.","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"a5d077e2c5e00459567bd808ee59d095fcb2fb93","unresolved":false,"context_lines":[{"line_number":3593,"context_line":"                destination_share, share_server, vserver, vserver_client,"},{"line_number":3594,"context_line":"                clear_current_export_policy\u003dFalse)"},{"line_number":3595,"context_line":"        else:"},{"line_number":3596,"context_line":"            export_locations \u003d source_share[\u0027export_locations\u0027][0][\u0027path\u0027]"},{"line_number":3597,"context_line":""},{"line_number":3598,"context_line":"        src_snaps_dict \u003d {s[\u0027id\u0027]: s for s in source_snapshots}"},{"line_number":3599,"context_line":"        snapshot_updates \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"d58b42b1_9166c497","line":3596,"range":{"start_line":3596,"start_character":12,"end_line":3596,"end_character":74},"in_reply_to":"f87ea870_be562ece","updated":"2023-03-07 12:12:08.000000000","message":"Done","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"}],"manila/share/drivers/netapp/dataontap/protocols/cifs_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a821fa51b3de9964b4160a87db675c8a48f18b98","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        cifs_exist \u003d self._client.cifs_share_exists(share_name)"},{"line_number":49,"context_line":"        export_path \u003d self._client.get_volume_junction_path(share_name)"},{"line_number":50,"context_line":"        if ensure_share_already_exists and not cifs_exist:"},{"line_number":51,"context_line":"            msg \u003d _(\"The expected CIFS share %(share_name)s was not found.\")"},{"line_number":52,"context_line":"            msg_args \u003d {\u0027share_name\u0027: share_name}"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4b02f9_21cafb93","line":49,"range":{"start_line":49,"start_character":35,"end_line":49,"end_character":59},"updated":"2023-01-27 00:22:58.000000000","message":"shouldn\u0027t you set \"is_cifs_style\u003dTrue\" here since you\u0027re looking for a CIFS share?\n\nAlso, if a share doesn\u0027t exist, doesn\u0027t this call raise an exception?","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"32d81bca2115d13d20b2d7f8853520aff418be06","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        cifs_exist \u003d self._client.cifs_share_exists(share_name)"},{"line_number":49,"context_line":"        export_path \u003d self._client.get_volume_junction_path(share_name)"},{"line_number":50,"context_line":"        if ensure_share_already_exists and not cifs_exist:"},{"line_number":51,"context_line":"            msg \u003d _(\"The expected CIFS share %(share_name)s was not found.\")"},{"line_number":52,"context_line":"            msg_args \u003d {\u0027share_name\u0027: share_name}"}],"source_content_type":"text/x-python","patch_set":4,"id":"4010986d_fb7c926a","line":49,"range":{"start_line":49,"start_character":35,"end_line":49,"end_character":59},"in_reply_to":"1a4b02f9_21cafb93","updated":"2023-02-09 18:33:53.000000000","message":"Regarding \"is_cifs_style\u003dTrue\" unfortunately, this parameter is deprecated and we don\u0027t want to keep it in the code because REST does not support it. Instead of it, we will parse the / in code side\n\nWe handle the existence of the share by checking whether the API return contains elements. If it does not, we set it as False. So for this case, we don\u0027t need to raise an exception.","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"cd58965ddf92f704246fe7529ee86dbfac47dd7a","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        cifs_exist \u003d self._client.cifs_share_exists(share_name)"},{"line_number":49,"context_line":"        export_path \u003d self._client.get_volume_junction_path(share_name)"},{"line_number":50,"context_line":"        if ensure_share_already_exists and not cifs_exist:"},{"line_number":51,"context_line":"            msg \u003d _(\"The expected CIFS share %(share_name)s was not found.\")"},{"line_number":52,"context_line":"            msg_args \u003d {\u0027share_name\u0027: share_name}"}],"source_content_type":"text/x-python","patch_set":4,"id":"f654d2f7_50a9b6b4","line":49,"range":{"start_line":49,"start_character":35,"end_line":49,"end_character":59},"in_reply_to":"4010986d_fb7c926a","updated":"2023-03-13 15:53:03.000000000","message":"About the exception handling, I think Goutham is right, and this call would throw an exception in case share does not exist. \n\nPlease, consider adding a condition to verify `if cifs_exist` before assigning the `export_path`. Note that lines 55 and 65 are affected by the value you set in the `export_path`.","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"dee21736482e2dd3ab1919d1c29d0e0dd4b11c83","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        cifs_exist \u003d self._client.cifs_share_exists(share_name)"},{"line_number":49,"context_line":"        export_path \u003d self._client.get_volume_junction_path(share_name)"},{"line_number":50,"context_line":"        if ensure_share_already_exists and not cifs_exist:"},{"line_number":51,"context_line":"            msg \u003d _(\"The expected CIFS share %(share_name)s was not found.\")"},{"line_number":52,"context_line":"            msg_args \u003d {\u0027share_name\u0027: share_name}"}],"source_content_type":"text/x-python","patch_set":4,"id":"2bfa17f7_2dd772f1","line":49,"range":{"start_line":49,"start_character":35,"end_line":49,"end_character":59},"in_reply_to":"d0767437_bf0828ac","updated":"2023-03-22 12:40:59.000000000","message":"Ok, makes sense to me. I can\u0027t think in a scenario like that, but I understand that you mean that you expect that the code should raise an exception in this case because this would be an unexpected behavior.","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"4557498a397fa8b8f31725047bd868d613c300d0","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        cifs_exist \u003d self._client.cifs_share_exists(share_name)"},{"line_number":49,"context_line":"        export_path \u003d self._client.get_volume_junction_path(share_name)"},{"line_number":50,"context_line":"        if ensure_share_already_exists and not cifs_exist:"},{"line_number":51,"context_line":"            msg \u003d _(\"The expected CIFS share %(share_name)s was not found.\")"},{"line_number":52,"context_line":"            msg_args \u003d {\u0027share_name\u0027: share_name}"}],"source_content_type":"text/x-python","patch_set":4,"id":"d0767437_bf0828ac","line":49,"range":{"start_line":49,"start_character":35,"end_line":49,"end_character":59},"in_reply_to":"f654d2f7_50a9b6b4","updated":"2023-03-21 13:24:08.000000000","message":"The NFS create_share is built from the ONTAP juntion path. And there is no handling in case there is no juntion path. That means CIFS can use the same approach without risk, because just like NFS, there is no scenario where the share is unmounted. Can you tell me in which scenario someone calls create_share without the volume being mounted on ONTAP?","commit_id":"2d0d542a45ede813d3027df01a83bf0ffb55e348"}],"releasenotes/notes/bug-1920937-fixed-cifs-share-migration-752fde9631fb077a.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7cc41c6591bb2e1fc87a5f1f02703b4e34ed4d1b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Fixed non-disruptive share migration of CIFS shares in the NetApp ONTAP"},{"line_number":5,"context_line":"    driver. During the CIFS share migration the creation of a new export path"},{"line_number":6,"context_line":"    is skipped and the actual export path is taken from the backend. For more"},{"line_number":7,"context_line":"    details, please refer to "},{"line_number":8,"context_line":"    \u0027launchpad bug #1920937 https://bugs.launchpad.net/manila/+bug/1920937\u0027_."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0a39b998_c01953d8","line":8,"range":{"start_line":7,"start_character":12,"end_line":8,"end_character":77},"updated":"2023-03-09 18:05:40.000000000","message":"incorrect link syntax, as well as a trailing white space that could be trimmed after \"refer to\".:\n\n\n    please refer to\n    \u0027launchpad bug #1920937 \u003chttps://bugs.launchpad.net/manila/+bug/1920937\u003e\u0027_.","commit_id":"0e2699170d4c1fe683c01cfff1b7a99d561914b2"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"e4f24f1dd6e8d3f74d44e02867aeecf01c5a835d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Fixed non-disruptive share migration of CIFS shares in the NetApp ONTAP"},{"line_number":5,"context_line":"    driver. During the CIFS share migration the creation of a new export path"},{"line_number":6,"context_line":"    is skipped and the actual export path is taken from the backend. For more"},{"line_number":7,"context_line":"    details, please refer to "},{"line_number":8,"context_line":"    \u0027launchpad bug #1920937 https://bugs.launchpad.net/manila/+bug/1920937\u0027_."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff23678_fa865a4e","line":8,"range":{"start_line":7,"start_character":12,"end_line":8,"end_character":77},"in_reply_to":"0a39b998_c01953d8","updated":"2023-03-13 13:30:17.000000000","message":"Done","commit_id":"0e2699170d4c1fe683c01cfff1b7a99d561914b2"}]}