)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ebb9904cce8e65da4bd044b2a8835b28b8c9d445","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"200f39cd_fb8aac0f","updated":"2022-09-29 15:42:52.000000000","message":"Thanks for the fix - Found few things that might be worth changing in the exception message. Please take a look at it :)\n\nUnsure if we need a release note for this, but initially I don\u0027t think so. We could gather other reviewers opinion as well.","commit_id":"b6352275a8d3aaab73fdc2a731fbdd23a26ef274"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a81aef270dc2922a06e566255b631391ddc78c53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4a1735bb_958e654c","updated":"2022-09-30 12:34:39.000000000","message":"LGTM, thanks for the updates, Victoria","commit_id":"8276fa3c88f17744d65f53124b91b26c4c62d2d0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5cafb638b9770e86fc1d970b4c50684886874a03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7874efc7_65fa586c","updated":"2022-09-30 16:58:29.000000000","message":"Thanks Victoria!","commit_id":"8276fa3c88f17744d65f53124b91b26c4c62d2d0"}],"manila/share/drivers/cephfs/driver.py":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"00ebec54058d6a3ea5bb0c4904128442abf5d55b","unresolved":true,"context_lines":[{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"        # there are no export IPs, we fallback to the hostname"},{"line_number":1200,"context_line":"        if not export_ips:"},{"line_number":1201,"context_line":"            export_ips \u003d [socket.gethostname()]"},{"line_number":1202,"context_line":""},{"line_number":1203,"context_line":"        return export_ips"},{"line_number":1204,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a1ad5fc_fac15620","line":1201,"range":{"start_line":1201,"start_character":26,"end_line":1201,"end_character":46},"updated":"2022-09-19 11:08:33.000000000","message":"This is probably fine in a standalone environment, but I\u0027m not sure what happens in a multinode where we have no VIP or A/A ganesha instances.\nI\u0027m worried about having the nfs cluster created but w/ no backends on the Ceph side.\n+1 to make additional checks on this stage and handling the failure, but we might need some logic to detect a failure in the underlying backend.","commit_id":"c4f05c0626d82c8991305b4ca51ad72232b47a5d"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"eaa50d32675e4cba7f29fcffb58671ac28d60dac","unresolved":false,"context_lines":[{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"        # there are no export IPs, we fallback to the hostname"},{"line_number":1200,"context_line":"        if not export_ips:"},{"line_number":1201,"context_line":"            export_ips \u003d [socket.gethostname()]"},{"line_number":1202,"context_line":""},{"line_number":1203,"context_line":"        return export_ips"},{"line_number":1204,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"be0c0605_b07c41be","line":1201,"range":{"start_line":1201,"start_character":26,"end_line":1201,"end_character":46},"in_reply_to":"61163d5c_81642490","updated":"2022-09-30 10:01:48.000000000","message":"Done","commit_id":"c4f05c0626d82c8991305b4ca51ad72232b47a5d"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"875110ce6f0ec67fe3d8ede8487c6ded3da57250","unresolved":true,"context_lines":[{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"        # there are no export IPs, we fallback to the hostname"},{"line_number":1200,"context_line":"        if not export_ips:"},{"line_number":1201,"context_line":"            export_ips \u003d [socket.gethostname()]"},{"line_number":1202,"context_line":""},{"line_number":1203,"context_line":"        return export_ips"},{"line_number":1204,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"61163d5c_81642490","line":1201,"range":{"start_line":1201,"start_character":26,"end_line":1201,"end_character":46},"in_reply_to":"7a1ad5fc_fac15620","updated":"2022-09-19 14:27:50.000000000","message":"Thanks for reviewing Francesco. I changed the logic to fail explicitly if no backend is found. We can think on another options if this doesn\u0027t work.","commit_id":"c4f05c0626d82c8991305b4ca51ad72232b47a5d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ebb9904cce8e65da4bd044b2a8835b28b8c9d445","unresolved":true,"context_lines":[{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"        # there are no export IPs, there are no NFS servers we can use"},{"line_number":1200,"context_line":"        if not export_ips:"},{"line_number":1201,"context_line":"            msg \u003d _(\"There are no NFS servers available to use.\""},{"line_number":1202,"context_line":"                    \"Please check the health of your Ceph cluster\""},{"line_number":1203,"context_line":"                    \"and restart the manila share service.\")"},{"line_number":1204,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"492a32a1_de207d2b","line":1201,"range":{"start_line":1201,"start_character":62,"end_line":1201,"end_character":64},"updated":"2022-09-29 15:42:52.000000000","message":"nit: missing blank space after the .","commit_id":"b6352275a8d3aaab73fdc2a731fbdd23a26ef274"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a200d4ff2e84c8c9dda69b657fe3e5b8426125fe","unresolved":true,"context_lines":[{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"        # there are no export IPs, there are no NFS servers we can use"},{"line_number":1200,"context_line":"        if not export_ips:"},{"line_number":1201,"context_line":"            msg \u003d _(\"There are no NFS servers available to use.\""},{"line_number":1202,"context_line":"                    \"Please check the health of your Ceph cluster\""},{"line_number":1203,"context_line":"                    \"and restart the manila share service.\")"},{"line_number":1204,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5d27f237_e0757e68","line":1201,"range":{"start_line":1201,"start_character":63,"end_line":1201,"end_character":64},"updated":"2022-09-29 15:43:05.000000000","message":"space before endquote","commit_id":"b6352275a8d3aaab73fdc2a731fbdd23a26ef274"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"eaa50d32675e4cba7f29fcffb58671ac28d60dac","unresolved":false,"context_lines":[{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"        # there are no export IPs, there are no NFS servers we can use"},{"line_number":1200,"context_line":"        if not export_ips:"},{"line_number":1201,"context_line":"            msg \u003d _(\"There are no NFS servers available to use.\""},{"line_number":1202,"context_line":"                    \"Please check the health of your Ceph cluster\""},{"line_number":1203,"context_line":"                    \"and restart the manila share service.\")"},{"line_number":1204,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"81eee33d_16bcd324","line":1201,"range":{"start_line":1201,"start_character":62,"end_line":1201,"end_character":64},"in_reply_to":"492a32a1_de207d2b","updated":"2022-09-30 10:01:48.000000000","message":"Done","commit_id":"b6352275a8d3aaab73fdc2a731fbdd23a26ef274"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"1fb943c523b7e801e8425b4bf1af0869eaefd56e","unresolved":false,"context_lines":[{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"        # there are no export IPs, there are no NFS servers we can use"},{"line_number":1200,"context_line":"        if not export_ips:"},{"line_number":1201,"context_line":"            msg \u003d _(\"There are no NFS servers available to use.\""},{"line_number":1202,"context_line":"                    \"Please check the health of your Ceph cluster\""},{"line_number":1203,"context_line":"                    \"and restart the manila share service.\")"},{"line_number":1204,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"a5b443b7_73a0b014","line":1201,"range":{"start_line":1201,"start_character":63,"end_line":1201,"end_character":64},"in_reply_to":"5d27f237_e0757e68","updated":"2022-09-30 09:45:35.000000000","message":"Done","commit_id":"b6352275a8d3aaab73fdc2a731fbdd23a26ef274"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ebb9904cce8e65da4bd044b2a8835b28b8c9d445","unresolved":true,"context_lines":[{"line_number":1199,"context_line":"        # there are no export IPs, there are no NFS servers we can use"},{"line_number":1200,"context_line":"        if not export_ips:"},{"line_number":1201,"context_line":"            msg \u003d _(\"There are no NFS servers available to use.\""},{"line_number":1202,"context_line":"                    \"Please check the health of your Ceph cluster\""},{"line_number":1203,"context_line":"                    \"and restart the manila share service.\")"},{"line_number":1204,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":1205,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a51a89d_0602100f","line":1202,"range":{"start_line":1202,"start_character":64,"end_line":1202,"end_character":66},"updated":"2022-09-29 15:42:52.000000000","message":"same","commit_id":"b6352275a8d3aaab73fdc2a731fbdd23a26ef274"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a200d4ff2e84c8c9dda69b657fe3e5b8426125fe","unresolved":true,"context_lines":[{"line_number":1199,"context_line":"        # there are no export IPs, there are no NFS servers we can use"},{"line_number":1200,"context_line":"        if not export_ips:"},{"line_number":1201,"context_line":"            msg \u003d _(\"There are no NFS servers available to use.\""},{"line_number":1202,"context_line":"                    \"Please check the health of your Ceph cluster\""},{"line_number":1203,"context_line":"                    \"and restart the manila share service.\")"},{"line_number":1204,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":1205,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"606c6bed_9c948449","line":1202,"range":{"start_line":1202,"start_character":65,"end_line":1202,"end_character":66},"updated":"2022-09-29 15:43:05.000000000","message":"space before endquote","commit_id":"b6352275a8d3aaab73fdc2a731fbdd23a26ef274"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"1fb943c523b7e801e8425b4bf1af0869eaefd56e","unresolved":false,"context_lines":[{"line_number":1199,"context_line":"        # there are no export IPs, there are no NFS servers we can use"},{"line_number":1200,"context_line":"        if not export_ips:"},{"line_number":1201,"context_line":"            msg \u003d _(\"There are no NFS servers available to use.\""},{"line_number":1202,"context_line":"                    \"Please check the health of your Ceph cluster\""},{"line_number":1203,"context_line":"                    \"and restart the manila share service.\")"},{"line_number":1204,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":1205,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"926ac981_efbb05cc","line":1202,"range":{"start_line":1202,"start_character":64,"end_line":1202,"end_character":66},"in_reply_to":"5a51a89d_0602100f","updated":"2022-09-30 09:45:35.000000000","message":"Ack","commit_id":"b6352275a8d3aaab73fdc2a731fbdd23a26ef274"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"1fb943c523b7e801e8425b4bf1af0869eaefd56e","unresolved":false,"context_lines":[{"line_number":1199,"context_line":"        # there are no export IPs, there are no NFS servers we can use"},{"line_number":1200,"context_line":"        if not export_ips:"},{"line_number":1201,"context_line":"            msg \u003d _(\"There are no NFS servers available to use.\""},{"line_number":1202,"context_line":"                    \"Please check the health of your Ceph cluster\""},{"line_number":1203,"context_line":"                    \"and restart the manila share service.\")"},{"line_number":1204,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":1205,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"45a1fd8c_5318478e","line":1202,"range":{"start_line":1202,"start_character":65,"end_line":1202,"end_character":66},"in_reply_to":"606c6bed_9c948449","updated":"2022-09-30 09:45:35.000000000","message":"Done","commit_id":"b6352275a8d3aaab73fdc2a731fbdd23a26ef274"}]}