)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33693,"name":"yuehui gan","display_name":"fzzf","email":"gan769410938@outlook.com","username":"gyh"},"change_message_id":"508314dc0d126498c33d0e7411fad6f613a268a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d9e5566b_2d171b00","updated":"2022-09-21 11:44:48.000000000","message":"MACROSAN:recheck","commit_id":"2bbee05cfd7000a1ca6cb64a24c4dd9f47746e84"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0a90abd5ff294d9f31c07c05a734f85d8e9fa060","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cff7c46f_463b0b7a","updated":"2022-09-21 15:33:02.000000000","message":"Thank you for the changes; could you also add a release note with the \"upgrade\" section calling out the new configuration option being added and how the behavior is changing? https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html#how-do-i-add-a-release-note","commit_id":"2bbee05cfd7000a1ca6cb64a24c4dd9f47746e84"},{"author":{"_account_id":33693,"name":"yuehui gan","display_name":"fzzf","email":"gan769410938@outlook.com","username":"gyh"},"change_message_id":"4ec521423af89055645a54908964b6d0e5c911e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bb1966c6_9a1377ea","updated":"2022-09-22 10:23:06.000000000","message":"MACROSAN:recheck","commit_id":"977ad7c5b08ba580aa9eed0e7187a55fea986c3c"},{"author":{"_account_id":33693,"name":"yuehui gan","display_name":"fzzf","email":"gan769410938@outlook.com","username":"gyh"},"change_message_id":"fad37ee3fdce819d205e3c13f831d9d0352f644b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"46927009_388c2c23","updated":"2022-09-23 05:44:28.000000000","message":"MACROSAN:recheck","commit_id":"6217cf3a2bcb7c1b076123304f154c8e8f8ca512"},{"author":{"_account_id":33693,"name":"yuehui gan","display_name":"fzzf","email":"gan769410938@outlook.com","username":"gyh"},"change_message_id":"0f5d180a18a1b96fa09ec308f7300db3ba7d93f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"69841309_b121f3e0","updated":"2022-09-23 06:18:42.000000000","message":"MACROSAN:recheck","commit_id":"6217cf3a2bcb7c1b076123304f154c8e8f8ca512"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e0b27c9f17e181a0d9743f5c982a085de8bad5d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"768662ff_3afd4ff3","updated":"2022-09-26 23:48:37.000000000","message":"Thanks, changes LGTM - the release note calls out something that wasn\u0027t modified in this change. Could you please take a look","commit_id":"9af49bb006783d4d484f6f7d62cb0ff151f3e768"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ef92a2ce852ea8ccf4a5deb7eddebdf0e399a140","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b4ff5177_37043dac","updated":"2022-09-27 18:32:46.000000000","message":"I agree with defaulting SSL verification to False; but it feels like the wrong thing to do in terms of security. You\u0027re claiming that the backend doesn\u0027t support SSL verification --- but that\u0027s not how this is supposed to work; the python SSL module will disallow the use of self-signed (or certificates with expired CA) if \"verify\" is set to False - the requests won\u0027t be sent to the backend at all. \n\nSo I strongly encourage asking deployers to use verifiable CA Signed certificates in production deployments - I suggested that you include that bit in the release note, but I see that you\u0027re probably hesitating to do that. I will leave that up to you... \n\nThanks for addressing the issues raised; we should be able to back-port this to stable/zed after this merges. ","commit_id":"4b83a6bd52c34a75346a03e01f01af54d554dbed"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ec506be81f049f8aac891db77d01ebdc6a34b77e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"eefd74e5_b571d223","updated":"2022-10-05 13:42:05.000000000","message":"Thank you for the follow-up change\nLooking good!","commit_id":"4b83a6bd52c34a75346a03e01f01af54d554dbed"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ec506be81f049f8aac891db77d01ebdc6a34b77e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a46060b1_6ac4e1e2","in_reply_to":"b4ff5177_37043dac","updated":"2022-10-05 13:42:05.000000000","message":"++, good remarks, Goutham!","commit_id":"4b83a6bd52c34a75346a03e01f01af54d554dbed"}],"manila/share/drivers/macrosan/macrosan_helper.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0a90abd5ff294d9f31c07c05a734f85d8e9fa060","unresolved":true,"context_lines":[{"line_number":319,"context_line":"\r"},{"line_number":320,"context_line":"        if proto \u003d\u003d \u0027NFS\u0027:\r"},{"line_number":321,"context_line":"            for share_access in access_list:\r"},{"line_number":322,"context_line":"                #IPv4 Address Blocks Reserved for Documentation\r"},{"line_number":323,"context_line":"                if share_access[\u0027access_to\u0027] \u003d\u003d \u0027192.0.2.0\u0027:\r"},{"line_number":324,"context_line":"                    continue\r"},{"line_number":325,"context_line":"                self.rest._delete_nfs_access_rest(share_path,\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"cb2684c2_633c7c9b","line":322,"in_reply_to":"880a9630_e3390421","updated":"2022-09-21 15:33:02.000000000","message":"\u003e pep8: E265 block comment should start with \u0027# \u0027\n\nYou\u0027re missing a space","commit_id":"2bbee05cfd7000a1ca6cb64a24c4dd9f47746e84"},{"author":{"_account_id":33693,"name":"yuehui gan","display_name":"fzzf","email":"gan769410938@outlook.com","username":"gyh"},"change_message_id":"ae2835381b06cc115dc8b12b2f689149a235db79","unresolved":false,"context_lines":[{"line_number":319,"context_line":"\r"},{"line_number":320,"context_line":"        if proto \u003d\u003d \u0027NFS\u0027:\r"},{"line_number":321,"context_line":"            for share_access in access_list:\r"},{"line_number":322,"context_line":"                #IPv4 Address Blocks Reserved for Documentation\r"},{"line_number":323,"context_line":"                if share_access[\u0027access_to\u0027] \u003d\u003d \u0027192.0.2.0\u0027:\r"},{"line_number":324,"context_line":"                    continue\r"},{"line_number":325,"context_line":"                self.rest._delete_nfs_access_rest(share_path,\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"352479b3_9a1c8e2b","line":322,"in_reply_to":"cb2684c2_633c7c9b","updated":"2022-09-23 15:27:51.000000000","message":"Done","commit_id":"2bbee05cfd7000a1ca6cb64a24c4dd9f47746e84"}],"manila/share/drivers/macrosan/macrosan_nas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0a90abd5ff294d9f31c07c05a734f85d8e9fa060","unresolved":true,"context_lines":[{"line_number":43,"context_line":"               choices\u003d[\u0027http\u0027, \u0027https\u0027],\r"},{"line_number":44,"context_line":"               help\u003d\u0027Http protocol for the Macrosan NAS server.\u0027),\r"},{"line_number":45,"context_line":"    cfg.BoolOpt(\u0027macrosan_ssl_cert_verify\u0027,\r"},{"line_number":46,"context_line":"                default\u003dFalse,\r"},{"line_number":47,"context_line":"                help\u003d\u0027Defines whether the driver should check ssl cert.\u0027),\r"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027macrosan_nas_prefix\u0027,\r"},{"line_number":49,"context_line":"               default\u003d\u0027nas\u0027,\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"9cfc7994_2343ef4c","line":46,"range":{"start_line":46,"start_character":24,"end_line":46,"end_character":29},"updated":"2022-09-21 15:33:02.000000000","message":"True\n\nIt\u0027s better to always verify, and allow overriding this to false in insecure environments","commit_id":"2bbee05cfd7000a1ca6cb64a24c4dd9f47746e84"},{"author":{"_account_id":33693,"name":"yuehui gan","display_name":"fzzf","email":"gan769410938@outlook.com","username":"gyh"},"change_message_id":"ae2835381b06cc115dc8b12b2f689149a235db79","unresolved":true,"context_lines":[{"line_number":43,"context_line":"               choices\u003d[\u0027http\u0027, \u0027https\u0027],\r"},{"line_number":44,"context_line":"               help\u003d\u0027Http protocol for the Macrosan NAS server.\u0027),\r"},{"line_number":45,"context_line":"    cfg.BoolOpt(\u0027macrosan_ssl_cert_verify\u0027,\r"},{"line_number":46,"context_line":"                default\u003dFalse,\r"},{"line_number":47,"context_line":"                help\u003d\u0027Defines whether the driver should check ssl cert.\u0027),\r"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027macrosan_nas_prefix\u0027,\r"},{"line_number":49,"context_line":"               default\u003d\u0027nas\u0027,\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"faad919d_41c87777","line":46,"range":{"start_line":46,"start_character":24,"end_line":46,"end_character":29},"in_reply_to":"9cfc7994_2343ef4c","updated":"2022-09-23 15:27:51.000000000","message":"backend didn\u0027t verify ssl, so I set False by default.","commit_id":"2bbee05cfd7000a1ca6cb64a24c4dd9f47746e84"},{"author":{"_account_id":33693,"name":"yuehui gan","display_name":"fzzf","email":"gan769410938@outlook.com","username":"gyh"},"change_message_id":"c72839562139b6abb4049250844da0aba14712bc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"               choices\u003d[\u0027http\u0027, \u0027https\u0027],\r"},{"line_number":44,"context_line":"               help\u003d\u0027Http protocol for the Macrosan NAS server.\u0027),\r"},{"line_number":45,"context_line":"    cfg.BoolOpt(\u0027macrosan_ssl_cert_verify\u0027,\r"},{"line_number":46,"context_line":"                default\u003dFalse,\r"},{"line_number":47,"context_line":"                help\u003d\u0027Defines whether the driver should check ssl cert.\u0027),\r"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027macrosan_nas_prefix\u0027,\r"},{"line_number":49,"context_line":"               default\u003d\u0027nas\u0027,\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"fcc25e0e_4792a5b0","line":46,"range":{"start_line":46,"start_character":24,"end_line":46,"end_character":29},"in_reply_to":"faad919d_41c87777","updated":"2022-09-27 05:43:57.000000000","message":"Done","commit_id":"2bbee05cfd7000a1ca6cb64a24c4dd9f47746e84"}],"releasenote/notes/macrosan-add-configuration-option-282fa1026748c4f9.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e0b27c9f17e181a0d9743f5c982a085de8bad5d8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Add configuration option \"macrosan_nas_http_protocol\","},{"line_number":4,"context_line":"    its values are \"http\", \"https\". driver only used \"https\"."},{"line_number":5,"context_line":"    add configuration option \"macrosan_ssl_cert_verfiy\", it define whether"},{"line_number":6,"context_line":"    driver check ssl cert. driver didn\u0027t check by default."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c946ea50_f91aabaa","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":35},"updated":"2022-09-26 23:48:37.000000000","message":"This config option wasn\u0027t added in this change... so please remove this since it might confuse deployers. you\u0027ve only added a \"choices\" field to the configuration so as to allow validation - that needn\u0027t be mentioned in the release note.","commit_id":"9af49bb006783d4d484f6f7d62cb0ff151f3e768"},{"author":{"_account_id":33693,"name":"yuehui gan","display_name":"fzzf","email":"gan769410938@outlook.com","username":"gyh"},"change_message_id":"c72839562139b6abb4049250844da0aba14712bc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Add configuration option \"macrosan_nas_http_protocol\","},{"line_number":4,"context_line":"    its values are \"http\", \"https\". driver only used \"https\"."},{"line_number":5,"context_line":"    add configuration option \"macrosan_ssl_cert_verfiy\", it define whether"},{"line_number":6,"context_line":"    driver check ssl cert. driver didn\u0027t check by default."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"af25c00f_85f4b41d","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":35},"in_reply_to":"c946ea50_f91aabaa","updated":"2022-09-27 05:43:57.000000000","message":"Done","commit_id":"9af49bb006783d4d484f6f7d62cb0ff151f3e768"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e0b27c9f17e181a0d9743f5c982a085de8bad5d8","unresolved":true,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Add configuration option \"macrosan_nas_http_protocol\","},{"line_number":4,"context_line":"    its values are \"http\", \"https\". driver only used \"https\"."},{"line_number":5,"context_line":"    add configuration option \"macrosan_ssl_cert_verfiy\", it define whether"},{"line_number":6,"context_line":"    driver check ssl cert. driver didn\u0027t check by default."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"25ecbd9c_ea6ac7e8","line":6,"range":{"start_line":5,"start_character":4,"end_line":6,"end_character":58},"updated":"2022-09-26 23:48:37.000000000","message":"Just a nit, but I suggest rewriting this a bit:\n\n  Added a new configuration option ``macrosan_ssl_cert_verify`` to configure\n  whether the driver should only allow verified ssl certificates. This option\n  defaults to ``False`` to allow backwards compatibility. It is strongly\n  recommended that this option is set to True and only signed and verifiable SSL\n  certificates are used with the Macrosan share driver.","commit_id":"9af49bb006783d4d484f6f7d62cb0ff151f3e768"},{"author":{"_account_id":33693,"name":"yuehui gan","display_name":"fzzf","email":"gan769410938@outlook.com","username":"gyh"},"change_message_id":"c72839562139b6abb4049250844da0aba14712bc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Add configuration option \"macrosan_nas_http_protocol\","},{"line_number":4,"context_line":"    its values are \"http\", \"https\". driver only used \"https\"."},{"line_number":5,"context_line":"    add configuration option \"macrosan_ssl_cert_verfiy\", it define whether"},{"line_number":6,"context_line":"    driver check ssl cert. driver didn\u0027t check by default."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ed1ead69_76a1bf76","line":6,"range":{"start_line":5,"start_character":4,"end_line":6,"end_character":58},"in_reply_to":"25ecbd9c_ea6ac7e8","updated":"2022-09-27 05:43:57.000000000","message":"Done","commit_id":"9af49bb006783d4d484f6f7d62cb0ff151f3e768"}]}