)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c055c2fec810171c7cd943d4c2da9e976c37ddd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"83bc5ed3_2d1f74fd","updated":"2022-09-29 19:00:24.000000000","message":"Thanks Pavlo, could you please add a release note? https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html#how-do-i-add-a-release-note\n\nIs this a bugfix that\u0027s required on older releases? If yes, having a release note would be helpful for backporting. ","commit_id":"638e97271fa55a39faee2f9d43048c8ca4155a99"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"71a1134b720414eaafa1c6e27352a9af9e642799","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc52b71a_9cd98096","in_reply_to":"7ce50112_a0ccf0cb","updated":"2022-09-30 13:38:16.000000000","message":"Done","commit_id":"638e97271fa55a39faee2f9d43048c8ca4155a99"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"adae2f3d84033ab00b82dd84c6d0d94bcacf5ec5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7ce50112_a0ccf0cb","in_reply_to":"83bc5ed3_2d1f74fd","updated":"2022-09-30 13:25:43.000000000","message":"yes, sure, will do - file a proper bug for reference and add a release note\n\nthe separate glance call seems to have appeared since Victoria (https://review.opendev.org/c/openstack/manila/+/738061) so I\u0027d think a backport down to Victoria may be warranted.","commit_id":"638e97271fa55a39faee2f9d43048c8ca4155a99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3253b220805b63da0fe746c804473fcfaa73b306","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eb8a3776_3ccbb2b9","updated":"2022-09-30 19:03:07.000000000","message":"Thanks for the bug reference and the release note! I think a couple of minor issues persist. ","commit_id":"0e29bc53be9271e7ddb6304d31716020127bc58c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9793d1ffb222f29361d98146e164c33f4c9ae661","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ee2b0c65_74f781b4","updated":"2022-09-30 19:03:44.000000000","message":"the CI failure on the LVM job here is unrelated; i\u0027m not re-triggering though because another patchset may address issues and will be tested anyway.. ","commit_id":"0e29bc53be9271e7ddb6304d31716020127bc58c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"23c31614442de58edd3a9669b4990c9be38aefb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b981f760_a172cc97","updated":"2022-10-04 14:23:54.000000000","message":"Fix looks good - Thank you!","commit_id":"111104b9a2fd54de2559041249bdb7a10c64664c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bdb8f7d62eaccdc2d85694e86d2bfbeffbaaf2d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7dae5078_a604d76f","updated":"2022-10-04 14:20:20.000000000","message":"Thank you for the fixes; LGTM!","commit_id":"111104b9a2fd54de2559041249bdb7a10c64664c"}],"manila/image/glance.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3253b220805b63da0fe746c804473fcfaa73b306","unresolved":true,"context_lines":[{"line_number":37,"context_line":"               help\u003d\u0027Region name for connecting to glance.\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027endpoint_type\u0027,"},{"line_number":39,"context_line":"               default\u003d\u0027publicURL\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027Endpoint type to be used with cinder client calls.\u0027),"},{"line_number":41,"context_line":"    ]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"d66eb88f_e32c86e3","line":40,"range":{"start_line":40,"start_character":51,"end_line":40,"end_character":57},"updated":"2022-09-30 19:03:07.000000000","message":"glance","commit_id":"0e29bc53be9271e7ddb6304d31716020127bc58c"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"3dabf7827303a1fcdde25e5733dd9b40d1368aaf","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d\u0027Region name for connecting to glance.\u0027),"},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027endpoint_type\u0027,"},{"line_number":39,"context_line":"               default\u003d\u0027publicURL\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027Endpoint type to be used with cinder client calls.\u0027),"},{"line_number":41,"context_line":"    ]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"0fc85711_eb83aadb","line":40,"range":{"start_line":40,"start_character":51,"end_line":40,"end_character":57},"in_reply_to":"d66eb88f_e32c86e3","updated":"2022-10-04 12:13:10.000000000","message":"Done","commit_id":"0e29bc53be9271e7ddb6304d31716020127bc58c"}],"releasenotes/notes/bug-1991396-add-glance-endpoint-type-151777f255e423a3.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3253b220805b63da0fe746c804473fcfaa73b306","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deployers now can specify ``[glance]endpoint_type`` configuration option"},{"line_number":5,"context_line":"    (defaults to ``publicURL`` for backward compatibility)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6ad14289_2ed74c7c","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2022-09-30 19:03:07.000000000","message":"fixes\n\n\n\nsince this resolves the issue you\u0027re having about using glance API when not available via the public network","commit_id":"0e29bc53be9271e7ddb6304d31716020127bc58c"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"3dabf7827303a1fcdde25e5733dd9b40d1368aaf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Deployers now can specify ``[glance]endpoint_type`` configuration option"},{"line_number":5,"context_line":"    (defaults to ``publicURL`` for backward compatibility)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2e1c76f5_f0a059a0","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"6ad14289_2ed74c7c","updated":"2022-10-04 12:13:10.000000000","message":"Done","commit_id":"0e29bc53be9271e7ddb6304d31716020127bc58c"}]}
