)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e9b656492373b251ad7712d47fd7f81bed14f3ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2d9ea91a_27aa18fa","updated":"2022-11-23 01:26:41.000000000","message":"Thanks carthaca for providing this fix. It looks fine. Just some small code style. \n\nWe need to pass this patch with NetApp CI too: run-NetApp CI","commit_id":"5f664ae31388e84aac68f353d9200dbf415fa80a"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"c32ac0a0ea55559bdb3c43f49034e0c8950dc07e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b97c077_2333a66a","updated":"2022-11-24 01:02:02.000000000","message":"LGTM. Waiting for NetApp CI","commit_id":"46d0c4d34a5a0d477788cdc036f8e575bbc8ed58"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"186375a6c981920917e6f23fcb71de8c215c9ef8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b990ac7_c5e8bc8a","updated":"2023-01-26 21:13:29.000000000","message":"Thanks for the fix, Maurice! LGTM","commit_id":"46d0c4d34a5a0d477788cdc036f8e575bbc8ed58"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"0f8249dc3d425346f30c20cd19c9ad59e3e38fc3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0d886234_a75fc062","updated":"2022-11-23 12:31:25.000000000","message":"recheck\n\nfailure is unrelated \u0027Server f6a5ef0a-29cd-41e6-bf9e-b88e0b383ae3 failed to reach ACTIVE status and task state \"None\" within the required time (196 s). Current status: BUILD. Current task state: spawning.\u0027","commit_id":"46d0c4d34a5a0d477788cdc036f8e575bbc8ed58"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"c7796f003a88dec40725edcdadb8dbfca25c95a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c65d0eac_69c4fb61","updated":"2022-11-24 01:02:10.000000000","message":"run-NetApp CI","commit_id":"46d0c4d34a5a0d477788cdc036f8e575bbc8ed58"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"06ddbe78cc07dfd45b9348638fdc86c6b7b46b47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e9f9b048_8248381e","updated":"2023-01-04 00:23:55.000000000","message":"run-NetApp CI","commit_id":"46d0c4d34a5a0d477788cdc036f8e575bbc8ed58"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e9b656492373b251ad7712d47fd7f81bed14f3ec","unresolved":true,"context_lines":[{"line_number":477,"context_line":"                        LOG.error(\u0027CIFS server does not exist for \u0027"},{"line_number":478,"context_line":"                                  \u0027Vserver %s.\u0027, vserver_name)"},{"line_number":479,"context_line":"                    else:"},{"line_number":480,"context_line":"                        LOG.debug(\u0027CIFS server force deleted for \u0027"},{"line_number":481,"context_line":"                                  \u0027Vserver %s.\u0027, vserver_name)"},{"line_number":482,"context_line":"                        force_args \u003d {"},{"line_number":483,"context_line":"                            \u0027force-account-delete\u0027: \u0027true\u0027"},{"line_number":484,"context_line":"                        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"6c098031_d960c680","line":481,"range":{"start_line":480,"start_character":24,"end_line":481,"end_character":62},"updated":"2022-11-23 01:26:41.000000000","message":"you could log that this is a retry:\n\n\"Retrying CIFS server delete with force flag for Vserver %s\"","commit_id":"5f664ae31388e84aac68f353d9200dbf415fa80a"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"9ee0209527fbaef12bfcd029c84d86d85f445156","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                        LOG.error(\u0027CIFS server does not exist for \u0027"},{"line_number":478,"context_line":"                                  \u0027Vserver %s.\u0027, vserver_name)"},{"line_number":479,"context_line":"                    else:"},{"line_number":480,"context_line":"                        LOG.debug(\u0027CIFS server force deleted for \u0027"},{"line_number":481,"context_line":"                                  \u0027Vserver %s.\u0027, vserver_name)"},{"line_number":482,"context_line":"                        force_args \u003d {"},{"line_number":483,"context_line":"                            \u0027force-account-delete\u0027: \u0027true\u0027"},{"line_number":484,"context_line":"                        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"2cad2d53_102c5df3","line":481,"range":{"start_line":480,"start_character":24,"end_line":481,"end_character":62},"in_reply_to":"6c098031_d960c680","updated":"2022-11-23 09:29:35.000000000","message":"Done","commit_id":"5f664ae31388e84aac68f353d9200dbf415fa80a"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e9b656492373b251ad7712d47fd7f81bed14f3ec","unresolved":true,"context_lines":[{"line_number":479,"context_line":"                    else:"},{"line_number":480,"context_line":"                        LOG.debug(\u0027CIFS server force deleted for \u0027"},{"line_number":481,"context_line":"                                  \u0027Vserver %s.\u0027, vserver_name)"},{"line_number":482,"context_line":"                        force_args \u003d {"},{"line_number":483,"context_line":"                            \u0027force-account-delete\u0027: \u0027true\u0027"},{"line_number":484,"context_line":"                        }"},{"line_number":485,"context_line":"                        vserver_client.send_request(\u0027cifs-server-delete\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7bbdbc80_ced0ef30","line":482,"range":{"start_line":482,"start_character":24,"end_line":482,"end_character":35},"updated":"2022-11-23 01:26:41.000000000","message":"nit: the client cmode code names this kind of variable as \"api_args\"","commit_id":"5f664ae31388e84aac68f353d9200dbf415fa80a"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"9ee0209527fbaef12bfcd029c84d86d85f445156","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                    else:"},{"line_number":480,"context_line":"                        LOG.debug(\u0027CIFS server force deleted for \u0027"},{"line_number":481,"context_line":"                                  \u0027Vserver %s.\u0027, vserver_name)"},{"line_number":482,"context_line":"                        force_args \u003d {"},{"line_number":483,"context_line":"                            \u0027force-account-delete\u0027: \u0027true\u0027"},{"line_number":484,"context_line":"                        }"},{"line_number":485,"context_line":"                        vserver_client.send_request(\u0027cifs-server-delete\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6e7c1e8c_234d1cd6","line":482,"range":{"start_line":482,"start_character":24,"end_line":482,"end_character":35},"in_reply_to":"7bbdbc80_ced0ef30","updated":"2022-11-23 09:29:35.000000000","message":"Done","commit_id":"5f664ae31388e84aac68f353d9200dbf415fa80a"}],"releasenotes/notes/bug-1995733-netapp-cifs-server-force-delete-d513c548ebf56448.yaml":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e9b656492373b251ad7712d47fd7f81bed14f3ec","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    An error preventing share server cleanup in the NetApp driver has been"},{"line_number":5,"context_line":"    fixed. When an active directory (ad) security service had been used and"},{"line_number":6,"context_line":"    the ad account credentials were no longer working to do the cleanup,"},{"line_number":7,"context_line":"    a fallback is working again. The fallback is to not remove the"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2e206adb_e0a783b1","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":6},"updated":"2022-11-23 01:26:41.000000000","message":"The","commit_id":"5f664ae31388e84aac68f353d9200dbf415fa80a"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"9ee0209527fbaef12bfcd029c84d86d85f445156","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    An error preventing share server cleanup in the NetApp driver has been"},{"line_number":5,"context_line":"    fixed. When an active directory (ad) security service had been used and"},{"line_number":6,"context_line":"    the ad account credentials were no longer working to do the cleanup,"},{"line_number":7,"context_line":"    a fallback is working again. The fallback is to not remove the"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fffd9ce8_3ef47237","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":6},"in_reply_to":"2e206adb_e0a783b1","updated":"2022-11-23 09:29:35.000000000","message":"Done and I\u0027ve added the link to the bug, so that the specific \u0027the\u0027 makes more sense","commit_id":"5f664ae31388e84aac68f353d9200dbf415fa80a"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e9b656492373b251ad7712d47fd7f81bed14f3ec","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    An error preventing share server cleanup in the NetApp driver has been"},{"line_number":5,"context_line":"    fixed. When an active directory (ad) security service had been used and"},{"line_number":6,"context_line":"    the ad account credentials were no longer working to do the cleanup,"},{"line_number":7,"context_line":"    a fallback is working again. The fallback is to not remove the"},{"line_number":8,"context_line":"    corresponding cifs server on ad."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"10ac817f_39858f5e","line":5,"range":{"start_line":4,"start_character":8,"end_line":5,"end_character":9},"updated":"2022-11-23 01:26:41.000000000","message":"Add the word \"NetApp driver\" at first. It makes the reader life easier, since it can know that the fix is related to NetApp from the beginning:\n\nNetApp driver has been fixed to the error preventing share server cleanup with active directory.","commit_id":"5f664ae31388e84aac68f353d9200dbf415fa80a"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"9ee0209527fbaef12bfcd029c84d86d85f445156","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    An error preventing share server cleanup in the NetApp driver has been"},{"line_number":5,"context_line":"    fixed. When an active directory (ad) security service had been used and"},{"line_number":6,"context_line":"    the ad account credentials were no longer working to do the cleanup,"},{"line_number":7,"context_line":"    a fallback is working again. The fallback is to not remove the"},{"line_number":8,"context_line":"    corresponding cifs server on ad."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"45dae1df_1c80bad5","line":5,"range":{"start_line":4,"start_character":8,"end_line":5,"end_character":9},"in_reply_to":"10ac817f_39858f5e","updated":"2022-11-23 09:29:35.000000000","message":"Done","commit_id":"5f664ae31388e84aac68f353d9200dbf415fa80a"}]}