)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6965b83637385f933e3595c042acd14d6f7de6cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"132f0028_fe0072b1","updated":"2022-12-23 18:32:02.000000000","message":"Failures are caused by tox \u003e 4.0","commit_id":"7b72342bb316198f848c7bfe3601de7946e5176a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"45fcfcb28deec260021b190042589f18d228b02d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bfdc8f5e_47cf3050","updated":"2023-01-02 17:19:37.000000000","message":"recheck\nBase job is supposed to be fixed now","commit_id":"7b72342bb316198f848c7bfe3601de7946e5176a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"e8c5d3659fa20acba017fde3f6f7da60b976ab99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3ea9fbcb_464c0eb6","updated":"2023-01-03 09:06:49.000000000","message":"thanks for your change. here are some comments.","commit_id":"7b72342bb316198f848c7bfe3601de7946e5176a"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"4abe323bcca8eb063b6308335b4275f4370465df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"401a5ab1_1aea04de","updated":"2023-01-31 14:59:35.000000000","message":"Hi, Kiran, this patch looks good to me. \n\nI have only one question - I was not able to find a patch related to this change in python-manilaclient. Since this patch changes the API behavior, I think a change in the client may be necessary. Does it make sense to you? Are you already planning to implement this change in the python-manilaclient?\n","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a960975cb3a848faa0041124015d547361466483","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"80cf9809_6ab6f275","updated":"2023-01-31 23:43:30.000000000","message":"Thanks Kiran, some comments inline","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"91e34f1292b91436d10f60b508b4d92c7cf6dd98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"99068055_c9fbe34a","in_reply_to":"401a5ab1_1aea04de","updated":"2023-01-31 15:21:23.000000000","message":"yes. change in client is necessary, I am waiting for approval on this manila PR. Once +2, I will upload client patch.","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eeba144c56de1e5fc371669e355b8164d81f2c00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4976b13c_b1bad678","in_reply_to":"99068055_c9fbe34a","updated":"2023-01-31 22:42:33.000000000","message":"If you\u0027d like the client change to land in this cycle, please submit it soon - the client will be released at feature freeze (when this patch should merge as well)","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6bb7bbe0dd659b80bf6b71253e58415ae78eec02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5ea8f0c9_8d0dd2e1","updated":"2023-02-02 01:13:39.000000000","message":"Thanks Kiran. See my comments, please.\n\nDo you have a plan to provide this feature to manila client (openstack/python-manilaclient) ? \n\nHow did you test it ? Do you have any tempest test for it ?","commit_id":"e5ee2f7fabeead6e2c401b97fce1cbf28310e7ea"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"12a0aef663532e391bf6b8067efb3feb1a891b41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2292048d_4c549505","updated":"2023-02-01 14:55:01.000000000","message":"recheck","commit_id":"e5ee2f7fabeead6e2c401b97fce1cbf28310e7ea"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4d89add7809f7a176da45ec9bbbd442b21d33520","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1506a0d2_201496e1","in_reply_to":"5ea8f0c9_8d0dd2e1","updated":"2023-02-09 08:35:53.000000000","message":"I tested on local setup, will add python-manilaclient PR for this.","commit_id":"e5ee2f7fabeead6e2c401b97fce1cbf28310e7ea"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c45982c6179d967c4b43d353b7adca97ea96102","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5ad8255f_b9ddb9e5","updated":"2023-02-14 01:51:25.000000000","message":"Change is looking good - Thanks Kiran! And sorry fo the wait. I have also tested it and it works just fine. Do you have plans for covering this feature on manila-tempest-plugin as well?","commit_id":"5f0f14a7f8b99ac008be4604bcaeec2dbc149d06"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0911c9bb09f2659d3c6c8fa7405d1c0d0e2c1f05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1814a9fb_dda013f5","updated":"2023-02-15 00:13:37.000000000","message":"LGTM, thanks Kiran","commit_id":"5f0f14a7f8b99ac008be4604bcaeec2dbc149d06"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"7947d910f5f5f3938a9163374b78956b3814f248","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"653ee2c2_508e0207","updated":"2023-02-13 12:31:49.000000000","message":"LGTM, thanks Kiran","commit_id":"5f0f14a7f8b99ac008be4604bcaeec2dbc149d06"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"feac0c18020dc893cd7d95272553c54f0f40428c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5b5f8641_98c058a3","updated":"2023-02-14 02:14:56.000000000","message":"LGTM, thanks.","commit_id":"5f0f14a7f8b99ac008be4604bcaeec2dbc149d06"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4d89add7809f7a176da45ec9bbbd442b21d33520","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a8167a42_5cca4e67","updated":"2023-02-09 08:35:53.000000000","message":"recheck","commit_id":"5f0f14a7f8b99ac008be4604bcaeec2dbc149d06"}],"api-ref/source/samples/share-replica-promote-request.json":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a960975cb3a848faa0041124015d547361466483","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"promote\": {"},{"line_number":3,"context_line":"        \"quiesce_wait_time\": 30}"},{"line_number":4,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"19402f9e_9c733fea","line":3,"range":{"start_line":3,"start_character":31,"end_line":3,"end_character":32},"updated":"2023-01-31 23:43:30.000000000","message":"wrap to next line","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ebc5db8665b3069b1f337157a66bbf9950472e6f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"promote\": {"},{"line_number":3,"context_line":"        \"quiesce_wait_time\": 30}"},{"line_number":4,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"b8c69112_8dea2976","line":3,"range":{"start_line":3,"start_character":31,"end_line":3,"end_character":32},"in_reply_to":"19402f9e_9c733fea","updated":"2023-02-01 09:58:59.000000000","message":"Done","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"}],"api-ref/source/share-replicas.inc":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"e8c5d3659fa20acba017fde3f6f7da60b976ab99","unresolved":true,"context_lines":[{"line_number":159,"context_line":"Request example"},{"line_number":160,"context_line":"---------------"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":".. literalinclude:: samples/share-replica-promote-request.json"},{"line_number":163,"context_line":"   :language: javascript"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"03f8718c_0b274f4d","line":162,"range":{"start_line":162,"start_character":28,"end_line":162,"end_character":62},"updated":"2023-01-03 09:06:49.000000000","message":"maybe we also need to update this file to add quiesce_wait_time.\nfor example:\n{\n    \"promote\": {\n        \"quiesce_wait_time\": 30}\n}","commit_id":"7b72342bb316198f848c7bfe3601de7946e5176a"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"204fd9e19c7ea447c3807da6af2f13dd380891fd","unresolved":false,"context_lines":[{"line_number":159,"context_line":"Request example"},{"line_number":160,"context_line":"---------------"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":".. literalinclude:: samples/share-replica-promote-request.json"},{"line_number":163,"context_line":"   :language: javascript"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"59de3663_5fce074f","line":162,"range":{"start_line":162,"start_character":28,"end_line":162,"end_character":62},"in_reply_to":"03f8718c_0b274f4d","updated":"2023-01-03 09:40:00.000000000","message":"Done","commit_id":"7b72342bb316198f848c7bfe3601de7946e5176a"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6bb7bbe0dd659b80bf6b71253e58415ae78eec02","unresolved":true,"context_lines":[{"line_number":199,"context_line":"# The default api version request is defined to be the"},{"line_number":200,"context_line":"# minimum version of the API supported."},{"line_number":201,"context_line":"_MIN_API_VERSION \u003d \"2.0\""},{"line_number":202,"context_line":"_MAX_API_VERSION \u003d \"2.74\""},{"line_number":203,"context_line":"DEFAULT_API_VERSION \u003d _MIN_API_VERSION"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"8f749d9d_bf57123e","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":25},"updated":"2023-02-02 01:13:39.000000000","message":"Please, bump the max api version to 2.75.","commit_id":"e5ee2f7fabeead6e2c401b97fce1cbf28310e7ea"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4d89add7809f7a176da45ec9bbbd442b21d33520","unresolved":false,"context_lines":[{"line_number":199,"context_line":"# The default api version request is defined to be the"},{"line_number":200,"context_line":"# minimum version of the API supported."},{"line_number":201,"context_line":"_MIN_API_VERSION \u003d \"2.0\""},{"line_number":202,"context_line":"_MAX_API_VERSION \u003d \"2.74\""},{"line_number":203,"context_line":"DEFAULT_API_VERSION \u003d _MIN_API_VERSION"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"f85a8e77_a6955f01","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":25},"in_reply_to":"8f749d9d_bf57123e","updated":"2023-02-09 08:35:53.000000000","message":"Done","commit_id":"e5ee2f7fabeead6e2c401b97fce1cbf28310e7ea"}],"manila/api/v2/share_replicas.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"e8c5d3659fa20acba017fde3f6f7da60b976ab99","unresolved":true,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        quiesce_wait_time \u003d None"},{"line_number":280,"context_line":"        if allow_quiesce_wait_time:"},{"line_number":281,"context_line":"            quiesce_wait_time \u003d body.get(\u0027promote\u0027).get(\u0027quiesce_wait_time\u0027)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        try:"},{"line_number":284,"context_line":"            replica \u003d self.share_api.promote_share_replica("}],"source_content_type":"text/x-python","patch_set":2,"id":"56b09fee_c152e17a","line":281,"range":{"start_line":281,"start_character":11,"end_line":281,"end_character":76},"updated":"2023-01-03 09:06:49.000000000","message":"quiesce_wait_time \u003d body.get(\u0027promote\u0027, {}).get(\u0027quiesce_wait_time\u0027)\nThis avoids some unnecessary keyerror errors if body is {\"promote\": null}","commit_id":"7b72342bb316198f848c7bfe3601de7946e5176a"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"204fd9e19c7ea447c3807da6af2f13dd380891fd","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        quiesce_wait_time \u003d None"},{"line_number":280,"context_line":"        if allow_quiesce_wait_time:"},{"line_number":281,"context_line":"            quiesce_wait_time \u003d body.get(\u0027promote\u0027).get(\u0027quiesce_wait_time\u0027)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        try:"},{"line_number":284,"context_line":"            replica \u003d self.share_api.promote_share_replica("}],"source_content_type":"text/x-python","patch_set":2,"id":"ad683671_4094f689","line":281,"range":{"start_line":281,"start_character":11,"end_line":281,"end_character":76},"in_reply_to":"56b09fee_c152e17a","updated":"2023-01-03 09:40:00.000000000","message":"Done","commit_id":"7b72342bb316198f848c7bfe3601de7946e5176a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a960975cb3a848faa0041124015d547361466483","unresolved":true,"context_lines":[{"line_number":245,"context_line":"    @wsgi.response(202)"},{"line_number":246,"context_line":"    @wsgi.action(\u0027promote\u0027)"},{"line_number":247,"context_line":"    def promote(self, req, id, body): # pylint: disable\u003dfunction-redefined  # noqa F811"},{"line_number":248,"context_line":"        # pylint: disable\u003dfunction-redefined  # noqa F811"},{"line_number":249,"context_line":"        return self._promote(req, id, body)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    @wsgi.Controller.api_version(\"2.75\")  # noqa"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a26929d_656b2407","line":248,"range":{"start_line":248,"start_character":0,"end_line":248,"end_character":57},"updated":"2023-01-31 23:43:30.000000000","message":"annotation on the line above is enough","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ebc5db8665b3069b1f337157a66bbf9950472e6f","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    @wsgi.response(202)"},{"line_number":246,"context_line":"    @wsgi.action(\u0027promote\u0027)"},{"line_number":247,"context_line":"    def promote(self, req, id, body): # pylint: disable\u003dfunction-redefined  # noqa F811"},{"line_number":248,"context_line":"        # pylint: disable\u003dfunction-redefined  # noqa F811"},{"line_number":249,"context_line":"        return self._promote(req, id, body)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    @wsgi.Controller.api_version(\"2.75\")  # noqa"}],"source_content_type":"text/x-python","patch_set":5,"id":"e8627f30_f11c3b1a","line":248,"range":{"start_line":248,"start_character":0,"end_line":248,"end_character":57},"in_reply_to":"5a26929d_656b2407","updated":"2023-02-01 09:58:59.000000000","message":"Done","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"03a71a7306e5f68d0846865b766fc41619467a08","unresolved":true,"context_lines":[{"line_number":280,"context_line":"        if allow_quiesce_wait_time:"},{"line_number":281,"context_line":"            wait_time \u003d body.get(\u0027promote\u0027, {}).get(\u0027quiesce_wait_time\u0027)"},{"line_number":282,"context_line":"            if wait_time:"},{"line_number":283,"context_line":"                try:"},{"line_number":284,"context_line":"                    quiesce_wait_time \u003d int(wait_time)"},{"line_number":285,"context_line":"                except ValueError:"},{"line_number":286,"context_line":"                    msg \u003d _(\"Invalid value of quiesce_wait_time.\")"},{"line_number":287,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        try:"},{"line_number":290,"context_line":"            replica \u003d self.share_api.promote_share_replica("}],"source_content_type":"text/x-python","patch_set":5,"id":"d298beeb_c3472866","line":287,"range":{"start_line":283,"start_character":16,"end_line":287,"end_character":61},"updated":"2023-02-01 01:29:14.000000000","message":"Maybe we can use the following methods to make the code more concise\n\n    from oslo_utils import strutils\n    if not strutils.is_int_like(wait_time) or int(wait_time) \u003c\u003d 0:\n        msg \u003d _(\"quiesce_wait_time must be an integer and areater than 0.\")\n        raise exc.HTTPBadRequest(explanation\u003dmsg)","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8c8ad0f5478c003c82011c09e2c28e1e005d1430","unresolved":true,"context_lines":[{"line_number":280,"context_line":"        if allow_quiesce_wait_time:"},{"line_number":281,"context_line":"            wait_time \u003d body.get(\u0027promote\u0027, {}).get(\u0027quiesce_wait_time\u0027)"},{"line_number":282,"context_line":"            if wait_time:"},{"line_number":283,"context_line":"                try:"},{"line_number":284,"context_line":"                    quiesce_wait_time \u003d int(wait_time)"},{"line_number":285,"context_line":"                except ValueError:"},{"line_number":286,"context_line":"                    msg \u003d _(\"Invalid value of quiesce_wait_time.\")"},{"line_number":287,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        try:"},{"line_number":290,"context_line":"            replica \u003d self.share_api.promote_share_replica("}],"source_content_type":"text/x-python","patch_set":5,"id":"f079933b_5d094528","line":287,"range":{"start_line":283,"start_character":16,"end_line":287,"end_character":61},"in_reply_to":"d298beeb_c3472866","updated":"2023-02-01 01:30:27.000000000","message":"greater , not areater.","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ebc5db8665b3069b1f337157a66bbf9950472e6f","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        if allow_quiesce_wait_time:"},{"line_number":281,"context_line":"            wait_time \u003d body.get(\u0027promote\u0027, {}).get(\u0027quiesce_wait_time\u0027)"},{"line_number":282,"context_line":"            if wait_time:"},{"line_number":283,"context_line":"                try:"},{"line_number":284,"context_line":"                    quiesce_wait_time \u003d int(wait_time)"},{"line_number":285,"context_line":"                except ValueError:"},{"line_number":286,"context_line":"                    msg \u003d _(\"Invalid value of quiesce_wait_time.\")"},{"line_number":287,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        try:"},{"line_number":290,"context_line":"            replica \u003d self.share_api.promote_share_replica("}],"source_content_type":"text/x-python","patch_set":5,"id":"a85fc7de_0b318a9b","line":287,"range":{"start_line":283,"start_character":16,"end_line":287,"end_character":61},"in_reply_to":"f079933b_5d094528","updated":"2023-02-01 09:58:59.000000000","message":"Done","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6bb7bbe0dd659b80bf6b71253e58415ae78eec02","unresolved":true,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        quiesce_wait_time \u003d None"},{"line_number":280,"context_line":"        if allow_quiesce_wait_time:"},{"line_number":281,"context_line":"            wait_time \u003d body.get(\u0027promote\u0027, {}).get(\u0027quiesce_wait_time\u0027)"},{"line_number":282,"context_line":"            if wait_time:"},{"line_number":283,"context_line":"                if not strutils.is_int_like(wait_time) or int(wait_time) \u003c\u003d 0:"},{"line_number":284,"context_line":"                    msg \u003d _(\"quiesce_wait_time must be an integer and \""},{"line_number":285,"context_line":"                            \"greater than 0.\")"},{"line_number":286,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":287,"context_line":"                else:"},{"line_number":288,"context_line":"                    quiesce_wait_time \u003d int(wait_time)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        try:"},{"line_number":291,"context_line":"            replica \u003d self.share_api.promote_share_replica("}],"source_content_type":"text/x-python","patch_set":7,"id":"50a004f3_84c796e6","line":288,"range":{"start_line":281,"start_character":12,"end_line":288,"end_character":54},"updated":"2023-02-02 01:13:39.000000000","message":"Please add a UT for this new code. As the coverage shows [1] it is not being teste.\n\n[1]  https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_a61/868486/7/check/openstack-tox-cover/a611c29/cover/d_18fb795c8d5970e6_share_replicas_py.html#t284","commit_id":"e5ee2f7fabeead6e2c401b97fce1cbf28310e7ea"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4d89add7809f7a176da45ec9bbbd442b21d33520","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        quiesce_wait_time \u003d None"},{"line_number":280,"context_line":"        if allow_quiesce_wait_time:"},{"line_number":281,"context_line":"            wait_time \u003d body.get(\u0027promote\u0027, {}).get(\u0027quiesce_wait_time\u0027)"},{"line_number":282,"context_line":"            if wait_time:"},{"line_number":283,"context_line":"                if not strutils.is_int_like(wait_time) or int(wait_time) \u003c\u003d 0:"},{"line_number":284,"context_line":"                    msg \u003d _(\"quiesce_wait_time must be an integer and \""},{"line_number":285,"context_line":"                            \"greater than 0.\")"},{"line_number":286,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":287,"context_line":"                else:"},{"line_number":288,"context_line":"                    quiesce_wait_time \u003d int(wait_time)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        try:"},{"line_number":291,"context_line":"            replica \u003d self.share_api.promote_share_replica("}],"source_content_type":"text/x-python","patch_set":7,"id":"08cf5f85_2ab686b3","line":288,"range":{"start_line":281,"start_character":12,"end_line":288,"end_character":54},"in_reply_to":"50a004f3_84c796e6","updated":"2023-02-09 08:35:53.000000000","message":"Done","commit_id":"e5ee2f7fabeead6e2c401b97fce1cbf28310e7ea"}],"manila/share/api.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"e8c5d3659fa20acba017fde3f6f7da60b976ab99","unresolved":true,"context_lines":[{"line_number":874,"context_line":""},{"line_number":875,"context_line":"        self.share_rpcapi.promote_share_replica("},{"line_number":876,"context_line":"            context, share_replica,"},{"line_number":877,"context_line":"            quiesce_wait_time\u003dquiesce_wait_time)"},{"line_number":878,"context_line":""},{"line_number":879,"context_line":"        return self.db.share_replica_get(context, share_replica[\u0027id\u0027])"},{"line_number":880,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a5b0d35_c5f62a96","line":877,"range":{"start_line":877,"start_character":30,"end_line":877,"end_character":47},"updated":"2023-01-03 09:06:49.000000000","message":"if quiesce_wait_time is not None, \nwe need to make sure it is an int or can revert to int, \notherwise raise.","commit_id":"7b72342bb316198f848c7bfe3601de7946e5176a"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"204fd9e19c7ea447c3807da6af2f13dd380891fd","unresolved":false,"context_lines":[{"line_number":874,"context_line":""},{"line_number":875,"context_line":"        self.share_rpcapi.promote_share_replica("},{"line_number":876,"context_line":"            context, share_replica,"},{"line_number":877,"context_line":"            quiesce_wait_time\u003dquiesce_wait_time)"},{"line_number":878,"context_line":""},{"line_number":879,"context_line":"        return self.db.share_replica_get(context, share_replica[\u0027id\u0027])"},{"line_number":880,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6bc9c4f3_1d531a6e","line":877,"range":{"start_line":877,"start_character":30,"end_line":877,"end_character":47},"in_reply_to":"3a5b0d35_c5f62a96","updated":"2023-01-03 09:40:00.000000000","message":"Done","commit_id":"7b72342bb316198f848c7bfe3601de7946e5176a"}],"manila/share/drivers/huawei/huawei_nas.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6bb7bbe0dd659b80bf6b71253e58415ae78eec02","unresolved":true,"context_lines":[{"line_number":254,"context_line":"                                                share_server)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def promote_replica(self, context, replica_list, replica, access_rules,"},{"line_number":257,"context_line":"                        share_server\u003dNone, quiesce_wait_time\u003dNone):"},{"line_number":258,"context_line":"        \"\"\"Promote a replica to \u0027active\u0027 replica state..\"\"\""},{"line_number":259,"context_line":"        return self.plugin.promote_replica(context,"},{"line_number":260,"context_line":"                                           replica_list,"}],"source_content_type":"text/x-python","patch_set":7,"id":"8d425d89_476b65d8","line":257,"range":{"start_line":257,"start_character":26,"end_line":257,"end_character":59},"updated":"2023-02-02 01:13:39.000000000","message":"How did you test the huawei driver ? I haven\u0027t seen any CI results.","commit_id":"e5ee2f7fabeead6e2c401b97fce1cbf28310e7ea"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4d89add7809f7a176da45ec9bbbd442b21d33520","unresolved":true,"context_lines":[{"line_number":254,"context_line":"                                                share_server)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def promote_replica(self, context, replica_list, replica, access_rules,"},{"line_number":257,"context_line":"                        share_server\u003dNone, quiesce_wait_time\u003dNone):"},{"line_number":258,"context_line":"        \"\"\"Promote a replica to \u0027active\u0027 replica state..\"\"\""},{"line_number":259,"context_line":"        return self.plugin.promote_replica(context,"},{"line_number":260,"context_line":"                                           replica_list,"}],"source_content_type":"text/x-python","patch_set":7,"id":"61fca5c9_914bb88a","line":257,"range":{"start_line":257,"start_character":26,"end_line":257,"end_character":59},"in_reply_to":"8d425d89_476b65d8","updated":"2023-02-09 08:35:53.000000000","message":"For huawei driver, its No-Ops.","commit_id":"e5ee2f7fabeead6e2c401b97fce1cbf28310e7ea"}],"manila/share/drivers/netapp/dataontap/cluster_mode/data_motion.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6bb7bbe0dd659b80bf6b71253e58415ae78eec02","unresolved":true,"context_lines":[{"line_number":334,"context_line":"                                           dest_volume)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        config \u003d get_backend_configuration(dest_backend)"},{"line_number":337,"context_line":"        timeout \u003d max(5, config.netapp_snapmirror_quiesce_timeout)"},{"line_number":338,"context_line":"        if quiesce_wait_time:"},{"line_number":339,"context_line":"            timeout \u003d max(5, quiesce_wait_time)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        retries \u003d timeout / 5"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        @utils.retry(retry_param\u003dexception.ReplicationException,"},{"line_number":344,"context_line":"                     interval\u003d5,"}],"source_content_type":"text/x-python","patch_set":7,"id":"853186df_a25dbcd7","line":341,"range":{"start_line":337,"start_character":8,"end_line":341,"end_character":29},"updated":"2023-02-02 01:13:39.000000000","message":"I think you don\u0027t need to use the max logic with this extra if. It can be as simple as:\n\ntimeout \u003d quiesce_wait_time or config.netapp_snapmirror_quiesce_timeout\n\nretries \u003d int(timeout / 5) or 1","commit_id":"e5ee2f7fabeead6e2c401b97fce1cbf28310e7ea"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4d89add7809f7a176da45ec9bbbd442b21d33520","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                                           dest_volume)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        config \u003d get_backend_configuration(dest_backend)"},{"line_number":337,"context_line":"        timeout \u003d max(5, config.netapp_snapmirror_quiesce_timeout)"},{"line_number":338,"context_line":"        if quiesce_wait_time:"},{"line_number":339,"context_line":"            timeout \u003d max(5, quiesce_wait_time)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        retries \u003d timeout / 5"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        @utils.retry(retry_param\u003dexception.ReplicationException,"},{"line_number":344,"context_line":"                     interval\u003d5,"}],"source_content_type":"text/x-python","patch_set":7,"id":"75c57d30_3e293cec","line":341,"range":{"start_line":337,"start_character":8,"end_line":341,"end_character":29},"in_reply_to":"853186df_a25dbcd7","updated":"2023-02-09 08:35:53.000000000","message":"Done","commit_id":"e5ee2f7fabeead6e2c401b97fce1cbf28310e7ea"}],"manila/share/manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a960975cb3a848faa0041124015d547361466483","unresolved":true,"context_lines":[{"line_number":243,"context_line":"class ShareManager(manager.SchedulerDependentManager):"},{"line_number":244,"context_line":"    \"\"\"Manages NAS storages.\"\"\""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    RPC_API_VERSION \u003d \u00271.23\u0027"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def __init__(self, share_driver\u003dNone, service_name\u003dNone, *args, **kwargs):"},{"line_number":249,"context_line":"        \"\"\"Load the driver from args, or from flags.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"823ccb97_6a5bc8aa","line":246,"range":{"start_line":246,"start_character":0,"end_line":246,"end_character":28},"updated":"2023-01-31 23:43:30.000000000","message":"Use the new version here when you introduce one in share/rpcapi.py","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ebc5db8665b3069b1f337157a66bbf9950472e6f","unresolved":false,"context_lines":[{"line_number":243,"context_line":"class ShareManager(manager.SchedulerDependentManager):"},{"line_number":244,"context_line":"    \"\"\"Manages NAS storages.\"\"\""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    RPC_API_VERSION \u003d \u00271.23\u0027"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def __init__(self, share_driver\u003dNone, service_name\u003dNone, *args, **kwargs):"},{"line_number":249,"context_line":"        \"\"\"Load the driver from args, or from flags.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"6b00647f_3a6727f5","line":246,"range":{"start_line":246,"start_character":0,"end_line":246,"end_character":28},"in_reply_to":"823ccb97_6a5bc8aa","updated":"2023-02-01 09:58:59.000000000","message":"Done","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"}],"manila/share/rpcapi.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a960975cb3a848faa0041124015d547361466483","unresolved":true,"context_lines":[{"line_number":81,"context_line":"            and share_server_get_progress()"},{"line_number":82,"context_line":"        1.22 - Add update_share_network_security_service() and"},{"line_number":83,"context_line":"            check_update_share_network_security_service()"},{"line_number":84,"context_line":"        1.23 - Add update_share_server_network_allocations() and"},{"line_number":85,"context_line":"            check_update_share_server_network_allocations()"},{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    BASE_RPC_API_VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"500e38d1_0e8f1fe8","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":59},"updated":"2023-01-31 23:43:30.000000000","message":"RPC Calls are versioned. Your changes must come in a new version","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ebc5db8665b3069b1f337157a66bbf9950472e6f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            and share_server_get_progress()"},{"line_number":82,"context_line":"        1.22 - Add update_share_network_security_service() and"},{"line_number":83,"context_line":"            check_update_share_network_security_service()"},{"line_number":84,"context_line":"        1.23 - Add update_share_server_network_allocations() and"},{"line_number":85,"context_line":"            check_update_share_server_network_allocations()"},{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    BASE_RPC_API_VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"efbf09d6_c141eabc","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":59},"in_reply_to":"500e38d1_0e8f1fe8","updated":"2023-02-01 09:58:59.000000000","message":"Done","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a960975cb3a848faa0041124015d547361466483","unresolved":true,"context_lines":[{"line_number":377,"context_line":"    def promote_share_replica(self, context, share_replica,"},{"line_number":378,"context_line":"                              quiesce_wait_time\u003dNone):"},{"line_number":379,"context_line":"        host \u003d utils.extract_host(share_replica[\u0027host\u0027])"},{"line_number":380,"context_line":"        call_context \u003d self.client.prepare(server\u003dhost, version\u003d\u00271.8\u0027)"},{"line_number":381,"context_line":"        call_context.cast(context,"},{"line_number":382,"context_line":"                          \u0027promote_share_replica\u0027,"},{"line_number":383,"context_line":"                          share_replica_id\u003dshare_replica[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"bb5ecdee_8e287327","line":380,"range":{"start_line":380,"start_character":65,"end_line":380,"end_character":68},"updated":"2023-01-31 23:43:30.000000000","message":"This would be incorrect. Update the version, see comment above","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ebc5db8665b3069b1f337157a66bbf9950472e6f","unresolved":false,"context_lines":[{"line_number":377,"context_line":"    def promote_share_replica(self, context, share_replica,"},{"line_number":378,"context_line":"                              quiesce_wait_time\u003dNone):"},{"line_number":379,"context_line":"        host \u003d utils.extract_host(share_replica[\u0027host\u0027])"},{"line_number":380,"context_line":"        call_context \u003d self.client.prepare(server\u003dhost, version\u003d\u00271.8\u0027)"},{"line_number":381,"context_line":"        call_context.cast(context,"},{"line_number":382,"context_line":"                          \u0027promote_share_replica\u0027,"},{"line_number":383,"context_line":"                          share_replica_id\u003dshare_replica[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"1cf69ed3_21ab58ba","line":380,"range":{"start_line":380,"start_character":65,"end_line":380,"end_character":68},"in_reply_to":"bb5ecdee_8e287327","updated":"2023-02-01 09:58:59.000000000","message":"Done","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"}],"manila/tests/share/drivers/netapp/dataontap/cluster_mode/test_data_motion.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a960975cb3a848faa0041124015d547361466483","unresolved":true,"context_lines":[{"line_number":529,"context_line":"            quiesce_wait_time\u003dNone)"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        self.assertFalse(self.mock_dest_client.mount_volume.called)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def test_break_snapmirror_wait_for_quiesced(self):"},{"line_number":534,"context_line":"        self.mock_object(self.dm_session, \u0027quiesce_then_abort\u0027)"},{"line_number":535,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"378d64cf_ef3094ee","line":532,"updated":"2023-01-31 23:43:30.000000000","message":"Please test the use of the quiesce option, perhaps at least the following:\n\n1) quiesce API option taking precedence over the config option\n2) When either option is under 5 seconds, we assume 5 seconds to be the minimum and attempt the quiescing only once.","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ebc5db8665b3069b1f337157a66bbf9950472e6f","unresolved":false,"context_lines":[{"line_number":529,"context_line":"            quiesce_wait_time\u003dNone)"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        self.assertFalse(self.mock_dest_client.mount_volume.called)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def test_break_snapmirror_wait_for_quiesced(self):"},{"line_number":534,"context_line":"        self.mock_object(self.dm_session, \u0027quiesce_then_abort\u0027)"},{"line_number":535,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ca92b77c_6758e300","line":532,"in_reply_to":"378d64cf_ef3094ee","updated":"2023-02-01 09:58:59.000000000","message":"Done","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"}],"releasenotes/notes/add-quiesce-wait-time-to-promote-replica-0757f36d46304a93.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0911c9bb09f2659d3c6c8fa7405d1c0d0e2c1f05","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting with microversion 2.75, user can specify quiesce wait time"},{"line_number":5,"context_line":"    seconds in share replica promote API. Be aware that not all drivers"},{"line_number":6,"context_line":"    support this parameter, when not supported, the value would be silently"},{"line_number":7,"context_line":"    ignored."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"858f3f2a_c0748738","line":7,"range":{"start_line":4,"start_character":0,"end_line":7,"end_character":12},"updated":"2023-02-15 00:13:37.000000000","message":"Release notes can be added in a single file, there\u0027s no need to add a separate file for the NetApp note you\u0027ve added here: https://review.opendev.org/c/openstack/manila/+/868486/9/releasenotes/notes/bug-2000171-make-netapp_snapmirror_quiesce_timeout-end-user-option-4dc090eb7da3f7eb.yaml\n\n\nFrom my earlier comment, I suggested separating the NetApp change into its own Yaml item:\n\n ---\n features:\n   - |\n     Starting with microversion 2.75, user can specify quiesce wait time\n     seconds in share replica promote API. Be aware that not all drivers\n     support this parameter, when not supported, the value would be silently\n     ignored.\n   - | \n     When using the NetApp ONTAP storage backend, the quiesce timeout requested\n     with the \"promote\" API will take precedence over the\n     `netapp_snapsmirror_quiesce_timeout` configuration option. \n     For more details, please refer to `launchpad bug 2000171 \u003chttps://bugs.launchpad.net/manila/+bug/2000171\u003e`_","commit_id":"5f0f14a7f8b99ac008be4604bcaeec2dbc149d06"}],"releasenotes/notes/bug-2000171-make-netapp_snapmirror_quiesce_timeout-end-user-option-4dc090eb7da3f7eb.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a960975cb3a848faa0041124015d547361466483","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting microversion 2.75, user can specify quiesce wait time seconds in"},{"line_number":5,"context_line":"    share replica promote API. If not specified in the API call, NetApp ONTAP"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4d9fc607_bc504613","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2023-01-31 23:43:30.000000000","message":"features","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ebc5db8665b3069b1f337157a66bbf9950472e6f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting microversion 2.75, user can specify quiesce wait time seconds in"},{"line_number":5,"context_line":"    share replica promote API. If not specified in the API call, NetApp ONTAP"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"edc7fed7_c2c7603d","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"in_reply_to":"4d9fc607_bc504613","updated":"2023-02-01 09:58:59.000000000","message":"Done","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a960975cb3a848faa0041124015d547361466483","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting microversion 2.75, user can specify quiesce wait time seconds in"},{"line_number":5,"context_line":"    share replica promote API. If not specified in the API call, NetApp ONTAP"},{"line_number":6,"context_line":"    driver will use the value from `netapp_snapmirror_quiesce_timeout` config"},{"line_number":7,"context_line":"    option. For more details, please refer to"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1e469218_f56f277c","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":13},"updated":"2023-01-31 23:43:30.000000000","message":"with","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ebc5db8665b3069b1f337157a66bbf9950472e6f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting microversion 2.75, user can specify quiesce wait time seconds in"},{"line_number":5,"context_line":"    share replica promote API. If not specified in the API call, NetApp ONTAP"},{"line_number":6,"context_line":"    driver will use the value from `netapp_snapmirror_quiesce_timeout` config"},{"line_number":7,"context_line":"    option. For more details, please refer to"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d1254992_e5fea963","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":13},"in_reply_to":"1e469218_f56f277c","updated":"2023-02-01 09:58:59.000000000","message":"Done","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a960975cb3a848faa0041124015d547361466483","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting microversion 2.75, user can specify quiesce wait time seconds in"},{"line_number":5,"context_line":"    share replica promote API. If not specified in the API call, NetApp ONTAP"},{"line_number":6,"context_line":"    driver will use the value from `netapp_snapmirror_quiesce_timeout` config"},{"line_number":7,"context_line":"    option. For more details, please refer to"},{"line_number":8,"context_line":"    `launchpad bug 2000171 \u003chttps://bugs.launchpad.net/manila/+bug/2000171\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c278cb74_1371e4ff","line":5,"range":{"start_line":5,"start_character":29,"end_line":5,"end_character":30},"updated":"2023-01-31 23:43:30.000000000","message":"+ \". Be aware that not all drivers support this parameter, when not supported, the value would be silently ignored.\"","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ebc5db8665b3069b1f337157a66bbf9950472e6f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting microversion 2.75, user can specify quiesce wait time seconds in"},{"line_number":5,"context_line":"    share replica promote API. If not specified in the API call, NetApp ONTAP"},{"line_number":6,"context_line":"    driver will use the value from `netapp_snapmirror_quiesce_timeout` config"},{"line_number":7,"context_line":"    option. For more details, please refer to"},{"line_number":8,"context_line":"    `launchpad bug 2000171 \u003chttps://bugs.launchpad.net/manila/+bug/2000171\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b15d8b6c_5885c1b5","line":5,"range":{"start_line":5,"start_character":29,"end_line":5,"end_character":30},"in_reply_to":"c278cb74_1371e4ff","updated":"2023-02-01 09:58:59.000000000","message":"Done","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a960975cb3a848faa0041124015d547361466483","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting microversion 2.75, user can specify quiesce wait time seconds in"},{"line_number":5,"context_line":"    share replica promote API. If not specified in the API call, NetApp ONTAP"},{"line_number":6,"context_line":"    driver will use the value from `netapp_snapmirror_quiesce_timeout` config"},{"line_number":7,"context_line":"    option. For more details, please refer to"},{"line_number":8,"context_line":"    `launchpad bug 2000171 \u003chttps://bugs.launchpad.net/manila/+bug/2000171\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"aec3270b_a22beedd","line":8,"range":{"start_line":5,"start_character":31,"end_line":8,"end_character":77},"updated":"2023-01-31 23:43:30.000000000","message":"Please separate out the NetApp driver behavior into a different yaml item","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ebc5db8665b3069b1f337157a66bbf9950472e6f","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting microversion 2.75, user can specify quiesce wait time seconds in"},{"line_number":5,"context_line":"    share replica promote API. If not specified in the API call, NetApp ONTAP"},{"line_number":6,"context_line":"    driver will use the value from `netapp_snapmirror_quiesce_timeout` config"},{"line_number":7,"context_line":"    option. For more details, please refer to"},{"line_number":8,"context_line":"    `launchpad bug 2000171 \u003chttps://bugs.launchpad.net/manila/+bug/2000171\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f1215d3_c9d6abad","line":8,"range":{"start_line":5,"start_character":31,"end_line":8,"end_character":77},"in_reply_to":"aec3270b_a22beedd","updated":"2023-02-01 09:58:59.000000000","message":"you mean like updated patch ?","commit_id":"dcaaf1bb60d093113bfce2d852510965a276355d"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6bb7bbe0dd659b80bf6b71253e58415ae78eec02","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"     In case of NetApp ONTAP driver, if value is not specified, it will use"},{"line_number":5,"context_line":"     the value from `netapp_snapmirror_quiesce_timeout` config option. For"},{"line_number":6,"context_line":"     more details, please refer to"},{"line_number":7,"context_line":"    `launchpad bug 2000171 \u003chttps://bugs.launchpad.net/manila/+bug/2000171\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"6d75aec1_dcc1aa47","line":4,"range":{"start_line":4,"start_character":38,"end_line":4,"end_character":63},"updated":"2023-02-02 01:13:39.000000000","message":"which value ? The release notes are different, so each one should be understood by itself. The point here is that the NetApp driver can now set the quiesce timeout either during promote and this method has precedence over NetApp configuration `netapp_snapsmirror_quiesce_timeout`.","commit_id":"e5ee2f7fabeead6e2c401b97fce1cbf28310e7ea"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4d89add7809f7a176da45ec9bbbd442b21d33520","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"     In case of NetApp ONTAP driver, if value is not specified, it will use"},{"line_number":5,"context_line":"     the value from `netapp_snapmirror_quiesce_timeout` config option. For"},{"line_number":6,"context_line":"     more details, please refer to"},{"line_number":7,"context_line":"    `launchpad bug 2000171 \u003chttps://bugs.launchpad.net/manila/+bug/2000171\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"96d799ff_b171d9c5","line":4,"range":{"start_line":4,"start_character":38,"end_line":4,"end_character":63},"in_reply_to":"6d75aec1_dcc1aa47","updated":"2023-02-09 08:35:53.000000000","message":"Done","commit_id":"e5ee2f7fabeead6e2c401b97fce1cbf28310e7ea"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6bb7bbe0dd659b80bf6b71253e58415ae78eec02","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"     In case of NetApp ONTAP driver, if value is not specified, it will use"},{"line_number":5,"context_line":"     the value from `netapp_snapmirror_quiesce_timeout` config option. For"},{"line_number":6,"context_line":"     more details, please refer to"},{"line_number":7,"context_line":"    `launchpad bug 2000171 \u003chttps://bugs.launchpad.net/manila/+bug/2000171\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"87608c7d_406169c0","line":6,"range":{"start_line":4,"start_character":5,"end_line":6,"end_character":34},"updated":"2023-02-02 01:13:39.000000000","message":"I think that this block is shift right. Please, remove the first space of each line to be aligned with \"|\". The release job is failing.","commit_id":"e5ee2f7fabeead6e2c401b97fce1cbf28310e7ea"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4d89add7809f7a176da45ec9bbbd442b21d33520","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"     In case of NetApp ONTAP driver, if value is not specified, it will use"},{"line_number":5,"context_line":"     the value from `netapp_snapmirror_quiesce_timeout` config option. For"},{"line_number":6,"context_line":"     more details, please refer to"},{"line_number":7,"context_line":"    `launchpad bug 2000171 \u003chttps://bugs.launchpad.net/manila/+bug/2000171\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c35ee367_cb8c2133","line":6,"range":{"start_line":4,"start_character":5,"end_line":6,"end_character":34},"in_reply_to":"87608c7d_406169c0","updated":"2023-02-09 08:35:53.000000000","message":"Done","commit_id":"e5ee2f7fabeead6e2c401b97fce1cbf28310e7ea"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c45982c6179d967c4b43d353b7adca97ea96102","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In case of NetApp ONTAP driver, user can now set the quiesce timeout"},{"line_number":5,"context_line":"    during promote and this timeout has precedence over NetApp configuration"},{"line_number":6,"context_line":"    `netapp_snapsmirror_quiesce_timeout`. For more details, please refer to"},{"line_number":7,"context_line":"    `launchpad bug 2000171 \u003chttps://bugs.launchpad.net/manila/+bug/2000171\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"04ffe997_2ef5264d","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":41},"updated":"2023-02-14 01:51:25.000000000","message":"nit: maybe mention on which vesion this was enabled","commit_id":"5f0f14a7f8b99ac008be4604bcaeec2dbc149d06"}]}