)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"0e48a2dbf8520ec14a4448fb117e7c23c9ba9b32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8b4f42e6_46b3b88e","updated":"2023-02-10 15:17:58.000000000","message":"Thanks for this patch, Nahim. I\u0027ve pointed some small nit things. The rest LGTM.","commit_id":"aeba907089df1594c4ed6082a1bd83e5bcb600a6"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"332aab95_0326a2a4","updated":"2023-02-16 03:22:29.000000000","message":"Thanks Nahim and all. See my comments.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"828b4823_05c1df87","updated":"2023-02-15 06:10:29.000000000","message":"Thanks for the change, and for taking us through it through the collab review session. Please see comments inline. ","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4989bee320360d957a55d2c0ae9297cd8fe9232","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"edd7baf0_7e21f59c","updated":"2023-02-16 01:29:03.000000000","message":"Thanks for working on this change! Please take a look at the comments inline :)","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3622fdbf_5c89613a","updated":"2023-02-22 18:35:15.000000000","message":"Hello, everyone. Thank you so much for the reviews. I addressed your comments in the last patch.","commit_id":"a092c79f25afcb95089712d92e899a679e857871"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"fd20f0eac83a13911df9b82b258234eef5b1a8f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2612df12_d35528a4","updated":"2023-02-22 23:49:08.000000000","message":"It seems that the patch is ready to go.","commit_id":"a092c79f25afcb95089712d92e899a679e857871"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"83f92e5011b7d2825d8a6a587705372f57695691","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"384b0cce_525d7742","updated":"2023-02-23 22:09:55.000000000","message":"LGTM, lets get this in","commit_id":"a092c79f25afcb95089712d92e899a679e857871"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0448a9bd8187913c7083bc3318d951996862e802","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bd611f57_6dd2508e","updated":"2023-02-23 12:09:54.000000000","message":"Looking good - thank you for following up on comments.\nIt would be ideal to have the NetApp CI voting on this change and the test results with rest though.","commit_id":"a092c79f25afcb95089712d92e899a679e857871"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"986b9be3e5bf14c17298d7a7d0033162cf7af0e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f0ab0d2d_aca4eec9","updated":"2023-02-23 17:21:23.000000000","message":"NetApp CI results for REST API - it was executed on the patch that is on the top of the stack (downstream), containing all the code: \n\n- manila-tempest-plugin-ontap-dhss-rest https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/99/1699/35/downstream-experimental/manila-tempest-plugin-ontap-dhss-rest/715b676/ : SUCCESS in 1h 59m 09s\n\n- manila-tempest-plugin-ontap-no-dhss-rest https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/12/1712/1/downstream-experimental/manila-tempest-plugin-ontap-no-dhss-rest/f70dfc6/ : SUCCESS in 2h 23m 35s","commit_id":"a092c79f25afcb95089712d92e899a679e857871"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"ba3962d29b3df0174afa06dc58cee05bfa5337eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b71facaf_7a605799","in_reply_to":"bd611f57_6dd2508e","updated":"2023-02-23 17:30:06.000000000","message":"I think we dont need to run the CI on this specific patch. We can only run once with the top patch. I mean, if the NetApp CI succeed with [1], then, all REST changes are fine. Btw, it has passed there (REST and ZAPI).\n\n[1] https://review.opendev.org/c/openstack/manila/+/871105","commit_id":"a092c79f25afcb95089712d92e899a679e857871"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":5265,"context_line":"    def create_fpolicy_event(self, share_name, event_name, protocol,"},{"line_number":5266,"context_line":"                             file_operations):"},{"line_number":5267,"context_line":"        \"\"\"Creates a new fpolicy policy event."},{"line_number":5268,"context_line":""},{"line_number":5269,"context_line":"        :param event_name: name of the new fpolicy event"},{"line_number":5270,"context_line":"        :param protocol: name of protocol for which event is created. Possible"},{"line_number":5271,"context_line":"            values are: \u0027nfsv3\u0027, \u0027nfsv4\u0027 or \u0027cifs\u0027."}],"source_content_type":"text/x-python","patch_set":5,"id":"4dac66de_46ff8f9e","line":5268,"updated":"2023-02-15 06:10:29.000000000","message":"missing parameter doc for \"share_name\"","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":5265,"context_line":"    def create_fpolicy_event(self, share_name, event_name, protocol,"},{"line_number":5266,"context_line":"                             file_operations):"},{"line_number":5267,"context_line":"        \"\"\"Creates a new fpolicy policy event."},{"line_number":5268,"context_line":""},{"line_number":5269,"context_line":"        :param event_name: name of the new fpolicy event"},{"line_number":5270,"context_line":"        :param protocol: name of protocol for which event is created. Possible"},{"line_number":5271,"context_line":"            values are: \u0027nfsv3\u0027, \u0027nfsv4\u0027 or \u0027cifs\u0027."}],"source_content_type":"text/x-python","patch_set":5,"id":"d62c2d36_8bf32c82","line":5268,"in_reply_to":"4dac66de_46ff8f9e","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":5284,"context_line":""},{"line_number":5285,"context_line":"    def delete_fpolicy_event(self, share_name, event_name):"},{"line_number":5286,"context_line":"        \"\"\"Deletes a fpolicy policy event."},{"line_number":5287,"context_line":""},{"line_number":5288,"context_line":"        :param event_name: name of the event to be deleted"},{"line_number":5289,"context_line":"        \"\"\""},{"line_number":5290,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"4a294450_2cec6a6a","line":5287,"updated":"2023-02-15 06:10:29.000000000","message":"missing parameter doc for \"share_name\"","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":5284,"context_line":""},{"line_number":5285,"context_line":"    def delete_fpolicy_event(self, share_name, event_name):"},{"line_number":5286,"context_line":"        \"\"\"Deletes a fpolicy policy event."},{"line_number":5287,"context_line":""},{"line_number":5288,"context_line":"        :param event_name: name of the event to be deleted"},{"line_number":5289,"context_line":"        \"\"\""},{"line_number":5290,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"34cf85d4_c132c6b5","line":5287,"in_reply_to":"4a294450_2cec6a6a","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":5357,"context_line":"    def create_fpolicy_policy(self, fpolicy_name, share_name, events,"},{"line_number":5358,"context_line":"                              engine\u003d\u0027native\u0027):"},{"line_number":5359,"context_line":"        \"\"\"Creates a fpolicy policy resource."},{"line_number":5360,"context_line":""},{"line_number":5361,"context_line":"        :param fpolicy_name: name of the fpolicy policy to be created."},{"line_number":5362,"context_line":"        :param events: list of event names for file access monitoring."},{"line_number":5363,"context_line":"        :param engine: name of the engine to be used."}],"source_content_type":"text/x-python","patch_set":5,"id":"c5f35e3e_810f3a3a","line":5360,"updated":"2023-02-15 06:10:29.000000000","message":"missing parameter doc for \"share_name\"","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":5357,"context_line":"    def create_fpolicy_policy(self, fpolicy_name, share_name, events,"},{"line_number":5358,"context_line":"                              engine\u003d\u0027native\u0027):"},{"line_number":5359,"context_line":"        \"\"\"Creates a fpolicy policy resource."},{"line_number":5360,"context_line":""},{"line_number":5361,"context_line":"        :param fpolicy_name: name of the fpolicy policy to be created."},{"line_number":5362,"context_line":"        :param events: list of event names for file access monitoring."},{"line_number":5363,"context_line":"        :param engine: name of the engine to be used."}],"source_content_type":"text/x-python","patch_set":5,"id":"323b2725_deb9c779","line":5360,"in_reply_to":"c5f35e3e_810f3a3a","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":5391,"context_line":"    def get_fpolicy_policies(self, share_name, policy_name\u003dNone,"},{"line_number":5392,"context_line":"                             engine_name\u003d\u0027native\u0027, event_names\u003d[]):"},{"line_number":5393,"context_line":"        \"\"\"Retrieve one or more fpolicy policies."},{"line_number":5394,"context_line":""},{"line_number":5395,"context_line":"        :param policy_name: name of the policy to be retrieved"},{"line_number":5396,"context_line":"        :param engine_name: name of the engine"},{"line_number":5397,"context_line":"        :param event_names: list of event names that must be associated to the"}],"source_content_type":"text/x-python","patch_set":5,"id":"f87de566_ae565c06","line":5394,"updated":"2023-02-15 06:10:29.000000000","message":"missing parameter doc for \"share_name\"","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":5391,"context_line":"    def get_fpolicy_policies(self, share_name, policy_name\u003dNone,"},{"line_number":5392,"context_line":"                             engine_name\u003d\u0027native\u0027, event_names\u003d[]):"},{"line_number":5393,"context_line":"        \"\"\"Retrieve one or more fpolicy policies."},{"line_number":5394,"context_line":""},{"line_number":5395,"context_line":"        :param policy_name: name of the policy to be retrieved"},{"line_number":5396,"context_line":"        :param engine_name: name of the engine"},{"line_number":5397,"context_line":"        :param event_names: list of event names that must be associated to the"}],"source_content_type":"text/x-python","patch_set":5,"id":"c972129b_2ac09c62","line":5394,"in_reply_to":"f87de566_ae565c06","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":5476,"context_line":"                             shares_to_include\u003d[], extensions_to_include\u003dNone,"},{"line_number":5477,"context_line":"                             extensions_to_exclude\u003dNone):"},{"line_number":5478,"context_line":"        \"\"\"Modify an existing fpolicy scope."},{"line_number":5479,"context_line":""},{"line_number":5480,"context_line":"        :param policy_name: name of the policy associated to the scope."},{"line_number":5481,"context_line":"        :param shares_to_include: list of shares to include for file access"},{"line_number":5482,"context_line":"            monitoring."}],"source_content_type":"text/x-python","patch_set":5,"id":"3001c075_a3825f63","line":5479,"updated":"2023-02-15 06:10:29.000000000","message":"missing parameter doc for \"share_name\"","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":5476,"context_line":"                             shares_to_include\u003d[], extensions_to_include\u003dNone,"},{"line_number":5477,"context_line":"                             extensions_to_exclude\u003dNone):"},{"line_number":5478,"context_line":"        \"\"\"Modify an existing fpolicy scope."},{"line_number":5479,"context_line":""},{"line_number":5480,"context_line":"        :param policy_name: name of the policy associated to the scope."},{"line_number":5481,"context_line":"        :param shares_to_include: list of shares to include for file access"},{"line_number":5482,"context_line":"            monitoring."}],"source_content_type":"text/x-python","patch_set":5,"id":"351f829e_7de0f9ab","line":5479,"in_reply_to":"3001c075_a3825f63","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":5530,"context_line":"                           shares_to_include\u003dNone):"},{"line_number":5531,"context_line":"        \"\"\"Retrieve fpolicy scopes."},{"line_number":5532,"context_line":""},{"line_number":5533,"context_line":"        :param policy_name: name of the policy associated with a scope."},{"line_number":5534,"context_line":"        :param extensions_to_include: file extensions included for screening."},{"line_number":5535,"context_line":"            Values should be provided as comma separated list"},{"line_number":5536,"context_line":"        :param extensions_to_exclude: file extensions excluded for screening."}],"source_content_type":"text/x-python","patch_set":5,"id":"b82bb608_7c1612b2","line":5533,"updated":"2023-02-15 06:10:29.000000000","message":"missing parameter doc for \"share_name\"","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":5530,"context_line":"                           shares_to_include\u003dNone):"},{"line_number":5531,"context_line":"        \"\"\"Retrieve fpolicy scopes."},{"line_number":5532,"context_line":""},{"line_number":5533,"context_line":"        :param policy_name: name of the policy associated with a scope."},{"line_number":5534,"context_line":"        :param extensions_to_include: file extensions included for screening."},{"line_number":5535,"context_line":"            Values should be provided as comma separated list"},{"line_number":5536,"context_line":"        :param extensions_to_exclude: file extensions excluded for screening."}],"source_content_type":"text/x-python","patch_set":5,"id":"09ede176_70568e88","line":5533,"in_reply_to":"b82bb608_7c1612b2","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":5602,"context_line":""},{"line_number":5603,"context_line":"    def enable_fpolicy_policy(self, share_name, policy_name, sequence_number):"},{"line_number":5604,"context_line":"        \"\"\"Enables a specific named policy."},{"line_number":5605,"context_line":""},{"line_number":5606,"context_line":"        :param policy_name: name of the policy to be enabled"},{"line_number":5607,"context_line":"        :param sequence_number: policy sequence number"},{"line_number":5608,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"2af5f880_36ea4366","line":5605,"updated":"2023-02-15 06:10:29.000000000","message":"missing parameter doc for \"share_name\"","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":5602,"context_line":""},{"line_number":5603,"context_line":"    def enable_fpolicy_policy(self, share_name, policy_name, sequence_number):"},{"line_number":5604,"context_line":"        \"\"\"Enables a specific named policy."},{"line_number":5605,"context_line":""},{"line_number":5606,"context_line":"        :param policy_name: name of the policy to be enabled"},{"line_number":5607,"context_line":"        :param sequence_number: policy sequence number"},{"line_number":5608,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"aad43239_b11e39fb","line":5605,"in_reply_to":"2af5f880_36ea4366","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"0e48a2dbf8520ec14a4448fb117e7c23c9ba9b32","unresolved":true,"context_lines":[{"line_number":673,"context_line":"            self.send_request(\u0027/protocols/nfs/export-policies\u0027, \u0027post\u0027,"},{"line_number":674,"context_line":"                              body\u003dbody)"},{"line_number":675,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":676,"context_line":"            if e.code !\u003d netapp_api.REST_DUPLICATE_ENTRY:"},{"line_number":677,"context_line":"                raise"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":4,"id":"f4611aa8_4e5260d3","line":676,"updated":"2023-02-10 15:17:58.000000000","message":"nit: Log message for mapped error code will help in future debugs, as done in \"delete_fpolicy_event\" function.","commit_id":"aeba907089df1594c4ed6082a1bd83e5bcb600a6"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":673,"context_line":"            self.send_request(\u0027/protocols/nfs/export-policies\u0027, \u0027post\u0027,"},{"line_number":674,"context_line":"                              body\u003dbody)"},{"line_number":675,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":676,"context_line":"            if e.code !\u003d netapp_api.REST_DUPLICATE_ENTRY:"},{"line_number":677,"context_line":"                raise"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":4,"id":"2e734b4b_d2d4714b","line":676,"in_reply_to":"a351f59f_9e484ec4","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"aeba907089df1594c4ed6082a1bd83e5bcb600a6"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":673,"context_line":"            self.send_request(\u0027/protocols/nfs/export-policies\u0027, \u0027post\u0027,"},{"line_number":674,"context_line":"                              body\u003dbody)"},{"line_number":675,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":676,"context_line":"            if e.code !\u003d netapp_api.REST_DUPLICATE_ENTRY:"},{"line_number":677,"context_line":"                raise"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":4,"id":"a351f59f_9e484ec4","line":676,"in_reply_to":"f4611aa8_4e5260d3","updated":"2023-02-16 03:22:29.000000000","message":"+1 thiago. Log.debug()","commit_id":"aeba907089df1594c4ed6082a1bd83e5bcb600a6"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"0e48a2dbf8520ec14a4448fb117e7c23c9ba9b32","unresolved":true,"context_lines":[{"line_number":683,"context_line":"        except netapp_api.api.NaApiError:"},{"line_number":684,"context_line":"            # NOTE(cknight): Policy deletion can fail if called too soon after"},{"line_number":685,"context_line":"            # removing from a flexvol.  So rename for later harvesting."},{"line_number":686,"context_line":"            self.rename_nfs_export_policy(policy_name,"},{"line_number":687,"context_line":"                                          DELETED_PREFIX + policy_name)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":4,"id":"bbd62807_5945eff5","line":686,"updated":"2023-02-10 15:17:58.000000000","message":"nit: Maybe it should be logged, since the delete operation failed and the object will be renamed instead of deleted?","commit_id":"aeba907089df1594c4ed6082a1bd83e5bcb600a6"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":683,"context_line":"        except netapp_api.api.NaApiError:"},{"line_number":684,"context_line":"            # NOTE(cknight): Policy deletion can fail if called too soon after"},{"line_number":685,"context_line":"            # removing from a flexvol.  So rename for later harvesting."},{"line_number":686,"context_line":"            self.rename_nfs_export_policy(policy_name,"},{"line_number":687,"context_line":"                                          DELETED_PREFIX + policy_name)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":4,"id":"f1252981_fbed668e","line":686,"in_reply_to":"bbd62807_5945eff5","updated":"2023-02-16 03:22:29.000000000","message":"+1 thiago. LOG.warning() ?","commit_id":"aeba907089df1594c4ed6082a1bd83e5bcb600a6"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        except netapp_api.api.NaApiError:"},{"line_number":684,"context_line":"            # NOTE(cknight): Policy deletion can fail if called too soon after"},{"line_number":685,"context_line":"            # removing from a flexvol.  So rename for later harvesting."},{"line_number":686,"context_line":"            self.rename_nfs_export_policy(policy_name,"},{"line_number":687,"context_line":"                                          DELETED_PREFIX + policy_name)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ad34cdf_d81adffa","line":686,"in_reply_to":"f1252981_fbed668e","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"aeba907089df1594c4ed6082a1bd83e5bcb600a6"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"0e48a2dbf8520ec14a4448fb117e7c23c9ba9b32","unresolved":true,"context_lines":[{"line_number":2331,"context_line":"                self.send_request(f\u0027/protocols/nfs/export-policies/{uuid}/rules/\\"},{"line_number":2332,"context_line":"                          {rule_index}\u0027, \u0027delete\u0027, body\u003dbody)"},{"line_number":2333,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":2334,"context_line":"                if e.code !\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":2335,"context_line":"                    raise"},{"line_number":2336,"context_line":""},{"line_number":2337,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":4,"id":"aff949fa_c4be7f3d","line":2334,"updated":"2023-02-10 15:17:58.000000000","message":"nit: Log message for mapped error code will help in future debugs, as done in \"delete_fpolicy_event\" function.","commit_id":"aeba907089df1594c4ed6082a1bd83e5bcb600a6"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":2331,"context_line":"                self.send_request(f\u0027/protocols/nfs/export-policies/{uuid}/rules/\\"},{"line_number":2332,"context_line":"                          {rule_index}\u0027, \u0027delete\u0027, body\u003dbody)"},{"line_number":2333,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":2334,"context_line":"                if e.code !\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":2335,"context_line":"                    raise"},{"line_number":2336,"context_line":""},{"line_number":2337,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":4,"id":"db4a20a6_21d775d1","line":2334,"in_reply_to":"aff949fa_c4be7f3d","updated":"2023-02-16 03:22:29.000000000","message":"+1","commit_id":"aeba907089df1594c4ed6082a1bd83e5bcb600a6"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2331,"context_line":"                self.send_request(f\u0027/protocols/nfs/export-policies/{uuid}/rules/\\"},{"line_number":2332,"context_line":"                          {rule_index}\u0027, \u0027delete\u0027, body\u003dbody)"},{"line_number":2333,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":2334,"context_line":"                if e.code !\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":2335,"context_line":"                    raise"},{"line_number":2336,"context_line":""},{"line_number":2337,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":4,"id":"57b8a2b4_5a8ee179","line":2334,"in_reply_to":"db4a20a6_21d775d1","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"aeba907089df1594c4ed6082a1bd83e5bcb600a6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fe7c1dd1_609679b5","updated":"2023-02-15 06:10:29.000000000","message":"The unit test coverage for this file: https://0755be101755fc07a36f-af919829f86b35e971243ef9572b928e.ssl.cf2.rackcdn.com/871103/5/check/openstack-tox-cover/fbe9597/cover/d_64027f75effc2ad2_client_cmode_rest_py.html\n\n72% is low; can we improve this?","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"439b2cc2_d97ec2ac","in_reply_to":"fe7c1dd1_609679b5","updated":"2023-02-22 18:35:15.000000000","message":"I agree, we will try to improve this in the next patch set. If this is not possible in time for the FF, we can provide a follow up patch for the UTs.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        :param job_uuid: uuid of the job to be searched."},{"line_number":246,"context_line":"        \"\"\""},{"line_number":247,"context_line":"        action_url \u003d \u0027/cluster/jobs/%s\u0027 % job_uuid"},{"line_number":248,"context_line":"        return self.send_request(action_url, \u0027get\u0027, enable_tunneling\u003dFalse)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def _has_records(self, api_result_element):"}],"source_content_type":"text/x-python","patch_set":5,"id":"52009c0f_4400033c","line":247,"range":{"start_line":247,"start_character":21,"end_line":247,"end_character":50},"updated":"2023-02-16 03:22:29.000000000","message":"f\u0027/cluster/jobs/{job_uuid}\u0027","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        :param job_uuid: uuid of the job to be searched."},{"line_number":246,"context_line":"        \"\"\""},{"line_number":247,"context_line":"        action_url \u003d \u0027/cluster/jobs/%s\u0027 % job_uuid"},{"line_number":248,"context_line":"        return self.send_request(action_url, \u0027get\u0027, enable_tunneling\u003dFalse)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def _has_records(self, api_result_element):"}],"source_content_type":"text/x-python","patch_set":5,"id":"e9d28f38_536a2b48","line":247,"range":{"start_line":247,"start_character":21,"end_line":247,"end_character":50},"in_reply_to":"52009c0f_4400033c","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":247,"context_line":"        action_url \u003d \u0027/cluster/jobs/%s\u0027 % job_uuid"},{"line_number":248,"context_line":"        return self.send_request(action_url, \u0027get\u0027, enable_tunneling\u003dFalse)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def _has_records(self, api_result_element):"},{"line_number":251,"context_line":"        if (not api_result_element[\u0027num_records\u0027] or"},{"line_number":252,"context_line":"                api_result_element[\u0027num_records\u0027] \u003d\u003d 0):"},{"line_number":253,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"8f1db9d4_4805a3d0","line":250,"range":{"start_line":250,"start_character":8,"end_line":250,"end_character":20},"updated":"2023-02-16 03:22:29.000000000","message":"add method documentation","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":247,"context_line":"        action_url \u003d \u0027/cluster/jobs/%s\u0027 % job_uuid"},{"line_number":248,"context_line":"        return self.send_request(action_url, \u0027get\u0027, enable_tunneling\u003dFalse)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def _has_records(self, api_result_element):"},{"line_number":251,"context_line":"        if (not api_result_element[\u0027num_records\u0027] or"},{"line_number":252,"context_line":"                api_result_element[\u0027num_records\u0027] \u003d\u003d 0):"},{"line_number":253,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"e23fae90_7df89878","line":250,"range":{"start_line":250,"start_character":27,"end_line":250,"end_character":45},"updated":"2023-02-16 03:22:29.000000000","message":"zapi variable name, please avoid zapi words. Maybe: response ?","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"bc50959a6e8d464fa71fb8eac518d19153f65f15","unresolved":true,"context_lines":[{"line_number":247,"context_line":"        action_url \u003d \u0027/cluster/jobs/%s\u0027 % job_uuid"},{"line_number":248,"context_line":"        return self.send_request(action_url, \u0027get\u0027, enable_tunneling\u003dFalse)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def _has_records(self, api_result_element):"},{"line_number":251,"context_line":"        if (not api_result_element[\u0027num_records\u0027] or"},{"line_number":252,"context_line":"                api_result_element[\u0027num_records\u0027] \u003d\u003d 0):"},{"line_number":253,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ff61482_461bf89b","line":250,"range":{"start_line":250,"start_character":8,"end_line":250,"end_character":20},"in_reply_to":"8f1db9d4_4805a3d0","updated":"2023-02-16 12:25:37.000000000","message":"@na_utils.trace","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        action_url \u003d \u0027/cluster/jobs/%s\u0027 % job_uuid"},{"line_number":248,"context_line":"        return self.send_request(action_url, \u0027get\u0027, enable_tunneling\u003dFalse)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def _has_records(self, api_result_element):"},{"line_number":251,"context_line":"        if (not api_result_element[\u0027num_records\u0027] or"},{"line_number":252,"context_line":"                api_result_element[\u0027num_records\u0027] \u003d\u003d 0):"},{"line_number":253,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"97644c08_bdf4b9dc","line":250,"range":{"start_line":250,"start_character":8,"end_line":250,"end_character":20},"in_reply_to":"9ff61482_461bf89b","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        action_url \u003d \u0027/cluster/jobs/%s\u0027 % job_uuid"},{"line_number":248,"context_line":"        return self.send_request(action_url, \u0027get\u0027, enable_tunneling\u003dFalse)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def _has_records(self, api_result_element):"},{"line_number":251,"context_line":"        if (not api_result_element[\u0027num_records\u0027] or"},{"line_number":252,"context_line":"                api_result_element[\u0027num_records\u0027] \u003d\u003d 0):"},{"line_number":253,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"2fe434bc_3b48681b","line":250,"range":{"start_line":250,"start_character":27,"end_line":250,"end_character":45},"in_reply_to":"e23fae90_7df89878","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":255,"context_line":"            return True"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @na_utils.trace"},{"line_number":258,"context_line":"    def get_licenses(self):"},{"line_number":259,"context_line":"        try:"},{"line_number":260,"context_line":"            result \u003d self.send_request(\u0027/cluster/licensing/licenses\u0027, \u0027get\u0027)"},{"line_number":261,"context_line":"        except netapp_api.api.NaApiError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"0a30494d_796e5430","line":258,"range":{"start_line":258,"start_character":8,"end_line":258,"end_character":20},"updated":"2023-02-16 03:22:29.000000000","message":"add method documentation","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            return True"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @na_utils.trace"},{"line_number":258,"context_line":"    def get_licenses(self):"},{"line_number":259,"context_line":"        try:"},{"line_number":260,"context_line":"            result \u003d self.send_request(\u0027/cluster/licensing/licenses\u0027, \u0027get\u0027)"},{"line_number":261,"context_line":"        except netapp_api.api.NaApiError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"eecfa3a0_b2809240","line":258,"range":{"start_line":258,"start_character":8,"end_line":258,"end_character":20},"in_reply_to":"0a30494d_796e5430","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":260,"context_line":"            result \u003d self.send_request(\u0027/cluster/licensing/licenses\u0027, \u0027get\u0027)"},{"line_number":261,"context_line":"        except netapp_api.api.NaApiError:"},{"line_number":262,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":263,"context_line":"                LOG.exception(\"Could not get licenses list.\")"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        return sorted("},{"line_number":266,"context_line":"            [license[\u0027name\u0027] for license in result.get(\u0027records\u0027, [])])"}],"source_content_type":"text/x-python","patch_set":5,"id":"ddbc0320_057eefea","line":263,"range":{"start_line":263,"start_character":45,"end_line":263,"end_character":58},"updated":"2023-02-15 06:10:29.000000000","message":"nit: list of ONTAP licenses","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            result \u003d self.send_request(\u0027/cluster/licensing/licenses\u0027, \u0027get\u0027)"},{"line_number":261,"context_line":"        except netapp_api.api.NaApiError:"},{"line_number":262,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":263,"context_line":"                LOG.exception(\"Could not get licenses list.\")"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        return sorted("},{"line_number":266,"context_line":"            [license[\u0027name\u0027] for license in result.get(\u0027records\u0027, [])])"}],"source_content_type":"text/x-python","patch_set":5,"id":"622ebdd2_1ede69d2","line":263,"range":{"start_line":263,"start_character":45,"end_line":263,"end_character":58},"in_reply_to":"ddbc0320_057eefea","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":274,"context_line":"        version \u003d system_version.get(\u0027version\u0027)"},{"line_number":275,"context_line":"        version_tuple \u003d system_version.get(\u0027version-tuple\u0027)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        # NVE requires an ONTAP version \u003e\u003d 9.1. Also, not all platforms"},{"line_number":278,"context_line":"        # support this feature. NVE is not supported if the version"},{"line_number":279,"context_line":"        # includes the substring \u0027\u003c1no-DARE\u003e\u0027 (no Data At Rest Encryption)."},{"line_number":280,"context_line":"        if version_tuple \u003e\u003d (9, 1, 0) and \"\u003c1no-DARE\u003e\" not in version:"}],"source_content_type":"text/x-python","patch_set":5,"id":"e257a1fe_e5db00c1","line":277,"range":{"start_line":277,"start_character":10,"end_line":277,"end_character":54},"updated":"2023-02-16 03:22:29.000000000","message":"it can be removed","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        version \u003d system_version.get(\u0027version\u0027)"},{"line_number":275,"context_line":"        version_tuple \u003d system_version.get(\u0027version-tuple\u0027)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        # NVE requires an ONTAP version \u003e\u003d 9.1. Also, not all platforms"},{"line_number":278,"context_line":"        # support this feature. NVE is not supported if the version"},{"line_number":279,"context_line":"        # includes the substring \u0027\u003c1no-DARE\u003e\u0027 (no Data At Rest Encryption)."},{"line_number":280,"context_line":"        if version_tuple \u003e\u003d (9, 1, 0) and \"\u003c1no-DARE\u003e\" not in version:"}],"source_content_type":"text/x-python","patch_set":5,"id":"a76fc76e_2df8c54a","line":277,"range":{"start_line":277,"start_character":10,"end_line":277,"end_character":54},"in_reply_to":"e257a1fe_e5db00c1","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":277,"context_line":"        # NVE requires an ONTAP version \u003e\u003d 9.1. Also, not all platforms"},{"line_number":278,"context_line":"        # support this feature. NVE is not supported if the version"},{"line_number":279,"context_line":"        # includes the substring \u0027\u003c1no-DARE\u003e\u0027 (no Data At Rest Encryption)."},{"line_number":280,"context_line":"        if version_tuple \u003e\u003d (9, 1, 0) and \"\u003c1no-DARE\u003e\" not in version:"},{"line_number":281,"context_line":"            if nodes is not None:"},{"line_number":282,"context_line":"                # (caiquemello) Does not have equivalent in REST"},{"line_number":283,"context_line":"                return self.get_security_key_manager_nve_support(nodes[0])"}],"source_content_type":"text/x-python","patch_set":5,"id":"42d547e8_6e56f0f0","line":280,"range":{"start_line":280,"start_character":11,"end_line":280,"end_character":37},"updated":"2023-02-15 06:10:29.000000000","message":"doesn\u0027t matter with this client?","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":277,"context_line":"        # NVE requires an ONTAP version \u003e\u003d 9.1. Also, not all platforms"},{"line_number":278,"context_line":"        # support this feature. NVE is not supported if the version"},{"line_number":279,"context_line":"        # includes the substring \u0027\u003c1no-DARE\u003e\u0027 (no Data At Rest Encryption)."},{"line_number":280,"context_line":"        if version_tuple \u003e\u003d (9, 1, 0) and \"\u003c1no-DARE\u003e\" not in version:"},{"line_number":281,"context_line":"            if nodes is not None:"},{"line_number":282,"context_line":"                # (caiquemello) Does not have equivalent in REST"},{"line_number":283,"context_line":"                return self.get_security_key_manager_nve_support(nodes[0])"}],"source_content_type":"text/x-python","patch_set":5,"id":"92ed4c41_aa887641","line":280,"range":{"start_line":280,"start_character":11,"end_line":280,"end_character":37},"in_reply_to":"42d547e8_6e56f0f0","updated":"2023-02-16 03:22:29.000000000","message":"Good catch! The REST client is always 9.11.1 or higher.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        # NVE requires an ONTAP version \u003e\u003d 9.1. Also, not all platforms"},{"line_number":278,"context_line":"        # support this feature. NVE is not supported if the version"},{"line_number":279,"context_line":"        # includes the substring \u0027\u003c1no-DARE\u003e\u0027 (no Data At Rest Encryption)."},{"line_number":280,"context_line":"        if version_tuple \u003e\u003d (9, 1, 0) and \"\u003c1no-DARE\u003e\" not in version:"},{"line_number":281,"context_line":"            if nodes is not None:"},{"line_number":282,"context_line":"                # (caiquemello) Does not have equivalent in REST"},{"line_number":283,"context_line":"                return self.get_security_key_manager_nve_support(nodes[0])"}],"source_content_type":"text/x-python","patch_set":5,"id":"1be54eac_ce795d47","line":280,"range":{"start_line":280,"start_character":11,"end_line":280,"end_character":37},"in_reply_to":"92ed4c41_aa887641","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":280,"context_line":"        if version_tuple \u003e\u003d (9, 1, 0) and \"\u003c1no-DARE\u003e\" not in version:"},{"line_number":281,"context_line":"            if nodes is not None:"},{"line_number":282,"context_line":"                # (caiquemello) Does not have equivalent in REST"},{"line_number":283,"context_line":"                return self.get_security_key_manager_nve_support(nodes[0])"},{"line_number":284,"context_line":"            else:"},{"line_number":285,"context_line":"                LOG.debug(\u0027Cluster credentials are required in order to \u0027"},{"line_number":286,"context_line":"                          \u0027determine whether NetApp Volume Encryption is \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"79bf9e82_2b2e544f","line":283,"range":{"start_line":283,"start_character":0,"end_line":283,"end_character":74},"updated":"2023-02-15 06:10:29.000000000","message":"As we discussed on the collab-review call; stuff like this can be called out in the \"issues\" section of a release note; beyond NetApp OpenStack documentation..","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4989bee320360d957a55d2c0ae9297cd8fe9232","unresolved":true,"context_lines":[{"line_number":280,"context_line":"        if version_tuple \u003e\u003d (9, 1, 0) and \"\u003c1no-DARE\u003e\" not in version:"},{"line_number":281,"context_line":"            if nodes is not None:"},{"line_number":282,"context_line":"                # (caiquemello) Does not have equivalent in REST"},{"line_number":283,"context_line":"                return self.get_security_key_manager_nve_support(nodes[0])"},{"line_number":284,"context_line":"            else:"},{"line_number":285,"context_line":"                LOG.debug(\u0027Cluster credentials are required in order to \u0027"},{"line_number":286,"context_line":"                          \u0027determine whether NetApp Volume Encryption is \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"fe66648b_9eedd0e9","line":283,"range":{"start_line":283,"start_character":0,"end_line":283,"end_character":74},"in_reply_to":"79bf9e82_2b2e544f","updated":"2023-02-16 01:29:03.000000000","message":"+1","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        if version_tuple \u003e\u003d (9, 1, 0) and \"\u003c1no-DARE\u003e\" not in version:"},{"line_number":281,"context_line":"            if nodes is not None:"},{"line_number":282,"context_line":"                # (caiquemello) Does not have equivalent in REST"},{"line_number":283,"context_line":"                return self.get_security_key_manager_nve_support(nodes[0])"},{"line_number":284,"context_line":"            else:"},{"line_number":285,"context_line":"                LOG.debug(\u0027Cluster credentials are required in order to \u0027"},{"line_number":286,"context_line":"                          \u0027determine whether NetApp Volume Encryption is \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1444c90c_3b4b53ad","line":283,"range":{"start_line":283,"start_character":0,"end_line":283,"end_character":74},"in_reply_to":"fe66648b_9eedd0e9","updated":"2023-02-22 18:35:15.000000000","message":"I agree. However, in this specific case, the function `get_security_key_manager_nve_support` was implemented in another patch above this (which is wrong). I\u0027ll remove the comment and put the function in this patch.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":282,"context_line":"                # (caiquemello) Does not have equivalent in REST"},{"line_number":283,"context_line":"                return self.get_security_key_manager_nve_support(nodes[0])"},{"line_number":284,"context_line":"            else:"},{"line_number":285,"context_line":"                LOG.debug(\u0027Cluster credentials are required in order to \u0027"},{"line_number":286,"context_line":"                          \u0027determine whether NetApp Volume Encryption is \u0027"},{"line_number":287,"context_line":"                          \u0027supported or not on this platform.\u0027)"},{"line_number":288,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"1d3f9be5_07b9a157","line":285,"range":{"start_line":285,"start_character":20,"end_line":285,"end_character":25},"updated":"2023-02-15 06:10:29.000000000","message":"warning?","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":282,"context_line":"                # (caiquemello) Does not have equivalent in REST"},{"line_number":283,"context_line":"                return self.get_security_key_manager_nve_support(nodes[0])"},{"line_number":284,"context_line":"            else:"},{"line_number":285,"context_line":"                LOG.debug(\u0027Cluster credentials are required in order to \u0027"},{"line_number":286,"context_line":"                          \u0027determine whether NetApp Volume Encryption is \u0027"},{"line_number":287,"context_line":"                          \u0027supported or not on this platform.\u0027)"},{"line_number":288,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"e23d9221_8e862a65","line":285,"range":{"start_line":285,"start_character":20,"end_line":285,"end_character":25},"in_reply_to":"1d3f9be5_07b9a157","updated":"2023-02-16 03:22:29.000000000","message":"+1 warning","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                # (caiquemello) Does not have equivalent in REST"},{"line_number":283,"context_line":"                return self.get_security_key_manager_nve_support(nodes[0])"},{"line_number":284,"context_line":"            else:"},{"line_number":285,"context_line":"                LOG.debug(\u0027Cluster credentials are required in order to \u0027"},{"line_number":286,"context_line":"                          \u0027determine whether NetApp Volume Encryption is \u0027"},{"line_number":287,"context_line":"                          \u0027supported or not on this platform.\u0027)"},{"line_number":288,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"87cbaf82_e6ce592a","line":285,"range":{"start_line":285,"start_character":20,"end_line":285,"end_character":25},"in_reply_to":"e23d9221_8e862a65","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":293,"context_line":"            return False"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    @na_utils.trace"},{"line_number":296,"context_line":"    def check_for_cluster_credentials(self):"},{"line_number":297,"context_line":"        try:"},{"line_number":298,"context_line":"            self.list_cluster_nodes()"},{"line_number":299,"context_line":"            # API succeeded, so definitely a cluster management LIF"}],"source_content_type":"text/x-python","patch_set":5,"id":"a198f5c0_e5d0cc8b","line":296,"range":{"start_line":296,"start_character":9,"end_line":296,"end_character":43},"updated":"2023-02-16 03:22:29.000000000","message":"add method documentation","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            return False"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    @na_utils.trace"},{"line_number":296,"context_line":"    def check_for_cluster_credentials(self):"},{"line_number":297,"context_line":"        try:"},{"line_number":298,"context_line":"            self.list_cluster_nodes()"},{"line_number":299,"context_line":"            # API succeeded, so definitely a cluster management LIF"}],"source_content_type":"text/x-python","patch_set":5,"id":"22201b4c_14e49173","line":296,"range":{"start_line":296,"start_character":9,"end_line":296,"end_character":43},"in_reply_to":"a198f5c0_e5d0cc8b","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":299,"context_line":"            # API succeeded, so definitely a cluster management LIF"},{"line_number":300,"context_line":"            return True"},{"line_number":301,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":302,"context_line":"            if e.code \u003d\u003d netapp_api.api.EAPINOTFOUND:"},{"line_number":303,"context_line":"                LOG.debug(\u0027Not connected to cluster management LIF.\u0027)"},{"line_number":304,"context_line":"                return False"},{"line_number":305,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"b426ce63_95320637","line":302,"range":{"start_line":302,"start_character":15,"end_line":302,"end_character":52},"updated":"2023-02-16 03:22:29.000000000","message":"This code is from ZAPI. I run it locally with a scoped user to list_cluster, the reported error is:\n\n{\n    \"error\": {\n        \"message\": \"not authorized for that command\",\n        \"code\": \"6\"\n    }\n}\n\nPlease, fix it.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            # API succeeded, so definitely a cluster management LIF"},{"line_number":300,"context_line":"            return True"},{"line_number":301,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":302,"context_line":"            if e.code \u003d\u003d netapp_api.api.EAPINOTFOUND:"},{"line_number":303,"context_line":"                LOG.debug(\u0027Not connected to cluster management LIF.\u0027)"},{"line_number":304,"context_line":"                return False"},{"line_number":305,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"8aa9ff4a_a825da8c","line":302,"range":{"start_line":302,"start_character":15,"end_line":302,"end_character":52},"in_reply_to":"b426ce63_95320637","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":312,"context_line":"        result \u003d self.send_request(\u0027/cluster/nodes\u0027, \u0027get\u0027)"},{"line_number":313,"context_line":"        return [node[\u0027name\u0027] for node in result.get(\u0027records\u0027, [])]"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def _get_unique_volume(self, records):"},{"line_number":316,"context_line":"        \"\"\"Get the unique FlexVol or FlexGroup volume from a volume list\"\"\""},{"line_number":317,"context_line":"        if len(records) !\u003d 1:"},{"line_number":318,"context_line":"            msg \u003d _(\u0027Could not find unique share. Shares found: %(shares)s.\u0027)"},{"line_number":319,"context_line":"            msg_args \u003d {\u0027shares\u0027: records}"},{"line_number":320,"context_line":"            raise exception.NetAppException(message\u003dmsg % msg_args)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        return records[0]"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @na_utils.trace"},{"line_number":325,"context_line":"    def _get_volume_by_args(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"6f48c681_e0ea39c4","line":322,"range":{"start_line":315,"start_character":4,"end_line":322,"end_character":25},"updated":"2023-02-16 03:22:29.000000000","message":"This method seems useless, since just one call. It is not being used for other calls. Also, I cannot see how other methods would reuse it. I think it can be removed and the code be part of the function \"_get_volume_by_args\". WDYT ?","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        result \u003d self.send_request(\u0027/cluster/nodes\u0027, \u0027get\u0027)"},{"line_number":313,"context_line":"        return [node[\u0027name\u0027] for node in result.get(\u0027records\u0027, [])]"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def _get_unique_volume(self, records):"},{"line_number":316,"context_line":"        \"\"\"Get the unique FlexVol or FlexGroup volume from a volume list\"\"\""},{"line_number":317,"context_line":"        if len(records) !\u003d 1:"},{"line_number":318,"context_line":"            msg \u003d _(\u0027Could not find unique share. Shares found: %(shares)s.\u0027)"},{"line_number":319,"context_line":"            msg_args \u003d {\u0027shares\u0027: records}"},{"line_number":320,"context_line":"            raise exception.NetAppException(message\u003dmsg % msg_args)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        return records[0]"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @na_utils.trace"},{"line_number":325,"context_line":"    def _get_volume_by_args(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"82b9d3b3_4f9d1d05","line":322,"range":{"start_line":315,"start_character":4,"end_line":322,"end_character":25},"in_reply_to":"6f48c681_e0ea39c4","updated":"2023-02-22 18:35:15.000000000","message":"I agree. Will remove the method.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":322,"context_line":"        return records[0]"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @na_utils.trace"},{"line_number":325,"context_line":"    def _get_volume_by_args(self, **kwargs):"},{"line_number":326,"context_line":"        \"\"\"Get info from a single volume according to the args.\"\"\""},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        query \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"234868d0_96e5e13d","line":325,"range":{"start_line":325,"start_character":34,"end_line":325,"end_character":43},"updated":"2023-02-16 03:22:29.000000000","message":"Why is it passed as kwargs ? I think it could be simpler by just make clear the parameters:\n\ndef _get_volume_by_args(self, vol_name\u003dNone, aggregate_name\u003dNone, vol_path\u003dNone, vserver\u003dNone, fields\u003dNone):\n\n\nIt seems more clear to the reader. WDYT ?","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":322,"context_line":"        return records[0]"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @na_utils.trace"},{"line_number":325,"context_line":"    def _get_volume_by_args(self, **kwargs):"},{"line_number":326,"context_line":"        \"\"\"Get info from a single volume according to the args.\"\"\""},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        query \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"700454cd_6e925dad","line":325,"range":{"start_line":325,"start_character":8,"end_line":325,"end_character":27},"updated":"2023-02-16 03:22:29.000000000","message":"this function is a core util for REST. We should cover all lines with UTs, but I can just see one single UT (test__get_volume_by_args). Could you improve it ?","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        return records[0]"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @na_utils.trace"},{"line_number":325,"context_line":"    def _get_volume_by_args(self, **kwargs):"},{"line_number":326,"context_line":"        \"\"\"Get info from a single volume according to the args.\"\"\""},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        query \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3b9d1ef8_842a4cd4","line":325,"range":{"start_line":325,"start_character":34,"end_line":325,"end_character":43},"in_reply_to":"234868d0_96e5e13d","updated":"2023-02-22 18:35:15.000000000","message":"I agree, it looks more clear. I\u0027ll change.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        return records[0]"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @na_utils.trace"},{"line_number":325,"context_line":"    def _get_volume_by_args(self, **kwargs):"},{"line_number":326,"context_line":"        \"\"\"Get info from a single volume according to the args.\"\"\""},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        query \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"cd093479_3b6858ab","line":325,"range":{"start_line":325,"start_character":8,"end_line":325,"end_character":27},"in_reply_to":"700454cd_6e925dad","updated":"2023-02-22 18:35:15.000000000","message":"Sure.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":384,"context_line":"    @na_utils.trace"},{"line_number":385,"context_line":"    def list_non_root_aggregates(self):"},{"line_number":386,"context_line":"        \"\"\"Get names of all aggregates that don\u0027t contain node root volumes.\"\"\""},{"line_number":387,"context_line":"        return self._list_aggregates()"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    @na_utils.trace"},{"line_number":390,"context_line":"    def _list_aggregates(self, query\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"62d22f40_1ddc3f98","line":387,"range":{"start_line":387,"start_character":8,"end_line":387,"end_character":38},"updated":"2023-02-16 03:22:29.000000000","message":"please add a note explaining why the \"non_root_aggregate\" calls the same method as the list all aggregates method. Something like:\n\n# NOTE(..): REST GET API retrieves all data aggregates in the cluster. System owned # root aggregates are not included in the output","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    @na_utils.trace"},{"line_number":385,"context_line":"    def list_non_root_aggregates(self):"},{"line_number":386,"context_line":"        \"\"\"Get names of all aggregates that don\u0027t contain node root volumes.\"\"\""},{"line_number":387,"context_line":"        return self._list_aggregates()"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    @na_utils.trace"},{"line_number":390,"context_line":"    def _list_aggregates(self, query\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"f5f15961_5af44af9","line":387,"range":{"start_line":387,"start_character":8,"end_line":387,"end_character":38},"in_reply_to":"62d22f40_1ddc3f98","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":387,"context_line":"        return self._list_aggregates()"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    @na_utils.trace"},{"line_number":390,"context_line":"    def _list_aggregates(self, query\u003dNone):"},{"line_number":391,"context_line":"        \"\"\"Get names of all aggregates.\"\"\""},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7fc956c7_90a2112d","line":390,"range":{"start_line":390,"start_character":0,"end_line":390,"end_character":42},"updated":"2023-02-16 03:22:29.000000000","message":"this method is not required. It is only used by \"list_non_root_aggregate\" and it is client internally. We don\u0027t need to copy ZAPI internal design.\n\nWDYT ?","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        return self._list_aggregates()"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    @na_utils.trace"},{"line_number":390,"context_line":"    def _list_aggregates(self, query\u003dNone):"},{"line_number":391,"context_line":"        \"\"\"Get names of all aggregates.\"\"\""},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"2959f71b_59c196e0","line":390,"range":{"start_line":390,"start_character":0,"end_line":390,"end_character":42},"in_reply_to":"7fc956c7_90a2112d","updated":"2023-02-22 18:35:15.000000000","message":"I agree. Removed.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":390,"context_line":"    def _list_aggregates(self, query\u003dNone):"},{"line_number":391,"context_line":"        \"\"\"Get names of all aggregates.\"\"\""},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        try:"},{"line_number":394,"context_line":"            query \u003d {"},{"line_number":395,"context_line":"            }"},{"line_number":396,"context_line":"            response \u003d self.send_request("},{"line_number":397,"context_line":"                \u0027/storage/aggregates\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":398,"context_line":"            aggr_list \u003d response[\u0027records\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"8794ab7a_a1d6f287","line":395,"range":{"start_line":393,"start_character":12,"end_line":395,"end_character":13},"updated":"2023-02-16 03:22:29.000000000","message":"why this query ?","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    def _list_aggregates(self, query\u003dNone):"},{"line_number":391,"context_line":"        \"\"\"Get names of all aggregates.\"\"\""},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        try:"},{"line_number":394,"context_line":"            query \u003d {"},{"line_number":395,"context_line":"            }"},{"line_number":396,"context_line":"            response \u003d self.send_request("},{"line_number":397,"context_line":"                \u0027/storage/aggregates\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":398,"context_line":"            aggr_list \u003d response[\u0027records\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"0c9a1644_232e7a3d","line":395,"range":{"start_line":393,"start_character":12,"end_line":395,"end_character":13},"in_reply_to":"8794ab7a_a1d6f287","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":396,"context_line":"            response \u003d self.send_request("},{"line_number":397,"context_line":"                \u0027/storage/aggregates\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":398,"context_line":"            aggr_list \u003d response[\u0027records\u0027]"},{"line_number":399,"context_line":"        except AttributeError:"},{"line_number":400,"context_line":"            msg \u003d _(\"Could not list aggregates.\")"},{"line_number":401,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        return [aggr[\u0027name\u0027] for aggr in aggr_list]"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"40418d9b_9a48d3c0","line":401,"range":{"start_line":399,"start_character":8,"end_line":401,"end_character":48},"updated":"2023-02-16 03:22:29.000000000","message":"why is it catching this exception ? I think it is a copy/paste from ZAPI. For REST, I cannot see why this would be required. WDYT ?\n\nPLEASE: there are several \"except AttributeError\" catch in REST. I think it is copying from ZAPI (not sure), please, could you check them to see if they have the the same copy/paste issue ?","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            response \u003d self.send_request("},{"line_number":397,"context_line":"                \u0027/storage/aggregates\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":398,"context_line":"            aggr_list \u003d response[\u0027records\u0027]"},{"line_number":399,"context_line":"        except AttributeError:"},{"line_number":400,"context_line":"            msg \u003d _(\"Could not list aggregates.\")"},{"line_number":401,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        return [aggr[\u0027name\u0027] for aggr in aggr_list]"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ea3fba4_7b4f68dc","line":401,"range":{"start_line":399,"start_character":8,"end_line":401,"end_character":48},"in_reply_to":"40418d9b_9a48d3c0","updated":"2023-02-22 18:35:15.000000000","message":"Makes sense. Since there is no specific treatment for these exceptions in the layers above, I think this exception handling can be removed and we can just let the exception be raised in these cases.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":407,"context_line":"        \"\"\"Calculates capacity of one or more aggregates."},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        Returns dictionary of aggregate capacity metrics."},{"line_number":410,"context_line":"        \u0027size-used\u0027 is the actual space consumed on the aggregate."},{"line_number":411,"context_line":"        \u0027size-available\u0027 is the actual space remaining."},{"line_number":412,"context_line":"        \u0027size-total\u0027 is the defined total aggregate size, such that"},{"line_number":413,"context_line":"        used + available \u003d total."}],"source_content_type":"text/x-python","patch_set":5,"id":"5116ee66_4089ff60","line":410,"range":{"start_line":410,"start_character":9,"end_line":410,"end_character":14},"updated":"2023-02-15 06:10:29.000000000","message":"\"size-\" prefix isnt being used below","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        \"\"\"Calculates capacity of one or more aggregates."},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        Returns dictionary of aggregate capacity metrics."},{"line_number":410,"context_line":"        \u0027size-used\u0027 is the actual space consumed on the aggregate."},{"line_number":411,"context_line":"        \u0027size-available\u0027 is the actual space remaining."},{"line_number":412,"context_line":"        \u0027size-total\u0027 is the defined total aggregate size, such that"},{"line_number":413,"context_line":"        used + available \u003d total."}],"source_content_type":"text/x-python","patch_set":5,"id":"c16e50a8_dc2354f6","line":410,"range":{"start_line":410,"start_character":9,"end_line":410,"end_character":14},"in_reply_to":"5116ee66_4089ff60","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":434,"context_line":"        return aggr_space_dict"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    @na_utils.trace"},{"line_number":437,"context_line":"    def _get_aggregates(self, aggregate_names\u003dNone, fields\u003dNone,"},{"line_number":438,"context_line":"                        is_vserver\u003dFalse):"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        query \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"25ff0ed1_901a76ab","line":437,"range":{"start_line":437,"start_character":8,"end_line":437,"end_character":23},"updated":"2023-02-16 03:22:29.000000000","message":"Please, add method documentation.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":434,"context_line":"        return aggr_space_dict"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    @na_utils.trace"},{"line_number":437,"context_line":"    def _get_aggregates(self, aggregate_names\u003dNone, fields\u003dNone,"},{"line_number":438,"context_line":"                        is_vserver\u003dFalse):"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        query \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"928cd3f4_3fd98b7a","line":437,"range":{"start_line":437,"start_character":8,"end_line":437,"end_character":23},"in_reply_to":"25ff0ed1_901a76ab","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":448,"context_line":"            \u0027/storage/aggregates\u0027, \u0027get\u0027, query\u003dquery,"},{"line_number":449,"context_line":"            enable_tunneling\u003dis_vserver)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        if not self._has_records(response):"},{"line_number":452,"context_line":"            return []"},{"line_number":453,"context_line":"        else:"},{"line_number":454,"context_line":"            return response[\u0027records\u0027]"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    @na_utils.trace"},{"line_number":457,"context_line":"    def get_aggregate(self, aggregate_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"f81e973c_a0a4f111","line":454,"range":{"start_line":451,"start_character":8,"end_line":454,"end_character":38},"updated":"2023-02-16 03:22:29.000000000","message":"return response.get(\u0027records\u0027, [])","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":448,"context_line":"            \u0027/storage/aggregates\u0027, \u0027get\u0027, query\u003dquery,"},{"line_number":449,"context_line":"            enable_tunneling\u003dis_vserver)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        if not self._has_records(response):"},{"line_number":452,"context_line":"            return []"},{"line_number":453,"context_line":"        else:"},{"line_number":454,"context_line":"            return response[\u0027records\u0027]"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    @na_utils.trace"},{"line_number":457,"context_line":"    def get_aggregate(self, aggregate_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"597a4338_12a723e9","line":454,"range":{"start_line":451,"start_character":8,"end_line":454,"end_character":38},"in_reply_to":"f81e973c_a0a4f111","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":471,"context_line":"                          aggregate_name)"},{"line_number":472,"context_line":"            return {}"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        if len(aggrs) \u003c 1:"},{"line_number":475,"context_line":"            return {}"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        aggr_attributes \u003d aggrs[0]"}],"source_content_type":"text/x-python","patch_set":5,"id":"60fb85a7_3a97ab28","line":474,"range":{"start_line":474,"start_character":11,"end_line":474,"end_character":25},"updated":"2023-02-16 03:22:29.000000000","message":"nit: len(aggrs) \u003d\u003d 0","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                          aggregate_name)"},{"line_number":472,"context_line":"            return {}"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        if len(aggrs) \u003c 1:"},{"line_number":475,"context_line":"            return {}"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        aggr_attributes \u003d aggrs[0]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ac5cfee2_e3bf9380","line":474,"range":{"start_line":474,"start_character":11,"end_line":474,"end_character":25},"in_reply_to":"60fb85a7_3a97ab28","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":503,"context_line":"            aggrs \u003d self._get_aggregates(aggregate_names\u003d[aggregate_name],"},{"line_number":504,"context_line":"                                         fields\u003dfields)"},{"line_number":505,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":506,"context_line":"            if e.code \u003d\u003d netapp_api.EAPINOTFOUND:"},{"line_number":507,"context_line":"                return None"},{"line_number":508,"context_line":"            else:"},{"line_number":509,"context_line":"                raise"},{"line_number":510,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f58b5bc_4f02ba43","line":507,"range":{"start_line":506,"start_character":12,"end_line":507,"end_character":27},"updated":"2023-02-16 03:22:29.000000000","message":"This is wrong. It is setting to the ZAPI code const. I ran the get aggregates to the Vserver LIF:\n\n{\n    \"error\": {\n        \"message\": \"not authorized for that command\",\n        \"code\": \"6\"\n    }\n}\n\nPlease, fix with the correct code handler.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":503,"context_line":"            aggrs \u003d self._get_aggregates(aggregate_names\u003d[aggregate_name],"},{"line_number":504,"context_line":"                                         fields\u003dfields)"},{"line_number":505,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":506,"context_line":"            if e.code \u003d\u003d netapp_api.EAPINOTFOUND:"},{"line_number":507,"context_line":"                return None"},{"line_number":508,"context_line":"            else:"},{"line_number":509,"context_line":"                raise"},{"line_number":510,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"b56c2094_55c1a075","line":507,"range":{"start_line":506,"start_character":12,"end_line":507,"end_character":27},"in_reply_to":"3fcb5725_3ecbb888","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e5c3a03d06a2db317c9911a4861a03ccb9be4a1b","unresolved":true,"context_lines":[{"line_number":503,"context_line":"            aggrs \u003d self._get_aggregates(aggregate_names\u003d[aggregate_name],"},{"line_number":504,"context_line":"                                         fields\u003dfields)"},{"line_number":505,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":506,"context_line":"            if e.code \u003d\u003d netapp_api.EAPINOTFOUND:"},{"line_number":507,"context_line":"                return None"},{"line_number":508,"context_line":"            else:"},{"line_number":509,"context_line":"                raise"},{"line_number":510,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fcb5725_3ecbb888","line":507,"range":{"start_line":506,"start_character":12,"end_line":507,"end_character":27},"in_reply_to":"5f58b5bc_4f02ba43","updated":"2023-02-16 16:07:02.000000000","message":"Please, add a LOG.debug()","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":508,"context_line":"            else:"},{"line_number":509,"context_line":"                raise"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        if len(aggrs) \u003c 1:"},{"line_number":512,"context_line":"            return None"},{"line_number":513,"context_line":"        return aggrs[0][\u0027home_node\u0027][\u0027name\u0027]"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    @na_utils.trace"},{"line_number":516,"context_line":"    def get_aggregate_disk_types(self, aggregate_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"151e5799_6a88d824","line":513,"range":{"start_line":511,"start_character":8,"end_line":513,"end_character":44},"updated":"2023-02-16 03:22:29.000000000","message":"3 lines in one:\n\nreturn aggrs[0][\u0027home_node\u0027][\u0027name\u0027] if aggrs else None","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":508,"context_line":"            else:"},{"line_number":509,"context_line":"                raise"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        if len(aggrs) \u003c 1:"},{"line_number":512,"context_line":"            return None"},{"line_number":513,"context_line":"        return aggrs[0][\u0027home_node\u0027][\u0027name\u0027]"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    @na_utils.trace"},{"line_number":516,"context_line":"    def get_aggregate_disk_types(self, aggregate_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"cbd89979_d909af5b","line":513,"range":{"start_line":511,"start_character":8,"end_line":513,"end_character":44},"in_reply_to":"151e5799_6a88d824","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":568,"context_line":"        return list(self.get_vserver_aggregate_capacities().keys())"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    @na_utils.trace"},{"line_number":571,"context_line":"    def get_vserver_aggregate_capacities(self, aggregate_names\u003dNone):"},{"line_number":572,"context_line":"        \"\"\"Calculates capacity of one or more aggregates for a vserver."},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        Returns dictionary of aggregate capacity metrics.  This must"}],"source_content_type":"text/x-python","patch_set":5,"id":"b05e1bae_a2959c92","line":571,"range":{"start_line":571,"start_character":47,"end_line":571,"end_character":64},"updated":"2023-02-16 03:22:29.000000000","message":"this variable should be used the same way as the ZAPI does: filter the aggregates that must be in this list (if it is passed). Please, fix it.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e5c3a03d06a2db317c9911a4861a03ccb9be4a1b","unresolved":true,"context_lines":[{"line_number":568,"context_line":"        return list(self.get_vserver_aggregate_capacities().keys())"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    @na_utils.trace"},{"line_number":571,"context_line":"    def get_vserver_aggregate_capacities(self, aggregate_names\u003dNone):"},{"line_number":572,"context_line":"        \"\"\"Calculates capacity of one or more aggregates for a vserver."},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        Returns dictionary of aggregate capacity metrics.  This must"}],"source_content_type":"text/x-python","patch_set":5,"id":"d1e4afa0_7276e2cd","line":571,"range":{"start_line":571,"start_character":47,"end_line":571,"end_character":64},"in_reply_to":"b05e1bae_a2959c92","updated":"2023-02-16 16:07:02.000000000","message":"You could use it with the query:\n\n    \u0027aggregates.name\u0027: (\u0027|\u0027.join(aggregates_name)\n                        if aggregate_names else \u0027*\u0027),","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        return list(self.get_vserver_aggregate_capacities().keys())"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    @na_utils.trace"},{"line_number":571,"context_line":"    def get_vserver_aggregate_capacities(self, aggregate_names\u003dNone):"},{"line_number":572,"context_line":"        \"\"\"Calculates capacity of one or more aggregates for a vserver."},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        Returns dictionary of aggregate capacity metrics.  This must"}],"source_content_type":"text/x-python","patch_set":5,"id":"142c72b2_5297b660","line":571,"range":{"start_line":571,"start_character":47,"end_line":571,"end_character":64},"in_reply_to":"d1e4afa0_7276e2cd","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":579,"context_line":"            return {}"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        fields \u003d \u0027name,space\u0027"},{"line_number":582,"context_line":"        aggrs \u003d self._get_aggregates(aggregate_names\u003daggregate_names,"},{"line_number":583,"context_line":"                                     fields\u003dfields, is_vserver\u003dTrue)"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"        if not aggrs:"},{"line_number":586,"context_line":"            LOG.warning(\u0027No aggregates assigned to Vserver %s.\u0027, self.vserver)"}],"source_content_type":"text/x-python","patch_set":5,"id":"51632808_565a70e2","line":583,"range":{"start_line":582,"start_character":8,"end_line":583,"end_character":68},"updated":"2023-02-16 03:22:29.000000000","message":"this code won\u0027t work with SVM scoped, since the scoped user cannot run \"/storage/aggregates\".\n\nThe code should follow the same way as ZAPI does: retrieve the vserver aggregate from the vserver itself endpint:\n\n\nquery \u003d {\n   \"fields\"\u003d \"aggregates.available_size,aggregates.name\",\n   \"name\": self.vserver,\n}\n\nself.send_request(\"/svm/svms\"\u0027, \"get\", query\u003dquery)\n\n\nNOTE: `available_size` is only avaialble from 9.12. So, for 9.11.1 you cannot run this method. So, for lower than 9.12 you should call ZAPI to do it.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":579,"context_line":"            return {}"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        fields \u003d \u0027name,space\u0027"},{"line_number":582,"context_line":"        aggrs \u003d self._get_aggregates(aggregate_names\u003daggregate_names,"},{"line_number":583,"context_line":"                                     fields\u003dfields, is_vserver\u003dTrue)"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"        if not aggrs:"},{"line_number":586,"context_line":"            LOG.warning(\u0027No aggregates assigned to Vserver %s.\u0027, self.vserver)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ac22b90_b2fd8db7","line":583,"range":{"start_line":582,"start_character":8,"end_line":583,"end_character":68},"in_reply_to":"51632808_565a70e2","updated":"2023-02-22 18:35:15.000000000","message":"After some tests, we noticed that even in ONTAP 9.12.1, the field `available_size` was not present in the API output. To avoid problems in this method, we decided to retrieve the size information using /private/cli endpoint, since it works with SVM scoped accounts and has all the information we need.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":600,"context_line":"    @na_utils.trace"},{"line_number":601,"context_line":"    def qos_policy_group_create(self, qos_policy_group_name, vserver,"},{"line_number":602,"context_line":"                                max_throughput\u003dNone):"},{"line_number":603,"context_line":"        \"\"\"Creates a QoS policy group.\"\"\""},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"        body \u003d {"},{"line_number":606,"context_line":"            \u0027name\u0027: qos_policy_group_name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"942b7e9f_e4141732","line":603,"range":{"start_line":603,"start_character":32,"end_line":603,"end_character":37},"updated":"2023-02-16 03:22:29.000000000","message":"nit: group.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e5c3a03d06a2db317c9911a4861a03ccb9be4a1b","unresolved":false,"context_lines":[{"line_number":600,"context_line":"    @na_utils.trace"},{"line_number":601,"context_line":"    def qos_policy_group_create(self, qos_policy_group_name, vserver,"},{"line_number":602,"context_line":"                                max_throughput\u003dNone):"},{"line_number":603,"context_line":"        \"\"\"Creates a QoS policy group.\"\"\""},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"        body \u003d {"},{"line_number":606,"context_line":"            \u0027name\u0027: qos_policy_group_name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f883ffa_8fb248d9","line":603,"range":{"start_line":603,"start_character":32,"end_line":603,"end_character":37},"in_reply_to":"942b7e9f_e4141732","updated":"2023-02-16 16:07:02.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":644,"context_line":"                \u0027home-port\u0027: lif_info[\u0027location\u0027][\u0027home_port\u0027][\u0027name\u0027],"},{"line_number":645,"context_line":"                \u0027interface-name\u0027: lif_info[\u0027name\u0027],"},{"line_number":646,"context_line":"                \u0027netmask\u0027: lif_info[\u0027ip\u0027][\u0027netmask\u0027],"},{"line_number":647,"context_line":"                \u0027role\u0027: lif_info[\u0027services\u0027],"},{"line_number":648,"context_line":"                \u0027vserver\u0027: lif_info[\u0027svm\u0027][\u0027name\u0027],"},{"line_number":649,"context_line":"            }"},{"line_number":650,"context_line":"            interfaces.append(lif)"}],"source_content_type":"text/x-python","patch_set":5,"id":"e8de0c9f_130e991f","line":647,"range":{"start_line":647,"start_character":15,"end_line":647,"end_character":45},"updated":"2023-02-16 03:22:29.000000000","message":"From ZAPI doc, role means: \"undef\", \"cluster\", \"data\", \"node_mgmt\", \"intercluster\" or \"cluster_mgmt\".\n\nI think REST \"services\" is not the correct map. However, I think driver layer is not using the \"role\" field, so we can keep it as it is. Right ?","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":644,"context_line":"                \u0027home-port\u0027: lif_info[\u0027location\u0027][\u0027home_port\u0027][\u0027name\u0027],"},{"line_number":645,"context_line":"                \u0027interface-name\u0027: lif_info[\u0027name\u0027],"},{"line_number":646,"context_line":"                \u0027netmask\u0027: lif_info[\u0027ip\u0027][\u0027netmask\u0027],"},{"line_number":647,"context_line":"                \u0027role\u0027: lif_info[\u0027services\u0027],"},{"line_number":648,"context_line":"                \u0027vserver\u0027: lif_info[\u0027svm\u0027][\u0027name\u0027],"},{"line_number":649,"context_line":"            }"},{"line_number":650,"context_line":"            interfaces.append(lif)"}],"source_content_type":"text/x-python","patch_set":5,"id":"2ba63633_60008a78","line":647,"range":{"start_line":647,"start_character":15,"end_line":647,"end_character":45},"in_reply_to":"e8de0c9f_130e991f","updated":"2023-02-22 18:35:15.000000000","message":"Right.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":651,"context_line":"        return interfaces"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    @na_utils.trace"},{"line_number":654,"context_line":"    def clear_nfs_export_policy_for_volume(self, volume_name):"},{"line_number":655,"context_line":"        self.set_nfs_export_policy_for_volume(volume_name, \u0027default\u0027)"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"86bee0f2_3282e585","line":654,"range":{"start_line":654,"start_character":8,"end_line":654,"end_character":42},"updated":"2023-02-16 03:22:29.000000000","message":"add method documentation","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        return interfaces"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    @na_utils.trace"},{"line_number":654,"context_line":"    def clear_nfs_export_policy_for_volume(self, volume_name):"},{"line_number":655,"context_line":"        self.set_nfs_export_policy_for_volume(volume_name, \u0027default\u0027)"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"3262cfdf_32632a9d","line":654,"range":{"start_line":654,"start_character":8,"end_line":654,"end_character":42},"in_reply_to":"86bee0f2_3282e585","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":655,"context_line":"        self.set_nfs_export_policy_for_volume(volume_name, \u0027default\u0027)"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"    @na_utils.trace"},{"line_number":658,"context_line":"    def set_nfs_export_policy_for_volume(self, volume_name, policy_name):"},{"line_number":659,"context_line":"        query \u003d {\"name\": volume_name}"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"97be8af3_51ac6443","line":658,"range":{"start_line":658,"start_character":8,"end_line":658,"end_character":40},"updated":"2023-02-16 03:22:29.000000000","message":"add method documentation","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":655,"context_line":"        self.set_nfs_export_policy_for_volume(volume_name, \u0027default\u0027)"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"    @na_utils.trace"},{"line_number":658,"context_line":"    def set_nfs_export_policy_for_volume(self, volume_name, policy_name):"},{"line_number":659,"context_line":"        query \u003d {\"name\": volume_name}"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"aa9fd09a_b40337a6","line":658,"range":{"start_line":658,"start_character":8,"end_line":658,"end_character":40},"in_reply_to":"97be8af3_51ac6443","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":666,"context_line":"                          query\u003dquery, body\u003dbody)"},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"    @na_utils.trace"},{"line_number":669,"context_line":"    def create_nfs_export_policy(self, policy_name):"},{"line_number":670,"context_line":"        body \u003d {\u0027name\u0027: policy_name}"},{"line_number":671,"context_line":"        try:"},{"line_number":672,"context_line":"            self.send_request(\u0027/protocols/nfs/export-policies\u0027, \u0027post\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ca6d0f90_e7e7e69a","line":669,"range":{"start_line":669,"start_character":8,"end_line":669,"end_character":32},"updated":"2023-02-16 03:22:29.000000000","message":"add method documentation","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":666,"context_line":"                          query\u003dquery, body\u003dbody)"},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"    @na_utils.trace"},{"line_number":669,"context_line":"    def create_nfs_export_policy(self, policy_name):"},{"line_number":670,"context_line":"        body \u003d {\u0027name\u0027: policy_name}"},{"line_number":671,"context_line":"        try:"},{"line_number":672,"context_line":"            self.send_request(\u0027/protocols/nfs/export-policies\u0027, \u0027post\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"d567ebb2_6d618bd2","line":669,"range":{"start_line":669,"start_character":8,"end_line":669,"end_character":32},"in_reply_to":"ca6d0f90_e7e7e69a","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":676,"context_line":"                raise"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"    @na_utils.trace"},{"line_number":679,"context_line":"    def soft_delete_nfs_export_policy(self, policy_name):"},{"line_number":680,"context_line":"        try:"},{"line_number":681,"context_line":"            self.delete_nfs_export_policy(policy_name)"},{"line_number":682,"context_line":"        except netapp_api.api.NaApiError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"33e0cc27_82d24383","line":679,"range":{"start_line":679,"start_character":8,"end_line":679,"end_character":37},"updated":"2023-02-16 03:22:29.000000000","message":"add method documentation","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":676,"context_line":"                raise"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"    @na_utils.trace"},{"line_number":679,"context_line":"    def soft_delete_nfs_export_policy(self, policy_name):"},{"line_number":680,"context_line":"        try:"},{"line_number":681,"context_line":"            self.delete_nfs_export_policy(policy_name)"},{"line_number":682,"context_line":"        except netapp_api.api.NaApiError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"105f99bd_c63dad8c","line":679,"range":{"start_line":679,"start_character":8,"end_line":679,"end_character":37},"in_reply_to":"33e0cc27_82d24383","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":686,"context_line":"                                          DELETED_PREFIX + policy_name)"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    @na_utils.trace"},{"line_number":689,"context_line":"    def rename_nfs_export_policy(self, policy_name, new_policy_name):"},{"line_number":690,"context_line":"        get_uuid \u003d self.send_request("},{"line_number":691,"context_line":"            \u0027/protocols/nfs/export-policies\u0027, \u0027get\u0027,"},{"line_number":692,"context_line":"            query\u003d{\u0027name\u0027: policy_name})"}],"source_content_type":"text/x-python","patch_set":5,"id":"33e821b8_dcee78aa","line":689,"range":{"start_line":689,"start_character":8,"end_line":689,"end_character":32},"updated":"2023-02-16 03:22:29.000000000","message":"add method documentation","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":686,"context_line":"                                          DELETED_PREFIX + policy_name)"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    @na_utils.trace"},{"line_number":689,"context_line":"    def rename_nfs_export_policy(self, policy_name, new_policy_name):"},{"line_number":690,"context_line":"        get_uuid \u003d self.send_request("},{"line_number":691,"context_line":"            \u0027/protocols/nfs/export-policies\u0027, \u0027get\u0027,"},{"line_number":692,"context_line":"            query\u003d{\u0027name\u0027: policy_name})"}],"source_content_type":"text/x-python","patch_set":5,"id":"985c12bf_f7f1345c","line":689,"range":{"start_line":689,"start_character":8,"end_line":689,"end_character":32},"in_reply_to":"33e821b8_dcee78aa","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":691,"context_line":"            \u0027/protocols/nfs/export-policies\u0027, \u0027get\u0027,"},{"line_number":692,"context_line":"            query\u003d{\u0027name\u0027: policy_name})"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        if self._has_records(get_uuid):"},{"line_number":695,"context_line":"            uuid \u003d get_uuid[\u0027records\u0027][0][\u0027id\u0027]"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        body \u003d {"},{"line_number":698,"context_line":"            \u0027name\u0027: new_policy_name"}],"source_content_type":"text/x-python","patch_set":5,"id":"3c246811_544664dc","line":695,"range":{"start_line":694,"start_character":8,"end_line":695,"end_character":47},"updated":"2023-02-16 03:22:29.000000000","message":"don\u0027t need to check like that, since it moght end up with line 701 accessing uuid that was not defined. You should check and raise if failure:\n   records \u003d get_uuid[\u0027records\u0027]\n   if not records:\n       msg \u003d \n       raise exception.NetAppException(msg)\n   uuid \u003d records[0][\u0027id\u0027]","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":691,"context_line":"            \u0027/protocols/nfs/export-policies\u0027, \u0027get\u0027,"},{"line_number":692,"context_line":"            query\u003d{\u0027name\u0027: policy_name})"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        if self._has_records(get_uuid):"},{"line_number":695,"context_line":"            uuid \u003d get_uuid[\u0027records\u0027][0][\u0027id\u0027]"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        body \u003d {"},{"line_number":698,"context_line":"            \u0027name\u0027: new_policy_name"}],"source_content_type":"text/x-python","patch_set":5,"id":"846f95d4_0015165d","line":695,"range":{"start_line":694,"start_character":8,"end_line":695,"end_character":47},"in_reply_to":"3c246811_544664dc","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":709,"context_line":"            \u0027fields\u0027: \u0027nas.path\u0027"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"        }"},{"line_number":712,"context_line":"        result \u003d self.send_request(\u0027storage/volumes/\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":713,"context_line":"        return result[\u0027records\u0027][0][\u0027nas\u0027][\u0027path\u0027]"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"b387d5a8_c07873bf","line":712,"range":{"start_line":712,"start_character":36,"end_line":712,"end_character":43},"updated":"2023-02-16 03:22:29.000000000","message":"keep as all: /storage/","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            \u0027fields\u0027: \u0027nas.path\u0027"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"        }"},{"line_number":712,"context_line":"        result \u003d self.send_request(\u0027storage/volumes/\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":713,"context_line":"        return result[\u0027records\u0027][0][\u0027nas\u0027][\u0027path\u0027]"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa20e574_04a11916","line":712,"range":{"start_line":712,"start_character":36,"end_line":712,"end_character":43},"in_reply_to":"b387d5a8_c07873bf","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":730,"context_line":"            msg_args \u003d {\u0027vol\u0027: volume_name}"},{"line_number":731,"context_line":"            raise exception.NetAppException(msg % msg_args)"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        volume_infos \u003d result.get(\u0027records\u0027, [])[0]"},{"line_number":734,"context_line":"        aggregates \u003d volume_infos.get(\u0027aggregates\u0027, [])"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"        if len(aggregates) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":5,"id":"b3261db0_6bc7ab91","line":733,"range":{"start_line":733,"start_character":23,"end_line":733,"end_character":51},"updated":"2023-02-16 03:22:29.000000000","message":"don\u0027t need to be safe, since already checked before:\n\nvolume_infos \u003d result[\u0027records\u0027][0]","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":730,"context_line":"            msg_args \u003d {\u0027vol\u0027: volume_name}"},{"line_number":731,"context_line":"            raise exception.NetAppException(msg % msg_args)"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        volume_infos \u003d result.get(\u0027records\u0027, [])[0]"},{"line_number":734,"context_line":"        aggregates \u003d volume_infos.get(\u0027aggregates\u0027, [])"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"        if len(aggregates) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":5,"id":"b2601ebf_6139325e","line":733,"range":{"start_line":733,"start_character":23,"end_line":733,"end_character":51},"in_reply_to":"b3261db0_6bc7ab91","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":757,"context_line":"        return volume"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"    @na_utils.trace"},{"line_number":760,"context_line":"    def cifs_share_exists(self, share_name):"},{"line_number":761,"context_line":"        \"\"\"Check that a cifs share already exists\"\"\""},{"line_number":762,"context_line":"        share_path \u003d \u0027/%s\u0027 % share_name"},{"line_number":763,"context_line":"        query \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"fd53ef41_2ec911ac","line":760,"range":{"start_line":760,"start_character":8,"end_line":760,"end_character":25},"updated":"2023-02-16 03:22:29.000000000","message":"add documentation method.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":757,"context_line":"        return volume"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"    @na_utils.trace"},{"line_number":760,"context_line":"    def cifs_share_exists(self, share_name):"},{"line_number":761,"context_line":"        \"\"\"Check that a cifs share already exists\"\"\""},{"line_number":762,"context_line":"        share_path \u003d \u0027/%s\u0027 % share_name"},{"line_number":763,"context_line":"        query \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"42712a0f_6fbbae3f","line":760,"range":{"start_line":760,"start_character":8,"end_line":760,"end_character":25},"in_reply_to":"fd53ef41_2ec911ac","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":769,"context_line":"        return self._has_records(result)"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"    @na_utils.trace"},{"line_number":772,"context_line":"    def create_cifs_share(self, share_name):"},{"line_number":773,"context_line":"        share_path \u003d \u0027/%s\u0027 % share_name"},{"line_number":774,"context_line":"        body \u003d {"},{"line_number":775,"context_line":"            \u0027name\u0027: share_name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ea5885f4_02c4774c","line":772,"range":{"start_line":772,"start_character":8,"end_line":772,"end_character":25},"updated":"2023-02-16 03:22:29.000000000","message":"add documentation method.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":769,"context_line":"        return self._has_records(result)"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"    @na_utils.trace"},{"line_number":772,"context_line":"    def create_cifs_share(self, share_name):"},{"line_number":773,"context_line":"        share_path \u003d \u0027/%s\u0027 % share_name"},{"line_number":774,"context_line":"        body \u003d {"},{"line_number":775,"context_line":"            \u0027name\u0027: share_name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"e9d7ff66_88e78f53","line":772,"range":{"start_line":772,"start_character":8,"end_line":772,"end_character":25},"in_reply_to":"ea5885f4_02c4774c","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4989bee320360d957a55d2c0ae9297cd8fe9232","unresolved":true,"context_lines":[{"line_number":804,"context_line":"            f\u0027/protocols/cifs/shares/{svm_uuid}/{share_name}\u0027"},{"line_number":805,"context_line":"            f\u0027/acls/{user_name}/{CIFS_USER_GROUP_TYPE}\u0027, \u0027delete\u0027)"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"    # NOTE(caique): when zapi is dropped, this method should be removed and"},{"line_number":808,"context_line":"    # the callers should start calling directly the \"create_volume_async\""},{"line_number":809,"context_line":"    @na_utils.trace"},{"line_number":810,"context_line":"    def create_volume(self, aggregate_name, volume_name, size_gb,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ad13c075_a773a318","line":807,"range":{"start_line":807,"start_character":6,"end_line":807,"end_character":10},"updated":"2023-02-16 01:29:03.000000000","message":"TODO","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":804,"context_line":"            f\u0027/protocols/cifs/shares/{svm_uuid}/{share_name}\u0027"},{"line_number":805,"context_line":"            f\u0027/acls/{user_name}/{CIFS_USER_GROUP_TYPE}\u0027, \u0027delete\u0027)"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"    # NOTE(caique): when zapi is dropped, this method should be removed and"},{"line_number":808,"context_line":"    # the callers should start calling directly the \"create_volume_async\""},{"line_number":809,"context_line":"    @na_utils.trace"},{"line_number":810,"context_line":"    def create_volume(self, aggregate_name, volume_name, size_gb,"}],"source_content_type":"text/x-python","patch_set":5,"id":"c32eeff2_07bfba15","line":807,"range":{"start_line":807,"start_character":6,"end_line":807,"end_character":10},"in_reply_to":"ad13c075_a773a318","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":807,"context_line":"    # NOTE(caique): when zapi is dropped, this method should be removed and"},{"line_number":808,"context_line":"    # the callers should start calling directly the \"create_volume_async\""},{"line_number":809,"context_line":"    @na_utils.trace"},{"line_number":810,"context_line":"    def create_volume(self, aggregate_name, volume_name, size_gb,"},{"line_number":811,"context_line":"                      thin_provisioned\u003dFalse, snapshot_policy\u003dNone,"},{"line_number":812,"context_line":"                      language\u003dNone, dedup_enabled\u003dFalse,"},{"line_number":813,"context_line":"                      compression_enabled\u003dFalse, max_files\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"26541c3f_a56e430d","line":810,"range":{"start_line":810,"start_character":8,"end_line":810,"end_character":21},"updated":"2023-02-16 03:22:29.000000000","message":"add documentation method.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":807,"context_line":"    # NOTE(caique): when zapi is dropped, this method should be removed and"},{"line_number":808,"context_line":"    # the callers should start calling directly the \"create_volume_async\""},{"line_number":809,"context_line":"    @na_utils.trace"},{"line_number":810,"context_line":"    def create_volume(self, aggregate_name, volume_name, size_gb,"},{"line_number":811,"context_line":"                      thin_provisioned\u003dFalse, snapshot_policy\u003dNone,"},{"line_number":812,"context_line":"                      language\u003dNone, dedup_enabled\u003dFalse,"},{"line_number":813,"context_line":"                      compression_enabled\u003dFalse, max_files\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"cbabc914_8eea9c92","line":810,"range":{"start_line":810,"start_character":8,"end_line":810,"end_character":21},"in_reply_to":"26541c3f_a56e430d","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":864,"context_line":"        }"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"        return job_info"},{"line_number":867,"context_line":""},{"line_number":868,"context_line":"    def _get_create_volume_body(self, volume_name, thin_provisioned,"},{"line_number":869,"context_line":"                                snapshot_policy, language, snapshot_reserve,"},{"line_number":870,"context_line":"                                volume_type, qos_policy_group, encrypt,"}],"source_content_type":"text/x-python","patch_set":5,"id":"116f5ac0_b36f8bae","line":867,"updated":"2023-02-16 03:22:29.000000000","message":"@na_utils.trace","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":864,"context_line":"        }"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"        return job_info"},{"line_number":867,"context_line":""},{"line_number":868,"context_line":"    def _get_create_volume_body(self, volume_name, thin_provisioned,"},{"line_number":869,"context_line":"                                snapshot_policy, language, snapshot_reserve,"},{"line_number":870,"context_line":"                                volume_type, qos_policy_group, encrypt,"}],"source_content_type":"text/x-python","patch_set":5,"id":"f9be9b38_76d59a7b","line":867,"in_reply_to":"116f5ac0_b36f8bae","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4989bee320360d957a55d2c0ae9297cd8fe9232","unresolved":true,"context_lines":[{"line_number":868,"context_line":"    def _get_create_volume_body(self, volume_name, thin_provisioned,"},{"line_number":869,"context_line":"                                snapshot_policy, language, snapshot_reserve,"},{"line_number":870,"context_line":"                                volume_type, qos_policy_group, encrypt,"},{"line_number":871,"context_line":"                                adaptive_qos_policy_group):"},{"line_number":872,"context_line":"        body \u003d {"},{"line_number":873,"context_line":"            \u0027type\u0027: volume_type,"},{"line_number":874,"context_line":"            \u0027guarantee.type\u0027: (\u0027none\u0027 if thin_provisioned else \u0027volume\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"2169a72f_7df3d02b","line":871,"updated":"2023-02-16 01:29:03.000000000","message":"missing docstring","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":868,"context_line":"    def _get_create_volume_body(self, volume_name, thin_provisioned,"},{"line_number":869,"context_line":"                                snapshot_policy, language, snapshot_reserve,"},{"line_number":870,"context_line":"                                volume_type, qos_policy_group, encrypt,"},{"line_number":871,"context_line":"                                adaptive_qos_policy_group):"},{"line_number":872,"context_line":"        body \u003d {"},{"line_number":873,"context_line":"            \u0027type\u0027: volume_type,"},{"line_number":874,"context_line":"            \u0027guarantee.type\u0027: (\u0027none\u0027 if thin_provisioned else \u0027volume\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"d8357263_85c36600","line":871,"in_reply_to":"2169a72f_7df3d02b","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e5c3a03d06a2db317c9911a4861a03ccb9be4a1b","unresolved":true,"context_lines":[{"line_number":930,"context_line":"        }"},{"line_number":931,"context_line":"        try:"},{"line_number":932,"context_line":"            result \u003d self.send_request(\u0027/storage/volumes\u0027,"},{"line_number":933,"context_line":"                                       \u0027get\u0027, query\u003dquery)"},{"line_number":934,"context_line":"            records \u003d result.get(\u0027records\u0027, [])"},{"line_number":935,"context_line":"        except exception.NetAppException:"},{"line_number":936,"context_line":"            msg \u003d _(\u0027Failed to get volume efficiency status for %s.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"8fed8140_30962778","line":933,"range":{"start_line":933,"start_character":39,"end_line":933,"end_character":58},"updated":"2023-02-16 16:07:02.000000000","message":"nit: it can be added to the same line","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":930,"context_line":"        }"},{"line_number":931,"context_line":"        try:"},{"line_number":932,"context_line":"            result \u003d self.send_request(\u0027/storage/volumes\u0027,"},{"line_number":933,"context_line":"                                       \u0027get\u0027, query\u003dquery)"},{"line_number":934,"context_line":"            records \u003d result.get(\u0027records\u0027, [])"},{"line_number":935,"context_line":"        except exception.NetAppException:"},{"line_number":936,"context_line":"            msg \u003d _(\u0027Failed to get volume efficiency status for %s.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"0c70ac60_33eec615","line":933,"range":{"start_line":933,"start_character":39,"end_line":933,"end_character":58},"in_reply_to":"8fed8140_30962778","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":931,"context_line":"        try:"},{"line_number":932,"context_line":"            result \u003d self.send_request(\u0027/storage/volumes\u0027,"},{"line_number":933,"context_line":"                                       \u0027get\u0027, query\u003dquery)"},{"line_number":934,"context_line":"            records \u003d result.get(\u0027records\u0027, [])"},{"line_number":935,"context_line":"        except exception.NetAppException:"},{"line_number":936,"context_line":"            msg \u003d _(\u0027Failed to get volume efficiency status for %s.\u0027)"},{"line_number":937,"context_line":"            LOG.error(msg, volume_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"faa31e9e_da667ec2","line":934,"range":{"start_line":934,"start_character":44,"end_line":934,"end_character":47},"updated":"2023-02-16 03:22:29.000000000","message":"it will fail later, since it is getting the first element from the list. The idea of the method is returning \"False\" in case of error/not found.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":931,"context_line":"        try:"},{"line_number":932,"context_line":"            result \u003d self.send_request(\u0027/storage/volumes\u0027,"},{"line_number":933,"context_line":"                                       \u0027get\u0027, query\u003dquery)"},{"line_number":934,"context_line":"            records \u003d result.get(\u0027records\u0027, [])"},{"line_number":935,"context_line":"        except exception.NetAppException:"},{"line_number":936,"context_line":"            msg \u003d _(\u0027Failed to get volume efficiency status for %s.\u0027)"},{"line_number":937,"context_line":"            LOG.error(msg, volume_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba61577f_8489ad92","line":934,"range":{"start_line":934,"start_character":44,"end_line":934,"end_character":47},"in_reply_to":"faa31e9e_da667ec2","updated":"2023-02-22 18:35:15.000000000","message":"Fixed.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":932,"context_line":"            result \u003d self.send_request(\u0027/storage/volumes\u0027,"},{"line_number":933,"context_line":"                                       \u0027get\u0027, query\u003dquery)"},{"line_number":934,"context_line":"            records \u003d result.get(\u0027records\u0027, [])"},{"line_number":935,"context_line":"        except exception.NetAppException:"},{"line_number":936,"context_line":"            msg \u003d _(\u0027Failed to get volume efficiency status for %s.\u0027)"},{"line_number":937,"context_line":"            LOG.error(msg, volume_name)"},{"line_number":938,"context_line":"            records \u003d result.get(\u0027records\u0027, [])"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f2e3781_b76bee43","line":935,"range":{"start_line":935,"start_character":9,"end_line":935,"end_character":40},"updated":"2023-02-16 03:22:29.000000000","message":"The send_request does not throw this kind of exception. It throws the \"except netapp_api.api.NaApiError as e\"","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":932,"context_line":"            result \u003d self.send_request(\u0027/storage/volumes\u0027,"},{"line_number":933,"context_line":"                                       \u0027get\u0027, query\u003dquery)"},{"line_number":934,"context_line":"            records \u003d result.get(\u0027records\u0027, [])"},{"line_number":935,"context_line":"        except exception.NetAppException:"},{"line_number":936,"context_line":"            msg \u003d _(\u0027Failed to get volume efficiency status for %s.\u0027)"},{"line_number":937,"context_line":"            LOG.error(msg, volume_name)"},{"line_number":938,"context_line":"            records \u003d result.get(\u0027records\u0027, [])"}],"source_content_type":"text/x-python","patch_set":5,"id":"69263f20_2807bca1","line":935,"range":{"start_line":935,"start_character":9,"end_line":935,"end_character":40},"in_reply_to":"1f2e3781_b76bee43","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":935,"context_line":"        except exception.NetAppException:"},{"line_number":936,"context_line":"            msg \u003d _(\u0027Failed to get volume efficiency status for %s.\u0027)"},{"line_number":937,"context_line":"            LOG.error(msg, volume_name)"},{"line_number":938,"context_line":"            records \u003d result.get(\u0027records\u0027, [])"},{"line_number":939,"context_line":"        return {"},{"line_number":940,"context_line":"            \u0027dedupe\u0027: True if \u0027enabled\u0027 \u003d\u003d records[0].get("},{"line_number":941,"context_line":"                \u0027efficiency\u0027, {}).get(\u0027state\u0027, \u0027\u0027) else False,"}],"source_content_type":"text/x-python","patch_set":5,"id":"71a9a09d_32694195","line":938,"range":{"start_line":938,"start_character":44,"end_line":938,"end_character":47},"updated":"2023-02-16 03:22:29.000000000","message":"it will fail later, since it is getting the first element from the list. The idea of the method is returning \"False\" in case of error/not found.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":935,"context_line":"        except exception.NetAppException:"},{"line_number":936,"context_line":"            msg \u003d _(\u0027Failed to get volume efficiency status for %s.\u0027)"},{"line_number":937,"context_line":"            LOG.error(msg, volume_name)"},{"line_number":938,"context_line":"            records \u003d result.get(\u0027records\u0027, [])"},{"line_number":939,"context_line":"        return {"},{"line_number":940,"context_line":"            \u0027dedupe\u0027: True if \u0027enabled\u0027 \u003d\u003d records[0].get("},{"line_number":941,"context_line":"                \u0027efficiency\u0027, {}).get(\u0027state\u0027, \u0027\u0027) else False,"}],"source_content_type":"text/x-python","patch_set":5,"id":"f56a525b_bd671714","line":938,"range":{"start_line":938,"start_character":44,"end_line":938,"end_character":47},"in_reply_to":"71a9a09d_32694195","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e5c3a03d06a2db317c9911a4861a03ccb9be4a1b","unresolved":true,"context_lines":[{"line_number":936,"context_line":"            msg \u003d _(\u0027Failed to get volume efficiency status for %s.\u0027)"},{"line_number":937,"context_line":"            LOG.error(msg, volume_name)"},{"line_number":938,"context_line":"            records \u003d result.get(\u0027records\u0027, [])"},{"line_number":939,"context_line":"        return {"},{"line_number":940,"context_line":"            \u0027dedupe\u0027: True if \u0027enabled\u0027 \u003d\u003d records[0].get("},{"line_number":941,"context_line":"                \u0027efficiency\u0027, {}).get(\u0027state\u0027, \u0027\u0027) else False,"},{"line_number":942,"context_line":"            \u0027compression\u0027: True if \u0027true\u0027 \u003d\u003d records[0].get("}],"source_content_type":"text/x-python","patch_set":5,"id":"916542da_e92438ee","line":939,"updated":"2023-02-16 16:07:02.000000000","message":"add before return:\n\n        if not records:\n            return {\n                \u0027dedupe\u0027: False,\n                \u0027compression\u0027: False,\n            }","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":936,"context_line":"            msg \u003d _(\u0027Failed to get volume efficiency status for %s.\u0027)"},{"line_number":937,"context_line":"            LOG.error(msg, volume_name)"},{"line_number":938,"context_line":"            records \u003d result.get(\u0027records\u0027, [])"},{"line_number":939,"context_line":"        return {"},{"line_number":940,"context_line":"            \u0027dedupe\u0027: True if \u0027enabled\u0027 \u003d\u003d records[0].get("},{"line_number":941,"context_line":"                \u0027efficiency\u0027, {}).get(\u0027state\u0027, \u0027\u0027) else False,"},{"line_number":942,"context_line":"            \u0027compression\u0027: True if \u0027true\u0027 \u003d\u003d records[0].get("}],"source_content_type":"text/x-python","patch_set":5,"id":"7582a70f_5e29d545","line":939,"in_reply_to":"916542da_e92438ee","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"    @na_utils.trace"},{"line_number":1018,"context_line":"    def set_volume_max_files(self, volume_name, max_files):"},{"line_number":1019,"context_line":"        \"\"\"Set flexvol file limit.\"\"\""},{"line_number":1020,"context_line":""},{"line_number":1021,"context_line":"        volume \u003d self._get_volume_by_args(vol_name\u003dvolume_name)"},{"line_number":1022,"context_line":"        uuid \u003d volume[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2aa083_d602d84b","line":1019,"range":{"start_line":1019,"start_character":15,"end_line":1019,"end_character":23},"updated":"2023-02-16 03:22:29.000000000","message":"share","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"    @na_utils.trace"},{"line_number":1018,"context_line":"    def set_volume_max_files(self, volume_name, max_files):"},{"line_number":1019,"context_line":"        \"\"\"Set flexvol file limit.\"\"\""},{"line_number":1020,"context_line":""},{"line_number":1021,"context_line":"        volume \u003d self._get_volume_by_args(vol_name\u003dvolume_name)"},{"line_number":1022,"context_line":"        uuid \u003d volume[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7479210f_420b96bd","line":1019,"range":{"start_line":1019,"start_character":15,"end_line":1019,"end_character":23},"in_reply_to":"5a2aa083_d602d84b","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4989bee320360d957a55d2c0ae9297cd8fe9232","unresolved":true,"context_lines":[{"line_number":1058,"context_line":"            volume \u003d self._get_volume_by_args(vol_name\u003dshare_name)"},{"line_number":1059,"context_line":"            svm_uuid \u003d volume[\u0027svm\u0027][\u0027uuid\u0027]"},{"line_number":1060,"context_line":"        except exception.NetAppException:"},{"line_number":1061,"context_line":"            LOG.debug(\u0027Could not find fpolicy. Share not found: %s.\u0027,"},{"line_number":1062,"context_line":"                      share_name)"},{"line_number":1063,"context_line":"            return []"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        query \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"a6f4f1f0_ce09426f","line":1062,"range":{"start_line":1061,"start_character":64,"end_line":1062,"end_character":32},"updated":"2023-02-16 01:29:03.000000000","message":"nit: this could be an f string as in other places in this file","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1058,"context_line":"            volume \u003d self._get_volume_by_args(vol_name\u003dshare_name)"},{"line_number":1059,"context_line":"            svm_uuid \u003d volume[\u0027svm\u0027][\u0027uuid\u0027]"},{"line_number":1060,"context_line":"        except exception.NetAppException:"},{"line_number":1061,"context_line":"            LOG.debug(\u0027Could not find fpolicy. Share not found: %s.\u0027,"},{"line_number":1062,"context_line":"                      share_name)"},{"line_number":1063,"context_line":"            return []"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        query \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f6a140a_ab6a37c1","line":1062,"range":{"start_line":1061,"start_character":64,"end_line":1062,"end_character":32},"in_reply_to":"a6f4f1f0_ce09426f","updated":"2023-02-22 18:35:15.000000000","message":"I recall in the past we had some problem when using f-string in LOG messages (don\u0027t remember what it was). But for other cases, I agree that f-strings are better :)","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4989bee320360d957a55d2c0ae9297cd8fe9232","unresolved":true,"context_lines":[{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"    @na_utils.trace"},{"line_number":1113,"context_line":"    def get_fpolicy_policies_status(self, share_name, policy_name\u003dNone,"},{"line_number":1114,"context_line":"                                    status\u003d\u0027true\u0027):"},{"line_number":1115,"context_line":"        volume \u003d self._get_volume_by_args(vol_name\u003dshare_name)"},{"line_number":1116,"context_line":"        svm_uuid \u003d volume[\u0027svm\u0027][\u0027uuid\u0027]"},{"line_number":1117,"context_line":"        query \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"04108836_accadde7","line":1114,"updated":"2023-02-16 01:29:03.000000000","message":"missing docstring","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"    @na_utils.trace"},{"line_number":1113,"context_line":"    def get_fpolicy_policies_status(self, share_name, policy_name\u003dNone,"},{"line_number":1114,"context_line":"                                    status\u003d\u0027true\u0027):"},{"line_number":1115,"context_line":"        volume \u003d self._get_volume_by_args(vol_name\u003dshare_name)"},{"line_number":1116,"context_line":"        svm_uuid \u003d volume[\u0027svm\u0027][\u0027uuid\u0027]"},{"line_number":1117,"context_line":"        query \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"f0a45d73_d7a8a24d","line":1114,"in_reply_to":"04108836_accadde7","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"bb9b82f8a80336d8b9dea401e3b107fbc86875e2","unresolved":true,"context_lines":[{"line_number":1279,"context_line":"            self.send_request("},{"line_number":1280,"context_line":"                f\u0027/protocols/fpolicy/{svm_uuid}/events/{event_name}\u0027, \u0027delete\u0027)"},{"line_number":1281,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":1282,"context_line":"            if e.code in [netapp_api.EEVENTNOTFOUND,"},{"line_number":1283,"context_line":"                          netapp_api.EOBJECTNOTFOUND]:"},{"line_number":1284,"context_line":"                msg \u003d _(\"FPolicy event %s not found.\")"},{"line_number":1285,"context_line":"                LOG.debug(msg, event_name)"},{"line_number":1286,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"436120da_4e50b935","line":1283,"range":{"start_line":1282,"start_character":26,"end_line":1283,"end_character":53},"updated":"2023-02-17 01:00:30.000000000","message":"they are ZAPI code, please, add the REST equivalent.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"            self.send_request("},{"line_number":1280,"context_line":"                f\u0027/protocols/fpolicy/{svm_uuid}/events/{event_name}\u0027, \u0027delete\u0027)"},{"line_number":1281,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":1282,"context_line":"            if e.code in [netapp_api.EEVENTNOTFOUND,"},{"line_number":1283,"context_line":"                          netapp_api.EOBJECTNOTFOUND]:"},{"line_number":1284,"context_line":"                msg \u003d _(\"FPolicy event %s not found.\")"},{"line_number":1285,"context_line":"                LOG.debug(msg, event_name)"},{"line_number":1286,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"19f6a7cf_ba8b8dd7","line":1283,"range":{"start_line":1282,"start_character":26,"end_line":1283,"end_character":53},"in_reply_to":"436120da_4e50b935","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e03ad282164a3897937f50c99befebf92ca8afb1","unresolved":true,"context_lines":[{"line_number":1304,"context_line":"                f\u0027/protocols/fpolicy/{svm_uuid}/policies/{policy_name}\u0027,"},{"line_number":1305,"context_line":"                \u0027delete\u0027)"},{"line_number":1306,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":1307,"context_line":"            if e.code in [netapp_api.EPOLICYNOTFOUND,"},{"line_number":1308,"context_line":"                          netapp_api.EOBJECTNOTFOUND]:"},{"line_number":1309,"context_line":"                msg \u003d _(\"FPolicy policy %s not found.\")"},{"line_number":1310,"context_line":"                LOG.debug(msg, policy_name)"},{"line_number":1311,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"85306b6d_f3651634","line":1308,"range":{"start_line":1307,"start_character":25,"end_line":1308,"end_character":54},"updated":"2023-02-17 01:53:05.000000000","message":"they are ZAPI code, please, add the REST equivalent.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"                f\u0027/protocols/fpolicy/{svm_uuid}/policies/{policy_name}\u0027,"},{"line_number":1305,"context_line":"                \u0027delete\u0027)"},{"line_number":1306,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":1307,"context_line":"            if e.code in [netapp_api.EPOLICYNOTFOUND,"},{"line_number":1308,"context_line":"                          netapp_api.EOBJECTNOTFOUND]:"},{"line_number":1309,"context_line":"                msg \u003d _(\"FPolicy policy %s not found.\")"},{"line_number":1310,"context_line":"                LOG.debug(msg, policy_name)"},{"line_number":1311,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"22920f90_ed548e64","line":1308,"range":{"start_line":1307,"start_character":25,"end_line":1308,"end_character":54},"in_reply_to":"85306b6d_f3651634","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4989bee320360d957a55d2c0ae9297cd8fe9232","unresolved":true,"context_lines":[{"line_number":1451,"context_line":"        self.send_request(f\u0027/storage/volumes/{uuid}\u0027, \u0027patch\u0027, body\u003dbody)"},{"line_number":1452,"context_line":""},{"line_number":1453,"context_line":"    @na_utils.trace"},{"line_number":1454,"context_line":"    # NOTE(felipe_rodrigues): remove the force parameter when ZAPI is dropped."},{"line_number":1455,"context_line":"    def unmount_volume(self, volume_name, force\u003dFalse, wait_seconds\u003d30):"},{"line_number":1456,"context_line":"        \"\"\"Unmounts a volume, retrying if a clone split is ongoing."},{"line_number":1457,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"b29fb8e2_b71c8b02","line":1454,"range":{"start_line":1454,"start_character":6,"end_line":1454,"end_character":10},"updated":"2023-02-16 01:29:03.000000000","message":"TODO","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1451,"context_line":"        self.send_request(f\u0027/storage/volumes/{uuid}\u0027, \u0027patch\u0027, body\u003dbody)"},{"line_number":1452,"context_line":""},{"line_number":1453,"context_line":"    @na_utils.trace"},{"line_number":1454,"context_line":"    # NOTE(felipe_rodrigues): remove the force parameter when ZAPI is dropped."},{"line_number":1455,"context_line":"    def unmount_volume(self, volume_name, force\u003dFalse, wait_seconds\u003d30):"},{"line_number":1456,"context_line":"        \"\"\"Unmounts a volume, retrying if a clone split is ongoing."},{"line_number":1457,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"53288948_d4dcfa37","line":1454,"range":{"start_line":1454,"start_character":6,"end_line":1454,"end_character":10},"in_reply_to":"b29fb8e2_b71c8b02","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":1474,"context_line":"                LOG.debug(\u0027Volume %s unmounted.\u0027, volume_name)"},{"line_number":1475,"context_line":"                return"},{"line_number":1476,"context_line":"            except netapp_api.api.NaApiError as e:"},{"line_number":1477,"context_line":"                # TODO(felipe_rodrigues): test the clone split mount error"},{"line_number":1478,"context_line":"                # code for REST."},{"line_number":1479,"context_line":"                if (e.code \u003d\u003d netapp_api.api.EAPIERROR"},{"line_number":1480,"context_line":"                        and \u0027job ID\u0027 in e.message):"},{"line_number":1481,"context_line":"                    msg \u003d (\u0027Could not unmount volume %(volume)s due to \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"f5bce063_474fb4b6","line":1478,"range":{"start_line":1477,"start_character":19,"end_line":1478,"end_character":32},"updated":"2023-02-16 03:22:29.000000000","message":"please, solve this TODO. Trigger a clone split and call REST with unmount, what error code occurs ?","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"645941df270f7571f2331a3e051804ae17015dcc","unresolved":false,"context_lines":[{"line_number":1474,"context_line":"                LOG.debug(\u0027Volume %s unmounted.\u0027, volume_name)"},{"line_number":1475,"context_line":"                return"},{"line_number":1476,"context_line":"            except netapp_api.api.NaApiError as e:"},{"line_number":1477,"context_line":"                # TODO(felipe_rodrigues): test the clone split mount error"},{"line_number":1478,"context_line":"                # code for REST."},{"line_number":1479,"context_line":"                if (e.code \u003d\u003d netapp_api.api.EAPIERROR"},{"line_number":1480,"context_line":"                        and \u0027job ID\u0027 in e.message):"},{"line_number":1481,"context_line":"                    msg \u003d (\u0027Could not unmount volume %(volume)s due to \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"e0102e83_75253a03","line":1478,"range":{"start_line":1477,"start_character":19,"end_line":1478,"end_character":32},"in_reply_to":"176dde09_277686a6","updated":"2023-02-23 00:30:58.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"fd20f0eac83a13911df9b82b258234eef5b1a8f1","unresolved":true,"context_lines":[{"line_number":1474,"context_line":"                LOG.debug(\u0027Volume %s unmounted.\u0027, volume_name)"},{"line_number":1475,"context_line":"                return"},{"line_number":1476,"context_line":"            except netapp_api.api.NaApiError as e:"},{"line_number":1477,"context_line":"                # TODO(felipe_rodrigues): test the clone split mount error"},{"line_number":1478,"context_line":"                # code for REST."},{"line_number":1479,"context_line":"                if (e.code \u003d\u003d netapp_api.api.EAPIERROR"},{"line_number":1480,"context_line":"                        and \u0027job ID\u0027 in e.message):"},{"line_number":1481,"context_line":"                    msg \u003d (\u0027Could not unmount volume %(volume)s due to \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"176dde09_277686a6","line":1478,"range":{"start_line":1477,"start_character":19,"end_line":1478,"end_character":32},"in_reply_to":"f5bce063_474fb4b6","updated":"2023-02-22 23:49:08.000000000","message":"We can solve it on a follow-up patch later","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8b4c0d253341c277b2ab7ef868fce96162191a22","unresolved":true,"context_lines":[{"line_number":1520,"context_line":"            \u0027name\u0027: qos_policy_group_name,"},{"line_number":1521,"context_line":"            \u0027fields\u0027: \u0027name,object_count,fixed.max_throughput_iops,svm.name\u0027,"},{"line_number":1522,"context_line":"        }"},{"line_number":1523,"context_line":"        res \u003d self.send_request(\u0027/storage/qos/policies\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":1524,"context_line":"        if not res.get(\u0027records\u0027):"},{"line_number":1525,"context_line":"            msg \u003d _(\u0027QoS %s not found.\u0027) % qos_policy_group_name"},{"line_number":1526,"context_line":"            raise exception.NetAppException(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fce4bbaa_65bfb9ee","line":1523,"range":{"start_line":1523,"start_character":7,"end_line":1523,"end_character":76},"updated":"2023-02-21 03:11:00.000000000","message":"It should have try/catch for preventing error with scoped account (as ZAPI does)","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"            \u0027name\u0027: qos_policy_group_name,"},{"line_number":1521,"context_line":"            \u0027fields\u0027: \u0027name,object_count,fixed.max_throughput_iops,svm.name\u0027,"},{"line_number":1522,"context_line":"        }"},{"line_number":1523,"context_line":"        res \u003d self.send_request(\u0027/storage/qos/policies\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":1524,"context_line":"        if not res.get(\u0027records\u0027):"},{"line_number":1525,"context_line":"            msg \u003d _(\u0027QoS %s not found.\u0027) % qos_policy_group_name"},{"line_number":1526,"context_line":"            raise exception.NetAppException(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"926f62f0_a432ded6","line":1523,"range":{"start_line":1523,"start_character":7,"end_line":1523,"end_character":76},"in_reply_to":"fce4bbaa_65bfb9ee","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":1630,"context_line":"        self.send_request(f\u0027/storage/qos/policies/{uuid}\u0027, \u0027patch\u0027,"},{"line_number":1631,"context_line":"                          body\u003dbody)"},{"line_number":1632,"context_line":""},{"line_number":1633,"context_line":"    def set_volume_size(self, volume_name, size_gb):"},{"line_number":1634,"context_line":"        \"\"\"Set volume size.\"\"\""},{"line_number":1635,"context_line":""},{"line_number":1636,"context_line":"        volume \u003d self._get_volume_by_args(vol_name\u003dvolume_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"a4024a34_1600745c","line":1633,"range":{"start_line":1633,"start_character":8,"end_line":1633,"end_character":23},"updated":"2023-02-16 03:22:29.000000000","message":"please, add @na_utils.trace","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1630,"context_line":"        self.send_request(f\u0027/storage/qos/policies/{uuid}\u0027, \u0027patch\u0027,"},{"line_number":1631,"context_line":"                          body\u003dbody)"},{"line_number":1632,"context_line":""},{"line_number":1633,"context_line":"    def set_volume_size(self, volume_name, size_gb):"},{"line_number":1634,"context_line":"        \"\"\"Set volume size.\"\"\""},{"line_number":1635,"context_line":""},{"line_number":1636,"context_line":"        volume \u003d self._get_volume_by_args(vol_name\u003dvolume_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bd80a998_72bd6311","line":1633,"range":{"start_line":1633,"start_character":8,"end_line":1633,"end_character":23},"in_reply_to":"a4024a34_1600745c","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8b4c0d253341c277b2ab7ef868fce96162191a22","unresolved":true,"context_lines":[{"line_number":1752,"context_line":"        }"},{"line_number":1753,"context_line":"        result \u003d self.get_records(\u0027/storage/volumes/\u0027, query\u003dquery)"},{"line_number":1754,"context_line":""},{"line_number":1755,"context_line":"        return [volume[\u0027name\u0027] for volume in result.get(\u0027records\u0027, [])]"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"    @na_utils.trace"},{"line_number":1758,"context_line":"    def split_volume_clone(self, volume_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ddf79bcf_4aef2428","line":1755,"range":{"start_line":1755,"start_character":14,"end_line":1755,"end_character":71},"updated":"2023-02-21 03:11:00.000000000","message":"Driver layer expects it as list of dict containing \"name\" key","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1752,"context_line":"        }"},{"line_number":1753,"context_line":"        result \u003d self.get_records(\u0027/storage/volumes/\u0027, query\u003dquery)"},{"line_number":1754,"context_line":""},{"line_number":1755,"context_line":"        return [volume[\u0027name\u0027] for volume in result.get(\u0027records\u0027, [])]"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"    @na_utils.trace"},{"line_number":1758,"context_line":"    def split_volume_clone(self, volume_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"0bbafd8e_e7d37fcf","line":1755,"range":{"start_line":1755,"start_character":14,"end_line":1755,"end_character":71},"in_reply_to":"ddf79bcf_4aef2428","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":1914,"context_line":""},{"line_number":1915,"context_line":"    @na_utils.trace"},{"line_number":1916,"context_line":"    def set_volume_name(self, volume_name, new_volume_name):"},{"line_number":1917,"context_line":"        \"\"\"Set flexvol name.\"\"\""},{"line_number":1918,"context_line":"        volume \u003d self._get_volume_by_args(vol_name\u003dvolume_name)"},{"line_number":1919,"context_line":"        uuid \u003d volume[\u0027uuid\u0027]"},{"line_number":1920,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"05755208_cd592bdc","line":1917,"range":{"start_line":1917,"start_character":15,"end_line":1917,"end_character":23},"updated":"2023-02-16 03:22:29.000000000","message":"volume","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1914,"context_line":""},{"line_number":1915,"context_line":"    @na_utils.trace"},{"line_number":1916,"context_line":"    def set_volume_name(self, volume_name, new_volume_name):"},{"line_number":1917,"context_line":"        \"\"\"Set flexvol name.\"\"\""},{"line_number":1918,"context_line":"        volume \u003d self._get_volume_by_args(vol_name\u003dvolume_name)"},{"line_number":1919,"context_line":"        uuid \u003d volume[\u0027uuid\u0027]"},{"line_number":1920,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d37d8b81_f0a9423f","line":1917,"range":{"start_line":1917,"start_character":15,"end_line":1917,"end_character":23},"in_reply_to":"05755208_cd592bdc","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4989bee320360d957a55d2c0ae9297cd8fe9232","unresolved":true,"context_lines":[{"line_number":1993,"context_line":"        return aggregate"},{"line_number":1994,"context_line":""},{"line_number":1995,"context_line":"    @na_utils.trace"},{"line_number":1996,"context_line":"    def get_volume_to_manage(self, aggregate_name, volume_name):"},{"line_number":1997,"context_line":"        query \u003d {"},{"line_number":1998,"context_line":"            \u0027name\u0027: volume_name,"},{"line_number":1999,"context_line":"            \u0027fields\u0027: \u0027name,aggregates.name,nas.path,name,type,style,\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"791109df_15ea4c45","line":1996,"updated":"2023-02-16 01:29:03.000000000","message":"missing docstring","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1993,"context_line":"        return aggregate"},{"line_number":1994,"context_line":""},{"line_number":1995,"context_line":"    @na_utils.trace"},{"line_number":1996,"context_line":"    def get_volume_to_manage(self, aggregate_name, volume_name):"},{"line_number":1997,"context_line":"        query \u003d {"},{"line_number":1998,"context_line":"            \u0027name\u0027: volume_name,"},{"line_number":1999,"context_line":"            \u0027fields\u0027: \u0027name,aggregates.name,nas.path,name,type,style,\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"b29f80c2_64c42036","line":1996,"in_reply_to":"791109df_15ea4c45","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4989bee320360d957a55d2c0ae9297cd8fe9232","unresolved":true,"context_lines":[{"line_number":2031,"context_line":""},{"line_number":2032,"context_line":"        return volume"},{"line_number":2033,"context_line":""},{"line_number":2034,"context_line":"    def _parse_timestamp(self, time_str):"},{"line_number":2035,"context_line":"        \"\"\"Parse timestamp string into a number.\"\"\""},{"line_number":2036,"context_line":""},{"line_number":2037,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1bb3f7fa_5ebba5dc","line":2034,"updated":"2023-02-16 01:29:03.000000000","message":"@na_utils.trace","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2031,"context_line":""},{"line_number":2032,"context_line":"        return volume"},{"line_number":2033,"context_line":""},{"line_number":2034,"context_line":"    def _parse_timestamp(self, time_str):"},{"line_number":2035,"context_line":"        \"\"\"Parse timestamp string into a number.\"\"\""},{"line_number":2036,"context_line":""},{"line_number":2037,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"29b1234b_86e8bd0a","line":2034,"in_reply_to":"1bb3f7fa_5ebba5dc","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4989bee320360d957a55d2c0ae9297cd8fe9232","unresolved":true,"context_lines":[{"line_number":2041,"context_line":"            LOG.debug(\"Failed to parse timestamp: %s\", time_str)"},{"line_number":2042,"context_line":"            raise"},{"line_number":2043,"context_line":""},{"line_number":2044,"context_line":"    def _get_snapmirrors(self, source_path\u003dNone, dest_path\u003dNone,"},{"line_number":2045,"context_line":"                         source_vserver\u003dNone, source_volume\u003dNone,"},{"line_number":2046,"context_line":"                         dest_vserver\u003dNone, dest_volume\u003dNone,"},{"line_number":2047,"context_line":"                         list_destinations_only\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"86bb10ea_26d26c14","line":2044,"updated":"2023-02-16 01:29:03.000000000","message":"@na_utils.trace + please add docstring","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2041,"context_line":"            LOG.debug(\"Failed to parse timestamp: %s\", time_str)"},{"line_number":2042,"context_line":"            raise"},{"line_number":2043,"context_line":""},{"line_number":2044,"context_line":"    def _get_snapmirrors(self, source_path\u003dNone, dest_path\u003dNone,"},{"line_number":2045,"context_line":"                         source_vserver\u003dNone, source_volume\u003dNone,"},{"line_number":2046,"context_line":"                         dest_vserver\u003dNone, dest_volume\u003dNone,"},{"line_number":2047,"context_line":"                         list_destinations_only\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"24761c51_03347e89","line":2044,"in_reply_to":"86bb10ea_26d26c14","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4989bee320360d957a55d2c0ae9297cd8fe9232","unresolved":true,"context_lines":[{"line_number":2228,"context_line":"                                                 is_flexgroup\u003dis_flexgroup)"},{"line_number":2229,"context_line":""},{"line_number":2230,"context_line":"    @na_utils.trace"},{"line_number":2231,"context_line":"    def get_nfs_export_policy_for_volume(self, volume_name):"},{"line_number":2232,"context_line":"        query \u003d {"},{"line_number":2233,"context_line":"            \u0027name\u0027: volume_name,"},{"line_number":2234,"context_line":"            \u0027fields\u0027: \u0027nas.export_policy.name\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"ebfbe761_efb7cec1","line":2231,"updated":"2023-02-16 01:29:03.000000000","message":"please add docstrings to this and the methods below","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2228,"context_line":"                                                 is_flexgroup\u003dis_flexgroup)"},{"line_number":2229,"context_line":""},{"line_number":2230,"context_line":"    @na_utils.trace"},{"line_number":2231,"context_line":"    def get_nfs_export_policy_for_volume(self, volume_name):"},{"line_number":2232,"context_line":"        query \u003d {"},{"line_number":2233,"context_line":"            \u0027name\u0027: volume_name,"},{"line_number":2234,"context_line":"            \u0027fields\u0027: \u0027nas.export_policy.name\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"06794eed_a782ea0c","line":2231,"in_reply_to":"ebfbe761_efb7cec1","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":2240,"context_line":"            msg \u003d _(\u0027Could not find export policy for volume %s.\u0027)"},{"line_number":2241,"context_line":"            raise exception.NetAppException(msg % volume_name)"},{"line_number":2242,"context_line":""},{"line_number":2243,"context_line":"        record \u003d res.get(\u0027records\u0027, [])[0]"},{"line_number":2244,"context_line":""},{"line_number":2245,"context_line":"        return record.get(\u0027nas\u0027).get(\u0027export_policy\u0027).get(\u0027name\u0027)"},{"line_number":2246,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"457d4882_13a7fc1c","line":2243,"range":{"start_line":2243,"start_character":17,"end_line":2243,"end_character":42},"updated":"2023-02-16 03:22:29.000000000","message":"already check has records, so simply: res[\u0027records\u0027][0]","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":2240,"context_line":"            msg \u003d _(\u0027Could not find export policy for volume %s.\u0027)"},{"line_number":2241,"context_line":"            raise exception.NetAppException(msg % volume_name)"},{"line_number":2242,"context_line":""},{"line_number":2243,"context_line":"        record \u003d res.get(\u0027records\u0027, [])[0]"},{"line_number":2244,"context_line":""},{"line_number":2245,"context_line":"        return record.get(\u0027nas\u0027).get(\u0027export_policy\u0027).get(\u0027name\u0027)"},{"line_number":2246,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da09b429_38a6a2b3","line":2243,"range":{"start_line":2243,"start_character":8,"end_line":2243,"end_character":15},"updated":"2023-02-16 03:22:29.000000000","message":"prefer the word tha represent the object:\n\nvolume \u003d ..","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2240,"context_line":"            msg \u003d _(\u0027Could not find export policy for volume %s.\u0027)"},{"line_number":2241,"context_line":"            raise exception.NetAppException(msg % volume_name)"},{"line_number":2242,"context_line":""},{"line_number":2243,"context_line":"        record \u003d res.get(\u0027records\u0027, [])[0]"},{"line_number":2244,"context_line":""},{"line_number":2245,"context_line":"        return record.get(\u0027nas\u0027).get(\u0027export_policy\u0027).get(\u0027name\u0027)"},{"line_number":2246,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"737eb5f7_7144ec97","line":2243,"range":{"start_line":2243,"start_character":17,"end_line":2243,"end_character":42},"in_reply_to":"457d4882_13a7fc1c","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2240,"context_line":"            msg \u003d _(\u0027Could not find export policy for volume %s.\u0027)"},{"line_number":2241,"context_line":"            raise exception.NetAppException(msg % volume_name)"},{"line_number":2242,"context_line":""},{"line_number":2243,"context_line":"        record \u003d res.get(\u0027records\u0027, [])[0]"},{"line_number":2244,"context_line":""},{"line_number":2245,"context_line":"        return record.get(\u0027nas\u0027).get(\u0027export_policy\u0027).get(\u0027name\u0027)"},{"line_number":2246,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"41d4f265_b574b97b","line":2243,"range":{"start_line":2243,"start_character":8,"end_line":2243,"end_character":15},"in_reply_to":"da09b429_38a6a2b3","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":2242,"context_line":""},{"line_number":2243,"context_line":"        record \u003d res.get(\u0027records\u0027, [])[0]"},{"line_number":2244,"context_line":""},{"line_number":2245,"context_line":"        return record.get(\u0027nas\u0027).get(\u0027export_policy\u0027).get(\u0027name\u0027)"},{"line_number":2246,"context_line":""},{"line_number":2247,"context_line":"    @na_utils.trace"},{"line_number":2248,"context_line":"    def get_unique_export_policy_id(self, policy_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bb169e0f_31d618e8","line":2245,"range":{"start_line":2245,"start_character":15,"end_line":2245,"end_character":65},"updated":"2023-02-16 03:22:29.000000000","message":"record[\u0027nas\u0027][\u0027export_policy\u0027][\u0027name\u0027]","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2242,"context_line":""},{"line_number":2243,"context_line":"        record \u003d res.get(\u0027records\u0027, [])[0]"},{"line_number":2244,"context_line":""},{"line_number":2245,"context_line":"        return record.get(\u0027nas\u0027).get(\u0027export_policy\u0027).get(\u0027name\u0027)"},{"line_number":2246,"context_line":""},{"line_number":2247,"context_line":"    @na_utils.trace"},{"line_number":2248,"context_line":"    def get_unique_export_policy_id(self, policy_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"59ac321d_53f45eb7","line":2245,"range":{"start_line":2245,"start_character":15,"end_line":2245,"end_character":65},"in_reply_to":"bb169e0f_31d618e8","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":2245,"context_line":"        return record.get(\u0027nas\u0027).get(\u0027export_policy\u0027).get(\u0027name\u0027)"},{"line_number":2246,"context_line":""},{"line_number":2247,"context_line":"    @na_utils.trace"},{"line_number":2248,"context_line":"    def get_unique_export_policy_id(self, policy_name):"},{"line_number":2249,"context_line":"        get_uuid \u003d self.send_request("},{"line_number":2250,"context_line":"            \u0027/protocols/nfs/export-policies\u0027, \u0027get\u0027,"},{"line_number":2251,"context_line":"            query\u003d{\u0027name\u0027: policy_name})"}],"source_content_type":"text/x-python","patch_set":5,"id":"c111c365_7fc912a0","line":2248,"range":{"start_line":2248,"start_character":8,"end_line":2248,"end_character":35},"updated":"2023-02-16 03:22:29.000000000","message":"add method documnetaiton","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2245,"context_line":"        return record.get(\u0027nas\u0027).get(\u0027export_policy\u0027).get(\u0027name\u0027)"},{"line_number":2246,"context_line":""},{"line_number":2247,"context_line":"    @na_utils.trace"},{"line_number":2248,"context_line":"    def get_unique_export_policy_id(self, policy_name):"},{"line_number":2249,"context_line":"        get_uuid \u003d self.send_request("},{"line_number":2250,"context_line":"            \u0027/protocols/nfs/export-policies\u0027, \u0027get\u0027,"},{"line_number":2251,"context_line":"            query\u003d{\u0027name\u0027: policy_name})"}],"source_content_type":"text/x-python","patch_set":5,"id":"be2f7611_dba4192b","line":2248,"range":{"start_line":2248,"start_character":8,"end_line":2248,"end_character":35},"in_reply_to":"c111c365_7fc912a0","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":2254,"context_line":"            msg \u003d _(\u0027Could not find export policy with name %s.\u0027)"},{"line_number":2255,"context_line":"            raise exception.NetAppException(msg % policy_name)"},{"line_number":2256,"context_line":""},{"line_number":2257,"context_line":"        uuid \u003d get_uuid[\u0027records\u0027][0][\u0027id\u0027]"},{"line_number":2258,"context_line":"        return uuid"},{"line_number":2259,"context_line":""},{"line_number":2260,"context_line":"    @na_utils.trace"},{"line_number":2261,"context_line":"    def _get_nfs_export_rule_indices(self, policy_name, client_match):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fe64fdfe_1d06f439","line":2258,"range":{"start_line":2257,"start_character":8,"end_line":2258,"end_character":19},"updated":"2023-02-16 03:22:29.000000000","message":"return get_uuid[\u0027records\u0027][0][\u0027id\u0027]","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2254,"context_line":"            msg \u003d _(\u0027Could not find export policy with name %s.\u0027)"},{"line_number":2255,"context_line":"            raise exception.NetAppException(msg % policy_name)"},{"line_number":2256,"context_line":""},{"line_number":2257,"context_line":"        uuid \u003d get_uuid[\u0027records\u0027][0][\u0027id\u0027]"},{"line_number":2258,"context_line":"        return uuid"},{"line_number":2259,"context_line":""},{"line_number":2260,"context_line":"    @na_utils.trace"},{"line_number":2261,"context_line":"    def _get_nfs_export_rule_indices(self, policy_name, client_match):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ab1d3f1_362e4245","line":2258,"range":{"start_line":2257,"start_character":8,"end_line":2258,"end_character":19},"in_reply_to":"fe64fdfe_1d06f439","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":2258,"context_line":"        return uuid"},{"line_number":2259,"context_line":""},{"line_number":2260,"context_line":"    @na_utils.trace"},{"line_number":2261,"context_line":"    def _get_nfs_export_rule_indices(self, policy_name, client_match):"},{"line_number":2262,"context_line":"        uuid \u003d self.get_unique_export_policy_id(policy_name)"},{"line_number":2263,"context_line":""},{"line_number":2264,"context_line":"        query \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"15b078df_8fc311d8","line":2261,"range":{"start_line":2261,"start_character":8,"end_line":2261,"end_character":36},"updated":"2023-02-16 03:22:29.000000000","message":"add method documnetaiton","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2258,"context_line":"        return uuid"},{"line_number":2259,"context_line":""},{"line_number":2260,"context_line":"    @na_utils.trace"},{"line_number":2261,"context_line":"    def _get_nfs_export_rule_indices(self, policy_name, client_match):"},{"line_number":2262,"context_line":"        uuid \u003d self.get_unique_export_policy_id(policy_name)"},{"line_number":2263,"context_line":""},{"line_number":2264,"context_line":"        query \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"0be8bd08_b821a74d","line":2261,"range":{"start_line":2261,"start_character":8,"end_line":2261,"end_character":36},"in_reply_to":"15b078df_8fc311d8","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":2276,"context_line":"        return [str(i) for i in indices]"},{"line_number":2277,"context_line":""},{"line_number":2278,"context_line":"    @na_utils.trace"},{"line_number":2279,"context_line":"    def _add_nfs_export_rule(self, policy_name, client_match, readonly,"},{"line_number":2280,"context_line":"                             auth_methods):"},{"line_number":2281,"context_line":"        uuid \u003d self.get_unique_export_policy_id(policy_name)"},{"line_number":2282,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"28a6d32a_50469793","line":2279,"range":{"start_line":2279,"start_character":8,"end_line":2279,"end_character":28},"updated":"2023-02-16 03:22:29.000000000","message":"add method documnetaiton","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2276,"context_line":"        return [str(i) for i in indices]"},{"line_number":2277,"context_line":""},{"line_number":2278,"context_line":"    @na_utils.trace"},{"line_number":2279,"context_line":"    def _add_nfs_export_rule(self, policy_name, client_match, readonly,"},{"line_number":2280,"context_line":"                             auth_methods):"},{"line_number":2281,"context_line":"        uuid \u003d self.get_unique_export_policy_id(policy_name)"},{"line_number":2282,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"d19e5683_33925e61","line":2279,"range":{"start_line":2279,"start_character":8,"end_line":2279,"end_character":28},"in_reply_to":"28a6d32a_50469793","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":2298,"context_line":"                          \u0027post\u0027, body\u003dbody)"},{"line_number":2299,"context_line":""},{"line_number":2300,"context_line":"    @na_utils.trace"},{"line_number":2301,"context_line":"    def _update_nfs_export_rule(self, policy_name, client_match, readonly,"},{"line_number":2302,"context_line":"                                rule_index, auth_methods):"},{"line_number":2303,"context_line":"        uuid \u003d self.get_unique_export_policy_id(policy_name)"},{"line_number":2304,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"7cbad5a9_b77d25b5","line":2301,"range":{"start_line":2301,"start_character":8,"end_line":2301,"end_character":31},"updated":"2023-02-16 03:22:29.000000000","message":"add method documnetaiton","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2298,"context_line":"                          \u0027post\u0027, body\u003dbody)"},{"line_number":2299,"context_line":""},{"line_number":2300,"context_line":"    @na_utils.trace"},{"line_number":2301,"context_line":"    def _update_nfs_export_rule(self, policy_name, client_match, readonly,"},{"line_number":2302,"context_line":"                                rule_index, auth_methods):"},{"line_number":2303,"context_line":"        uuid \u003d self.get_unique_export_policy_id(policy_name)"},{"line_number":2304,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"08e09b9e_c7b5c3af","line":2301,"range":{"start_line":2301,"start_character":8,"end_line":2301,"end_character":31},"in_reply_to":"7cbad5a9_b77d25b5","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":2320,"context_line":"                          {rule_index}\u0027, \u0027patch\u0027, body\u003dbody)"},{"line_number":2321,"context_line":""},{"line_number":2322,"context_line":"    @na_utils.trace"},{"line_number":2323,"context_line":"    def _remove_nfs_export_rules(self, policy_name, rule_indices):"},{"line_number":2324,"context_line":"        uuid \u003d self.get_unique_export_policy_id(policy_name)"},{"line_number":2325,"context_line":"        for rule_index in rule_indices:"},{"line_number":2326,"context_line":"            body \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"5c619484_dad7cd1d","line":2323,"range":{"start_line":2323,"start_character":8,"end_line":2323,"end_character":32},"updated":"2023-02-16 03:22:29.000000000","message":"add method documnetaiton","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2320,"context_line":"                          {rule_index}\u0027, \u0027patch\u0027, body\u003dbody)"},{"line_number":2321,"context_line":""},{"line_number":2322,"context_line":"    @na_utils.trace"},{"line_number":2323,"context_line":"    def _remove_nfs_export_rules(self, policy_name, rule_indices):"},{"line_number":2324,"context_line":"        uuid \u003d self.get_unique_export_policy_id(policy_name)"},{"line_number":2325,"context_line":"        for rule_index in rule_indices:"},{"line_number":2326,"context_line":"            body \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a8f9ff2_50c2685b","line":2323,"range":{"start_line":2323,"start_character":8,"end_line":2323,"end_character":32},"in_reply_to":"5c619484_dad7cd1d","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e5c3a03d06a2db317c9911a4861a03ccb9be4a1b","unresolved":true,"context_lines":[{"line_number":2327,"context_line":"                \u0027index\u0027: rule_index"},{"line_number":2328,"context_line":"            }"},{"line_number":2329,"context_line":"            try:"},{"line_number":2330,"context_line":"                self.send_request(f\u0027/protocols/nfs/export-policies/{uuid}/rules/\\"},{"line_number":2331,"context_line":"                          {rule_index}\u0027, \u0027delete\u0027, body\u003dbody)"},{"line_number":2332,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":2333,"context_line":"                if e.code !\u003d netapp_api.EOBJECTNOTFOUND:"}],"source_content_type":"text/x-python","patch_set":5,"id":"48d72268_8031bda4","line":2330,"range":{"start_line":2330,"start_character":80,"end_line":2330,"end_character":81},"updated":"2023-02-16 16:07:02.000000000","message":"don\u0027t use `\\` to break lines, you can use:\n\n        for r_index in rule_indices:\n            body \u003d {\n                \u0027index\u0027: r_index\n            }\n            action \u003d f\u0027/protocols/nfs/export-policies/{uuid}/rules/{r_index}\u0027\n            try:\n                self.send_request(action, \u0027delete\u0027, body\u003dbody)","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2327,"context_line":"                \u0027index\u0027: rule_index"},{"line_number":2328,"context_line":"            }"},{"line_number":2329,"context_line":"            try:"},{"line_number":2330,"context_line":"                self.send_request(f\u0027/protocols/nfs/export-policies/{uuid}/rules/\\"},{"line_number":2331,"context_line":"                          {rule_index}\u0027, \u0027delete\u0027, body\u003dbody)"},{"line_number":2332,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":2333,"context_line":"                if e.code !\u003d netapp_api.EOBJECTNOTFOUND:"}],"source_content_type":"text/x-python","patch_set":5,"id":"78cf747c_5faa3ed7","line":2330,"range":{"start_line":2330,"start_character":80,"end_line":2330,"end_character":81},"in_reply_to":"48d72268_8031bda4","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e03ad282164a3897937f50c99befebf92ca8afb1","unresolved":true,"context_lines":[{"line_number":2329,"context_line":"            try:"},{"line_number":2330,"context_line":"                self.send_request(f\u0027/protocols/nfs/export-policies/{uuid}/rules/\\"},{"line_number":2331,"context_line":"                          {rule_index}\u0027, \u0027delete\u0027, body\u003dbody)"},{"line_number":2332,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":2333,"context_line":"                if e.code !\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":2334,"context_line":"                    raise"},{"line_number":2335,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"04a3d278_64d4565a","line":2332,"range":{"start_line":2332,"start_character":12,"end_line":2332,"end_character":46},"updated":"2023-02-17 01:53:05.000000000","message":"This object is wrongly accessed. It should be \"netapp_api.api\"","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2329,"context_line":"            try:"},{"line_number":2330,"context_line":"                self.send_request(f\u0027/protocols/nfs/export-policies/{uuid}/rules/\\"},{"line_number":2331,"context_line":"                          {rule_index}\u0027, \u0027delete\u0027, body\u003dbody)"},{"line_number":2332,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":2333,"context_line":"                if e.code !\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":2334,"context_line":"                    raise"},{"line_number":2335,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"2ac5f1a9_9a6e15d8","line":2332,"range":{"start_line":2332,"start_character":12,"end_line":2332,"end_character":46},"in_reply_to":"04a3d278_64d4565a","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":2330,"context_line":"                self.send_request(f\u0027/protocols/nfs/export-policies/{uuid}/rules/\\"},{"line_number":2331,"context_line":"                          {rule_index}\u0027, \u0027delete\u0027, body\u003dbody)"},{"line_number":2332,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":2333,"context_line":"                if e.code !\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":2334,"context_line":"                    raise"},{"line_number":2335,"context_line":""},{"line_number":2336,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"f7acc775_08af1947","line":2333,"range":{"start_line":2333,"start_character":16,"end_line":2333,"end_character":55},"updated":"2023-02-16 03:22:29.000000000","message":"this is not the code for REST, it came from ZAPI. Please, fix the code with the correct object/code.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2330,"context_line":"                self.send_request(f\u0027/protocols/nfs/export-policies/{uuid}/rules/\\"},{"line_number":2331,"context_line":"                          {rule_index}\u0027, \u0027delete\u0027, body\u003dbody)"},{"line_number":2332,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":2333,"context_line":"                if e.code !\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":2334,"context_line":"                    raise"},{"line_number":2335,"context_line":""},{"line_number":2336,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"d0e8fd32_504fa1ce","line":2333,"range":{"start_line":2333,"start_character":16,"end_line":2333,"end_character":55},"in_reply_to":"0c928419_78c40a78","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e5c3a03d06a2db317c9911a4861a03ccb9be4a1b","unresolved":true,"context_lines":[{"line_number":2330,"context_line":"                self.send_request(f\u0027/protocols/nfs/export-policies/{uuid}/rules/\\"},{"line_number":2331,"context_line":"                          {rule_index}\u0027, \u0027delete\u0027, body\u003dbody)"},{"line_number":2332,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":2333,"context_line":"                if e.code !\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":2334,"context_line":"                    raise"},{"line_number":2335,"context_line":""},{"line_number":2336,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"0c928419_78c40a78","line":2333,"range":{"start_line":2333,"start_character":16,"end_line":2333,"end_character":55},"in_reply_to":"f7acc775_08af1947","updated":"2023-02-16 16:07:02.000000000","message":"s/EOBJECTNOTFOUND/ENTRYNOTFOUND/","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":2334,"context_line":"                    raise"},{"line_number":2335,"context_line":""},{"line_number":2336,"context_line":"    @na_utils.trace"},{"line_number":2337,"context_line":"    def get_cifs_share_access(self, share_name):"},{"line_number":2338,"context_line":"        query \u003d {"},{"line_number":2339,"context_line":"            \u0027name\u0027: share_name,"},{"line_number":2340,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":5,"id":"030d157e_bc949a1d","line":2337,"range":{"start_line":2337,"start_character":8,"end_line":2337,"end_character":29},"updated":"2023-02-16 03:22:29.000000000","message":"add method documnetaiton","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2334,"context_line":"                    raise"},{"line_number":2335,"context_line":""},{"line_number":2336,"context_line":"    @na_utils.trace"},{"line_number":2337,"context_line":"    def get_cifs_share_access(self, share_name):"},{"line_number":2338,"context_line":"        query \u003d {"},{"line_number":2339,"context_line":"            \u0027name\u0027: share_name,"},{"line_number":2340,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":5,"id":"84be5cf4_39aaf3cf","line":2337,"range":{"start_line":2337,"start_character":8,"end_line":2337,"end_character":29},"in_reply_to":"030d157e_bc949a1d","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":2347,"context_line":"            \u0027get\u0027, query\u003dquery)"},{"line_number":2348,"context_line":""},{"line_number":2349,"context_line":"        rules \u003d {}"},{"line_number":2350,"context_line":""},{"line_number":2351,"context_line":"        for records in result[\"records\"]:"},{"line_number":2352,"context_line":"            user_or_group \u003d records[\u0027user_or_group\u0027]"},{"line_number":2353,"context_line":"            permission \u003d records[\u0027permission\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"479e29cf_a4b8dd40","line":2350,"updated":"2023-02-16 03:22:29.000000000","message":"remove this extra line","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2347,"context_line":"            \u0027get\u0027, query\u003dquery)"},{"line_number":2348,"context_line":""},{"line_number":2349,"context_line":"        rules \u003d {}"},{"line_number":2350,"context_line":""},{"line_number":2351,"context_line":"        for records in result[\"records\"]:"},{"line_number":2352,"context_line":"            user_or_group \u003d records[\u0027user_or_group\u0027]"},{"line_number":2353,"context_line":"            permission \u003d records[\u0027permission\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"d754a7c3_79c35121","line":2350,"in_reply_to":"479e29cf_a4b8dd40","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":2356,"context_line":"        return rules"},{"line_number":2357,"context_line":""},{"line_number":2358,"context_line":"    @na_utils.trace"},{"line_number":2359,"context_line":"    def add_cifs_share_access(self, share_name, user_name, readonly):"},{"line_number":2360,"context_line":"        query \u003d {"},{"line_number":2361,"context_line":"            \u0027name\u0027: share_name"},{"line_number":2362,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":5,"id":"e3377404_72f65984","line":2359,"range":{"start_line":2359,"start_character":8,"end_line":2359,"end_character":29},"updated":"2023-02-16 03:22:29.000000000","message":"add method documnetaiton","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2356,"context_line":"        return rules"},{"line_number":2357,"context_line":""},{"line_number":2358,"context_line":"    @na_utils.trace"},{"line_number":2359,"context_line":"    def add_cifs_share_access(self, share_name, user_name, readonly):"},{"line_number":2360,"context_line":"        query \u003d {"},{"line_number":2361,"context_line":"            \u0027name\u0027: share_name"},{"line_number":2362,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":5,"id":"56b27f6d_d99e59d2","line":2359,"range":{"start_line":2359,"start_character":8,"end_line":2359,"end_character":29},"in_reply_to":"e3377404_72f65984","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":2375,"context_line":"            \u0027post\u0027, body\u003dbody)"},{"line_number":2376,"context_line":""},{"line_number":2377,"context_line":"    @na_utils.trace"},{"line_number":2378,"context_line":"    def modify_cifs_share_access(self, share_name, user_name, readonly):"},{"line_number":2379,"context_line":"        query \u003d {"},{"line_number":2380,"context_line":"            \u0027name\u0027: share_name"},{"line_number":2381,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":5,"id":"4a7c2acf_108dcda2","line":2378,"range":{"start_line":2378,"start_character":8,"end_line":2378,"end_character":32},"updated":"2023-02-16 03:22:29.000000000","message":"add method documnetaiton","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2375,"context_line":"            \u0027post\u0027, body\u003dbody)"},{"line_number":2376,"context_line":""},{"line_number":2377,"context_line":"    @na_utils.trace"},{"line_number":2378,"context_line":"    def modify_cifs_share_access(self, share_name, user_name, readonly):"},{"line_number":2379,"context_line":"        query \u003d {"},{"line_number":2380,"context_line":"            \u0027name\u0027: share_name"},{"line_number":2381,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":5,"id":"8be02504_21c84df3","line":2378,"range":{"start_line":2378,"start_character":8,"end_line":2378,"end_character":32},"in_reply_to":"4a7c2acf_108dcda2","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"}],"manila/share/drivers/netapp/dataontap/client/rest_api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"REST_DUPLICATE_ENTRY \u003d \u00271\u0027"},{"line_number":37,"context_line":"ESIS_CLONE_NOT_LICENSED \u003d \u002714956\u0027"},{"line_number":38,"context_line":"REST_SNAPMIRROR_INITIALIZING \u003d \u0027917536\u0027"},{"line_number":39,"context_line":"EVSERVERNOTFOUND \u003d \u002713434920\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"22fd60cc_e1ae716e","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":20},"updated":"2023-02-15 06:10:29.000000000","message":"For consistency, couldn\u0027t you prefix all of these with \"E\" so you know this is an error..","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4989bee320360d957a55d2c0ae9297cd8fe9232","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"REST_DUPLICATE_ENTRY \u003d \u00271\u0027"},{"line_number":37,"context_line":"ESIS_CLONE_NOT_LICENSED \u003d \u002714956\u0027"},{"line_number":38,"context_line":"REST_SNAPMIRROR_INITIALIZING \u003d \u0027917536\u0027"},{"line_number":39,"context_line":"EVSERVERNOTFOUND \u003d \u002713434920\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"eab84067_dbfb4e26","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":20},"in_reply_to":"22fd60cc_e1ae716e","updated":"2023-02-16 01:29:03.000000000","message":"+1","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"REST_DUPLICATE_ENTRY \u003d \u00271\u0027"},{"line_number":37,"context_line":"ESIS_CLONE_NOT_LICENSED \u003d \u002714956\u0027"},{"line_number":38,"context_line":"REST_SNAPMIRROR_INITIALIZING \u003d \u0027917536\u0027"},{"line_number":39,"context_line":"EVSERVERNOTFOUND \u003d \u002713434920\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da06017d_16d512bc","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":20},"in_reply_to":"eab84067_dbfb4e26","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8b4c0d253341c277b2ab7ef868fce96162191a22","unresolved":true,"context_lines":[{"line_number":348,"context_line":"            # the license exists. By the got error, it checks whether license"},{"line_number":349,"context_line":"            # is installed or not."},{"line_number":350,"context_line":"            try:"},{"line_number":351,"context_line":"                self._client.restore_snapshot("},{"line_number":352,"context_line":"                    \"fake_%s\" % uuidutils.generate_uuid(dashed\u003dFalse), \"\")"},{"line_number":353,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":354,"context_line":"                no_license \u003d \u0027is not licensed\u0027"},{"line_number":355,"context_line":"                LOG.debug(\u0027Fake restore_snapshot request failed: %s\u0027, e)"}],"source_content_type":"text/x-python","patch_set":5,"id":"313cf4e6_ab4127dc","line":352,"range":{"start_line":351,"start_character":16,"end_line":352,"end_character":74},"updated":"2023-02-21 03:11:00.000000000","message":"It won\u0027t work with REST. Please, add it to client layer and implement the REST one.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            # the license exists. By the got error, it checks whether license"},{"line_number":349,"context_line":"            # is installed or not."},{"line_number":350,"context_line":"            try:"},{"line_number":351,"context_line":"                self._client.restore_snapshot("},{"line_number":352,"context_line":"                    \"fake_%s\" % uuidutils.generate_uuid(dashed\u003dFalse), \"\")"},{"line_number":353,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":354,"context_line":"                no_license \u003d \u0027is not licensed\u0027"},{"line_number":355,"context_line":"                LOG.debug(\u0027Fake restore_snapshot request failed: %s\u0027, e)"}],"source_content_type":"text/x-python","patch_set":5,"id":"f3851b3f_db44df0b","line":352,"range":{"start_line":351,"start_character":16,"end_line":352,"end_character":74},"in_reply_to":"313cf4e6_ab4127dc","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":1095,"context_line":"                  \u0027provisioning options %(options)s\u0027,"},{"line_number":1096,"context_line":"                  {\u0027share\u0027: share_name, \u0027pool\u0027: pool_name,"},{"line_number":1097,"context_line":"                   \u0027options\u0027: provisioning_options})"},{"line_number":1098,"context_line":"        is_flexgroup \u003d self._is_flexgroup_pool(pool_name)"},{"line_number":1099,"context_line":"        if is_flexgroup:"},{"line_number":1100,"context_line":"            aggr_list \u003d self._get_flexgroup_aggregate_list(pool_name)"},{"line_number":1101,"context_line":"            start_timeout \u003d ("},{"line_number":1102,"context_line":"                self.configuration.netapp_flexgroup_aggregate_not_busy_timeout)"},{"line_number":1103,"context_line":"            job_info \u003d self.wait_for_start_create_flexgroup("},{"line_number":1104,"context_line":"                start_timeout, vserver_client, aggr_list, share_name,"},{"line_number":1105,"context_line":"                share[\u0027size\u0027], snapshot_reserve\u003dself.configuration."},{"line_number":1106,"context_line":"                netapp_volume_snapshot_reserve_percent, **provisioning_options)"},{"line_number":1107,"context_line":"        else:"},{"line_number":1108,"context_line":"            job_info \u003d vserver_client.create_volume("},{"line_number":1109,"context_line":"                pool_name, share_name, share[\u0027size\u0027],"},{"line_number":1110,"context_line":"                snapshot_reserve\u003dself.configuration."},{"line_number":1111,"context_line":"                netapp_volume_snapshot_reserve_percent,"},{"line_number":1112,"context_line":"                **provisioning_options)"},{"line_number":1113,"context_line":"        if job_info:"},{"line_number":1114,"context_line":"            self._set_max_files_and_efficiency("},{"line_number":1115,"context_line":"                job_info, vserver_client, share_name, is_flexgroup,"},{"line_number":1116,"context_line":"                dedup_enabled\u003dprovisioning_options[\u0027dedup_enabled\u0027],"},{"line_number":1117,"context_line":"                compression_enabled\u003d("},{"line_number":1118,"context_line":"                    provisioning_options[\u0027compression_enabled\u0027]),"},{"line_number":1119,"context_line":"                max_files\u003dprovisioning_options[\u0027max_files\u0027])"},{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"        if hide_snapdir:"},{"line_number":1122,"context_line":"            self._apply_snapdir_visibility("}],"source_content_type":"text/x-python","patch_set":5,"id":"e7887f49_27793ac7","line":1119,"range":{"start_line":1098,"start_character":7,"end_line":1119,"end_character":60},"updated":"2023-02-16 03:22:29.000000000","message":"we should avoid changing the driver keeping the REST transition separated code:\n\n1. Easier to backport it to older releases\n2. Less prone to add bugs to existent ZAPI solutio","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"                  \u0027provisioning options %(options)s\u0027,"},{"line_number":1096,"context_line":"                  {\u0027share\u0027: share_name, \u0027pool\u0027: pool_name,"},{"line_number":1097,"context_line":"                   \u0027options\u0027: provisioning_options})"},{"line_number":1098,"context_line":"        is_flexgroup \u003d self._is_flexgroup_pool(pool_name)"},{"line_number":1099,"context_line":"        if is_flexgroup:"},{"line_number":1100,"context_line":"            aggr_list \u003d self._get_flexgroup_aggregate_list(pool_name)"},{"line_number":1101,"context_line":"            start_timeout \u003d ("},{"line_number":1102,"context_line":"                self.configuration.netapp_flexgroup_aggregate_not_busy_timeout)"},{"line_number":1103,"context_line":"            job_info \u003d self.wait_for_start_create_flexgroup("},{"line_number":1104,"context_line":"                start_timeout, vserver_client, aggr_list, share_name,"},{"line_number":1105,"context_line":"                share[\u0027size\u0027], snapshot_reserve\u003dself.configuration."},{"line_number":1106,"context_line":"                netapp_volume_snapshot_reserve_percent, **provisioning_options)"},{"line_number":1107,"context_line":"        else:"},{"line_number":1108,"context_line":"            job_info \u003d vserver_client.create_volume("},{"line_number":1109,"context_line":"                pool_name, share_name, share[\u0027size\u0027],"},{"line_number":1110,"context_line":"                snapshot_reserve\u003dself.configuration."},{"line_number":1111,"context_line":"                netapp_volume_snapshot_reserve_percent,"},{"line_number":1112,"context_line":"                **provisioning_options)"},{"line_number":1113,"context_line":"        if job_info:"},{"line_number":1114,"context_line":"            self._set_max_files_and_efficiency("},{"line_number":1115,"context_line":"                job_info, vserver_client, share_name, is_flexgroup,"},{"line_number":1116,"context_line":"                dedup_enabled\u003dprovisioning_options[\u0027dedup_enabled\u0027],"},{"line_number":1117,"context_line":"                compression_enabled\u003d("},{"line_number":1118,"context_line":"                    provisioning_options[\u0027compression_enabled\u0027]),"},{"line_number":1119,"context_line":"                max_files\u003dprovisioning_options[\u0027max_files\u0027])"},{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"        if hide_snapdir:"},{"line_number":1122,"context_line":"            self._apply_snapdir_visibility("}],"source_content_type":"text/x-python","patch_set":5,"id":"95752c0c_97de9734","line":1119,"range":{"start_line":1098,"start_character":7,"end_line":1119,"end_character":60},"in_reply_to":"e7887f49_27793ac7","updated":"2023-02-22 18:35:15.000000000","message":"As we discussed, this approach was changed and we decided to remove these changes from lib_base and replicate the ZAPI behavior for flexvol creation (at least, while ZAPI is not deprecated).","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":1152,"context_line":"            msg \u003d \"Error creating share: %s.\""},{"line_number":1153,"context_line":"            raise exception.NetAppException(msg % job_info[\u0027error-message\u0027])"},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"        if is_flexgroup:"},{"line_number":1156,"context_line":"            timeout \u003d self.configuration.netapp_flexgroup_volume_online_timeout"},{"line_number":1157,"context_line":"        else:"},{"line_number":1158,"context_line":"            timeout \u003d self.configuration.netapp_flexvol_volume_online_timeout"},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"        self.wait_for_share_provisioning(vserver_client, job_info[\u0027jobid\u0027],"},{"line_number":1161,"context_line":"                                         timeout)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b19a8104_7c8898b0","line":1158,"range":{"start_line":1155,"start_character":0,"end_line":1158,"end_character":77},"updated":"2023-02-15 06:10:29.000000000","message":"I suggest using the flexgroup timeout for both kinds of volumes and introduce a flexvol timeout config as a separate change that doesn\u0027t need to be backported to older stable releases","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1152,"context_line":"            msg \u003d \"Error creating share: %s.\""},{"line_number":1153,"context_line":"            raise exception.NetAppException(msg % job_info[\u0027error-message\u0027])"},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"        if is_flexgroup:"},{"line_number":1156,"context_line":"            timeout \u003d self.configuration.netapp_flexgroup_volume_online_timeout"},{"line_number":1157,"context_line":"        else:"},{"line_number":1158,"context_line":"            timeout \u003d self.configuration.netapp_flexvol_volume_online_timeout"},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"        self.wait_for_share_provisioning(vserver_client, job_info[\u0027jobid\u0027],"},{"line_number":1161,"context_line":"                                         timeout)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ea129a21_c30a01bb","line":1158,"range":{"start_line":1155,"start_character":0,"end_line":1158,"end_character":77},"in_reply_to":"803139a4_f57375b0","updated":"2023-02-22 18:35:15.000000000","message":"As Felipe said, I removed this change in the last patch set to avoid big changes in lib_base.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4989bee320360d957a55d2c0ae9297cd8fe9232","unresolved":true,"context_lines":[{"line_number":1152,"context_line":"            msg \u003d \"Error creating share: %s.\""},{"line_number":1153,"context_line":"            raise exception.NetAppException(msg % job_info[\u0027error-message\u0027])"},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"        if is_flexgroup:"},{"line_number":1156,"context_line":"            timeout \u003d self.configuration.netapp_flexgroup_volume_online_timeout"},{"line_number":1157,"context_line":"        else:"},{"line_number":1158,"context_line":"            timeout \u003d self.configuration.netapp_flexvol_volume_online_timeout"},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"        self.wait_for_share_provisioning(vserver_client, job_info[\u0027jobid\u0027],"},{"line_number":1161,"context_line":"                                         timeout)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa27d020_fb39fb9c","line":1158,"range":{"start_line":1155,"start_character":0,"end_line":1158,"end_character":77},"in_reply_to":"b19a8104_7c8898b0","updated":"2023-02-16 01:29:03.000000000","message":"+1","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"20e61924ed3fc7143bf935f5968a0207920bbcb5","unresolved":true,"context_lines":[{"line_number":1152,"context_line":"            msg \u003d \"Error creating share: %s.\""},{"line_number":1153,"context_line":"            raise exception.NetAppException(msg % job_info[\u0027error-message\u0027])"},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"        if is_flexgroup:"},{"line_number":1156,"context_line":"            timeout \u003d self.configuration.netapp_flexgroup_volume_online_timeout"},{"line_number":1157,"context_line":"        else:"},{"line_number":1158,"context_line":"            timeout \u003d self.configuration.netapp_flexvol_volume_online_timeout"},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"        self.wait_for_share_provisioning(vserver_client, job_info[\u0027jobid\u0027],"},{"line_number":1161,"context_line":"                                         timeout)"}],"source_content_type":"text/x-python","patch_set":5,"id":"803139a4_f57375b0","line":1158,"range":{"start_line":1155,"start_character":0,"end_line":1158,"end_character":77},"in_reply_to":"b19a8104_7c8898b0","updated":"2023-02-16 03:22:29.000000000","message":"Good point. I think we will drop this driver changes for creating share. We don\u0027t want to change the driver with transitioning to REST. So, this new option should be removed.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"}],"manila/share/drivers/netapp/options.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":185,"context_line":"               default\u003d360,  # Default to six minutes"},{"line_number":186,"context_line":"               help\u003d\u0027Sets time in seconds to wait for a FlexGroup snapshot \u0027"},{"line_number":187,"context_line":"                    \u0027to not be busy with clones after splitting them.\u0027),"},{"line_number":188,"context_line":"    cfg.IntOpt(\u0027netapp_flexvol_volume_online_timeout\u0027,"},{"line_number":189,"context_line":"               min\u003d30,"},{"line_number":190,"context_line":"               default\u003d60,  # Default to one minutes"},{"line_number":191,"context_line":"               help\u003d\u0027Sets time in seconds to wait for a FlexVol share \u0027"},{"line_number":192,"context_line":"                    \u0027create to complete and go online.\u0027), ]"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"netapp_cluster_opts \u003d ["},{"line_number":195,"context_line":"    cfg.StrOpt(\u0027netapp_vserver\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"c387c774_058aace9","line":192,"range":{"start_line":188,"start_character":0,"end_line":192,"end_character":59},"updated":"2023-02-15 06:10:29.000000000","message":"If this isn\u0027t a necessary addition, i would do this as a separate feature because you expect to backport this patch series back several releases and it doesn\u0027t look good adding new features while you pursue that","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":true,"context_lines":[{"line_number":185,"context_line":"               default\u003d360,  # Default to six minutes"},{"line_number":186,"context_line":"               help\u003d\u0027Sets time in seconds to wait for a FlexGroup snapshot \u0027"},{"line_number":187,"context_line":"                    \u0027to not be busy with clones after splitting them.\u0027),"},{"line_number":188,"context_line":"    cfg.IntOpt(\u0027netapp_flexvol_volume_online_timeout\u0027,"},{"line_number":189,"context_line":"               min\u003d30,"},{"line_number":190,"context_line":"               default\u003d60,  # Default to one minutes"},{"line_number":191,"context_line":"               help\u003d\u0027Sets time in seconds to wait for a FlexVol share \u0027"},{"line_number":192,"context_line":"                    \u0027create to complete and go online.\u0027), ]"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"netapp_cluster_opts \u003d ["},{"line_number":195,"context_line":"    cfg.StrOpt(\u0027netapp_vserver\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"cc2e94b4_77a5988c","line":192,"range":{"start_line":188,"start_character":0,"end_line":192,"end_character":59},"in_reply_to":"c387c774_058aace9","updated":"2023-02-22 18:35:15.000000000","message":"We decided to remove this timeout, but we had to add a more generic timeout called `netapp_rest_operation_timeout`. This was necessary because many ZAPI calls that were done synchronously are now asynchronous in the REST API.\n\nTo replicate this synchronous behavior and keep the compatibility, this timeout indicates what is the maximum amount of time a synchronous operation should take. By default, this time is 60 seconds, but we decided to introduce this option because IF a customer finds a problem caused by some operation that is taking more time than expected, he/she can increase the timeout while we implement a better solution for the specific scenario.\n\nPlease, let me know if this approach is ok to you.","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"83f92e5011b7d2825d8a6a587705372f57695691","unresolved":true,"context_lines":[{"line_number":185,"context_line":"               default\u003d360,  # Default to six minutes"},{"line_number":186,"context_line":"               help\u003d\u0027Sets time in seconds to wait for a FlexGroup snapshot \u0027"},{"line_number":187,"context_line":"                    \u0027to not be busy with clones after splitting them.\u0027),"},{"line_number":188,"context_line":"    cfg.IntOpt(\u0027netapp_flexvol_volume_online_timeout\u0027,"},{"line_number":189,"context_line":"               min\u003d30,"},{"line_number":190,"context_line":"               default\u003d60,  # Default to one minutes"},{"line_number":191,"context_line":"               help\u003d\u0027Sets time in seconds to wait for a FlexVol share \u0027"},{"line_number":192,"context_line":"                    \u0027create to complete and go online.\u0027), ]"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"netapp_cluster_opts \u003d ["},{"line_number":195,"context_line":"    cfg.StrOpt(\u0027netapp_vserver\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"d8b518e2_f8dd65cb","line":192,"range":{"start_line":188,"start_character":0,"end_line":192,"end_character":59},"in_reply_to":"cc2e94b4_77a5988c","updated":"2023-02-23 22:09:55.000000000","message":"ack; makes sense. Thanks for checking Nahim!","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"}],"manila/tests/share/drivers/netapp/dataontap/client/test_api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":424,"context_line":"         \u0027patch\u0027)"},{"line_number":425,"context_line":"    )"},{"line_number":426,"context_line":"    @ddt.unpack"},{"line_number":427,"context_line":"    def test__get_request_info(self, api_name, expected_url, expected_method):"},{"line_number":428,"context_line":"        self.root._session \u003d fake.FAKE_HTTP_SESSION"},{"line_number":429,"context_line":"        for http_method in [\u0027post\u0027, \u0027get\u0027, \u0027put\u0027, \u0027delete\u0027, \u0027patch\u0027]:"},{"line_number":430,"context_line":"            setattr(self.root._session, http_method, mock.Mock())"}],"source_content_type":"text/x-python","patch_set":5,"id":"08f1ef35_75ac2e4e","side":"PARENT","line":427,"range":{"start_line":427,"start_character":0,"end_line":427,"end_character":78},"updated":"2023-02-15 06:10:29.000000000","message":"is this removal necessary?","commit_id":"d490f70df5c0fba4056c2ee303c00e47de4f46f7"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":424,"context_line":"         \u0027patch\u0027)"},{"line_number":425,"context_line":"    )"},{"line_number":426,"context_line":"    @ddt.unpack"},{"line_number":427,"context_line":"    def test__get_request_info(self, api_name, expected_url, expected_method):"},{"line_number":428,"context_line":"        self.root._session \u003d fake.FAKE_HTTP_SESSION"},{"line_number":429,"context_line":"        for http_method in [\u0027post\u0027, \u0027get\u0027, \u0027put\u0027, \u0027delete\u0027, \u0027patch\u0027]:"},{"line_number":430,"context_line":"            setattr(self.root._session, http_method, mock.Mock())"}],"source_content_type":"text/x-python","patch_set":5,"id":"6b256128_78fa81a9","side":"PARENT","line":427,"range":{"start_line":427,"start_character":0,"end_line":427,"end_character":78},"in_reply_to":"08f1ef35_75ac2e4e","updated":"2023-02-22 18:35:15.000000000","message":"No. Good catch, it was removed by mistake.","commit_id":"d490f70df5c0fba4056c2ee303c00e47de4f46f7"}],"manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":4854,"context_line":""},{"line_number":4855,"context_line":"        result \u003d self.client.get_snapshot(fake.SHARE_NAME, fake.SNAPSHOT_NAME)"},{"line_number":4856,"context_line":""},{"line_number":4857,"context_line":"        print(result)"},{"line_number":4858,"context_line":""},{"line_number":4859,"context_line":"        print(expected)"},{"line_number":4860,"context_line":"        snapshot_get_iter_args \u003d {"},{"line_number":4861,"context_line":"            \u0027query\u0027: {"},{"line_number":4862,"context_line":"                \u0027snapshot-info\u0027: {"}],"source_content_type":"text/x-python","patch_set":5,"id":"054547ab_58447ce0","line":4859,"range":{"start_line":4857,"start_character":0,"end_line":4859,"end_character":23},"updated":"2023-02-15 06:10:29.000000000","message":"please remove","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":4854,"context_line":""},{"line_number":4855,"context_line":"        result \u003d self.client.get_snapshot(fake.SHARE_NAME, fake.SNAPSHOT_NAME)"},{"line_number":4856,"context_line":""},{"line_number":4857,"context_line":"        print(result)"},{"line_number":4858,"context_line":""},{"line_number":4859,"context_line":"        print(expected)"},{"line_number":4860,"context_line":"        snapshot_get_iter_args \u003d {"},{"line_number":4861,"context_line":"            \u0027query\u0027: {"},{"line_number":4862,"context_line":"                \u0027snapshot-info\u0027: {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a1f3363_1db37c7e","line":4859,"range":{"start_line":4857,"start_character":0,"end_line":4859,"end_character":23},"in_reply_to":"054547ab_58447ce0","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"}],"manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode_rest.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":1491,"context_line":"        self.client.send_request.assert_called_once_with("},{"line_number":1492,"context_line":"            f\u0027/protocols/fpolicy/{uuid}/policies\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":1493,"context_line":""},{"line_number":1494,"context_line":"    @ddt.data(\u0027fake_policy_name\u0027)"},{"line_number":1495,"context_line":"    def test_delete_nfs_export_policy(self, policy_name):"},{"line_number":1496,"context_line":"        query \u003d {"},{"line_number":1497,"context_line":"            \u0027name\u0027: policy_name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"0ccc4f39_aa9820a0","line":1494,"updated":"2023-02-15 06:10:29.000000000","message":"ddt not necessary, there\u0027s just one input","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1491,"context_line":"        self.client.send_request.assert_called_once_with("},{"line_number":1492,"context_line":"            f\u0027/protocols/fpolicy/{uuid}/policies\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":1493,"context_line":""},{"line_number":1494,"context_line":"    @ddt.data(\u0027fake_policy_name\u0027)"},{"line_number":1495,"context_line":"    def test_delete_nfs_export_policy(self, policy_name):"},{"line_number":1496,"context_line":"        query \u003d {"},{"line_number":1497,"context_line":"            \u0027name\u0027: policy_name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"024e27af_e4be3df4","line":1494,"in_reply_to":"0ccc4f39_aa9820a0","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":1514,"context_line":"            mock.call(f\u0027/protocols/nfs/export-policies/{id}\u0027, \u0027delete\u0027),"},{"line_number":1515,"context_line":"        ])"},{"line_number":1516,"context_line":""},{"line_number":1517,"context_line":"    @ddt.data(\u0027fake_volume_name\u0027)"},{"line_number":1518,"context_line":"    def test_delete_volume(self, volume_name):"},{"line_number":1519,"context_line":"        \"\"\"Deletes a volume.\"\"\""},{"line_number":1520,"context_line":"        volume \u003d fake.VOLUME_ITEM_SIMPLE_RESPONSE_REST"}],"source_content_type":"text/x-python","patch_set":5,"id":"cbd97d13_f32c7bbd","line":1517,"updated":"2023-02-15 06:10:29.000000000","message":"ddt not necessary, there\u0027s just one input","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1514,"context_line":"            mock.call(f\u0027/protocols/nfs/export-policies/{id}\u0027, \u0027delete\u0027),"},{"line_number":1515,"context_line":"        ])"},{"line_number":1516,"context_line":""},{"line_number":1517,"context_line":"    @ddt.data(\u0027fake_volume_name\u0027)"},{"line_number":1518,"context_line":"    def test_delete_volume(self, volume_name):"},{"line_number":1519,"context_line":"        \"\"\"Deletes a volume.\"\"\""},{"line_number":1520,"context_line":"        volume \u003d fake.VOLUME_ITEM_SIMPLE_RESPONSE_REST"}],"source_content_type":"text/x-python","patch_set":5,"id":"c9fe49b8_e36bab7f","line":1517,"in_reply_to":"cbd97d13_f32c7bbd","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":1530,"context_line":""},{"line_number":1531,"context_line":"        mock_sr.assert_called_once_with(f\u0027/storage/volumes/{uuid}\u0027, \u0027delete\u0027)"},{"line_number":1532,"context_line":""},{"line_number":1533,"context_line":"    @ddt.data(\u0027fake_volume_name\u0027)"},{"line_number":1534,"context_line":"    def test__unmount_volume(self, volume_name):"},{"line_number":1535,"context_line":"        volume \u003d fake.VOLUME_ITEM_SIMPLE_RESPONSE_REST"},{"line_number":1536,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"332f69e6_65602d08","line":1533,"updated":"2023-02-15 06:10:29.000000000","message":"ddt not necessary, there\u0027s just one input","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1530,"context_line":""},{"line_number":1531,"context_line":"        mock_sr.assert_called_once_with(f\u0027/storage/volumes/{uuid}\u0027, \u0027delete\u0027)"},{"line_number":1532,"context_line":""},{"line_number":1533,"context_line":"    @ddt.data(\u0027fake_volume_name\u0027)"},{"line_number":1534,"context_line":"    def test__unmount_volume(self, volume_name):"},{"line_number":1535,"context_line":"        volume \u003d fake.VOLUME_ITEM_SIMPLE_RESPONSE_REST"},{"line_number":1536,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5bff0add_39ff8a0a","line":1533,"in_reply_to":"332f69e6_65602d08","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":1586,"context_line":"                                                       body\u003dbody),"},{"line_number":1587,"context_line":"        ])"},{"line_number":1588,"context_line":""},{"line_number":1589,"context_line":"    @ddt.data(\u0027extreme\u0027)"},{"line_number":1590,"context_line":"    def test_qos_policy_group_get(self, qos_policy_group_name):"},{"line_number":1591,"context_line":"        qos_policy_group \u003d fake.QOS_POLICY_GROUP_REST"},{"line_number":1592,"context_line":"        qos_policy \u003d qos_policy_group.get(\u0027records\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":5,"id":"611f4adc_0bfc042f","line":1589,"range":{"start_line":1589,"start_character":0,"end_line":1589,"end_character":24},"updated":"2023-02-15 06:10:29.000000000","message":"ddt not necessary, there\u0027s just one input","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1586,"context_line":"                                                       body\u003dbody),"},{"line_number":1587,"context_line":"        ])"},{"line_number":1588,"context_line":""},{"line_number":1589,"context_line":"    @ddt.data(\u0027extreme\u0027)"},{"line_number":1590,"context_line":"    def test_qos_policy_group_get(self, qos_policy_group_name):"},{"line_number":1591,"context_line":"        qos_policy_group \u003d fake.QOS_POLICY_GROUP_REST"},{"line_number":1592,"context_line":"        qos_policy \u003d qos_policy_group.get(\u0027records\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7392f724_512f15af","line":1589,"range":{"start_line":1589,"start_character":0,"end_line":1589,"end_character":24},"in_reply_to":"611f4adc_0bfc042f","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":1634,"context_line":"            mock.call(\u0027/storage/qos/policies\u0027, \u0027get\u0027, query\u003dquery),"},{"line_number":1635,"context_line":"            mock.call(f\u0027/storage/qos/policies/{uuid}\u0027, \u0027delete\u0027)])"},{"line_number":1636,"context_line":""},{"line_number":1637,"context_line":"    @ddt.data(\u0027unmount_name\u0027)"},{"line_number":1638,"context_line":"    def test_unmount_volume(self, unmount_name):"},{"line_number":1639,"context_line":"        mock_unmount \u003d self.mock_object(self.client, \u0027_unmount_volume\u0027)"},{"line_number":1640,"context_line":"        self.client.unmount_volume(unmount_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"f697156b_78924261","line":1637,"range":{"start_line":1637,"start_character":4,"end_line":1637,"end_character":29},"updated":"2023-02-15 06:10:29.000000000","message":"why use ddt here when there\u0027s only one input?","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1634,"context_line":"            mock.call(\u0027/storage/qos/policies\u0027, \u0027get\u0027, query\u003dquery),"},{"line_number":1635,"context_line":"            mock.call(f\u0027/storage/qos/policies/{uuid}\u0027, \u0027delete\u0027)])"},{"line_number":1636,"context_line":""},{"line_number":1637,"context_line":"    @ddt.data(\u0027unmount_name\u0027)"},{"line_number":1638,"context_line":"    def test_unmount_volume(self, unmount_name):"},{"line_number":1639,"context_line":"        mock_unmount \u003d self.mock_object(self.client, \u0027_unmount_volume\u0027)"},{"line_number":1640,"context_line":"        self.client.unmount_volume(unmount_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"a040d0b4_8e62d6dd","line":1637,"range":{"start_line":1637,"start_character":4,"end_line":1637,"end_character":29},"in_reply_to":"f697156b_78924261","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d4989bee320360d957a55d2c0ae9297cd8fe9232","unresolved":true,"context_lines":[{"line_number":1638,"context_line":"    def test_unmount_volume(self, unmount_name):"},{"line_number":1639,"context_line":"        mock_unmount \u003d self.mock_object(self.client, \u0027_unmount_volume\u0027)"},{"line_number":1640,"context_line":"        self.client.unmount_volume(unmount_name)"},{"line_number":1641,"context_line":"        mock_unmount.assert_called_once()"},{"line_number":1642,"context_line":""},{"line_number":1643,"context_line":"    @ddt.data(\u0027extreme\u0027)"},{"line_number":1644,"context_line":"    def test_qos_policy_group_exists(self, qos_policy_group_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"04ca88a2_f9088cfa","line":1641,"range":{"start_line":1641,"start_character":8,"end_line":1641,"end_character":41},"updated":"2023-02-16 01:29:03.000000000","message":"same about assert_called_once vs assert_called_once_with()\nAssert_called_once_with is more precise, so the preference is to use it here and in the below occurrences :)","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1638,"context_line":"    def test_unmount_volume(self, unmount_name):"},{"line_number":1639,"context_line":"        mock_unmount \u003d self.mock_object(self.client, \u0027_unmount_volume\u0027)"},{"line_number":1640,"context_line":"        self.client.unmount_volume(unmount_name)"},{"line_number":1641,"context_line":"        mock_unmount.assert_called_once()"},{"line_number":1642,"context_line":""},{"line_number":1643,"context_line":"    @ddt.data(\u0027extreme\u0027)"},{"line_number":1644,"context_line":"    def test_qos_policy_group_exists(self, qos_policy_group_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"15f63756_534357c1","line":1641,"range":{"start_line":1641,"start_character":8,"end_line":1641,"end_character":41},"in_reply_to":"04ca88a2_f9088cfa","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":1640,"context_line":"        self.client.unmount_volume(unmount_name)"},{"line_number":1641,"context_line":"        mock_unmount.assert_called_once()"},{"line_number":1642,"context_line":""},{"line_number":1643,"context_line":"    @ddt.data(\u0027extreme\u0027)"},{"line_number":1644,"context_line":"    def test_qos_policy_group_exists(self, qos_policy_group_name):"},{"line_number":1645,"context_line":"        mock \u003d self.mock_object(self.client, \u0027qos_policy_group_get\u0027)"},{"line_number":1646,"context_line":"        response \u003d self.client.qos_policy_group_exists(qos_policy_group_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"354e8790_3d91eca0","line":1643,"range":{"start_line":1643,"start_character":0,"end_line":1643,"end_character":24},"updated":"2023-02-15 06:10:29.000000000","message":"same comment as above","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1640,"context_line":"        self.client.unmount_volume(unmount_name)"},{"line_number":1641,"context_line":"        mock_unmount.assert_called_once()"},{"line_number":1642,"context_line":""},{"line_number":1643,"context_line":"    @ddt.data(\u0027extreme\u0027)"},{"line_number":1644,"context_line":"    def test_qos_policy_group_exists(self, qos_policy_group_name):"},{"line_number":1645,"context_line":"        mock \u003d self.mock_object(self.client, \u0027qos_policy_group_get\u0027)"},{"line_number":1646,"context_line":"        response \u003d self.client.qos_policy_group_exists(qos_policy_group_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1d5696d6_76ad7208","line":1643,"range":{"start_line":1643,"start_character":0,"end_line":1643,"end_character":24},"in_reply_to":"354e8790_3d91eca0","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":1647,"context_line":"        mock.assert_called_once()"},{"line_number":1648,"context_line":"        self.assertTrue(response)"},{"line_number":1649,"context_line":""},{"line_number":1650,"context_line":"    @ddt.data(\u0027extreme\u0027)"},{"line_number":1651,"context_line":"    def test_mark_qos_policy_group_for_deletion(self, qos_policy_group_name):"},{"line_number":1652,"context_line":"        mock_exists \u003d self.mock_object(self.client, \u0027qos_policy_group_exists\u0027,"},{"line_number":1653,"context_line":"                                       mock.Mock(return_value\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":5,"id":"b261827d_230e0421","line":1650,"range":{"start_line":1650,"start_character":0,"end_line":1650,"end_character":24},"updated":"2023-02-15 06:10:29.000000000","message":"same comment as above","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":1647,"context_line":"        mock.assert_called_once()"},{"line_number":1648,"context_line":"        self.assertTrue(response)"},{"line_number":1649,"context_line":""},{"line_number":1650,"context_line":"    @ddt.data(\u0027extreme\u0027)"},{"line_number":1651,"context_line":"    def test_mark_qos_policy_group_for_deletion(self, qos_policy_group_name):"},{"line_number":1652,"context_line":"        mock_exists \u003d self.mock_object(self.client, \u0027qos_policy_group_exists\u0027,"},{"line_number":1653,"context_line":"                                       mock.Mock(return_value\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":5,"id":"03b06944_a2da2f55","line":1650,"range":{"start_line":1650,"start_character":0,"end_line":1650,"end_character":24},"in_reply_to":"b261827d_230e0421","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":2249,"context_line":"        mock_sr \u003d self.mock_object(self.client, \u0027send_request\u0027,"},{"line_number":2250,"context_line":"                                   mock.Mock(return_value\u003dret))"},{"line_number":2251,"context_line":"        res \u003d self.client.get_nfs_export_policy_for_volume(\u0027fake_volume_name\u0027)"},{"line_number":2252,"context_line":"        mock_records.assert_called_once()"},{"line_number":2253,"context_line":"        mock_sr.assert_called_once()"},{"line_number":2254,"context_line":"        expected \u003d \u0027fake_name\u0027"},{"line_number":2255,"context_line":"        self.assertEqual(expected, res)"}],"source_content_type":"text/x-python","patch_set":5,"id":"d957ccba_a095bce2","line":2252,"updated":"2023-02-15 06:10:29.000000000","message":"prefer the use of assert_called_once_with(...) over this here and below...","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2249,"context_line":"        mock_sr \u003d self.mock_object(self.client, \u0027send_request\u0027,"},{"line_number":2250,"context_line":"                                   mock.Mock(return_value\u003dret))"},{"line_number":2251,"context_line":"        res \u003d self.client.get_nfs_export_policy_for_volume(\u0027fake_volume_name\u0027)"},{"line_number":2252,"context_line":"        mock_records.assert_called_once()"},{"line_number":2253,"context_line":"        mock_sr.assert_called_once()"},{"line_number":2254,"context_line":"        expected \u003d \u0027fake_name\u0027"},{"line_number":2255,"context_line":"        self.assertEqual(expected, res)"}],"source_content_type":"text/x-python","patch_set":5,"id":"221617d8_bbaa021d","line":2252,"in_reply_to":"d957ccba_a095bce2","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":2268,"context_line":"        mock_sr \u003d self.mock_object(self.client, \u0027send_request\u0027,"},{"line_number":2269,"context_line":"                                   mock.Mock(return_value\u003dret))"},{"line_number":2270,"context_line":"        res \u003d self.client.get_unique_export_policy_id(\u0027fake_policy_name\u0027)"},{"line_number":2271,"context_line":"        mock_records.assert_called_once()"},{"line_number":2272,"context_line":"        mock_sr.assert_called_once()"},{"line_number":2273,"context_line":"        self.assertEqual(expected, res)"},{"line_number":2274,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"09ab9546_e4ad0d9e","line":2271,"updated":"2023-02-15 06:10:29.000000000","message":"same","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2268,"context_line":"        mock_sr \u003d self.mock_object(self.client, \u0027send_request\u0027,"},{"line_number":2269,"context_line":"                                   mock.Mock(return_value\u003dret))"},{"line_number":2270,"context_line":"        res \u003d self.client.get_unique_export_policy_id(\u0027fake_policy_name\u0027)"},{"line_number":2271,"context_line":"        mock_records.assert_called_once()"},{"line_number":2272,"context_line":"        mock_sr.assert_called_once()"},{"line_number":2273,"context_line":"        self.assertEqual(expected, res)"},{"line_number":2274,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac1d6b3_00f25163","line":2271,"in_reply_to":"09ab9546_e4ad0d9e","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":2286,"context_line":"        mock_sr \u003d self.mock_object(self.client, \u0027send_request\u0027,"},{"line_number":2287,"context_line":"                                   mock.Mock(return_value\u003dret))"},{"line_number":2288,"context_line":"        res \u003d self.client._get_nfs_export_rule_indices(\u0027fake_policy\u0027, \u0027fakecl\u0027)"},{"line_number":2289,"context_line":"        mockpid.assert_called_once()"},{"line_number":2290,"context_line":"        mock_sr.assert_called_once()"},{"line_number":2291,"context_line":"        expected \u003d [\u00270\u0027]"},{"line_number":2292,"context_line":"        self.assertEqual(expected, res)"}],"source_content_type":"text/x-python","patch_set":5,"id":"672036ae_81e7ef6d","line":2289,"updated":"2023-02-15 06:10:29.000000000","message":"same","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2286,"context_line":"        mock_sr \u003d self.mock_object(self.client, \u0027send_request\u0027,"},{"line_number":2287,"context_line":"                                   mock.Mock(return_value\u003dret))"},{"line_number":2288,"context_line":"        res \u003d self.client._get_nfs_export_rule_indices(\u0027fake_policy\u0027, \u0027fakecl\u0027)"},{"line_number":2289,"context_line":"        mockpid.assert_called_once()"},{"line_number":2290,"context_line":"        mock_sr.assert_called_once()"},{"line_number":2291,"context_line":"        expected \u003d [\u00270\u0027]"},{"line_number":2292,"context_line":"        self.assertEqual(expected, res)"}],"source_content_type":"text/x-python","patch_set":5,"id":"eb389cfa_1bd4d07f","line":2289,"in_reply_to":"672036ae_81e7ef6d","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":2315,"context_line":"        mock_sr \u003d self.mock_object(self.client, \u0027send_request\u0027)"},{"line_number":2316,"context_line":"        self.client._update_nfs_export_rule(\u0027fake_policy\u0027, \u0027fake_cli\u0027, False,"},{"line_number":2317,"context_line":"                                            \u00270\u0027, [\u0027rw\u0027])"},{"line_number":2318,"context_line":"        mockpid.assert_called_once()"},{"line_number":2319,"context_line":"        mock_sr.assert_called_once()"},{"line_number":2320,"context_line":""},{"line_number":2321,"context_line":"    def test__remove_nfs_export_rules(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"b1ca0fa4_504d5d04","line":2318,"updated":"2023-02-15 06:10:29.000000000","message":"same","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2315,"context_line":"        mock_sr \u003d self.mock_object(self.client, \u0027send_request\u0027)"},{"line_number":2316,"context_line":"        self.client._update_nfs_export_rule(\u0027fake_policy\u0027, \u0027fake_cli\u0027, False,"},{"line_number":2317,"context_line":"                                            \u00270\u0027, [\u0027rw\u0027])"},{"line_number":2318,"context_line":"        mockpid.assert_called_once()"},{"line_number":2319,"context_line":"        mock_sr.assert_called_once()"},{"line_number":2320,"context_line":""},{"line_number":2321,"context_line":"    def test__remove_nfs_export_rules(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"eec4c9bb_8503a6a9","line":2318,"in_reply_to":"b1ca0fa4_504d5d04","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2fe976b6fcccf73c24c8f676ff08808af6c95a91","unresolved":true,"context_lines":[{"line_number":2323,"context_line":"                                   mock.Mock(return_value\u003d\u0027fake_policy_id\u0027))"},{"line_number":2324,"context_line":"        mock_sr \u003d self.mock_object(self.client, \u0027send_request\u0027)"},{"line_number":2325,"context_line":"        self.client._remove_nfs_export_rules(\u0027fake_policy\u0027, [0])"},{"line_number":2326,"context_line":"        mockpid.assert_called_once()"},{"line_number":2327,"context_line":"        mock_sr.assert_called_once()"},{"line_number":2328,"context_line":""},{"line_number":2329,"context_line":"    def test_modify_cifs_share_access(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5879dfe7_aaedb31d","line":2326,"updated":"2023-02-15 06:10:29.000000000","message":"same","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"aa5e612f1394eafbddd4a9030f569f0209366241","unresolved":false,"context_lines":[{"line_number":2323,"context_line":"                                   mock.Mock(return_value\u003d\u0027fake_policy_id\u0027))"},{"line_number":2324,"context_line":"        mock_sr \u003d self.mock_object(self.client, \u0027send_request\u0027)"},{"line_number":2325,"context_line":"        self.client._remove_nfs_export_rules(\u0027fake_policy\u0027, [0])"},{"line_number":2326,"context_line":"        mockpid.assert_called_once()"},{"line_number":2327,"context_line":"        mock_sr.assert_called_once()"},{"line_number":2328,"context_line":""},{"line_number":2329,"context_line":"    def test_modify_cifs_share_access(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"0d70b74e_bba3c683","line":2326,"in_reply_to":"5879dfe7_aaedb31d","updated":"2023-02-22 18:35:15.000000000","message":"Done","commit_id":"8256fa1290d74a09c3acf3ca9516251d57779d46"}],"releasenotes/notes/netapp-ontap-rest-api-client-4c83c7b931f950cf.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"83f92e5011b7d2825d8a6a587705372f57695691","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    NetApp driver: introduced the option to request ONTAP operations through"},{"line_number":5,"context_line":"    REST API when using ONTAP 9.12.1 or greater. The new option"},{"line_number":6,"context_line":"    `netapp_use_legacy_client` allows switching between the old ZAPI client"},{"line_number":7,"context_line":"    approach and new REST client. It is default to `True`, meaning that the"},{"line_number":8,"context_line":"    drivers will keep working as before using ZAPI operations. If desired, this"},{"line_number":9,"context_line":"    option can be set to `False` connecting with new REST client that performs"},{"line_number":10,"context_line":"    REST API operations if it is available, otherwise falls back to ZAPI. "}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8a1c11f8_d27f1a48","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":50},"updated":"2023-02-23 22:09:55.000000000","message":"nit: defaults to","commit_id":"a092c79f25afcb95089712d92e899a679e857871"}]}