)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"516904cc23ebe65f24174851a4cd477ddd8c4bb4","unresolved":true,"context_lines":[{"line_number":23,"context_line":"  \u003e Create share from snapshot"},{"line_number":24,"context_line":"  \u003e Share server migration"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"partially-implements: bp netapp-ontap-rest-api-client"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: Ia8992e8125c4fc7f30fb94f19449cd62b95a4831"},{"line_number":29,"context_line":"Co-authored-by: Caique Mello \u003ccaiquemellosbo@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"6b23df65_d7785a3d","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":20},"updated":"2023-02-14 00:17:07.000000000","message":"if there are no more follow up patches, please change this to \"implements\"","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  \u003e Create share from snapshot"},{"line_number":24,"context_line":"  \u003e Share server migration"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"partially-implements: bp netapp-ontap-rest-api-client"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: Ia8992e8125c4fc7f30fb94f19449cd62b95a4831"},{"line_number":29,"context_line":"Co-authored-by: Caique Mello \u003ccaiquemellosbo@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"eccc8ee0_8129a0b0","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":20},"in_reply_to":"6b23df65_d7785a3d","updated":"2023-02-22 18:35:56.000000000","message":"Ack","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"c4c364542cf949483390d9f38371972b1e95e20d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4b922b93_5bd27dfc","updated":"2023-02-10 21:08:22.000000000","message":"Thanks for the patch, Nahim. I\u0027ve pointed some small nit and questions. The rest LGTM.","commit_id":"56ab803b6988f07ff018da242ade2f0f1a70acfd"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"91c5ad0c_07a73467","updated":"2023-02-17 02:43:06.000000000","message":"Thanks Nahim and all. Please, see my comments.","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a1bf386ecdf24a96825ce41a2cc96f4c7e10d64b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f559206d_52a75499","updated":"2023-02-17 01:42:13.000000000","message":"Thanks for working on this change. Still taking a look at unit tests.\nAlso, noticed that there are several parts uncovered by unit tests. Could you please take a look?","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c288aab1_cdf2f1ae","updated":"2023-02-22 18:35:56.000000000","message":"Hello, everyone. Thank you so much for the reviews. I addressed your comments in the last patch.","commit_id":"f7aff275fcdfbca0cef7dd245a652a7c008e32e4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ae14301a91d863665e267dd189b04c27423acd67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9fc7a7a3_abc9b941","updated":"2023-02-23 22:46:43.000000000","message":"LGTM, thanks!","commit_id":"65c82408ff7126220c6b6f279e1a4cecb879924c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"bf775c54374e20897d1e7dd921d0b1ebc7b66cb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ec5776f7_fde2ba7b","updated":"2023-02-23 17:21:03.000000000","message":"NetApp CI results for REST API - it was executed on the patch that is on the top of the stack (downstream), containing all the code: \n\n- manila-tempest-plugin-ontap-dhss-rest https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/99/1699/35/downstream-experimental/manila-tempest-plugin-ontap-dhss-rest/715b676/ : SUCCESS in 1h 59m 09s\n\n- manila-tempest-plugin-ontap-no-dhss-rest https://netappopenstacklogserver.s3.us-west-1.amazonaws.com/index.html#logs/12/1712/1/downstream-experimental/manila-tempest-plugin-ontap-no-dhss-rest/f70dfc6/ : SUCCESS in 2h 23m 35s\n","commit_id":"65c82408ff7126220c6b6f279e1a4cecb879924c"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"1965b287cfdd723b45b75187aeba560c27edbb16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c79e65bb_6ed32424","updated":"2023-02-23 17:27:53.000000000","message":"Thanks Nahim. LGTM.","commit_id":"65c82408ff7126220c6b6f279e1a4cecb879924c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d7984ee360504b2948e8f48e497789c8f89a4af0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e0449946_8396313e","updated":"2023-02-23 22:13:01.000000000","message":"Thanks, LGTM. Lets get this in so the CI jobs that you\u0027re testing REST with can be enabled by default","commit_id":"65c82408ff7126220c6b6f279e1a4cecb879924c"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"fd323a0af1535d4dcb0ca376fafd93bfd22826de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"877b8aad_99ec0db8","updated":"2023-02-23 14:47:40.000000000","message":"run-NetApp CI","commit_id":"65c82408ff7126220c6b6f279e1a4cecb879924c"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"c4c364542cf949483390d9f38371972b1e95e20d","unresolved":true,"context_lines":[{"line_number":3371,"context_line":"            timeout \u003d ("},{"line_number":3372,"context_line":"                bkp_timeout if bkp_timeout is not None else DEFAULT_TIMEOUT)"},{"line_number":3373,"context_line":"            self.connection.set_timeout(timeout)"},{"line_number":3374,"context_line":"            self.connection \u003d copy.copy(bkp_connection)"},{"line_number":3375,"context_line":"            self.connection.set_vserver(bkp_vserver)"},{"line_number":3376,"context_line":""},{"line_number":3377,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":4,"id":"9bcb5265_cd1272d2","line":3374,"updated":"2023-02-10 21:08:22.000000000","message":"It\u0027s necessary to make a copy from bkp_connection, since it\u0027s already a copy and not used?","commit_id":"56ab803b6988f07ff018da242ade2f0f1a70acfd"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3371,"context_line":"            timeout \u003d ("},{"line_number":3372,"context_line":"                bkp_timeout if bkp_timeout is not None else DEFAULT_TIMEOUT)"},{"line_number":3373,"context_line":"            self.connection.set_timeout(timeout)"},{"line_number":3374,"context_line":"            self.connection \u003d copy.copy(bkp_connection)"},{"line_number":3375,"context_line":"            self.connection.set_vserver(bkp_vserver)"},{"line_number":3376,"context_line":""},{"line_number":3377,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":4,"id":"32c0da7c_0b2be850","line":3374,"in_reply_to":"9bcb5265_cd1272d2","updated":"2023-02-22 18:35:56.000000000","message":"The connection and timeout are defined inside the connection object, since they are changed, the connection is changed. The first copy in line 3363 is necessary, but this one is optional, I did this just to be safe :D\n\nOne thing I noticed now is that lines 3382 and 3383 seems to be inverted, because connection should be set before setting the timeout. I\u0027ll fix this.","commit_id":"56ab803b6988f07ff018da242ade2f0f1a70acfd"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"c4c364542cf949483390d9f38371972b1e95e20d","unresolved":true,"context_lines":[{"line_number":3443,"context_line":"        # NOTE(nahimsouza): Default values to replicate ZAPI behavior when"},{"line_number":3444,"context_line":"        # response is empty. Also, REST API does not have an equivalent to"},{"line_number":3445,"context_line":"        # \u0027udp-max-xfer-size\u0027, so the default is always returned."},{"line_number":3446,"context_line":"        nfs_info \u003d {"},{"line_number":3447,"context_line":"            \u0027tcp-max-xfer-size\u0027: 65536,"},{"line_number":3448,"context_line":"            \u0027udp-max-xfer-size\u0027: 32768,"},{"line_number":3449,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":4,"id":"1df930df_0631f27d","line":3446,"updated":"2023-02-10 21:08:22.000000000","message":"nit: Make this a constant should turn easier for reuse in \"get_nfs_config\" function and modify values in the future.","commit_id":"56ab803b6988f07ff018da242ade2f0f1a70acfd"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3443,"context_line":"        # NOTE(nahimsouza): Default values to replicate ZAPI behavior when"},{"line_number":3444,"context_line":"        # response is empty. Also, REST API does not have an equivalent to"},{"line_number":3445,"context_line":"        # \u0027udp-max-xfer-size\u0027, so the default is always returned."},{"line_number":3446,"context_line":"        nfs_info \u003d {"},{"line_number":3447,"context_line":"            \u0027tcp-max-xfer-size\u0027: 65536,"},{"line_number":3448,"context_line":"            \u0027udp-max-xfer-size\u0027: 32768,"},{"line_number":3449,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":4,"id":"fe0fc130_5a26b384","line":3446,"in_reply_to":"1df930df_0631f27d","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"56ab803b6988f07ff018da242ade2f0f1a70acfd"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"c4c364542cf949483390d9f38371972b1e95e20d","unresolved":true,"context_lines":[{"line_number":3475,"context_line":"                              body\u003dbody)"},{"line_number":3476,"context_line":"        # TODO(caiquemello): Verify and implement the API error code."},{"line_number":3477,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":3478,"context_line":"            if e.code \u003d\u003d netapp_api.EDUPLICATEENTRY:"},{"line_number":3479,"context_line":"                LOG.debug(\u0027Kerberos realm config already exists.\u0027)"},{"line_number":3480,"context_line":"            else:"},{"line_number":3481,"context_line":"                msg \u003d _(\u0027Failed to create Kerberos realm. %s\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f086e6a1_e71d68c9","line":3478,"updated":"2023-02-10 21:08:22.000000000","message":"Is this error code the one mentioned in the TODO above?","commit_id":"56ab803b6988f07ff018da242ade2f0f1a70acfd"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3475,"context_line":"                              body\u003dbody)"},{"line_number":3476,"context_line":"        # TODO(caiquemello): Verify and implement the API error code."},{"line_number":3477,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":3478,"context_line":"            if e.code \u003d\u003d netapp_api.EDUPLICATEENTRY:"},{"line_number":3479,"context_line":"                LOG.debug(\u0027Kerberos realm config already exists.\u0027)"},{"line_number":3480,"context_line":"            else:"},{"line_number":3481,"context_line":"                msg \u003d _(\u0027Failed to create Kerberos realm. %s\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfe4e953_e99e12a8","line":3478,"in_reply_to":"f086e6a1_e71d68c9","updated":"2023-02-22 18:35:56.000000000","message":"Yes. I fixed the todo.","commit_id":"56ab803b6988f07ff018da242ade2f0f1a70acfd"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3237,"context_line":"                \u0027labels\u0027: labels,"},{"line_number":3238,"context_line":"                \u0027base-counter\u0027: base_counter,"},{"line_number":3239,"context_line":"            }"},{"line_number":3240,"context_line":"        except netapp_api.NaApiError:"},{"line_number":3241,"context_line":"            raise exception.NotFound(_(\u0027Counter %s not found\u0027) % counter_name)"},{"line_number":3242,"context_line":""},{"line_number":3243,"context_line":"    def get_performance_instance_uuids(self, object_name, node_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a930522_94b0c815","line":3240,"range":{"start_line":3240,"start_character":8,"end_line":3240,"end_character":36},"updated":"2023-02-17 02:43:06.000000000","message":"This object is wrongly accessed. It should be \"netapp_api.api\"","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3237,"context_line":"                \u0027labels\u0027: labels,"},{"line_number":3238,"context_line":"                \u0027base-counter\u0027: base_counter,"},{"line_number":3239,"context_line":"            }"},{"line_number":3240,"context_line":"        except netapp_api.NaApiError:"},{"line_number":3241,"context_line":"            raise exception.NotFound(_(\u0027Counter %s not found\u0027) % counter_name)"},{"line_number":3242,"context_line":""},{"line_number":3243,"context_line":"    def get_performance_instance_uuids(self, object_name, node_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ac92b5d_5e90bb55","line":3240,"range":{"start_line":3240,"start_character":8,"end_line":3240,"end_character":36},"in_reply_to":"3a930522_94b0c815","updated":"2023-02-22 18:35:56.000000000","message":"Ack","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3384,"context_line":"            self.connection.set_vserver(bkp_vserver)"},{"line_number":3385,"context_line":""},{"line_number":3386,"context_line":"    @na_utils.trace"},{"line_number":3387,"context_line":"    def _get_deleted_nfs_export_policies(self):"},{"line_number":3388,"context_line":"        query \u003d {"},{"line_number":3389,"context_line":"            \u0027name\u0027: DELETED_PREFIX + \u0027*\u0027,"},{"line_number":3390,"context_line":"            \u0027fields\u0027: \u0027name,svm.name\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"2f11d0db_60a70a42","line":3387,"range":{"start_line":3387,"start_character":8,"end_line":3387,"end_character":40},"updated":"2023-02-17 02:43:06.000000000","message":"add method documentation","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3384,"context_line":"            self.connection.set_vserver(bkp_vserver)"},{"line_number":3385,"context_line":""},{"line_number":3386,"context_line":"    @na_utils.trace"},{"line_number":3387,"context_line":"    def _get_deleted_nfs_export_policies(self):"},{"line_number":3388,"context_line":"        query \u003d {"},{"line_number":3389,"context_line":"            \u0027name\u0027: DELETED_PREFIX + \u0027*\u0027,"},{"line_number":3390,"context_line":"            \u0027fields\u0027: \u0027name,svm.name\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"0816290d_423e39a6","line":3387,"range":{"start_line":3387,"start_character":8,"end_line":3387,"end_character":40},"in_reply_to":"2f11d0db_60a70a42","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3403,"context_line":"        return policy_map"},{"line_number":3404,"context_line":""},{"line_number":3405,"context_line":"    @na_utils.trace"},{"line_number":3406,"context_line":"    def prune_deleted_nfs_export_policies(self):"},{"line_number":3407,"context_line":"        deleted_policy_map \u003d self._get_deleted_nfs_export_policies()"},{"line_number":3408,"context_line":"        for vserver in deleted_policy_map:"},{"line_number":3409,"context_line":"            client \u003d copy.copy(self)"}],"source_content_type":"text/x-python","patch_set":5,"id":"22ee4833_35dd8aa5","line":3406,"range":{"start_line":3406,"start_character":8,"end_line":3406,"end_character":41},"updated":"2023-02-17 02:43:06.000000000","message":"add method documentation","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3403,"context_line":"        return policy_map"},{"line_number":3404,"context_line":""},{"line_number":3405,"context_line":"    @na_utils.trace"},{"line_number":3406,"context_line":"    def prune_deleted_nfs_export_policies(self):"},{"line_number":3407,"context_line":"        deleted_policy_map \u003d self._get_deleted_nfs_export_policies()"},{"line_number":3408,"context_line":"        for vserver in deleted_policy_map:"},{"line_number":3409,"context_line":"            client \u003d copy.copy(self)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9713ad1e_124e29c0","line":3406,"range":{"start_line":3406,"start_character":8,"end_line":3406,"end_character":41},"in_reply_to":"22ee4833_35dd8aa5","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3467,"context_line":"    def create_kerberos_realm(self, security_service):"},{"line_number":3468,"context_line":"        \"\"\"Creates Kerberos realm on cluster.\"\"\""},{"line_number":3469,"context_line":""},{"line_number":3470,"context_line":"        if not self.features.KERBEROS_VSERVER:"},{"line_number":3471,"context_line":"            msg \u003d _(\u0027Kerberos realms owned by Vserver are supported on ONTAP \u0027"},{"line_number":3472,"context_line":"                    \u00278.3 or later.\u0027)"},{"line_number":3473,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":3474,"context_line":""},{"line_number":3475,"context_line":"        body \u003d {"},{"line_number":3476,"context_line":"            \u0027comment\u0027: \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"11768b90_f7d07a22","line":3473,"range":{"start_line":3470,"start_character":8,"end_line":3473,"end_character":48},"updated":"2023-02-17 02:43:06.000000000","message":"it can be removd, since REST runs with 9.11.1 or higher","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3467,"context_line":"    def create_kerberos_realm(self, security_service):"},{"line_number":3468,"context_line":"        \"\"\"Creates Kerberos realm on cluster.\"\"\""},{"line_number":3469,"context_line":""},{"line_number":3470,"context_line":"        if not self.features.KERBEROS_VSERVER:"},{"line_number":3471,"context_line":"            msg \u003d _(\u0027Kerberos realms owned by Vserver are supported on ONTAP \u0027"},{"line_number":3472,"context_line":"                    \u00278.3 or later.\u0027)"},{"line_number":3473,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":3474,"context_line":""},{"line_number":3475,"context_line":"        body \u003d {"},{"line_number":3476,"context_line":"            \u0027comment\u0027: \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"e98ed82a_9535d477","line":3473,"range":{"start_line":3470,"start_character":8,"end_line":3473,"end_character":48},"in_reply_to":"11768b90_f7d07a22","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3482,"context_line":"        try:"},{"line_number":3483,"context_line":"            self.send_request(\u0027/protocols/nfs/kerberos/realms\u0027, \u0027post\u0027,"},{"line_number":3484,"context_line":"                              body\u003dbody)"},{"line_number":3485,"context_line":"        # TODO(caiquemello): Verify and implement the API error code."},{"line_number":3486,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":3487,"context_line":"            if e.code \u003d\u003d netapp_api.EDUPLICATEENTRY:"},{"line_number":3488,"context_line":"                LOG.debug(\u0027Kerberos realm config already exists.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"036db040_ed9a7943","line":3485,"range":{"start_line":3485,"start_character":11,"end_line":3485,"end_character":60},"updated":"2023-02-17 02:43:06.000000000","message":"please, solve this todo removing the ZApi error code.","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3482,"context_line":"        try:"},{"line_number":3483,"context_line":"            self.send_request(\u0027/protocols/nfs/kerberos/realms\u0027, \u0027post\u0027,"},{"line_number":3484,"context_line":"                              body\u003dbody)"},{"line_number":3485,"context_line":"        # TODO(caiquemello): Verify and implement the API error code."},{"line_number":3486,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":3487,"context_line":"            if e.code \u003d\u003d netapp_api.EDUPLICATEENTRY:"},{"line_number":3488,"context_line":"                LOG.debug(\u0027Kerberos realm config already exists.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"c09d58b4_0b80094b","line":3485,"range":{"start_line":3485,"start_character":11,"end_line":3485,"end_character":60},"in_reply_to":"036db040_ed9a7943","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3483,"context_line":"            self.send_request(\u0027/protocols/nfs/kerberos/realms\u0027, \u0027post\u0027,"},{"line_number":3484,"context_line":"                              body\u003dbody)"},{"line_number":3485,"context_line":"        # TODO(caiquemello): Verify and implement the API error code."},{"line_number":3486,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":3487,"context_line":"            if e.code \u003d\u003d netapp_api.EDUPLICATEENTRY:"},{"line_number":3488,"context_line":"                LOG.debug(\u0027Kerberos realm config already exists.\u0027)"},{"line_number":3489,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"a9299a29_b30e5f95","line":3486,"range":{"start_line":3486,"start_character":14,"end_line":3486,"end_character":36},"updated":"2023-02-17 02:43:06.000000000","message":"This object is wrongly accessed. It should be \"netapp_api.api\"","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3483,"context_line":"            self.send_request(\u0027/protocols/nfs/kerberos/realms\u0027, \u0027post\u0027,"},{"line_number":3484,"context_line":"                              body\u003dbody)"},{"line_number":3485,"context_line":"        # TODO(caiquemello): Verify and implement the API error code."},{"line_number":3486,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":3487,"context_line":"            if e.code \u003d\u003d netapp_api.EDUPLICATEENTRY:"},{"line_number":3488,"context_line":"                LOG.debug(\u0027Kerberos realm config already exists.\u0027)"},{"line_number":3489,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fb904f5d_3164343d","line":3486,"range":{"start_line":3486,"start_character":14,"end_line":3486,"end_character":36},"in_reply_to":"a9299a29_b30e5f95","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3494,"context_line":"    def configure_kerberos(self, security_service, vserver_name):"},{"line_number":3495,"context_line":"        \"\"\"Configures Kerberos for NFS on Vserver.\"\"\""},{"line_number":3496,"context_line":""},{"line_number":3497,"context_line":"        if not self.features.KERBEROS_VSERVER:"},{"line_number":3498,"context_line":"            msg \u003d _(\u0027Kerberos realms owned by Vserver are supported on ONTAP \u0027"},{"line_number":3499,"context_line":"                    \u00278.3 or later.\u0027)"},{"line_number":3500,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":3501,"context_line":""},{"line_number":3502,"context_line":"        self.configure_dns(security_service, vserver_name\u003dvserver_name)"},{"line_number":3503,"context_line":"        spn \u003d self._get_kerberos_service_principal_name("}],"source_content_type":"text/x-python","patch_set":5,"id":"7ebc208c_6c6de1f0","line":3500,"range":{"start_line":3497,"start_character":8,"end_line":3500,"end_character":48},"updated":"2023-02-17 02:43:06.000000000","message":"it can be removd, since REST runs with 9.11.1 or higher","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3494,"context_line":"    def configure_kerberos(self, security_service, vserver_name):"},{"line_number":3495,"context_line":"        \"\"\"Configures Kerberos for NFS on Vserver.\"\"\""},{"line_number":3496,"context_line":""},{"line_number":3497,"context_line":"        if not self.features.KERBEROS_VSERVER:"},{"line_number":3498,"context_line":"            msg \u003d _(\u0027Kerberos realms owned by Vserver are supported on ONTAP \u0027"},{"line_number":3499,"context_line":"                    \u00278.3 or later.\u0027)"},{"line_number":3500,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":3501,"context_line":""},{"line_number":3502,"context_line":"        self.configure_dns(security_service, vserver_name\u003dvserver_name)"},{"line_number":3503,"context_line":"        spn \u003d self._get_kerberos_service_principal_name("}],"source_content_type":"text/x-python","patch_set":5,"id":"72549986_a0403ff0","line":3500,"range":{"start_line":3497,"start_character":8,"end_line":3500,"end_character":48},"in_reply_to":"7ebc208c_6c6de1f0","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3528,"context_line":"                \u0027patch\u0027, body\u003dbody)"},{"line_number":3529,"context_line":""},{"line_number":3530,"context_line":"    @na_utils.trace"},{"line_number":3531,"context_line":"    def _get_kerberos_service_principal_name(self, security_service,"},{"line_number":3532,"context_line":"                                             vserver_name):"},{"line_number":3533,"context_line":"        return (\u0027nfs/\u0027 + vserver_name.replace(\u0027_\u0027, \u0027-\u0027) + \u0027.\u0027 +"},{"line_number":3534,"context_line":"                security_service[\u0027domain\u0027] + \u0027@\u0027 +"}],"source_content_type":"text/x-python","patch_set":5,"id":"6ba6412d_e24e836e","line":3531,"range":{"start_line":3531,"start_character":8,"end_line":3531,"end_character":44},"updated":"2023-02-17 02:43:06.000000000","message":"method documentation","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3528,"context_line":"                \u0027patch\u0027, body\u003dbody)"},{"line_number":3529,"context_line":""},{"line_number":3530,"context_line":"    @na_utils.trace"},{"line_number":3531,"context_line":"    def _get_kerberos_service_principal_name(self, security_service,"},{"line_number":3532,"context_line":"                                             vserver_name):"},{"line_number":3533,"context_line":"        return (\u0027nfs/\u0027 + vserver_name.replace(\u0027_\u0027, \u0027-\u0027) + \u0027.\u0027 +"},{"line_number":3534,"context_line":"                security_service[\u0027domain\u0027] + \u0027@\u0027 +"}],"source_content_type":"text/x-python","patch_set":5,"id":"7fab8c91_8e70a205","line":3531,"range":{"start_line":3531,"start_character":8,"end_line":3531,"end_character":44},"in_reply_to":"6ba6412d_e24e836e","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3535,"context_line":"                security_service[\u0027domain\u0027].upper())"},{"line_number":3536,"context_line":""},{"line_number":3537,"context_line":"    @na_utils.trace"},{"line_number":3538,"context_line":"    def _get_cifs_server_name(self, vserver_name):"},{"line_number":3539,"context_line":"        # \u0027cifs-server\u0027 is CIFS Server NetBIOS Name, max length is 15."},{"line_number":3540,"context_line":"        # Should be unique within each domain (data[\u0027domain\u0027])."},{"line_number":3541,"context_line":"        # Cut to 15 char with begin and end, attempt to make valid DNS hostname"}],"source_content_type":"text/x-python","patch_set":5,"id":"adadb447_075e0fd6","line":3538,"range":{"start_line":3538,"start_character":8,"end_line":3538,"end_character":29},"updated":"2023-02-17 02:43:06.000000000","message":"method documentation","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3535,"context_line":"                security_service[\u0027domain\u0027].upper())"},{"line_number":3536,"context_line":""},{"line_number":3537,"context_line":"    @na_utils.trace"},{"line_number":3538,"context_line":"    def _get_cifs_server_name(self, vserver_name):"},{"line_number":3539,"context_line":"        # \u0027cifs-server\u0027 is CIFS Server NetBIOS Name, max length is 15."},{"line_number":3540,"context_line":"        # Should be unique within each domain (data[\u0027domain\u0027])."},{"line_number":3541,"context_line":"        # Cut to 15 char with begin and end, attempt to make valid DNS hostname"}],"source_content_type":"text/x-python","patch_set":5,"id":"202dc81e_217f4998","line":3538,"range":{"start_line":3538,"start_character":8,"end_line":3538,"end_character":29},"in_reply_to":"adadb447_075e0fd6","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3569,"context_line":"            body[\u0027ad_domain.organizational_unit\u0027] \u003d security_service[\u0027ou\u0027]"},{"line_number":3570,"context_line":""},{"line_number":3571,"context_line":"        try:"},{"line_number":3572,"context_line":"            LOG.debug(\"Trying to setup CIFS server with data: %s\", body)"},{"line_number":3573,"context_line":"            self.send_request(\u0027/protocols/cifs/services\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":3574,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":3575,"context_line":"            msg \u003d _(\"Failed to create CIFS server entry. %s\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"44571488_0e0a9412","line":3572,"range":{"start_line":3572,"start_character":66,"end_line":3572,"end_character":71},"updated":"2023-02-17 02:43:06.000000000","message":"do you want to log the password? I think for security reasons you should only login the other fields. WDYT ?","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3569,"context_line":"            body[\u0027ad_domain.organizational_unit\u0027] \u003d security_service[\u0027ou\u0027]"},{"line_number":3570,"context_line":""},{"line_number":3571,"context_line":"        try:"},{"line_number":3572,"context_line":"            LOG.debug(\"Trying to setup CIFS server with data: %s\", body)"},{"line_number":3573,"context_line":"            self.send_request(\u0027/protocols/cifs/services\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":3574,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":3575,"context_line":"            msg \u003d _(\"Failed to create CIFS server entry. %s\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"031afb45_01455123","line":3572,"range":{"start_line":3572,"start_character":66,"end_line":3572,"end_character":71},"in_reply_to":"44571488_0e0a9412","updated":"2023-02-22 18:35:56.000000000","message":"If trace is enabled, it will be logged anyway in the request/response from send_request, and I don\u0027t know how this could be prevented. Besides that, ZAPI also logs this field.","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3576,"context_line":"            raise exception.NetAppException(msg % e.message)"},{"line_number":3577,"context_line":""},{"line_number":3578,"context_line":"    @na_utils.trace"},{"line_number":3579,"context_line":"    def _get_unique_svm_by_name(self, vserver_name\u003dNone):"},{"line_number":3580,"context_line":"        # Get SVM UUID."},{"line_number":3581,"context_line":"        query \u003d {"},{"line_number":3582,"context_line":"            \u0027name\u0027: vserver_name if vserver_name else self.vserver,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5b5b836a_4a642ce8","line":3579,"range":{"start_line":3579,"start_character":8,"end_line":3579,"end_character":31},"updated":"2023-02-17 02:43:06.000000000","message":"method documentation","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3576,"context_line":"            raise exception.NetAppException(msg % e.message)"},{"line_number":3577,"context_line":""},{"line_number":3578,"context_line":"    @na_utils.trace"},{"line_number":3579,"context_line":"    def _get_unique_svm_by_name(self, vserver_name\u003dNone):"},{"line_number":3580,"context_line":"        # Get SVM UUID."},{"line_number":3581,"context_line":"        query \u003d {"},{"line_number":3582,"context_line":"            \u0027name\u0027: vserver_name if vserver_name else self.vserver,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfd14a9e_da77b4b9","line":3579,"range":{"start_line":3579,"start_character":8,"end_line":3579,"end_character":31},"in_reply_to":"5b5b836a_4a642ce8","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a1bf386ecdf24a96825ce41a2cc96f4c7e10d64b","unresolved":true,"context_lines":[{"line_number":3610,"context_line":""},{"line_number":3611,"context_line":"        return dns_config"},{"line_number":3612,"context_line":""},{"line_number":3613,"context_line":"    def configure_dns(self, security_service, vserver_name\u003dNone):"},{"line_number":3614,"context_line":"        \"\"\"Configure DNS address and servers for a vserver.\"\"\""},{"line_number":3615,"context_line":"        body \u003d {"},{"line_number":3616,"context_line":"            \u0027domains\u0027: [],"}],"source_content_type":"text/x-python","patch_set":5,"id":"6a6b6ed4_8d70148a","line":3613,"updated":"2023-02-17 01:42:13.000000000","message":"na_utils.trace","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3610,"context_line":""},{"line_number":3611,"context_line":"        return dns_config"},{"line_number":3612,"context_line":""},{"line_number":3613,"context_line":"    def configure_dns(self, security_service, vserver_name\u003dNone):"},{"line_number":3614,"context_line":"        \"\"\"Configure DNS address and servers for a vserver.\"\"\""},{"line_number":3615,"context_line":"        body \u003d {"},{"line_number":3616,"context_line":"            \u0027domains\u0027: [],"}],"source_content_type":"text/x-python","patch_set":5,"id":"ecf4c51a_7ce48855","line":3613,"in_reply_to":"6a6b6ed4_8d70148a","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a1bf386ecdf24a96825ce41a2cc96f4c7e10d64b","unresolved":true,"context_lines":[{"line_number":3647,"context_line":""},{"line_number":3648,"context_line":"    @na_utils.trace"},{"line_number":3649,"context_line":"    def setup_security_services(self, security_services, vserver_client,"},{"line_number":3650,"context_line":"                                vserver_name, timeout\u003d30):"},{"line_number":3651,"context_line":"        body \u003d {"},{"line_number":3652,"context_line":"            \u0027nsswitch.namemap\u0027: [\u0027ldap\u0027, \u0027files\u0027],"},{"line_number":3653,"context_line":"            \u0027nsswitch.group\u0027: [\u0027ldap\u0027, \u0027files\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"5cc7e548_630dfbee","line":3650,"updated":"2023-02-17 01:42:13.000000000","message":"please add docstring","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3647,"context_line":""},{"line_number":3648,"context_line":"    @na_utils.trace"},{"line_number":3649,"context_line":"    def setup_security_services(self, security_services, vserver_client,"},{"line_number":3650,"context_line":"                                vserver_name, timeout\u003d30):"},{"line_number":3651,"context_line":"        body \u003d {"},{"line_number":3652,"context_line":"            \u0027nsswitch.namemap\u0027: [\u0027ldap\u0027, \u0027files\u0027],"},{"line_number":3653,"context_line":"            \u0027nsswitch.group\u0027: [\u0027ldap\u0027, \u0027files\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"dd0c7abd_0149bd2d","line":3650,"in_reply_to":"5cc7e548_630dfbee","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3850,"context_line":"                f\u0027/protocols/cifs/domains/{svm_uuid}/\u0027"},{"line_number":3851,"context_line":"                f\u0027preferred-domain-controllers/{fqdn}/{server_ip}\u0027,"},{"line_number":3852,"context_line":"                \u0027delete\u0027, query\u003dquery)"},{"line_number":3853,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":3854,"context_line":"            msg \u003d _(\"Failed to unset preferred DCs. %s\")"},{"line_number":3855,"context_line":"            raise exception.NetAppException(msg % e.message)"},{"line_number":3856,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"af945760_d294d648","line":3853,"range":{"start_line":3853,"start_character":8,"end_line":3853,"end_character":41},"updated":"2023-02-17 02:43:06.000000000","message":"This object is wrongly accessed. It should be \"netapp_api.api\"","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3850,"context_line":"                f\u0027/protocols/cifs/domains/{svm_uuid}/\u0027"},{"line_number":3851,"context_line":"                f\u0027preferred-domain-controllers/{fqdn}/{server_ip}\u0027,"},{"line_number":3852,"context_line":"                \u0027delete\u0027, query\u003dquery)"},{"line_number":3853,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":3854,"context_line":"            msg \u003d _(\"Failed to unset preferred DCs. %s\")"},{"line_number":3855,"context_line":"            raise exception.NetAppException(msg % e.message)"},{"line_number":3856,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"2009ffe0_54900234","line":3853,"range":{"start_line":3853,"start_character":8,"end_line":3853,"end_character":41},"in_reply_to":"af945760_d294d648","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a1bf386ecdf24a96825ce41a2cc96f4c7e10d64b","unresolved":true,"context_lines":[{"line_number":3857,"context_line":"    @na_utils.trace"},{"line_number":3858,"context_line":"    def modify_active_directory_security_service("},{"line_number":3859,"context_line":"            self, vserver_name, differring_keys, new_security_service,"},{"line_number":3860,"context_line":"            current_security_service):"},{"line_number":3861,"context_line":""},{"line_number":3862,"context_line":"        svm_uuid \u003d self._get_unique_svm_by_name(vserver_name)"},{"line_number":3863,"context_line":"        new_username \u003d new_security_service[\u0027user\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"57c46aa7_dff7d236","line":3860,"updated":"2023-02-17 01:42:13.000000000","message":"missing docstring","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3857,"context_line":"    @na_utils.trace"},{"line_number":3858,"context_line":"    def modify_active_directory_security_service("},{"line_number":3859,"context_line":"            self, vserver_name, differring_keys, new_security_service,"},{"line_number":3860,"context_line":"            current_security_service):"},{"line_number":3861,"context_line":""},{"line_number":3862,"context_line":"        svm_uuid \u003d self._get_unique_svm_by_name(vserver_name)"},{"line_number":3863,"context_line":"        new_username \u003d new_security_service[\u0027user\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"e37ade12_a502b244","line":3860,"in_reply_to":"57c46aa7_dff7d236","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3874,"context_line":"                    f\u0027/protocols/cifs/local-users/{svm_uuid}/{sid}\u0027,"},{"line_number":3875,"context_line":"                    \u0027patch\u0027, query\u003dquery"},{"line_number":3876,"context_line":"                )"},{"line_number":3877,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":3878,"context_line":"                msg \u003d _(\"Failed to modify existing CIFS server password. %s\")"},{"line_number":3879,"context_line":"                raise exception.NetAppException(msg % e.message)"},{"line_number":3880,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ecb130bd_fb41d95f","line":3877,"range":{"start_line":3877,"start_character":12,"end_line":3877,"end_character":46},"updated":"2023-02-17 02:43:06.000000000","message":"This object is wrongly accessed. It should be \"netapp_api.api\"","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3874,"context_line":"                    f\u0027/protocols/cifs/local-users/{svm_uuid}/{sid}\u0027,"},{"line_number":3875,"context_line":"                    \u0027patch\u0027, query\u003dquery"},{"line_number":3876,"context_line":"                )"},{"line_number":3877,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":3878,"context_line":"                msg \u003d _(\"Failed to modify existing CIFS server password. %s\")"},{"line_number":3879,"context_line":"                raise exception.NetAppException(msg % e.message)"},{"line_number":3880,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df0b8f27_ed609862","line":3877,"range":{"start_line":3877,"start_character":12,"end_line":3877,"end_character":46},"in_reply_to":"ecb130bd_fb41d95f","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3887,"context_line":"                    f\u0027/protocols/cifs/local-users/{svm_uuid}/{sid}\u0027,"},{"line_number":3888,"context_line":"                    \u0027patch\u0027, query\u003dquery"},{"line_number":3889,"context_line":"                )"},{"line_number":3890,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":3891,"context_line":"                msg \u003d _(\"Failed to modify existing CIFS server user-name. %s\")"},{"line_number":3892,"context_line":"                raise exception.NetAppException(msg % e.message)"},{"line_number":3893,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e260b0e3_1f8a048f","line":3890,"range":{"start_line":3890,"start_character":12,"end_line":3890,"end_character":41},"updated":"2023-02-17 02:43:06.000000000","message":"This object is wrongly accessed. It should be \"netapp_api.api\"","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3887,"context_line":"                    f\u0027/protocols/cifs/local-users/{svm_uuid}/{sid}\u0027,"},{"line_number":3888,"context_line":"                    \u0027patch\u0027, query\u003dquery"},{"line_number":3889,"context_line":"                )"},{"line_number":3890,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":3891,"context_line":"                msg \u003d _(\"Failed to modify existing CIFS server user-name. %s\")"},{"line_number":3892,"context_line":"                raise exception.NetAppException(msg % e.message)"},{"line_number":3893,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"c6afd70d_2859c2e7","line":3890,"range":{"start_line":3890,"start_character":12,"end_line":3890,"end_character":41},"in_reply_to":"e260b0e3_1f8a048f","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a1bf386ecdf24a96825ce41a2cc96f4c7e10d64b","unresolved":true,"context_lines":[{"line_number":3900,"context_line":""},{"line_number":3901,"context_line":"    @na_utils.trace"},{"line_number":3902,"context_line":"    def set_preferred_dc(self, security_service, svm_uuid):"},{"line_number":3903,"context_line":"        # server is optional"},{"line_number":3904,"context_line":"        if not security_service[\u0027server\u0027]:"},{"line_number":3905,"context_line":"            return"},{"line_number":3906,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"96a7c364_5b73edef","line":3903,"updated":"2023-02-17 01:42:13.000000000","message":"missing docstring here and in some methods below","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3900,"context_line":""},{"line_number":3901,"context_line":"    @na_utils.trace"},{"line_number":3902,"context_line":"    def set_preferred_dc(self, security_service, svm_uuid):"},{"line_number":3903,"context_line":"        # server is optional"},{"line_number":3904,"context_line":"        if not security_service[\u0027server\u0027]:"},{"line_number":3905,"context_line":"            return"},{"line_number":3906,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7475f12e_3a05f607","line":3903,"in_reply_to":"96a7c364_5b73edef","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3920,"context_line":"                f\u0027protocols/cifs/domains/{svm_uuid}\u0027"},{"line_number":3921,"context_line":"                \u0027/preferred-domain-controllers\u0027,"},{"line_number":3922,"context_line":"                \u0027post\u0027, query\u003dquery)"},{"line_number":3923,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":3924,"context_line":"            msg \u003d _(\"Failed to set preferred DC. %s\")"},{"line_number":3925,"context_line":"            raise exception.NetAppException(msg % e.message)"},{"line_number":3926,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"c83bf644_7c1bab97","line":3923,"range":{"start_line":3923,"start_character":8,"end_line":3923,"end_character":40},"updated":"2023-02-17 02:43:06.000000000","message":"This object is wrongly accessed. It should be \"netapp_api.api\"","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3920,"context_line":"                f\u0027protocols/cifs/domains/{svm_uuid}\u0027"},{"line_number":3921,"context_line":"                \u0027/preferred-domain-controllers\u0027,"},{"line_number":3922,"context_line":"                \u0027post\u0027, query\u003dquery)"},{"line_number":3923,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":3924,"context_line":"            msg \u003d _(\"Failed to set preferred DC. %s\")"},{"line_number":3925,"context_line":"            raise exception.NetAppException(msg % e.message)"},{"line_number":3926,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"f70120a4_30497a06","line":3923,"range":{"start_line":3923,"start_character":8,"end_line":3923,"end_character":40},"in_reply_to":"c83bf644_7c1bab97","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3971,"context_line":"        if vserver_name:"},{"line_number":3972,"context_line":"            query[\u0027svm.name\u0027] \u003d vserver_name"},{"line_number":3973,"context_line":""},{"line_number":3974,"context_line":"        query[\u0027fields\u0027] \u003d \\"},{"line_number":3975,"context_line":"            \u0027uuid,svm.name,peer.svm.name,state,peer.cluster.name\u0027"},{"line_number":3976,"context_line":""},{"line_number":3977,"context_line":"        result \u003d self.send_request(\u0027/svm/peers\u0027, \u0027get\u0027, query\u003dquery)"}],"source_content_type":"text/x-python","patch_set":5,"id":"70d6f1c4_57464e1e","line":3974,"range":{"start_line":3974,"start_character":26,"end_line":3974,"end_character":27},"updated":"2023-02-17 02:43:06.000000000","message":"use () to break lines","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3971,"context_line":"        if vserver_name:"},{"line_number":3972,"context_line":"            query[\u0027svm.name\u0027] \u003d vserver_name"},{"line_number":3973,"context_line":""},{"line_number":3974,"context_line":"        query[\u0027fields\u0027] \u003d \\"},{"line_number":3975,"context_line":"            \u0027uuid,svm.name,peer.svm.name,state,peer.cluster.name\u0027"},{"line_number":3976,"context_line":""},{"line_number":3977,"context_line":"        result \u003d self.send_request(\u0027/svm/peers\u0027, \u0027get\u0027, query\u003dquery)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ac628e4f_179faff5","line":3974,"range":{"start_line":3974,"start_character":26,"end_line":3974,"end_character":27},"in_reply_to":"70d6f1c4_57464e1e","updated":"2023-02-22 18:35:56.000000000","message":"Ack","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":3979,"context_line":"            return []"},{"line_number":3980,"context_line":""},{"line_number":3981,"context_line":"        vserver_peers \u003d []"},{"line_number":3982,"context_line":""},{"line_number":3983,"context_line":"        for vserver_peer_info in result[\u0027records\u0027]:"},{"line_number":3984,"context_line":""},{"line_number":3985,"context_line":"            vserver_peer \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"d376c3ab_c69f4c0a","line":3982,"updated":"2023-02-17 02:43:06.000000000","message":"nit: empty line can be removed","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3979,"context_line":"            return []"},{"line_number":3980,"context_line":""},{"line_number":3981,"context_line":"        vserver_peers \u003d []"},{"line_number":3982,"context_line":""},{"line_number":3983,"context_line":"        for vserver_peer_info in result[\u0027records\u0027]:"},{"line_number":3984,"context_line":""},{"line_number":3985,"context_line":"            vserver_peer \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"d569a9d4_99bf6338","line":3982,"in_reply_to":"d376c3ab_c69f4c0a","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4038,"context_line":"            body[\u0027subtype\u0027] \u003d subtype"},{"line_number":4039,"context_line":""},{"line_number":4040,"context_line":"        if ipspace_name:"},{"line_number":4041,"context_line":"            if not self.features.IPSPACES:"},{"line_number":4042,"context_line":"                msg \u003d \u0027IPSpaces are not supported on this backend.\u0027"},{"line_number":4043,"context_line":"                raise exception.NetAppException(msg)"},{"line_number":4044,"context_line":"            else:"},{"line_number":4045,"context_line":"                body[\u0027ipspace.name\u0027] \u003d ipspace_name"},{"line_number":4046,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"907f78b5_10b77fc4","line":4043,"range":{"start_line":4041,"start_character":12,"end_line":4043,"end_character":52},"updated":"2023-02-17 02:43:06.000000000","message":"not required since the REST runs with version 9.11.1 or upper","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4038,"context_line":"            body[\u0027subtype\u0027] \u003d subtype"},{"line_number":4039,"context_line":""},{"line_number":4040,"context_line":"        if ipspace_name:"},{"line_number":4041,"context_line":"            if not self.features.IPSPACES:"},{"line_number":4042,"context_line":"                msg \u003d \u0027IPSpaces are not supported on this backend.\u0027"},{"line_number":4043,"context_line":"                raise exception.NetAppException(msg)"},{"line_number":4044,"context_line":"            else:"},{"line_number":4045,"context_line":"                body[\u0027ipspace.name\u0027] \u003d ipspace_name"},{"line_number":4046,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dd512d0a_a8e46682","line":4043,"range":{"start_line":4041,"start_character":12,"end_line":4043,"end_character":52},"in_reply_to":"907f78b5_10b77fc4","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4051,"context_line":"        self.send_request(\u0027/svm/svms\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":4052,"context_line":""},{"line_number":4053,"context_line":"    @na_utils.trace"},{"line_number":4054,"context_line":"    def list_node_data_ports(self, node):"},{"line_number":4055,"context_line":"        ports \u003d self.get_node_data_ports(node)"},{"line_number":4056,"context_line":"        return [port.get(\u0027port\u0027) for port in ports]"},{"line_number":4057,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fb2cf051_54ad9c8f","line":4054,"range":{"start_line":4054,"start_character":8,"end_line":4054,"end_character":28},"updated":"2023-02-17 02:43:06.000000000","message":"method documentation","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4051,"context_line":"        self.send_request(\u0027/svm/svms\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":4052,"context_line":""},{"line_number":4053,"context_line":"    @na_utils.trace"},{"line_number":4054,"context_line":"    def list_node_data_ports(self, node):"},{"line_number":4055,"context_line":"        ports \u003d self.get_node_data_ports(node)"},{"line_number":4056,"context_line":"        return [port.get(\u0027port\u0027) for port in ports]"},{"line_number":4057,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"c656660e_780c2311","line":4054,"range":{"start_line":4054,"start_character":8,"end_line":4054,"end_character":28},"in_reply_to":"fb2cf051_54ad9c8f","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4056,"context_line":"        return [port.get(\u0027port\u0027) for port in ports]"},{"line_number":4057,"context_line":""},{"line_number":4058,"context_line":"    @na_utils.trace"},{"line_number":4059,"context_line":"    def _sort_data_ports_by_speed(self, ports):"},{"line_number":4060,"context_line":""},{"line_number":4061,"context_line":"        def sort_key(port):"},{"line_number":4062,"context_line":"            value \u003d port.get(\u0027speed\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ee2cca2e_46b83da5","line":4059,"range":{"start_line":4059,"start_character":8,"end_line":4059,"end_character":33},"updated":"2023-02-17 02:43:06.000000000","message":"method documentation","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4056,"context_line":"        return [port.get(\u0027port\u0027) for port in ports]"},{"line_number":4057,"context_line":""},{"line_number":4058,"context_line":"    @na_utils.trace"},{"line_number":4059,"context_line":"    def _sort_data_ports_by_speed(self, ports):"},{"line_number":4060,"context_line":""},{"line_number":4061,"context_line":"        def sort_key(port):"},{"line_number":4062,"context_line":"            value \u003d port.get(\u0027speed\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"2955248f_c198b1bb","line":4059,"range":{"start_line":4059,"start_character":8,"end_line":4059,"end_character":33},"in_reply_to":"ee2cca2e_46b83da5","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4149,"context_line":"        self.send_request(\u0027/network/ipspaces\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":4150,"context_line":""},{"line_number":4151,"context_line":"    @na_utils.trace"},{"line_number":4152,"context_line":"    def create_port_and_broadcast_domain(self, node, port, vlan, mtu, ipspace):"},{"line_number":4153,"context_line":"        home_port_name \u003d port"},{"line_number":4154,"context_line":"        if vlan:"},{"line_number":4155,"context_line":"            self._create_vlan(node, port, vlan)"}],"source_content_type":"text/x-python","patch_set":5,"id":"686918f3_03b8a80d","line":4152,"range":{"start_line":4152,"start_character":8,"end_line":4152,"end_character":40},"updated":"2023-02-17 02:43:06.000000000","message":"method documentation","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4149,"context_line":"        self.send_request(\u0027/network/ipspaces\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":4150,"context_line":""},{"line_number":4151,"context_line":"    @na_utils.trace"},{"line_number":4152,"context_line":"    def create_port_and_broadcast_domain(self, node, port, vlan, mtu, ipspace):"},{"line_number":4153,"context_line":"        home_port_name \u003d port"},{"line_number":4154,"context_line":"        if vlan:"},{"line_number":4155,"context_line":"            self._create_vlan(node, port, vlan)"}],"source_content_type":"text/x-python","patch_set":5,"id":"739e85bf_3eb44814","line":4152,"range":{"start_line":4152,"start_character":8,"end_line":4152,"end_character":40},"in_reply_to":"686918f3_03b8a80d","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4155,"context_line":"            self._create_vlan(node, port, vlan)"},{"line_number":4156,"context_line":"            home_port_name \u003d \u0027%(port)s-%(tag)s\u0027 % {\u0027port\u0027: port, \u0027tag\u0027: vlan}"},{"line_number":4157,"context_line":""},{"line_number":4158,"context_line":"        if self.features.BROADCAST_DOMAINS:"},{"line_number":4159,"context_line":"            self._ensure_broadcast_domain_for_port("},{"line_number":4160,"context_line":"                node, home_port_name, mtu, ipspace\u003dipspace)"},{"line_number":4161,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d479d3ef_9435f325","line":4158,"range":{"start_line":4158,"start_character":0,"end_line":4158,"end_character":43},"updated":"2023-02-17 02:43:06.000000000","message":"not required since the REST runs with 9.11.1 or upper","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4155,"context_line":"            self._create_vlan(node, port, vlan)"},{"line_number":4156,"context_line":"            home_port_name \u003d \u0027%(port)s-%(tag)s\u0027 % {\u0027port\u0027: port, \u0027tag\u0027: vlan}"},{"line_number":4157,"context_line":""},{"line_number":4158,"context_line":"        if self.features.BROADCAST_DOMAINS:"},{"line_number":4159,"context_line":"            self._ensure_broadcast_domain_for_port("},{"line_number":4160,"context_line":"                node, home_port_name, mtu, ipspace\u003dipspace)"},{"line_number":4161,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"92c25070_f103b476","line":4158,"range":{"start_line":4158,"start_character":0,"end_line":4158,"end_character":43},"in_reply_to":"d479d3ef_9435f325","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4162,"context_line":"        return home_port_name"},{"line_number":4163,"context_line":""},{"line_number":4164,"context_line":"    @na_utils.trace"},{"line_number":4165,"context_line":"    def _create_vlan(self, node, port, vlan):"},{"line_number":4166,"context_line":"        try:"},{"line_number":4167,"context_line":"            body \u003d {"},{"line_number":4168,"context_line":"                \u0027vlan.base_port.name\u0027: port,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1d923924_6dfaac90","line":4165,"range":{"start_line":4165,"start_character":8,"end_line":4165,"end_character":20},"updated":"2023-02-17 02:43:06.000000000","message":"method documentation","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4162,"context_line":"        return home_port_name"},{"line_number":4163,"context_line":""},{"line_number":4164,"context_line":"    @na_utils.trace"},{"line_number":4165,"context_line":"    def _create_vlan(self, node, port, vlan):"},{"line_number":4166,"context_line":"        try:"},{"line_number":4167,"context_line":"            body \u003d {"},{"line_number":4168,"context_line":"                \u0027vlan.base_port.name\u0027: port,"}],"source_content_type":"text/x-python","patch_set":5,"id":"8fa7f287_3c09ea41","line":4165,"range":{"start_line":4165,"start_character":8,"end_line":4165,"end_character":20},"in_reply_to":"1d923924_6dfaac90","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4467,"context_line":"        return self._has_records(result)"},{"line_number":4468,"context_line":""},{"line_number":4469,"context_line":"    @na_utils.trace"},{"line_number":4470,"context_line":"    def create_route(self, gateway, destination\u003dNone):"},{"line_number":4471,"context_line":"        if not gateway:"},{"line_number":4472,"context_line":"            return"},{"line_number":4473,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"974dd0f4_f4f0d0be","line":4470,"range":{"start_line":4470,"start_character":8,"end_line":4470,"end_character":20},"updated":"2023-02-17 02:43:06.000000000","message":"method documentation","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4467,"context_line":"        return self._has_records(result)"},{"line_number":4468,"context_line":""},{"line_number":4469,"context_line":"    @na_utils.trace"},{"line_number":4470,"context_line":"    def create_route(self, gateway, destination\u003dNone):"},{"line_number":4471,"context_line":"        if not gateway:"},{"line_number":4472,"context_line":"            return"},{"line_number":4473,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"19c94f39_af4d349a","line":4470,"range":{"start_line":4470,"start_character":8,"end_line":4470,"end_character":20},"in_reply_to":"974dd0f4_f4f0d0be","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4537,"context_line":"            vserver_info \u003d response.get(\u0027records\u0027)[0]"},{"line_number":4538,"context_line":"            vserver_subtype \u003d vserver_info[\u0027subtype\u0027]"},{"line_number":4539,"context_line":"            vserver_state \u003d vserver_info[\u0027state\u0027]"},{"line_number":4540,"context_line":"        except KeyError:"},{"line_number":4541,"context_line":"            msg \u003d _(\u0027Could not retrieve vserver-info for %s.\u0027) % vserver_name"},{"line_number":4542,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":4543,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"79e96fc5_9b6a37f2","line":4540,"range":{"start_line":4540,"start_character":8,"end_line":4540,"end_character":21},"updated":"2023-02-17 02:43:06.000000000","message":"why is this catch here ? Is it possible to \u0027subtype\u0027 or \u0027state\u0027 not be part of the response ?","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4537,"context_line":"            vserver_info \u003d response.get(\u0027records\u0027)[0]"},{"line_number":4538,"context_line":"            vserver_subtype \u003d vserver_info[\u0027subtype\u0027]"},{"line_number":4539,"context_line":"            vserver_state \u003d vserver_info[\u0027state\u0027]"},{"line_number":4540,"context_line":"        except KeyError:"},{"line_number":4541,"context_line":"            msg \u003d _(\u0027Could not retrieve vserver-info for %s.\u0027) % vserver_name"},{"line_number":4542,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":4543,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"25aa2276_d2b77463","line":4540,"range":{"start_line":4540,"start_character":8,"end_line":4540,"end_character":21},"in_reply_to":"79e96fc5_9b6a37f2","updated":"2023-02-22 18:35:56.000000000","message":"Ack","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4574,"context_line":"    @na_utils.trace"},{"line_number":4575,"context_line":"    def get_vserver_ipspace(self, vserver_name):"},{"line_number":4576,"context_line":"        \"\"\"Get the IPspace of the vserver, or None if not supported.\"\"\""},{"line_number":4577,"context_line":"        if not self.features.IPSPACES:"},{"line_number":4578,"context_line":"            return None"},{"line_number":4579,"context_line":""},{"line_number":4580,"context_line":"        query \u003d {"},{"line_number":4581,"context_line":"            \u0027name\u0027: vserver_name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"936fb9c5_4b7108d1","line":4578,"range":{"start_line":4577,"start_character":8,"end_line":4578,"end_character":23},"updated":"2023-02-17 02:43:06.000000000","message":"not required, since REST runs with 9.11.1 or upper","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4574,"context_line":"    @na_utils.trace"},{"line_number":4575,"context_line":"    def get_vserver_ipspace(self, vserver_name):"},{"line_number":4576,"context_line":"        \"\"\"Get the IPspace of the vserver, or None if not supported.\"\"\""},{"line_number":4577,"context_line":"        if not self.features.IPSPACES:"},{"line_number":4578,"context_line":"            return None"},{"line_number":4579,"context_line":""},{"line_number":4580,"context_line":"        query \u003d {"},{"line_number":4581,"context_line":"            \u0027name\u0027: vserver_name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a5814f0_c72a2435","line":4578,"range":{"start_line":4577,"start_character":8,"end_line":4578,"end_character":23},"in_reply_to":"936fb9c5_4b7108d1","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4585,"context_line":""},{"line_number":4586,"context_line":"        try:"},{"line_number":4587,"context_line":"            ipspace \u003d response.get(\u0027records\u0027)[0][\u0027ipspace\u0027][\u0027name\u0027]"},{"line_number":4588,"context_line":"        except netapp_api.api.NaApiError:"},{"line_number":4589,"context_line":"            msg \u003d _(\u0027Could not determine IPspace for Vserver %s.\u0027)"},{"line_number":4590,"context_line":"            raise exception.NetAppException(msg % vserver_name)"},{"line_number":4591,"context_line":""},{"line_number":4592,"context_line":"        return ipspace"},{"line_number":4593,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"a1f48f03_e6a7b1c9","line":4590,"range":{"start_line":4588,"start_character":8,"end_line":4590,"end_character":63},"updated":"2023-02-17 02:43:06.000000000","message":"this catch is wrong. The call was done earlier (line 4584)","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4585,"context_line":""},{"line_number":4586,"context_line":"        try:"},{"line_number":4587,"context_line":"            ipspace \u003d response.get(\u0027records\u0027)[0][\u0027ipspace\u0027][\u0027name\u0027]"},{"line_number":4588,"context_line":"        except netapp_api.api.NaApiError:"},{"line_number":4589,"context_line":"            msg \u003d _(\u0027Could not determine IPspace for Vserver %s.\u0027)"},{"line_number":4590,"context_line":"            raise exception.NetAppException(msg % vserver_name)"},{"line_number":4591,"context_line":""},{"line_number":4592,"context_line":"        return ipspace"},{"line_number":4593,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"42980588_8afa3e7c","line":4590,"range":{"start_line":4588,"start_character":8,"end_line":4590,"end_character":63},"in_reply_to":"a1f48f03_e6a7b1c9","updated":"2023-02-22 18:35:56.000000000","message":"Ack","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4608,"context_line":"        return policy_name"},{"line_number":4609,"context_line":""},{"line_number":4610,"context_line":"    @na_utils.trace"},{"line_number":4611,"context_line":"    def delete_snapmirror_policy(self):"},{"line_number":4612,"context_line":"        \"\"\"Deletes a SnapMirror policy.\"\"\""},{"line_number":4613,"context_line":""},{"line_number":4614,"context_line":"        uuid \u003d self._get_snapmirror_uuid()"}],"source_content_type":"text/x-python","patch_set":5,"id":"d629b967_19eaeeef","line":4611,"range":{"start_line":4611,"start_character":4,"end_line":4611,"end_character":39},"updated":"2023-02-17 02:43:06.000000000","message":"I think it is wrong, ZAPI has a different method interface (it has a parameter \"policy_name\").","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4608,"context_line":"        return policy_name"},{"line_number":4609,"context_line":""},{"line_number":4610,"context_line":"    @na_utils.trace"},{"line_number":4611,"context_line":"    def delete_snapmirror_policy(self):"},{"line_number":4612,"context_line":"        \"\"\"Deletes a SnapMirror policy.\"\"\""},{"line_number":4613,"context_line":""},{"line_number":4614,"context_line":"        uuid \u003d self._get_snapmirror_uuid()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ceb99fd_bcb35434","line":4611,"range":{"start_line":4611,"start_character":4,"end_line":4611,"end_character":39},"in_reply_to":"d629b967_19eaeeef","updated":"2023-02-22 18:35:56.000000000","message":"Ack","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4611,"context_line":"    def delete_snapmirror_policy(self):"},{"line_number":4612,"context_line":"        \"\"\"Deletes a SnapMirror policy.\"\"\""},{"line_number":4613,"context_line":""},{"line_number":4614,"context_line":"        uuid \u003d self._get_snapmirror_uuid()"},{"line_number":4615,"context_line":"        try:"},{"line_number":4616,"context_line":"            self.send_request(f\u0027/api/snapmirror/policies/{uuid}\u0027, \u0027delete\u0027)"},{"line_number":4617,"context_line":"        except netapp_api.api.NaApiError as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bb575b48_a269e764","line":4614,"range":{"start_line":4614,"start_character":21,"end_line":4614,"end_character":40},"updated":"2023-02-17 02:43:06.000000000","message":"what ? I didn\u0027t get it. Retrieving a snapmirror uuid ?","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4611,"context_line":"    def delete_snapmirror_policy(self):"},{"line_number":4612,"context_line":"        \"\"\"Deletes a SnapMirror policy.\"\"\""},{"line_number":4613,"context_line":""},{"line_number":4614,"context_line":"        uuid \u003d self._get_snapmirror_uuid()"},{"line_number":4615,"context_line":"        try:"},{"line_number":4616,"context_line":"            self.send_request(f\u0027/api/snapmirror/policies/{uuid}\u0027, \u0027delete\u0027)"},{"line_number":4617,"context_line":"        except netapp_api.api.NaApiError as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"563e4138_7518eb6e","line":4614,"range":{"start_line":4614,"start_character":21,"end_line":4614,"end_character":40},"in_reply_to":"bb575b48_a269e764","updated":"2023-02-22 18:35:56.000000000","message":"It should be policy uuid. I reimplemented the function.","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4613,"context_line":""},{"line_number":4614,"context_line":"        uuid \u003d self._get_snapmirror_uuid()"},{"line_number":4615,"context_line":"        try:"},{"line_number":4616,"context_line":"            self.send_request(f\u0027/api/snapmirror/policies/{uuid}\u0027, \u0027delete\u0027)"},{"line_number":4617,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":4618,"context_line":"            if e.code !\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":4619,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":5,"id":"8d00ff46_62796ab6","line":4616,"range":{"start_line":4616,"start_character":32,"end_line":4616,"end_character":37},"updated":"2023-02-17 02:43:06.000000000","message":"wrong, \"/api\" should not be added to the action url","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4613,"context_line":""},{"line_number":4614,"context_line":"        uuid \u003d self._get_snapmirror_uuid()"},{"line_number":4615,"context_line":"        try:"},{"line_number":4616,"context_line":"            self.send_request(f\u0027/api/snapmirror/policies/{uuid}\u0027, \u0027delete\u0027)"},{"line_number":4617,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":4618,"context_line":"            if e.code !\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":4619,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":5,"id":"1b12aa41_dfcd93b7","line":4616,"range":{"start_line":4616,"start_character":32,"end_line":4616,"end_character":37},"in_reply_to":"8d00ff46_62796ab6","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4615,"context_line":"        try:"},{"line_number":4616,"context_line":"            self.send_request(f\u0027/api/snapmirror/policies/{uuid}\u0027, \u0027delete\u0027)"},{"line_number":4617,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":4618,"context_line":"            if e.code !\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":4619,"context_line":"                raise"},{"line_number":4620,"context_line":""},{"line_number":4621,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"b16258c9_d54ffdb9","line":4618,"range":{"start_line":4618,"start_character":36,"end_line":4618,"end_character":51},"updated":"2023-02-17 02:43:06.000000000","message":"zapi code","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4615,"context_line":"        try:"},{"line_number":4616,"context_line":"            self.send_request(f\u0027/api/snapmirror/policies/{uuid}\u0027, \u0027delete\u0027)"},{"line_number":4617,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":4618,"context_line":"            if e.code !\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":4619,"context_line":"                raise"},{"line_number":4620,"context_line":""},{"line_number":4621,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"355a8fc9_060d12e1","line":4618,"range":{"start_line":4618,"start_character":36,"end_line":4618,"end_character":51},"in_reply_to":"b16258c9_d54ffdb9","updated":"2023-02-22 18:35:56.000000000","message":"Ack","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4643,"context_line":"                vserver_client.offline_volume(root_volume_name)"},{"line_number":4644,"context_line":"            except netapp_api.api.NaApiError as e:"},{"line_number":4645,"context_line":"                if e.code \u003d\u003d netapp_api.ENTRYNOTFOUND:"},{"line_number":4646,"context_line":"                    LOG.error(\"Entry doesn\u0027t exist.\")"},{"line_number":4647,"context_line":"                else:"},{"line_number":4648,"context_line":"                    raise"},{"line_number":4649,"context_line":"            vserver_client.delete_volume(root_volume_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"f7fb603d_6ca6b8ea","line":4646,"range":{"start_line":4646,"start_character":30,"end_line":4646,"end_character":50},"updated":"2023-02-17 02:43:06.000000000","message":"Please log a more meaningful message.","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4643,"context_line":"                vserver_client.offline_volume(root_volume_name)"},{"line_number":4644,"context_line":"            except netapp_api.api.NaApiError as e:"},{"line_number":4645,"context_line":"                if e.code \u003d\u003d netapp_api.ENTRYNOTFOUND:"},{"line_number":4646,"context_line":"                    LOG.error(\"Entry doesn\u0027t exist.\")"},{"line_number":4647,"context_line":"                else:"},{"line_number":4648,"context_line":"                    raise"},{"line_number":4649,"context_line":"            vserver_client.delete_volume(root_volume_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"aa997e7b_26e36d31","line":4646,"range":{"start_line":4646,"start_character":30,"end_line":4646,"end_character":50},"in_reply_to":"f7fb603d_6ca6b8ea","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4659,"context_line":"        self.send_request(f\u0027/svm/svms/{svm_uuid}\u0027, \u0027delete\u0027)"},{"line_number":4660,"context_line":""},{"line_number":4661,"context_line":"    @na_utils.trace"},{"line_number":4662,"context_line":"    def _get_snapmirror_uuid(self):"},{"line_number":4663,"context_line":"        # Get SVM UUID."},{"line_number":4664,"context_line":"        query \u003d {"},{"line_number":4665,"context_line":"            \u0027name\u0027: self.vserver,"}],"source_content_type":"text/x-python","patch_set":5,"id":"716d5b37_107c5d58","line":4662,"range":{"start_line":4662,"start_character":4,"end_line":4662,"end_character":35},"updated":"2023-02-17 02:43:06.000000000","message":"I could not understand this method. Why is it getting the snapmirro uuid ?","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4659,"context_line":"        self.send_request(f\u0027/svm/svms/{svm_uuid}\u0027, \u0027delete\u0027)"},{"line_number":4660,"context_line":""},{"line_number":4661,"context_line":"    @na_utils.trace"},{"line_number":4662,"context_line":"    def _get_snapmirror_uuid(self):"},{"line_number":4663,"context_line":"        # Get SVM UUID."},{"line_number":4664,"context_line":"        query \u003d {"},{"line_number":4665,"context_line":"            \u0027name\u0027: self.vserver,"}],"source_content_type":"text/x-python","patch_set":5,"id":"690f6754_dfade54b","line":4662,"range":{"start_line":4662,"start_character":4,"end_line":4662,"end_character":35},"in_reply_to":"716d5b37_107c5d58","updated":"2023-02-22 18:35:56.000000000","message":"I removed this function. It\u0027s not needed anymore.","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4666,"context_line":"            \u0027fields\u0027: \u0027uuid\u0027"},{"line_number":4667,"context_line":"        }"},{"line_number":4668,"context_line":"        res \u003d self.send_request("},{"line_number":4669,"context_line":"            \u0027/api/snapmirror/policies\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":4670,"context_line":"        if not res.get(\u0027records\u0027):"},{"line_number":4671,"context_line":"            msg \u003d (\u0027Vserver %s not found.\u0027) % self.vserver"},{"line_number":4672,"context_line":"            raise exception.NetAppException(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"56a0f2f4_6824d08c","line":4669,"range":{"start_line":4669,"start_character":12,"end_line":4669,"end_character":19},"updated":"2023-02-17 02:43:06.000000000","message":"This is definitely wrong, the \"/api\" should not be part of the action url.","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4666,"context_line":"            \u0027fields\u0027: \u0027uuid\u0027"},{"line_number":4667,"context_line":"        }"},{"line_number":4668,"context_line":"        res \u003d self.send_request("},{"line_number":4669,"context_line":"            \u0027/api/snapmirror/policies\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":4670,"context_line":"        if not res.get(\u0027records\u0027):"},{"line_number":4671,"context_line":"            msg \u003d (\u0027Vserver %s not found.\u0027) % self.vserver"},{"line_number":4672,"context_line":"            raise exception.NetAppException(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"aa69b316_a81731d9","line":4669,"range":{"start_line":4669,"start_character":12,"end_line":4669,"end_character":19},"in_reply_to":"56a0f2f4_6824d08c","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4670,"context_line":"        if not res.get(\u0027records\u0027):"},{"line_number":4671,"context_line":"            msg \u003d (\u0027Vserver %s not found.\u0027) % self.vserver"},{"line_number":4672,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":4673,"context_line":"        svm_id \u003d res.get(\u0027records\u0027)[0][\u0027uuid\u0027]"},{"line_number":4674,"context_line":"        return svm_id"},{"line_number":4675,"context_line":""},{"line_number":4676,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"949a3d61_35cfded1","line":4673,"range":{"start_line":4673,"start_character":7,"end_line":4673,"end_character":46},"updated":"2023-02-17 02:43:06.000000000","message":"SVM id from \"/snapmirror/policies\" ?","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4670,"context_line":"        if not res.get(\u0027records\u0027):"},{"line_number":4671,"context_line":"            msg \u003d (\u0027Vserver %s not found.\u0027) % self.vserver"},{"line_number":4672,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":4673,"context_line":"        svm_id \u003d res.get(\u0027records\u0027)[0][\u0027uuid\u0027]"},{"line_number":4674,"context_line":"        return svm_id"},{"line_number":4675,"context_line":""},{"line_number":4676,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"eb439815_d8baed0d","line":4673,"range":{"start_line":4673,"start_character":7,"end_line":4673,"end_character":46},"in_reply_to":"949a3d61_35cfded1","updated":"2023-02-22 18:35:56.000000000","message":"Ack","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4673,"context_line":"        svm_id \u003d res.get(\u0027records\u0027)[0][\u0027uuid\u0027]"},{"line_number":4674,"context_line":"        return svm_id"},{"line_number":4675,"context_line":""},{"line_number":4676,"context_line":"    @na_utils.trace"},{"line_number":4677,"context_line":"    def _get_record_count(self, api_result_element):"},{"line_number":4678,"context_line":"        try:"},{"line_number":4679,"context_line":"            return int(api_result_element.get(\u0027num_records\u0027))"},{"line_number":4680,"context_line":"        except KeyError:"},{"line_number":4681,"context_line":"            msg \u003d _(\u0027Missing record count for NetApp iterator API invocation.\u0027)"},{"line_number":4682,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":4683,"context_line":""},{"line_number":4684,"context_line":"    @na_utils.trace"},{"line_number":4685,"context_line":"    def get_vserver_volume_count(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"63e3c716_9b3503ed","line":4682,"range":{"start_line":4676,"start_character":4,"end_line":4682,"end_character":48},"updated":"2023-02-17 02:43:06.000000000","message":"remove this function. It is only used for one call. It is a copy/paste from ZAPI.","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4673,"context_line":"        svm_id \u003d res.get(\u0027records\u0027)[0][\u0027uuid\u0027]"},{"line_number":4674,"context_line":"        return svm_id"},{"line_number":4675,"context_line":""},{"line_number":4676,"context_line":"    @na_utils.trace"},{"line_number":4677,"context_line":"    def _get_record_count(self, api_result_element):"},{"line_number":4678,"context_line":"        try:"},{"line_number":4679,"context_line":"            return int(api_result_element.get(\u0027num_records\u0027))"},{"line_number":4680,"context_line":"        except KeyError:"},{"line_number":4681,"context_line":"            msg \u003d _(\u0027Missing record count for NetApp iterator API invocation.\u0027)"},{"line_number":4682,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":4683,"context_line":""},{"line_number":4684,"context_line":"    @na_utils.trace"},{"line_number":4685,"context_line":"    def get_vserver_volume_count(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"b3b943e3_77983100","line":4682,"range":{"start_line":4676,"start_character":4,"end_line":4682,"end_character":48},"in_reply_to":"63e3c716_9b3503ed","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4682,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":4683,"context_line":""},{"line_number":4684,"context_line":"    @na_utils.trace"},{"line_number":4685,"context_line":"    def get_vserver_volume_count(self):"},{"line_number":4686,"context_line":""},{"line_number":4687,"context_line":"        query \u003d {"},{"line_number":4688,"context_line":"            \u0027fields\u0027: \u0027name\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"67c52291_6e33496f","line":4685,"range":{"start_line":4685,"start_character":8,"end_line":4685,"end_character":32},"updated":"2023-02-17 02:43:06.000000000","message":"method documentation","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4682,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":4683,"context_line":""},{"line_number":4684,"context_line":"    @na_utils.trace"},{"line_number":4685,"context_line":"    def get_vserver_volume_count(self):"},{"line_number":4686,"context_line":""},{"line_number":4687,"context_line":"        query \u003d {"},{"line_number":4688,"context_line":"            \u0027fields\u0027: \u0027name\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"78495e68_419cbf56","line":4685,"range":{"start_line":4685,"start_character":8,"end_line":4685,"end_character":32},"in_reply_to":"67c52291_6e33496f","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4684,"context_line":"    @na_utils.trace"},{"line_number":4685,"context_line":"    def get_vserver_volume_count(self):"},{"line_number":4686,"context_line":""},{"line_number":4687,"context_line":"        query \u003d {"},{"line_number":4688,"context_line":"            \u0027fields\u0027: \u0027name\u0027"},{"line_number":4689,"context_line":"        }"},{"line_number":4690,"context_line":""},{"line_number":4691,"context_line":"        response \u003d self.send_request(\u0027/storage/volumes\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":4692,"context_line":"        return self._get_record_count(response)"}],"source_content_type":"text/x-python","patch_set":5,"id":"c3a9c46a_a4084f0d","line":4689,"range":{"start_line":4687,"start_character":8,"end_line":4689,"end_character":9},"updated":"2023-02-17 02:43:06.000000000","message":"does it need ? I think it can be removed, since it is only interested about the number.","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4684,"context_line":"    @na_utils.trace"},{"line_number":4685,"context_line":"    def get_vserver_volume_count(self):"},{"line_number":4686,"context_line":""},{"line_number":4687,"context_line":"        query \u003d {"},{"line_number":4688,"context_line":"            \u0027fields\u0027: \u0027name\u0027"},{"line_number":4689,"context_line":"        }"},{"line_number":4690,"context_line":""},{"line_number":4691,"context_line":"        response \u003d self.send_request(\u0027/storage/volumes\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":4692,"context_line":"        return self._get_record_count(response)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7471d75a_e21aafe9","line":4689,"range":{"start_line":4687,"start_character":8,"end_line":4689,"end_character":9},"in_reply_to":"c3a9c46a_a4084f0d","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4689,"context_line":"        }"},{"line_number":4690,"context_line":""},{"line_number":4691,"context_line":"        response \u003d self.send_request(\u0027/storage/volumes\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":4692,"context_line":"        return self._get_record_count(response)"},{"line_number":4693,"context_line":""},{"line_number":4694,"context_line":"    @na_utils.trace"},{"line_number":4695,"context_line":"    def _terminate_vserver_services(self, vserver_name, vserver_client,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7d75532a_f654ff3f","line":4692,"range":{"start_line":4692,"start_character":15,"end_line":4692,"end_character":47},"updated":"2023-02-17 02:43:06.000000000","message":"don\u0027t need to call a function, just do;\n\nreturn response[\u0027num_records\u0027]","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4689,"context_line":"        }"},{"line_number":4690,"context_line":""},{"line_number":4691,"context_line":"        response \u003d self.send_request(\u0027/storage/volumes\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":4692,"context_line":"        return self._get_record_count(response)"},{"line_number":4693,"context_line":""},{"line_number":4694,"context_line":"    @na_utils.trace"},{"line_number":4695,"context_line":"    def _terminate_vserver_services(self, vserver_name, vserver_client,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1d18e394_95f307bc","line":4692,"range":{"start_line":4692,"start_character":15,"end_line":4692,"end_character":47},"in_reply_to":"7d75532a_f654ff3f","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4692,"context_line":"        return self._get_record_count(response)"},{"line_number":4693,"context_line":""},{"line_number":4694,"context_line":"    @na_utils.trace"},{"line_number":4695,"context_line":"    def _terminate_vserver_services(self, vserver_name, vserver_client,"},{"line_number":4696,"context_line":"                                    security_services):"},{"line_number":4697,"context_line":""},{"line_number":4698,"context_line":"        svm_uuid \u003d self._get_unique_svm_by_name(vserver_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"68fb0855_71ca3794","line":4695,"range":{"start_line":4695,"start_character":8,"end_line":4695,"end_character":35},"updated":"2023-02-17 02:43:06.000000000","message":"method documentation","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4692,"context_line":"        return self._get_record_count(response)"},{"line_number":4693,"context_line":""},{"line_number":4694,"context_line":"    @na_utils.trace"},{"line_number":4695,"context_line":"    def _terminate_vserver_services(self, vserver_name, vserver_client,"},{"line_number":4696,"context_line":"                                    security_services):"},{"line_number":4697,"context_line":""},{"line_number":4698,"context_line":"        svm_uuid \u003d self._get_unique_svm_by_name(vserver_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"8fab0019_7ed11392","line":4695,"range":{"start_line":4695,"start_character":8,"end_line":4695,"end_character":35},"in_reply_to":"68fb0855_71ca3794","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4729,"context_line":"    def disable_kerberos(self, security_service):"},{"line_number":4730,"context_line":"        \"\"\"Disable Kerberos in all Vserver LIFs.\"\"\""},{"line_number":4731,"context_line":""},{"line_number":4732,"context_line":"        # (caiquemello) Using \u0027get_network_interface\u0027 instead of"},{"line_number":4733,"context_line":"        # \u0027list_network_interface\u0027 because REST equivalent needs the lif uuid"},{"line_number":4734,"context_line":"        # in the endpoint."},{"line_number":4735,"context_line":"        lifs \u003d self.get_network_interfaces()"},{"line_number":4736,"context_line":""},{"line_number":4737,"context_line":"        # NOTE(dviroel): If the Vserver has no LIFs, there are no Kerberos"}],"source_content_type":"text/x-python","patch_set":5,"id":"a6741742_e25443b4","line":4734,"range":{"start_line":4732,"start_character":8,"end_line":4734,"end_character":26},"updated":"2023-02-17 02:43:06.000000000","message":"I think it doesn\u0027t need this note. I think how it is mapped from ZAPi is not important to comment, unless the REST code does some different flow. That\u0027s not the case here, right ?","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4729,"context_line":"    def disable_kerberos(self, security_service):"},{"line_number":4730,"context_line":"        \"\"\"Disable Kerberos in all Vserver LIFs.\"\"\""},{"line_number":4731,"context_line":""},{"line_number":4732,"context_line":"        # (caiquemello) Using \u0027get_network_interface\u0027 instead of"},{"line_number":4733,"context_line":"        # \u0027list_network_interface\u0027 because REST equivalent needs the lif uuid"},{"line_number":4734,"context_line":"        # in the endpoint."},{"line_number":4735,"context_line":"        lifs \u003d self.get_network_interfaces()"},{"line_number":4736,"context_line":""},{"line_number":4737,"context_line":"        # NOTE(dviroel): If the Vserver has no LIFs, there are no Kerberos"}],"source_content_type":"text/x-python","patch_set":5,"id":"befde919_d9e7c8ee","line":4734,"range":{"start_line":4732,"start_character":8,"end_line":4734,"end_character":26},"in_reply_to":"a6741742_e25443b4","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4750,"context_line":"                self.send_request("},{"line_number":4751,"context_line":"                    f\u0027/protocols/nfs/kerberos/interfaces/{interface_uuid}\u0027,"},{"line_number":4752,"context_line":"                    \u0027patch\u0027, body\u003dbody)"},{"line_number":4753,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":4754,"context_line":"                disabled_msg \u003d ("},{"line_number":4755,"context_line":"                    \"Kerberos is already enabled/disabled on this LIF\")"},{"line_number":4756,"context_line":"                if (e.code \u003d\u003d netapp_api.KERBEROS_ALREADY_ENABLE_DISABELE and"}],"source_content_type":"text/x-python","patch_set":5,"id":"b138bf3b_9277f68c","line":4753,"range":{"start_line":4753,"start_character":12,"end_line":4753,"end_character":45},"updated":"2023-02-17 02:43:06.000000000","message":"This object is wrongly accessed. It should be \"netapp_api.api\"","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4750,"context_line":"                self.send_request("},{"line_number":4751,"context_line":"                    f\u0027/protocols/nfs/kerberos/interfaces/{interface_uuid}\u0027,"},{"line_number":4752,"context_line":"                    \u0027patch\u0027, body\u003dbody)"},{"line_number":4753,"context_line":"            except netapp_api.NaApiError as e:"},{"line_number":4754,"context_line":"                disabled_msg \u003d ("},{"line_number":4755,"context_line":"                    \"Kerberos is already enabled/disabled on this LIF\")"},{"line_number":4756,"context_line":"                if (e.code \u003d\u003d netapp_api.KERBEROS_ALREADY_ENABLE_DISABELE and"}],"source_content_type":"text/x-python","patch_set":5,"id":"296a03e0_c10a44b3","line":4753,"range":{"start_line":4753,"start_character":12,"end_line":4753,"end_character":45},"in_reply_to":"b138bf3b_9277f68c","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4768,"context_line":"            unique_volume \u003d self._get_volume_by_args(vserver\u003dvserver_name,"},{"line_number":4769,"context_line":"                                                     is_root\u003dTrue)"},{"line_number":4770,"context_line":"            root_volume_name \u003d unique_volume[\u0027name\u0027]"},{"line_number":4771,"context_line":"        except AttributeError:"},{"line_number":4772,"context_line":"            msg \u003d _(\u0027Could not determine root volume name \u0027"},{"line_number":4773,"context_line":"                    \u0027for Vserver %s.\u0027) % vserver_name"},{"line_number":4774,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":4775,"context_line":"        return root_volume_name"},{"line_number":4776,"context_line":""},{"line_number":4777,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"fbbe7431_45088d8c","line":4774,"range":{"start_line":4771,"start_character":8,"end_line":4774,"end_character":48},"updated":"2023-02-17 02:43:06.000000000","message":"ZAPi code. I think it is not required here.","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4768,"context_line":"            unique_volume \u003d self._get_volume_by_args(vserver\u003dvserver_name,"},{"line_number":4769,"context_line":"                                                     is_root\u003dTrue)"},{"line_number":4770,"context_line":"            root_volume_name \u003d unique_volume[\u0027name\u0027]"},{"line_number":4771,"context_line":"        except AttributeError:"},{"line_number":4772,"context_line":"            msg \u003d _(\u0027Could not determine root volume name \u0027"},{"line_number":4773,"context_line":"                    \u0027for Vserver %s.\u0027) % vserver_name"},{"line_number":4774,"context_line":"            raise exception.NetAppException(msg)"},{"line_number":4775,"context_line":"        return root_volume_name"},{"line_number":4776,"context_line":""},{"line_number":4777,"context_line":"    @na_utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"92485c37_911e0cfe","line":4774,"range":{"start_line":4771,"start_character":8,"end_line":4774,"end_character":48},"in_reply_to":"fbbe7431_45088d8c","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4777,"context_line":"    @na_utils.trace"},{"line_number":4778,"context_line":"    def ipspace_has_data_vservers(self, ipspace_name):"},{"line_number":4779,"context_line":"        \"\"\"Check whether an IPspace has any data Vservers assigned to it.\"\"\""},{"line_number":4780,"context_line":"        if not self.features.IPSPACES:"},{"line_number":4781,"context_line":"            return False"},{"line_number":4782,"context_line":""},{"line_number":4783,"context_line":"        query \u003d {\u0027ipspace.name\u0027: ipspace_name}"},{"line_number":4784,"context_line":"        result \u003d self.send_request(\u0027/svm/svms\u0027, \u0027get\u0027, query\u003dquery)"}],"source_content_type":"text/x-python","patch_set":5,"id":"6c7f58e9_9384f45b","line":4781,"range":{"start_line":4780,"start_character":8,"end_line":4781,"end_character":24},"updated":"2023-02-17 02:43:06.000000000","message":"not required. REST runs with 9.11.1 or upper","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4777,"context_line":"    @na_utils.trace"},{"line_number":4778,"context_line":"    def ipspace_has_data_vservers(self, ipspace_name):"},{"line_number":4779,"context_line":"        \"\"\"Check whether an IPspace has any data Vservers assigned to it.\"\"\""},{"line_number":4780,"context_line":"        if not self.features.IPSPACES:"},{"line_number":4781,"context_line":"            return False"},{"line_number":4782,"context_line":""},{"line_number":4783,"context_line":"        query \u003d {\u0027ipspace.name\u0027: ipspace_name}"},{"line_number":4784,"context_line":"        result \u003d self.send_request(\u0027/svm/svms\u0027, \u0027get\u0027, query\u003dquery)"}],"source_content_type":"text/x-python","patch_set":5,"id":"18b94421_723d0f5b","line":4781,"range":{"start_line":4780,"start_character":8,"end_line":4781,"end_character":24},"in_reply_to":"6c7f58e9_9384f45b","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4785,"context_line":"        return self._has_records(result)"},{"line_number":4786,"context_line":""},{"line_number":4787,"context_line":"    @na_utils.trace"},{"line_number":4788,"context_line":"    def delete_vlan(self, node, port, vlan):"},{"line_number":4789,"context_line":"        query \u003d {"},{"line_number":4790,"context_line":"            \u0027vlan.base_port.name\u0027: port,"},{"line_number":4791,"context_line":"            \u0027node.name\u0027: node,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5e6fbe79_72416fe3","line":4788,"range":{"start_line":4788,"start_character":8,"end_line":4788,"end_character":19},"updated":"2023-02-17 02:43:06.000000000","message":"method documentation","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4785,"context_line":"        return self._has_records(result)"},{"line_number":4786,"context_line":""},{"line_number":4787,"context_line":"    @na_utils.trace"},{"line_number":4788,"context_line":"    def delete_vlan(self, node, port, vlan):"},{"line_number":4789,"context_line":"        query \u003d {"},{"line_number":4790,"context_line":"            \u0027vlan.base_port.name\u0027: port,"},{"line_number":4791,"context_line":"            \u0027node.name\u0027: node,"}],"source_content_type":"text/x-python","patch_set":5,"id":"d27fde5f_57e08165","line":4788,"range":{"start_line":4788,"start_character":8,"end_line":4788,"end_character":19},"in_reply_to":"5e6fbe79_72416fe3","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"40d7ed502319a8a9cbdebbd5d46ce2ef9590546f","unresolved":true,"context_lines":[{"line_number":4952,"context_line":"    def get_ipspaces(self, ipspace_name\u003dNone):"},{"line_number":4953,"context_line":"        \"\"\"Gets one or more IPSpaces.\"\"\""},{"line_number":4954,"context_line":""},{"line_number":4955,"context_line":"        if not self.features.IPSPACES:"},{"line_number":4956,"context_line":"            return []"},{"line_number":4957,"context_line":""},{"line_number":4958,"context_line":"        query \u003d {"},{"line_number":4959,"context_line":"            \u0027name\u0027: ipspace_name"}],"source_content_type":"text/x-python","patch_set":5,"id":"91c6df38_31137d85","line":4956,"range":{"start_line":4955,"start_character":7,"end_line":4956,"end_character":21},"updated":"2023-02-17 02:43:06.000000000","message":"not required, REST runs with 9.11.1 or upper","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":4952,"context_line":"    def get_ipspaces(self, ipspace_name\u003dNone):"},{"line_number":4953,"context_line":"        \"\"\"Gets one or more IPSpaces.\"\"\""},{"line_number":4954,"context_line":""},{"line_number":4955,"context_line":"        if not self.features.IPSPACES:"},{"line_number":4956,"context_line":"            return []"},{"line_number":4957,"context_line":""},{"line_number":4958,"context_line":"        query \u003d {"},{"line_number":4959,"context_line":"            \u0027name\u0027: ipspace_name"}],"source_content_type":"text/x-python","patch_set":5,"id":"05c9e5ed_cf6acbd5","line":4956,"range":{"start_line":4955,"start_character":7,"end_line":4956,"end_character":21},"in_reply_to":"91c6df38_31137d85","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"}],"manila/share/drivers/netapp/dataontap/client/rest_api.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"fe3273f31eaf3c49b00c8321a72e9d21a3865d14","unresolved":true,"context_lines":[{"line_number":34,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"ENTRYNOTFOUND \u003d \u00274\u0027"},{"line_number":37,"context_line":"REST_DUPLICATE_ENTRY \u003d \u00271\u0027"},{"line_number":38,"context_line":"FPOLICY_MODIF_POLICY_ALREADY_DISABLED \u003d \u00279765029\u0027"},{"line_number":39,"context_line":"REST_DUPLICATE_ENTRY \u003d \u00271\u0027"},{"line_number":40,"context_line":"ESIS_CLONE_NOT_LICENSED \u003d \u002714956\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"6361bace_8d1fa47e","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":26},"updated":"2023-02-16 16:26:00.000000000","message":"duplicate, see 2 lines below\n\n.. oh the irony","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":34,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"ENTRYNOTFOUND \u003d \u00274\u0027"},{"line_number":37,"context_line":"REST_DUPLICATE_ENTRY \u003d \u00271\u0027"},{"line_number":38,"context_line":"FPOLICY_MODIF_POLICY_ALREADY_DISABLED \u003d \u00279765029\u0027"},{"line_number":39,"context_line":"REST_DUPLICATE_ENTRY \u003d \u00271\u0027"},{"line_number":40,"context_line":"ESIS_CLONE_NOT_LICENSED \u003d \u002714956\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"f7a750fe_a3ee0ffe","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":26},"in_reply_to":"6361bace_8d1fa47e","updated":"2023-02-22 18:35:56.000000000","message":"Removed :D","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"fe3273f31eaf3c49b00c8321a72e9d21a3865d14","unresolved":true,"context_lines":[{"line_number":49,"context_line":"REST_NOT_INITIALIZED_ERROR \u003d \u002713303812\u0027"},{"line_number":50,"context_line":"REST_DUPLICATE_ROUTE \u003d \u00271966345\u0027"},{"line_number":51,"context_line":"REST_FAIL_ADD_PORT_BROADCAST \u003d \u00271967149\u0027"},{"line_number":52,"context_line":"KERBEROS_ALREADY_ENABLE_DISABELE \u003d \u00273276861\u0027"},{"line_number":53,"context_line":"REST_INTERFACE_BOUND \u003d \u00271376858\u0027"},{"line_number":54,"context_line":"REST_PORT_IN_USE \u003d \u00271966189\u0027"},{"line_number":55,"context_line":"ENFS_V4_0_ENABLED_MIGRATION_FAILURE \u003d \u002713172940\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"ddc6367f_bdd1b31e","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":32},"updated":"2023-02-16 16:26:00.000000000","message":"please change to `KERBEROS_ALREADY_ENABLED_DISABLED`\n\nfor reference: in https://library.netapp.com/ecmdocs/ECMLP2884821/html/index.html#/NAS/kerberos_interface_modify it states \"3276861\tKerberos is already enabled/disabled on this LIF.\"","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":49,"context_line":"REST_NOT_INITIALIZED_ERROR \u003d \u002713303812\u0027"},{"line_number":50,"context_line":"REST_DUPLICATE_ROUTE \u003d \u00271966345\u0027"},{"line_number":51,"context_line":"REST_FAIL_ADD_PORT_BROADCAST \u003d \u00271967149\u0027"},{"line_number":52,"context_line":"KERBEROS_ALREADY_ENABLE_DISABELE \u003d \u00273276861\u0027"},{"line_number":53,"context_line":"REST_INTERFACE_BOUND \u003d \u00271376858\u0027"},{"line_number":54,"context_line":"REST_PORT_IN_USE \u003d \u00271966189\u0027"},{"line_number":55,"context_line":"ENFS_V4_0_ENABLED_MIGRATION_FAILURE \u003d \u002713172940\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"75272583_b2b46290","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":32},"in_reply_to":"ddc6367f_bdd1b31e","updated":"2023-02-22 18:35:56.000000000","message":"Ack","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"}],"manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode_rest.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a1bf386ecdf24a96825ce41a2cc96f4c7e10d64b","unresolved":true,"context_lines":[{"line_number":3582,"context_line":"        self.client.configure_kerberos(fake.KERBEROS_SECURITY_SERVICE,"},{"line_number":3583,"context_line":"                                       fake.VSERVER_NAME)"},{"line_number":3584,"context_line":""},{"line_number":3585,"context_line":"        self.client.configure_dns.assert_called_once()"},{"line_number":3586,"context_line":"        self_get_kerberos \u003d self.client._get_kerberos_service_principal_name"},{"line_number":3587,"context_line":"        self_get_kerberos.assert_called_once_with("},{"line_number":3588,"context_line":"            fake.KERBEROS_SECURITY_SERVICE, fake.VSERVER_NAME)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f5dc170_6775576a","line":3585,"range":{"start_line":3585,"start_character":33,"end_line":3585,"end_character":54},"updated":"2023-02-17 01:42:13.000000000","message":"please replace here and below with assert_called_once_with","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"becaa97bc05e3407d30bf6349df6f9179e8c5eff","unresolved":false,"context_lines":[{"line_number":3582,"context_line":"        self.client.configure_kerberos(fake.KERBEROS_SECURITY_SERVICE,"},{"line_number":3583,"context_line":"                                       fake.VSERVER_NAME)"},{"line_number":3584,"context_line":""},{"line_number":3585,"context_line":"        self.client.configure_dns.assert_called_once()"},{"line_number":3586,"context_line":"        self_get_kerberos \u003d self.client._get_kerberos_service_principal_name"},{"line_number":3587,"context_line":"        self_get_kerberos.assert_called_once_with("},{"line_number":3588,"context_line":"            fake.KERBEROS_SECURITY_SERVICE, fake.VSERVER_NAME)"}],"source_content_type":"text/x-python","patch_set":5,"id":"048e14e3_da2c93a7","line":3585,"range":{"start_line":3585,"start_character":33,"end_line":3585,"end_character":54},"in_reply_to":"7f5dc170_6775576a","updated":"2023-02-22 18:35:56.000000000","message":"Done","commit_id":"07ae7d1e280993b2d4b51f959db52e05cff41dad"}]}