)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b6e482f8cdf7a825ee025899e2fedafbef67a4cb","unresolved":true,"context_lines":[{"line_number":9,"context_line":"From version 2.76, \u0027default_ad_site\u0027 which if provided set domain"},{"line_number":10,"context_line":"controller discovery mode to \u0027site\u0027."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Relates-bug: #1988146"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: I8e21e9170eace134a51efed84de1ccc58eb7eaaa"},{"line_number":15,"context_line":"Change-Id: I251e4f94ef04e9ad2fe24844fb8ce1947f42d752"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"25bcd7aa_7ba1c040","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":7},"updated":"2023-02-17 00:05:07.000000000","message":"Related","commit_id":"a2e6e4f66d401ce5f8777b1a61d7a304bd1b0abe"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5419e23efd8fdd099bda301adc71935685c28267","unresolved":false,"context_lines":[{"line_number":9,"context_line":"From version 2.76, \u0027default_ad_site\u0027 which if provided set domain"},{"line_number":10,"context_line":"controller discovery mode to \u0027site\u0027."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Relates-bug: #1988146"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: I8e21e9170eace134a51efed84de1ccc58eb7eaaa"},{"line_number":15,"context_line":"Change-Id: I251e4f94ef04e9ad2fe24844fb8ce1947f42d752"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"45f33db9_7cae552f","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":7},"in_reply_to":"25bcd7aa_7ba1c040","updated":"2023-02-17 09:11:54.000000000","message":"Done","commit_id":"a2e6e4f66d401ce5f8777b1a61d7a304bd1b0abe"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dc1176eb55055b275f32ea0c927625dd6a61ca11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ae9ca7ef_19e44aab","updated":"2023-02-16 11:50:15.000000000","message":"Looking good - Waiting on CI output.\nIt would be also good to get the NetApp CI voting on this change.\nThank you very much for splitting this change, Kiran!","commit_id":"63b9279f2771921f84fb601f493f9f4024e116db"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b6e482f8cdf7a825ee025899e2fedafbef67a4cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7139879f_0d350d37","updated":"2023-02-17 00:05:07.000000000","message":"run NetApp-CI\n\nI\u0027d like NetApp folks to weigh in on this change please.","commit_id":"a2e6e4f66d401ce5f8777b1a61d7a304bd1b0abe"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"a5186d2bc05bd0785516853612451fd4cc377546","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1773e9fa_8d2dd6d2","updated":"2023-02-17 15:43:46.000000000","message":"Hi, Kiran, overall patch looks good to me. If I\u0027m not wrong, CI currently does not validate this scenario. Did you tested it manually? If so, would it be possible to  provide some QA logs?","commit_id":"d13b7ecc67018908359c91057aba302c738d37a8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"203c379184c538531d808b77e2e1ad6079445f1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7624b8cd_5809baa2","updated":"2023-02-17 13:56:16.000000000","message":"LGTM, thanks.","commit_id":"d13b7ecc67018908359c91057aba302c738d37a8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"375fd3377b532ef568ebee72df43d72edff454f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bd4c8708_16794743","updated":"2023-02-20 22:38:51.000000000","message":"Thanks, LGTM - waiting on Nahim\u0027s response","commit_id":"d13b7ecc67018908359c91057aba302c738d37a8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"523097349ef3a47fffd62854c66b61f8d992fbfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5a831349_e94b7051","updated":"2023-02-20 22:38:29.000000000","message":"run-NetApp CI","commit_id":"d13b7ecc67018908359c91057aba302c738d37a8"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f2546b87620ea4009a43cda53667b6cfb9c4eaa1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3d2abf1f_9f2b032c","in_reply_to":"1773e9fa_8d2dd6d2","updated":"2023-02-17 16:43:13.000000000","message":"yes, I have tested manually, its on our production setup for months now. I will try to get logs","commit_id":"d13b7ecc67018908359c91057aba302c738d37a8"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"133639a337197f3b412be0beb7f6e61f2b0ba0e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"18f30598_729e2201","in_reply_to":"3d2abf1f_9f2b032c","updated":"2023-02-20 12:18:38.000000000","message":"https://paste.opendev.org/show/bVDFZA48GSZU4C6kH0zd/","commit_id":"d13b7ecc67018908359c91057aba302c738d37a8"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"4fdffe294ba2cbbf0ecc9b50390dc555c8d8c6db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5614ddf7_aa99dc55","updated":"2023-02-21 11:14:20.000000000","message":"Thanks for providing the logs, Kiran. LGTM.","commit_id":"0a66bd095ca2d799f1e730cd17a989c442af6613"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"70ec36372281ad82859abea4d8bd0e14d1ab4705","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"11453ff5_9fa1e47c","updated":"2023-02-21 15:33:59.000000000","message":"run-NetApp CI","commit_id":"0a66bd095ca2d799f1e730cd17a989c442af6613"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b6e482f8cdf7a825ee025899e2fedafbef67a4cb","unresolved":true,"context_lines":[{"line_number":2029,"context_line":""},{"line_number":2030,"context_line":"    @na_utils.trace"},{"line_number":2031,"context_line":"    def configure_cifs_options(self, security_service,"},{"line_number":2032,"context_line":"                               default_dc_discovery\u003dFalse):"},{"line_number":2033,"context_line":"        if security_service.get(\u0027server\u0027):"},{"line_number":2034,"context_line":"            api_args \u003d {\u0027mode\u0027: \u0027none\u0027}"},{"line_number":2035,"context_line":"        elif security_service.get(\u0027default_ad_site\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"4371a060_b0973b03","line":2032,"range":{"start_line":2032,"start_character":31,"end_line":2032,"end_character":58},"updated":"2023-02-17 00:05:07.000000000","message":"this isn\u0027t used","commit_id":"a2e6e4f66d401ce5f8777b1a61d7a304bd1b0abe"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"5419e23efd8fdd099bda301adc71935685c28267","unresolved":false,"context_lines":[{"line_number":2029,"context_line":""},{"line_number":2030,"context_line":"    @na_utils.trace"},{"line_number":2031,"context_line":"    def configure_cifs_options(self, security_service,"},{"line_number":2032,"context_line":"                               default_dc_discovery\u003dFalse):"},{"line_number":2033,"context_line":"        if security_service.get(\u0027server\u0027):"},{"line_number":2034,"context_line":"            api_args \u003d {\u0027mode\u0027: \u0027none\u0027}"},{"line_number":2035,"context_line":"        elif security_service.get(\u0027default_ad_site\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff1acdd8_437ca9d4","line":2032,"range":{"start_line":2032,"start_character":31,"end_line":2032,"end_character":58},"in_reply_to":"4371a060_b0973b03","updated":"2023-02-17 09:11:54.000000000","message":"nice catch.","commit_id":"a2e6e4f66d401ce5f8777b1a61d7a304bd1b0abe"}]}
