)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2b34caea473b0a60bd0f17192766686f336ea2a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c24163c9_0bd09667","updated":"2023-08-24 20:47:44.000000000","message":"This needs a release note, carlos!","commit_id":"d675dc52ed60104c32a9390617e371a70337ad5a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b94c373fc1b6f607b8cca45f8a7953abfb5261e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"feaf8a6f_ef4855ff","updated":"2023-09-14 17:37:29.000000000","message":"Thanks for the release notes suggestion - looks much better now :) PTAL","commit_id":"ed58e813eae4742fe77e29f89d76c957175f9de4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f524117b86748edb700930732658ff2f9c8161eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fde83e22_8fcac620","updated":"2023-09-13 19:55:23.000000000","message":"Thanks for the review, Goutham! Please check the latest PS","commit_id":"ed58e813eae4742fe77e29f89d76c957175f9de4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ea58f5f7ef5ec827a649daea8aa3d4c468c35e8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bbf3ceef_38d5fd96","updated":"2023-09-13 21:38:52.000000000","message":"recheck\nKnown issue in the LVM driver job","commit_id":"ed58e813eae4742fe77e29f89d76c957175f9de4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f88e62c6ec6a477eb4330196cb4b597e33ebd31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5a8d7b5f_46368473","updated":"2023-09-14 17:45:56.000000000","message":"real quick; some typos","commit_id":"424786a743c0d526c549ea60b5d898d1648517d8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b23c2862666296af3cc923f7b2354c61c0fc505","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"cda8e412_ddcf04c9","updated":"2023-09-14 18:14:08.000000000","message":"LGTM; thanks for adding the bug link and fixing up the reno..","commit_id":"3eb34c3ce7feaf51012c3338a03882b0d103138a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7ad2a27f1ee2448e7901448848b25df04d07357e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0e0862f0_4598858a","updated":"2023-09-14 19:31:38.000000000","message":"Thanks Carlos, LGTM","commit_id":"3eb34c3ce7feaf51012c3338a03882b0d103138a"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"9698e216f7c231c60d2627a49ee72ab558cf0006","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e6f450a5_b40dc7df","updated":"2023-09-14 18:40:37.000000000","message":"lgtm, question: would this be affected by the export location metadata implementation started earlier this cycle?","commit_id":"3eb34c3ce7feaf51012c3338a03882b0d103138a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2728b0d7ea45aa7c1214b53324f865566d5b54b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8cbc4e47_f23bbd74","updated":"2023-09-14 19:33:37.000000000","message":"zuul passed on a prior run; should do now as well... lets queue it up","commit_id":"3eb34c3ce7feaf51012c3338a03882b0d103138a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ec1231aa63e96dc46eb4830c5aed41f634dc9aa0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a809165d_09b4fe71","in_reply_to":"e6f450a5_b40dc7df","updated":"2023-09-14 19:02:55.000000000","message":"Chatted briefly about this we Goutham... We shouldn\u0027t allow the users to update metadata set by the services... The preferred export location is something that the drivers set. So we should likely block people from updating the preferred field in the metadata export location update/create/delete APIs. In case the administrators want to set another flags, they will be able to","commit_id":"3eb34c3ce7feaf51012c3338a03882b0d103138a"}],"manila/share/drivers/cephfs/driver.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dfa1577086c71bd97ea8caab84e448a7343aa386","unresolved":true,"context_lines":[{"line_number":1038,"context_line":"        if not self.configured_ip_versions:"},{"line_number":1039,"context_line":"            try:"},{"line_number":1040,"context_line":"                if not self.export_ips:"},{"line_number":1041,"context_line":"                    self.export_ips \u003d ("},{"line_number":1042,"context_line":"                        self._get_export_ips())"},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"                for export_ip in self.export_ips:"},{"line_number":1045,"context_line":"                    self.configured_ip_versions.add("}],"source_content_type":"text/x-python","patch_set":2,"id":"decd5811_1175e13e","line":1042,"range":{"start_line":1041,"start_character":38,"end_line":1042,"end_character":47},"updated":"2023-03-28 01:40:27.000000000","message":"not needed","commit_id":"82cac03aebf24788ecfccb4b50314b09058b073a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e9ef186949fd264880e3378d0ebe33b6c0dbbceb","unresolved":false,"context_lines":[{"line_number":1038,"context_line":"        if not self.configured_ip_versions:"},{"line_number":1039,"context_line":"            try:"},{"line_number":1040,"context_line":"                if not self.export_ips:"},{"line_number":1041,"context_line":"                    self.export_ips \u003d ("},{"line_number":1042,"context_line":"                        self._get_export_ips())"},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"                for export_ip in self.export_ips:"},{"line_number":1045,"context_line":"                    self.configured_ip_versions.add("}],"source_content_type":"text/x-python","patch_set":2,"id":"baed2895_4f344134","line":1042,"range":{"start_line":1041,"start_character":38,"end_line":1042,"end_character":47},"in_reply_to":"decd5811_1175e13e","updated":"2023-03-28 22:21:33.000000000","message":"Done","commit_id":"82cac03aebf24788ecfccb4b50314b09058b073a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dfa1577086c71bd97ea8caab84e448a7343aa386","unresolved":true,"context_lines":[{"line_number":1149,"context_line":"        rados_command(self.rados_client, \"fs subvolume deauthorize\", argdict)"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":"    def _get_export_ips(self):"},{"line_number":1152,"context_line":"        # NOTE(carloss) If we are reaching this point, it means that the"},{"line_number":1153,"context_line":"        # deployment does not have a cephfs_nfs_cluster_id configured, thus we"},{"line_number":1154,"context_line":"        # don\u0027t need to look for different export ips."},{"line_number":1155,"context_line":"        ganesha_export_ips \u003d self.config.cephfs_ganesha_export_ips"},{"line_number":1156,"context_line":"        if not ganesha_export_ips:"},{"line_number":1157,"context_line":"            ganesha_export_ips \u003d [self.ganesha_host]"}],"source_content_type":"text/x-python","patch_set":2,"id":"209d6ce3_4955eaea","line":1154,"range":{"start_line":1152,"start_character":7,"end_line":1154,"end_character":54},"updated":"2023-03-28 01:40:27.000000000","message":"note not relevant now - can add a more relevant explaining why this will *always* be preferred\u003dfalse","commit_id":"82cac03aebf24788ecfccb4b50314b09058b073a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5a525c82fe0f6b1ad209bf52d4a55ba86ce29bed","unresolved":false,"context_lines":[{"line_number":1149,"context_line":"        rados_command(self.rados_client, \"fs subvolume deauthorize\", argdict)"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":"    def _get_export_ips(self):"},{"line_number":1152,"context_line":"        # NOTE(carloss) If we are reaching this point, it means that the"},{"line_number":1153,"context_line":"        # deployment does not have a cephfs_nfs_cluster_id configured, thus we"},{"line_number":1154,"context_line":"        # don\u0027t need to look for different export ips."},{"line_number":1155,"context_line":"        ganesha_export_ips \u003d self.config.cephfs_ganesha_export_ips"},{"line_number":1156,"context_line":"        if not ganesha_export_ips:"},{"line_number":1157,"context_line":"            ganesha_export_ips \u003d [self.ganesha_host]"}],"source_content_type":"text/x-python","patch_set":2,"id":"e9fb4a7d_51b1e309","line":1154,"range":{"start_line":1152,"start_character":7,"end_line":1154,"end_character":54},"in_reply_to":"209d6ce3_4955eaea","updated":"2023-08-23 16:32:53.000000000","message":"Done","commit_id":"82cac03aebf24788ecfccb4b50314b09058b073a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dfa1577086c71bd97ea8caab84e448a7343aa386","unresolved":true,"context_lines":[{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"        return self._nfs_clusterid"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":"    def _get_ganesha_export_ips(self):"},{"line_number":1202,"context_line":"        ganesha_server_ips \u003d ("},{"line_number":1203,"context_line":"            self.configuration.safe_get(\u0027cephfs_ganesha_export_ips\u0027) or [])"},{"line_number":1204,"context_line":"        if not ganesha_server_ips:"},{"line_number":1205,"context_line":"            ganesha_server_ips \u003d ("},{"line_number":1206,"context_line":"                self.configuration.safe_get(\u0027cephfs_ganesha_server_ip\u0027))"},{"line_number":1207,"context_line":"            ganesha_server_ips \u003d ("},{"line_number":1208,"context_line":"                [ganesha_server_ips] if ganesha_server_ips else [])"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"        return ganesha_server_ips"},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"    def _get_export_ips(self):"},{"line_number":1213,"context_line":"        \"\"\"Get NFS cluster export ips.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"05b3cbaf_225cdb33","line":1210,"range":{"start_line":1201,"start_character":4,"end_line":1210,"end_character":33},"updated":"2023-03-28 01:40:27.000000000","message":"not being used anymore, just emove","commit_id":"82cac03aebf24788ecfccb4b50314b09058b073a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e9ef186949fd264880e3378d0ebe33b6c0dbbceb","unresolved":true,"context_lines":[{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"        return self._nfs_clusterid"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":"    def _get_ganesha_export_ips(self):"},{"line_number":1202,"context_line":"        ganesha_server_ips \u003d ("},{"line_number":1203,"context_line":"            self.configuration.safe_get(\u0027cephfs_ganesha_export_ips\u0027) or [])"},{"line_number":1204,"context_line":"        if not ganesha_server_ips:"},{"line_number":1205,"context_line":"            ganesha_server_ips \u003d ("},{"line_number":1206,"context_line":"                self.configuration.safe_get(\u0027cephfs_ganesha_server_ip\u0027))"},{"line_number":1207,"context_line":"            ganesha_server_ips \u003d ("},{"line_number":1208,"context_line":"                [ganesha_server_ips] if ganesha_server_ips else [])"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"        return ganesha_server_ips"},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"    def _get_export_ips(self):"},{"line_number":1213,"context_line":"        \"\"\"Get NFS cluster export ips.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"f2c604d4_e09b92e1","line":1210,"range":{"start_line":1201,"start_character":4,"end_line":1210,"end_character":33},"in_reply_to":"05b3cbaf_225cdb33","updated":"2023-03-28 22:21:33.000000000","message":"Actually, it is being used - so ignore","commit_id":"82cac03aebf24788ecfccb4b50314b09058b073a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5a525c82fe0f6b1ad209bf52d4a55ba86ce29bed","unresolved":false,"context_lines":[{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"        return self._nfs_clusterid"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":"    def _get_ganesha_export_ips(self):"},{"line_number":1202,"context_line":"        ganesha_server_ips \u003d ("},{"line_number":1203,"context_line":"            self.configuration.safe_get(\u0027cephfs_ganesha_export_ips\u0027) or [])"},{"line_number":1204,"context_line":"        if not ganesha_server_ips:"},{"line_number":1205,"context_line":"            ganesha_server_ips \u003d ("},{"line_number":1206,"context_line":"                self.configuration.safe_get(\u0027cephfs_ganesha_server_ip\u0027))"},{"line_number":1207,"context_line":"            ganesha_server_ips \u003d ("},{"line_number":1208,"context_line":"                [ganesha_server_ips] if ganesha_server_ips else [])"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"        return ganesha_server_ips"},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"    def _get_export_ips(self):"},{"line_number":1213,"context_line":"        \"\"\"Get NFS cluster export ips.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"b4ebeaac_90ad9084","line":1210,"range":{"start_line":1201,"start_character":4,"end_line":1210,"end_character":33},"in_reply_to":"f2c604d4_e09b92e1","updated":"2023-08-23 16:32:53.000000000","message":"Done","commit_id":"82cac03aebf24788ecfccb4b50314b09058b073a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ac2d66f6ab93bc68d0bc77f1188a8e980e8ba88","unresolved":true,"context_lines":[{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"        export_ips \u003d []"},{"line_number":1156,"context_line":"        for ip in ganesha_export_ips:"},{"line_number":1157,"context_line":"            # Add the address and make it preferred \u003d False. As of Zed, we"},{"line_number":1158,"context_line":"            # can also have a Cephadm deployed ganesha server. The new server"},{"line_number":1159,"context_line":"            # would be always preferred."},{"line_number":1160,"context_line":"            export_ips.append({\u0027ip\u0027: ip, \u0027preferred\u0027: False})"},{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"        return export_ips"}],"source_content_type":"text/x-python","patch_set":4,"id":"af3de988_a217b294","line":1159,"range":{"start_line":1157,"start_character":61,"end_line":1159,"end_character":40},"updated":"2023-09-11 21:09:07.000000000","message":"this comment makes sense only for the NFSClusterProtocolHelper..","commit_id":"d675dc52ed60104c32a9390617e371a70337ad5a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f524117b86748edb700930732658ff2f9c8161eb","unresolved":false,"context_lines":[{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"        export_ips \u003d []"},{"line_number":1156,"context_line":"        for ip in ganesha_export_ips:"},{"line_number":1157,"context_line":"            # Add the address and make it preferred \u003d False. As of Zed, we"},{"line_number":1158,"context_line":"            # can also have a Cephadm deployed ganesha server. The new server"},{"line_number":1159,"context_line":"            # would be always preferred."},{"line_number":1160,"context_line":"            export_ips.append({\u0027ip\u0027: ip, \u0027preferred\u0027: False})"},{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"        return export_ips"}],"source_content_type":"text/x-python","patch_set":4,"id":"e3b9c734_8075174a","line":1159,"range":{"start_line":1157,"start_character":61,"end_line":1159,"end_character":40},"in_reply_to":"af3de988_a217b294","updated":"2023-09-13 19:55:23.000000000","message":"Done","commit_id":"d675dc52ed60104c32a9390617e371a70337ad5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1ac2d66f6ab93bc68d0bc77f1188a8e980e8ba88","unresolved":true,"context_lines":[{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"        return self._nfs_clusterid"},{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"    def _get_ganesha_export_ips(self):"},{"line_number":1200,"context_line":"        ganesha_server_ips \u003d ("},{"line_number":1201,"context_line":"            self.configuration.safe_get(\u0027cephfs_ganesha_export_ips\u0027) or [])"},{"line_number":1202,"context_line":"        if not ganesha_server_ips:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5714a882_8a60415e","line":1199,"range":{"start_line":1199,"start_character":8,"end_line":1199,"end_character":31},"updated":"2023-09-11 21:09:07.000000000","message":"`_get_configured_export_ips` perhaps?","commit_id":"d675dc52ed60104c32a9390617e371a70337ad5a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f524117b86748edb700930732658ff2f9c8161eb","unresolved":false,"context_lines":[{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"        return self._nfs_clusterid"},{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"    def _get_ganesha_export_ips(self):"},{"line_number":1200,"context_line":"        ganesha_server_ips \u003d ("},{"line_number":1201,"context_line":"            self.configuration.safe_get(\u0027cephfs_ganesha_export_ips\u0027) or [])"},{"line_number":1202,"context_line":"        if not ganesha_server_ips:"}],"source_content_type":"text/x-python","patch_set":4,"id":"0f3d2d1f_49919502","line":1199,"range":{"start_line":1199,"start_character":8,"end_line":1199,"end_character":31},"in_reply_to":"5714a882_8a60415e","updated":"2023-09-13 19:55:23.000000000","message":"Done","commit_id":"d675dc52ed60104c32a9390617e371a70337ad5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2b34caea473b0a60bd0f17192766686f336ea2a7","unresolved":true,"context_lines":[{"line_number":1239,"context_line":"                    \"and restart the manila share service.\")"},{"line_number":1240,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":1241,"context_line":""},{"line_number":1242,"context_line":"        export_ips \u003d []"},{"line_number":1243,"context_line":"        for ip in ceph_nfs_export_ips:"},{"line_number":1244,"context_line":"            export_ips.append({\u0027ip\u0027: ip, \u0027preferred\u0027: True})"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"        for ip in ganesha_export_ips:"},{"line_number":1247,"context_line":"            export_ips.append({\u0027ip\u0027: ip, \u0027preferred\u0027: False})"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"        return export_ips"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fcda32f_6826bd02","line":1248,"range":{"start_line":1242,"start_character":0,"end_line":1248,"end_character":0},"updated":"2023-08-24 20:47:44.000000000","message":"Can you add a comment here explaining what\u0027s happening.. \n```\n# It\u0027s possible for deployers to state additional \n# NFS interfaces directly via manila.conf. If they do,\n# these are represented as non-preferred export paths.\n# This is mostly to allow NFS-Ganesha server migrations.\n```","commit_id":"d675dc52ed60104c32a9390617e371a70337ad5a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f524117b86748edb700930732658ff2f9c8161eb","unresolved":false,"context_lines":[{"line_number":1239,"context_line":"                    \"and restart the manila share service.\")"},{"line_number":1240,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":1241,"context_line":""},{"line_number":1242,"context_line":"        export_ips \u003d []"},{"line_number":1243,"context_line":"        for ip in ceph_nfs_export_ips:"},{"line_number":1244,"context_line":"            export_ips.append({\u0027ip\u0027: ip, \u0027preferred\u0027: True})"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"        for ip in ganesha_export_ips:"},{"line_number":1247,"context_line":"            export_ips.append({\u0027ip\u0027: ip, \u0027preferred\u0027: False})"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"        return export_ips"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"70a6ec98_40058ce0","line":1248,"range":{"start_line":1242,"start_character":0,"end_line":1248,"end_character":0},"in_reply_to":"3fcda32f_6826bd02","updated":"2023-09-13 19:55:23.000000000","message":"Done","commit_id":"d675dc52ed60104c32a9390617e371a70337ad5a"}],"releasenotes/notes/ceph-nfs-set-preferred-export-location-d1f228a51df8c8b4.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"31c27831684565f32cba008b1ebf4d636deea96f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The CephFS backend driver is now capable of updating the export locations"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6651fb0a_f32bb233","line":1,"updated":"2023-09-13 23:17:46.000000000","message":"the \"preferred\" metadata change is only effective when ``ceph_nfs_cluster_id`` is set. Without it, preferred\u003dFalse for all exports set up by the driver, same as it is now. so i suggest some rewrites:\n\nfeatures:\n  - |\n    It is now possible to configure ``cephfs_ganesha_export_ips`` (or\n    alternatively, ``cephs_ganesha_server_ip``) alongside ``ceph_nfs_cluster_id``.\n    Setting these options will allow the CephFS driver to report additional\n    export paths. These additional export paths will have the \"preferred\"\n    metadata key set to False. The export paths pertaining to the NFS service\n    host discovered by the driver will have the \"preferred\" metadata key\n    set to True. It is expected that administrators will configure additional\n    IP addresses when preparing to migrate from a standalone NFS-Ganesha\n    service to a NFS service cluster setup facilitated by the Ceph orchestration\n    service. Eventually, when the migration has completed, these configuration\n    options can be removed and the corresponding share export path records will be\n    dropped from manila. Note that the CephFS driver will not create or manipulate\n    access rules within the NFS service configured via \n    ``cephfs_ganesha_export_ips`` or `cephs_ganesha_server_ip``.\nupgrades:\n  - |\n    In order to assist the user experience when migrating from a standalone\n    CephFS NFS (NFS-Ganesha) service to an NFS service created with the\n    Ceph Orchestrator, the CephFS driver allows configuring \n    ``cephfs_ganesha_export_ips`` (or alternatively, ``cephs_ganesha_server_ip``) \n    alongside ``ceph_nfs_cluster_id``.","commit_id":"ed58e813eae4742fe77e29f89d76c957175f9de4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b94c373fc1b6f607b8cca45f8a7953abfb5261e3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The CephFS backend driver is now capable of updating the export locations"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa47441c_13484a87","line":1,"in_reply_to":"6651fb0a_f32bb233","updated":"2023-09-14 17:37:29.000000000","message":"Done","commit_id":"ed58e813eae4742fe77e29f89d76c957175f9de4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f88e62c6ec6a477eb4330196cb4b597e33ebd31","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    It is now possible to configure `cephfs_ganesha_export_ips` (or"},{"line_number":5,"context_line":"    alternatively, `cephs_ganesha_server_ip`) alongside `ceph_nfs_cluster_id`."},{"line_number":6,"context_line":"    Setting these options will allow the CephFS driver to report additional"},{"line_number":7,"context_line":"    export paths. These additional export paths will have the \"preferred\""},{"line_number":8,"context_line":"    metadata key set to False. The export paths pertaining to the NFS service"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"66ed8e2f_81dd8c17","line":5,"range":{"start_line":5,"start_character":20,"end_line":5,"end_character":43},"updated":"2023-09-14 17:45:56.000000000","message":"cephfs_ganesha_server_ip","commit_id":"424786a743c0d526c549ea60b5d898d1648517d8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f88e62c6ec6a477eb4330196cb4b597e33ebd31","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    It is now possible to configure `cephfs_ganesha_export_ips` (or"},{"line_number":5,"context_line":"    alternatively, `cephs_ganesha_server_ip`) alongside `ceph_nfs_cluster_id`."},{"line_number":6,"context_line":"    Setting these options will allow the CephFS driver to report additional"},{"line_number":7,"context_line":"    export paths. These additional export paths will have the \"preferred\""},{"line_number":8,"context_line":"    metadata key set to False. The export paths pertaining to the NFS service"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"28554976_e74713c9","line":5,"range":{"start_line":5,"start_character":57,"end_line":5,"end_character":76},"updated":"2023-09-14 17:45:56.000000000","message":"cephfs_nfs_cluster_id","commit_id":"424786a743c0d526c549ea60b5d898d1648517d8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8e149816d20635f597c396b3eacc9086f452bc9c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    It is now possible to configure `cephfs_ganesha_export_ips` (or"},{"line_number":5,"context_line":"    alternatively, `cephs_ganesha_server_ip`) alongside `ceph_nfs_cluster_id`."},{"line_number":6,"context_line":"    Setting these options will allow the CephFS driver to report additional"},{"line_number":7,"context_line":"    export paths. These additional export paths will have the \"preferred\""},{"line_number":8,"context_line":"    metadata key set to False. The export paths pertaining to the NFS service"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"702b72bb_d920e308","line":5,"range":{"start_line":5,"start_character":57,"end_line":5,"end_character":76},"in_reply_to":"28554976_e74713c9","updated":"2023-09-14 18:13:42.000000000","message":"Done","commit_id":"424786a743c0d526c549ea60b5d898d1648517d8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8e149816d20635f597c396b3eacc9086f452bc9c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    It is now possible to configure `cephfs_ganesha_export_ips` (or"},{"line_number":5,"context_line":"    alternatively, `cephs_ganesha_server_ip`) alongside `ceph_nfs_cluster_id`."},{"line_number":6,"context_line":"    Setting these options will allow the CephFS driver to report additional"},{"line_number":7,"context_line":"    export paths. These additional export paths will have the \"preferred\""},{"line_number":8,"context_line":"    metadata key set to False. The export paths pertaining to the NFS service"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"13b318b0_73415b80","line":5,"range":{"start_line":5,"start_character":20,"end_line":5,"end_character":43},"in_reply_to":"66ed8e2f_81dd8c17","updated":"2023-09-14 18:13:42.000000000","message":"Done","commit_id":"424786a743c0d526c549ea60b5d898d1648517d8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f88e62c6ec6a477eb4330196cb4b597e33ebd31","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    In order to assist the user experience when migrating from a standalone"},{"line_number":21,"context_line":"    CephFS NFS (NFS-Ganesha) service to an NFS service created with the"},{"line_number":22,"context_line":"    Ceph Orchestrator, the CephFS driver allows configuring"},{"line_number":23,"context_line":"    `cephfs_ganesha_export_ips` (or alternatively, `cephs_ganesha_server_ip`)"},{"line_number":24,"context_line":"    alongside `ceph_nfs_cluster_id`."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff1e5ccb_be285253","line":23,"range":{"start_line":23,"start_character":52,"end_line":23,"end_character":75},"updated":"2023-09-14 17:45:56.000000000","message":"cephfs_ganesha_server_ip","commit_id":"424786a743c0d526c549ea60b5d898d1648517d8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8e149816d20635f597c396b3eacc9086f452bc9c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    In order to assist the user experience when migrating from a standalone"},{"line_number":21,"context_line":"    CephFS NFS (NFS-Ganesha) service to an NFS service created with the"},{"line_number":22,"context_line":"    Ceph Orchestrator, the CephFS driver allows configuring"},{"line_number":23,"context_line":"    `cephfs_ganesha_export_ips` (or alternatively, `cephs_ganesha_server_ip`)"},{"line_number":24,"context_line":"    alongside `ceph_nfs_cluster_id`."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3e935202_fc6233cc","line":23,"range":{"start_line":23,"start_character":52,"end_line":23,"end_character":75},"in_reply_to":"ff1e5ccb_be285253","updated":"2023-09-14 18:13:42.000000000","message":"Done","commit_id":"424786a743c0d526c549ea60b5d898d1648517d8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8f88e62c6ec6a477eb4330196cb4b597e33ebd31","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    CephFS NFS (NFS-Ganesha) service to an NFS service created with the"},{"line_number":22,"context_line":"    Ceph Orchestrator, the CephFS driver allows configuring"},{"line_number":23,"context_line":"    `cephfs_ganesha_export_ips` (or alternatively, `cephs_ganesha_server_ip`)"},{"line_number":24,"context_line":"    alongside `ceph_nfs_cluster_id`."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c3196296_e8f9ecc3","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":34},"updated":"2023-09-14 17:45:56.000000000","message":"cephfs_nfs_cluster_id","commit_id":"424786a743c0d526c549ea60b5d898d1648517d8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8e149816d20635f597c396b3eacc9086f452bc9c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    CephFS NFS (NFS-Ganesha) service to an NFS service created with the"},{"line_number":22,"context_line":"    Ceph Orchestrator, the CephFS driver allows configuring"},{"line_number":23,"context_line":"    `cephfs_ganesha_export_ips` (or alternatively, `cephs_ganesha_server_ip`)"},{"line_number":24,"context_line":"    alongside `ceph_nfs_cluster_id`."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fd20549_e9a13cf9","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":34},"in_reply_to":"c3196296_e8f9ecc3","updated":"2023-09-14 18:13:42.000000000","message":"Done","commit_id":"424786a743c0d526c549ea60b5d898d1648517d8"}]}