)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"b3721a29c11dce9d2e447a93bd62fdd987ae086a","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Support reapplying rules during ensuring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is an internal change in the share manager\u0027s"},{"line_number":10,"context_line":"\"ensure_driver_resources\" method, and isn\u0027t invoked"},{"line_number":11,"context_line":"by any code path yet. The idea is to allow drivers"},{"line_number":12,"context_line":"to opt into running \"update_access\" on shares that"},{"line_number":13,"context_line":"they are ensuring."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"30410099_fc5b5965","line":11,"range":{"start_line":10,"start_character":37,"end_line":11,"end_character":21},"updated":"2023-08-31 13:45:45.000000000","message":"How did you test it ? Could you add this flow for dummy driver so we can test it avoing future bugs here ?","commit_id":"5367b57c85d9034452867947161b54a1e57d4d63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"76a9848209f308f2c73026ae8142c963a67f365e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support reapplying rules during ensuring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is an internal change in the share manager\u0027s"},{"line_number":10,"context_line":"\"ensure_driver_resources\" method, and isn\u0027t invoked"},{"line_number":11,"context_line":"by any code path yet. The idea is to allow drivers"},{"line_number":12,"context_line":"to opt into running \"update_access\" on shares that"},{"line_number":13,"context_line":"they are ensuring."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"115c3e46_57b441ce","line":11,"range":{"start_line":10,"start_character":37,"end_line":11,"end_character":21},"in_reply_to":"30410099_fc5b5965","updated":"2023-09-08 16:25:34.000000000","message":"Hmmm, this one is tricky. The dummy driver currently implements \"ensure_share\". \n\nSince this change applies to \"ensure_shares\" alone, we\u0027d need to implement \"ensure_shares\" with the dummy driver.... since these methods are mutually exclusive, we\u0027d lose testing for \"ensure_share\"... \n\nthis code path is being tested with the cephfs driver changes that depend on this patch. maybe we can weigh the benefit of introducing \"ensure_shares\" with the dummy driver together at a team meeting and decide what to do.","commit_id":"5367b57c85d9034452867947161b54a1e57d4d63"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"af25a8dcc28eda477219332590be728fbc026059","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4daae01f_7c154f0d","updated":"2023-04-13 15:41:50.000000000","message":"Reference bug: https://review.opendev.org/c/openstack/manila/+/879013","commit_id":"fef1e7bfb5f7e8cb341322b32b1b0370796b6310"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"b3721a29c11dce9d2e447a93bd62fdd987ae086a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d26a6159_2a39f31d","updated":"2023-08-31 13:45:45.000000000","message":"Thank you goutham for this new functionality. I have some questions/points. Please, see them. :)","commit_id":"5367b57c85d9034452867947161b54a1e57d4d63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b4d90cfe6915aa3978e40112064024a5c0fbe732","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"41b9d243_f1c8c8e2","updated":"2023-08-03 23:54:59.000000000","message":"recheck\n\nfailure doesn\u0027t seem related","commit_id":"5367b57c85d9034452867947161b54a1e57d4d63"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"101e6ec8bbbac88e968516f020c81ce8bc94b9f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5479a886_f6c2b3c4","updated":"2023-09-13 21:10:46.000000000","message":"LGTM, thanks Goutham","commit_id":"389a2ea1e5f1e96386128af1a90dbbb9f95811f1"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8391a7b1fdd29372e281ab263b5a130795a6238b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5bde6833_3d89e287","updated":"2023-09-14 19:09:13.000000000","message":"LGTM, thanks Goutham!","commit_id":"389a2ea1e5f1e96386128af1a90dbbb9f95811f1"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"941148232a80916ed3e4eebb1eacd46503fc09ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f736c4e8_f66a8a05","updated":"2023-09-14 19:21:23.000000000","message":"Late to the party, but LGTM","commit_id":"389a2ea1e5f1e96386128af1a90dbbb9f95811f1"}],"manila/share/manager.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"b3721a29c11dce9d2e447a93bd62fdd987ae086a","unresolved":true,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"            share_server \u003d self._get_share_server(ctxt, share_instance)"},{"line_number":496,"context_line":"            driver_has_to_reapply_access_rules \u003d ("},{"line_number":497,"context_line":"                share_instance_update_dict.get(\u0027reapply_access_rules\u0027) is True"},{"line_number":498,"context_line":"            )"},{"line_number":499,"context_line":"            share_instance_has_pending_rules \u003d ("},{"line_number":500,"context_line":"                share_instance[\u0027access_rules_status\u0027] !\u003d"}],"source_content_type":"text/x-python","patch_set":2,"id":"016a8448_f872c68a","line":497,"range":{"start_line":497,"start_character":48,"end_line":497,"end_character":68},"updated":"2023-08-31 13:45:45.000000000","message":"It is a bit like \"magic\". Who is setting it ? How ? Why is it not a const ? Do we have any kind of lite-spec that you are following ? \n\nIf the idea is about \"ensure_share\" from driver\u0027s interface, it should be more clear. I am not sure if that is the idea.\n\nThe \"ensure_share\" documentation is for ensure the \"export_location\". Not for \"reapply_access_rules\". See the driver documentation [1].\n\nIf the idea is chanding it, we should make it clear in the \"ensure_shre\" documentation and also implement it in a dummy driver (maybe, not sure).\n\n[1] https://github.com/openstack/manila/blob/master/manila/share/driver.py#L2831-L2835","commit_id":"5367b57c85d9034452867947161b54a1e57d4d63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"76a9848209f308f2c73026ae8142c963a67f365e","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"            share_server \u003d self._get_share_server(ctxt, share_instance)"},{"line_number":496,"context_line":"            driver_has_to_reapply_access_rules \u003d ("},{"line_number":497,"context_line":"                share_instance_update_dict.get(\u0027reapply_access_rules\u0027) is True"},{"line_number":498,"context_line":"            )"},{"line_number":499,"context_line":"            share_instance_has_pending_rules \u003d ("},{"line_number":500,"context_line":"                share_instance[\u0027access_rules_status\u0027] !\u003d"}],"source_content_type":"text/x-python","patch_set":2,"id":"70cc1f2d_e1687c8c","line":497,"range":{"start_line":497,"start_character":48,"end_line":497,"end_character":68},"in_reply_to":"016a8448_f872c68a","updated":"2023-09-08 16:25:34.000000000","message":"We have two startup routines: \"ensure_share\" and \"ensure_shares\". This code change pertains to \"ensure_shares\".\n\nThere\u0027s a difference between these two methods -\n\n\"ensure_share\" is executed with a single share instance, and the driver can return an updated list of export locations (and no other share updates). This routine is executed on each service startup and cannot be skipped.\n\n\"ensure_shares\" is executed with all share instances belonging to the host. The share manager checks with the driver for a \"backend_info\" snippet... if the backend info has changed, the share manager asks the driver to \"ensure_shares\". The driver can return a list of dicts, where each dict member pertains to a specific share instance. The driver can update \"status\" and \"export_locations\" for each share instance. With this change i\u0027m making it so that \"reapply_access_rules\" can be specified as well. \n\ni don\u0027t think declaring it as a constant is necessary. I\u0027ll add driver documentation.","commit_id":"5367b57c85d9034452867947161b54a1e57d4d63"}]}