)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eb8f7476128c3a7b9ee9e5893e3c3c6c58d4f742","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6d51a739_443467e0","updated":"2023-04-13 15:41:56.000000000","message":"Reference bug: https://review.opendev.org/c/openstack/manila/+/879013","commit_id":"ba735b988068c0535fe2396a5b3952e4f3a04a3e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"b5f32e36c93f9030d94bf82d003e015821c00e08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bd299350_6218ecb2","updated":"2023-08-30 11:52:35.000000000","message":"CI is happy, code looks good!","commit_id":"e53cab526d26193040716608c5d74aaf54dd1358"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"384ebdb51b280bbaf3bff0cbad7b6cb552091cac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4bb8c05c_862eac11","updated":"2023-08-11 03:43:03.000000000","message":"recheck\n\n\nfailure rate of \"manila-tempest-plugin-cephfs-nfs\" is quite high; we haven\u0027t finished repatriating ths job into a multinode job to avoid resource contention issues;","commit_id":"e53cab526d26193040716608c5d74aaf54dd1358"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4f73c9abb19e1b1ab9581f1c72a24c9bf04c328e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4f3bd0f4_fbe18490","updated":"2023-09-13 21:23:42.000000000","message":"LGTM, only have some minor comments regarding code readability, but they are not actually related to this change, and I see you\u0027re following the pattern, so I\u0027m okay if you prefer not to address them :)","commit_id":"ee8af90109cc41d1c22f2e0cd1718f7cfd2fdfe7"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"77c182f9245e3594da126ccf23d38c1a652e2813","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"af791bc5_7008b092","updated":"2023-09-14 18:36:22.000000000","message":"Looks great Goutham! Thanks for working on this. I think it would be useful to add some docs about the salt usage (and how is it expected to be used). Maybe it can be added as a follow up patch?","commit_id":"ee8af90109cc41d1c22f2e0cd1718f7cfd2fdfe7"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"9d5c7f38f31d08b05a2d3fbc0850bacf6abdc111","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f474ca3b_fb683b02","updated":"2023-09-14 19:08:40.000000000","message":"Thanks again!","commit_id":"ee8af90109cc41d1c22f2e0cd1718f7cfd2fdfe7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"50d4efc0ff4c73877162887b5ec5df07f80e29c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8802eb00_1eba7259","in_reply_to":"af791bc5_7008b092","updated":"2023-09-14 19:00:35.000000000","message":"++ I\u0027ll do that as a follow up, Victoria :)","commit_id":"ee8af90109cc41d1c22f2e0cd1718f7cfd2fdfe7"}],"manila/share/drivers/cephfs/driver.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4f73c9abb19e1b1ab9581f1c72a24c9bf04c328e","unresolved":true,"context_lines":[{"line_number":550,"context_line":"    def get_backend_info(self, context):"},{"line_number":551,"context_line":"        return self.protocol_helper.get_backend_info(context)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    def ensure_shares(self, context, shares):"},{"line_number":554,"context_line":"        share_updates \u003d {}"},{"line_number":555,"context_line":"        for share in shares:"},{"line_number":556,"context_line":"            share_updates[share[\u0027id\u0027]] \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"9dbaabf2_fbaa4829","line":553,"range":{"start_line":553,"start_character":37,"end_line":553,"end_character":43},"updated":"2023-09-13 21:23:42.000000000","message":"Must confess this confused me, as we are sending share instances to this method, and we are referring to them as shares 😄","commit_id":"ee8af90109cc41d1c22f2e0cd1718f7cfd2fdfe7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"65c315c3a5ad05667cc3abe9a89704788a7dd1ec","unresolved":false,"context_lines":[{"line_number":550,"context_line":"    def get_backend_info(self, context):"},{"line_number":551,"context_line":"        return self.protocol_helper.get_backend_info(context)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    def ensure_shares(self, context, shares):"},{"line_number":554,"context_line":"        share_updates \u003d {}"},{"line_number":555,"context_line":"        for share in shares:"},{"line_number":556,"context_line":"            share_updates[share[\u0027id\u0027]] \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"12f71a51_f8812e3f","line":553,"range":{"start_line":553,"start_character":37,"end_line":553,"end_character":43},"in_reply_to":"9dbaabf2_fbaa4829","updated":"2023-09-13 23:28:36.000000000","message":"share instances were introduced in the core manila logic to isolate separate physical copies of data.. as far as the drivers are concerned, a share instance is the same thing as a share; so this layer was untouched... the share manager class performs all the logic to allow drivers to pretend share instances are just shares.","commit_id":"ee8af90109cc41d1c22f2e0cd1718f7cfd2fdfe7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4f73c9abb19e1b1ab9581f1c72a24c9bf04c328e","unresolved":true,"context_lines":[{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    def ensure_shares(self, context, shares):"},{"line_number":554,"context_line":"        share_updates \u003d {}"},{"line_number":555,"context_line":"        for share in shares:"},{"line_number":556,"context_line":"            share_updates[share[\u0027id\u0027]] \u003d {"},{"line_number":557,"context_line":"                \u0027reapply_access_rules\u0027:"},{"line_number":558,"context_line":"                    self.protocol_helper.reapply_rules_while_ensuring_shares,"}],"source_content_type":"text/x-python","patch_set":5,"id":"41e585c5_769296e2","line":555,"range":{"start_line":555,"start_character":12,"end_line":555,"end_character":17},"updated":"2023-09-13 21:23:42.000000000","message":"maybe naming this share_instance would make this piece easier to read and assimilate what\u0027s the actual entity we\u0027re dealing with?","commit_id":"ee8af90109cc41d1c22f2e0cd1718f7cfd2fdfe7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8bd228c46461ec9c6b1307a5e696cc41a04c267e","unresolved":false,"context_lines":[{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    def ensure_shares(self, context, shares):"},{"line_number":554,"context_line":"        share_updates \u003d {}"},{"line_number":555,"context_line":"        for share in shares:"},{"line_number":556,"context_line":"            share_updates[share[\u0027id\u0027]] \u003d {"},{"line_number":557,"context_line":"                \u0027reapply_access_rules\u0027:"},{"line_number":558,"context_line":"                    self.protocol_helper.reapply_rules_while_ensuring_shares,"}],"source_content_type":"text/x-python","patch_set":5,"id":"2053ce4c_48d209d7","line":555,"range":{"start_line":555,"start_character":12,"end_line":555,"end_character":17},"in_reply_to":"39e7d544_5f984528","updated":"2023-09-14 17:59:14.000000000","message":"Got it! Thanks","commit_id":"ee8af90109cc41d1c22f2e0cd1718f7cfd2fdfe7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"65c315c3a5ad05667cc3abe9a89704788a7dd1ec","unresolved":false,"context_lines":[{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    def ensure_shares(self, context, shares):"},{"line_number":554,"context_line":"        share_updates \u003d {}"},{"line_number":555,"context_line":"        for share in shares:"},{"line_number":556,"context_line":"            share_updates[share[\u0027id\u0027]] \u003d {"},{"line_number":557,"context_line":"                \u0027reapply_access_rules\u0027:"},{"line_number":558,"context_line":"                    self.protocol_helper.reapply_rules_while_ensuring_shares,"}],"source_content_type":"text/x-python","patch_set":5,"id":"39e7d544_5f984528","line":555,"range":{"start_line":555,"start_character":12,"end_line":555,"end_character":17},"in_reply_to":"41e585c5_769296e2","updated":"2023-09-13 23:28:36.000000000","message":"for a long time we\u0027ve held the view that driver maintainers don\u0027t need to worry about \"instances\".. for all practical purposes, they\u0027re handed a share object. \n\nreplication interfaces have \"replicas\" which the drivers treat as shares too and migration interfaces refer to \"source_share\" and \"destination_share\" objects","commit_id":"ee8af90109cc41d1c22f2e0cd1718f7cfd2fdfe7"}],"releasenotes/notes/bug-2035137-cephfs-support-ensure-shares-b72fe18381af274a.yaml":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"77c182f9245e3594da126ccf23d38c1a652e2813","unresolved":true,"context_lines":[{"line_number":12,"context_line":"upgrade:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    A new configuration option called ``cephfs_ensure_all_shares_salt`` has"},{"line_number":15,"context_line":"    been introduced to assist cloud administrtrators that would like the CephFS"},{"line_number":16,"context_line":"    driver to reconcile export paths of existing shares during service"},{"line_number":17,"context_line":"    startup."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c7135ae9_49890929","line":15,"updated":"2023-09-14 18:36:22.000000000","message":"NIT administrators","commit_id":"ee8af90109cc41d1c22f2e0cd1718f7cfd2fdfe7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"50d4efc0ff4c73877162887b5ec5df07f80e29c6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"upgrade:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    A new configuration option called ``cephfs_ensure_all_shares_salt`` has"},{"line_number":15,"context_line":"    been introduced to assist cloud administrtrators that would like the CephFS"},{"line_number":16,"context_line":"    driver to reconcile export paths of existing shares during service"},{"line_number":17,"context_line":"    startup."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e8608c83_cefc8c02","line":15,"in_reply_to":"c7135ae9_49890929","updated":"2023-09-14 19:00:35.000000000","message":"argh! i\u0027ll fix this up in a separate patch... reno fixes are easy and will not invoke the whole CI","commit_id":"ee8af90109cc41d1c22f2e0cd1718f7cfd2fdfe7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ad5afa052efb4062128dffbd10d6ccc849a09028","unresolved":false,"context_lines":[{"line_number":12,"context_line":"upgrade:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    A new configuration option called ``cephfs_ensure_all_shares_salt`` has"},{"line_number":15,"context_line":"    been introduced to assist cloud administrtrators that would like the CephFS"},{"line_number":16,"context_line":"    driver to reconcile export paths of existing shares during service"},{"line_number":17,"context_line":"    startup."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3dea41de_d2fab560","line":15,"in_reply_to":"e8608c83_cefc8c02","updated":"2023-09-14 19:02:00.000000000","message":"done here: https://review.opendev.org/c/openstack/manila/+/895031","commit_id":"ee8af90109cc41d1c22f2e0cd1718f7cfd2fdfe7"}]}