)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ff53819faa5e8a770adbf82cfd78ef66d05b27ea","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds a new Manila driver to support Dell PowerFlex storage backend."},{"line_number":10,"context_line":"It will include the minimum set of Manila features."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint dell-powerflex-manila-driver"},{"line_number":13,"context_line":"Change-Id: I4dc81bf75135b32f1971ca21eee298bca33441cf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"cf26517f_eb2cbb92","line":11,"updated":"2023-05-22 23:20:34.000000000","message":"New drivers must have a bit of documentation; and docs can accompany the code change since they are maintained in the repo: \n\nhttps://opendev.org/openstack/manila/src/branch/master/doc/source/admin\nhttps://opendev.org/openstack/manila/src/branch/master/doc/source/configuration/shared-file-systems/drivers","commit_id":"c80dd6aad01835e493fe8e42820602c17e987afa"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"7b3bb07cc363e362544de400f992cb77e5705146","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds a new Manila driver to support Dell PowerFlex storage backend."},{"line_number":10,"context_line":"It will include the minimum set of Manila features."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint dell-powerflex-manila-driver"},{"line_number":13,"context_line":"Change-Id: I4dc81bf75135b32f1971ca21eee298bca33441cf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"e81656df_afdf7528","line":11,"in_reply_to":"cf26517f_eb2cbb92","updated":"2023-06-09 11:49:39.000000000","message":"Done","commit_id":"c80dd6aad01835e493fe8e42820602c17e987afa"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"af187a9e8e2427f81aaad2b1cc8cf184efb3e389","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"09b1d2cb_d21ec645","updated":"2023-05-22 23:15:36.000000000","message":"Hi Yian, \n\nThanks for submitting this change; Could you please folks that you\u0027ve copied on the review here? The automated messages that are being generated here may be considered spam. I\u0027d be happy to review this for you; and i\u0027ve added this change in the community\u0027s review focus etherpad: https://etherpad.opendev.org/p/manila-bobcat-review-focus\n\nIf reviewers aren\u0027t paying attention to your change; one way to get their attention would be to chime in on the #openstack-manila channel on OFTC, or attend the weekly community meeting on OFTC [1].\n\n[1] https://wiki.openstack.org/wiki/Manila/Meetings","commit_id":"c80dd6aad01835e493fe8e42820602c17e987afa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ff53819faa5e8a770adbf82cfd78ef66d05b27ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e5bd5365_7977560e","updated":"2023-05-22 23:20:34.000000000","message":"Yion Zong: Is there a CI system that tests this driver?","commit_id":"c80dd6aad01835e493fe8e42820602c17e987afa"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"e17c281330a77bf9e494efd84d2dbe3573590b71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5e75b603_504e2350","updated":"2023-04-26 10:50:39.000000000","message":"recheck manila-tempest-plugin-dummy-dhss  failure","commit_id":"c80dd6aad01835e493fe8e42820602c17e987afa"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"483f6bb637558b2328ac34a5ce9398f25b7304db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0afbc06d_822779ed","updated":"2023-04-26 08:21:57.000000000","message":"recheck manila-tempest-plugin-lvm failure","commit_id":"c80dd6aad01835e493fe8e42820602c17e987afa"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"7b3bb07cc363e362544de400f992cb77e5705146","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"6e725ee5_93e21292","updated":"2023-06-09 11:49:39.000000000","message":"Documentation added, thks.","commit_id":"fe27b86491900aadc46d9d3213eb82f267071e71"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8220e661c5d9062adad8011c877ae0068417f7de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"6a6345d1_e94080ce","updated":"2023-07-19 15:53:11.000000000","message":"Overall looks good, but you need to add the release notes and it should pass on Dell EMC PowerFlex CI.","commit_id":"fe27b86491900aadc46d9d3213eb82f267071e71"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"ff1512ecc1c2165009a82c07ee387b31f55cf337","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"c9016703_ffb93f0d","updated":"2023-06-09 11:54:12.000000000","message":"recheck","commit_id":"fe27b86491900aadc46d9d3213eb82f267071e71"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"c677b4c1a0bc738e0c870df70df8440187f0d71a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"336cde53_cd9e31da","updated":"2023-06-09 11:49:15.000000000","message":"recheck manila-tempest-plugin-lvm failures","commit_id":"fe27b86491900aadc46d9d3213eb82f267071e71"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"d833f0f9bbd0e4278461955afa0248d3ad668597","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"45fabc6c_fc692802","updated":"2023-07-06 03:44:35.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"fe27b86491900aadc46d9d3213eb82f267071e71"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"cc341c291343865813fcf380c3c9a4236221eee7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"58382025_434db6b0","updated":"2023-07-06 03:08:47.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"fe27b86491900aadc46d9d3213eb82f267071e71"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"42a7b2093837b502a163c959299a906cb34794f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"59aa098d_3d83c0be","updated":"2023-07-07 13:44:34.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"fe27b86491900aadc46d9d3213eb82f267071e71"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"ec3d2532037741cc3dde473eed0c170183a4811a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"6bd3d99d_0dd1bcdc","updated":"2023-07-11 05:29:56.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"fe27b86491900aadc46d9d3213eb82f267071e71"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"5676ebe7c82fb87b2fc1a564052a1de2cb9e1ac6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"e959b224_37982e7c","updated":"2023-07-06 03:10:35.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"fe27b86491900aadc46d9d3213eb82f267071e71"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4f15b63627e1c63e22dc3c6f55817259319977da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"4b2cbd2f_543b7b2a","updated":"2023-06-14 14:39:03.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"fe27b86491900aadc46d9d3213eb82f267071e71"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"45acdf8799c13b2730615b935cd94de57a3a0a4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"6c84814b_ec58e43c","updated":"2023-07-17 08:46:28.000000000","message":"recheck","commit_id":"bf1102170c8cd4070bba60d33063127df364ff1f"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"8c39f54e2215e0f41b2a6d0a14736588e850569f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"00c5a811_2418651a","updated":"2023-07-18 09:38:49.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bf1102170c8cd4070bba60d33063127df364ff1f"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"8379934ce9bb0a2eb863912c148fc2b2bf298e96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"046e838a_17d0cd63","updated":"2023-07-17 13:23:33.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bf1102170c8cd4070bba60d33063127df364ff1f"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"4dfd573334e4045dde19527dc045126afe06c5cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"14017dbf_03cc3242","updated":"2023-07-20 08:14:17.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bf1102170c8cd4070bba60d33063127df364ff1f"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"440f9fed3f621c85bbe21a0ba5f4df9d1a6f7994","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"3567907d_31982add","updated":"2023-07-19 03:03:05.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bf1102170c8cd4070bba60d33063127df364ff1f"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"312b4cc945e4a63b1dd3099ed685a67dfb9a90a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"40f0fed5_d3de7bfb","updated":"2023-07-18 09:39:49.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bf1102170c8cd4070bba60d33063127df364ff1f"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"1212d3edf20cb4f652e4510e8a9c7c6a6d6209fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"5ba286a4_bd91476a","updated":"2023-07-18 02:02:57.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bf1102170c8cd4070bba60d33063127df364ff1f"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"e757c36ac3b8154e530a0cfed1ba66a026d8798a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"8a2c473c_1a816853","updated":"2023-07-20 06:38:07.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bf1102170c8cd4070bba60d33063127df364ff1f"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"bcc090aaab5c0b3476cfff39eee1b9fc1e7d01a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"8c17736a_df4fd30d","updated":"2023-07-18 08:25:57.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bf1102170c8cd4070bba60d33063127df364ff1f"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"40fe6aaaa1d8068dc83b21958f950acb401a44f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"975cd61f_381d8d03","updated":"2023-07-18 08:27:47.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bf1102170c8cd4070bba60d33063127df364ff1f"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"bea8ac772f2a81cda1865098ca6d9d317a6987fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"c447e915_87ea747c","updated":"2023-07-18 09:05:25.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bf1102170c8cd4070bba60d33063127df364ff1f"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"3ebb1c8c9d65867af513f9c2323efe8b40f5134a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"eb7c8e9e_c438a580","updated":"2023-07-18 07:50:49.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bf1102170c8cd4070bba60d33063127df364ff1f"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"b9d30b6be3f37e2f639e7e74efb50e9b51c4b9b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"f908ba94_4d1d6782","updated":"2023-07-18 06:47:45.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bf1102170c8cd4070bba60d33063127df364ff1f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b376e2e2f756392ad2a11fb62db9e16ddf24a3be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"b2fcd14e_6f3435bc","updated":"2023-07-20 14:29:03.000000000","message":"Hello, Yian! Thank you for working on this driver. I was trying to check the CI output but the link I\u0027m redirected doesn\u0027t show anything [1]. In order to get this driver merged, it is required to have the CI system reporting and the tests passing. The test results should be available to the community. Could you please take a look?\n\n[1] https://elab-os-logsrv.delllabs.net/27/880527/20/check/DellEMC_PowerFlex_Manila_dhss_false/3879619/DellEMC_PowerFlex_Manila_dhss_false/66","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":30020,"name":"Zhao Xiaodong","email":"tom.zhao@dell.com"},"change_message_id":"b983157fb4a5efbf7546350f175759f989f2c718","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"84469dee_05be2221","updated":"2023-07-21 06:11:47.000000000","message":"Hi Carlos,\nThanks for the review. You are right that the log is not accessible, this is because our log server is inaccessible recently, we are working with our lab team and the security team to trouble shoot what causes the inaccessibility and trying the best to get this resolved, but no firm ETA when this could be resolved yet. Is there another 2nd option availalble for this, e.g., could we upload all the logs to a ftp site so the Community could review first?\nPlease let us know your recommendations. Thanks in adavnce.","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"254092a4bf326808b4f61fc63f62556bf4612817","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"6b42f03f_1e207074","updated":"2023-07-21 03:51:52.000000000","message":"Hi Reviewers,\nThanks for your feedback!\nThe CI link is blocked due to the company security policy. We are working on unblocking it.","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"112924be2a5f5b50f46ef8367234b9feea3c5852","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"bd61e5fe_d48a0870","updated":"2023-07-24 06:07:48.000000000","message":"Hi reviewer, the CI log server is back, could you please check the powerflex ci log again? Thanks.","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b3b9adbc8359ea68999241a9f4e46f836ff7d61a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"5e6ebbdc_955c3cc5","updated":"2023-07-24 22:07:39.000000000","message":"Hi, \n\nI\u0027ve a question:\n\nto understand - https://review.opendev.org/c/openstack/manila/+/885974 is a different driver being added, correct? And you\u0027re looking to get these two drivers into the Bobcat/2023.2 release of OpenStack Manila?","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19eeaf7aae96c4a454b0c13ac8bb343d8b008167","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"96ff32c5_ab89e0f3","updated":"2023-07-21 03:29:30.000000000","message":"Hi, \n\nThanks for your patience with the reviews. In addition to making the CI results viewable by the community, i\u0027d like to remind you to drop the long list of reviewers you\u0027ve added to this patch. Please see some other requests for change inline. Thanks!","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a4a10ea61ea0284bf32381ee16617b007457b435","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"fbad94b6_6bcc2822","in_reply_to":"126dd5e9_987cab56","updated":"2023-07-27 12:42:01.000000000","message":"I believe if you run the steps Goutham mentioned and generate the file, the file would likely be created and uploaded with the other logs. I think it would be really nice to have, but I think the logs output for the driver should suffice for this deadline (https://releases.openstack.org/bobcat/schedule.html#b-manila-new-driver-deadline).","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"befc9ade4925f3e6fec9792e14c27594b0f0851d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"fd9a8cc7_fd9e0a6c","in_reply_to":"5e6ebbdc_955c3cc5","updated":"2023-07-25 02:02:58.000000000","message":"Hi Goutham,\nYes, both PowerFlex Manila driver and PowerStore Manila driver are target at Bobcat release.","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9fae47ed06430c199dcef7701fca3386e20eb97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"facab326_b42677d3","in_reply_to":"6569cd59_39335866","updated":"2023-07-28 05:15:24.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"f97036b8c992f0d07c516a397a5e3c2bb7a13a67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"126dd5e9_987cab56","in_reply_to":"7c0f4c15_c206d0d6","updated":"2023-07-25 04:58:08.000000000","message":"Thank you for your review, since we are not using zuul v3+, it may not be able to meet the HTML requirement in a short time. The manila deadline is approaching, can we use the existing log for review?","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9fae47ed06430c199dcef7701fca3386e20eb97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"9f7ed339_e30991f0","in_reply_to":"84469dee_05be2221","updated":"2023-07-28 05:15:24.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bddae14fd8830cebdef7dd86f1282b0f1fb954ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"eed63cda_b3bd283e","in_reply_to":"93814779_f32cf08a","updated":"2023-08-02 20:21:22.000000000","message":"Thanks for working on it! Will take a look and do a review soon :)","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":30020,"name":"Zhao Xiaodong","email":"tom.zhao@dell.com"},"change_message_id":"b983157fb4a5efbf7546350f175759f989f2c718","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"6569cd59_39335866","in_reply_to":"b2fcd14e_6f3435bc","updated":"2023-07-21 06:11:47.000000000","message":"Hi Carlos, \nThanks for the review. You are right that the log is not accessible, this is because our log server is inaccessible recently, we are working with our lab team and the security team to trouble shoot what causes the inaccessibility and trying the best to get this resolved, but no firm ETA when this could be resolved yet. Is there another 2nd option availalble for this, e.g., could we upload all the logs to a ftp site so the Community could review first? \nPlease let us know your recommendations. Thanks in adavnce.","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2648628b879e5ea819ac7e71e02736029a14f1f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"7c0f4c15_c206d0d6","in_reply_to":"bd61e5fe_d48a0870","updated":"2023-07-24 22:11:20.000000000","message":"Hi, \n\nThank you. I can see the logs now. \nCould you please also have your CI system publish a HTML version of the test results? i.e, add a testr_results.html file to the CI results?\n\nI don\u0027t know what strategy you\u0027re using in the CI, i.e., if you\u0027re using \"Zuul\" CI system, and if you\u0027re deploying it via SoftwareFactory [1], etc. \n\ngenerating a html report with the test results is very easy:\n\n stestr last --subunit \u003e testrepository.subunit\n subunit2html ./testrepository.subunit testr_results.html\n\nThese commands have to be run after the tests have completed. Depending on how you\u0027ve setup your test jobs, maybe there\u0027s an easier way to do this. \n\n[1] https://softwarefactory-project.io/docs/components/zuul.html","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"275a00fcc361827c320bc5e1da1023041281e567","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"93814779_f32cf08a","in_reply_to":"fbad94b6_6bcc2822","updated":"2023-08-02 07:16:43.000000000","message":"Hi Goutham/Carlos, the latest trigger log has included the test result html file, please check it. Thanks.","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a1f48f062b18284240e80ef19e47485c5f799ca4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"e778f6fc_226ee5bb","updated":"2023-08-10 12:10:10.000000000","message":"LGTM","commit_id":"114c772b68c754baf7ecc2aaab6d3f273a03187a"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"71df76d88522e51a3c100af8410587e0551c82a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"a5085c8e_bc2b8a45","updated":"2023-08-09 11:57:12.000000000","message":"Thank you Yian, I have only one question and overall the patch LGTM (Good coverage, DELL CI passing and reporting test_results).","commit_id":"114c772b68c754baf7ecc2aaab6d3f273a03187a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"13beff1a85621fb47b6758559c0ac44405cf6131","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"d0d05f67_32416cc6","updated":"2023-08-09 19:33:42.000000000","message":"This looks good to me for the most part; there\u0027s a minor issue with the use of the \"six\" library. Could you please fix that up? I\u0027d also suggest linking the config guide to the administrator reference. Please take a look\n\nI\u0027m not going to block the merge of this waiting for these changes; we\u0027d like to keep moving.. so if you don\u0027t submit an update to this change, we\u0027ll expect a separate follow up change.\n\n\nThanks for working on your CI system btw. Please keep it running against other changes in the repository going forward. Could you please provide an update to this file: https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI\n\n\nWe\u0027re specifically interested in an email address to reach out to the driver maintainers in case we have an issue, and a launchpad assignee if there are bug reports against the driver.\n\nThanks!","commit_id":"114c772b68c754baf7ecc2aaab6d3f273a03187a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"61c39292201a358dcc37ea9562ba7d0e1e0e38b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"fa59ac6c_8b94e2de","updated":"2023-08-01 04:14:29.000000000","message":"recheck","commit_id":"114c772b68c754baf7ecc2aaab6d3f273a03187a"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"ad30957334a1be535191fe9bcdb232784283ff55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"b455e4f9_6fadc2f6","updated":"2023-08-02 06:03:42.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"114c772b68c754baf7ecc2aaab6d3f273a03187a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"832b757da8f3b248f44682ee14fcb0f8d73049f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"cb45188a_32c7a7fa","updated":"2023-08-14 13:38:14.000000000","message":"recheck","commit_id":"d694a9a4b7d4aab7dc6af8ec66d4ea77376d8088"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"f819c0e2bd20e4056d31f8ca203a16487e7eaa97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"806382b1_ce3d5474","in_reply_to":"351aed51_dd09e751","updated":"2023-08-15 06:11:11.000000000","message":"Good to know. Thanks!","commit_id":"d694a9a4b7d4aab7dc6af8ec66d4ea77376d8088"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d5d0552e4b7d490b95c683f5ab85d150db120575","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"351aed51_dd09e751","in_reply_to":"cb45188a_32c7a7fa","updated":"2023-08-15 02:03:27.000000000","message":"we have an issue with two of the voting jobs right now; it should be resolved with https://review.opendev.org/c/openstack/manila-tempest-plugin/+/891359","commit_id":"d694a9a4b7d4aab7dc6af8ec66d4ea77376d8088"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"2be2fd3cf20e55640c736a79984cc4961f5c01fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"ebaac019_f5c07885","updated":"2023-08-21 16:36:53.000000000","message":"All my comments were addressed. Thank you guys!","commit_id":"f44983e2f7219e7b4f14ebca75f56d8e3b4a2d59"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"85680f7992030dcfadd66c3339acdfb89ff5579f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"2d131915_e930b70a","updated":"2023-08-23 15:02:29.000000000","message":"Good to see the CI fixed; please rebase this patch, and we\u0027ll be able to merge it","commit_id":"f44983e2f7219e7b4f14ebca75f56d8e3b4a2d59"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"94278ab19855f15aec0b79d1e6102ad06fec36b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"f1db4aca_10b6f294","updated":"2023-08-21 14:36:34.000000000","message":"Thank you for working on this change and for the patience while waiting for reviews.\nI left some comments for you inline, but don\u0027t think they are a blocker, so I\u0027m in for merging this change. I recommend you to address the suggested changes in a follow-up patch set, in case other reviewers don\u0027t have something major to point out.","commit_id":"f44983e2f7219e7b4f14ebca75f56d8e3b4a2d59"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"38120483b26c67003aed07c5c502890c3532a4f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"1543a6b1_4cca27f1","updated":"2023-08-21 16:43:42.000000000","message":"Yian, I was taking a look at your CI and it seems to be failing. We had an issue with some other jobs last week, and Goutham proposed a fix for it [1]. We believe this could affect other CI systems as well. Please take a look and apply to your env if you think it\u0027s applicable :)\n\n[1] https://review.opendev.org/c/openstack/manila/+/891641","commit_id":"f44983e2f7219e7b4f14ebca75f56d8e3b4a2d59"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c2bd07a035b72daa3fcae9b32ddf2c2308d2c8c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"60d6773d_ce2671d2","updated":"2023-08-15 17:53:22.000000000","message":"recheck\n\nWe fixed the failing jobs with https://review.opendev.org/c/openstack/manila-tempest-plugin/+/891359\n\n\nCould you please re-run your CI system; it\u0027s failed on the last patch","commit_id":"f44983e2f7219e7b4f14ebca75f56d8e3b4a2d59"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"5ad8809e07c3cbf11fecefc02ecb34ec34fc5065","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"10f31bee_5506e04a","updated":"2023-08-23 03:00:16.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"f44983e2f7219e7b4f14ebca75f56d8e3b4a2d59"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1988ac5c73096c5ec3c727fe2a9dd609c5b5cabc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"7335dc55_d13c7a59","updated":"2023-08-17 15:19:37.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"f44983e2f7219e7b4f14ebca75f56d8e3b4a2d59"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cdee1341d19aa6692b1ebdd6f0c176afae03ec8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"9e426826_f0315f64","updated":"2023-08-23 18:08:31.000000000","message":"LGTM, thanks!","commit_id":"ac8a9a2380c155f61093c61e3b7b21d375fab3d0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dff374b28b9896752dd2610e518f97ad3cf3c686","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"ef659b66_ca968252","updated":"2023-08-23 18:51:25.000000000","message":"LGTM, thanks!","commit_id":"ac8a9a2380c155f61093c61e3b7b21d375fab3d0"}],"doc/source/configuration/shared-file-systems/drivers.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19eeaf7aae96c4a454b0c13ac8bb343d8b008167","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"e8cafb59_c6af3b41","updated":"2023-07-21 03:29:30.000000000","message":"There\u0027s another documentation file to update: https://github.com/openstack/manila/blob/e31be16130a0aad95da7b8a9c4589f41f1f3ac1e/doc/source/admin/share_back_ends_feature_support_mapping.rst\n\nPlease see and update the features supported in that file. Use the alphabet \"B\" to indicate that the specific feature was added during the \"Bobcat\" release cycle","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9fae47ed06430c199dcef7701fca3386e20eb97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"c44a2e64_4e6d1f7c","in_reply_to":"e8cafb59_c6af3b41","updated":"2023-07-28 05:15:24.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"}],"doc/source/configuration/shared-file-systems/drivers/dell-emc-powerflex-driver.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19eeaf7aae96c4a454b0c13ac8bb343d8b008167","unresolved":true,"context_lines":[{"line_number":2,"context_line":"Dell EMC PowerFlex driver"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The EMC Shared File Systems service driver framework (EMCShareDriver)"},{"line_number":6,"context_line":"utilizes the EMC storage products to provide the shared file systems to"},{"line_number":7,"context_line":"OpenStack. The EMC driver is a plug-in based driver which is designed to"},{"line_number":8,"context_line":"use different plug-ins to manage different EMC storage products."}],"source_content_type":"text/x-rst","patch_set":20,"id":"5b919ccc_fe9b41e7","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":7},"updated":"2023-07-21 03:29:30.000000000","message":"here and all other \"EMC\" references, shouldn\u0027t this be \"Dell EMC\"?","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9fae47ed06430c199dcef7701fca3386e20eb97","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Dell EMC PowerFlex driver"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The EMC Shared File Systems service driver framework (EMCShareDriver)"},{"line_number":6,"context_line":"utilizes the EMC storage products to provide the shared file systems to"},{"line_number":7,"context_line":"OpenStack. The EMC driver is a plug-in based driver which is designed to"},{"line_number":8,"context_line":"use different plug-ins to manage different EMC storage products."}],"source_content_type":"text/x-rst","patch_set":20,"id":"345cb1ea_91c319ec","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":7},"in_reply_to":"5b919ccc_fe9b41e7","updated":"2023-07-28 05:15:24.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19eeaf7aae96c4a454b0c13ac8bb343d8b008167","unresolved":true,"context_lines":[{"line_number":135,"context_line":"The following extra specifications need to be configured with share type."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"- snapshot_support \u003d True"},{"line_number":138,"context_line":"- create_share_from_snapshot_support \u003d True"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"For new share type, these extra specifications can be set directly when"},{"line_number":141,"context_line":"creating share type:"}],"source_content_type":"text/x-rst","patch_set":20,"id":"18184636_a3ffce8f","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":43},"updated":"2023-07-21 03:29:30.000000000","message":"The driver doesn\u0027t support this: https://review.opendev.org/c/openstack/manila/+/880527/20/manila/share/drivers/dell_emc/plugins/powerflex/connection.py#354\n\nSo you shouldn\u0027t be needing this..","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9fae47ed06430c199dcef7701fca3386e20eb97","unresolved":false,"context_lines":[{"line_number":135,"context_line":"The following extra specifications need to be configured with share type."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"- snapshot_support \u003d True"},{"line_number":138,"context_line":"- create_share_from_snapshot_support \u003d True"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"For new share type, these extra specifications can be set directly when"},{"line_number":141,"context_line":"creating share type:"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3a26e4f6_e741096f","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":43},"in_reply_to":"18184636_a3ffce8f","updated":"2023-07-28 05:15:24.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19eeaf7aae96c4a454b0c13ac8bb343d8b008167","unresolved":true,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":".. code-block:: console"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    $ openstack share type create --extra_specs snapshot_support\u003dTrue --extra_specs create_share_from_snapshot_support\u003dTrue ${share_type_name} False"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Or you can update already existing share type with command:"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"1675b74a_345f1508","line":145,"range":{"start_line":145,"start_character":70,"end_line":145,"end_character":123},"updated":"2023-07-21 03:29:30.000000000","message":"same comment as above","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9fae47ed06430c199dcef7701fca3386e20eb97","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":".. code-block:: console"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    $ openstack share type create --extra_specs snapshot_support\u003dTrue --extra_specs create_share_from_snapshot_support\u003dTrue ${share_type_name} False"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Or you can update already existing share type with command:"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"57d6e039_466a54a5","line":145,"range":{"start_line":145,"start_character":70,"end_line":145,"end_character":123},"in_reply_to":"1675b74a_345f1508","updated":"2023-07-28 05:15:24.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19eeaf7aae96c4a454b0c13ac8bb343d8b008167","unresolved":true,"context_lines":[{"line_number":149,"context_line":".. code-block:: console"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    $ openstack share type set --extra_specs snapshot_support\u003dTrue ${share_type_name}"},{"line_number":152,"context_line":"    $ openstack share type set --extra_specs create_share_from_snapshot_support\u003dTrue ${share_type_name}"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Known restrictions"}],"source_content_type":"text/x-rst","patch_set":20,"id":"1a11c9db_f868ea12","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":103},"updated":"2023-07-21 03:29:30.000000000","message":"same comment as above","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9fae47ed06430c199dcef7701fca3386e20eb97","unresolved":false,"context_lines":[{"line_number":149,"context_line":".. code-block:: console"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    $ openstack share type set --extra_specs snapshot_support\u003dTrue ${share_type_name}"},{"line_number":152,"context_line":"    $ openstack share type set --extra_specs create_share_from_snapshot_support\u003dTrue ${share_type_name}"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Known restrictions"}],"source_content_type":"text/x-rst","patch_set":20,"id":"94088de6_5c54cfdc","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":103},"in_reply_to":"1a11c9db_f868ea12","updated":"2023-07-28 05:15:24.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"13beff1a85621fb47b6758559c0ac44405cf6131","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"a0554e2a_8887008f","updated":"2023-08-09 19:33:42.000000000","message":"Could you also link this file under this section:\n\n\nhttps://github.com/openstack/manila/blob/master/doc/source/admin/index.rst#supported-share-back-ends","commit_id":"114c772b68c754baf7ecc2aaab6d3f273a03187a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"94278ab19855f15aec0b79d1e6102ad06fec36b8","unresolved":true,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":".. code-block:: console"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    $ openstack share type create --extra_specs snapshot_support\u003dTrue ${share_type_name} False"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Or you can update already existing share type with command:"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-rst","patch_set":24,"id":"e844d2ae_6403ea68","line":144,"range":{"start_line":144,"start_character":70,"end_line":144,"end_character":88},"updated":"2023-08-21 14:36:34.000000000","message":"as you were already creating a share type named powerflex above, wouldn\u0027t be a bad idea to use the share type name that was just created here too.","commit_id":"f44983e2f7219e7b4f14ebca75f56d8e3b4a2d59"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"94278ab19855f15aec0b79d1e6102ad06fec36b8","unresolved":true,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":".. code-block:: console"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    $ openstack share type set --extra_specs snapshot_support\u003dTrue ${share_type_name}"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Known restrictions"}],"source_content_type":"text/x-rst","patch_set":24,"id":"74e4a24a_577ab3ba","line":150,"range":{"start_line":150,"start_character":67,"end_line":150,"end_character":85},"updated":"2023-08-21 14:36:34.000000000","message":"same","commit_id":"f44983e2f7219e7b4f14ebca75f56d8e3b4a2d59"}],"manila/share/drivers/dell_emc/plugins/powerflex/connection.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1010f3c60246ba9e0b160a481118500a71849c22","unresolved":true,"context_lines":[{"line_number":138,"context_line":"                                                    self.certificate_path,"},{"line_number":139,"context_line":"                                                    self.verify_certificate)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def create_share(self, context, share, share_server):"},{"line_number":142,"context_line":"        \"\"\"Is called to create a share.\"\"\""},{"line_number":143,"context_line":"        if share[\u0027share_proto\u0027].upper() \u003d\u003d \u0027NFS\u0027:"},{"line_number":144,"context_line":"            LOG.debug(\u0027Found NFS share protocol, creating NFS share.\u0027)"},{"line_number":145,"context_line":"            location \u003d self._create_nfs_share(share)"},{"line_number":146,"context_line":"        else:"},{"line_number":147,"context_line":"            message \u003d (_(\u0027Unsupported share protocol: %(proto)s.\u0027) %"},{"line_number":148,"context_line":"                       {\u0027proto\u0027: share[\u0027share_proto\u0027]})"},{"line_number":149,"context_line":"            LOG.error(message)"},{"line_number":150,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        return location"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def create_share_from_snapshot(self, context, share, snapshot,"},{"line_number":155,"context_line":"                                   share_server\u003dNone, parent_share\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5e8a1c13_af8f3440","line":152,"range":{"start_line":141,"start_character":0,"end_line":152,"end_character":23},"updated":"2023-05-22 23:24:44.000000000","message":"if the driver only supports the NFS protocol, it looks like you need to implement \"update_share_stats\" to override the \"storage_protocol\": https://opendev.org/openstack/manila/src/commit/b3951d06dd5b0a6770e8b90f26d471ac38504159/manila/share/drivers/dell_emc/driver.py#L284\n\nAlso, the driver will need to report the storage capacity available for manila to make scheduling decisions. The Dell EMC Unity driver could be a good example of what all needs to be queried from your storage system: https://opendev.org/openstack/manila/src/commit/b3951d06dd5b0a6770e8b90f26d471ac38504159/manila/share/drivers/dell_emc/plugins/unity/connection.py#L578-L612","commit_id":"c80dd6aad01835e493fe8e42820602c17e987afa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"683f19f6eb5f4ee51fd0d68c8cfa5746f5f26c88","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                                                    self.certificate_path,"},{"line_number":139,"context_line":"                                                    self.verify_certificate)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def create_share(self, context, share, share_server):"},{"line_number":142,"context_line":"        \"\"\"Is called to create a share.\"\"\""},{"line_number":143,"context_line":"        if share[\u0027share_proto\u0027].upper() \u003d\u003d \u0027NFS\u0027:"},{"line_number":144,"context_line":"            LOG.debug(\u0027Found NFS share protocol, creating NFS share.\u0027)"},{"line_number":145,"context_line":"            location \u003d self._create_nfs_share(share)"},{"line_number":146,"context_line":"        else:"},{"line_number":147,"context_line":"            message \u003d (_(\u0027Unsupported share protocol: %(proto)s.\u0027) %"},{"line_number":148,"context_line":"                       {\u0027proto\u0027: share[\u0027share_proto\u0027]})"},{"line_number":149,"context_line":"            LOG.error(message)"},{"line_number":150,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        return location"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def create_share_from_snapshot(self, context, share, snapshot,"},{"line_number":155,"context_line":"                                   share_server\u003dNone, parent_share\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"6a538e69_67654acb","line":152,"range":{"start_line":141,"start_character":0,"end_line":152,"end_character":23},"in_reply_to":"5e8a1c13_af8f3440","updated":"2023-05-30 06:46:18.000000000","message":"Done","commit_id":"c80dd6aad01835e493fe8e42820602c17e987afa"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8220e661c5d9062adad8011c877ae0068417f7de","unresolved":true,"context_lines":[{"line_number":253,"context_line":"        \"\"\""},{"line_number":254,"context_line":"        size_in_bytes \u003d share[\u0027size\u0027] * units.Gi"},{"line_number":255,"context_line":"        # Minimum size is 3GiB, that is 3221225472 bytes"},{"line_number":256,"context_line":"        if size_in_bytes \u003e\u003d 3221225472:"},{"line_number":257,"context_line":"            LOG.debug(f\u0027Retrieving Storage Pool ID for {self.storage_pool}\u0027)"},{"line_number":258,"context_line":"            storage_pool_id \u003d self.manager.get_storage_pool_id("},{"line_number":259,"context_line":"                self.protection_domain,"}],"source_content_type":"text/x-python","patch_set":18,"id":"6cd16b17_1843e6c5","line":256,"range":{"start_line":256,"start_character":28,"end_line":256,"end_character":38},"updated":"2023-07-19 15:53:11.000000000","message":"Set it as a const of the class for better readability and maintenance:\nMINIMUM_ALLOWED_SIZE \u003d 3221225472 # 3GiB\n\nif size_in_bytes \u003e\u003d self.MINIMUM_ALLOWED_SIZE:","commit_id":"fe27b86491900aadc46d9d3213eb82f267071e71"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"f48a5eef5f248fe8358c313cc1355172edfd8588","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        \"\"\""},{"line_number":254,"context_line":"        size_in_bytes \u003d share[\u0027size\u0027] * units.Gi"},{"line_number":255,"context_line":"        # Minimum size is 3GiB, that is 3221225472 bytes"},{"line_number":256,"context_line":"        if size_in_bytes \u003e\u003d 3221225472:"},{"line_number":257,"context_line":"            LOG.debug(f\u0027Retrieving Storage Pool ID for {self.storage_pool}\u0027)"},{"line_number":258,"context_line":"            storage_pool_id \u003d self.manager.get_storage_pool_id("},{"line_number":259,"context_line":"                self.protection_domain,"}],"source_content_type":"text/x-python","patch_set":18,"id":"6463d384_3cb27136","line":256,"range":{"start_line":256,"start_character":28,"end_line":256,"end_character":38},"in_reply_to":"6cd16b17_1843e6c5","updated":"2023-07-20 11:01:12.000000000","message":"Done","commit_id":"fe27b86491900aadc46d9d3213eb82f267071e71"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19eeaf7aae96c4a454b0c13ac8bb343d8b008167","unresolved":true,"context_lines":[{"line_number":50,"context_line":"               help\u003d\u0027Root directory or NAS server which owns the shares.\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027dell_nas_login\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027User name for the Dell NAS backend.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027dell_nas_password\u0027,"},{"line_number":54,"context_line":"               help\u003d\u0027Password for the Dell NAS backend.\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"286582ef_3f9d31ce","line":54,"range":{"start_line":53,"start_character":4,"end_line":54,"end_character":57},"updated":"2023-07-21 03:29:30.000000000","message":"set \"secret\u003dTrue\" as a parameter for this config opt.","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9fae47ed06430c199dcef7701fca3386e20eb97","unresolved":false,"context_lines":[{"line_number":50,"context_line":"               help\u003d\u0027Root directory or NAS server which owns the shares.\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027dell_nas_login\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027User name for the Dell NAS backend.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027dell_nas_password\u0027,"},{"line_number":54,"context_line":"               help\u003d\u0027Password for the Dell NAS backend.\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"cad415bb_79554d44","line":54,"range":{"start_line":53,"start_character":4,"end_line":54,"end_character":57},"in_reply_to":"286582ef_3f9d31ce","updated":"2023-07-28 05:15:24.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19eeaf7aae96c4a454b0c13ac8bb343d8b008167","unresolved":true,"context_lines":[{"line_number":113,"context_line":"                    self.rest_password]):"},{"line_number":114,"context_line":"            message \u003d _(\"REST server IP, username and password\""},{"line_number":115,"context_line":"                        \" must be specified.\")"},{"line_number":116,"context_line":"            raise exception.InvalidInput(reason\u003dmessage)"},{"line_number":117,"context_line":"        # validate certificate settings"},{"line_number":118,"context_line":"        if self.verify_certificate and not self.certificate_path:"},{"line_number":119,"context_line":"            message \u003d _(\"Path to REST server\u0027s certificate must be specified.\")"}],"source_content_type":"text/x-python","patch_set":20,"id":"38ace154_e8acf0d6","line":116,"range":{"start_line":116,"start_character":28,"end_line":116,"end_character":40},"updated":"2023-07-21 03:29:30.000000000","message":"there\u0027s an exception class that is more appropriate here and on line 120:","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9fae47ed06430c199dcef7701fca3386e20eb97","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    self.rest_password]):"},{"line_number":114,"context_line":"            message \u003d _(\"REST server IP, username and password\""},{"line_number":115,"context_line":"                        \" must be specified.\")"},{"line_number":116,"context_line":"            raise exception.InvalidInput(reason\u003dmessage)"},{"line_number":117,"context_line":"        # validate certificate settings"},{"line_number":118,"context_line":"        if self.verify_certificate and not self.certificate_path:"},{"line_number":119,"context_line":"            message \u003d _(\"Path to REST server\u0027s certificate must be specified.\")"}],"source_content_type":"text/x-python","patch_set":20,"id":"ac82e4cd_053215eb","line":116,"range":{"start_line":116,"start_character":28,"end_line":116,"end_character":40},"in_reply_to":"38ace154_e8acf0d6","updated":"2023-07-28 05:15:24.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19eeaf7aae96c4a454b0c13ac8bb343d8b008167","unresolved":true,"context_lines":[{"line_number":169,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":170,"context_line":"                      delete_rules, share_server\u003dNone):"},{"line_number":171,"context_line":"        \"\"\"Is called to update share access.\"\"\""},{"line_number":172,"context_line":"        if share[\u0027share_proto\u0027].upper() \u003d\u003d \u0027NFS\u0027:"},{"line_number":173,"context_line":"            LOG.debug(\u0027Found NFS share protocol, updating access \\"},{"line_number":174,"context_line":"                      to NFS share.\u0027)"},{"line_number":175,"context_line":"            self._update_nfs_access(share, access_rules)"},{"line_number":176,"context_line":"        else:"},{"line_number":177,"context_line":"            message \u003d (_(\u0027Unsupported share protocol: %(proto)s.\u0027) %"},{"line_number":178,"context_line":"                       {\u0027proto\u0027: share[\u0027share_proto\u0027]})"},{"line_number":179,"context_line":"            LOG.error(message)"},{"line_number":180,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def create_snapshot(self, context, snapshot, share_server):"},{"line_number":183,"context_line":"        \"\"\"Is called to create snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"af0616aa_d597db22","line":180,"range":{"start_line":172,"start_character":8,"end_line":180,"end_character":56},"updated":"2023-07-21 03:29:30.000000000","message":"You don\u0027t need this protocol error handling here. Since the driver advertises \"storage_protocol\" to the Manila scheduler, you\u0027ll never see any other kind of shares being scheduled to this driver. Please remove this error handling, it makes the code hard to follow.","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9fae47ed06430c199dcef7701fca3386e20eb97","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":170,"context_line":"                      delete_rules, share_server\u003dNone):"},{"line_number":171,"context_line":"        \"\"\"Is called to update share access.\"\"\""},{"line_number":172,"context_line":"        if share[\u0027share_proto\u0027].upper() \u003d\u003d \u0027NFS\u0027:"},{"line_number":173,"context_line":"            LOG.debug(\u0027Found NFS share protocol, updating access \\"},{"line_number":174,"context_line":"                      to NFS share.\u0027)"},{"line_number":175,"context_line":"            self._update_nfs_access(share, access_rules)"},{"line_number":176,"context_line":"        else:"},{"line_number":177,"context_line":"            message \u003d (_(\u0027Unsupported share protocol: %(proto)s.\u0027) %"},{"line_number":178,"context_line":"                       {\u0027proto\u0027: share[\u0027share_proto\u0027]})"},{"line_number":179,"context_line":"            LOG.error(message)"},{"line_number":180,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def create_snapshot(self, context, snapshot, share_server):"},{"line_number":183,"context_line":"        \"\"\"Is called to create snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"e818a88d_c5730a43","line":180,"range":{"start_line":172,"start_character":8,"end_line":180,"end_character":56},"in_reply_to":"af0616aa_d597db22","updated":"2023-07-28 05:15:24.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19eeaf7aae96c4a454b0c13ac8bb343d8b008167","unresolved":true,"context_lines":[{"line_number":273,"context_line":"                    {\u0027export\u0027: share[\u0027name\u0027]}}"},{"line_number":274,"context_line":"                LOG.error(message)"},{"line_number":275,"context_line":"                raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":276,"context_line":"            else:"},{"line_number":277,"context_line":"                LOG.debug(f\"Creating export {share[\u0027name\u0027]}\")"},{"line_number":278,"context_line":"                export_id \u003d self.manager.create_nfs_export(filesystem_id,"},{"line_number":279,"context_line":"                                                           share[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":20,"id":"58f43c2a_9f25aa81","line":276,"range":{"start_line":276,"start_character":0,"end_line":276,"end_character":17},"updated":"2023-07-21 03:29:30.000000000","message":"nit: no need for \"else\"","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9fae47ed06430c199dcef7701fca3386e20eb97","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                    {\u0027export\u0027: share[\u0027name\u0027]}}"},{"line_number":274,"context_line":"                LOG.error(message)"},{"line_number":275,"context_line":"                raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":276,"context_line":"            else:"},{"line_number":277,"context_line":"                LOG.debug(f\"Creating export {share[\u0027name\u0027]}\")"},{"line_number":278,"context_line":"                export_id \u003d self.manager.create_nfs_export(filesystem_id,"},{"line_number":279,"context_line":"                                                           share[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":20,"id":"e0c6428a_6edadd43","line":276,"range":{"start_line":276,"start_character":0,"end_line":276,"end_character":17},"in_reply_to":"58f43c2a_9f25aa81","updated":"2023-07-28 05:15:24.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19eeaf7aae96c4a454b0c13ac8bb343d8b008167","unresolved":true,"context_lines":[{"line_number":291,"context_line":"                                                   export_path)"},{"line_number":292,"context_line":"            return locations"},{"line_number":293,"context_line":"        else:"},{"line_number":294,"context_line":"            message \u003d ("},{"line_number":295,"context_line":"                _(\u0027The requested size for \"%(export)s must be\u0027"},{"line_number":296,"context_line":"                  \u0027 bigger than 3GiB.\u0027) %"},{"line_number":297,"context_line":"                {\u0027export\u0027: share[\u0027name\u0027]})"},{"line_number":298,"context_line":"            LOG.error(message)"},{"line_number":299,"context_line":"            raise exception.ShareBackendException(message)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    def _delete_nfs_share(self, share):"},{"line_number":302,"context_line":"        \"\"\"Deletes a filesystem and its associated export.\"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"9eef60a6_ddc349bd","line":299,"range":{"start_line":294,"start_character":0,"end_line":299,"end_character":58},"updated":"2023-07-21 03:29:30.000000000","message":"There is a way to tell the scheduler to disallow scheduling shares under a particular size. It\u0027s using a filter function. \n\nhere\u0027s an example of another Dell driver doing this: \n\nhttps://github.com/openstack/manila/blob/e31be16130a0aad95da7b8a9c4589f41f1f3ac1e/manila/share/drivers/dell_emc/plugins/unity/connection.py#L919-L922\n\nThat driver has a config option to report this; I would recommend you don\u0027t implement a config option, just implement a \"get_default_driver_function\" interface like this:\n\n  \n     def get_default_filter_function(self):\n          return \"share.size \u003e\u003d 3\"\n\n\nWith this, you don\u0027t need to perform any of this error handling in the driver","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9fae47ed06430c199dcef7701fca3386e20eb97","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                                                   export_path)"},{"line_number":292,"context_line":"            return locations"},{"line_number":293,"context_line":"        else:"},{"line_number":294,"context_line":"            message \u003d ("},{"line_number":295,"context_line":"                _(\u0027The requested size for \"%(export)s must be\u0027"},{"line_number":296,"context_line":"                  \u0027 bigger than 3GiB.\u0027) %"},{"line_number":297,"context_line":"                {\u0027export\u0027: share[\u0027name\u0027]})"},{"line_number":298,"context_line":"            LOG.error(message)"},{"line_number":299,"context_line":"            raise exception.ShareBackendException(message)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    def _delete_nfs_share(self, share):"},{"line_number":302,"context_line":"        \"\"\"Deletes a filesystem and its associated export.\"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"90477660_d39ca412","line":299,"range":{"start_line":294,"start_character":0,"end_line":299,"end_character":58},"in_reply_to":"9eef60a6_ddc349bd","updated":"2023-07-28 05:15:24.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19eeaf7aae96c4a454b0c13ac8bb343d8b008167","unresolved":true,"context_lines":[{"line_number":322,"context_line":"        nfs_ro_ips \u003d set()"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        for rule in access_rules:"},{"line_number":325,"context_line":"            if rule[\u0027access_type\u0027].lower() !\u003d \u0027ip\u0027:"},{"line_number":326,"context_line":"                message \u003d (_(\"Only IP access type currently supported for \""},{"line_number":327,"context_line":"                             \"NFS. Share provided %(share)s with rule type \""},{"line_number":328,"context_line":"                             \"%(type)s\") % {\u0027share\u0027: share[\u0027display_name\u0027],"},{"line_number":329,"context_line":"                                            \u0027type\u0027: rule[\u0027access_type\u0027]})"},{"line_number":330,"context_line":"                LOG.error(message)"},{"line_number":331,"context_line":"                raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"            else:"},{"line_number":334,"context_line":"                if rule[\u0027access_level\u0027] \u003d\u003d const.ACCESS_LEVEL_RW:"}],"source_content_type":"text/x-python","patch_set":20,"id":"0d9844ce_bda94cc4","line":331,"range":{"start_line":325,"start_character":12,"end_line":331,"end_character":66},"updated":"2023-07-21 03:29:30.000000000","message":"raising an exception like this will cause the loop to exit and the state of all access rules will be set to \"error\". \n\nInstead, you could just log this and process the next access rule. \nYou can return a list of dictionaries with access rule updates back to the share manager so that only the appropriate rule is set to an \"error\" state. \n\nFor example, here\u0027s how another driver handles this:\n\n https://github.com/openstack/manila/blob/e31be16130a0aad95da7b8a9c4589f41f1f3ac1e/manila/share/drivers/cephfs/driver.py#L934-L975","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9fae47ed06430c199dcef7701fca3386e20eb97","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        nfs_ro_ips \u003d set()"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        for rule in access_rules:"},{"line_number":325,"context_line":"            if rule[\u0027access_type\u0027].lower() !\u003d \u0027ip\u0027:"},{"line_number":326,"context_line":"                message \u003d (_(\"Only IP access type currently supported for \""},{"line_number":327,"context_line":"                             \"NFS. Share provided %(share)s with rule type \""},{"line_number":328,"context_line":"                             \"%(type)s\") % {\u0027share\u0027: share[\u0027display_name\u0027],"},{"line_number":329,"context_line":"                                            \u0027type\u0027: rule[\u0027access_type\u0027]})"},{"line_number":330,"context_line":"                LOG.error(message)"},{"line_number":331,"context_line":"                raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"            else:"},{"line_number":334,"context_line":"                if rule[\u0027access_level\u0027] \u003d\u003d const.ACCESS_LEVEL_RW:"}],"source_content_type":"text/x-python","patch_set":20,"id":"6126ad5e_809b1f0a","line":331,"range":{"start_line":325,"start_character":12,"end_line":331,"end_character":66},"in_reply_to":"0d9844ce_bda94cc4","updated":"2023-07-28 05:15:24.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19eeaf7aae96c4a454b0c13ac8bb343d8b008167","unresolved":true,"context_lines":[{"line_number":350,"context_line":"    def update_share_stats(self, stats_dict):"},{"line_number":351,"context_line":"        \"\"\"Retrieve stats info from share.\"\"\""},{"line_number":352,"context_line":"        stats_dict[\u0027driver_version\u0027] \u003d VERSION"},{"line_number":353,"context_line":"        stats_dict[\u0027storage_protocol\u0027] \u003d \u0027NFS\u0027"},{"line_number":354,"context_line":"        stats_dict[\u0027create_share_from_snapshot_support\u0027] \u003d False"},{"line_number":355,"context_line":"        stats_dict[\u0027pools\u0027] \u003d []"},{"line_number":356,"context_line":"        storage_pool_id \u003d self.manager.get_storage_pool_id("}],"source_content_type":"text/x-python","patch_set":20,"id":"bd4a7862_18820021","line":353,"range":{"start_line":353,"start_character":8,"end_line":353,"end_character":46},"updated":"2023-07-21 03:29:30.000000000","message":"The scheduler will not allow scheduling of shares with unsupported protocols because the driver is reporting this value. So, if you\u0027d like, please cleanup all the protocol checks that you have in the code, like lines 149-153","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9fae47ed06430c199dcef7701fca3386e20eb97","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    def update_share_stats(self, stats_dict):"},{"line_number":351,"context_line":"        \"\"\"Retrieve stats info from share.\"\"\""},{"line_number":352,"context_line":"        stats_dict[\u0027driver_version\u0027] \u003d VERSION"},{"line_number":353,"context_line":"        stats_dict[\u0027storage_protocol\u0027] \u003d \u0027NFS\u0027"},{"line_number":354,"context_line":"        stats_dict[\u0027create_share_from_snapshot_support\u0027] \u003d False"},{"line_number":355,"context_line":"        stats_dict[\u0027pools\u0027] \u003d []"},{"line_number":356,"context_line":"        storage_pool_id \u003d self.manager.get_storage_pool_id("}],"source_content_type":"text/x-python","patch_set":20,"id":"a01a7271_9f81e9f8","line":353,"range":{"start_line":353,"start_character":8,"end_line":353,"end_character":46},"in_reply_to":"bd4a7862_18820021","updated":"2023-07-28 05:15:24.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19eeaf7aae96c4a454b0c13ac8bb343d8b008167","unresolved":true,"context_lines":[{"line_number":351,"context_line":"        \"\"\"Retrieve stats info from share.\"\"\""},{"line_number":352,"context_line":"        stats_dict[\u0027driver_version\u0027] \u003d VERSION"},{"line_number":353,"context_line":"        stats_dict[\u0027storage_protocol\u0027] \u003d \u0027NFS\u0027"},{"line_number":354,"context_line":"        stats_dict[\u0027create_share_from_snapshot_support\u0027] \u003d False"},{"line_number":355,"context_line":"        stats_dict[\u0027pools\u0027] \u003d []"},{"line_number":356,"context_line":"        storage_pool_id \u003d self.manager.get_storage_pool_id("},{"line_number":357,"context_line":"            self.protection_domain,"}],"source_content_type":"text/x-python","patch_set":20,"id":"b8a537d5_b25be99b","line":354,"range":{"start_line":354,"start_character":8,"end_line":354,"end_character":20},"updated":"2023-07-21 03:29:30.000000000","message":"stats_dict[\u0027snapshot_support\u0027] \u003d True","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"6d62bdcc2480bc66825e56b969e17b377e074769","unresolved":true,"context_lines":[{"line_number":351,"context_line":"        \"\"\"Retrieve stats info from share.\"\"\""},{"line_number":352,"context_line":"        stats_dict[\u0027driver_version\u0027] \u003d VERSION"},{"line_number":353,"context_line":"        stats_dict[\u0027storage_protocol\u0027] \u003d \u0027NFS\u0027"},{"line_number":354,"context_line":"        stats_dict[\u0027create_share_from_snapshot_support\u0027] \u003d False"},{"line_number":355,"context_line":"        stats_dict[\u0027pools\u0027] \u003d []"},{"line_number":356,"context_line":"        storage_pool_id \u003d self.manager.get_storage_pool_id("},{"line_number":357,"context_line":"            self.protection_domain,"}],"source_content_type":"text/x-python","patch_set":20,"id":"b9621976_8a73ec41","line":354,"range":{"start_line":354,"start_character":8,"end_line":354,"end_character":20},"in_reply_to":"b8a537d5_b25be99b","updated":"2023-07-28 05:21:57.000000000","message":"Hi Goutham,\n\n\u0027snapshot_support\u0027 is set to True at:\nhttps://review.opendev.org/c/openstack/manila/+/880527/21/manila/share/drivers/dell_emc/driver.py#284","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"b6560f221ababb2418eca95b256d7cb54fc7b75d","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        \"\"\"Retrieve stats info from share.\"\"\""},{"line_number":352,"context_line":"        stats_dict[\u0027driver_version\u0027] \u003d VERSION"},{"line_number":353,"context_line":"        stats_dict[\u0027storage_protocol\u0027] \u003d \u0027NFS\u0027"},{"line_number":354,"context_line":"        stats_dict[\u0027create_share_from_snapshot_support\u0027] \u003d False"},{"line_number":355,"context_line":"        stats_dict[\u0027pools\u0027] \u003d []"},{"line_number":356,"context_line":"        storage_pool_id \u003d self.manager.get_storage_pool_id("},{"line_number":357,"context_line":"            self.protection_domain,"}],"source_content_type":"text/x-python","patch_set":20,"id":"d6daafae_0015869c","line":354,"range":{"start_line":354,"start_character":8,"end_line":354,"end_character":20},"in_reply_to":"b9621976_8a73ec41","updated":"2023-07-28 06:44:07.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19eeaf7aae96c4a454b0c13ac8bb343d8b008167","unresolved":true,"context_lines":[{"line_number":371,"context_line":"            \u0027allocated_capacity_gb\u0027: used,"},{"line_number":372,"context_line":"            \u0027provisioned_capacity_gb\u0027: provisioned,"},{"line_number":373,"context_line":"            \u0027qos\u0027: False,"},{"line_number":374,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":375,"context_line":"            \u0027reserved_snapshot_percentage\u0027: 0,"},{"line_number":376,"context_line":"            \u0027reserved_share_extend_percentage\u0027: 0"},{"line_number":377,"context_line":"        }"},{"line_number":378,"context_line":"        stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"98d5dbe5_6914ff9b","line":376,"range":{"start_line":374,"start_character":12,"end_line":376,"end_character":48},"updated":"2023-07-21 03:29:30.000000000","message":"These have to be administrator configurable; they cannot be hardcoded to zero. Please see code in the other drivers, for example: https://github.com/openstack/manila/blob/e31be16130a0aad95da7b8a9c4589f41f1f3ac1e/manila/share/drivers/dell_emc/plugins/unity/connection.py#L129-L142\nhttps://github.com/openstack/manila/blob/e31be16130a0aad95da7b8a9c4589f41f1f3ac1e/manila/share/drivers/dell_emc/plugins/powermax/connection.py#L595-L607","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9fae47ed06430c199dcef7701fca3386e20eb97","unresolved":false,"context_lines":[{"line_number":371,"context_line":"            \u0027allocated_capacity_gb\u0027: used,"},{"line_number":372,"context_line":"            \u0027provisioned_capacity_gb\u0027: provisioned,"},{"line_number":373,"context_line":"            \u0027qos\u0027: False,"},{"line_number":374,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":375,"context_line":"            \u0027reserved_snapshot_percentage\u0027: 0,"},{"line_number":376,"context_line":"            \u0027reserved_share_extend_percentage\u0027: 0"},{"line_number":377,"context_line":"        }"},{"line_number":378,"context_line":"        stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"7e2b6a0f_0f899cb4","line":376,"range":{"start_line":374,"start_character":12,"end_line":376,"end_character":48},"in_reply_to":"98d5dbe5_6914ff9b","updated":"2023-07-28 05:15:24.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19eeaf7aae96c4a454b0c13ac8bb343d8b008167","unresolved":true,"context_lines":[{"line_number":374,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":375,"context_line":"            \u0027reserved_snapshot_percentage\u0027: 0,"},{"line_number":376,"context_line":"            \u0027reserved_share_extend_percentage\u0027: 0"},{"line_number":377,"context_line":"        }"},{"line_number":378,"context_line":"        stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def _get_nfs_location(self, file_interfaces, export_path):"}],"source_content_type":"text/x-python","patch_set":20,"id":"4007c52c_7bf297c3","line":377,"updated":"2023-07-21 03:29:30.000000000","message":"since the driver supports thin_provisioning, you should also get and report the value of \"max_over_subscription_ratio\" from the configuration","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9fae47ed06430c199dcef7701fca3386e20eb97","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":375,"context_line":"            \u0027reserved_snapshot_percentage\u0027: 0,"},{"line_number":376,"context_line":"            \u0027reserved_share_extend_percentage\u0027: 0"},{"line_number":377,"context_line":"        }"},{"line_number":378,"context_line":"        stats_dict[\u0027pools\u0027].append(pool_stat)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def _get_nfs_location(self, file_interfaces, export_path):"}],"source_content_type":"text/x-python","patch_set":20,"id":"aa2884e9_22431164","line":377,"in_reply_to":"4007c52c_7bf297c3","updated":"2023-07-28 05:15:24.000000000","message":"Done","commit_id":"d38531a09b8a91a2d80a6ea933921ea97588d0fa"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"71df76d88522e51a3c100af8410587e0551c82a0","unresolved":true,"context_lines":[{"line_number":263,"context_line":"            self.storage_pool)"},{"line_number":264,"context_line":"        nas_server_id \u003d self.manager.get_nas_server_id(self.nas_server)"},{"line_number":265,"context_line":"        LOG.debug(f\"Creating filesystem {share[\u0027name\u0027]}\")"},{"line_number":266,"context_line":"        size_in_bytes \u003d share[\u0027size\u0027] * units.Gi"},{"line_number":267,"context_line":"        filesystem_id \u003d self.manager.create_filesystem(storage_pool_id,"},{"line_number":268,"context_line":"                                                       self.nas_server,"},{"line_number":269,"context_line":"                                                       share[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":22,"id":"f1a86b51_830d58b0","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":48},"updated":"2023-08-09 11:57:12.000000000","message":"Would be good to have a condition checking when size is less than 3Gib to avoid unnecessary call? Minimum size is mentioned in \"known restrictions\".\n\nlink: https://review.opendev.org/c/openstack/manila/+/880527/22/doc/source/configuration/shared-file-systems/drivers/dell-emc-powerflex-driver.rst#158","commit_id":"114c772b68c754baf7ecc2aaab6d3f273a03187a"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"2be2fd3cf20e55640c736a79984cc4961f5c01fd","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            self.storage_pool)"},{"line_number":264,"context_line":"        nas_server_id \u003d self.manager.get_nas_server_id(self.nas_server)"},{"line_number":265,"context_line":"        LOG.debug(f\"Creating filesystem {share[\u0027name\u0027]}\")"},{"line_number":266,"context_line":"        size_in_bytes \u003d share[\u0027size\u0027] * units.Gi"},{"line_number":267,"context_line":"        filesystem_id \u003d self.manager.create_filesystem(storage_pool_id,"},{"line_number":268,"context_line":"                                                       self.nas_server,"},{"line_number":269,"context_line":"                                                       share[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":22,"id":"1c02d16c_fbb8c607","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":48},"in_reply_to":"e545981c_9db4a9d3","updated":"2023-08-21 16:36:53.000000000","message":"Ack","commit_id":"114c772b68c754baf7ecc2aaab6d3f273a03187a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1c740791a5fabb18e14108487e5380692624c875","unresolved":true,"context_lines":[{"line_number":263,"context_line":"            self.storage_pool)"},{"line_number":264,"context_line":"        nas_server_id \u003d self.manager.get_nas_server_id(self.nas_server)"},{"line_number":265,"context_line":"        LOG.debug(f\"Creating filesystem {share[\u0027name\u0027]}\")"},{"line_number":266,"context_line":"        size_in_bytes \u003d share[\u0027size\u0027] * units.Gi"},{"line_number":267,"context_line":"        filesystem_id \u003d self.manager.create_filesystem(storage_pool_id,"},{"line_number":268,"context_line":"                                                       self.nas_server,"},{"line_number":269,"context_line":"                                                       share[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":22,"id":"e545981c_9db4a9d3","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":48},"in_reply_to":"f1a86b51_830d58b0","updated":"2023-08-09 15:22:31.000000000","message":"No; not necessary; the driver reports a default filter function on line 389","commit_id":"114c772b68c754baf7ecc2aaab6d3f273a03187a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"94278ab19855f15aec0b79d1e6102ad06fec36b8","unresolved":true,"context_lines":[{"line_number":364,"context_line":"        pool_stat \u003d {"},{"line_number":365,"context_line":"            \u0027pool_name\u0027: self.storage_pool,"},{"line_number":366,"context_line":"            \u0027thin_provisioning\u0027: True,"},{"line_number":367,"context_line":"            \u0027total_capacity_gb\u0027: total,"},{"line_number":368,"context_line":"            \u0027free_capacity_gb\u0027: free,"},{"line_number":369,"context_line":"            \u0027allocated_capacity_gb\u0027: used,"},{"line_number":370,"context_line":"            \u0027provisioned_capacity_gb\u0027: provisioned,"},{"line_number":371,"context_line":"            \u0027qos\u0027: False,"},{"line_number":372,"context_line":"            \u0027reserved_percentage\u0027: self.reserved_percentage,"},{"line_number":373,"context_line":"            \u0027reserved_snapshot_percentage\u0027:"}],"source_content_type":"text/x-python","patch_set":24,"id":"2875bbc0_dbe94182","line":370,"range":{"start_line":367,"start_character":12,"end_line":370,"end_character":51},"updated":"2023-08-21 14:36:34.000000000","message":"this 4 variables completely rely on the existence of the statistic variable. If not, they won\u0027t exist and driver will crash. It would be nice if you could initialize them before, just to ensure this won\u0027t crash","commit_id":"f44983e2f7219e7b4f14ebca75f56d8e3b4a2d59"}],"manila/share/drivers/dell_emc/plugins/powerflex/object_manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"13beff1a85621fb47b6758559c0ac44405cf6131","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"import requests"},{"line_number":18,"context_line":"from six.moves import http_client"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from manila import exception"},{"line_number":21,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":22,"id":"09625a68_799bfe84","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":33},"updated":"2023-08-09 19:33:42.000000000","message":"six is no longer in manila\u0027s test_requirements file;\n\nWe do not support installing manila with python2.x; so please remove and replace with the stdlib import instead\n\n```\nfrom http import client as http_client\n```","commit_id":"114c772b68c754baf7ecc2aaab6d3f273a03187a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c2bd07a035b72daa3fcae9b32ddf2c2308d2c8c1","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"import requests"},{"line_number":18,"context_line":"from six.moves import http_client"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from manila import exception"},{"line_number":21,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":22,"id":"8adc7c3e_282668e1","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":33},"in_reply_to":"09625a68_799bfe84","updated":"2023-08-15 17:53:22.000000000","message":"Done","commit_id":"114c772b68c754baf7ecc2aaab6d3f273a03187a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d5d0552e4b7d490b95c683f5ab85d150db120575","unresolved":true,"context_lines":[{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"import requests"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from http import client as http_client"},{"line_number":20,"context_line":"from manila import exception"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"c559935f_ea4e339f","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":38},"updated":"2023-08-15 02:03:27.000000000","message":"http is part of the std lib, it belongs in the first group above with \"json\"\n\n\"requests\" is a third party library..","commit_id":"d694a9a4b7d4aab7dc6af8ec66d4ea77376d8088"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c2bd07a035b72daa3fcae9b32ddf2c2308d2c8c1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"import requests"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from http import client as http_client"},{"line_number":20,"context_line":"from manila import exception"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"6210f167_01a4a97c","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":38},"in_reply_to":"c559935f_ea4e339f","updated":"2023-08-15 17:53:22.000000000","message":"Done","commit_id":"d694a9a4b7d4aab7dc6af8ec66d4ea77376d8088"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d5d0552e4b7d490b95c683f5ab85d150db120575","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from http import client as http_client"},{"line_number":20,"context_line":"from manila import exception"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"15ae8c04_3e375d55","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":35},"updated":"2023-08-15 02:03:27.000000000","message":"pLease check/follow the import template:\n\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template\n\nthird party libraries should be in a separate group.","commit_id":"d694a9a4b7d4aab7dc6af8ec66d4ea77376d8088"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c2bd07a035b72daa3fcae9b32ddf2c2308d2c8c1","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from http import client as http_client"},{"line_number":20,"context_line":"from manila import exception"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"5b4a701f_08733b8f","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":35},"in_reply_to":"15ae8c04_3e375d55","updated":"2023-08-15 17:53:22.000000000","message":"Done","commit_id":"d694a9a4b7d4aab7dc6af8ec66d4ea77376d8088"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"94278ab19855f15aec0b79d1e6102ad06fec36b8","unresolved":true,"context_lines":[{"line_number":213,"context_line":"        :param filesystem_id: ID of the filesystem to delete"},{"line_number":214,"context_line":"        :return: True if deleted successfully"},{"line_number":215,"context_line":"        \"\"\""},{"line_number":216,"context_line":"        url \u003d self.base_url + \\"},{"line_number":217,"context_line":"            \u0027/v1/file-systems/\u0027 + \\"},{"line_number":218,"context_line":"            filesystem_id"},{"line_number":219,"context_line":"        res \u003d self.execute_powerflex_delete_request(url)"},{"line_number":220,"context_line":"        return res.status_code \u003d\u003d 204"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"081187de_e1aa35d8","line":218,"range":{"start_line":216,"start_character":14,"end_line":218,"end_character":25},"updated":"2023-08-21 14:36:34.000000000","message":"nit: you could use an f string here:\n``url \u003d f\u0027{self.base_url}/v1/file-systems/{filesystem_id}\u0027``","commit_id":"f44983e2f7219e7b4f14ebca75f56d8e3b4a2d59"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"94278ab19855f15aec0b79d1e6102ad06fec36b8","unresolved":true,"context_lines":[{"line_number":229,"context_line":"        params \u003d {"},{"line_number":230,"context_line":"            \"name\": name"},{"line_number":231,"context_line":"            }"},{"line_number":232,"context_line":"        url \u003d self.base_url + \\"},{"line_number":233,"context_line":"            \u0027/v1/file-systems/\u0027 + \\"},{"line_number":234,"context_line":"            filesystem_id + \\"},{"line_number":235,"context_line":"            \u0027/snapshot\u0027"},{"line_number":236,"context_line":"        res, response \u003d self.execute_powerflex_post_request(url, params)"},{"line_number":237,"context_line":"        return res.status_code \u003d\u003d 201"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3bf56c8d_671ac5ce","line":235,"range":{"start_line":232,"start_character":8,"end_line":235,"end_character":23},"updated":"2023-08-21 14:36:34.000000000","message":"same as above, also in the other occurrences below","commit_id":"f44983e2f7219e7b4f14ebca75f56d8e3b4a2d59"}],"manila/tests/share/drivers/dell_emc/plugins/powerflex/test_object_manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"13beff1a85621fb47b6758559c0ac44405cf6131","unresolved":true,"context_lines":[{"line_number":19,"context_line":"import ddt"},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":"import requests_mock"},{"line_number":22,"context_line":"from six.moves import http_client"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from manila import exception"},{"line_number":25,"context_line":"from manila.share.drivers.dell_emc.plugins.powerflex import ("}],"source_content_type":"text/x-python","patch_set":22,"id":"dbed9c44_d05f7239","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":33},"updated":"2023-08-09 19:33:42.000000000","message":"six is no longer in manila\u0027s test_requirements file; \n\nWe do not support installing manila with python2.x; so please remove and replace with the stdlib import instead\n\n```\n\nfrom http import client as http_client\n\n```","commit_id":"114c772b68c754baf7ecc2aaab6d3f273a03187a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c2bd07a035b72daa3fcae9b32ddf2c2308d2c8c1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import ddt"},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":"import requests_mock"},{"line_number":22,"context_line":"from six.moves import http_client"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from manila import exception"},{"line_number":25,"context_line":"from manila.share.drivers.dell_emc.plugins.powerflex import ("}],"source_content_type":"text/x-python","patch_set":22,"id":"f3aa38d1_a004ed2a","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":33},"in_reply_to":"dbed9c44_d05f7239","updated":"2023-08-15 17:53:22.000000000","message":"Done","commit_id":"114c772b68c754baf7ecc2aaab6d3f273a03187a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d5d0552e4b7d490b95c683f5ab85d150db120575","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from pathlib import Path"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import ddt"},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":"import requests_mock"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from http import client as http_client"},{"line_number":24,"context_line":"from manila import exception"},{"line_number":25,"context_line":"from manila.share.drivers.dell_emc.plugins.powerflex import ("},{"line_number":26,"context_line":"    object_manager as manager"}],"source_content_type":"text/x-python","patch_set":23,"id":"2000f725_e8cc66ec","line":23,"range":{"start_line":16,"start_character":0,"end_line":23,"end_character":38},"updated":"2023-08-15 02:03:27.000000000","message":"Please follow the import order template:\n\n\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"d694a9a4b7d4aab7dc6af8ec66d4ea77376d8088"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c2bd07a035b72daa3fcae9b32ddf2c2308d2c8c1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from pathlib import Path"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import ddt"},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":"import requests_mock"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from http import client as http_client"},{"line_number":24,"context_line":"from manila import exception"},{"line_number":25,"context_line":"from manila.share.drivers.dell_emc.plugins.powerflex import ("},{"line_number":26,"context_line":"    object_manager as manager"}],"source_content_type":"text/x-python","patch_set":23,"id":"cc8c0da1_21400246","line":23,"range":{"start_line":16,"start_character":0,"end_line":23,"end_character":38},"in_reply_to":"2000f725_e8cc66ec","updated":"2023-08-15 17:53:22.000000000","message":"Done","commit_id":"d694a9a4b7d4aab7dc6af8ec66d4ea77376d8088"}],"releasenotes/notes/bp-dell-powerflex-manila-driver-2c496483242e555a.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"13beff1a85621fb47b6758559c0ac44405cf6131","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new Manila driver to support Dell PowerFlex storage backend."},{"line_number":5,"context_line":"    It supports the minimum set of Manila features."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"580f4c39_e48fb728","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"updated":"2023-08-09 19:33:42.000000000","message":"Added","commit_id":"114c772b68c754baf7ecc2aaab6d3f273a03187a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c2bd07a035b72daa3fcae9b32ddf2c2308d2c8c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new Manila driver to support Dell PowerFlex storage backend."},{"line_number":5,"context_line":"    It supports the minimum set of Manila features."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"f308bc50_2e0320d0","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"in_reply_to":"580f4c39_e48fb728","updated":"2023-08-15 17:53:22.000000000","message":"Done","commit_id":"114c772b68c754baf7ecc2aaab6d3f273a03187a"}]}