)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35328,"name":"Clifford Emeka","email":"emclidon@gmail.com","username":"emclidon"},"change_message_id":"a2501f50e8e15978d50498f52f8311a2240634fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d4098eae_bdea7aa6","updated":"2023-04-20 07:27:44.000000000","message":"Absolutely, I\u0027ll give it a shot.","commit_id":"804f91cd902df7fffd4c4bb927f6e9fad65310f6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"13c3628a6ecc1d056eeff7eb7d11f4442b7e3b3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4813b965_1b3ba7a6","updated":"2023-04-19 22:54:01.000000000","message":"Hi Clifford, \n\nThe Manila API is micro-versioned.. which means, for API response schema changes like these, you will need to bump the API microversion. \n\nHere\u0027s a document that talks about how API microversions work: https://docs.openstack.org/manila/latest/contributor/api_microversion_dev.html\n\nHere\u0027s Manila\u0027s API microversion history: https://docs.openstack.org/manila/latest/contributor/api_microversion_history.html\n\nHere\u0027s an example of a change that is trying to remove a field: https://review.opendev.org/c/openstack/manila/+/845586 \n\nCan you adapt your change like that? Thanks!","commit_id":"804f91cd902df7fffd4c4bb927f6e9fad65310f6"},{"author":{"_account_id":35328,"name":"Clifford Emeka","email":"emclidon@gmail.com","username":"emclidon"},"change_message_id":"674ca9b3928e7ac065ba67f2f192df3a786178ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"690c5625_c14bf034","in_reply_to":"4813b965_1b3ba7a6","updated":"2023-04-28 10:29:07.000000000","message":"\u003e Hi Clifford, \n\u003e \n\u003e The Manila API is micro-versioned.. which means, for API response schema changes like these, you will need to bump the API microversion. \n\u003e \n\u003e Here\u0027s a document that talks about how API microversions work: https://docs.openstack.org/manila/latest/contributor/api_microversion_dev.html\n\u003e \n\u003e Here\u0027s Manila\u0027s API microversion history: https://docs.openstack.org/manila/latest/contributor/api_microversion_history.html\n\u003e \n\u003e Here\u0027s an example of a change that is trying to remove a field: https://review.opendev.org/c/openstack/manila/+/845586 \n\u003e \n\u003e Can you adapt your change like that? Thanks!\n\nPlease check, I bumped a new version 2.79","commit_id":"804f91cd902df7fffd4c4bb927f6e9fad65310f6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e913e76287445e3833ce7a9ed536e4c1bb14bc9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a0aae9ea_f24b8829","updated":"2023-04-29 00:08:04.000000000","message":"Thanks for the changes, please see comments inline; also, can you please add a release note for this change?","commit_id":"f68da7266a1544e9b1034c9ee352ce8eacbdbfc1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3b69f05ed711f5f719115c033f44f3cc0604a319","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3b0daab6_4817ef82","updated":"2023-07-19 14:34:06.000000000","message":"Could you please fix the pep8 error?","commit_id":"8106850ab1214fe648aeeb4ae32c326ad3ac6930"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9a5bd4a6427c461fd29320992e4d5634b1caf938","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"843f4a48_65a6ff94","updated":"2024-07-17 20:33:29.000000000","message":"LGTM, thanks for the fix","commit_id":"45ef4f0858cc205804cb47d02af4aa0d5be47dcd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0cd1c26d4b9d81f98d6ed0fa25f72fe57d3e7617","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f2e3ff23_ee0b0a0d","updated":"2024-07-17 22:13:36.000000000","message":"Thank you very much Ashley; can you please fix the API ref alongside this?\nWe have \"volume_type\" in the API Ref\u0027s parameters.yaml file [1]. This needs a max_version and its description updated if necessary; and by tradition, we maintain API request/response examples with the latest microversion.. so you can nuke the \"volume_type\" from the response samples [2]. We\u0027ll have to just retain \"volume_type\" in the share types response. but that\u0027s an API change that\u0027s probably okay to not do in the near term. \n\n[1] https://opendev.org/openstack/manila/src/branch/master/api-ref/source/parameters.yaml#L4331-L4338\n[2] https://codesearch.opendev.org/?q\u003dvolume_type\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003dsamples%5C%2Fshare\u0026excludeFiles\u003d\u0026repos\u003dopenstack/manila","commit_id":"45ef4f0858cc205804cb47d02af4aa0d5be47dcd"}],"manila/api/views/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e913e76287445e3833ce7a9ed536e4c1bb14bc9e","unresolved":true,"context_lines":[{"line_number":90,"context_line":"            \u0027export_location\u0027: share.get(\u0027export_location\u0027),"},{"line_number":91,"context_line":"            \u0027metadata\u0027: metadata,"},{"line_number":92,"context_line":"            \u0027share_type\u0027: share_type,"},{"line_number":93,"context_line":"            \u0027volume_type\u0027: share_type,"},{"line_number":94,"context_line":"            \u0027links\u0027: self._get_links(request, share[\u0027id\u0027]),"},{"line_number":95,"context_line":"            \u0027is_public\u0027: share.get(\u0027is_public\u0027),"},{"line_number":96,"context_line":"            \u0027export_locations\u0027: export_locations,"}],"source_content_type":"text/x-python","patch_set":3,"id":"be64c0e4_8b9c7acf","side":"PARENT","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":38},"updated":"2023-04-29 00:08:04.000000000","message":"deleting  it here would be incorrect; the key will be gone from all API microversions..","commit_id":"15b4b39eb5ad6dbc77c430fb8c6500ef22f89bd1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0cd1c26d4b9d81f98d6ed0fa25f72fe57d3e7617","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            \u0027export_location\u0027: share.get(\u0027export_location\u0027),"},{"line_number":91,"context_line":"            \u0027metadata\u0027: metadata,"},{"line_number":92,"context_line":"            \u0027share_type\u0027: share_type,"},{"line_number":93,"context_line":"            \u0027volume_type\u0027: share_type,"},{"line_number":94,"context_line":"            \u0027links\u0027: self._get_links(request, share[\u0027id\u0027]),"},{"line_number":95,"context_line":"            \u0027is_public\u0027: share.get(\u0027is_public\u0027),"},{"line_number":96,"context_line":"            \u0027export_locations\u0027: export_locations,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5122da38_8b23495c","side":"PARENT","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":38},"in_reply_to":"be64c0e4_8b9c7acf","updated":"2024-07-17 22:13:36.000000000","message":"Done","commit_id":"15b4b39eb5ad6dbc77c430fb8c6500ef22f89bd1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e913e76287445e3833ce7a9ed536e4c1bb14bc9e","unresolved":true,"context_lines":[{"line_number":126,"context_line":"            \u0027share_type\u0027: share_type,"},{"line_number":127,"context_line":"        })"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    @common.ViewBuilder.versioned_method(\"2.9\")"},{"line_number":130,"context_line":"    def remove_export_locations(self, context, share_dict, share):"},{"line_number":131,"context_line":"        share_dict.pop(\u0027export_location\u0027)"},{"line_number":132,"context_line":"        share_dict.pop(\u0027export_locations\u0027)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @common.ViewBuilder.versioned_method(\"2.10\")"},{"line_number":135,"context_line":"    def add_access_rules_status_field(self, context, share_dict, share):"}],"source_content_type":"text/x-python","patch_set":3,"id":"c247b792_e76a8f72","line":132,"range":{"start_line":129,"start_character":0,"end_line":132,"end_character":42},"updated":"2023-04-29 00:08:04.000000000","message":"This is how a removal is done at a particular microversion","commit_id":"f68da7266a1544e9b1034c9ee352ce8eacbdbfc1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0cd1c26d4b9d81f98d6ed0fa25f72fe57d3e7617","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            \u0027share_type\u0027: share_type,"},{"line_number":127,"context_line":"        })"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    @common.ViewBuilder.versioned_method(\"2.9\")"},{"line_number":130,"context_line":"    def remove_export_locations(self, context, share_dict, share):"},{"line_number":131,"context_line":"        share_dict.pop(\u0027export_location\u0027)"},{"line_number":132,"context_line":"        share_dict.pop(\u0027export_locations\u0027)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @common.ViewBuilder.versioned_method(\"2.10\")"},{"line_number":135,"context_line":"    def add_access_rules_status_field(self, context, share_dict, share):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7e46dde9_38e122bc","line":132,"range":{"start_line":129,"start_character":0,"end_line":132,"end_character":42},"in_reply_to":"c247b792_e76a8f72","updated":"2024-07-17 22:13:36.000000000","message":"Done","commit_id":"f68da7266a1544e9b1034c9ee352ce8eacbdbfc1"}],"releasenotes/notes/bug-2015325-remove-volume-type-from-share-dict-2271471e8306e760.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0cd1c26d4b9d81f98d6ed0fa25f72fe57d3e7617","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed the `volume_type` from `share_dict` details."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a891c059_0085b51f","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":46},"updated":"2024-07-17 22:13:36.000000000","message":"Please rewrite this with some more detail:\n\n\"\"\"\nIn API version 2.86 and beyond, \"volume_type\" will not appear in the API response body for the following API actions:\n\n- GET /v2/shares/detail\n- GET\n/v2/shares/{share_id}\n- POST /shares\n- POST /shares/manage\n- PUT/v2/shares/{share_id}\n\"\"\"","commit_id":"45ef4f0858cc205804cb47d02af4aa0d5be47dcd"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"eb5e611e560c14d337dd0055ddbbbceade1c9aae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed the `volume_type` from `share_dict` details."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"d5ae66ec_c1a4e498","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":46},"in_reply_to":"a891c059_0085b51f","updated":"2024-12-18 21:09:08.000000000","message":"Done","commit_id":"45ef4f0858cc205804cb47d02af4aa0d5be47dcd"}]}