)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"297b838391d3139d6aeb43498eddc3f227e7bd80","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Netapp: Removes stanza check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Signed-Off-by:"},{"line_number":10,"context_line":"Closes-Bug: #2012742"},{"line_number":11,"context_line":"Change-Id: If07b35727f03328fb2637811e083552bc2b137b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fe9432df_0c371359","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":14},"updated":"2025-05-30 00:11:50.000000000","message":"?\n\n@kinpaa@gmail.com please complete this or remove it..","commit_id":"52aa795ffbcc3c32500e87058db04fa47b6b7908"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"19cbd0ccff7518c3296b17ed314e4d1cf722ab18","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Netapp: Removes stanza check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Signed-Off-by:"},{"line_number":10,"context_line":"Closes-Bug: #2012742"},{"line_number":11,"context_line":"Change-Id: If07b35727f03328fb2637811e083552bc2b137b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5ce47923_350b720f","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":14},"in_reply_to":"fe9432df_0c371359","updated":"2025-05-30 07:43:35.000000000","message":"Done","commit_id":"52aa795ffbcc3c32500e87058db04fa47b6b7908"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c8418ec7129e96161192f816ed5ae33c992a445d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Netapp: Removes stanza check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Signed-Off-by: kpdev"},{"line_number":10,"context_line":"Closes-Bug: #2012742"},{"line_number":11,"context_line":"Change-Id: If07b35727f03328fb2637811e083552bc2b137b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ef47f860_0dff59aa","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":20},"updated":"2025-05-30 18:00:32.000000000","message":"Use: \"git commit -s\" to generate this.. the format is:\n\n\"Signed-off-by: Name \u003cemail\u003e\"","commit_id":"cffb15c12a725d85aee000f8c40978728c7894c5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f8e74867fc3f440be8e9e112d9a29c18235b94ef","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Netapp: Removes stanza check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Signed-Off-by: kpdev"},{"line_number":10,"context_line":"Closes-Bug: #2012742"},{"line_number":11,"context_line":"Change-Id: If07b35727f03328fb2637811e083552bc2b137b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"4de5642f_ce8f926c","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":20},"in_reply_to":"ef47f860_0dff59aa","updated":"2025-05-31 08:35:44.000000000","message":"Done","commit_id":"cffb15c12a725d85aee000f8c40978728c7894c5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"521b0b84614717b891ea20bc4e9599e90b78fdc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a46b4711_cac0f0bd","updated":"2024-12-17 15:13:21.000000000","message":"Hey, Romain! Could you please take a look at Goutham\u0027s and Saravanan\u0027s comments?","commit_id":"af60683c141dd102b405269dd4986123a9f5a383"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9d06fa4866a7267497a9efbb597a24094949cb85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"879762db_93c54560","updated":"2023-05-20 01:07:43.000000000","message":"Thanks for the fix,Romain. I\u0027ve a concern, please check comments inline.. \nI was hoping NetApp driver maintainers can share their views as well.. \n\nIf you\u0027re fixing this up as suggested, could you please add a bugfix release note as well? Here\u0027s how you do that: https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html#how-do-i-add-a-release-note","commit_id":"af60683c141dd102b405269dd4986123a9f5a383"},{"author":{"_account_id":35879,"name":"Romain Dupont","display_name":"rdupontovh","email":"romain.dupont@ovhcloud.com","username":"rdupontovh","status":"dev at OVHcloud"},"change_message_id":"9c0bc936599a98588e05386dbba412ac28155f1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"96b4b96f_a8cf23ec","in_reply_to":"a46b4711_cac0f0bd","updated":"2025-01-31 15:43:52.000000000","message":"Hey,\nVery sorry for not working on this sooner, I\u0027ll take a look at this very soon","commit_id":"af60683c141dd102b405269dd4986123a9f5a383"},{"author":{"_account_id":35879,"name":"Romain Dupont","display_name":"rdupontovh","email":"romain.dupont@ovhcloud.com","username":"rdupontovh","status":"dev at OVHcloud"},"change_message_id":"9c0bc936599a98588e05386dbba412ac28155f1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ad8cc02e_32ad1c32","updated":"2025-01-31 15:43:52.000000000","message":"Added new patchset with your suggestions, sorry for taking that long","commit_id":"220c891caa11f3319140a3b1e4999e635a103ccd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f99479df0920ff9cf1ce5f5ce2b0b3ca8343fa4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"23eef879_88f3e234","updated":"2025-05-28 20:30:16.000000000","message":"LGTM, thanks for the fix. Would be nice if we could get someone from NetApp engineering to also review this change","commit_id":"73108782bd2a5e3c0666c5b71c8667cef25d9f55"},{"author":{"_account_id":35979,"name":"Sylvan Le Deunff","email":"sylvan.le-deunff@ovhcloud.com","username":"sylvanld"},"change_message_id":"16df776dcb3210d5e724f6491fa166107126b511","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"23b5c5f6_2321f4f1","updated":"2025-02-18 15:58:36.000000000","message":"recheck Manila grenade tests where broken","commit_id":"73108782bd2a5e3c0666c5b71c8667cef25d9f55"},{"author":{"_account_id":35979,"name":"Sylvan Le Deunff","email":"sylvan.le-deunff@ovhcloud.com","username":"sylvanld"},"change_message_id":"97b4055e9d234178f2b3c2a8e8348932980cc73a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a8e5923f_28ebc4e3","updated":"2025-02-19 11:15:47.000000000","message":"recheck tempest tests failed at setup","commit_id":"73108782bd2a5e3c0666c5b71c8667cef25d9f55"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"34fbf90f94b2f7080b62ecb79ea0ce28aab96bcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"12bd0429_f937fe1f","updated":"2025-05-30 00:11:12.000000000","message":"recheck\n\ngrenade-skip-level job\u0027s been marked non-voting now","commit_id":"52aa795ffbcc3c32500e87058db04fa47b6b7908"}],"manila/share/drivers/netapp/dataontap/cluster_mode/data_motion.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9d06fa4866a7267497a9efbb597a24094949cb85","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def get_backend_configuration(backend_name):"},{"line_number":45,"context_line":"    config_stanzas \u003d CONF.list_all_sections()"},{"line_number":46,"context_line":"    if backend_name not in config_stanzas:"},{"line_number":47,"context_line":"        msg \u003d _(\"Could not find backend stanza %(backend_name)s in \""},{"line_number":48,"context_line":"                \"configuration which is required for replication or migration \""}],"source_content_type":"text/x-python","patch_set":1,"id":"a8407a44_ee6321dd","side":"PARENT","line":45,"updated":"2023-05-20 01:07:43.000000000","message":"Thanks for the explanation in the bug as to why this needs to be removed [1]. I think however, that we\u0027d still need to fail early if the \n\n[1] https://bugs.launchpad.net/manila/+bug/2012742/comments/6","commit_id":"4682f457dfcbbc98b3a3aaa2d1863ea21de84649"},{"author":{"_account_id":35879,"name":"Romain Dupont","display_name":"rdupontovh","email":"romain.dupont@ovhcloud.com","username":"rdupontovh","status":"dev at OVHcloud"},"change_message_id":"9c0bc936599a98588e05386dbba412ac28155f1d","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def get_backend_configuration(backend_name):"},{"line_number":45,"context_line":"    config_stanzas \u003d CONF.list_all_sections()"},{"line_number":46,"context_line":"    if backend_name not in config_stanzas:"},{"line_number":47,"context_line":"        msg \u003d _(\"Could not find backend stanza %(backend_name)s in \""},{"line_number":48,"context_line":"                \"configuration which is required for replication or migration \""}],"source_content_type":"text/x-python","patch_set":1,"id":"8c72226d_9073c391","side":"PARENT","line":45,"in_reply_to":"a8407a44_ee6321dd","updated":"2025-01-31 15:43:52.000000000","message":"Acknowledged","commit_id":"4682f457dfcbbc98b3a3aaa2d1863ea21de84649"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9d06fa4866a7267497a9efbb597a24094949cb85","unresolved":true,"context_lines":[{"line_number":44,"context_line":"def get_backend_configuration(backend_name):"},{"line_number":45,"context_line":"    config \u003d configuration.Configuration(driver.share_opts,"},{"line_number":46,"context_line":"                                         config_group\u003dbackend_name)"},{"line_number":47,"context_line":"    if config.driver_handles_share_servers:"},{"line_number":48,"context_line":"        # NOTE(dviroel): avoid using a pre-create vserver on DHSS \u003d\u003d True mode"},{"line_number":49,"context_line":"        # when retrieving remote backend configuration."},{"line_number":50,"context_line":"        config.netapp_vserver \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"2299f33c_5170599f","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":43},"updated":"2023-05-20 01:07:43.000000000","message":"If a config section doesn\u0027t exist as the NetApp driver expects, we could be failing later in the code, which would be bad because i don\u0027t see any of the code references handling errors from this besides the BadConfigurationException.. \n\nI think we can add a check against this parameter here; \"driver_handles_share_servers\" is a mandatory configuration option that needs to be a boolean [1].. if it is null, we can assume that the config section doesn\u0027t exist... \n\nDo you agree?\nIf yes, I think this check can replace the config stanza check that you\u0027re removing.. \n\n\n[1] https://opendev.org/openstack/manila/src/commit/b3951d06dd5b0a6770e8b90f26d471ac38504159/manila/share/driver.py#L305","commit_id":"af60683c141dd102b405269dd4986123a9f5a383"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"61ad1f2c244300bf6aed433a0c8bbb6d7e4dbd38","unresolved":true,"context_lines":[{"line_number":44,"context_line":"def get_backend_configuration(backend_name):"},{"line_number":45,"context_line":"    config \u003d configuration.Configuration(driver.share_opts,"},{"line_number":46,"context_line":"                                         config_group\u003dbackend_name)"},{"line_number":47,"context_line":"    if config.driver_handles_share_servers:"},{"line_number":48,"context_line":"        # NOTE(dviroel): avoid using a pre-create vserver on DHSS \u003d\u003d True mode"},{"line_number":49,"context_line":"        # when retrieving remote backend configuration."},{"line_number":50,"context_line":"        config.netapp_vserver \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"2f27ea59_8204f44d","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":43},"in_reply_to":"2299f33c_5170599f","updated":"2023-08-31 15:47:45.000000000","message":"Yes, I agree. We can check this var \"driver_handles_share_servers\" for null. If it is null, we can print debug messages, and move on without raising exception.\n\nAlso, we need to check later, at driver side if oslo.config sufficiently provides backend details. We need to fail there with proper information rather than leaving it to fail with random error.","commit_id":"af60683c141dd102b405269dd4986123a9f5a383"},{"author":{"_account_id":35879,"name":"Romain Dupont","display_name":"rdupontovh","email":"romain.dupont@ovhcloud.com","username":"rdupontovh","status":"dev at OVHcloud"},"change_message_id":"9c0bc936599a98588e05386dbba412ac28155f1d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"def get_backend_configuration(backend_name):"},{"line_number":45,"context_line":"    config \u003d configuration.Configuration(driver.share_opts,"},{"line_number":46,"context_line":"                                         config_group\u003dbackend_name)"},{"line_number":47,"context_line":"    if config.driver_handles_share_servers:"},{"line_number":48,"context_line":"        # NOTE(dviroel): avoid using a pre-create vserver on DHSS \u003d\u003d True mode"},{"line_number":49,"context_line":"        # when retrieving remote backend configuration."},{"line_number":50,"context_line":"        config.netapp_vserver \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"4b223dde_2f99fde7","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":43},"in_reply_to":"2299f33c_5170599f","updated":"2025-01-31 15:43:52.000000000","message":"i had this check in mind when first trying to remove this so yes i can go with that, i just found it a bit weird to test that particular setting but we can rely on the fact that it will always be mandatory","commit_id":"af60683c141dd102b405269dd4986123a9f5a383"}]}