)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"8b8c4fa6884d3cfa484e6cc53e5800c01ae29d02","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b0c78ffb_ec064b3e","updated":"2023-06-28 21:09:42.000000000","message":"Hi Helena, thanks for the patch. Some comments inline.","commit_id":"7889f4147a8208b92b7cac8bd44cab992ab8d87b"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"fc18ce0d16707a923dc5a90074c6d64079d805f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"986e0a70_08af3f25","in_reply_to":"b0c78ffb_ec064b3e","updated":"2023-09-18 12:25:11.000000000","message":"Done","commit_id":"7889f4147a8208b92b7cac8bd44cab992ab8d87b"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"c7ceae709a19f471a032307e06aa380cc697cba5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5bd565b0_ba2cc9b7","updated":"2023-09-15 11:41:20.000000000","message":"Thank you Thiago for the review.","commit_id":"19cc7dd69f8402ba6e10c0455c1d2fff3342959b"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"3dd177191899ecac05200af0a5d945cd820834a1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6a5b33a9_b38044e5","updated":"2023-09-15 12:51:57.000000000","message":"I realize now, but the release note name needs to be updated.","commit_id":"c8e37f74cd16fe96d4dbcf78d7f14d0cf31b8569"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"ef9ead00b4e262935d7d2ede98a3d8a8a5a7cb9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4eab02c3_4e11a084","in_reply_to":"6a5b33a9_b38044e5","updated":"2023-09-18 11:57:14.000000000","message":"Thank you Thiago.","commit_id":"c8e37f74cd16fe96d4dbcf78d7f14d0cf31b8569"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"74ead75e7759517155748d6a96aa58b160749804","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f4120018_08a3d105","updated":"2023-09-18 14:18:09.000000000","message":"Thanks for the fix - One suggestion for the release note","commit_id":"ac23ff9d66141c5a469e31e8e7336fbfe9bbbc19"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"fc18ce0d16707a923dc5a90074c6d64079d805f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"29c5e33b_8e83719b","updated":"2023-09-18 12:25:11.000000000","message":"Thanks for the updates, Caique.","commit_id":"ac23ff9d66141c5a469e31e8e7336fbfe9bbbc19"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"681e12240d5100ae707fd3fc74b6cbe17c30c22d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"74ade22c_bf563d03","updated":"2023-09-22 16:18:31.000000000","message":"Hi Caique, thank you for updating this patch.. some comments inline..","commit_id":"b6a6aaa8e64b31f6895f9b584854ca5d2356adca"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8bc949b98772f12925abf9ad92b1230d8eca5352","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"20880184_f98c64e0","updated":"2023-09-20 14:49:29.000000000","message":"LGTM","commit_id":"b6a6aaa8e64b31f6895f9b584854ca5d2356adca"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8838e5876da5022f1a76bbc6454b2aa7ccc07574","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"46c433e9_63e43959","updated":"2023-09-19 14:11:44.000000000","message":"LGTM, thanks Caique!","commit_id":"b6a6aaa8e64b31f6895f9b584854ca5d2356adca"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"28a82fd2798f3c07c5779fab82e62bdc46935ec3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b09a24c9_d05d2b6c","updated":"2023-09-20 19:15:40.000000000","message":"Looks good to me.","commit_id":"b6a6aaa8e64b31f6895f9b584854ca5d2356adca"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"d2e550b856737196b68a2bfe13ff42d0a1308bcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"74b52282_e50eb827","updated":"2023-09-18 17:56:05.000000000","message":"Thank you for the review carloss!","commit_id":"b6a6aaa8e64b31f6895f9b584854ca5d2356adca"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"391173f1950dd6d4cace857ff85e7913eb6b6fdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"628e7345_27aefd83","updated":"2023-09-18 21:37:12.000000000","message":"recheck unrelated error in manila-tempest-plugin-dummy-dhss","commit_id":"b6a6aaa8e64b31f6895f9b584854ca5d2356adca"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"394d18ae9a40addaca928dd87f0301a5195328b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1d8c62ce_6b068329","updated":"2023-09-28 20:14:11.000000000","message":"Caique/Thiago/NetApp folks: This feels like something that could be backported to older stable branches... could you please propose these backports if you agree?","commit_id":"81126d97e38cf7fb3bfcf4a7c2fd38b6a2da622b"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"397f2ad4645a52ec56a62526fe90043203ae35f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f81c83f3_11ac49b5","updated":"2023-09-25 17:36:53.000000000","message":"Keeping my previous vote.","commit_id":"81126d97e38cf7fb3bfcf4a7c2fd38b6a2da622b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0adf6b99ddaea31764db34645339e67437728496","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4efaa96c_8241c3f8","updated":"2023-09-28 12:12:19.000000000","message":"LGTM, thanks Caique!","commit_id":"81126d97e38cf7fb3bfcf4a7c2fd38b6a2da622b"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"0512a1ed5fe398d27423b912cf7cc92f9f3b92ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8421ef55_31263b11","updated":"2023-09-25 12:49:05.000000000","message":"Thank you Goutham and Saravanan. The comments were addressed.","commit_id":"81126d97e38cf7fb3bfcf4a7c2fd38b6a2da622b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9ae8ac9a27c2f16d4e8f8a3a1a5ad2c0b9467d89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3385b0c5_5773626f","updated":"2023-09-25 19:02:57.000000000","message":"run-NetApp CI","commit_id":"81126d97e38cf7fb3bfcf4a7c2fd38b6a2da622b"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"681e12240d5100ae707fd3fc74b6cbe17c30c22d","unresolved":true,"context_lines":[{"line_number":1839,"context_line":"            LOG.debug(\"Trying to setup CIFS server with data: %s\", api_args)"},{"line_number":1840,"context_line":"            self.send_request(\u0027cifs-server-create\u0027, api_args)"},{"line_number":1841,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":1842,"context_line":"            credential_msg \u003d \"FAILURE: Could not authenticate as\""},{"line_number":1843,"context_line":"            privilege_msg \u003d \"The user has insufficient access\""},{"line_number":1844,"context_line":"            if (e.code \u003d\u003d netapp_api.EAPIERROR and ("},{"line_number":1845,"context_line":"                    credential_msg in e.message or"},{"line_number":1846,"context_line":"                    privilege_msg in e.message)):"}],"source_content_type":"text/x-python","patch_set":6,"id":"32bf5306_79d787c3","line":1843,"range":{"start_line":1842,"start_character":11,"end_line":1843,"end_character":62},"updated":"2023-09-22 16:18:31.000000000","message":"please convert to lowercase","commit_id":"b6a6aaa8e64b31f6895f9b584854ca5d2356adca"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"0512a1ed5fe398d27423b912cf7cc92f9f3b92ad","unresolved":false,"context_lines":[{"line_number":1839,"context_line":"            LOG.debug(\"Trying to setup CIFS server with data: %s\", api_args)"},{"line_number":1840,"context_line":"            self.send_request(\u0027cifs-server-create\u0027, api_args)"},{"line_number":1841,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":1842,"context_line":"            credential_msg \u003d \"FAILURE: Could not authenticate as\""},{"line_number":1843,"context_line":"            privilege_msg \u003d \"The user has insufficient access\""},{"line_number":1844,"context_line":"            if (e.code \u003d\u003d netapp_api.EAPIERROR and ("},{"line_number":1845,"context_line":"                    credential_msg in e.message or"},{"line_number":1846,"context_line":"                    privilege_msg in e.message)):"}],"source_content_type":"text/x-python","patch_set":6,"id":"65747715_749a4306","line":1843,"range":{"start_line":1842,"start_character":11,"end_line":1843,"end_character":62},"in_reply_to":"32bf5306_79d787c3","updated":"2023-09-25 12:49:05.000000000","message":"Done","commit_id":"b6a6aaa8e64b31f6895f9b584854ca5d2356adca"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"681e12240d5100ae707fd3fc74b6cbe17c30c22d","unresolved":true,"context_lines":[{"line_number":1842,"context_line":"            credential_msg \u003d \"FAILURE: Could not authenticate as\""},{"line_number":1843,"context_line":"            privilege_msg \u003d \"The user has insufficient access\""},{"line_number":1844,"context_line":"            if (e.code \u003d\u003d netapp_api.EAPIERROR and ("},{"line_number":1845,"context_line":"                    credential_msg in e.message or"},{"line_number":1846,"context_line":"                    privilege_msg in e.message)):"},{"line_number":1847,"context_line":"                auth_msg \u003d _(\"Failed to create CIFS server entry.\""},{"line_number":1848,"context_line":"                             \"Please double check you user credentials\""},{"line_number":1849,"context_line":"                             \"or privileges. %s\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"1963b737_6562cd05","line":1846,"range":{"start_line":1845,"start_character":20,"end_line":1846,"end_character":46},"updated":"2023-09-22 16:18:31.000000000","message":"convert e.message to lowercase as well.. \n\nmatching strings in error responses is a dicey thing; it\u0027s possible the error message is changed on the server and we\u0027d be doing the wrong thing.. \n\nAre we sure there\u0027s no specific error code for this failure on ONTAP?\n\nIf not, there\u0027s not much we can do.. perhaps we could the patterns be shortened to:\n \"could not authenticate\"\n \"insufficient access\"\n \nand hope that trivial message changes don\u0027t affect those critical portions of the error..","commit_id":"b6a6aaa8e64b31f6895f9b584854ca5d2356adca"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"0512a1ed5fe398d27423b912cf7cc92f9f3b92ad","unresolved":false,"context_lines":[{"line_number":1842,"context_line":"            credential_msg \u003d \"FAILURE: Could not authenticate as\""},{"line_number":1843,"context_line":"            privilege_msg \u003d \"The user has insufficient access\""},{"line_number":1844,"context_line":"            if (e.code \u003d\u003d netapp_api.EAPIERROR and ("},{"line_number":1845,"context_line":"                    credential_msg in e.message or"},{"line_number":1846,"context_line":"                    privilege_msg in e.message)):"},{"line_number":1847,"context_line":"                auth_msg \u003d _(\"Failed to create CIFS server entry.\""},{"line_number":1848,"context_line":"                             \"Please double check you user credentials\""},{"line_number":1849,"context_line":"                             \"or privileges. %s\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"f2e9cbd0_99f7f4f7","line":1846,"range":{"start_line":1845,"start_character":20,"end_line":1846,"end_character":46},"in_reply_to":"1963b737_6562cd05","updated":"2023-09-25 12:49:05.000000000","message":"convert e.message to lowercase - Done.\nI think we don\u0027t have specific errors for those scenarios.\nI Agreed with the shortened patterns -Done.","commit_id":"b6a6aaa8e64b31f6895f9b584854ca5d2356adca"},{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"32d7d61e862777c8d5ceab9bd1f249074fc0c494","unresolved":true,"context_lines":[{"line_number":1845,"context_line":"                    credential_msg in e.message or"},{"line_number":1846,"context_line":"                    privilege_msg in e.message)):"},{"line_number":1847,"context_line":"                auth_msg \u003d _(\"Failed to create CIFS server entry.\""},{"line_number":1848,"context_line":"                             \"Please double check you user credentials\""},{"line_number":1849,"context_line":"                             \"or privileges. %s\")"},{"line_number":1850,"context_line":"                raise exception.SecurityServiceFailedAuth(auth_msg % e.message)"},{"line_number":1851,"context_line":"            msg \u003d _(\"Failed to create CIFS server entry. %s\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"15caff13_da120a39","line":1848,"updated":"2023-09-20 19:17:04.000000000","message":"NIT: Typo check: Please double check your*","commit_id":"b6a6aaa8e64b31f6895f9b584854ca5d2356adca"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"681e12240d5100ae707fd3fc74b6cbe17c30c22d","unresolved":true,"context_lines":[{"line_number":1845,"context_line":"                    credential_msg in e.message or"},{"line_number":1846,"context_line":"                    privilege_msg in e.message)):"},{"line_number":1847,"context_line":"                auth_msg \u003d _(\"Failed to create CIFS server entry.\""},{"line_number":1848,"context_line":"                             \"Please double check you user credentials\""},{"line_number":1849,"context_line":"                             \"or privileges. %s\")"},{"line_number":1850,"context_line":"                raise exception.SecurityServiceFailedAuth(auth_msg % e.message)"},{"line_number":1851,"context_line":"            msg \u003d _(\"Failed to create CIFS server entry. %s\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"ee8f5e03_ed2bbf0e","line":1848,"range":{"start_line":1848,"start_character":70,"end_line":1848,"end_character":71},"updated":"2023-09-22 16:18:31.000000000","message":"and add a trailing space at the end of this line, and above","commit_id":"b6a6aaa8e64b31f6895f9b584854ca5d2356adca"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"0512a1ed5fe398d27423b912cf7cc92f9f3b92ad","unresolved":false,"context_lines":[{"line_number":1845,"context_line":"                    credential_msg in e.message or"},{"line_number":1846,"context_line":"                    privilege_msg in e.message)):"},{"line_number":1847,"context_line":"                auth_msg \u003d _(\"Failed to create CIFS server entry.\""},{"line_number":1848,"context_line":"                             \"Please double check you user credentials\""},{"line_number":1849,"context_line":"                             \"or privileges. %s\")"},{"line_number":1850,"context_line":"                raise exception.SecurityServiceFailedAuth(auth_msg % e.message)"},{"line_number":1851,"context_line":"            msg \u003d _(\"Failed to create CIFS server entry. %s\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"677c0ec5_5f86a280","line":1848,"in_reply_to":"15caff13_da120a39","updated":"2023-09-25 12:49:05.000000000","message":"Done","commit_id":"b6a6aaa8e64b31f6895f9b584854ca5d2356adca"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"0512a1ed5fe398d27423b912cf7cc92f9f3b92ad","unresolved":false,"context_lines":[{"line_number":1845,"context_line":"                    credential_msg in e.message or"},{"line_number":1846,"context_line":"                    privilege_msg in e.message)):"},{"line_number":1847,"context_line":"                auth_msg \u003d _(\"Failed to create CIFS server entry.\""},{"line_number":1848,"context_line":"                             \"Please double check you user credentials\""},{"line_number":1849,"context_line":"                             \"or privileges. %s\")"},{"line_number":1850,"context_line":"                raise exception.SecurityServiceFailedAuth(auth_msg % e.message)"},{"line_number":1851,"context_line":"            msg \u003d _(\"Failed to create CIFS server entry. %s\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"08d187d0_4e1b7da9","line":1848,"range":{"start_line":1848,"start_character":70,"end_line":1848,"end_character":71},"in_reply_to":"ee8f5e03_ed2bbf0e","updated":"2023-09-25 12:49:05.000000000","message":"Done","commit_id":"b6a6aaa8e64b31f6895f9b584854ca5d2356adca"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"8b8c4fa6884d3cfa484e6cc53e5800c01ae29d02","unresolved":true,"context_lines":[{"line_number":3655,"context_line":"            LOG.debug(\"Trying to setup CIFS server with data: %s\", body)"},{"line_number":3656,"context_line":"            self.send_request(\u0027/protocols/cifs/services\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":3657,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":3658,"context_line":"            credential_msg \u003d \"FAILURE: Could not authenticate as\""},{"line_number":3659,"context_line":"            if (e.code \u003d\u003d netapp_api.api.EAPIERROR and"},{"line_number":3660,"context_line":"                    credential_msg in e.message):"},{"line_number":3661,"context_line":"                auth_msg \u003d _(\"Failed to create CIFS server entry.\""},{"line_number":3662,"context_line":"                             \"Please double check you user settings. %s\")"},{"line_number":3663,"context_line":"                raise exception.SecurityServiceFailedAuth(auth_msg % e.message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"103e7194_6fdc77d7","line":3660,"range":{"start_line":3658,"start_character":12,"end_line":3660,"end_character":49},"updated":"2023-06-28 21:09:42.000000000","message":"From the logs provided in the bug and by commit message, looks like this covers the \"wrong password\" scenario [0], but not the \"insufficient privilege\" scenario [1], since the failure cause is different between them. The same thing applies to ZAPI change [2].\n\nDid you try to execute both scenarios to confirm that?\n\n[0] http://paste.openstack.org/show/799228\n[1] http://paste.openstack.org/show/799227\n[2] https://review.opendev.org/c/openstack/manila/+/881770/2/manila/share/drivers/netapp/dataontap/client/client_cmode.py#1727","commit_id":"7889f4147a8208b92b7cac8bd44cab992ab8d87b"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"c7ceae709a19f471a032307e06aa380cc697cba5","unresolved":true,"context_lines":[{"line_number":3655,"context_line":"            LOG.debug(\"Trying to setup CIFS server with data: %s\", body)"},{"line_number":3656,"context_line":"            self.send_request(\u0027/protocols/cifs/services\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":3657,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":3658,"context_line":"            credential_msg \u003d \"FAILURE: Could not authenticate as\""},{"line_number":3659,"context_line":"            if (e.code \u003d\u003d netapp_api.api.EAPIERROR and"},{"line_number":3660,"context_line":"                    credential_msg in e.message):"},{"line_number":3661,"context_line":"                auth_msg \u003d _(\"Failed to create CIFS server entry.\""},{"line_number":3662,"context_line":"                             \"Please double check you user settings. %s\")"},{"line_number":3663,"context_line":"                raise exception.SecurityServiceFailedAuth(auth_msg % e.message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"55b4b630_e2e1290d","line":3660,"range":{"start_line":3658,"start_character":12,"end_line":3660,"end_character":49},"in_reply_to":"103e7194_6fdc77d7","updated":"2023-09-15 11:41:20.000000000","message":"Thank you Thiago for the pointers, a condition to cover the insufficient access rights was added as well. Can you please take a look?","commit_id":"7889f4147a8208b92b7cac8bd44cab992ab8d87b"},{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"3dd177191899ecac05200af0a5d945cd820834a1","unresolved":false,"context_lines":[{"line_number":3655,"context_line":"            LOG.debug(\"Trying to setup CIFS server with data: %s\", body)"},{"line_number":3656,"context_line":"            self.send_request(\u0027/protocols/cifs/services\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":3657,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":3658,"context_line":"            credential_msg \u003d \"FAILURE: Could not authenticate as\""},{"line_number":3659,"context_line":"            if (e.code \u003d\u003d netapp_api.api.EAPIERROR and"},{"line_number":3660,"context_line":"                    credential_msg in e.message):"},{"line_number":3661,"context_line":"                auth_msg \u003d _(\"Failed to create CIFS server entry.\""},{"line_number":3662,"context_line":"                             \"Please double check you user settings. %s\")"},{"line_number":3663,"context_line":"                raise exception.SecurityServiceFailedAuth(auth_msg % e.message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"42c40a5b_1429880e","line":3660,"range":{"start_line":3658,"start_character":12,"end_line":3660,"end_character":49},"in_reply_to":"55b4b630_e2e1290d","updated":"2023-09-15 12:51:57.000000000","message":"Thanks Caique, looks good.","commit_id":"7889f4147a8208b92b7cac8bd44cab992ab8d87b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"681e12240d5100ae707fd3fc74b6cbe17c30c22d","unresolved":true,"context_lines":[{"line_number":3778,"context_line":"        try:"},{"line_number":3779,"context_line":"            LOG.debug(\"Trying to setup CIFS server with data: %s\", body)"},{"line_number":3780,"context_line":"            self.send_request(\u0027/protocols/cifs/services\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":3781,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":3782,"context_line":"            credential_msg \u003d \"FAILURE: Could not authenticate as\""},{"line_number":3783,"context_line":"            privilege_msg \u003d \"The user has insufficient access\""},{"line_number":3784,"context_line":"            if (e.code \u003d\u003d netapp_api.api.EAPIERROR and ("},{"line_number":3785,"context_line":"                    credential_msg in e.message or"},{"line_number":3786,"context_line":"                    privilege_msg in e.message)):"},{"line_number":3787,"context_line":"                auth_msg \u003d _(\"Failed to create CIFS server entry.\""},{"line_number":3788,"context_line":"                             \"Please double check you user credentials\""},{"line_number":3789,"context_line":"                             \"or privileges. %s\")"},{"line_number":3790,"context_line":"                raise exception.SecurityServiceFailedAuth(auth_msg % e.message)"},{"line_number":3791,"context_line":"            msg \u003d _(\"Failed to create CIFS server entry. %s\")"},{"line_number":3792,"context_line":"            raise exception.NetAppException(msg % e.message)"},{"line_number":3793,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"58733d96_ad87ebfc","line":3790,"range":{"start_line":3781,"start_character":46,"end_line":3790,"end_character":79},"updated":"2023-09-22 16:18:31.000000000","message":"same comments as in the prior file; please check the trailing spaces in each line..","commit_id":"b6a6aaa8e64b31f6895f9b584854ca5d2356adca"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"0512a1ed5fe398d27423b912cf7cc92f9f3b92ad","unresolved":false,"context_lines":[{"line_number":3778,"context_line":"        try:"},{"line_number":3779,"context_line":"            LOG.debug(\"Trying to setup CIFS server with data: %s\", body)"},{"line_number":3780,"context_line":"            self.send_request(\u0027/protocols/cifs/services\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":3781,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":3782,"context_line":"            credential_msg \u003d \"FAILURE: Could not authenticate as\""},{"line_number":3783,"context_line":"            privilege_msg \u003d \"The user has insufficient access\""},{"line_number":3784,"context_line":"            if (e.code \u003d\u003d netapp_api.api.EAPIERROR and ("},{"line_number":3785,"context_line":"                    credential_msg in e.message or"},{"line_number":3786,"context_line":"                    privilege_msg in e.message)):"},{"line_number":3787,"context_line":"                auth_msg \u003d _(\"Failed to create CIFS server entry.\""},{"line_number":3788,"context_line":"                             \"Please double check you user credentials\""},{"line_number":3789,"context_line":"                             \"or privileges. %s\")"},{"line_number":3790,"context_line":"                raise exception.SecurityServiceFailedAuth(auth_msg % e.message)"},{"line_number":3791,"context_line":"            msg \u003d _(\"Failed to create CIFS server entry. %s\")"},{"line_number":3792,"context_line":"            raise exception.NetAppException(msg % e.message)"},{"line_number":3793,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"cf0d4099_5e69d6c8","line":3790,"range":{"start_line":3781,"start_character":46,"end_line":3790,"end_character":79},"in_reply_to":"58733d96_ad87ebfc","updated":"2023-09-25 12:49:05.000000000","message":"Done","commit_id":"b6a6aaa8e64b31f6895f9b584854ca5d2356adca"}],"manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode_rest.py":[{"author":{"_account_id":35677,"name":"Thiago José de Andrade Alvoravel","display_name":"Thiago Alvoravel","email":"thiago.andrade@fit-tecnologia.org.br","username":"thiagoalvoravel"},"change_message_id":"8b8c4fa6884d3cfa484e6cc53e5800c01ae29d02","unresolved":true,"context_lines":[{"line_number":5488,"context_line":"    @ddt.data(fake.CIFS_SECURITY_SERVICE, fake.CIFS_SECURITY_SERVICE_3)"},{"line_number":5489,"context_line":"    def test_configure_active_directory_credential_error(self,"},{"line_number":5490,"context_line":"                                                         security_service):"},{"line_number":5491,"context_line":"        msg \u003d \"FAILURE: Could not authenticate as\""},{"line_number":5492,"context_line":"        fake_security \u003d copy.deepcopy(security_service)"},{"line_number":5493,"context_line":""},{"line_number":5494,"context_line":"        self.mock_object(self.client, \u0027configure_dns\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0303d82f_50d42b2f","line":5491,"updated":"2023-06-28 21:09:42.000000000","message":"If is missing treating \"insufficient privilege\" scenario from bug, will need covers it too as well (REST and ZAPI).","commit_id":"7889f4147a8208b92b7cac8bd44cab992ab8d87b"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"c7ceae709a19f471a032307e06aa380cc697cba5","unresolved":false,"context_lines":[{"line_number":5488,"context_line":"    @ddt.data(fake.CIFS_SECURITY_SERVICE, fake.CIFS_SECURITY_SERVICE_3)"},{"line_number":5489,"context_line":"    def test_configure_active_directory_credential_error(self,"},{"line_number":5490,"context_line":"                                                         security_service):"},{"line_number":5491,"context_line":"        msg \u003d \"FAILURE: Could not authenticate as\""},{"line_number":5492,"context_line":"        fake_security \u003d copy.deepcopy(security_service)"},{"line_number":5493,"context_line":""},{"line_number":5494,"context_line":"        self.mock_object(self.client, \u0027configure_dns\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b62fd5f_e8befa71","line":5491,"in_reply_to":"0303d82f_50d42b2f","updated":"2023-09-15 11:41:20.000000000","message":"Done","commit_id":"7889f4147a8208b92b7cac8bd44cab992ab8d87b"}],"releasenotes/notes/bug-1900755-netapp-add-exception-cifs-creation-error-user-privileges-or-credentials.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"74ead75e7759517155748d6a96aa58b160749804","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1900755 \u003chttps://bugs.launchpad.net/manila/+bug/1900755\u003e`_:"},{"line_number":5,"context_line":"    Added raising exception in NetApp driver when trying to create a share"},{"line_number":6,"context_line":"    using a security service with insufficient privileges or wrong credentials."},{"line_number":7,"context_line":"    Added an user message to provide a cleary information to users."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6e82a8b1_7f2db74a","line":5,"updated":"2023-09-18 14:18:09.000000000","message":"I believe this is too much implementation detail for a release note... We should keep this to a level where the end users would not read things related to the implementation... So my suggestion would be:\n```\n`Bug #1900755 \u003chttps://bugs.launchpad.net/manila/+bug/1900755\u003e`_:\nWhen failing to create shares using security services due to insufficient  privileges or wrong credentials, the NetApp ONTAP driver will now report\nmore accurate information on the failure.\n```","commit_id":"ac23ff9d66141c5a469e31e8e7336fbfe9bbbc19"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"d2e550b856737196b68a2bfe13ff42d0a1308bcc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1900755 \u003chttps://bugs.launchpad.net/manila/+bug/1900755\u003e`_:"},{"line_number":5,"context_line":"    Added raising exception in NetApp driver when trying to create a share"},{"line_number":6,"context_line":"    using a security service with insufficient privileges or wrong credentials."},{"line_number":7,"context_line":"    Added an user message to provide a cleary information to users."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"043be3d9_3a4c8cc3","line":5,"in_reply_to":"6e82a8b1_7f2db74a","updated":"2023-09-18 17:56:05.000000000","message":"Done","commit_id":"ac23ff9d66141c5a469e31e8e7336fbfe9bbbc19"}]}